kmx git

Commit	Date	Message
0479df53	2023-01-09T09:48:21	Updated copyright for 2023
d59caffe	2022-12-13T14:03:40	Added support for clang thread-safety analysis The annotations have been added to SDL_mutex.h and have been made public so applications can enable this for their own code. Clang assumes that locking and unlocking can't fail, but SDL has the concept of a NULL mutex, so the mutex functions have been changed not to report errors if a mutex hasn't been initialized. We do have mutexes that might be accessed when they are NULL, notably in the event system, so this is an important change. This commit cleans up a bunch of rare race conditions in the joystick and game controller code so now everything should be completely protected by the joystick lock. To test this, change the compiler to "clang -Wthread-safety -Werror=thread-safety -DSDL_THREAD_SAFETY_ANALYSIS"
d0bbfdbf	2022-12-01T16:07:03	Clang-Tidy fixes (#6725) (cherry picked from commit 3c501b963dd8f0605a6ce7978882df39ba76f9cd)
b8d85c69	2022-11-30T12:51:59	Update for SDL3 coding style (#6717) I updated .clang-format and ran clang-format 14 over the src and test directories to standardize the code base. In general I let clang-format have it's way, and added markup to prevent formatting of code that would break or be completely unreadable if formatted. The script I ran for the src directory is added as build-scripts/clang-format-src.sh This fixes: #6592 #6593 #6594 (cherry picked from commit 5750bcb174300011b91d1de20edb288fcca70f8c)
fb0ce375	2022-11-27T17:38:43	Cleanup add brace (#6545) * Add braces after if conditions * More add braces after if conditions * Add braces after while() conditions * Fix compilation because of macro being modified * Add braces to for loop * Add braces after if/goto * Move comments up * Remove extra () in the 'return ...;' statements * More remove extra () in the 'return ...;' statements * More remove extra () in the 'return ...;' statements after merge * Fix inconsistent patterns are xxx == NULL vs !xxx * More "{}" for "if() break;" and "if() continue;" * More "{}" after if() short statement * More "{}" after "if () return;" statement * More fix inconsistent patterns are xxx == NULL vs !xxx * Revert some modificaion on SDL_RLEaccel.c * SDL_RLEaccel: no short statement * Cleanup 'if' where the bracket is in a new line * Cleanup 'while' where the bracket is in a new line * Cleanup 'for' where the bracket is in a new line * Cleanup 'else' where the bracket is in a new line (cherry picked from commit 6a2200823c66e53bd3cda4a25f0206b834392652 to reduce conflicts merging between SDL2 and SDL3)
7d536d52	2022-11-14T16:16:21	N3DS: Put `SDL_Log.txt` in the proper directory. The homebrew "user" directory should be `/3ds/`. To avoid ambiguity, `sdmc:` is specified.
65527537	2021-03-30T04:32:39	N3DS port (squashed) A dedicated renderer using Citro3D would likely allow for better much better graphical performances.
5892ed43	2022-09-16T09:44:39	Fixed Xcode warnings on macOS
ad0b9130	2022-07-05T22:29:43	android: Add missing entries to SDL_category_prefixes table. Add static assert so this shouldn't happen in the future. Fixes #5883
3b191580	2022-06-27T17:19:39	Windows GDK Support (#5830) * Added GDK * Simplfied checks in SDL_config_wingdk.h * Added testgdk sample * Added GDK readme * Fixed error in merge of SDL_windows.h * Additional GDK fixes * OpenWatcom should not export _SDL_GDKGetTaskQueue * Formatting fixes * Moved initialization code into SDL_GDKRunApp
e4409f67	2022-06-06T00:05:20	Include SDL_Log driver
f7280dce	2022-05-10T14:52:14	log: Check for integer overflow.
8cd908e0	2022-05-06T10:51:55	Fixed building with Visual Studio 2013 Added SDL_vacopy.h since it needs to be included after Windows headers
88889924	2022-04-29T16:30:30	log: Allow log messages of any length. Log messages are no longer truncated to SDL_MAX_LOG_MESSAGE.
645db217	2022-04-29T14:06:05	log: Use malloc for long messages. For short messages, use a stack buffer that is significantly smaller than SDL_MAX_LOG_MESSAGE. The rationale for this is that we don't want to risk blowing the stack, while at the same time we would like to not put pressure on the memory allocator unless absolutely necessary.
7e636b03	2022-04-29T10:16:14	Removed log message length limitation for Apple platforms This works in conjunction with https://github.com/libsdl-org/SDL/pull/5584
a0cdc1fc	2022-04-28T15:01:34	Added declaration of SDL_LogInit() and SDL_LogQuit() Fixes compile warning on Android
0f45a4e3	2022-04-27T12:22:37	log: Don't try to SDL_free the static array. :) I shouldn't be allowed near computers, I swear.
31e83cd1	2022-04-27T12:13:44	log: Fixed build (sorry!)
fde9a708	2022-04-27T12:05:07	log: Make the message buffer static. Now we don't have to worry about allocation failure, or performance issues or changes to the allocation layout when trying to track down subtle bugs.
c4141bc1	2022-04-27T09:39:24	log: Wrap the call to the logging implementation in a mutex. Fixes #2463.
2a429522	2022-04-27T08:06:28	log: Don't stack-allocate the message buffer. It's 4 kilobytes, so I could see this failing if you have a thread with a tiny stack that unexpectedly logs something.
120c76c8	2022-01-03T09:40:00	Updated copyright for 2022
ed6ce5cc	2021-08-04T02:34:09	log: Fixed compiler warnings on 64-bit Visual Studio.
2d64e37e	2020-11-02T18:09:43	Initial rebase of xerpi's port
391bb80b	2021-03-05T16:53:06	Replace duplicate functions and lstrlen/lstrcat with SDL string functions
9130f7c3	2021-01-02T10:25:38	Updated copyright for 2021
a8780c6a	2020-01-16T20:49:25	Updated copyright date for 2020
bf9bf602	2019-07-17T23:20:57	Copypaste SDL_NSLog to UIKit backend, document it as such
5e13087b	2019-01-04T22:01:14	Updated copyright for 2019
b262b0eb	2018-10-22T20:50:32	Small stack allocations fall back to malloc if they're unexpectedly large.
e3cc5b2c	2018-01-03T10:03:25	Updated copyright for 2018
7914725b	2017-12-04T20:26:09	Removed spurious debug output
5a735da9	2017-12-04T19:28:03	Fixed SDL_Log not working on windows if the output is being redirected.
de91b124	2017-08-14T06:28:21	Fixed bug 3745 - specify SDLCALL as the calling convention for API callbacks Patches contributed by Ozkan Sezer
45b774e3	2017-01-01T18:33:28	Updated copyright for 2017
91491824	2016-12-07T11:02:02	Removed unneeded warning when running from Visual Studio
abe92710	2016-11-20T21:29:27	Fixed warning building under mingw, patch contributed by Sylvain
6f11545a	2016-10-01T12:28:05	Fixed bug 3323 - SDL_LogOutput prints message twice on Windows when linked with libc Simon Hug If SDL2 is compiled with HAVE_LIBC on Windows, the SDL_LogOutput function has two ways of printing a message. WriteConsole and fprintf.
42065e78	2016-01-02T10:10:34	Updated copyright to 2016
16e18817	2015-07-16T21:31:21	Windows: Fixed wrong debugger output if logging empty string as info or warning.
0e45984f	2015-06-21T17:33:46	Fixed crash if initialization of EGL failed but was tried again later. The internal function SDL_EGL_LoadLibrary() did not delete and remove a mostly uninitialized data structure if loading the library first failed. A later try to use EGL then skipped initialization and assumed it was previously successful because the data structure now already existed. This led to at least one crash in the internal function SDL_EGL_ChooseConfig() because a NULL pointer was dereferenced to make a call to eglBindAPI().
2c4a6ea0	2015-05-26T06:27:46	Updated the copyright year to 2015
b72938c8	2015-04-20T12:22:44	Windows: Always set the system timer resolution to 1ms by default. An existing hint lets apps that don't need the timer resolution changed avoid this, to save battery, etc, but this fixes several problems in timing, audio callbacks not firing fast enough, etc. Fixes Bugzilla #2944.
fe6c797c	2015-04-10T23:30:31	Fixed an iOS view orientation issue when SDL_GL_CreateContext or SDL_CreateRenderer is called.
b88ca1b4	2015-02-10T16:28:56	the last parameter of XChangeProperty is the number of elements.. and when the element format is 32.. the element is "long" so we have 5 long elements here. Yes this seems confusing as on mac+linux Long is either 32 or 64bits depending on the architecture, but this is how the X11 protocol is defined. Thus 5 is the correct value for the nelts here. Not 5 or 10 depending on the architecture. More info on the confusion https://bugs.freedesktop.org/show_bug.cgi?id=16802
b48e54aa	2015-01-26T22:00:29	Fixed bug 2802 - [patch] Fix android build compiling in wrong filesystem implementation Jonas Kulla The configure script didn't differentiate between Linux and Android, unconditionally compiling in the unix implementation of SDL_sysfilesystem.c. I'm probably one of the very few people building SDL for android using classic configure + standalone toolchain, so this has gone undetected all along.
70438be2	2014-12-03T10:55:23	WinRT: fixed bug whereby SDL would override an app's default orientation WinRT apps can set a default, preferred orientation via a .appxmanifest file. SDL was overriding this on app startup, and making the app use all possible orientations (landscape and portrait). Thanks to Eric Wing for the heads up on this!
9c398852	2014-11-22T22:20:40	Corrected header file documentation comment.
24c86b55	2014-09-11T19:24:42	[X11] Reconcile logical keyboard state with physical state on FocusIn since the window system doesn't do it for us like other platforms. This prevents sticky keys and missed keys when going in and out of focus, for example Alt would appear to stick if switching away from an SDL app with Alt-Tab and had to be pressed again. CR: Sam
1e352d79	2014-06-06T15:45:59	Chrome's Native Client backend implementation
da6d9a9f	2014-06-04T10:56:56	Added annotations to help code analysis tools CR: Bruce Dawson
3dcb451f	2014-04-09T21:29:19	Added a README file regarding WinRT support To note, this file is currently formatted with CRLF line endings, rather than LF, to allow the file to be viewed with Notepad.
1367bf87	2014-03-09T11:36:47	Integrated David Ludwig's support for Windows RT
05c23063	2014-03-09T11:06:11	Fixed line endings on WinRT source code
58edac3e	2014-02-02T00:53:27	Fixed bug 2374 - Update copyright for 2014... Is it that time already??
f848adff	2013-11-29T10:06:08	Improve Android pause/resume behavior.
7e1289af	2013-11-24T23:56:17	Make internal SDL sources include SDL_internal.h instead of SDL_config.h The new header will include SDL_config.h, but allows for other global stuff.
1704af5b	2013-10-27T23:03:11	WinRT: build fixes, post SDL 2.0.1 update
69c5d21d	2013-10-27T21:26:46	WinRT: merged with SDL 2.0.1 codebase
12ca3ce3	2013-10-17T23:02:29	Fixed building using MinGW Our SDL_windows.h needed to be included before anything else so UNICODE is defined.
48aca0b2	2013-09-05T06:43:34	Fixed bug 2084 - SDL_log xxx on Android outputs to Logcat with incorrect priority. Pallav Nawani This effects all SDL_Logxxx functions. On android, the debug output has a priority that is 1 higher than intended, ie, if you try SDL_LogInfo, the log has the priority of Warn instead.
2538d311	2013-08-28T22:05:16	Fix endlines for logging via OutputDebugString().
d41fdc94	2013-08-13T20:09:52	WinRT: build fixes and additional WinRT-related integrations with SDL 2.0.0
f7049b93	2013-08-12T22:29:55	WinRT: merged with SDL 2.0.0 codebase (aka. SDL hg rev d4ce48ff30d1)
dad42067	2013-08-12T11:13:50	Fixes #2022, do not resume on Android when surfaceChanged If the app is in landscape mode and the user presses the power button, a pause is followed immediately by a surfaceChanged event because the lock screen is shown in portrait mode. This triggers a "false" resume. So, we just pause and resume following the onWindowFocusChanged events. Also, wait for SDL_APP_WILLENTERBACKGROUND and SDL_APP_DIDENTERBACKGROUND before blocking the event pump.
1ad936eb	2013-08-11T19:56:43	Fixed bug 2027 - Full-screen appears to be broken - hang in SDL_DestroyWindow() Rainer Deyke I'm running Linux Mint 15 with the Cinnamon window manager. SDL_DestroyWindow consistently locks up for me when the window if fullscreen.

0479df53

2023-01-09T09:48:21

Updated copyright for 2023

d59caffe

2022-12-13T14:03:40

Added support for clang thread-safety analysis The annotations have been added to SDL_mutex.h and have been made public so applications can enable this for their own code. Clang assumes that locking and unlocking can't fail, but SDL has the concept of a NULL mutex, so the mutex functions have been changed not to report errors if a mutex hasn't been initialized. We do have mutexes that might be accessed when they are NULL, notably in the event system, so this is an important change. This commit cleans up a bunch of rare race conditions in the joystick and game controller code so now everything should be completely protected by the joystick lock. To test this, change the compiler to "clang -Wthread-safety -Werror=thread-safety -DSDL_THREAD_SAFETY_ANALYSIS"

d0bbfdbf

2022-12-01T16:07:03

Clang-Tidy fixes (#6725) (cherry picked from commit 3c501b963dd8f0605a6ce7978882df39ba76f9cd)

b8d85c69

2022-11-30T12:51:59

Update for SDL3 coding style (#6717) I updated .clang-format and ran clang-format 14 over the src and test directories to standardize the code base. In general I let clang-format have it's way, and added markup to prevent formatting of code that would break or be completely unreadable if formatted. The script I ran for the src directory is added as build-scripts/clang-format-src.sh This fixes: #6592 #6593 #6594 (cherry picked from commit 5750bcb174300011b91d1de20edb288fcca70f8c)

fb0ce375

2022-11-27T17:38:43

Cleanup add brace (#6545) * Add braces after if conditions * More add braces after if conditions * Add braces after while() conditions * Fix compilation because of macro being modified * Add braces to for loop * Add braces after if/goto * Move comments up * Remove extra () in the 'return ...;' statements * More remove extra () in the 'return ...;' statements * More remove extra () in the 'return ...;' statements after merge * Fix inconsistent patterns are xxx == NULL vs !xxx * More "{}" for "if() break;" and "if() continue;" * More "{}" after if() short statement * More "{}" after "if () return;" statement * More fix inconsistent patterns are xxx == NULL vs !xxx * Revert some modificaion on SDL_RLEaccel.c * SDL_RLEaccel: no short statement * Cleanup 'if' where the bracket is in a new line * Cleanup 'while' where the bracket is in a new line * Cleanup 'for' where the bracket is in a new line * Cleanup 'else' where the bracket is in a new line (cherry picked from commit 6a2200823c66e53bd3cda4a25f0206b834392652 to reduce conflicts merging between SDL2 and SDL3)

7d536d52

2022-11-14T16:16:21

N3DS: Put `SDL_Log.txt` in the proper directory. The homebrew "user" directory should be `/3ds/`. To avoid ambiguity, `sdmc:` is specified.

65527537

2021-03-30T04:32:39

N3DS port (squashed) A dedicated renderer using Citro3D would likely allow for better much better graphical performances.

5892ed43

2022-09-16T09:44:39

Fixed Xcode warnings on macOS

ad0b9130

2022-07-05T22:29:43

android: Add missing entries to SDL_category_prefixes table. Add static assert so this shouldn't happen in the future. Fixes #5883

3b191580

2022-06-27T17:19:39

Windows GDK Support (#5830) * Added GDK * Simplfied checks in SDL_config_wingdk.h * Added testgdk sample * Added GDK readme * Fixed error in merge of SDL_windows.h * Additional GDK fixes * OpenWatcom should not export _SDL_GDKGetTaskQueue * Formatting fixes * Moved initialization code into SDL_GDKRunApp

e4409f67

2022-06-06T00:05:20

Include SDL_Log driver

f7280dce

2022-05-10T14:52:14

log: Check for integer overflow.

8cd908e0

2022-05-06T10:51:55

Fixed building with Visual Studio 2013 Added SDL_vacopy.h since it needs to be included after Windows headers

88889924

2022-04-29T16:30:30

log: Allow log messages of any length. Log messages are no longer truncated to SDL_MAX_LOG_MESSAGE.

645db217

2022-04-29T14:06:05

log: Use malloc for long messages. For short messages, use a stack buffer that is significantly smaller than SDL_MAX_LOG_MESSAGE. The rationale for this is that we don't want to risk blowing the stack, while at the same time we would like to not put pressure on the memory allocator unless absolutely necessary.

7e636b03

2022-04-29T10:16:14

Removed log message length limitation for Apple platforms This works in conjunction with https://github.com/libsdl-org/SDL/pull/5584

a0cdc1fc

2022-04-28T15:01:34

Added declaration of SDL_LogInit() and SDL_LogQuit() Fixes compile warning on Android

0f45a4e3

2022-04-27T12:22:37

log: Don't try to SDL_free the static array. :) I shouldn't be allowed near computers, I swear.

31e83cd1

2022-04-27T12:13:44

log: Fixed build (sorry!)

fde9a708

2022-04-27T12:05:07

log: Make the message buffer static. Now we don't have to worry about allocation failure, or performance issues or changes to the allocation layout when trying to track down subtle bugs.

c4141bc1

2022-04-27T09:39:24

log: Wrap the call to the logging implementation in a mutex. Fixes #2463.

2a429522

2022-04-27T08:06:28

log: Don't stack-allocate the message buffer. It's 4 kilobytes, so I could see this failing if you have a thread with a tiny stack that unexpectedly logs something.

120c76c8

2022-01-03T09:40:00

Updated copyright for 2022

ed6ce5cc

2021-08-04T02:34:09

log: Fixed compiler warnings on 64-bit Visual Studio.

2d64e37e

2020-11-02T18:09:43

Initial rebase of xerpi's port

391bb80b

2021-03-05T16:53:06

Replace duplicate functions and lstrlen/lstrcat with SDL string functions

9130f7c3

2021-01-02T10:25:38

Updated copyright for 2021

a8780c6a

2020-01-16T20:49:25

Updated copyright date for 2020

bf9bf602

2019-07-17T23:20:57

Copypaste SDL_NSLog to UIKit backend, document it as such

5e13087b

2019-01-04T22:01:14

Updated copyright for 2019

b262b0eb

2018-10-22T20:50:32

Small stack allocations fall back to malloc if they're unexpectedly large.

e3cc5b2c

2018-01-03T10:03:25

Updated copyright for 2018

7914725b

2017-12-04T20:26:09

Removed spurious debug output

5a735da9

2017-12-04T19:28:03

Fixed SDL_Log not working on windows if the output is being redirected.

de91b124

2017-08-14T06:28:21

Fixed bug 3745 - specify SDLCALL as the calling convention for API callbacks Patches contributed by Ozkan Sezer

45b774e3

2017-01-01T18:33:28

Updated copyright for 2017

91491824

2016-12-07T11:02:02

Removed unneeded warning when running from Visual Studio

abe92710

2016-11-20T21:29:27

Fixed warning building under mingw, patch contributed by Sylvain

6f11545a

2016-10-01T12:28:05

Fixed bug 3323 - SDL_LogOutput prints message twice on Windows when linked with libc Simon Hug If SDL2 is compiled with HAVE_LIBC on Windows, the SDL_LogOutput function has two ways of printing a message. WriteConsole and fprintf.

42065e78

2016-01-02T10:10:34

Updated copyright to 2016

16e18817

2015-07-16T21:31:21

Windows: Fixed wrong debugger output if logging empty string as info or warning.

0e45984f

2015-06-21T17:33:46

Fixed crash if initialization of EGL failed but was tried again later. The internal function SDL_EGL_LoadLibrary() did not delete and remove a mostly uninitialized data structure if loading the library first failed. A later try to use EGL then skipped initialization and assumed it was previously successful because the data structure now already existed. This led to at least one crash in the internal function SDL_EGL_ChooseConfig() because a NULL pointer was dereferenced to make a call to eglBindAPI().

2c4a6ea0

2015-05-26T06:27:46

Updated the copyright year to 2015

b72938c8

2015-04-20T12:22:44

Windows: Always set the system timer resolution to 1ms by default. An existing hint lets apps that don't need the timer resolution changed avoid this, to save battery, etc, but this fixes several problems in timing, audio callbacks not firing fast enough, etc. Fixes Bugzilla #2944.

fe6c797c

2015-04-10T23:30:31

Fixed an iOS view orientation issue when SDL_GL_CreateContext or SDL_CreateRenderer is called.

b88ca1b4

2015-02-10T16:28:56

the last parameter of XChangeProperty is the number of elements.. and when the element format is 32.. the element is "long" so we have 5 long elements here. Yes this seems confusing as on mac+linux Long is either 32 or 64bits depending on the architecture, but this is how the X11 protocol is defined. Thus 5 is the correct value for the nelts here. Not 5 or 10 depending on the architecture. More info on the confusion https://bugs.freedesktop.org/show_bug.cgi?id=16802

b48e54aa

2015-01-26T22:00:29

Fixed bug 2802 - [patch] Fix android build compiling in wrong filesystem implementation Jonas Kulla The configure script didn't differentiate between Linux and Android, unconditionally compiling in the unix implementation of SDL_sysfilesystem.c. I'm probably one of the very few people building SDL for android using classic configure + standalone toolchain, so this has gone undetected all along.

70438be2

2014-12-03T10:55:23

WinRT: fixed bug whereby SDL would override an app's default orientation WinRT apps can set a default, preferred orientation via a .appxmanifest file. SDL was overriding this on app startup, and making the app use all possible orientations (landscape and portrait). Thanks to Eric Wing for the heads up on this!

9c398852

2014-11-22T22:20:40

Corrected header file documentation comment.

24c86b55

2014-09-11T19:24:42

[X11] Reconcile logical keyboard state with physical state on FocusIn since the window system doesn't do it for us like other platforms. This prevents sticky keys and missed keys when going in and out of focus, for example Alt would appear to stick if switching away from an SDL app with Alt-Tab and had to be pressed again. CR: Sam

1e352d79

2014-06-06T15:45:59

Chrome's Native Client backend implementation

da6d9a9f

2014-06-04T10:56:56

Added annotations to help code analysis tools CR: Bruce Dawson

3dcb451f

2014-04-09T21:29:19

Added a README file regarding WinRT support To note, this file is currently formatted with CRLF line endings, rather than LF, to allow the file to be viewed with Notepad.

1367bf87

2014-03-09T11:36:47

Integrated David Ludwig's support for Windows RT

05c23063

2014-03-09T11:06:11

Fixed line endings on WinRT source code

58edac3e

2014-02-02T00:53:27

f848adff

2013-11-29T10:06:08

Improve Android pause/resume behavior.

7e1289af

2013-11-24T23:56:17

Make internal SDL sources include SDL_internal.h instead of SDL_config.h The new header will include SDL_config.h, but allows for other global stuff.

1704af5b

2013-10-27T23:03:11

WinRT: build fixes, post SDL 2.0.1 update

69c5d21d

2013-10-27T21:26:46

WinRT: merged with SDL 2.0.1 codebase

12ca3ce3

2013-10-17T23:02:29

Fixed building using MinGW Our SDL_windows.h needed to be included before anything else so UNICODE is defined.

48aca0b2

2013-09-05T06:43:34

Fixed bug 2084 - SDL_log xxx on Android outputs to Logcat with incorrect priority. Pallav Nawani This effects all SDL_Logxxx functions. On android, the debug output has a priority that is 1 higher than intended, ie, if you try SDL_LogInfo, the log has the priority of Warn instead.

2538d311

2013-08-28T22:05:16

Fix endlines for logging via OutputDebugString().

d41fdc94

2013-08-13T20:09:52

WinRT: build fixes and additional WinRT-related integrations with SDL 2.0.0

f7049b93

2013-08-12T22:29:55

WinRT: merged with SDL 2.0.0 codebase (aka. SDL hg rev d4ce48ff30d1)

dad42067

2013-08-12T11:13:50

Fixes #2022, do not resume on Android when surfaceChanged If the app is in landscape mode and the user presses the power button, a pause is followed immediately by a surfaceChanged event because the lock screen is shown in portrait mode. This triggers a "false" resume. So, we just pause and resume following the onWindowFocusChanged events. Also, wait for SDL_APP_WILLENTERBACKGROUND and SDL_APP_DIDENTERBACKGROUND before blocking the event pump.

1ad936eb

2013-08-11T19:56:43

Fixed bug 2027 - Full-screen appears to be broken - hang in SDL_DestroyWindow() Rainer Deyke I'm running Linux Mint 15 with the Cinnamon window manager. SDL_DestroyWindow consistently locks up for me when the window if fullscreen.

kc3-lang/SDL/src/SDL_log.c

src/SDL_log.c

Log