|
3f647b1b
|
2019-11-09T16:24:50
|
|
Vulkan: Improve Bresenham line emulation.
Clamps the vertex position to the subpixel grid before interpolation.
This will give more correct results on systems that have less than
8 bits of subpixel accuracy.
Also uses a more accurate formulation for the emulation filter in the
fragment shader using dfdx and dfdy.
Fixes line raster CTS tests on SwiftShader. Still does not produce spec
conformant lines. Updates the public docs to indicate this.
Bug: angleproject:2830
Change-Id: Ib9a268df3e7d986bd2b1348be664389fe8fc0ef2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1826598
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
b9b1bae4
|
2019-11-12T07:01:24
|
|
Roll third_party/spirv-tools/src 3e4abc9ac382..12e54dae167c (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3e4abc9ac382..12e54dae167c
Created with:
gclient setdep -r third_party/spirv-tools/src@12e54dae167c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=cnorthrop@google.com
Change-Id: I25c0aa854a5d44c9f517de60603c3014a3b7a95f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1910782
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
867f8c92
|
2019-11-12T07:01:31
|
|
Roll third_party/SwiftShader 31edef751a8d..9da287fd0264 (6 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/31edef751a8d..9da287fd0264
git log 31edef751a8d..9da287fd0264 --date=short --no-merges --format='%ad %ae %s'
2019-11-11 timvp@google.com Output Swiftshader version to logcat
2019-11-11 chrisforbes@google.com Allow depth/stencil attachment to be VK_ATTACHMENT_UNUSED in clear
2019-11-11 swiftshader.regress@gmail.com Regres: Update test lists @ 414f99e0
2019-11-11 chrisforbes@google.com Relax descriptor set index assert at descriptor point of definition
2019-11-11 sugoi@google.com Avoid sync issues by removing global android swapchain map
2019-11-11 bclayton@google.com Regres: Check out the change before attempting to read files from it.
Created with:
gclient setdep -r third_party/SwiftShader@9da287fd0264
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=cnorthrop@google.com
Change-Id: I27defe08fe427a2fe8eec29bd49c35dcae411383
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1910783
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
e33c1582
|
2019-11-06T16:55:29
|
|
Fix EXT_texture_norm16
* Add norm16 format info for OpenGL backend
* Add validation for newly introduced norm16 formats
* Fix some logic of texture tests
Bug: chromium:1000354, angleproject:1365
Change-Id: Ie6d6e5e276da4df4b7c667be28d324d4976b35ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1902720
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
|
|
|
82fd2540
|
2019-11-11T10:46:17
|
|
Windows: Use Job handle in LaunchProcess.
This forces all child processes to quit when the parent process is
unexpectedly terminated.
Disabled on Windows 7 because it seems to fail with assinging the
process to the job object. Possibly because of permission conflicts
with the Chromium base/test launcher.
Bug: angleproject:3162
Change-Id: I35f1c1ac5c802904b9b7220cab1bafce1ae0ea15
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1862989
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
f18ff947
|
2019-11-09T23:01:47
|
|
Minor tweaks to SampleApplication.
Removes an unreferenced function. Also adds the ability for samples to
respond to key up and down events. Only implemented on Windows.
Bug: angleproject:2830
Change-Id: I44c9f93f0ad07b92923ffc0efa580f97d9b98693
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1908448
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
1abb0dd1
|
2019-11-11T00:07:59
|
|
Add Metal progress to README
Just to let users of ANGLE aware of
Bug: angleproject:2634
Change-Id: I241ed569a967e8c427cb5cc2e6d82c73c17e320c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906621
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
1c7097b6
|
2019-11-11T07:01:30
|
|
Roll third_party/SwiftShader d9ed1c2732ba..31edef751a8d (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d9ed1c2732ba..31edef751a8d
git log d9ed1c2732ba..31edef751a8d --date=short --no-merges --format='%ad %ae %s'
2019-11-09 chrisforbes@google.com Update deqp to vulkan-cts-1.1.6.1
2019-11-08 chrisforbes@google.com Fix PointCoord builtin
2019-11-08 bclayton@google.com Kokoro: Allow 'Fixes:' in bug check
Created with:
gclient setdep -r third_party/SwiftShader@31edef751a8d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: Id5d4e11721e8d64f0434e6fd58c178419c31e327
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1909434
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
02eeebf1
|
2019-11-11T07:01:25
|
|
Roll third_party/spirv-tools/src 041f0a02493d..3e4abc9ac382 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/041f0a02493d..3e4abc9ac382
Created with:
gclient setdep -r third_party/spirv-tools/src@3e4abc9ac382
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: Ic814942250eea97d3370bf18eb5947941e22188f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1909433
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
012d1519
|
2019-10-31T16:50:23
|
|
Stop using __has_include<Cocoa/Cocoa.h>
__has_include seems to cause problems with goma builds.
Instead, detect iOS vs MacOS using TargetConditionals.h. Also use
plain C++ instead of Objective-C++ when possible.
Bug: angleproject:3439
Bug: 1015591
Change-Id: I816624e0cdc54ad3a18d3891b4efecf6fe640574
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1894243
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
|
|
|
5c0e6e52
|
2019-11-08T17:05:38
|
|
Capture/Replay: Implement more state for mid-execution replay.
Includes much more state serialization. Notably Vertex Arrays were
missing as well as multiple GL render states. Also fixes many
serialization bugs. For example, we would not be using the correct
client array and pack/unpack state in the mid-execution capture. Also
depth/stencil attachments were missing from the capture.
Also fixes the replay sample to work with non-zero starting frames.
With these fixes we can run mid-execution replay of the T-Rex demo.
Bug: angleproject:3611
Change-Id: I6945eb9b30a5137be996956b43f074a0a750b333
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1895112
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
405d4cf3
|
2019-11-09T02:28:49
|
|
Metal: multiple bug fixes
- ContextMtl: triangle fan draws should call setupDraw() with original
parameters. Not the modified parameters.
- SurfaceMtl: should initialize metal layer's drawableSize after layer's
creation.
- TextureMtl & FrameBufferMtl: Fix texture copySubImage CPU path
incorrectly copied unflipped area.
- mtl_render_utils: Fix wrong variable name used for trifan compute
pipeline cache table.
- mtl_resources: Fix texture & buffer memory leaks due to missing
ANGLE_MTL_AUTORELEASE.
- mtl_utils: Fix viewport flipping error due to arithmetic between
unsigned & signed values.
These bugs were discovered during dEQP tests running.
Bug: angleproject:2634
Change-Id: Ie01380910ab68a2b876718d9dac0b5b4c41b607c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906608
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
c2f1f618
|
2019-10-28T13:06:42
|
|
Always use MTLPixelFormatBGRA8Unorm for SurfaceMtl.
Apple Features Table says BGRA8 is not always available but it turned
out not the case based on response from Apple dev.
Bug: angleproject:2634
Change-Id: I9e3465420f45fcd362cbdd385bb78169463a759d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906606
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
60a396a8
|
2019-11-07T16:36:45
|
|
Reset texture swizzle state to default after LUMA workaround
The copySubImage LUMA workaround sets special TEXTURE_SWIZZLE_RGBA
values to work. However, it must reset this parameter back to the
default state after the workaround completes.
Bug: 1022080
Change-Id: I84870f1264311c106ebece1e6a37d5f92a1da28c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1904627
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
50919254
|
2019-11-07T10:52:21
|
|
Only enable addAndTrueToLoopCondition feature on Mac Intel
The issue which reported the need for this workaround only found a
problem on Mac. The failure doesn't happen on other the Linux
OpenGL Intel driver, so it shouldn't be enabled there.
Bug: chromium:1021900, chromium:644669
Change-Id: I65e7462828419aeb9182898f73977ee1c5e72ff3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1904291
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
|
|
|
dc98ca69
|
2019-11-08T07:01:28
|
|
Roll third_party/glslang/src e471df3c9154..f34cdc70ca1b (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e471df3c9154..f34cdc70ca1b
Created with:
gclient setdep -r third_party/glslang/src@f34cdc70ca1b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: I2902d0c568de1c07f2d688982aa6d80389cd7f94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1905273
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
6fdbe529
|
2019-11-08T07:01:31
|
|
Roll third_party/SwiftShader 27a3d31d7a9d..d9ed1c2732ba (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/27a3d31d7a9d..d9ed1c2732ba
git log 27a3d31d7a9d..d9ed1c2732ba --date=short --no-merges --format='%ad %ae %s'
2019-11-07 sugoi@google.com Prevent rasterizing fragments outside the framebuffer
Created with:
gclient setdep -r third_party/SwiftShader@d9ed1c2732ba
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: angleproject:4060
TBR=jonahr@google.com
Change-Id: I7cd94017d1dedfcab87e599f586396b9900b8d03
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1905274
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
7f9c9a7f
|
2019-11-08T07:01:25
|
|
Roll third_party/spirv-tools/src dc59b4b075e9..041f0a02493d (4 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dc59b4b075e9..041f0a02493d
Created with:
gclient setdep -r third_party/spirv-tools/src@041f0a02493d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: I0937fa1cef8e10179104802c47df697d495702de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1905272
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
652dbfc6
|
2019-11-06T16:56:28
|
|
Init Blend State color mask defaults.
This is an unrelated code cleanup. Previously we would only init these
member variables in the gl::State initialization code.
Bug: angleproject:3611
Change-Id: I3aa34958ce5b00542d45ef63e0b32010b2eb3220
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1902188
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
a5a04ac0
|
2019-10-29T22:57:55
|
|
Metal backend pt3: shader translator
Implementation of GLSL to MSL translator
Bug: angleproject:2634
Change-Id: I66e2374b461548fac46163ea79790a488515e6b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1887251
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
653ee5f1
|
2019-11-07T09:14:22
|
|
Capture/Replay: Introduce capture index file.
This index file lets us very easily write a generic capture sample.
Previously the dev had to maintain a list of multiple sources files.
Potentially hundreds. By writing the source file list to an index file
we can load this easily in GN as a variable and plug that into the
sources.
Also updates docs.
Bug: angleproject:3611
Change-Id: I69ba961e271d6d13d06ae01c89a0605a6fd725ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1902189
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
e167f76b
|
2019-11-06T16:51:55
|
|
Capture/Replay: Pass gl::State to capture functions.
This replaces passing gl::Context. Using a gl::State directly will more
easily let the mid-execution replay code pass a mocked gl::State
instead of having to modify the real underlying Context state. For
example when capturing pixel pack and unpack parameters the states
could not be overridden without changing the gl::Context itself.
Similarly when capturing client side data.
Also moves a query parameter info function into queryutils so it can be
accessible to the State-based capture.
Refactoring change only.
Bug: angleproject:3611
Change-Id: I3c064001cfa83ebbb67a2b8fc8b6180491edd215
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1899728
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
075cc4c3
|
2019-11-07T07:01:31
|
|
Roll third_party/SwiftShader 88264e3e188d..27a3d31d7a9d (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/88264e3e188d..27a3d31d7a9d
git log 88264e3e188d..27a3d31d7a9d --date=short --no-merges --format='%ad %ae %s'
2019-11-06 jonahr@google.com Fix issues presenting MetalSurfaces
Created with:
gclient setdep -r third_party/SwiftShader@27a3d31d7a9d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: I6ca25951e73f298519756654d250524ea23a4b61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1903408
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
266e4e05
|
2019-11-07T07:01:25
|
|
Roll third_party/spirv-tools/src d9fbf0234869..dc59b4b075e9 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d9fbf0234869..dc59b4b075e9
Created with:
gclient setdep -r third_party/spirv-tools/src@dc59b4b075e9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: If778c8f30ee5cfd9b94216905df566505511cef7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1902367
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
8542baee
|
2019-11-07T07:01:28
|
|
Roll third_party/glslang/src 5d0e01d9e7f9..e471df3c9154 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5d0e01d9e7f9..e471df3c9154
Created with:
gclient setdep -r third_party/glslang/src@e471df3c9154
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: I71df38874026822623509b2bbfff0714ef804326
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1902368
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
cc0919dc
|
2019-11-06T16:51:53
|
|
Capture/Replay: Fix VertexAttribType BYTE output.
Was mistakenly outputting UNSIGNED_BYTE. Caused incorrect rendering in
the T-Rex replay.
Bug: angleproject:3611
Change-Id: I91c91cb8b35f5f56cb4cce5b6893cef0fdbf71d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1902187
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
16da9515
|
2019-11-04T11:19:14
|
|
Vulkan:ImageHelper read combined DS textures
Update ImageHelper to be able to copy both the depth and stencil
aspects of a DS image to a buffer. The aspects are copied separately
with the depth data preceding the stencil data.
This allows dEQP-GLES31.functional.stencil_texturing.misc.base_level
test to pass. Added exception for ANDROID VULKAN where test still
fails and new tracking bug (4080) for this case.
Bug: angleproject:3949
Bug: angleproject:4080
Change-Id: Ib6104d7fa9f516154131f3e82161078ba216cfe1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1897649
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
322220a0
|
2019-11-05T09:51:43
|
|
Vulkan: Ignore VK_INCOMPLETE from vkGetPipelineCacheData
When getting the data store from a pipeline cache, we do the following
sequence:
1.) Query the amount of data to get.
2.) Create a buffer to hold that data.
3.) Request that amount of pipeline cache data.
This typically works without errors, but we have seen cases where the
amount of pipeline cache data changes between steps (1) and (3). This
leads to the driver returning VK_INCOMPLETE because we requested a
different amount of data than the driver currently has (either too much
or too little). However, getting at least the pipeline cache header is
all that's required, so this isn't necessarily an error:
From the Vulkan spec:
> If pDataSize is less than the maximum size that can be retrieved by
the pipeline cache, at most pDataSize bytes will be written to
pData, and vkGetPipelineCacheData will return VK_INCOMPLETE. Any
data written to pData is valid and can be provided as the
pInitialData member of the VkPipelineCacheCreateInfo structure
passed to vkCreatePipelineCache.
This change will update ANGLE to ignore VK_INCOMPLETE, rather than
treating it as an error.
Bug: angleproject:3988
Test: Android dEQP-GLES2.*
Change-Id: I6518d7cb00c26ae403b58aafa86a600fa7a8504a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1900009
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
6072d056
|
2019-11-05T10:26:12
|
|
Vulkan:Ignore layer warnings about provoking vtx ext
We're temporarily using a pre-release version of the provoking vertex
vulkan extension that's causing the layers to complain about unknown
structs. I already skipped two warnings, but missed this one so adding
it. This will temporarily disable the warning until the extension lands
in the header.
Bug: angleproject:4063
Change-Id: Ide7b0b068fca6ea4b3cd60bce35fb56f431e4739
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1900014
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
|
f7b3a2ac
|
2019-11-04T15:51:51
|
|
Fix d3d9 intel gpu fail to create image surface issue
Set allowClearForRobustResourceInit to true on D3D9 backend,
which fixes clients report issues where unity web app throws
`Fail to create image surface` error on integrated-intel gpu
Bug: chromium:1011627, chromium:1017076
Change-Id: I733434123a8c34671b1a33b87017367baec5623c
TBR=geofflang@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1898701
Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
19dd51b0
|
2019-11-04T11:28:19
|
|
GL: Expose PBO extensions
Ensure WebGLCompatibilityTest.EnablePixelBufferObjectExtensions functions
in surfaceless mode by creating a framebuffer to do the test glReadPixels
from.
BUG=angleproject:4079
Change-Id: I109b3cdeb85625a6a97832ecf8130d53a4074af9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1893058
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
f8b5a4c8
|
2019-11-06T07:01:24
|
|
Roll third_party/spirv-tools/src e0d5544c9864..d9fbf0234869 (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e0d5544c9864..d9fbf0234869
Created with:
gclient setdep -r third_party/spirv-tools/src@d9fbf0234869
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: Ice35b534d9ad4d77b3ef25c2ae14bf2bc44b55be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1899844
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
aae71bda
|
2019-11-06T07:01:30
|
|
Roll third_party/SwiftShader aaa64b76c0b4..88264e3e188d (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/aaa64b76c0b4..88264e3e188d
git log aaa64b76c0b4..88264e3e188d --date=short --no-merges --format='%ad %ae %s'
2019-11-06 swiftshader.regress@gmail.com Regres: Update test lists @ 215bc794
2019-11-05 jonahr@google.com Add VK_EXT_metal_surface extension support
2019-11-05 capn@google.com Update Vulkan CTS testlist
Created with:
gclient setdep -r third_party/SwiftShader@88264e3e188d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: I4e8fae15600166d5f268da1ee513ded8a45b2c52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1899845
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
1d09b983
|
2019-11-05T16:22:04
|
|
Vulkan: Fix memory corruption crash
When VK_EXT_LINE_RASTERIZATION or VK_EXT_PROVOKING_VERTEX is present,
createInfo's pNext pointer is set, which caused pEnabledFeatures to
not be set, which ended up causing memory corruption issues.
This change was made to comply with the Vulkan spec, specifically:
"If the pNext chain includes a VkPhysicalDeviceFeatures2 structure,
then pEnabledFeatures must be NULL"
Since the VkPhysicalDeviceFeatures2 structure is only added to the
pNext member of the createInfo structure in the if statement above,
restoring the else statement solves this issue.
Bug: angleproject:4060
Change-Id: I0688c4297f167fa28e110cd6ee11a11b95282493
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1899731
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
1bae5615
|
2019-11-02T09:58:51
|
|
Remove some ignores from export_targets.py.
These were fixed upstream.
Bug: angleproject:4077
Change-Id: I656616a111e1703f8a910c27e6be3ec3e918f6ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1899726
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
ac36a55c
|
2019-11-05T08:27:28
|
|
Roll third_party/glslang/src 48233ad3d45b..5d0e01d9e7f9 (7 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/48233ad3d45b..5d0e01d9e7f9
Created with:
gclient setdep -r third_party/glslang/src@5d0e01d9e7f9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: If9ae34dc69395f1497c884285791cff87e0d496e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1899361
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
9649b725
|
2019-11-05T07:01:24
|
|
Roll third_party/spirv-tools/src f1e5cd73f658..e0d5544c9864 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f1e5cd73f658..e0d5544c9864
Created with:
gclient setdep -r third_party/spirv-tools/src@e0d5544c9864
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: Iabc14c43ed42e7fe4aac37269808f412cb194baa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1899209
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
df415528
|
2019-10-24T09:22:39
|
|
Vulkan: Enable VK_IMAGE_USAGE_STORAGE_BIT when it is needed
VK_IMAGE_USAGE_STORAGE_BIT is always enabled for vkImage, this
increases memory bandwidth in some platforms.
This CL changes the behavior to enable VK_IMAGE_USAGE_STORAGE_BIT
when necessary.
Bug: angleproject:3904
Test: angle_end2end_tests
Test: angle_deqp_gles2_tests
Change-Id: I8ffd37efa8d99d04328fa6232de0755be3273d9e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1857799
Commit-Queue: Sunny Sun <sunny.sun@arm.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
67527cb4
|
2019-10-25T13:47:55
|
|
Fix compilation on UWP targets.
Bug: angleproject:4053
Change-Id: Iaa358c8ce61d0ebaae11672bfb6dac2d3e847be1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1881343
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c898ec1a
|
2019-11-04T15:20:18
|
|
Add EGL GGP extensions.
This CL adds two new extensions:
* EGL_ANGLE_ggp_stream_descriptor:
Introduces a new attribute to CreateWindowSurface. Allows the app
to pass in a stream descriptor to VkCreateSurfaceKHR.
Mirrors VK_GGP_stream_descriptor_surface.
* EGL_ANGLE_swap_with_frame_token:
Introduces a new function 'eglSwapBuffersWithFrameTokenANGLE'. This
allows the app to pass a GGP frame token down to vkQueuePresentKHR.
Mirrors VK_GGP_frame_token.
Bug: angleproject:4078
Change-Id: I4313ac4c264e68999905049f661bc64b44f72fab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1897315
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
71b0f0b5
|
2019-10-25T09:53:06
|
|
EGL: Implement EGL_KHR_surfaceless_context
Add extension string to registry
Add extension flag to EGL and Vulkan Displays
Bug: angleproject:3960
Test: dEQP-EGL.functional.surfaceless_context.*
angle_end2end_tests --gtest_filter=EGLSurfacelessContextTest*
Change-Id: Id17916f1f636454af395b7bc92892dcf8fc93e54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1885075
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
5cbb7773
|
2019-11-04T11:05:14
|
|
Vulkan: Increase Fence Wait Time
Our current fence wait time is triggering timeouts while running with
SwiftShader. However, it's possible for a 'real' application to hit a
timeout also with a large enough workload. This change increases the
timeout to something large enough for us to avoid most timeouts and
instead rely on the OS's detection and recovery mechanism (e.g., Windows
TDR).
We will continue to investigate improving ANGLE's command timeout
handling mechanism.
Bug: angleproject:4043
Test: CQ
Change-Id: I3a32174d1d794806fef1971806797683b6b3f0b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1897648
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
28b0c453
|
2019-10-11T15:22:02
|
|
New end2end test to print EGL information
Print out EGL vendor, version, clients, clent extensions, display extensions
Print GL vendor, version, renderer, shader, extensions
Prints each EGL config ID and its attributes
Just Vulkan based information. D3D and GL can be enabled.
Bug: angleproject:4039
Test: angle_end2end_tests --gtest_filter=EGLPrintEGLinfoTest*
Change-Id: I103a22eacb2eb14547d7908f93eeeca5434c5e66
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879492
Commit-Queue: Jeff Vigil <j.vigil@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
0c541c30
|
2019-11-04T10:17:41
|
|
Fix Platform methods list
Functions have to be added to the end of the list to prevent breaking
EGL on Android.
Bug: angleproject:2634
Change-Id: I19705144d8ab873c13891038f840b9fc96a79103
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1897646
Commit-Queue: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
5883a44b
|
2019-11-02T19:34:47
|
|
Vulkan: Don't pass width/height to Surface constructors.
These values are accessible already from the Surface state. Sometimes
they don't apply (e.g. GGP). Remove them to keep the code clearer.
Updates the offscreen surface constructor to pull width and height from
the attributes map instead of using parameters. Otherwise they weren't
used.
Refactoring change only.
Bug: angleproject:4078
Change-Id: I9e49eadc7116562f62bd8d11342d6b8835376719
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1895762
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
2f6a9afd
|
2019-11-01T15:06:58
|
|
Vulkan:Ignore layer warnings about provoking vtx ext
We're temporarily using a pre-release version of the provoking vertex
vulkan extension that's causing the layers to complain about unknown
structs. Temporarily disable these warnings until the extension lands
in the header.
Bug: angleproject:4063
Change-Id: Ia441ddef21bfcca9bb1b46f25a009eb469e8f1fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1895326
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
|
b9ddfd57
|
2019-11-04T07:01:31
|
|
Roll third_party/SwiftShader fda994c63075..aaa64b76c0b4 (8 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/fda994c63075..aaa64b76c0b4
git log fda994c63075..aaa64b76c0b4 --date=short --no-merges --format='%ad %ae %s'
2019-11-01 amaiorano@google.com Modify Blitter to implement FunctionT
2019-11-01 amaiorano@google.com Modify SetupRoutine to implement FunctionT
2019-11-01 amaiorano@google.com Modify PixelRoutine to implement FunctionT
2019-11-01 amaiorano@google.com Modify VertexRoutine to implement FunctionT
2019-11-01 amaiorano@google.com ReactorUnitTests: use FunctionT
2019-11-01 amaiorano@google.com Reactor: add type-safe FunctionT and RoutineT
2019-11-01 natsu@google.com Allow concurrent eglSwapBuffers() with same display but different surfaces
2019-11-01 natsu@google.com Move egl locking code from main.cpp to libEGL.cpp
Created with:
gclient setdep -r third_party/SwiftShader@aaa64b76c0b4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=ynovikov@google.com
Change-Id: I3f139b83f7f77beb913ee2dca988d7cfe98a01ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1896150
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
ef323f4d
|
2019-11-04T07:01:24
|
|
Roll third_party/spirv-tools/src 618ee509421f..f1e5cd73f658 (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/618ee509421f..f1e5cd73f658
Created with:
gclient setdep -r third_party/spirv-tools/src@f1e5cd73f658
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=ynovikov@google.com
Change-Id: I810ffee83153c8dd880d2e3a1fa4db2b23092f8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1896148
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
6c7208f9
|
2019-10-31T14:33:27
|
|
Capture/Replay: Implement mid-execution replay.
Mid-execution replay starts the replay from a specific start frame
instead of frame 0. Integration tests will then run between the start
and end frames. This lets us make much smaller reproduction cases from
large benchmarks or applications.
We implement mid-execution replay via a cpp "Setup" function. The
replay test will run the setup function before the starting frame. Test
execution proceeds normally after setup.
Currently we do not implement mid-execution capture. We run capture on
all frames. Including frames before the start frame. We do this to
intercept compiled shaders and programs for easier caching. This could
be changed in the future to also start capture mid-execution. Mid-
execution capture might require using ProgramBinary calls to capture
shader and program data.
Many captures are unimplemented. Several comments indicate missing
functionality. There's a lot we can add as we explore replaying more
complex applications and higher GL versions. We will also need some
kind of state reset functionality so we can run the replay in a loop.
Bug: angleproject:3611
Change-Id: I51841fc1a64e3622c34e49c85ed8919a9a7c0b20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1689329
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
b68a279c
|
2019-10-31T17:47:59
|
|
Capture/Replay: Capture GetFloatv params.
Was used in the mip map ANGLE sample. Add a new helper function that we
can use for multiple captures.
Bug: angleproject:3611
Change-Id: I430ce0089df4ce81ba2ca2ad64c0c206b59397b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1894144
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
a576e0d4
|
2019-11-02T17:23:34
|
|
Capture/Replay: Only convert GLES 2 GLenums to string.
Previously the enum conversion script would convert all enums in gl.xml
including those for desktop GL. When replaying from a CPP file we would
sometimes try to use enum values that only are exposed in desktop GL.
One example is GL_TEXTURE_MAX_ANISOTROPY/GL_TEXTURE_MAX_ANISOTROPY_EXT.
GLES only has the "EXT" version. Desktop uses the core version. This
was breaking a replay sample that used the EXT enum.
Fix this by a) including the anisotropy extension in registry_xml and
b) updating the enum script to only parse GLES 2 entries. In the future
we could improve the situation by auto-generating a header that defines
exactly the enums we need for ANGLE.
Also updates the enum helper to use uppercase enum values.
Bug: angleproject:3611
Change-Id: I1e01608bc8af282dc078d5a19ac4eba659c96b57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1894143
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
95f5806e
|
2019-11-02T17:19:43
|
|
Delete stale unused proc table functions.
These were orphaned and unused after we shifted the proc table
generator to split between WGL and EGL.
Bug: angleproject:3533
Change-Id: I0bf6df438ba431a0cac0a1f89eabc13c67a0f676
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1895760
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
422ebad2
|
2019-10-31T16:02:48
|
|
Fix ANGLE_get_image cube map handling.
Was missing a layer parameter. Also includes a regression test.
Also updates incomplete texture handling in Vulkan. Will try to sync
the texture storage if the texture has never been used.
Bug: angleproject:3944
Change-Id: I5fcd6931f9cb9e008faaeaecb1f6df275a2af73f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1894142
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
35f74cd6
|
2019-10-31T16:47:10
|
|
Reorder BaseVertexBaseInstance draw calls parameters
To match the parameter order of MultiDraw* calls.
And potentially expose in chromium directly with ANGLE_ prefix.
Bug: angleproject:3402, chromium:891861
Change-Id: I19548f4c3c7faa422e43905850b218039de43015
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1894241
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
fe26bae4
|
2019-10-29T18:38:53
|
|
Metal backend implementation pt 2
This is without Metal specific shader translator implemented yet.
Bug: angleproject:2634
Change-Id: I95d589442251c9ba111bd05a2dc379a36739046c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1855069
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
076fae01
|
2019-11-01T07:01:28
|
|
Roll third_party/glslang/src b131630e7c74..48233ad3d45b (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b131630e7c74..48233ad3d45b
Created with:
gclient setdep -r third_party/glslang/src@48233ad3d45b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=ynovikov@google.com
Change-Id: I5897793dd12484322c1361965335abe1acdb6169
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1895072
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e9603921
|
2019-10-31T14:33:26
|
|
Capture/Replay: Correct a few GLenum replay issues.
This change refactors the GLenum utils into a non-autogenerated and an
autogenerated portion. That makes it easier to modify the non-auto-
generated bits to properly output GLenums even when the gl.xml data
isn't totally correct. For instance, the "GetPName" group was missing
a bunch of queries. Instead of trying to fix the GL we can simply fall
back to querying the "Default" group when we return invalid enum.
Also corrects a missing "0x" on hex output.
Also allows the capture/replay sample to specify the correct binary
data directory when testing a replay.
Bug: angleproject:3611
Change-Id: I8e4c690b2850bb157a8cde8b057b20603e4b177d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1891008
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
ba65c156
|
2019-10-31T10:52:24
|
|
Capture/Replay: Implement GetFramebufferParameter capture.
This is necessary for the T-Rex benchmark.
Bug: angleproject:3611
Change-Id: I4573f8e86356272364baaccc678494707d2eebc0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1893571
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
3ff097ff
|
2019-10-31T10:42:00
|
|
Win: Add ANGLE_WAIT_FOR_DEBUGGER option.
Setting this environment variable will make ANGLE pop up a dialog. The
dev can then attach a debugger to this dialog. Only implemented on
Windows currently.
This option is only available when ASSERTs are enabled in libGLESv2.
The code is based on SwiftShader's implementation of WaitForDebugger:
https://cs.chromium.org/chromium/src/third_party/swiftshader/src/Vulkan/main.cpp
Bug: angleproject:4072
Change-Id: I160cb91a423a6d4517f067f2a6f3a2d953b26505
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1892173
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
5e6be1d6
|
2019-10-11T11:29:22
|
|
Provoking vertex feature support enabled
Added support in ANGLE for the provoking vertex feature,
which allows to choose the provoking vertex convention
(first or last) for flat shading.
Just copying the vk_ext_provoking_vertex.h file into ANGLE src tree for now.
When the extension lands in the vulkan header we'll migrate to that and remove this
file from ANGLE.
With this, all these tests pass with SwANGLE:
dEQP-GLES3.functional.fragment_out.* (fixes 526 failures)
dEQP-GLES3.functional.rasterization.flatshading.* (fixes 6 failures)
dEQP-GLES3.functional.shaders.linkage.varying.* (already passing before, still passing)
Bug: angleproject:3430
Bug: angleproject:3677
Bug: angleproject:4063
Change-Id: Icc361f567072c12472398e37a94a61d7f95007ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1855681
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
|
|
|
133be103
|
2019-10-31T07:01:30
|
|
Roll third_party/SwiftShader e1cda3916cee..fda994c63075 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e1cda3916cee..fda994c63075
git log e1cda3916cee..fda994c63075 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 digit@google.com [vulkan] Implement external semaphore support for Fuchsia
2019-10-30 digit@google.com Vulkan headers: restore vulkan_fuchsia_extras.h include.
Created with:
gclient setdep -r third_party/SwiftShader@fda994c63075
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=ynovikov@google.com
Change-Id: Ifab83c52fc2d7b3be486e0befc5918092526f198
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1892556
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
69460436
|
2019-10-31T07:01:24
|
|
Roll third_party/spirv-tools/src 7e2cba6a5241..618ee509421f (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7e2cba6a5241..618ee509421f
Created with:
gclient setdep -r third_party/spirv-tools/src@618ee509421f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=ynovikov@google.com
Change-Id: I66bd4b119b577a194fc3e10e21c14ab15c0d4808
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1892555
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
841b0167
|
2019-10-30T18:08:53
|
|
Suppress flaky dEQP-GLES3 test on Win7 NVIDIA D3D11
dEQP-GLES3.functional.rasterization.flatshading.triangles
Bug: angleproject:4070
Change-Id: I8bdba9d1b9d3c04df42a6c90fa106cf7e8b1a018
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1890729
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
5da6f444
|
2019-10-30T12:54:49
|
|
Fix error string commas.
For example: 1, 2, 3, 4 became 1 = 2 = 3 = 4.
These were acidentally changed to equals signs way back in this CL:
610640fabee9 "Don't use gl::Error in validation."
Bug: angleproject:4067
Change-Id: I05d1c5ecc5f6fb7636f81ca59d05928dd940bf8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1890631
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
924dad3b
|
2019-10-30T07:01:34
|
|
Roll third_party/spirv-tools/src 42f885238114..7e2cba6a5241 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/42f885238114..7e2cba6a5241
Created with:
gclient setdep -r third_party/spirv-tools/src@7e2cba6a5241
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=ynovikov@google.com
Change-Id: I6e83a7ad7fa1c53ecf862cd0f359e7589e6e5ab0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1889339
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
07be79e1
|
2019-10-30T07:01:48
|
|
Roll third_party/SwiftShader f8f6103eb89f..e1cda3916cee (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f8f6103eb89f..e1cda3916cee
git log f8f6103eb89f..e1cda3916cee --date=short --no-merges --format='%ad %ae %s'
2019-10-29 sugoi@google.com vkGetPhysicalDeviceFeatures2 fix
2019-10-29 sugoi@google.com Provoking vertex fixes
Created with:
gclient setdep -r third_party/SwiftShader@e1cda3916cee
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: angleproject:3677,angleproject:3430,angleproject:3677,angleproject:3430
TBR=ynovikov@google.com
Change-Id: I9b60af8c54c22dfb34f4fec6a06adaa41eed186c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1889340
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
bb35bb4e
|
2019-10-29T17:17:04
|
|
Vulkan: Implement simple case ANGLE_get_image.
A couple cases are left unimplemented:
Incomplete/unused Textures. This leads to a slightly more tricky
implementation. Since we need to read back from the staging buffer
we will need to flush the Image contents to a temporary buffer.
Depth/stencil readback. Requires a more complex pixel packing
step.
3D/Cube/2D Array readback. Also requires a more complex packing
step.
Bug: angleproject:3944
Change-Id: Ic5d9a606177ba7e3e5ab945feb5f555afa11741f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879964
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
ec5c3d5f
|
2019-10-28T13:46:37
|
|
Fix Renderbuffer support for unsized DS formats
This extends a previous fix for TextureAttachment support to also apply
to Renderbuffer. Unsized DS formats should not pick up support from ES3
automatically.
Also unsized DEPTH COMPONENT textures should not be allowed as renderbuffer
without also having support for GL_ANGLE_depth_texture or
GL_OES_depth_texture extensions.
The DS sections of format tables were also refactored so that the columns
align again.
Bug: angleproject:3952
Change-Id: I034b6bc95091f345b7e543d7454e04554ad8eb79
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1884421
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
f8a8ac0c
|
2019-10-29T11:59:22
|
|
Update docs for recent dEQP / VK-GL-CTS update
Location of dEQP / VK-GL-CTS has moved, update doc/dEQP.md.
Bug: angleproject:3914
Change-Id: I705922b7292ffb60954042edae2514d515e68b44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1887678
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
2c703b1a
|
2019-10-24T17:53:24
|
|
Print the testConfig in dEQP tests.
This will help debug failures on the bots that could be caused by the
wrong test config being used. As a side effect this changes the
condition array of GPUTestConfig to use an angle::BitSetT
BUG=chromium:997351
Change-Id: If742cd3d416694d5df6c3e6c1d722a24f487a960
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879585
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
|
|
88a74e59
|
2019-10-29T09:48:18
|
|
Vulkan Android: Remove support for EGLConfig's with GL_RGB10_A2 & GL_RGBA16F
These were recently reverted from the Android Vulkan loader, and must
also be reverted from ANGLE. When the Android Vulkan loader adds
back support, it will be conditional based on whether the device
supports those formats. Therefore, at that time, ANGLE will need to
do the same.
Bug: http://anglebug.com/4019
Bug: http://anglebug.com/4061
Bug: http://anglebug.com/4062
Change-Id: I0b749dc8be0439e6f3b8eeeb51716d4185e9b021
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1887393
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
febdcf51
|
2019-10-28T10:54:03
|
|
Roll dEQP to VK-GL-CTS
Switch from Android dEQP to Khronos GL CTS.
We now mirror from the public Khronos Github
github.com/KhronosGroup/VK-GL-CTS
This includes a number of text fixes for GLES 2.0 conformance.
Bug: angleproject:3914
Bug: angleproject:1656
Change-Id: I4cccd33e47752742cb989127c5883c0afd075b9e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879579
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
287b0a67
|
2019-10-24T17:21:40
|
|
Vulkan: Enable forceOldRewriteStructSamplers for all Android ICDs
Both Qualcomm and SwS require forceOldRewriteStructSamplers to be
enabled, so this change will enable that feature for all of Android.
We aren't sure yet why this is required for SwS also, but that will be
chased as part of issue 2703.
Bug: angleproject:4045
Change-Id: I83b2ac18e0111ed35438ffd457bfe120911a7767
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879711
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
dc883a94
|
2019-10-29T07:01:34
|
|
Roll third_party/spirv-tools/src ec12de913124..42f885238114 (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ec12de913124..42f885238114
Created with:
gclient setdep -r third_party/spirv-tools/src@42f885238114
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=ynovikov@google.com
Change-Id: I4d367272caee2c40d00237049e7af1b0b5db7bc2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1885999
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
dca568a3
|
2019-10-29T07:01:48
|
|
Roll third_party/SwiftShader 1737a30e3e34..f8f6103eb89f (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/1737a30e3e34..f8f6103eb89f
git log 1737a30e3e34..f8f6103eb89f --date=short --no-merges --format='%ad %ae %s'
2019-10-28 sugoi@google.com VK_EXT_provoking_vertex support
2019-10-28 jonahr@google.com Fix vulkan builds in ANGLE on MacOS
Created with:
gclient setdep -r third_party/SwiftShader@f8f6103eb89f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: angleproject:3677,angleproject:3430
TBR=ynovikov@google.com
Change-Id: Ib298b4e4a21eeadaa876f442fc2c4408b44f3b23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1886000
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e7852798
|
2019-10-28T13:51:43
|
|
Vulkan: Clean up redundant vk:: prefixes.
Were in a lot of places in vk_helpers.
Bug: angleproject:3944
Change-Id: I8635400d6debb7ed92e3cf84993773ca9ed74285
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879963
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
96ba0f12
|
2019-10-28T13:51:42
|
|
Vulkan: Move readPixels logic to ImageHelper.
This logic will be shared with ANGLE_get_image. Cleans up some of the
graph access logic so it can work easily with TextureVk/RenderbufferVk.
Bug: angleproject:3944
Change-Id: If069528f27b2c291d52de892c707562875b95227
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879962
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
6f23b4b7
|
2019-09-03T20:04:28
|
|
Fix MinGW include: s/VersionHelpers.h/versionhelpers.h/
Bug: angleproject:4050
Change-Id: I7d6ac948479b499df4fb4f734fc0d9abd40bb455
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880451
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
dfc20daf
|
2019-10-28T13:51:42
|
|
Plumb more logic for ANGLE_get_image.
Also implements and tests validation / negative API.
Bug: angleproject:3944
Change-Id: I3385a4255f4fab6a12eee2abfa5ffcce2107359a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879961
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
2f71802b
|
2019-10-28T11:48:46
|
|
GN: Don't expose glslang when unused.
The ninja generation step could get confused if we try to build the
glslang wrapper project on platforms that don't support glslang. Turn
it off if the Metal / Vulkan back-ends are not enabled.
Bug: angleproject:4053
Change-Id: If4dd2856681f18f4f45e952bf88e33371b9a1e3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1884010
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
a12b3032
|
2019-10-28T12:55:49
|
|
Don't cc angle-team on Chromium DEPS rolls.
Leave a TODO to use the wrangler email alias when Chrome's rota-ng
tool is updated.
Bug: angleproject:4059
Change-Id: Ide7538b4762ea3ec0f21237e1f2af7dba5023301
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1884012
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
0964988b
|
2019-10-26T19:47:41
|
|
Fixups to ANGLE_get_image boilerplate.
- Remove level parameter from GetRenderbufferImage.
- Add packed enum handling to GetTexImage.
- Fix ext spec reference to table 8.4.
Bug: angleproject:3944
Change-Id: I8f67608396217aaddb789dd95d0f3e2378ce918d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879960
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
225301d6
|
2019-10-28T07:01:19
|
|
Roll third_party/SwiftShader f44f7c066a67..1737a30e3e34 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f44f7c066a67..1737a30e3e34
git log f44f7c066a67..1737a30e3e34 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 sugoi@google.com Removed stencil reference from PixelProcessor::States
Created with:
gclient setdep -r third_party/SwiftShader@1737a30e3e34
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: I74de5492bf7d771d4d70f2ee91e8579b22b4cddd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1883390
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
076f869c
|
2019-10-28T07:01:23
|
|
Roll third_party/spirv-tools/src b34fa731931b..ec12de913124 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b34fa731931b..ec12de913124
Created with:
gclient setdep -r third_party/spirv-tools/src@ec12de913124
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: I26ac305c6099059c7f1d5671fdd2b0aa419e8881
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1883391
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
95a736bd
|
2019-10-09T10:26:25
|
|
Reland "Add more test_utils functions."
This is a reland of 5fcfcea4a9379633a83a67fc1d94938cb31f2a9c
Re-land uses static linking with angle_util. The root cause
of the CFI error wasn't solved. Static linking works around
the problem by not using any export rules.
Second re-land fixes missing imports for libEGL and libGLESv2
static varieties.
Original change's description:
> Add more test_utils functions.
>
> Includes methods for creating temporary files, deleting files, and
> reading files into a string. Also renames GetPathSeparator to mention
> it's only used for environment variables. Includes a new virtual type
> angle::Process that will be used to implement cross-platform async
> Process launching for tests. Also includes a way to specify a custom
> crash handler callback.
>
> Also adds a few unit tests for the new functionality. They are disabled
> on Android because the functions are not needed by the new test runner.
>
> Bug: angleproject:3162
> Change-Id: I3e2c2e9837608884c98379fa0f78c9ffbe158d73
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1821940
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Bug: chromium:1015810
Bug: angleproject:3162
Change-Id: I2a18b819b0f91df610ad12ffedea2b38349fe7cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879859
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
e7c8e80d
|
2019-10-26T08:16:12
|
|
Roll chromium_revision 60074bf9e0..5fe256ab5e (709436:709762)
Change log: https://chromium.googlesource.com/chromium/src/+log/60074bf9e0..5fe256ab5e
Full diff: https://chromium.googlesource.com/chromium/src/+/60074bf9e0..5fe256ab5e
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/a193dcc697..258e22bc61
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f712af4fd9..85152663b9
* third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/571788934b..1cfec065ed
* third_party/yasm: https://chromium.googlesource.com/chromium/src/third_party/yasm/+log/cc10bc0f1d..02a8d2167f
DEPS diff: https://chromium.googlesource.com/chromium/src/+/60074bf9e0..5fe256ab5e/DEPS
No update to Clang.
Also includes new DEPS for jsoncpp and yasm.
TBR=jmadill@chromium.org,
BUG=1017514
Change-Id: I0f1998407f74521251d920d269ad2787e79fb57d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1882273
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
76763cb9
|
2019-10-25T11:09:27
|
|
SwiftShader: Update the expectations file according to latest testing
Some tests fixed. Others only fail on Android.
Bug: angleproject:4016
Bug: angleproject:4019
Bug: angleproject:4045
Change-Id: If3b915fdd1c54cefa17589f025ea8a93935377c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880165
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
04ee27ef
|
2019-10-24T18:29:15
|
|
Capture/Replay: Add ANGLE_get_image extension.
Will be used for mid-execution capture. Only has a
stubbed-out implementation right now.
Bug: angleproject:3944
Change-Id: I6ddae07907ecbdbd3be9a5d2d3fcafeb425445e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1878888
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
003629a5
|
2019-10-25T15:24:20
|
|
Roll third_party/SwiftShader 883e817b14bf..f44f7c066a67 (4 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/883e817b14bf..f44f7c066a67
git log 883e817b14bf..f44f7c066a67 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 amaiorano@google.com Fix LLVM7 partially initialized ManagedStatic
2019-10-24 sugoi@google.com Fixed using an offset in Blitter::blitFromBuffer()
2019-10-24 sugoi@google.com Fix stencil+MSAA
2019-10-24 paulthomson@google.com Add LESS_DEBUG_INFO CMake option
Created with:
gclient setdep -r third_party/SwiftShader@f44f7c066a67
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: angleproject:4037,angleproject:4013,angleproject:4044
TBR=jonahr@google.com,jmadill@google.com
Change-Id: If8150d05ff1e222c24c1f8dc09b99cbb42bffa10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880455
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
02c89327
|
2019-10-25T12:04:36
|
|
Capture/Replay: Fix capture build on Android.
A compile error slipped in due to lack of test coverage.
Bug: angleproject:3611
Change-Id: Id34ce239f3913efb0ed1abab77321981419cab44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880160
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
adcda20c
|
2019-10-25T11:27:00
|
|
Update wrangling docs to link to SwiftShader roller.
Bug: angleproject:1944
Change-Id: I8eabf5e8ec5cd7bfeab4db9b7bd5422f5168744e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880159
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e55374f7
|
2019-10-24T12:55:12
|
|
GN: Explicitly add several Windows libs.
These were not implicitly added in the Skia build.
Bug: angleproject:4046
Change-Id: I0acdb4056e4598ea372b650dbd8044fe680187b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877483
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
8ab0bf1f
|
2019-10-24T12:55:12
|
|
Fix warnings in xxhash.
Again these were showing up in Skia.
Bug: angleproject:4046
Change-Id: Ia295ac02b1e1d7bd4186243fc2bf38dffce43c2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877482
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
4bad5355
|
2019-10-25T11:54:24
|
|
Roll third_party/spirv-tools/src feb154921397..b34fa731931b (23 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/feb154921397..b34fa731931b
Also rolling transitive DEPS:
third_party/spirv-headers/src 842ec9067462..af64a9e826bf
Created with:
gclient setdep -r third_party/spirv-tools/src@b34fa731931b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: I19a2870cef1000757fa7767ef45b5fbac8a3a4a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880801
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
664be3f8
|
2019-10-25T11:17:58
|
|
Capture/Replay: Fix docs link.
Should be samples/capture_replay not samples/capture_and_replay.
Bug: angleproject:3611
Change-Id: I5de4849c875add39df36f7875482e4dc91ca0ca6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880158
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
07035681
|
2019-10-25T09:00:41
|
|
Use googletest nested DEPS file.
This will fix the issue where gclient didn't support checking
out DEPS-inside-DEPS. We pass a 'googletest_revision' variable
to third_party/googletest via recursedeps.
Bug: chromium:1017514
Change-Id: I4ef3785e385775910f24e13e60e284b8ab2996d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1881023
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
7d51cc98
|
2019-10-25T08:06:35
|
|
Roll chromium_revision 9325340209..60074bf9e0 (704874:709436)
Change log: https://chromium.googlesource.com/chromium/src/+log/9325340209..60074bf9e0
Full diff: https://chromium.googlesource.com/chromium/src/+/9325340209..60074bf9e0
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/592281c03c..a193dcc697
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/6752fa027a..f712af4fd9
* third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/c721b68dde..60616473f7
* third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/48246a0995..571788934b
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/9d3bf3e968..bc13578529
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/ddebad26cf..403ca5ad3a
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6bc727d9d8..662cbb8d60
DEPS diff: https://chromium.googlesource.com/chromium/src/+/9325340209..60074bf9e0/DEPS
No update to Clang.
TBR=jmadill@chromium.org,
BUG=None
Change-Id: I429a0179f2941ebe04a41a1e25068c2bc41e66c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1881022
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
155947fc
|
2019-10-24T12:55:11
|
|
Enable "-Wconditional-uninitialized".
This is a final warning used by Skia.
Bug: angleproject:4046
Change-Id: I3970e30e4bd2aef07cddadd7322ef120ac857493
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877481
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
16370a65
|
2019-10-24T12:55:11
|
|
Enable "-Winconsistent-missing-destructor-override".
This is purely a code style and consistency warning. Enabled to
support building in Skia.
Bug: angleproject:4046
Change-Id: Ibdcd06ded0195123e52c693851c43d0864e54ad1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877480
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
ec14fd5a
|
2019-10-25T07:01:10
|
|
Roll third_party/glslang/src 7662586844f4..b131630e7c74 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7662586844f4..b131630e7c74
Created with:
gclient setdep -r third_party/glslang/src@b131630e7c74
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=jonahr@google.com
Change-Id: Ia4ef9eeef7404245de43d5adf1636e395c4e61f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880657
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|