kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 4f384e51 2025-09-18T07:59:53 Roll Chromium from 8e8081831607 to 129abbaa76d7 (640 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8e8081831607..129abbaa76d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/298617b7f0..e924c0b4e3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/19bc3708ba..f924cff1b2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5f35403daf..f1faf4cb02 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f733f5a3fa..47b1fee1d4 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/399e5f5ba9..4d7a487088 * third_party/android_build_tools/lint/cipd: d6CQ9eCLBIOopQEbwq-Sax2LJTcnhF8kso6FeFopbkgC..P8K_TqqlfAsVDdYQsTmShh1m5oAOuFLB2lnrpIXmprAC * third_party/android_build_tools/nullaway/cipd: Zk_ffB0B6qGrr2ZDKqCxAgnPmo4-5giVRIauRffZaZYC..N8e9CN_YH72RHiFh5wTuXkcMtNbQBBrtot_-HePTmAwC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/cf6beb83fd..e161b0d383 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0a50a85229..d266e57b80 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6da6aecbb4..0d761e6db8 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/f2fc757153..49c8eeff56 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/6a2c6d01f5..7d15f427b6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8e6c4696e2..d5c58bc612 * tools/luci-go: git_revision:49b2e707cefeee85697673b81627b3329debfae4..git_revision:6645da847edf4e1ebcfe8cf4d860ad75e63b20cb * tools/luci-go: git_revision:49b2e707cefeee85697673b81627b3329debfae4..git_revision:6645da847edf4e1ebcfe8cf4d860ad75e63b20cb * tools/luci-go: git_revision:49b2e707cefeee85697673b81627b3329debfae4..git_revision:6645da847edf4e1ebcfe8cf4d860ad75e63b20cb * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0b97617ee6..91aecc7266 * tools/skia_goldctl/linux: hV2dfcJ5iud2DblnB27NWew6qYb6HipSH86rBfdGh1EC..0m9SaljOycDrE8fearwZkVxxQQ098EfFXGJeb3EBjQYC * tools/skia_goldctl/mac_amd64: r6FpOxWU9iELjJeuq72JTfmKs93KTxpbkt6RwybYABoC..AzKEv2HI-8_ky3EVvExnuRplPIq3tixEfrAHZEb_07kC * tools/skia_goldctl/mac_arm64: 0DvbA0ox2ZUvnTJFNQMtNGdwzeJbpCaAZQcQYyiFTpMC..VrlF0xpgJleUjmPltWxsqf_gls027kAQjJxsrnn-iDkC * tools/skia_goldctl/win: k1h3MReK-_5P1okvxqyXSeNIJ1EaFV5dfHokEHQUKpcC..kJaXlUqja-Q_RLqhVDs9FUO3RhdH6i_xcIAmuGI5Xi4C No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I6b99e68b2353bce3089b895dc92c386aafba555d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6961465 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 3c588044 2025-09-17T22:44:36 Tests: Add trace batch for 2025-09-17 These traces were contributed by Samsung. Traces in this batch include: - match_factory - paper_io2 Test: angle_trace_tests Bug: b/445816053, b/445816060 Change-Id: Id75e9ca06cd3beafc0794b4c2cf134e22ee5318a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6961131 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Austin Annestrand 7217890d 2025-06-17T11:51:08 CL/VK: Add SerializedExecution feature knob Feature allows for each enqueue-able CL command to submit and wait for fence (debugging aid). Bug: angleproject:444491489 Change-Id: I16b7e74f2a321680a81ab3c8a18dd9534a64ce1a Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6941617 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Andrew Mitchell f5f9c129 2025-09-14T18:24:09 Add reference to ReAuth guide Change-Id: Ifc9128da700cfd0e0a74e6426eefee9f3fb2aaa0 Bug: chromium:415115279 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6947247 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 9e8f3c1f 2025-06-06T15:01:59 CL/VK: Cleanup buffer and image map handling - Create/move memory map routine(s) to CLBufferVK/CLImageVk. - Update image staging buffer routines. - Remove unused CLMemoryVk routines. Bug: angleproject:444481344 Change-Id: Ibd8361ce8eec67a1891effe0fee344ef977d25dd Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6941607 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Brian Sheedy 44db20f2 2025-09-17T15:57:09 Revert "Add a "noncoherent" layout qualifier to PLS" This reverts commit ef9c5ce43110f4f8ba56124bdee927944ce3ddd1. Reason for revert: Causes issues on Apple silicon crbug.com/445727125 Original change's description: > Add a "noncoherent" layout qualifier to PLS > > Raster ordering can be expensive. If an app knows the geometry in a draw > does not overlap, it can mark the PLS planes as noncoherent and opt for > using barriers instead. > > Bug: angleproject:40096838 > Change-Id: I2d686c2e64f51940face186637a9fcadcc251bef > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923300 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Chris Dalton <chris@rive.app> Bug: angleproject:40096838 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ibc24bed27cec406b6e4ffa9aaa8fe3a2110b58ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6962955 Reviewed-by: Kenneth Russell <kbr@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Charlie Lao 7201e17d 2025-09-16T11:04:05 Vulkan: Move divisor>MaxVertexAttribDivisor to VA::syncState Another preparation for use mVertexInputBindingDesc directly. Instead of checking divisor > renderer->getMaxVertexAttribDivisor() in ContextVk code, this CL take care of them in VertexArrayVk::syncState, so that all other code do not need to take care of it. Bug: b/439073246 Change-Id: Id938c168a1490e072e6f4bb08b85b60b55968ddf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6955256 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Austin Annestrand b3e715de 2025-07-15T13:43:31 cl/vk: Fix user-event handling - add missing internal retain for user-event setting - add missing predicate for condition variable wait - fix double-alloc on user-event backend creation - mImpl is created during "initBackend", not ctor Bug: angleproject:444482493 Change-Id: I48fa8bca43a06d5ff8b2bceb884a924840ec5682 Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6941605 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao e542cb6c 2025-09-15T16:35:34 Vulkan: Split handleDirtyGraphicsVertexBuffers into two funcs ContextVk::handleDirtyGraphicsVertexBuffers() has two code paths that are quite different, depends on if supportsVertexInputDynamicState is enabled or not. This CL splits this function into two so that 1) code is much easier to read that what is done in each case and 2) get rid of if check at draw time. Bug: b/439073246 Change-Id: Iaf9f84fb20d82e784f9dfe8ece321cff94b7b58d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6956208 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Charlie Lao <cclao@google.com>
Shahbaz Youssefi f128872e 2025-09-16T23:37:08 Translator: Compare variables by unique id instead of pointer Bug: angleproject:349994211 Change-Id: I32ab2ffe9a04e196330949484e704913d0f4e41d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6955119 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Geoff Lang 0cc9b7be 2025-09-03T11:33:37 Support more YUV formats in CopyTextureCHROMIUM Add support for formats in GL_ANGLE_yuv_internal_format as source textures to glCopyTextureCHROMIUM. These formats are common AHardwareBuffer formats and Chrome uses them as copy texture sources when decoding video. Bug: chromium:405308165 Change-Id: Ic817cce83b676ee9a517bee4fac6ef94a174961f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6908295 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Lokbondo Kung 938c80d5 2025-09-17T11:57:39 Fix missing include for <ratio> used for std::nano. Bug: b/412761856 Change-Id: I7535e7176e4372df6948f903504594e448153d48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6961860 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Loko Kung <lokokung@google.com> Commit-Queue: Loko Kung <lokokung@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 130bdaa9 2025-09-10T12:51:37 Vulkan: Store VkFormat in VkVertexInputBindingDescription2EXT In preparation for next CL that uses VkVertexInputBindingDescription2EXT directly, this CL also stores the VkFormat in VkVertexInputBindingDescription2EXT directly. mDefaultAttribFormatIDs is added to store the angle::FormatID for the default attribute (used when attrib is disabled in VertexArray) Bug: b/439073246 Change-Id: Ia36758b258be23676b9b12c0c7cec7adefe1036a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6935270 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 1252d9aa 2025-05-30T14:16:23 CL: Create frontend event and pass to enqueue APIs Since frontend cl_event object does not depend on enqueue API routines, we can construct it early and then pass to mImpl enqueue API calls (for any backend that needs it). Also update backend routines to init their backend event implementations using frontend event object. Bug: angleproject:444482493 Change-Id: I459dbf34f10cb6b30245479c9966f876d6e905d7 Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6941604 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 5298dccc 2025-09-13T21:04:47 Vulkan: Fix depth/stencil blit src layer The depth/stencil views used in blit viewed the exact layer, so they are always 2D and no layer parameter is needed. Tests upcoming in https://chromium-review.googlesource.com/c/angle/angle/+/6780168 Bug: angleproject:433816259 Change-Id: I7fa105d2734c47c86d4d0e82e8f68dc1a23e4612 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6944631 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Aurora Zhang f8c8264a 2025-09-17T10:01:22 Support RGBX format with GL_RGBA when using glTexSubImage2D Add an additional combination support with GL_RGBA in glTexSubImage2D for RGBX format. Add an end2end test. Bug: angleproject:444335354 Change-Id: I96fc9d3543fc58c9f666bf149f78cf9049758a32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6938945 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Panfeng Hou c8af6941 2025-09-16T14:51:55 Vulkan: Enable FragmentShadingRateEXT CTS fix patch was merged, enable per draw and per primitive VRS. Bug: angleproject:397255625 Change-Id: I681a52d9d28572153ff868cfbfc71657f26e3b21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6953541 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Panfeng Hou <panfeng.hou@arm.com>
Mark Mentovai 2f564f1c 2025-09-16T16:46:36 mac: handle Metal toolchain being unbundled from Xcode 26 The Metal toolchain was formerly part of Xcode, but in Xcode 26, it has been unbundled and is now a separate install. Attempting to use the Metal toolchain without installing it results in a build error, such as: error: error: cannot execute tool 'metal' due to missing Metal Toolchain; use: xcodebuild -downloadComponent MetalToolchain By running the suggested command, the Metal toolchain can be installed, but the existing angle build does not know how to find it correctly. For system Xcode installations, tools from the Metal toolchain (`metal` and `metallib`) can be run via `xcrun`. This construct should work equally well for older Xcode versions, for situations where it’s still in use. For the hermetic toolchain, we’ll continue splicing the Metal toolchain into the location it had previously been avialable (see https://chromium-review.googlesource.com/c/6950738), although this is subject to change in the future. Bug: chromium:423933062, chromium:445400016 Change-Id: I139eca51938f7cecfec9b90fd488947160ef4ec9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6955000 Auto-Submit: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 7b4946b7 2025-09-17T03:01:47 Roll SwiftShader from 3877515497c0 to ce5b85176a89 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/3877515497c0..ce5b85176a89 2025-09-16 swiftshader.regress@gmail.com Regres: Update test lists @ 38775154 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ia39f24a46a40975b73bd1d50a684ae3d2618f5e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6958592 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4c5b7f14 2025-09-17T11:21:44 Roll vulkan-deps from 90665ef518dd to 59d1ef64176c (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/90665ef518dd..59d1ef64176c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/1614abe2a290062df11c142bfc67fccc56692133..720fe8ab367beb15c4b08064c13cdf96711247f5 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/4ff7bc64c6881d8028251323d97a1078ebb60201..50399a2c3011bea1941a977f5b90a241053af4bc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/9819b31bed2a79cb88260d69ede346a92319ac8b..b7cec35a0ca9d1197aeb85a00a5f426249e1e134 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ifc9dfb058d51f5d37d46cf39b84142eb2c4e2f17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6958719 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e24df24e 2025-09-17T07:01:51 Roll Chromium from c960af7f560f to 8e8081831607 (593 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c960af7f560f..8e8081831607 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3afd36a297..298617b7f0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/958004daac..19bc3708ba * buildtools/reclient: re_client_version:0.179.0.28341fc7-gomaip..re_client_version:0.183.0.3b3097cd-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/57fef43213..5f35403daf * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9d692d6692..f733f5a3fa * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/0c9a24dacc..399e5f5ba9 * third_party/android_build_tools/error_prone/cipd: _xvKMGMJix5ysOYKkNTfSBd8CHQlf-DqEmAYYoEP3wgC..qtE2WAvADZ8xIiG9JKU7PwWTsjruwLj4bwJa6jqxVpIC * third_party/android_build_tools/manifest_merger/cipd: -IKgMtIkFMuvZVpfM_1mWxAhbYzplqRHQ1JHqsbZ1RQC..uKGig6PBT9wSbI5t2hAl8MQ9b8iT5CcnYe1T9tGBVIkC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/74d30d13de..cf6beb83fd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/375b4c2e2a..0a50a85229 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/35982166cc..6da6aecbb4 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0257666efc..7b8dc07adc * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/06a10da15f..f2fc757153 * third_party/r8/cipd: mYSxNBcKcdv-HE9jrIzdWaxdKITSSM0lbH_DTAVO4tcC..GdIzaPd-qIK7U0nz0iINlRfmvCQI73zL3OSNmyEXFWEC * third_party/six: https://chromium.googlesource.com/chromium/src/third_party/six/+log/580980eb7d..98dedb5909 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/266f8e4f13..6a2c6d01f5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/700365ffd9..0b97617ee6 No update to Clang. Bug: angleproject:5038 Tbr: solti@google.com Change-Id: I4d49f4627eb677650e01c6aa325223df7e3b0d7e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6956066 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b770a628 2025-09-17T03:09:44 Manual roll VK-GL-CTS from 4dea45108845 to 7f30dc62428c (1 revision) Manual roll requested by solti@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/4dea45108845..7f30dc62428c 2025-09-12 ziga@lunarg.com Test task shader with primitive type payload If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Iec95c20589dcc903f93cc6714cecab0af9e9d063 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6956786 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kenneth Russell baeea13f 2025-09-11T10:51:33 PLS: enforce rules around color attachment 0. Generate INVALID_OPERATION during draw calls if the following two rules are not satisfied: 1. If the fragment shader declares index zero output, then attachment zero must be present, and have a compatible numeric type. 2. If attachment zero is present, it must be enabled. This avoids complex and error-prone workarounds on macOS with AMD GPUs, and enforces the same simple and consistent rules on all platforms. Bug: angleproject:402810076 Change-Id: If029f677ca645060b8e7c2c4040e8a26d2aa2eb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6937659 Reviewed-by: Chris Dalton <chris@rive.app> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 13ab9ed5 2025-09-16T08:08:46 Tests: Fix slotomania trace name Previous name had a typo in it: - slotmania -> slotomania Test: angle_trace_tests --gtest_filter=*slotomania Bug: b/445241470 Change-Id: Ie1c7f99ddf683dce7c93b394d53a4c5b90f57158 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6954868 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
angle-autoroll 4abc99e3 2025-09-16T23:17:21 Manual roll VK-GL-CTS from bf9b8e7f0a4b to 4dea45108845 (3 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/bf9b8e7f0a4b..4dea45108845 2025-09-12 marcin.zajac@cognizant.com QuerySize query check for NULL texel buffers 2025-09-12 marcin.zajac@cognizant.com Fix validation errors in draw tests 2025-09-12 piotr.byszewski@mobica.com Generate mandatory features tests using vulkan_object If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Icbcae354129b4075c7e22f72712fe614c016c6aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6956064 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton ef9c5ce4 2025-09-07T17:50:37 Add a "noncoherent" layout qualifier to PLS Raster ordering can be expensive. If an app knows the geometry in a draw does not overlap, it can mark the PLS planes as noncoherent and opt for using barriers instead. Bug: angleproject:40096838 Change-Id: I2d686c2e64f51940face186637a9fcadcc251bef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923300 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
angle-autoroll 5968f540 2025-09-16T20:21:42 Manual roll VK-GL-CTS from 12633f4f5972 to bf9b8e7f0a4b (4 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/12633f4f5972..bf9b8e7f0a4b 2025-09-12 piotr.byszewski@mobica.com Use vulkan_object.py in gen_framework 2025-09-12 jbolz@nvidia.com Add support for forcing a test group to run in fraction 0. 2025-09-11 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-09-09 lorenzo@khronosgroup.org Add -Winconsistent-missing-override If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I90773ce2123b83d43ee807bea319cb1119d167b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6953470 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roberto Rodriguez 16771259 2025-09-12T11:10:18 Update main() prototype in shader if main() has been replaced. If the main() function definition has been wrapped/replaced in a shader and a main() function prototype is also present, the prototype needs to be replaced. Otherwise it will continue to reference the replaced main() which can cause issues with shader translation steps. Bug: angleproject:444653099 Change-Id: Ie6ce85cac89e026876a1b6e25cd294f1d8a536c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6944807 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Mark Lobodzinski cf04616b 2025-09-11T12:16:54 Trace/Replay: Make SetupReplayContext(main) last in setup The SetupReplayContext function for the main context was always executed first in the main setup replay function -- move it to last to minimize issues where Frame1 is expecting specific shader state from the main context. Test: angle_trace_tests --gtest_filter=*harry_potter_magic_awakened Bug: b/445208963 Change-Id: Ia48760e704465150617ffd33d419195723a51285 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6950246 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 8e7fa804 2025-09-15T14:06:38 Check shaderFloat16 feature support for enabling Float16 in Spirv According to VK_KHR_shader_float16_int8 device extension spec: "It introduces two new optional features shaderFloat16 and shaderInt8 which directly map to the Float16 and the Int8 SPIR-V capabilities." We should check if the shaderFloat16 is supported before we generate SPIRV that declares SPIR-V Capability Float16 Bug: angleproject:405795981 Change-Id: Ied7edfbed81ed5b862907c9bb1e772cb43acdb8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6919673 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Xiang Wang <xwxw@google.com>
Cody Northrop 90a12ea4 2025-09-15T23:29:55 Tests: Add Lineage2M trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*lineage_2m Bug: b/445241477, b/445419190 Change-Id: Ie9971a95ccf373e0dfb2701e0f316ff987a1b967 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6953461 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Shahbaz Youssefi f0370a41 2025-09-09T19:44:57 Vulkan: Use the GENERAL layout if VK_KHR_unified_image_layouts This lets ANGLE simplify synchronization by generally being able to use memory barriers instead of listing image barriers separately. Although the more specific access masks from VK_KHR_synchronization2 is possibly necessary for some hardware to work optimally (VK_ACCESS_2_SHADER_SAMPLED_READ_BIT in particular). It also lets ANGLE optimize a very specific scenario. Take an image used in the following scenario: 1. Copy to image in a transfer operation 2. Sample from image in the fragment shader of render pass 1 3. Sample from image in the vertex shader of shader pass 2 When GENERAL is not used, there's a layout transition between steps 1 and 2, changing the layout from TRANSFER_DST to SHADER_READ_ONLY_OPTIMAL (with dst stage == fragment shader). Later, at step 3, we need to make sure the vertex shader at least waits for this layout transition to finish... a dependency which is not expressible in Vulkan: * There cannot be a dependency to step 1, because the layout transition is not necessarily done * There is no stage mask that signifies the end of a layout transition. Without GENERAL, ANGLE has no choice but to issue a fragment->vertex dependency before step 3, serializing render pass 2's vertex pass with render pass 1's fragment pass on tilers. When using the GENERAL layout instead, step 3 can issue a transfer->vertex memory barrier, including using a VkEvent, parallelizing the two render passes. The above optimization is possible after this change, but not yet implemented. Bug: angleproject:422982681 Change-Id: Ieaae6f92b8b7d1e9c80c810a759c64b1e81d2dc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6936485 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 98915e44 2025-09-12T14:15:05 Vulkan: Fix blit src missing mip Bug: angleproject:433816259 Bug: angleproject:40644750 Change-Id: I50261279224dea8e37beff388207b927399d099a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6944327 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Cody Northrop e7b9bb3d 2025-09-15T19:12:37 Tests: Add trace batch for 2025-09-15 These traces were contributed by Samsung. Traces in this batch include: - slotmania - spider_fighter_3 Test: angle_trace_tests Bug: b/445240493, b/445241470 Change-Id: Iea862c88317f0fc793d6a1aa249399b538c0613e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6953240 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll a70f3d57 2025-09-16T10:57:22 Roll vulkan-deps from 484d6ecc00b6 to 90665ef518dd (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/484d6ecc00b6..90665ef518dd Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/46455d300c6d1435594aaeee7dc394060d31cab1..1614abe2a290062df11c142bfc67fccc56692133 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/bc980018ddfff551a988760e3d09803b2f1889f3..6ce15ebd721a74c7aae1f9c49033635b81224044 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/f4b28d2855e587bb3c287a75c23d8cc251d9111f..4ff7bc64c6881d8028251323d97a1078ebb60201 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/c9ed944bb39a564dbf15d0bdda63cc145018ed84..83cded838a1a6e2dadfda6b114c8e12135194718 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/34ea98ed3035293274f66d3590429da857ea2d2c..9819b31bed2a79cb88260d69ede346a92319ac8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I930927ebfbacc479ef8b7da1a2f9aec4a203873a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6953464 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c3b8e7e5 2025-09-16T07:01:26 Roll Chromium from 5f91357e141e to c960af7f560f (510 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5f91357e141e..c960af7f560f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0c8d2cd8fb..3afd36a297 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fbd5aafefc..57fef43213 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/481d414f76..4989759b31 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/06b834fb17..375b4c2e2a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/150db33178..35982166cc * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f7f5a32b3e..864f61dc92 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/cf32009cc6..4a68b52b89 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/adb45b6c6d..06a10da15f * third_party/siso/cipd: git_revision:02cbec18d7b18a0733fec402f2e90ff071b98f63..git_revision:e1e6b655eeb5da6f764ea736e9f5b1dbbd2859d6 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/ddfcb8b6ea..266f8e4f13 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/52f92e094f..700365ffd9 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I05fa53ca895dfe3e4f0091a08df6969890d74157 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6952892 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov 3760c722 2025-09-09T10:50:15 FrameCapture: Add compare_trace_screenshots.py fuzz_ab command Also add `compare_with_fuzz_factors()` and `get_common_files()` helper functions to avoid code duplication. Bug: b/294882956 Change-Id: Ibc12df0ec033db502930e8a7ea3b7be8b17a79b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6932073 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 7a630c62 2025-09-15T16:29:55 FrameCapture: Disable GL_EXT_texture_norm16 during capture Test: Lineage2M Bug: b/445241477 Change-Id: Ib4cfd87f0b79646965ea3e24db5b725062cfa725 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6951980 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Yuxin Hu b8281f5d 2025-09-09T17:15:26 Add condition check in emulate dithering shader code Prior to this change, the emulate dithering shader code will write to all elements of gl_FragData, regardless of whether the dither value is zero or not: gl_FragData[i] = gl_FragData[i] + dither_value. If dither_value is 0, then this doesn't change gl_FragData[i] and it incurs unnecessary shader writes. This change adds a boolean variable that is initialized to false, and it is only set to true if dither value for that output element is changed from zero to non-zero value. This way we are only issuing shader write operations when necessary. Bug: angleproject:425733272 Change-Id: Iacfd81ff9a1d7d0f71ecf8d119033b2500d2869e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6931777 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya b5e73d90 2025-09-12T12:43:17 Vulkan: Enhance EGLPrintEGLinfoTest Add tests that log features and vulkan extensions Bug: angleproject:386749841 Change-Id: I212aca3015292ed2bd5cd08216878a4bc56db0a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6944908 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi b496b7a5 2025-09-14T22:56:16 Vulkan: Bug fix to tracking of last non-shader-read-only access Observed when an image is sampled in one shader stage and then another, the tracking of which non-shader stage the image was last accessed in was accidentally showing the first shader stage the image was sampled in. Bug: angleproject:388307202 Change-Id: Ic809994b67c00226cad44d9dbedec923639ca5b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6947445 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll c3e28939 2025-09-15T11:14:41 Roll vulkan-deps from 2de7b0ea6642 to 484d6ecc00b6 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2de7b0ea6642..484d6ecc00b6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/bbe9759e73620f5d58f96a2ce925f6eb5f647386..46455d300c6d1435594aaeee7dc394060d31cab1 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/33b1bcbe210f22acfc77e54857ad6d81747976fc..bc980018ddfff551a988760e3d09803b2f1889f3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/344e4e6888b2a901bc7cf11028f8bc34c07738a8..f4b28d2855e587bb3c287a75c23d8cc251d9111f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/f7a6d134b827a17a1c75a5e04fbf04e97d5d9388..34ea98ed3035293274f66d3590429da857ea2d2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ia663b4296e134517e2017e37c0135b471354a7f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6948865 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f6a7b667 2025-09-15T07:30:39 Roll Chromium from 532eaf631818 to 5f91357e141e (670 revisions) https://chromium.googlesource.com/chromium/src.git/+log/532eaf631818..5f91357e141e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/750d2deee1..0c8d2cd8fb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7fc90e8960..fbd5aafefc * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0ea625751e..06b834fb17 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3accee0833..150db33178 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/53a68ac7f1..adb45b6c6d * third_party/r8/cipd: gt1-zSjnG7X9doAhlbcWFpH4PbBSW4tfzcbccnWr6cwC..mYSxNBcKcdv-HE9jrIzdWaxdKITSSM0lbH_DTAVO4tcC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/70aa0a702d..2a41c8cc1b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/476f572604..ddfcb8b6ea * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d9cc6f78c1..52f92e094f No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I9f8cf892fa6bf09496ccf977a47ee6d7eeab6909 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6947024 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jordan 81a181d1 2025-09-04T06:48:30 Fix README.chromium for llvm Bug:b/442971025 Change-Id: I772ce7559c76c5586a6ffd51e03d402e9d4bb47c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6914255 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jordan Brown <rop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop ab6a82e0 2025-09-12T15:57:43 Tests: Add trace batch for 2025-09-12 These traces were contributed by Samsung. Traces in this batch include: - cash_frenzy_casino_slots - dark_war_survival - qblock_wood_block_puzzle_game - yalla_ludo Test: angle_trace_tests Bug: b/444735013, b/444735404, b/444737091, b/444736902 Change-Id: I81ecadfa77cf80d090c1d04785d01ff2eb43b03b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6944911 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Igor Nazarov dce03998 2025-09-09T15:38:25 FrameCapture: Add discard_zero_diff_png argument ... into the "compare_trace_screenshots.py". Bug: b/294882956 Change-Id: I639e842d36c5f0b5233ad8f7855e9381743078be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6932072 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Igor Nazarov 238eaf1d 2025-09-09T15:14:02 FrameCapture: Fix ignoring compare_trace_screenshots.py --log Bug: b/294882956 Change-Id: I1e281b058c2f09f0dca3ce76648e385a3b443f0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6932071 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 1025f0a9 2025-09-11T17:11:43 Tests: Add trace batch for 2025-09-11 These traces were contributed by Samsung. Traces in this batch include: - archero_2 - bubble_shooter_relaxing - hole_io - my_talking_angela - race_master_3d Bug: b/444545431, b/444546028, b/444546358, b/444546046, b/444547452 Bug: b/444522928 Change-Id: I67987e4991b16207f4b45306ddee5e60ec2fbbf0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6941586 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 752363c8 2025-09-12T10:01:29 Roll vulkan-deps from 1f8b1e55c428 to 2de7b0ea6642 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1f8b1e55c428..2de7b0ea6642 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/1a98374227eceac2f3559d911ca94f814df62f74..33b1bcbe210f22acfc77e54857ad6d81747976fc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/3af548220a6a256fdb7e03443ce92d26b2fc3b84..344e4e6888b2a901bc7cf11028f8bc34c07738a8 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/0c746033e574bf741ef1a87e2e823f3fa733ab8f..f7a6d134b827a17a1c75a5e04fbf04e97d5d9388 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I20cad918d72cc6970be0f83dbd58a36d5a202e13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6942970 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov 4ee596cc 2025-09-09T10:43:41 FrameCapture: Fix compare_trace_screenshots.py versus_native ... when not using `--trace-list-path` argument. Also fix missing `--screenshot-dir ` argument in "README.md". Bug: b/294882956 Change-Id: Ie69707e4ad97f69182f7635fdd52e1576136f483 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6932070 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
angle-autoroll 80ca4c1e 2025-09-12T07:01:32 Roll Chromium from 01aafb610483 to 532eaf631818 (556 revisions) https://chromium.googlesource.com/chromium/src.git/+log/01aafb610483..532eaf631818 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ad10799874..750d2deee1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d20625351b..958004daac * testing: https://chromium.googlesource.com/chromium/src/testing/+log/138cc5cd74..7fc90e8960 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/c3563670ef..9d692d6692 * third_party/android_build_tools/manifest_merger/cipd: MFlelAeq9AjbPFiLMR9nSNIXDKTdmo99j3cyOZk_MPkC..-IKgMtIkFMuvZVpfM_1mWxAhbYzplqRHQ1JHqsbZ1RQC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/4fd4297496..74d30d13de * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0ba0717e2f..0ea625751e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5ed7fd0ea5..3accee0833 * third_party/fuchsia-sdk/sdk: version:29.20250901.2.1..version:29.20250911.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/b87b2bb112..0257666efc * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/52e894a82e..53a68ac7f1 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/db20dc9b3c..70aa0a702d * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/234fa32449..476f572604 * tools/luci-go: git_revision:7b865aedb41581e1413a79d784b44bb8121978a6..git_revision:49b2e707cefeee85697673b81627b3329debfae4 * tools/luci-go: git_revision:7b865aedb41581e1413a79d784b44bb8121978a6..git_revision:49b2e707cefeee85697673b81627b3329debfae4 * tools/luci-go: git_revision:7b865aedb41581e1413a79d784b44bb8121978a6..git_revision:49b2e707cefeee85697673b81627b3329debfae4 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/513bc2117e..28382daab7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bf97de0959..d9cc6f78c1 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/9dbbc10b2a..75a2b60baf No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I9d2075d35fd1433af2ea13a770b212d22fe73cce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6942530 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 46444b3d 2025-09-09T16:13:58 Vulkan: Use VkVertexInputBindingDescription2EXT to store stride This is preparation for next CL. Since most driver supports VK_EXT_vertex_input_dynamic_state, which uses VkVertexInputBindingDescription2EXT and VkVertexInputAttributeDescription2EXT to send stride/divisor/offset to the vulkan driver, why not store these directly in these structs instead of store gl::AttribArray<> and copy then into VkVertexInputBindingDescription2EXT/VkVertexInputBindingDescription2EXT later. This CL only replaced mCurrentArrayBufferRelativeOffsets, mCurrentArrayBufferStrides, mCurrentArrayBufferDivisors with mVertexInputBindingDesc and mVertexInputAttribDesc. It still does the data copy, which means this CL is mostly a mechanical change. But it makes the next CL diff smaller. Bug: b/439073246 Change-Id: Ie3c2034df07ea5e973b07a15f715fdb7c73ec04d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6933260 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 60f694c6 2025-09-10T11:55:58 Vulkan: Bugfixes in preferGlobalPipelineCache 1. per-program pipeline cache was being unconditionally initialized during warmup 2. mergeProgramPipelineCachesToGlobalCache should be disabled when preferGlobalPipelineCache feature is enabled Also, prefer use of global pipeline cache for Samsung. Bug: angleproject:386749841 Change-Id: Ifd66ef8c6d10b8a5ffd3c002239e8747f469ba47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6936119 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Sungyong Choi d917f771 2025-09-01T18:44:34 Vulkan: Simplify/Fix DmaBufImageSiblingVkLinux import probing Remove the multi-format probing logic in DmaBufImageSiblingVkLinux. Use the renderer’s base VkFormat and a single check with VkImageFormatListCreateInfo, instead of looping over mVkFormats with mutable/non-mutable combinations. This cuts down redundant queries and streamlines initImpl. Also, this CL fixes some issues occur when mapping DRM format into Vulkan backend formats. - Default to SampleOnly but prefer Renderable if the modifier properties exposes both sampling and rendering, since usage at import time is unknown. - Fix emulated-format handling issue by using getIntendedFormatID() and getActualImageFormatID() instead of deriving both IDs from VkFormat with GetFormatIDFromVkFormat() directly. Bug: angleproject:442313595 Bug: angleproject:426475684 Change-Id: Ia38d8e7901da10948a2c15eb284b055359dd4a2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6904888 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com>
hoonee.cho b5b46623 2024-11-07T16:14:12 CL/VK: ArgumentPointerUniform support NonSemanticClspvReflectionArgumentPointerUniform is generated replacing NonSemanticClspvReflectionArgumentPointerPushConstant if push constants size exceeds the limit (test_api min_max_parameter_size) Bug: angleproject:442950569 Change-Id: Ief1f6bb96db6d711dcaa147e1992020c9a33ae23 Signed-off-by: hoonee.cho <hoonee.cho@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916344 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Amirali Abdolrashidi 66ca0f48 2025-09-11T11:41:39 Vulkan: Extend BGR565 preference to Mesa * Updated the availability of preferBGR565ToRGB565. Bug: b/409867243 Change-Id: Iecda303bb13c2d99a78d326a192759640008eeb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6937661 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
hoonee.cho 46d75031 2024-11-06T17:12:05 CL/VK: ConstantDataPointerPushConstant support add compiler option "-module-constants-in-storage-buffer" to enable Module-scope __constants to be collected into a single storage buffer Bug: angleproject:442950569 Change-Id: I45b3776301a5cee8896cade71bce517dfad2eda2 Signed-off-by: hoonee.cho <hoonee.cho@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916343 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Charlie Lao c292f292 2025-09-10T14:34:14 Vulkan: Remove compressVertexData feature This feature was added for performance reason. It was used years ago to improve performance of lego legacy. That entire game dashboard feature was disabled a few years ago. So this code path is no longer been used now, and not been tested on bots as well. This CL deletes this feature and related code path so that we don't just leave it bit rotten. Bug: b/167404532 Bug: b/439073246 Change-Id: I384fc97021592da57d38e8c1771892071ae68a89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6935271 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
jh.eun 059734f9 2025-05-02T13:20:28 CL: Roll OpenCL headers, docs, CTS, loader Updated OpenCL headers and updated third_party sources accordingly. - Updated OpenCL Headers from change 265df85 - Updated third_party/OpenCL-Docs - Updated third_party/OpenCL-CTS and modified ninja build corresponding to update - Updated third_party/OpenCL-ICD-Loader and modified ninja build corresponding to update - When after updating OpenCL-Docs, entry-points for clIcdGetFunctionAddressForPlatformKHR and clIcdSetPlatformDispatchDataKHR (cl_khr_icd 2.0.0) are generated by run_code_generation.py. Filled code returning INVALID_OPERATION error in the entry-points. - When after updating cl_ext.h, cl_khr_external_memory_dx is removed. Deleted codes referencing cl_khr_external_memory_dx (e.q., CL_EXTERNAL_MEMORY_HANDLE_D3D11_TEXTURE_KHR) Bug: angleproject:441956395 Tests-Passing: test_basic, test_api Change-Id: I08e0b78abb5c0ff5f1ea693ea355893b1a6f765e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6915959 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Alexander Ovchinnikov 9530a896 2025-09-05T18:02:42 Don't use DXGI_SWAP_CHAIN_FLAG_FRAME_LATENCY_WAITABLE_OBJECT A swap chain for Windows.UI.Composition is created with DXGI_SWAP_CHAIN_FLAG_FRAME_LATENCY_WAITABLE_OBJECT flag, but is resized without it. This leads to an error, because according to MSDN, this flag cannot be changed by a call to ResizeBuffers. In fact, this flag is never used by any code in ANGLE, so we should remove it. Bug: angleproject:442600654 Change-Id: I3eecd96abd243433b402780c30634abf2528c323 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6919163 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Charlie Lao dcbe926e 2025-09-10T17:17:58 Vulkan: Avoid redundant updateVertexInput on disabled attribs When supportsVertexInputDynamicState feature is disabled, we are calling updateVertexInput right from VertexArray::syncState for both enabled and disabled attributes. But disabled attributes we are also calling contextVk->invalidateDefaultAttribute(attribIndex), which end up with VertexArrayVk::updateDefaultAttrib(), which calls updateVertexInput(). This means updateVertexInput() are called twice for disabled attributes. This CL skips onVertexArrayChange for disabled attributes. Bug: b/439073246 Change-Id: Icf9c08d1a920d9112ef4080b95d0451f6230c6dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6937213 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 36ff2883 2025-09-10T11:32:12 Vulkan: Remove redundant setDefaultPackedInput call VertexArrayVk::syncDirtyDisabledAttrib() is calling contextVk->invalidateDefaultAttribute(attribIndex), which will set DIRTY_BIT_DEFAULT_ATTRIBS, which triggers ContextVk::handleDirtyGraphicsDefaultAttribs() call, which calls updateDefaultAttrib(), which calls setDefaultPackedInput(). So the setDefaultPackedInput() call in VertexArrayVk::syncDirtyDisabledAttrib() is not needed. Further, when program changes we also invalidateDefaultAttributes(), which dirty all active default attribs, so we can rely on DIRTY_BIT_DEFAULT_ATTRIBS. Bug: b/439073246 Change-Id: Iae985697ace757462d1dbe24e5fdd967863e8674 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6935268 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 52884e7d 2025-09-09T09:41:49 Tests: Add Odin: Valhalla Rising trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*odin_valhalla_rising Bug: b/443970433, b/444333530 Change-Id: Ieed76508d9bfa7738236a21a9b3e4b5c97ebf207 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6930754 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Charlie Lao b71c7fd7 2025-09-10T16:17:10 Vulkan: Avoid recompute vertexArray attribute's ComponentType ContextVk::handleDirtyGraphicsVertexBuffers() is calculating vertex array attribute's component type. We actually already calculated and stored in VertexArrayState. This CL get the component type from VertexArrayState instead. The other benefit is that it removes the usage of formatId, which helps the next CL. Bug: b/439073246 Change-Id: I4ed32b5714fe48437af6f3a2f5da130ea71019a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6935272 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 35a3f874 2025-09-11T10:01:14 Roll vulkan-deps from 9b55d8906d6f to 1f8b1e55c428 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9b55d8906d6f..1f8b1e55c428 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/dee820e683500bf87e41c17a226fa7b9cd20b592..1a98374227eceac2f3559d911ca94f814df62f74 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/1ba658a39d2da0434e6ce3f0f41b7433d1d8fd10..0c746033e574bf741ef1a87e2e823f3fa733ab8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I18f465d663f8c80d2af221fce565cfe43e4b825e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6937653 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 547c5504 2025-09-11T07:56:57 Roll Chromium from c14d177aceb5 to 01aafb610483 (554 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c14d177aceb5..01aafb610483 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/361d91951d..ad10799874 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c597f18f7e..138cc5cd74 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b8160884f4..c3563670ef * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/053c2159ec..4fd4297496 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/863b506758..0ba0717e2f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/88e06ae96e..5ed7fd0ea5 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/e07e71553c..52e894a82e * third_party/r8/cipd: c5uRiviKwnpvuwxnd72Fas1gLwjrwA-_OsYLcIA1EWUC..gt1-zSjnG7X9doAhlbcWFpH4PbBSW4tfzcbccnWr6cwC * third_party/r8/d8/cipd: iGVAmwvi7lXeH5SCnaZ0PpcrSL_X8-fC6JbEKfYst-wC..gt1-zSjnG7X9doAhlbcWFpH4PbBSW4tfzcbccnWr6cwC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/01bb1b6895..db20dc9b3c * third_party/siso/cipd: git_revision:39f570f121d63078bca79de500f4f2a50cb37456..git_revision:02cbec18d7b18a0733fec402f2e90ff071b98f63 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/35fb33d2b2..234fa32449 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/969098a0e4..8e6c4696e2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a8246b09fe..bf97de0959 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I03cb58f1db260326fe50917459755d56c493983c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6937652 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop e0f5f3e2 2025-09-10T18:55:09 Tests: Add trace batch for 2025-09-10 These traces were contributed by Samsung. Traces in this batch include: - apex_girl - fashion_show - i9_inferno_nine - mob_control Test: angle_trace_tests Bug: b/444312058, b/444038530, b/444077873, b/444096901 Change-Id: I59f1e6eacb27f5968a138701e7f537c759904838 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6937765 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Geoff Lang a0cc64cd 2025-09-10T15:18:17 HLSL: Mark shadow sampler textureLod calls as using gradients TextureLod calls bottom out in the HLSL SampleCmp function which does not take a LOD parameter so we end up dropping it. This causes them to need gradients. Mark them as using gradient so that any loop they are used in is flagged and not unrolled by FXC. Reverted original fix from https://chromium-review.googlesource.com/c/angle/angle/+/6421496 because the wrong number of parameters are passed to the generated comparison sampling function when it is changed to LOD0. Thanks to Mikkel Simonsen at Unity and Calder Young for the tests. Fixed: angleproject:406190894 Change-Id: Ia9255e4336099045366c02f945a3c4de8075427a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6936488 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Amirali Abdolrashidi f27d1719 2025-07-29T16:41:27 Vulkan: Prefer BGR565 for RGB565 if enabled Some platforms exhibit better performance when using BGR565 instead of RGB565, including when loading buffer data to the image. This change allows such platforms to use a BGR565 image in the backend instead of an RGB565 image when using Vulkan, when the corresponding flag is enabled: preferBGR565ToRGB565 * Updated the formats to include B5G6R5 as a fallback to R5G6B5, which would be triggered when the corresponding feature flag is enabled. * The only exception would be when the surface is being initialized as R5G6B5. * In addition, this format will not be subject to forced format fallback. * Added VVL skip that specifically does not allow undefined format for border color for certain formats, including B5G6R5 if flag enabled. * Some suites with RGB565 tests will be run with preferBGR565ToRGB565 enabled on SwS to provide better test coverage. Bug: b/409867243 Change-Id: Ibb8c71b024ba318862f62ded8abd2d07835e8a40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6799253 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 428afbc2 2025-09-09T12:38:30 Vulkan: Remove hardcoded image layouts In some places, ANGLE assumed and hardcoded the image layout. This was often unnecessary, as the layout (or ImageAccess) was readily available already. In preparation for setting the image layout to GENERAL due to VK_KHR_unified_image_layouts, this change makes sure the image layout is not assumed to be anything specifically not GENERAL. Bug: angleproject:422982681 Change-Id: I831bed0ca20197bd7424295ab0858d6bce83fe81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6932268 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi 5c1ba222 2025-08-22T14:59:58 Vulkan: Add feature flag preferBGR565ToRGB565 * This flag will let certain platforms to prefer using BGR565 instead of using RGB565 for better performance in a follow-up change. Bug: b/409867243 Change-Id: If89eea1e801ca9d1c10021213862e967231a7343 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6876528 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi ad7ee7fa 2025-09-08T11:53:57 Fix RGB565/BGR565 loading functions The BGR565-related loading functions seem to have been defined based on D3D11, especially since D3D11 only has format support for B5G6R5. However, if other backends, such as Vulkan, try to use BGR565, the loading functions do not work as intended. This change aims to correct the loading functions in order to have a single loading methodology for all backends, and to prepare for the future changes that allow the proper usage of B5G6R5 for Vulkan. * Updated the component order in the loading functions related to RGB565 and BGR565. * Updated D3D function map and data related to BGR565 for consistency. * Reverted the PackPixels() exception for RGB565 in Renderer11. * Fixed typo in D3D format data. Bug: b/441803462 Bug: b/409867243 Change-Id: I4d3e497a9435bd65bdf64b527b094267a0353cb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916353 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Xiang Wang 28f18f4c 2025-09-05T12:27:46 FrameCapture: Add GL_TEXTURE_CUBE_MAP_ARRAY support Updated the CopyImageSubDataCubeMapArray e2e test with full rendering pipeline to draw on screen using default frame buffer. Tested that the frame capture will crash during game capture or the e2e test without the fix. Bug: b/419863436 Test: (enable capture sysprop) TextureCubeTestES32.CopyImageSubDataCubeMapArray/ES3_2_Vulkan Change-Id: I7c30ed0fc7304b528020e5ab4f9b23be952c5a51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916781 Commit-Queue: Xiang Wang <xwxw@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi e04b7198 2025-08-28T14:58:08 Fix BGR565 pixel functions It seems that the B5G6R5 read/write pixels switch the red and blue components due to them being based on D3D11, which does not seem to have native support for R5G6B5, instead using B5G6R5 and using the related loading functions to switch the two components. However, Vulkan supports both native R5G6B5 and B5G6R5, and using the latter format (e.g., using BGR565 in the backend instead of RGB565) causes errors in the tests. * e.g., the test BlendPackedTest.RGB565/ES2_D3D11 would fail if the readColor() for B5G6R5 is changed to switch red and blue, although the test is regarding RGB565. This does not affect Vulkan, but if BGR565 is used in Vulkan, the test would fail without this switch. * Fixed the order of the component values in B5G6R5 read/write functions. * Updated packPixels() in D3D11 renderer to use R5G6B5's functions when the internal format is GL_RGB565 and the texture's format is BGR565. Bug: b/441803462 Bug: b/409867243 Change-Id: Ia4883f6dfb5d96e77bbdc087f48e7ffca42a5657 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6847283 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Liza Burakova 718cdb91 2025-09-08T15:32:34 [WebGPU] Set ReadPixels to use context's command encoder. This change modifies ContextWgpu::getCurrentCommandEncoder() such that it now ends a render pass if there's an active one, ensures a command encoder is created, then sets an outHandle command encoder. This streamlines a lot of repetitive calls when getting the command encoder. This change also modifies ImageHelper::readPixels such that it now gets the command encoder from the context instead of making its own. This ensure that when the queue is submitted for a read call, that any draw/clear/etc calls in the queue are also submitted for a texture so that a read call can properly read from the texture. Bug: angleproject:438268609 Change-Id: Iec6d7f7ca27c7640cc8bdb42da53f64e4836dc5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923328 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Matthew Denton a471c005 2025-08-19T17:24:38 WGSL: derivative_uniformity diagnostic should be a warning WGSL requires derivatives to be calculated only if it can statically prove control flow is uniform. GLSL allows dynamically uniform control flow in this case. This CL uses WGSL's diagnostic filter to make derivative_uniformity diagnostics into warnings, to match GLSL semantics. Bug: angleproject:392542001 Change-Id: I98dd55205ad6d3c9d13ca3f94c0e7858ba92d536 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6862844 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Xiang Wang e77725a4 2025-09-02T12:14:55 Add VkFormat id to descriptor cache key's imageSubresourceRange This is to fix the bug when two shaders are modifying the same texture buffer but with different formats, the old buffer view with "incompatible" format can be reused. Bug: b/443105853 Change-Id: Ic3b2202a7d1d408fbbf826414bfcf2b1df4c3a15 Test: GLSLTest.TextureBufferWritesUsingDifferentFormats Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916350 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Liza Burakova f32fa362 2025-09-02T16:14:44 [WebGPU] Add helper methods for streaming indices in syncClientArrays Bug: angleproject:401499251 Change-Id: I2cab62524ce92a01117282726a3d4de1c266f818 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6438259 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jisun Lee 7619f8a0 2025-06-11T00:44:36 Fast copy R8G8B8A8_UNORM / R8G8B8A8_UNORM_SRGB for readPixels Support FastCopyFunction on R8G8B8A8_UNORM and R8G8B8A8_UNORM_SRGB. Copying src pixels to dest directly is more performant than converting UNORM to GLfloat. Bug: b/429541195 Tests: dEQP-GLES31.functional.srgb_texture_decode.skip_decode* Change-Id: If9a3d75dbf7b9fd286a61b144ed607144c833740 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6704713 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 52665e89 2025-09-09T14:52:38 Tests: Add Domino Dreams trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*domino_dreams Bug: b/444034769 Change-Id: I9930b05b8cc16ca281fcb748b8889ff3a9426b64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6931774 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll c937f129 2025-09-10T12:07:57 Roll vulkan-deps from af8c2ea541d3 to 9b55d8906d6f (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/af8c2ea541d3..9b55d8906d6f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/055b25c02fa80cdcca77fcf94ab64a02f02d9199..bbe9759e73620f5d58f96a2ce925f6eb5f647386 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/54ae32bce772b29a253b18583b86ab813ed1887c..01e0577914a75a2569c846778c2f93aa8e6feddd https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/337fdb6a284fe7f7e374a14271f8e20e579f3263..dee820e683500bf87e41c17a226fa7b9cd20b592 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/32deb15853e1a3c442fc2820066995758821546a..c9ed944bb39a564dbf15d0bdda63cc145018ed84 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/34edde1191548c51cf4958f2dc6772bf7f76c8cd..a0543a68cca0de632c010724fad08fce0bc27679 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/af5376ef7061716a95ab2bc321aeae4f77958a28..1ba658a39d2da0434e6ce3f0f41b7433d1d8fd10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I11022dc9108495ba387974666af12fd68cf1c0cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6935266 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 335a1fda 2025-09-09T14:06:27 Tests: Add Brain Test: Tricky Puzzles trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*brain_test_tricky_puzzles Bug: b/444026267 Change-Id: If2fdbe6c21ef55ad41cac38e18aaa829c87ae9eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6931773 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
angle-autoroll 6b3232ae 2025-09-10T09:31:43 Roll Chromium from d4e5be2db70e to c14d177aceb5 (705 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d4e5be2db70e..c14d177aceb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cbd5cdbb19..361d91951d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/10b037a661..d20625351b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1d8aae3c6d..c597f18f7e * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7962db2867..b8160884f4 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/c347f4a5a5..481d414f76 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3c5077921d..863b506758 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3ca8f4784d..88e06ae96e * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/954086abf1..b87b2bb112 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/2d2b9785f9..e07e71553c * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/a90f9bcc20..01bb1b6895 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/a20cce9e2d..35fb33d2b2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/887b4e835a..969098a0e4 * tools/luci-go: git_revision:f58a984f19eeed333afe8ec2e167cb7197dca7f5..git_revision:7b865aedb41581e1413a79d784b44bb8121978a6 * tools/luci-go: git_revision:f58a984f19eeed333afe8ec2e167cb7197dca7f5..git_revision:7b865aedb41581e1413a79d784b44bb8121978a6 * tools/luci-go: git_revision:f58a984f19eeed333afe8ec2e167cb7197dca7f5..git_revision:7b865aedb41581e1413a79d784b44bb8121978a6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3354d77a77..a8246b09fe * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/4b27f72dd2..9dbbc10b2a * tools/skia_goldctl/linux: 0reqJkEekQRnJ-rFL80hFTkXvC0uuptBZeiraNZj2NUC..hV2dfcJ5iud2DblnB27NWew6qYb6HipSH86rBfdGh1EC * tools/skia_goldctl/mac_amd64: DBaYppt36tqyLb4_UgQ681mSTT8PKBAB6xmsdcGpytUC..r6FpOxWU9iELjJeuq72JTfmKs93KTxpbkt6RwybYABoC * tools/skia_goldctl/mac_arm64: Eqcsof-0qbc-C7HqbVjjTmBIx7JiwRPOIj0lQCA-fn0C..0DvbA0ox2ZUvnTJFNQMtNGdwzeJbpCaAZQcQYyiFTpMC * tools/skia_goldctl/win: GcCLRtRDIafGi3F6e48loAb3FeWZVPE6iAb04xL5QpAC..k1h3MReK-_5P1okvxqyXSeNIJ1EaFV5dfHokEHQUKpcC Clang version changed llvmorg-21-init-16348-gbd809ffb:llvmorg-22-init-6852-g2384a6a2 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/887b4e835a6081ca35b5f3407c944e0b96d9408a..969098a0e4489f341a27c3b11d5b2b68b001bb38/scripts/update.py Bug: None Tbr: yuxinhu@google.com Change-Id: I13193e21372ff884dfdae12354199f5ebb65abff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6935264 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop fba2e7e9 2025-09-09T13:45:55 Tests: Add Snake Lite - Snake Game trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*snake_lite Bug: b/444021690 Change-Id: I3fda5f4d28466607a274934325f179e693396c44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6931772 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 3570e579 2025-09-09T11:04:20 Tests: Add Two Player Games trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*two_player_games Bug: b/443989221 Change-Id: Ie5dd28d6871adbc2bf42de10a934f72844b350c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6931372 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 7e869843 2025-09-09T11:43:22 Tests: Add Cat Runner: Decorate Home trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*cat_runner Bug: b/443995610 Change-Id: I5388f04dfa17324666fb0ac2ca52d78613b3ba48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6931373 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Xiang Wang <xwxw@google.com>
hoonee.cho 1df3b59f 2024-10-30T16:40:51 CL/VK: PrintfBufferPointerPushConstant support Bug: angleproject:442950569 Change-Id: I64edba5a04c2f1f2d3eb7bb34e6629f12269a69c Signed-off-by: hoonee.cho <hoonee.cho@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916342 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
hoonee.cho 55063f5e 2024-11-06T09:26:38 CL/VK: ArgumentPointerPushConstant support - use physical storage buffers instead of storage buffers - add CLSPV compile options "-arch=spir64 -physical-storage-buffers " - fix NonSemanticClspvReflectionArgumentPointerPushConstant logics Bug: angleproject:442950569 Change-Id: I76a8c3fa6ea87c153022a5976f2914bd62cdfcf1 Signed-off-by: hoonee.cho <hoonee.cho@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916341 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Shahbaz Youssefi 166c9e23 2025-09-05T12:52:38 Vulkan: Separate barrier data into its file vk::Renderer includes a modified copy of kImageMemoryBarrierData. When using VK_KHR_unified_image_layouts, even more of this data is modified based on device features. Leaving kImageMemoryBarrierData in vk_helpers.cpp runs the risk that it's accessed directly instead of using the copy in vk::Renderer. Bug: angleproject:422982681 Change-Id: I7e288ef0ac519c53842214fe934ba7b2474e1f9c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6927350 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 823c60bc 2025-09-08T15:05:21 Tests: Add Hero Wars: Alliance trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*hero_wars Bug: b/443793326 Change-Id: I70db881b22f64d9c9bce2a061363d3ba300bb5bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6926590 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Cody Northrop 1a290707 2025-09-08T14:44:50 Tests: Add Block Craft 3D trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*block_craft_3d Bug: b/42264359 Bug: b/443788675 Change-Id: I541ecc84ec5d9e77624c5c7afd225ac89a5f7ce4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6926021 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Charlie Lao 352900dd 2025-09-08T11:54:22 Fix BitSetArray::bits for 32 bit Which was causing compilation issue on some platforms. Bug: b/439073246 Change-Id: I6863f28af3fa5364b7739f2ff61520c9e775752d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6925089 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 493aa87d 2025-09-09T03:01:57 Roll SwiftShader from 14f87286123a to 3877515497c0 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/14f87286123a..3877515497c0 2025-09-08 swiftshader.regress@gmail.com Regres: Update test lists @ 14f87286 2025-09-08 brunopitrus@hotmail.com Reland “Make Reactor buildable with LLVM 18” If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I0a6c3f39999f0a14f05bc56089825a2e63b260c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6929871 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 979c66ec 2025-09-09T07:21:59 Roll Chromium from 036558884dbf to d4e5be2db70e (587 revisions) https://chromium.googlesource.com/chromium/src.git/+log/036558884dbf..d4e5be2db70e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/396bde5914..cbd5cdbb19 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b8aba99a05..1d8aae3c6d * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/6d1d8024dd..053c2159ec * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9c3171ffea..3ca8f4784d * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3601008ab2..2d2b9785f9 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/0e03294673..a90f9bcc20 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e34b8ce2ad..a20cce9e2d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a90208e570..3354d77a77 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/7ae3c976eb..4b27f72dd2 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ide758264316274e0f2dcab452ec0266b89c1fa33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6929442 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7d1e4e16 2025-09-08T12:14:57 Manual Roll vulkan-deps from 5107e9eef1bc to af8c2ea541d3 https://chromium.googlesource.com/vulkan-deps.git/+log/5107e9eef1bc..af8c2ea541d3 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/f6940d2b8a9dc6de805c48eb3e8bafd65118b25c..337fdb6a284fe7f7e374a14271f8e20e579f3263 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/dc22b23433ab3a390b4c75710836691fdb6f11f4..af5376ef7061716a95ab2bc321aeae4f77958a28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:443133082 Tbr: yuxinhu@google.com Change-Id: I577cc5555b99aa1f903313a83d96ed755634dd79 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923245 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi ebf29178 2025-09-05T12:15:23 Vulkan: Rename ImageLayout to ImageAccess This enum really describes how the image is accessed, including what VkImageLayout it should be in for that access. With VK_KHR_unified_image_layouts, it makes little sense to call this enum ImageLayout anymore, given how almost all of them will have VK_IMAGE_LAYOUT_GENERAL. Bug: angleproject:422982681 Change-Id: Id0ea107d339457e90b7a167292b75211eb42f803 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6918518 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 020e41d2 2025-09-08T12:21:51 Tests: Add Mini Games: Calm & Relax trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*mini_games_calm_and_relax Bug: b/443739993 Change-Id: Ide3ba54ec926f1ea99b50dc134c7b8094bfebb6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6925086 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
hoonee.cho e9a30817 2024-10-28T14:54:38 Vulkan: Support vulkan physical addr in vk_helpers - Add extraAllocationInfo for physical addressing in AllocateBufferMemory/AllocateImageMemory - Add getDeviceAddress which calls vkGetBufferDeviceAddressKHR API to get device address In CL, All the physical addressing supports are enabled when the runtime flag "supportsPhysicalAddressing" is set. Bug: angleproject:442950569 Change-Id: I1658062b3f031b3d55923937947cece0c1b67d67 Signed-off-by: hoonee.cho <hoonee.cho@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916340 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Shahbaz Youssefi 26926a8b 2025-09-08T13:07:49 Vulkan: Rename CommandBufferAccess to CommandResources CommandBufferAccess was named as such to indicate "what the command buffer is going to access". The new name indicates "what resources are the following command going to use". The rename is happening to reduce usages of "access", in preparation for introducing another "access" which can be confused with this. Bug: angleproject:422982681 Change-Id: Ib072cde8533515ba76734b6426b4d673cb07cc45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923331 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 0042de5f 2025-09-08T12:04:33 Vulkan: Rename ImageAccess to ImageFormatSupport `ImageAccess` to be used for other purposes. Variable name `access` was also identical to variables of `CommandBufferAccess`. Bug: angleproject:422982681 Change-Id: I69b4d2bd773f1c5ff0fb15c7b611efd1f736061d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923330 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0