|
072eec08
|
2025-01-21T13:09:44
|
|
Use `exec_script_allowlist` in GN now that it is available.
This CL renames the gn dotfile variable `exec_script_whitelist`
to `exec_script_allowlist`, in order to be more inclusive.
Bug: chromium:40713186
Change-Id: Iaf5ef131a64f3189e675acfd090c7043c3138df8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188240
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
6afff893
|
2024-07-24T10:05:37
|
|
Roll Rust tools with Chromium
Bug: angleproject:349994211
Change-Id: I9360b869e59365ff41d35359ce5af47c878fa89f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5736063
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
b71fe1c5
|
2024-05-16T15:10:09
|
|
Flatten vulkan-deps.
Sub-repos will be now checked out in third_party directly,
instead of under third_party/vulkan-deps.
Bug: chromium:341002187
Change-Id: Ia1c10ce5e7865c164b29bdcabb6ab8a7e4ae35b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5545577
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
e8a3493f
|
2024-02-14T21:51:00
|
|
Initialize DisplayWgpu
This change adds basic initialize to DisplayWgpu as well as adding
APIs for DisplayGLX and DisplayWgpu. These APIs are necessary to ensure
DisplayWgpu doesn't pull in necessary X11 headers that break builds.
Bug: angleproject:8477
Change-Id: Icc6d9e7246a741def7a0337a296f9c1f9cec1415
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5259979
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Liza Burakova <liza@chromium.org>
|
|
b8d5a423
|
2023-08-21T14:43:42
|
|
Add static_assert(std::is_trivially_copyable<LinkedUniform>(),"")
Since we are using memcpy for LinkedUniform, it is desirable to utilize
compile time assertion to ensure that in future if anyone modifies POD
struct (and the class of data members of POD struct) and made it that no
longer memcopy-able, we would immediately caught at compile time.
std::is_trivially_copyable<>is exactly for this reason. In order to make
this work, the POD struct and any data it uses can not have user defined
copy constructor. The problem is that right now ANGLE is using
clang_use_chrome_plugins=true, and chrome-style generates warnings if
the complex struct (has more than 10 data members) does not define a
copy constructor, and that warning causes build failure with -Werror. So
clang_use_chrome_plugins=true and std::is_trivially_copyable have this
conflicting requirements that I can not apply both. This has been raised
to compiler team, but before we get a solution from them, if we have to
make a choice, I think the better choice is to disable
clang_use_chrome_plugins and apply std::is_trivially_copyable, since the
later is more critical to ensure safety, while chrome-style is mostly
trying to minimize the code size, but won't affect
correctness/robustness. This CL sets clang_use_chrome_plugins to false,
and removes the copy constructor and copy assignment operator from
BitSetT and LinkedUniform and added static assertion
is_trivially_copyable for LinkedUniform. Same thing applied to
ProgramInput as well.
In future once we have a better solution from compile team, we can
re-enable clang_use_chrome_plugins and disable only for structs that
requires is_trivially_copyable assertion.
Bug: b/275102061
Change-Id: If33415ea61deda568d855a7dd6a4fd6042058be5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4799342
Reviewed-by: Roman Lavrov <romanl@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
219776e2
|
2023-03-28T09:56:25
|
|
Roll Chromium from c83e966b4c7e to f7c2a70f23b1 (1902 revisions)
Disable Rust toolchain support in standalone ANGLE,
to avoid unnecessary dependencies.
https://chromium.googlesource.com/chromium/src.git/+log/c83e966b4c7e..f7c2a70f23b1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/32e94e55de..052437a6e1
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0a6c69640f..c97a3b8902
* buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e44019bfac..26ace673c4
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f132d63e88..df3b0c9f14
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/4189179faf..115fe1141d
* third_party/android_sdk/public: 3Yn5Sn7BMObm8gsoZCF0loJMKg9_PpgU07G9DObCLdQC..EWnL2r7oV5GtE9Ef7GyohyFam42wtMtEKYU4dCb3U1YC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e838386fa0
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/479e1e9055..df528a9d7a
* third_party/fuchsia-sdk/sdk: version:12.20230322.3.1..version:12.20230327.3.1
* third_party/kotlin_stdlib: zeFlVAEGvnpaj3JJujWHzRlUiBEm4XeeaMQzVsdW6D4C..XON2v801ZWS7FjApXO8Ev7Me7cOsIAnmqzyCXJuMwJ0C
* third_party/r8: EGf7RQo3stt-vPTw69TaMGuNtnOx0Dbk1O-MBquwswYC..BTs9W6pUBDK8YTePjjF3Q0-ZQo1snO7GBCT6frWMIj8C
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7a7207a7f2..04d87bfe25
* tools/luci-go: git_revision:320bf3ed60cd4d24549d0ea9ee3a94394f2665ce..git_revision:3569ebf36f17a991aa4d26fd6e228cdf6e664d13
* tools/luci-go: git_revision:320bf3ed60cd4d24549d0ea9ee3a94394f2665ce..git_revision:3569ebf36f17a991aa4d26fd6e228cdf6e664d13
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/db6ffdf0ba..993b50afde
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/b55593f4dc..13f0b81ce5
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b87bb2fac8..892ad5cc94
* tools/skia_goldctl/linux: iQ7zKud-gha6r9hEdwqYWRdOpeAs6gFfDxnviDUt4FQC..CHIKK9YvBNPOM_lAlqkfs4dTTbM6I-AKggA94sfc5PoC
* tools/skia_goldctl/mac_amd64: 9Wfje1bt82IO9pJokAt9lboy59X_Pe-s0b4EpmH7RT4C..Gwb7laBBhkBhwP1nIoAb1EwklQ5sEon7g7r76v7jAasC
* tools/skia_goldctl/mac_arm64: zihT2Lk2afg0XzIZozuGcZXWv7RJujaDEi_6q7QL4DgC..Jh19SHnigVXYxpk7Fp4ZDMF_ZvLpQUie2NMaK5aEISMC
* tools/skia_goldctl/win: we56UJIWxJJ2GkQ_ne0o3oGAr7FBJa5T5Jr1xguLn-gC..pUOVquC14y84RkNMzEAPw_7tztey-kvH7KBwGsFViuIC
No update to Clang.
Bug: chromium:1292038
Change-Id: Ie7f8204e241101673768257be9c003343bc47256
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4376783
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
7108e069
|
2021-06-08T09:55:11
|
|
Roll Chromium from 3bcc8fd7c291 to 6c5859c895f5 (510 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/3bcc8fd7c291..6c5859c895f5
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e353b02625..8870cb4120
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0b443d31ef..c793cca886
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a45949a818..a62f8260df
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/42884eb2ac..887e8d9009
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d598390f02
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a5b6b2f8b7..b508ecd932
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/9523daa51d..82f8803671
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0c64e8349d..09481f56be
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d5d794a9f5..94630dfc19
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/71214b910d..84ad259424
No update to Clang.
Manually added tools/android/modularization/convenience/lookup_dep.py
from crrev.com/889754
And updated .gn to use python3 in GN build by default
Bug: angleproject:6042
Tbr: syoussefi@google.com
Change-Id: I00384f4d38d14b54778d334aec9c633f54d619bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946825
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
d170f8e1
|
2021-04-20T19:17:17
|
|
infra: Add configs for Android build.
Updates the configs to use the new protobuf properties. Adds
support for ARM/ARM64 Android builds.
Must be landed in conjunction with http://crrev.com/c/2841787 .
Bug: angleproject:2344
Bug: angleproject:5114
Change-Id: I49f4f46ceaa7ce9118c9f4b4ceb06353b00429b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842306
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
68f1203d
|
2021-04-13T21:55:07
|
|
Disable location tags in test isolates.
The current setup has problems producing tags in an ANGLE checkout.
Bug: angleproject:5114
Change-Id: I91864650ddb2a9df0ac533bf4c43259c476a99ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822238
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
acd15cae
|
2020-10-11T17:16:34
|
|
Re-land "Link C++ histogram support into angle_perftests."
This is the first step in uploading histogram data instead of a gtest
special format. We importing several new libraries:
- tools/protoc_wrapper
- third_party/protobuf
- third_party/catapult (was already used for Android)
No functional change. Only affects compilation. Protobuf support is
disabled when not available.
Bug: angleproject:5161
Change-Id: I64be0977648993b1012ff0d9e0439c5876697e36
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497221
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
4953f03d
|
2020-10-23T22:57:43
|
|
Revert "Link C++ histogram support into angle_perftests."
This reverts commit 7a0263547cda936b320d80c650b69d7522ee1a9f.
Reason for revert: Breaks roll of ANGLE into AOSP:
ERROR at //testing/test.gni:76:5: Assertion failed.
assert(_use_raw_android_executable || enable_java_templates)
^-----
See //third_party/catapult/tracing/tracing/BUILD.gn:35:1: whence it was called.
test("histogram_unittests") {
^----------------------------
See //src/tests/BUILD.gn:262:17: which caused the file to be included.
deps += [ "//third_party/catapult/tracing/tracing:histogram" ]
^-------------------------------------------------
Original change's description:
> Link C++ histogram support into angle_perftests.
>
> This is the first step in uploading histogram data instead of a gtest
> special format. We importing several new libraries:
>
> - tools/protoc_wrapper
> - third_party/protobuf
> - third_party/catapult (was already used for Android)
>
> No functional change. Only affects compilation. Protobuf support is
> disabled when not available.
>
> Bug: angleproject:5161
> Change-Id: Ie28d57d7e142c437ebd51463ce3e2cafd87468d1
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2482294
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
TBR=ynovikov@chromium.org,bsheedy@chromium.org,jmadill@chromium.org
Change-Id: I62c4b926cbe82d10e460b28b5f864521e2b1f8ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:5161
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495549
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
7a026354
|
2020-10-11T17:16:34
|
|
Link C++ histogram support into angle_perftests.
This is the first step in uploading histogram data instead of a gtest
special format. We importing several new libraries:
- tools/protoc_wrapper
- third_party/protobuf
- third_party/catapult (was already used for Android)
No functional change. Only affects compilation. Protobuf support is
disabled when not available.
Bug: angleproject:5161
Change-Id: Ie28d57d7e142c437ebd51463ce3e2cafd87468d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2482294
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
e815afbf
|
2020-09-07T22:09:22
|
|
First pass at increasing inclusivity
Link to the inclusivity rules
https://source.android.com/setup/contribute/respectful-code
Bug: b/162834212
Bug: chromium:1097198
Change-Id: Ied5a9e3879d72bff3f77ea6fcda9b82f30c32c2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2396737
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Trevor Black <vantablack@google.com>
|
|
|
a42a7f06
|
2020-09-16T12:39:09
|
|
Remove setting a default value for use_custom_libcxx
Update the .gn to remove forcing use_custom_libcxx = false. Instead, let
//build/config/c++/c++.gni determine the value, which should better
match Chromium.
In particular, this helps with Abseil integration by supporting Windows
component builds by better matching the contents of the .def files.
Bug: angleproject:4873
Test: CQ
Change-Id: If8c064f16459292bfb95113a4d78e14e8923f86f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414739
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
f1e3609c
|
2019-05-13T08:55:54
|
|
angle: Stop setting secondary_source.
It's no longer needed.
Bug: chromium:947060
Change-Id: I873f17a4876b9d0fac313740853054b6867afeb9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610077
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
|
|
66ae5315
|
2019-04-01T16:35:53
|
|
Add a mac_toolchain update DEP. Update use_system_xcode to match Chrome.
BUG=948286
Change-Id: I85f44622efaf4f018d00046e4fc5dc0757f38539
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545127
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
ab2bfa81
|
2019-01-15T19:06:47
|
|
Enable Chromium clang style plugin for libANGLE.
This fixes a few style warnings:
* auto should not deduce to raw pointer type
* inlined virtual methods are not allowed
* non-trivial constructors and destructors should be explicit
* inlined non-trivial constructors should not be in-class
* missing override keywords
Bug: angleproject:3069
Change-Id: I3b3e55683691da3ebf6da06a5d3c729c71b6ee53
Reviewed-on: https://chromium-review.googlesource.com/c/1407640
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
624ce6a3
|
2019-01-04T14:17:24
|
|
Pass GN header visibility check.
Updates angle_util to see the loader includes even if the loader is not
enabled. This makes the GN check happy.
Bug: angleproject:3052
Change-Id: Ifd23070385beefede4358c7b4c1823dc87b5ded8
Reviewed-on: https://chromium-review.googlesource.com/c/1395809
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
a7f97a27
|
2018-08-21T00:04:05
|
|
Gyp is dead. Long live gn.
Remove the gyp build. The .gypi files were not renamed so that diff and
rebase would work on this change. They will be renamed in a separate
change.
BUG=angleproject:1569
Change-Id: If8a217027633293664b820104f91a4ca5889b24e
Reviewed-on: https://chromium-review.googlesource.com/1187380
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
9d4277b0
|
2018-05-21T16:22:22
|
|
Enable sysroot install on x86 & x64 based-systems
For builds set "use_sysroot = true" by default
This is intended to fix a bot config that is hitting a build error with
latest Vulkan validation layer roll.
Bug: angleproject:2560
Change-Id: I06edfc7b74f367bbab23fea6f01b2778b12a470a
Reviewed-on: https://chromium-review.googlesource.com/1068031
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
9b1462a0
|
2018-05-21T16:40:57
|
|
Roll fwd ANGLE chromium DEPs
Roll build, buildtools, clang, testing, googletest, zlib, gyp.
Bug: angleproject:2560
Change-Id: Ic7f2a8bbdb9f6ff3bca1cd6d7ba424add7d086ad
Reviewed-on: https://chromium-review.googlesource.com/1068064
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
7b7ada6a
|
2018-02-05T14:49:15
|
|
Add a dotfile_settings GN config file.
This file will be imported into both ANGLE's and Chrome's .gn files so
we can share some of the same settings. This will mean we no longer
have to patch Chromium to make changes to the exec script whitelist.
Bug: angleproject:2339
Change-Id: I2d7dd4237488ffecf5376643447ad95a0c1dbf98
Reviewed-on: https://chromium-review.googlesource.com/902324
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
d0ef13a2
|
2017-08-28T22:53:24
|
|
Stand-alone build with gn.
This should do the same things as the stand-alone gyp build, but with gn.
You should switch to gn as gyp support will go away.
You need a recent enough version of gn. If yours is too old try this one:
./buildtools/linux64/gn
If "gclient sync" or anything fails with an ImportError on gyp stuff,
try running it with the following PYTHONPATH in the environment:
PYTHONPATH=tools/gyp/pylib
BUG=angleproject:1569
Change-Id: I56d19bec2d8b649a7bd65062c656cbfc69ea3dd8
Reviewed-on: https://chromium-review.googlesource.com/642588
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
|