|
a63c2826
|
2025-03-08T16:12:40
|
|
Skip MultithreadingTest.ProgramLinkAndBind on Intel/windows
Due to flakiness
Bug: angleproject:401554049
Change-Id: I7210ff90c6de3d9b225d1e3a65df3cc4452fc9d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6334634
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
0331847e
|
2025-03-07T16:32:41
|
|
Vulkan: Update VkGraphicsPipelineCreateInfo::flags
... with protected access bits if VK_EXT_pipeline_protected_access
is supported
Bug: angleproject:42265839
Bug: angleproject:391002353
Change-Id: Ibb00a4a0dcb1084046403bf4bfaeeb8d125b9aea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6336515
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
113bd9ef
|
2025-03-08T11:26:16
|
|
Manual roll vulkan-deps from e369814ee08e to adee401e9cba (14 revisions)
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/e369814ee08e..adee401e9cba
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/19d232bb93a8585236051094cf49f747cc892e26..92356079fb9c9f6aa5c9c7766d5f8c5d52f436c3
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/0f0cfd88d7e6ece3ca6456df692f0055bde94be7..cacef3039d277c448c89336290ec3937270b0996
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/1bc9d032a89ef9b09e5b395d2f93fcd59fedf8ad..8491f31d36a8c642e588220b89729129721fec31
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/7efad3a101ea6e641e5948a4ed0d6e93b99b7bff..2bcf294ed82185b17c6c73ff512033a59dedb12d
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/50563f48368d75281bc2fb1c3407dc531ce28910..bc3a4d9fd9b46729651a3cec4f5226f6272b8684
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/85582585bee9e1ff7660dafeba76afcb524dbed3..789e54cec2e2c8e134522cc90f4b327852cdf0de
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com,ynovikov@google.com
Change-Id: I76a1b65476db8197efddf004d55e72b7d655e058
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6337447
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
1cd6194d
|
2025-03-07T18:37:45
|
|
Manual roll vulkan-deps from d34de7171c18 to e369814ee08e (8 revisions)
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/d34de7171c18..e369814ee08e
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0e5ff759622e16fa55e515895ca049a9056d68be..3b495e1450b19dd79c4493ec2fe9698d003e209f
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/d3fc6ed183bd375538d3ca6d45d160470b3b6cdc..ba828b232c88c572624476c03c284a09c1b34f55
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/dd0c2e4afdf11fcec55902c92865e57768af928a..7efad3a101ea6e641e5948a4ed0d6e93b99b7bff
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ad204746d6f25d00c38cb870e9c67b919eb96a9b..85582585bee9e1ff7660dafeba76afcb524dbed3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com,ynovikov@google.com
Change-Id: I426e9a538b65ae83333e05526ace11163063e9b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6336504
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
412bd05c
|
2025-03-06T19:26:11
|
|
Implement workaround for MAX_COMBINED_SHADER_OUTPUT_RESOURCES.
Implement a GL Feature to force MAX_COMBINED_SHADER_OUTPUT_RESOURCES to
be the sum of MAX_COMBINED_SHADER_STORAGE_BLOCKS,
MAX_COMBINED_IMAGE_UNIFORMS, and MAX_COLOR_ATTACHMENTS.
Enable the feature for NV and PowerVR Rogue.
Bug: angleproject:401232345
Change-Id: I03a113eed364617303f4ee59d90c853258865259
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6330671
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
|
|
|
83f3bdfd
|
2025-03-07T14:42:29
|
|
Manual roll vulkan-deps from 4f7de8f463f8 to d34de7171c18 (1 revision)
Manual roll requested by ynovikov@google.com
Due to https://github.com/KhronosGroup/Vulkan-Headers/pull/534
including <vulkan/vulkan.h> now causes <X11/Xlib.h> to be included,
which breaks the build because of the macros it defines.
To workaround, undefine these macros after vulkan.h include.
https://chromium.googlesource.com/vulkan-deps.git/+log/4f7de8f463f8..d34de7171c18
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/952f776f6573aafbb62ea717d871cd1d6816c387..0f0cfd88d7e6ece3ca6456df692f0055bde94be7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:345261080
Change-Id: Ib229dc03e7b33daf817e3248025fdcab64157e1e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6334528
Reviewed-by: Solti Ho <solti@google.com>
Commit-Queue: Solti Ho <solti@google.com>
|
|
4eb4165b
|
2025-03-07T10:24:05
|
|
Roll third_party/dawn/ 8119dbd27..7a8946456 (244 commits; 3 trivial rolls)
Need
https://dawn-review.googlesource.com/c/dawn/+/229494
to roll
https://chromium-review.googlesource.com/c/angle/angle/+/6334483
vulkan_platform.h:152:9: error: 'VK_USE_PLATFORM_XLIB_KHR' macro redefined
https://dawn.googlesource.com/dawn.git/+log/8119dbd27471..7a8946456d49
$ git log 8119dbd27..7a8946456 --date=short --no-merges --format='%ad %ae %s'
2025-03-07 cwallez [tint] Add support for binding_array to the IR validator
2025-03-07 hitawala [stream] Check for size invalidity before reserving in Stream::Read
2025-03-07 cwallez Reland "[dawn] Fix detection of __builtin_assume for DAWN_ASSERT"
2025-03-06 dawn-autoroll Roll ANGLE from 99ebd28ad246 to 0cdbc7814e59 (4 revisions)
2025-03-06 jiawei.shao Remove the redefinition of dawn::native::Vulkan::ClampFragDepthArgs
2025-03-06 jiawei.shao Vulkan: Implement PreferNotUsingMappableOrUniformBufferAsStorage()
2025-03-06 rharrison [tint][ir][fuzz] Re-enable SubgroupMatrix in IR binary
2025-03-06 shrekshao [Compat] Remove suppressions for ReadOnlyDepthStencilAttachmentTests
2025-03-06 thomasanderson [X11] Don't redefine VK_USE_PLATFORM_XLIB_KHR
2025-03-06 lokokung [dawn][emscripten] Fix Emscripten bindings for compilation messages.
2025-03-06 lokokung [dawn][native] Add validation for Infinities.
2025-03-06 lokokung [dawn][headers] Update wgpu::Surface APIs to match upstream.
2025-03-06 bsheedy [tools] Convert glob to use dependency injection
2025-03-06 cwallez [dawn][native] Track the set of BGLInternal separately from BGL.
2025-03-06 amaiorano tint: make PreventInfiniteLoops count down from uint32::highest() down to 0
2025-03-06 dsinclair Revert "Vulkan: Allow setting multiple `MemoryKind` bits"
2025-03-06 ynovikov Reland "Roll reclient, siso; update related DEPS to match Chromium"
2025-03-06 dawn-autoroll Roll ANGLE from 1a0c9db3748a to 99ebd28ad246 (8 revisions)
2025-03-06 cwallez Revert "[dawn] Fix detection of __builtin_assume for DAWN_ASSERT"
2025-03-05 zhaoming.jiang Dawn: Remove adapter from shader compilation request
2025-03-05 jiawei.shao Skip the test CreateBufferOOMWithValidationError when no validation
2025-03-05 lokokung [dawn][native] Make error scopes thread local.
2025-03-05 dawn-autoroll Roll ANGLE from 6b10ae3386b7 to 1a0c9db3748a (3 revisions)
2025-03-05 mohamedkhairy0101 tint: Improve error message for module-scope function calls
2025-03-05 mohammedashraf4599 add BOM error message
2025-03-05 cwallez [dawn] Fix detection of __builtin_assume for DAWN_ASSERT
2025-03-05 cwallez [tint] Add binding_array indexing to the resolver.
2025-03-05 kylechar Add SlabAllocator::DeleteEmptySlabs()
2025-03-05 dawn-autoroll Roll ANGLE from 73992d71f9d1 to 6b10ae3386b7 (7 revisions)
2025-03-05 shrekshao Remove enabling core-features-and-limits in backends
2025-03-04 lokokung [dawn][headers] Removes default UTF16 support.
2025-03-04 lokokung Reland "[dawn][headers] Remove obsolete ifdefs."
2025-03-04 jwata build: GN builds use Siso without Reclient in tools/setup-build script
2025-03-04 jrprice [vulkan] Fix subgroup matrix config gathering
2025-03-04 dawn-autoroll Roll ANGLE from bd8bc1055ecd to 73992d71f9d1 (1 revision)
2025-03-04 chrome-branch-day Activate dawn M135
2025-03-04 beaufort.francois Remove maxInterStageShaderComponents limit
2025-03-04 beaufort.francois Refactor Bindgroup constructors
2025-03-04 cwallez [tint] Add binding_array to the resolver
2025-03-04 cwallez Revert "[dawn][headers] Remove obsolete ifdefs."
2025-03-04 lokokung [dawn][headers] Remove obsolete ifdefs.
2025-03-03 zhaoming.jiang Dawn: Cache limits in AdapterBase
2025-03-03 dawn-autoroll Roll ANGLE from 19b35fcbff31 to bd8bc1055ecd (5 revisions)
2025-03-03 lokokung [dawn][headers] Adds extension support for UTF-16 in compilation message.
2025-03-03 jrprice [spirv] Only add explicit layout decorations on types that need them
2025-03-03 kainino [emscripten] Add emsdk to DEPS for Wasm builds
2025-03-03 lokokung [dawn][wire] Adds Dawn wire invalid extension struct and handling.
2025-03-03 jrprice [dawn] Validate workgroup size for subgroup matrix
2025-03-03 jrprice [inspector] Reflect the use of a subgroup matrix
2025-03-03 jrprice [tint] Reject non-compute shaders that use subgroup matrices
(...)
2025-02-18 zhjiang Dawn: Tighten the scope of ScopedTintICEHandler
2025-02-18 dawn-autoroll Roll DirectX Shader Compiler from 6b68f3b5832c to fcbd2a184294 (2 revisions)
2025-02-18 jiawei.shao Replace `PipelineCompatibilityToken(0)` with `kExplicitPCT`
2025-02-18 yulong.fs fix memory address value passed to emwgpuDelete()
2025-02-18 dsinclair [spirv-reader][ir] Implement OpConvertFToU
2025-02-18 kainino dawn::DynamicLib: Leak all DLLs on Windows ASan builds
2025-02-18 dsinclair [spirv-reader][ir] Implement ConvertFToS
2025-02-18 petermcneeley Fix for assignment outside the range of representable type
2025-02-18 kainino Refactor TINT_ASAN_ENABLED into common DAWN_ASAN_ENABLED()
2025-02-18 gman Add a trace option to the Metal Backend
2025-02-18 dawn-autoroll Roll ANGLE from ba3dcfa4670d to 8dda514cb833 (3 revisions)
2025-02-18 dsinclair Mark function unused.
2025-02-18 dawn-autoroll Roll DirectX Shader Compiler from 20950d662f4d to 6b68f3b5832c (1 revision)
2025-02-17 dawn-autoroll Roll ANGLE from e0332c861004 to ba3dcfa4670d (1 revision)
2025-02-17 dawn-autoroll Roll vulkan-deps from 2a09ac22553e to 5d08bc0b0e23 (6 revisions)
2025-02-17 yulong.fs fix buffer destroy
2025-02-17 dawn-autoroll Roll ANGLE from 51d2561b5a6b to e0332c861004 (1 revision)
2025-02-17 lehoangquyen D3D: remove dead code used by the old external image API
2025-02-16 dawn-autoroll Roll Depot Tools from 77a800d7294d to 7a0dbd207449 (59 revisions)
2025-02-16 jiawei.shao Enable creating pipeline layout with null bind group layout by default
2025-02-16 dawn-autoroll Roll vulkan-deps from 2365826a66b2 to 2a09ac22553e (1 revision)
2025-02-15 dawn-autoroll Roll vulkan-deps from cc6490ed63e7 to 2365826a66b2 (5 revisions)
2025-02-15 dawn-autoroll Roll ANGLE from bef478f54e6e to 51d2561b5a6b (2 revisions)
2025-02-15 jie.a.chen Fix CooperativeMatrix extension index
2025-02-14 dawn-autoroll Roll ANGLE from 7afa2345f8d2 to bef478f54e6e (3 revisions)
2025-02-14 dsinclair [spirv-reader][ir] Register names instead of using new
2025-02-14 dsinclair [spirv-reader][ir] Support OpBranchConditional after OpSelectionMerge
2025-02-14 dawn-autoroll Roll vulkan-deps from 5cc3a63e8fdb to cc6490ed63e7 (5 revisions)
2025-02-14 gman Emit WGSL errors as part of GPUValidationError
2025-02-14 jimblackler [Kotlin] Update template now WGPUChainedStructOut has been removed.
2025-02-14 dawn-autoroll Roll ANGLE from cd7f92e1ed57 to 7afa2345f8d2 (6 revisions)
2025-02-13 petermcneeley Substitute overrides in IR (vk)
2025-02-13 shaoboyan [Spirv] Remove clamp_frag_depth attribute in Options
2025-02-13 dsinclair [spirv-reader][ir] Handle OpBranch instruction
2025-02-13 jrprice [ir] Add builtin struct support to the protobuf
2025-02-13 rharrison [tint][ir][val] Check Samplers & Textures address space
2025-02-13 jrprice [tint] Add flag for WGSL internal structures
2025-02-13 rharrison [tint] Replace unsafe casting with shift & mask in eval.cc
2025-02-13 rharrison [tint] Narrow warning suppression in table_data.h
2025-02-13 bajones Loosen Viewport validation requirements
2025-02-13 shrekshao [Compat] Add compat-min-es31 tags in expectations
2025-02-13 gman Remove old subgroups from dawn.node
2025-02-13 dawn-autoroll Roll ANGLE from 19c5293e1347 to cd7f92e1ed57 (9 revisions)
2025-02-13 dsinclair [spirv-reader][ir] Add names for functions and function parameters.
2025-02-13 dsinclair [spirv-reader][ir] Support names.
2025-02-13 dsinclair [spirv-reader][ir] Fixup mixed sign binary methods.
2025-02-13 dawn-autoroll Roll vulkan-deps from a88fd25a6a0d to 5cc3a63e8fdb (17 revisions)
2025-02-13 dsinclair Add suppressions for compat failures.
2025-02-13 jrprice [spirv] Emit Matrix*SignedComponents operands
2025-02-13 jrprice [tint] Subgroup matrix component types do not have to match
Created with:
roll-dep third_party/dawn
Bug: chromium:345261080
Change-Id: I9ee360934bcbd838d682ffabe5029cc7baecec9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6333617
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
efb344e9
|
2025-03-06T15:09:21
|
|
Remove unused VVL skip message
Below tests from the two bugs:
angleproject:42264930
Texture2DBaseMaxTestES3.Fuzz545ImmutableTexRenderFeedback/ES3_Vulkan
angleproject:42265542
FramebufferTest_ES3.ReattachToInvalidBaseLevel/ES3_Vulkan
No longer fails due to VVL error.
Tested on Linux with AMD Vulkan driver.
Remove the original VVL error from the skip list.
Bug: angleproject:42264930
Bug: angleproject:42265542
Change-Id: I249033e643211bae399712303162ab990c154fa6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6334552
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a69c2803
|
2025-03-07T13:46:27
|
|
Manual roll vulkan-deps from cc919ee5dbcf to 4f7de8f463f8 (3 revisions)
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/cc919ee5dbcf..4f7de8f463f8
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8dffe4c195918813d3aa4c557c2853e55e9ca037..0e5ff759622e16fa55e515895ca049a9056d68be
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3ea34d98a3b088d60d66404b0a9bdb893452ab8f..ad204746d6f25d00c38cb870e9c67b919eb96a9b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com,ynovikov@google.com
Change-Id: I6abda7203b65ffedc2e193c49dc0b3278750f2c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6334527
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
234c3f73
|
2025-03-07T11:41:10
|
|
Roll third_party/perfetto/ d06bef780..5c17fc6e0 (3310 commits)
Also make the gitlink owned by anyone, like the others.
https://android.googlesource.com/platform/external/perfetto.git/+log/d06bef7807a8..5c17fc6e089c
$ git log d06bef780..5c17fc6e0 --date=short --no-merges --format='%ad %ae %s'
2025-03-06 lalitm tp: fix crash when we unable to parse kernel version
2025-03-06 stevegolton ui: Fix screenshot tests
2025-03-06 zezeozue ui: Show more descriptive names in the binder plugin
2025-03-06 elrakadm Create new sql function __instrinsic_strip_hex in perfetto sql
2025-03-06 rsavitski misc python scripts: use raw strings to avoid syntax warnings
2025-03-06 stevegolton ui: Bump idle detector timeout from 30s to 60s
2025-03-06 rsavitski ui: LinuxPerf: remove debug print and the now-unused type value
2025-03-06 stevegolton ui: Relax constraints when checking for optional dataset types
2025-03-06 stevegolton ui: Use struct for args to createTraceProcessorSliceTrack()
2025-03-06 stevegolton ui: Bump test timeout for large trace
2025-03-06 stevegolton ui: Format queries in search_manager.ts
2025-03-06 stevegolton ui: Use SliceRef in debug/query tracks' details panels
2025-03-05 lukechang [ui] Add hotkey for pin track cmd
2025-03-05 elrakadm Change thread_prefix perfetto function to public
2025-03-05 stevegolton ui: Add search implementation based on dataset
2025-03-05 stevegolton ui: Batch large union datasets into CTEs to avoid SQLite limits
2025-03-05 rsavitski smaps_rollup: clarify that it doesn't work on android sysimg out of the box
2025-03-05 zezeozue ui: Add a reason_type breakdown to the binder plugin
2025-03-05 lalitm ui: fix categorization of smaps tracks
2025-03-04 rzuklie Import Bluetooth duration as dur rather than arg.
2025-03-04 lydiatse ui: Breakdown tracks component
2025-03-04 shinyuw Add disp_vblank_irq_enable ftrace event
2025-03-03 lalitm perfetto: pin summary full proto to java 11
2025-03-03 lalitm perfetto:: Update changelog with `TraceWriter::drop_count`
2025-03-03 lalitm perfetto: add `TraceWriter::drop_count`
2025-03-03 elrakadm More standarization of slices (wakelocks, async slices)
2025-03-03 lalitm ui: add test for CPU and thread funcgraph traces
2025-03-03 simonmacm Clamp kernel wakelock held ratio to 0 as well as 1; we have seen pathological values occasionally cause massive negative values here.
2025-02-28 lalitm perfetto: expose trace summary protos publicly in Bazel
2025-02-28 elrakadm standarize vsync slice names and asset loading
2025-02-27 stevegolton ui: Scroll track group into view on collapse
2025-02-27 lalitm tp: add support for adding key-value metadata fields to summary
2025-02-27 lalitm ui: fix thread funcgraph data being missing
2025-02-27 ktimofeev Revert "Android Java SDK: test that we can use `@CriticalNative`."
2025-02-26 ktimofeev Android Java SDK: test that we can use `@CriticalNative`.
2025-02-26 ktimofeev BUILD: use API level 35 when building Android SDK with Bazel.
2025-02-26 ktimofeev Android Instrumentation Testing using Blaze: fix test runner script.
2025-02-26 altimin [ui] Remove old pivot table implementation
2025-02-26 lalitm Revert "perfetto: always use suspend aware clock for service snapshots"
2025-02-26 lydiatse ui: Data visualiser row limit warning.
2025-02-26 lydiatse ui: Add Query Node actions.
2025-02-26 lalitm tp: make perfetto keyword also a possible id
2025-02-26 primiano ui: recording: make chrome extension message more actionable
2025-02-26 lalitm tp: fix unused state variable in grammar destructor
2025-02-26 stevegolton ui: Roll stable
2025-02-26 stevegolton ui: Roll canary
2025-02-26 stevegolton ui: Remove the ability to set TrackNode ids manually
2025-02-26 chinglinyu ui: handle swapper task in multi-machine traces
2025-02-25 shayba Reland "Add bitmap tracing events to android_track_event"
2025-02-25 mayzner tp: Make v2_metric proto public.
(...)
2024-01-31 hjd ui: Show unterminated thread state slices
2024-01-31 stevegolton [ui] Add links to flows tab in area selection details panel
2024-01-31 hjd ui: experimental.slices -> slices.slices
2024-01-31 stevegolton [ui] Add UI plugin docs for tabs and details panels
2024-01-31 stevegolton [ui] Show empty state widget in flow tab when no flows can be displayed
2024-01-31 stevegolton [ui] Fix bug where tabs could not be closed when we have too many open
2024-01-31 hjd ui: Add feature docs for TabsV2
2024-01-31 zezeozue [ui]: Add debug tracks for app_process_starts
2024-01-31 simonmacm Fix feature detection for battery plugin.
2024-01-31 mayzner Revert "tp: Extrinsically sorted columns"
2024-01-30 zezeozue [stdlib]: Add an android_app_process_starts module
2024-01-30 lalitm tp: remove experimental package and diffuse contents into other packages
2024-01-30 lalitm tp: merge NullableVector into ColumnStorage<optional<T>>
2024-01-30 mayzner tp: Extrinsically sorted columns
2024-01-30 primiano TP: parse trace filter stats
2024-01-30 lalitm tp: improve API of RuntimeTable
2024-01-30 stevegolton [ui] Improve aggregation tab discovery
2024-01-30 primiano test: add NullConsumerEndpoint
2024-01-30 hjd ui: TabsV2 panel starts closed
2024-01-30 sgjesse Update test to ensure OOM triggering allocation is not optimized out
2024-01-30 yangwangyw Add ODP perfetto metric.
2024-01-30 lalitm tp: document CREATE PERFETTO MACRO
2024-01-30 lalitm tp: add documentation of macros in standard library
2024-01-30 lalitm tp: implement graph reachability macro in standard library
2024-01-30 lalitm tp: reduce public API surface of Table
2023-12-20 pablogamito Add protolog trace processor
2024-01-30 mayzner tp: Fix BitVector::Builder check
2024-01-30 primiano Optimize binary size of syscall tables
2024-01-29 lalitm tp: rework all internal tables to be prefixed with just _
2024-01-29 ddiproietto Revert "perfetto_cmd: Move code into libperfetto.so"
2024-01-29 ddiproietto Revert "trigger_perfetto: Move code into libperfetto.so"
2024-01-29 fhernqvist Add the base category to the Audio perfetto switch
2024-01-29 stevegolton [ui] Put pivot table tab behind flag
2024-01-29 rsavitski ui: simplify "io.ufs.command.tags" track grouping
2024-01-22 spandandas Add libz to shared libs of heapprofd_standalone_client
2024-01-17 stevegolton [ui] Include async stack trace in error report for failed queries
2023-12-15 liutongbo Add mcts tag to MainlineCTS ART test modules.
2023-05-09 ddiproietto ftrace: Avoid crashing if format doesn't match expectations
2023-09-12 rzuklie Proto fields for network tracing icmp type/code.
2023-07-19 hugojacob Fix duplicated `data` field
2023-03-10 ddiproietto Build apps for CTS tests with sdk 31
2023-03-10 ddiproietto Move reporter_test_cts.cc into a separate file
2023-03-08 rpl Explain the use of `min_sdk_version: "31"` in `CtsPerfettoTestCases`.
2023-03-10 ddiproietto Move reporter app into subdirectory
2023-03-06 rpl Run `HeapprofdJavaCtsTest` in Mainline Presubmits with the ART Module.
2023-03-02 rpl Add support for `CtsPerfettoTestCases` to MTS.
2023-03-06 rpl Run `HeapprofdJavaCtsTest` in Mainline Presubmits with the ART Module.
2023-03-02 rpl Add support for `CtsPerfettoTestCases` to MTS.
2023-02-22 rsavitski Revert "cts: stop asking for special FGS permission for isolated service"
2023-02-21 rsavitski cts: stop asking for special FGS permission for isolated service
Created with:
roll-dep third_party/perfetto
Bug: chromium:388068052
Change-Id: I586c7e76d905279a324d3189d9e9cd9a3502c183
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6329991
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Roman Lavrov <romanl@google.com>
Auto-Submit: Victor Vianna <victorvianna@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
d7538152
|
2025-03-07T07:01:24
|
|
Roll Chromium from 7cf51f2bf4b0 to c86846c05457 (554 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/7cf51f2bf4b0..c86846c05457
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/ffd2960846..d888fb97bd
* buildtools/linux64: git_revision:dae6a4496ecbe141b76c67ce5f1996711a3f87cd..git_revision:7a8aa3a08a13521336853a28c46537ec04338a2d
* buildtools/mac: git_revision:dae6a4496ecbe141b76c67ce5f1996711a3f87cd..git_revision:7a8aa3a08a13521336853a28c46537ec04338a2d
* buildtools/win: git_revision:dae6a4496ecbe141b76c67ce5f1996711a3f87cd..git_revision:7a8aa3a08a13521336853a28c46537ec04338a2d
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/0f5ae1427a..e64069c364
* third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/3a5a3b1187..cd3ef01e66
* third_party/android_build_tools/nullaway/cipd: 65WJkoinJEXvtu9xwdDNDb3QCbqBAl8FKDpgnXr3iiEC..Br9gBQM1eYGrSHKahSZ-WTQPlz-YegUJ9mvraq3UajUC
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/7347dc7bf0..f1f2b47c96
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/518773bc43..4d2793429f
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/e12bb2ed8b..688c775e96
* third_party/r8/cipd: XmGGyZBHve7V9GyuIoNw9bCzu7jot4K8f3QwfoJ7_MYC..S_Mw-FWmkjlDmMD5YGNWSahfOYEaf0V-QE2qNlpQp_kC
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/d6c6ae0ddf..e816ca14d2
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/3872603833..d7583da45f
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6b8dd30537..0ea80f8705
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a04da863f0..61f390a8b5
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/496cd4818d..6b2fe798bf
No update to Clang.
Bug: None
Tbr: solti@google.com
Change-Id: I85dd8604554292a53bc91d88bf1a53cd324b71c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6334176
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
0cdbc781
|
2025-03-06T11:22:18
|
|
WGSL: Output samplers, including samplers from structs
This output two WGSL variables for each GLSL sampler, including samplers
in structs. This does not output the correct types for the WGSL
variables, yet, nor does it generate texture access function calls.
It also can't deal with arrays of samplers, which are not allowed in
WGSL.
Note that WGSL does not allow structs containing samplers to be
arguments to a function, like Vulkan, nor does it allowed arrays of
samplers at all, unlike Vulkan. This deals with the former problem the
same way as Vulkan and Metal, by monomorphizing functions that take
unsupported arguments.
Bug: angleproject:389145696
Change-Id: I346688783dd2771c8fe6848b6783d948ed111783
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6253672
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
|
|
|
3daf60f7
|
2025-03-06T19:38:39
|
|
Manual roll vulkan-deps from c7d9e02082b2 to cc919ee5dbcf (26 revisions)
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/c7d9e02082b2..cc919ee5dbcf
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/131c5ff10f600580902229e8c2689da709e003be..19d232bb93a8585236051094cf49f747cc892e26
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/a946dba8574df96cd0f1004f91406bbf226c4a6f..d3fc6ed183bd375538d3ca6d45d160470b3b6cdc
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/224f1c36695967f0ec719c360f39da220dffda20..1bc9d032a89ef9b09e5b395d2f93fcd59fedf8ad
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/4b1c758046b142168a6a58dfb25d380820d8e19a..dd0c2e4afdf11fcec55902c92865e57768af928a
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/5f41f2a9bf3589dc5d1791d42ff46f1abe873f2b..50563f48368d75281bc2fb1c3407dc531ce28910
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/c288b606725be00b77926cbea9737d379e1cffe2..3ea34d98a3b088d60d66404b0a9bdb893452ab8f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com,ynovikov@google.com
Change-Id: Iff25c11a43adfe13bf84229b5eb2ad4bdb9fca19
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6333236
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
85fe2671
|
2025-02-25T16:54:20
|
|
Set length or infoLog when they are not NULL
For glGetProgramPipelineInfoLog, spec says that if length is NULL,
then no length is returned. Also do this to infoLog to avoid crash.
Bug: angleproject:398904340
Change-Id: I1f87a8932f72a0d5c44c2344936ee18c674a802b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6300356
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
ab98c698
|
2025-03-06T11:34:09
|
|
Manual roll vulkan-deps from 4b720a347d47 to c7d9e02082b2 (18 revisions)
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/4b720a347d47..c7d9e02082b2
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/99ee11b0106b48f06fb9e2a324ba928b8316cc33..8dffe4c195918813d3aa4c557c2853e55e9ca037
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/3346bb2280a3a132403641d70f6cbedc6f85365a..131c5ff10f600580902229e8c2689da709e003be
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/b1140ad29a5e73ec3b938632fbc5ceeed2027103..a946dba8574df96cd0f1004f91406bbf226c4a6f
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/809941a4ca137df69dc9c6e8eb456bd70309197c..224f1c36695967f0ec719c360f39da220dffda20
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/fb8f5a5d69f4590ff1f5ecacb5e3957b6d11daee..4b1c758046b142168a6a58dfb25d380820d8e19a
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/5f8c82f68a9e1a63f3b9effceb928d7068873813..c288b606725be00b77926cbea9737d379e1cffe2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com,ynovikov@google.com
Change-Id: I53c01a61491ea8f5cbdd4c50050a5277b8a828f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6333031
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
99ebd28a
|
2025-03-06T09:02:48
|
|
Roll Chromium from 368392cfc394 to 7cf51f2bf4b0 (622 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/368392cfc394..7cf51f2bf4b0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/9afcd7944d..ffd2960846
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0224bdb2e3..135baa8210
* buildtools/linux64: git_revision:eabc4de478e68adce5a645261aadbb00f2994f14..git_revision:dae6a4496ecbe141b76c67ce5f1996711a3f87cd
* buildtools/mac: git_revision:eabc4de478e68adce5a645261aadbb00f2994f14..git_revision:dae6a4496ecbe141b76c67ce5f1996711a3f87cd
* buildtools/win: git_revision:eabc4de478e68adce5a645261aadbb00f2994f14..git_revision:dae6a4496ecbe141b76c67ce5f1996711a3f87cd
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/d8f523232f..0f5ae1427a
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2705c6655c..b0604d7ea2
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6d817fd7f4..f40ddcd8d5
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/ac66645101..7c3087b8a7
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/927aabfcd2..e14cbfaa85
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/a35441f9bb..e12bb2ed8b
* third_party/r8/cipd: w5KUJIdByRgBQ6coQA_wTY1rmuuZ8IMvkfVpctohUIkC..XmGGyZBHve7V9GyuIoNw9bCzu7jot4K8f3QwfoJ7_MYC
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/46287405a3..d6c6ae0ddf
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e5dbe2f5d9..3872603833
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3c16f5c569..6b8dd30537
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5dae5159e2..496cd4818d
* tools/skia_goldctl/linux: uLQB_1WxcmRdlgGWxlAm-iVcWjyluWWVqk9bd5iOK6wC..iooiiMwZUCMqHCv40mG4S7a86FM-mCHhc43iUkLWqEcC
* tools/skia_goldctl/mac_amd64: dd92wAzkVOkqYNdHKbG1PgtODtzTfTAM-IdVDacENC8C..J6jd6q-lIqYw3lwXZqUgINwrOoHMVWs-Qt_LZA3wsN4C
* tools/skia_goldctl/mac_arm64: ZhEAr6v2tWN1oxK6leQvyRjaNwUi4vrXZAyCwv5veegC..hD1Vv8Z7IQMShv-PK0PEaSkXuaQi3EgzFIY49YR9ApkC
* tools/skia_goldctl/win: LZpmI-6e2-R1o2X3Zgl_O54JicwHEzFp8T_XTBBs8zoC..xa9dza8Y74PPBKEHXdNtCQoVjtZgz1BmvtOM2CygAR8C
No update to Clang.
Bug: None
Tbr: solti@google.com
Change-Id: I1f93469d5738124e95b23aea6ce969f69360cf2d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6332482
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
b5ad5035
|
2025-03-05T18:01:42
|
|
Manual roll vulkan-deps from 898a2304cea9 to 4b720a347d47 (1 revision)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/898a2304cea9..4b720a347d47
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/8496ed5028cee8c5e5f18cc791766f6b454609fb..5f8c82f68a9e1a63f3b9effceb928d7068873813
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: b/399867824
Bug: b/400986108
Tbr: solti@google.com
Change-Id: I205de362c25692700f8bf092003b2882028b6740
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6325931
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Solti Ho <solti@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
4f6a799a
|
2025-03-05T18:28:44
|
|
Fix iOS build
Broken by
https://chromium-review.googlesource.com/c/angle/angle/+/6302912
Bug: b/398048048
Change-Id: I41d7c8b45b42b9fc36fcd761a254f346c7fb2299
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6330716
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
9bdc6763
|
2025-03-03T15:54:46
|
|
GetProgramPipelineiv may create a new state vector
For glGetProgramPipelineiv, spec says that If pipeline is a name
that has been generated (without subsequent deletion) by
GenProgramPipelines, but refers to a program pipeline object that
has not been previously bound, the GL first creates a new state
vector in the same manner as when BindProgramPipeline creates a new
program pipeline object.
Also creates a new state vector in glValidateProgramPipeline if the
pipeline has not been previously bound.
Modify the ProgramPipeline's validate function so that when the
program pipeline is generated, but has never been bound, the
validation status would be false.
Bug: angleproject:400254603
Change-Id: I906669a4e80aa12283156bae8a72a2dbf0b63b90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6316349
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
3d806ba6
|
2025-03-02T00:15:36
|
|
Translator: Split textureGather* ops
... based on whether the comp or refz arguments are present.
Bug: angleproject:349994211
Change-Id: I19e638f6cb27cdb890c5e30c0662aad30888d2da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6313582
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e70d1298
|
2025-02-18T14:32:35
|
|
Vulkan: Rework SurfaceVk::mUse tracking logic
Original commit that introduced `mUse` had a bug and was then reverted:
Vulkan: SurfaceVk should only wait for GPU work that uses it
https://crrev.com/c/angle/angle/+/4220723
The reland fixed the original issue by adding
"contextVk::mLastSubmitQueueSerial" into "Surface::mUse" before calling
finish:
Reland "Vulkan: SurfaceVk should only wait for GPU work that uses it"
https://crrev.com/c/angle/angle/+/4406891
However, the real issue was that the `finish()` call (called because of
the "waitIdleBeforeSwapchainRecreation" feature) was done after
`releaseSwapchainImages()`, which resets all resource uses. Because of
this bug, `finish()` ignored all uses of swapchain images, causing GPU
crash on Mali. Crash was not because of semaphores that was not tracked
by resource use. Adding "mLastSubmitQueueSerial" fixed the crash simply
because it accounts for all uses ever made by the Context.
This change fixes this issue by calling `mergeImageResourceUses()` at
the beginning of `releaseSwapchainImages()`. Adds missing retain when
transitioning into the `ImageLayout::Present`. Updates one-off submit
tracking by updating use of the image, rather than `SurfaceVk::mUse`
directly. Explicitly tracks present semaphore submission. All these
changes allow to remove adding `ContextVk::mSubmittedResourceUse`
before calling `finish()` and in the `unMakeCurrent()`.
I confirmed that this fix works by forcing `oldSwapchain` destruction
(as if it was never used) and "waitIdleBeforeSwapchainRecreation"
enabled. GPU crash happens on SM-S921B if remove addition of
`mSubmittedResourceUse` before `finish()` call, and fixed again by
calling `mergeImageResourceUses()` in the `releaseSwapchainImages()`.
So the `mergeImageResourceUses()` fixes the issue without potentially
waiting for unrelated submissions from the `mSubmittedResourceUse`.
After this change, surface use tracking should work according to the
original intent.
Bug: angleproject:397848903
Bug: b/267806287
Change-Id: Ic8197e33d0c19aad274b5f9da6f9c7377a166b60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6277446
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
|
|
|
ad6c3d74
|
2025-02-19T22:45:29
|
|
Vulkan: Fix RP resolve layouts w.r.t shared present mode
This is partially a regression after the previous change:
Vulkan: Fix present optimization w.r.t shared present mode
Before the above change, swapchain image was still optimized for present
even when using shared present mode. However, because
SetBitField(mAttachmentOps[packedAttachmentIndex].finalResolveLayout
line was using `getCurrentImageLayout()` (lucky coincidence) it was
setting correct SharedPresent layout into `finalResolveLayout`.
The `initialLayout` and reference `layout` was still
`VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL`, but for some reason VVL was
not producing any errors.
This change adds setting `finalResolveLayout` for the resolve
attachment, which in turn propagates
`VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR` to all renderpass layouts as well
as to the dynamic rendering info.
Test: angle_end2end_tests --gtest_filter=EGLSingleBufferTest.SharedPresentLayoutWithMSAA/*
Bug: angleproject:42262606
Change-Id: I49a121f1d43a078890b0dc32e0574a79e3565270
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6281569
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
|
|
|
318d4038
|
2025-02-18T13:19:28
|
|
Vulkan: Fix present optimization w.r.t shared present mode
Since the implementation of "EGL_KHR_mutable_render_buffer" mode
(angleproject:42262606), the renderpass optimization for present
(b/153885625) was not working correctly. It sill tries to transition
into `ImageLayout::Present`, but instead of entirely skipping the
transition, it inserts the barrier even when renderpass is still opened.
When both "supportsSharedPresentableImageExtension" and
"preferDynamicRendering" are enabled, code will hit ASSERT in
`flushToPrimary()` when attempting to record `ImageLayout::Present`
barrier into the primary command buffer.
Above issue is fixed by skipping the transitioning into
`ImageLayout::Present` when in shared present mode.
Other changes and fixes:
- removed renderpass flush when resolving with renderpass, since it is
not necessary (angleproject:42265256).
- above change reveled a bug in `finalizeImageLayout(&mColorImageMS)`
call. This call reverts the layout in the previous finalize call
from Present to ColorWrite. So it must have been inserted before
finalizing the swapchain image. Issue fixed by removing both finalize
calls.
- updated condition to skip invalidate w.r.t shared present mode
(b/229689340), that was missed during implementation of
"EGL_ANDROID_front_buffer_auto_refresh" (angleproject:42265697).
Test: angle_end2end_tests --gtest_filter=EGLSurfaceTest.PresentLayoutTransitionWithMSAA/*
Bug: b/153885625
Bug: angleproject:42262606
Bug: angleproject:42265256
Bug: b/229689340
Bug: angleproject:42265697
Change-Id: Ifad8aea8548fa7bfac27941812c435b2af655309
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6277445
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
|
|
|
1a0c9db3
|
2025-02-27T10:43:00
|
|
Vulkan: Disable monolithic pipeline creation with GPL
As it violates OpenGL ES rules. This change also removes Vulkan perf
counter tests that attempt to verify that warmed up programs hit the
cache... this fails in non-trivial ways especially with graphics
pipeline library due to:
- Warm up tasks being async, they may finish after the test reads the
perf counters to set expectations
- Some drivers report a cache miss when fast-linking libraries... but
likely they don't even look at the cache (so both hit and miss would
have been inaccurate)
- There is no 100% guarantee that the warmup really leads to a draw-time
cache hit.
Things are made worse by
https://chromium-review.googlesource.com/c/angle/angle/+/5421594 because
we don't necessarily even wait for the warm up tasks if ANGLE's view of
the pipeline description doesn't match what was used for warm up (even
if internally to the driver some of the state does not affect the binary
blobs).
Bug: angleproject:42265839
Change-Id: Iaf96e4f64e2187abc666ff07fe1304d7474a0e86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6309696
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
d50cd35e
|
2025-02-20T08:29:07
|
|
Tests: Add expectations file for angle_trace_tests
Skipping trace tests was handled in the TracePerfTest source and
is now specified in angle_trace_tests_expectations.txt.
Bug: b/398048048
Change-Id: Idbf5e95e74699374eb46330dc3880a0c2dfc9bc1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6302912
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
97fc5534
|
2025-03-05T07:04:06
|
|
Roll Chromium from c3f04995b4b8 to 368392cfc394 (577 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/c3f04995b4b8..368392cfc394
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/081449739f..9afcd7944d
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ea220da186..0224bdb2e3
* buildtools/linux64: git_revision:4a8016dc391553fa1644c0740cc04eaac844121e..git_revision:eabc4de478e68adce5a645261aadbb00f2994f14
* buildtools/mac: git_revision:4a8016dc391553fa1644c0740cc04eaac844121e..git_revision:eabc4de478e68adce5a645261aadbb00f2994f14
* buildtools/win: git_revision:4a8016dc391553fa1644c0740cc04eaac844121e..git_revision:eabc4de478e68adce5a645261aadbb00f2994f14
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/67874c0c46..d8f523232f
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/2b3cce7b2a..7347dc7bf0
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1a3be5fe47..518773bc43
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f53d073a6d..6d817fd7f4
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/a02de4d0d9..a35441f9bb
* third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/f477acb104..767a169c88
* third_party/r8/cipd: LVdu8kozId1Vv9Mbx69A8KonHqt9h0WSBb32X-UElEEC..w5KUJIdByRgBQ6coQA_wTY1rmuuZ8IMvkfVpctohUIkC
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/a42ecdc19f..46287405a3
* third_party/siso/cipd: git_revision:3d58d66552de848b17cd585cfa6d5018124892ea..git_revision:ef01a689b77e0a3c98e841310bf3cdea737707ab
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/802e25c33a..3c16f5c569
* tools/luci-go: git_revision:ca20346b3e3d0ac7f06cded05d8d06625b01867e..git_revision:b7196a984610cef94ac3f0d38d1a9527469bdebc
* tools/luci-go: git_revision:ca20346b3e3d0ac7f06cded05d8d06625b01867e..git_revision:b7196a984610cef94ac3f0d38d1a9527469bdebc
* tools/luci-go: git_revision:ca20346b3e3d0ac7f06cded05d8d06625b01867e..git_revision:b7196a984610cef94ac3f0d38d1a9527469bdebc
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c32d180b35..5dae5159e2
* tools/skia_goldctl/linux: KnSU1X1UW0ccKC3nnReCfxj4qzjIxicmwJwlgK9o5ggC..uLQB_1WxcmRdlgGWxlAm-iVcWjyluWWVqk9bd5iOK6wC
* tools/skia_goldctl/mac_amd64: YN53h8DsYeYloUN2eiOm_LnrySkcSwRDIYkdORdOJnsC..dd92wAzkVOkqYNdHKbG1PgtODtzTfTAM-IdVDacENC8C
* tools/skia_goldctl/mac_arm64: SK2PbPuoemUqSfsJ6A-VxlCalkoil6Wee9eEnJ4nYzYC..ZhEAr6v2tWN1oxK6leQvyRjaNwUi4vrXZAyCwv5veegC
* tools/skia_goldctl/win: Mn_CajZS-7Y13Io8vvrhRHowS8C3sKwCGTTmyKNR6FoC..LZpmI-6e2-R1o2X3Zgl_O54JicwHEzFp8T_XTBBs8zoC
No update to Clang.
Bug: None
Tbr: solti@google.com
Change-Id: I3230fff6824276a4ae9147a0a0b3091cf2bd6234
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6324787
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
6b10ae33
|
2025-03-03T14:41:21
|
|
Remove the unused SkippedSyncvalMessage
Below tests from the two bugs
angleproject:42264934:
FramebufferFetchES31.BasicInout_NonCoherent/ES3_1_Vulkan
angleproject:42264929:
MultisampledRenderToTextureES3Test.RenderbufferDrawThenBlitDepthStencilOnly/ES3_Vulkan
No longer fails due to VVL errors. Tested on Pixel 8.
Remove them from the kSkippedSyncvalMessages list.
Bug: angleproject:42264929
Bug: angleproject:42264934
Bug: angleproject:391284743
Change-Id: I4369eba5ef2a056b4085fced6419e7add7a5c279
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6317223
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
4fae3323
|
2025-03-03T14:21:07
|
|
ValidateEGLImageObject should not skip 3D EGLImage
* Vulkan and GL backends already support 3D EGLImage, so remove related
part in ValidatioinEGLImageObject.
* Add a new end2end test for 3D EGLImage.
Bug: angleproject:399774384
Change-Id: I6c39298a2f2d4c2dded2d6ddd8b98cdb8a22616a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6311581
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Aurora Zhang <Aurora.Zhang@arm.com>
|
|
ae567733
|
2025-02-26T19:09:14
|
|
Vulkan: Make use of VK_EXT_device_fault if exists
This Vulkan extension, if available, can provide further details
about the device in case of VK_ERROR_DEVICE_LOST.
* Added the following ANGLE feature: supportsDeviceFault
* It shows whether the extension VK_EXT_device_fault is supported
and that the deviceFault bit is enabled on the physical device.
* Added the Vulkan entry point for the following function:
* vkGetDeviceFaultInfoEXT
* Added the following to the renderer:
* mFaultFeatures (device feature)
* retrieveDeviceLostDetails(); to log information regarding the
following if the appropriate support is available:
* Address faults
* Vendor-specific faults
* Vendor binary dump (logged in hex format)
* Added RetrieveDeviceLostInfoFromDevice() to vk_renderer.cpp
to be used in Renderer::retrieveDeviceLostDetails().
* Updated ContextVk::handleError() to try to retrieve more info in
case of DEVICE_LOST.
Bug: b/399478440
Change-Id: If8d8e04001dabbe775c023f9922c44ef2205317e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6305888
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b6301fb1
|
2025-03-04T22:04:53
|
|
Manual roll vulkan-deps from 1f5d4f5673a3 to 898a2304cea9 (1 revision)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/1f5d4f5673a3..898a2304cea9
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/cc4bfd761e025ff14ae329c1b1dbbf24e4f0922b..8496ed5028cee8c5e5f18cc791766f6b454609fb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: b/400789178
Bug: b/399867824
Tbr: solti@google.com
Change-Id: I375095773761362f98e6679c4297d3a58c4e5f11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6320900
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Solti Ho <solti@google.com>
|
|
|
2e65d3d4
|
2025-02-03T16:26:46
|
|
Vulkan: Fine-tune submission for multiple RPs
This CL aims to fine-tune submission based on a certain command
buffer size. This allows us to perform one submission for multiple
smaller render passes.
* Added mCommandsPendingSubmissionCount to ContextVk.
* In ContextVk::syncState(), preferSubmitAtFBOBoundary is only used
if the render pass pending command count exceeds the threshold:
kMinCommandCountToSubmit
* Currently set to 32.
* For now, we still submit if the command is a clear (for example
glClearBufferfv()).
* For now, we also still submit if the command is an invalidate
(for example, glInvalidateFramebuffer()).
* In ContextVk::flushImpl(), if the pending command count exceeds the
threshold (kMinCommandCountToSubmit) and the device is found to be
idle, the work is submitted to keep the device busy.
* Modified the following unit test from VulkanPerformanceCounterTest:
VerifySubmitCounterForSwitchUserFBOToDirtyUserFBO
* Since there is now a minimum command count for submission, the
number of draw calls has been changed so that the submission is
still issued at the new FBO boundary.
* After this CL, life_is_strange shows the following improvements:
(From the latest measurements)
* +19% wall_time
* +38% cpu_time
Bug: angleproject:42265052
Change-Id: I18452cc1d39ca7e0ac376f6012974b498153cce8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6182927
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
729b55ba
|
2025-03-04T10:45:34
|
|
Tests: Fix --gtest_repeat reporting Pass on intermediate Fail
When running with --gtest_repeat=N, the same test is executed multiple
times and the harness was overwriting a previous Fail status with a
subsequent Pass. Also made Android logging more clear.
Bug: None
Change-Id: Ib1d71ca89e9e9b2af8f6a0df2c9e280b86143265
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6320657
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
1cc27b60
|
2025-03-04T18:02:28
|
|
Manual roll vulkan-deps from 80732b88bef9 to 1f5d4f5673a3 (1 revision)
Manual roll requested by solti@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/80732b88bef9..1f5d4f5673a3
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2d1626fcdeec21134adeecca92e286e6b235bd05..cc4bfd761e025ff14ae329c1b1dbbf24e4f0922b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: I0b6c2437d1cac813e9b732afbb5b9c965f9ce46a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6320642
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
73992d71
|
2025-03-04T07:45:58
|
|
Roll Chromium from 91a51a25fcad to c3f04995b4b8 (426 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/91a51a25fcad..c3f04995b4b8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e965c4ffb4..081449739f
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b248db940e..ea220da186
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f81aaec981..67874c0c46
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/669df69264..2b3cce7b2a
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/93e56257a5..1a3be5fe47
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/85ec2718b5..f53d073a6d
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7f8b68f91c..ac66645101
* third_party/r8/d8/cipd: a5lzGHzibplY-YfBMiaHgYRnmll4wB1csMwXCzHMoH8C..LVdu8kozId1Vv9Mbx69A8KonHqt9h0WSBb32X-UElEEC
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/7f2e443447..a42ecdc19f
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/786a0cdb02..802e25c33a
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cab8061a80..c32d180b35
* tools/skia_goldctl/linux: GGRZJWa6xkrq-E8sKElWsbFz5h_MzyIClxLus3TIbPgC..KnSU1X1UW0ccKC3nnReCfxj4qzjIxicmwJwlgK9o5ggC
* tools/skia_goldctl/mac_amd64: QUB-1pP_ki7pa9VtWMiQw23KsIOTOsrqsjod0ic_1s8C..YN53h8DsYeYloUN2eiOm_LnrySkcSwRDIYkdORdOJnsC
* tools/skia_goldctl/mac_arm64: op7z6olEAHR9u_jp-NHnWh2L1NG7kE-IPBClH7ExbQ8C..SK2PbPuoemUqSfsJ6A-VxlCalkoil6Wee9eEnJ4nYzYC
* tools/skia_goldctl/win: iEvrlp9kgIVZSE_ZhAvv6u6WFNTWozqp9tRnLQ6bSzQC..Mn_CajZS-7Y13Io8vvrhRHowS8C3sKwCGTTmyKNR6FoC
No update to Clang.
Bug: None
Tbr: solti@google.com
Change-Id: I601acf3cd0bb499ad713a8c57b14ffac56ac8137
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6320677
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
bd8bc105
|
2025-02-19T18:08:32
|
|
vulkan: disable pipeline cache data serialization for nvidia device.
we still see the big cache data issue after driver version 520.
rename hasEffectivePipelineCacheSerialization to
skipPipelineCacheSerialization.
Bug: b/358380399
Change-Id: Idd8354f95c3eb4c2e58678a4cf50c8b6af20f371
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6284126
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Hailin Zhang <hailinzhang@google.com>
|
|
9df57ec5
|
2025-02-28T14:35:01
|
|
Vulkan: Limit max vector size of mEmptySlotBits to 4
Add another safety guard: in case of some uncommon usage case that we
end up with one buffer/texture is part of many descriptorSets, skip the
tracking logic in SharedCacheKeyManager to avoid the excessive overhead
associated with it. The only downside is that when BufferBlock gets
destroyed, we will not able to immediately destroy all cached
descriptorSets that it is part of. They will still gets evicted later on
if needed (see evictStaleDescriptorSets for detail). Based on 300+ app
traces we have, this appears very rare situation.
Also made this behavior limited to DescriptorSetCacheManager, so that
FramebufferCacheManager will not get affected. FramebufferCacheManager
does not have any cache eviction, so it is important that we always
destroy cache when texture is destroyed.
Bug: b/293297177
Bug: b/384839847
Change-Id: I0f1eb21b014f83675b14fb59ab59b5c694a421e9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6314161
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
d254f6dd
|
2025-03-03T16:31:43
|
|
Manual roll Chromium from cbb59f8b903a to 91a51a25fcad (60 revisions)
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/chromium/src.git/+log/cbb59f8b903a..91a51a25fcad
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependency
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/2f5bf11b5c..a02de4d0d9
No update to Clang.
Bug: None
Tbr: solti@google.com,ynovikov@google.com
Change-Id: I445dfd5443bc3e55b1ad7c6c4b67c69bb4f3dc30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6318009
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
6f6c7d93
|
2025-03-03T15:00:51
|
|
Manual roll Chromium from d8add19f010a to cbb59f8b903a (950 revisions)
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/chromium/src.git/+log/d8add19f010a..cbb59f8b903a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/4aa3d0d3cc..e965c4ffb4
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/486f978d15..f81aaec981
* third_party/android_build_tools/error_prone/cipd: nMr_RGT4rigGBhQsXW9PYfo20Zi0ABB1XBIdMvKrtkoC..yV2AWEuHgVYgavFYLJw7j7TY-u0ti8S84sQtfQ_2Wo0C
* third_party/android_build_tools/lint/cipd: Gj-bf0mbp-Xwrhdet_cfri4Ubb-8PgONVeBw6aXt10MC..odZaAzq5aTldQyS4zrVQBok4BHtqZUpxdhVHlZCO0ukC
* third_party/android_build_tools/manifest_merger/cipd: kSLW7TCDnPXiA8K_534GKlsaIZOkGd_CSDf1sBwb-3cC..DIy35BIO4jvsL0DDQvMnUdDC1rep8uWzgKeSHejYdKAC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/96e731bf12..93e56257a5
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c4e7c8717c..85ec2718b5
* third_party/fuchsia-sdk/sdk: version:27.20250207.1.1..version:27.20250301.0.1
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/b1fcd9bd08..2f5bf11b5c
* third_party/r8/cipd: a5lzGHzibplY-YfBMiaHgYRnmll4wB1csMwXCzHMoH8C..LVdu8kozId1Vv9Mbx69A8KonHqt9h0WSBb32X-UElEEC
* third_party/siso/cipd: git_revision:b146378738dc716f49267d22ed7b7953cdbccecb..git_revision:3d58d66552de848b17cd585cfa6d5018124892ea
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/6655febf26..e5dbe2f5d9
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d040e7b4f7..786a0cdb02
* tools/luci-go: git_revision:0cddbdc27507a17134e1e038f938b62d0f509756..git_revision:ca20346b3e3d0ac7f06cded05d8d06625b01867e
* tools/luci-go: git_revision:0cddbdc27507a17134e1e038f938b62d0f509756..git_revision:ca20346b3e3d0ac7f06cded05d8d06625b01867e
* tools/luci-go: git_revision:0cddbdc27507a17134e1e038f938b62d0f509756..git_revision:ca20346b3e3d0ac7f06cded05d8d06625b01867e
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/31e7c132a8..cab8061a80
* tools/skia_goldctl/linux: cFP5_MeKETBLhyiZ3wrHD1ei0WT9jfIt4d_zmFFDlL0C..GGRZJWa6xkrq-E8sKElWsbFz5h_MzyIClxLus3TIbPgC
* tools/skia_goldctl/mac_amd64: 9ZKSPWL0BFFJ9i-XXta9akbpsxgQzTvJFPOSLaFXrIgC..QUB-1pP_ki7pa9VtWMiQw23KsIOTOsrqsjod0ic_1s8C
* tools/skia_goldctl/mac_arm64: ocDZkono_-0H7--idWYeYTAFQeO3RVx7ugf5aj4Y4sYC..op7z6olEAHR9u_jp-NHnWh2L1NG7kE-IPBClH7ExbQ8C
* tools/skia_goldctl/win: nkeh5UQvxZz54dBmhgRp3xrCFIEaVW45Smum7g2NkJIC..iEvrlp9kgIVZSE_ZhAvv6u6WFNTWozqp9tRnLQ6bSzQC
No update to Clang.
Bug: None
Tbr: solti@google.com,ynovikov@google.com
Change-Id: I117ff18759c023ad484e5f8633a5b24d5bfde49a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6318007
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
1f4708b2
|
2025-02-28T16:38:36
|
|
Fix nullptr argument to std::string constructor
Passing nullptr to std::string's constructor is not allowed and the
latest libc++ version warns about it.
Bug: chromium:399683086
Change-Id: Id43d2d58b8e9df99a811345e46cfe0d8b60c0cca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6311612
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
|
|
|
19b35fcb
|
2025-03-03T10:01:01
|
|
Roll vulkan-deps from 040c4735c51c to 80732b88bef9 (10 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/040c4735c51c..80732b88bef9
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0b7c079b32f676b57e92a8ded374976842985116..99ee11b0106b48f06fb9e2a324ba928b8316cc33
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/f82d29981c0b0136adfaa7863df485a705c80c84..3346bb2280a3a132403641d70f6cbedc6f85365a
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/d3bfa4b9b639c47ffaee7c1c1b76044c92fa66cc..b1140ad29a5e73ec3b938632fbc5ceeed2027103
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/2d8f273ebd4b843c402d9ee881616895b854e42f..5f41f2a9bf3589dc5d1791d42ff46f1abe873f2b
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/7d5cab3ff7ea5a8b62dc94df72141606539344fc..2d1626fcdeec21134adeecca92e286e6b235bd05
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: solti@google.com
Change-Id: I158a460332563aeaaa775e6364a3506918d4dfcc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6316434
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
aa697ed0
|
2025-02-28T11:05:55
|
|
Manual Roll vulkan-deps from c1c31f to 040c47 (9 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/c1c31f4d17a9..040c4735c51c
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8b822ee8ac2c3e52926820f46ad858532a895951..0b7c079b32f676b57e92a8ded374976842985116
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/e1fcaef1e8f2e4f4ccbfb58ad8f20e807368de76..f82d29981c0b0136adfaa7863df485a705c80c84
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/f289d047f49fb60488301ec62bafab85573668cc..d3bfa4b9b639c47ffaee7c1c1b76044c92fa66cc
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/4e7b0c905b1a0401e24333800937cc8792efa037..7d5cab3ff7ea5a8b62dc94df72141606539344fc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: b/399191283
Bug: b/399969262
Tbr: yuxinhu@google.com
Change-Id: I150f1cb9c56f014628c1a2aa06c1981b71d2d605
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6312337
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Solti Ho <solti@google.com>
|
|
|
8dd4a6e8
|
2025-02-28T16:50:51
|
|
Translator: Remove rect and 2DMS* images from atomic ops
They are a relic of desktop GLSL support.
Bug: angleproject:349994211
Change-Id: I111467fea111d22e2d12003d639bec268e418b44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6313639
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
4bfb9da6
|
2025-02-28T12:49:28
|
|
Revert "Reland "Add GL_BGRA_EXT as a sized renderable format""
This reverts commit 8f2fbbd1a0d16471596afad57c88f950a1ee3032.
Reason for revert: http://anglebug.com/399913714
Original change's description:
> Reland "Add GL_BGRA_EXT as a sized renderable format"
>
> This reverts commit 22dfe435daa7c680c07bb8d4f1d98ab765e60ad0.
>
> Reason for revert: Fixed mapping back to BGRA_EXT for GL backend
>
> Original change's description:
> > Revert "Add GL_BGRA_EXT as a sized renderable format"
> >
> > This reverts commit 80093a7d8f850c3ab551ddb4972c2f1f27511433.
> >
> > Reason for revert: suspect for blocking rolling ANGLE into Chroimum
> > https://chromium-review.googlesource.com/c/chromium/src/+/6283973
> > https://ci.chromium.org/ui/p/chromium/builders/try/chromeos-amd64-generic-rel-gtest/372754/overview
> >
> > Original change's description:
> > > Add GL_BGRA_EXT as a sized renderable format
> > >
> > > dEQP tests were updated to cover GL_BGRA_EXT as a sized renderable
> > > format. It was apparently always supposed to be, based on the
> > > wording of the spec.
> > >
> > > This CL adds that support and updates expectations, along with a few
> > > extra tests.
> > >
> > > Includes contributions from Robic.Sun@arm.com.
> > >
> > > Test: angle_end2end_tests, angle_deqp_*_tests
> > > Bug: b/42267264
> > > Bug: angleproject:394384906
> > > Change-Id: Ia10bcd61f66c5d99a3d27a2cfd6008c991ddcaa7
> > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6235444
> > > Reviewed-by: Geoff Lang <geofflang@chromium.org>
> > > Commit-Queue: Cody Northrop <cnorthrop@google.com>
> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> >
> > Bug: b/42267264
> > Bug: angleproject:394384906
> > Change-Id: I64572361cfed33b4ea17eabf278f580471d045c2
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285628
> > Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
>
> Bug: b/42267264
> Bug: angleproject:394384906
> Change-Id: I1bd9df904d93fd54286cbfce53fe89db89e842b9
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6310699
> Commit-Queue: Cody Northrop <cnorthrop@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Bug: b/42267264
Bug: angleproject:394384906
Bug: angleproject:399913714
Change-Id: I9f79f39a6d9cba3b23c261005bc3e012d70cd1cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6312977
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
3c08ed1e
|
2025-02-28T10:31:53
|
|
Cleanup: clarify ShouldReportDebugMessage logic
Bug: angleproject:391284743
Change-Id: I0900bc834d2bfa177f98ddb75747ae4bc1578297
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6312881
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
cb81b2b2
|
2025-02-27T16:52:29
|
|
Set mMappedState offset and size to actual mapped offset + size
Bug: angleproject:383356846
Change-Id: I68a4b4d3cb4c29071c9fb593b19fb55ded010950
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6308949
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Liza Burakova <liza@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
65343c4c
|
2025-02-27T11:23:04
|
|
Vulkan: Improve ConvertImageLayoutToVkImageLayout()
This CL removes supportsMixedReadWriteDepthStencilLayouts feature flag.
This feature flag was introduced when ANGLE only requires vulkan 1.0.
But now we require vulkan 1.1 and this is part of vulkan 1.1 core spec.
So it is no longer needed and wasting CPU cycles to check this every
time ConvertImageLayoutToVkImageLayout() is called.
With supportsMixedReadWriteDepthStencilLayouts removed, convert from
ImageLayout to VkImageLayout no longer needs renderer parameter. The
layout information in kImageMemoryBarrierData is never modified by
renderer at run time. So the renerer arguments has been removed in a lot
of places, avoids another pointer de-reference.
Bug: b/384839847
Change-Id: I5a89a890c0c0a1f99d2fdc1b2a85baf7de5c28bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6310839
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e6d28755
|
2025-02-27T11:09:10
|
|
Vulkan: Use VkImageLayout in DescriptorInfoDesc
DescriptorInfoDesc is part of the cache key for descriptorSet cache.
Right now it uses ImageLayout for
DescriptorInfoDesc::imageLayoutOrRange. There are cases where two
ImageLayout have the exact same VkImageLayout, which end up with cache
miss. Switch to use VkImageLayout will make it cache hit. Given that
this field is uint32_t, we are not really getting any benefit by using
ImageLayout.
Bug: b/384839847
Change-Id: I14060c3faab701b76a554a1e3a07aff44e25d7cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6310838
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
055123f8
|
2025-02-27T10:45:56
|
|
Vulkan: Don't maintain SharedCacheKeyManager for BufferBlock
Dynamic descriptor type uses the underlying BufferBlock in the
descriptorSet. There could be many BufferHelper objects sub-allocated
from the same BufferBlock. And each BufferHelper could combine with
other buffers to form a descriptorSet. This means the combination for
BufferBlock could potentially be very large, in thousands with some app
traces like seeing in honkai_star_rail. The overhead of maintaining
mDescriptorSetCacheManager for BufferBlock could be too big. In this CL
I have chosen to not maintain mDescriptorSetCacheManager in the
BufferBlock. The only downside is that when BufferBlock gets destroyed,
we will not able to immediately destroy all cached descriptorSets that
it is part of. They will still gets evicted later on if needed (see
evictStaleDescriptorSets for detail). After this CL, running with all
app traces we have, the max vector size of
SharedCacheKeyManager::mEmptySlotBits is no more than 2, versus ~70s
before the CL.
Bug: b/384839847
Bug: b/293297177
Bug: b/237686097
Change-Id: I7c7c91cd0aeacba4145575ac4270b713bf38b742
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6310837
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
00f5944d
|
2025-02-26T15:42:14
|
|
Vulkan: Avoid duplicate sharedCacheKey in mDescriptorSetCacheManager
There are usage cases that same buffer/texture bound to multiple binding
points. When we have a cache miss, we end up walking through all binding
points and record the sharedCacheKey there (so that when the
buffer/texture is destroyed, the cache will be destroyed). This causes
same cacheKey added to the same buffer/texture multiple times. This CL
keeps track of last added sharedCacheKey and do a quick check against it
and it matches, we just early return. With this CL,
SharedCacheKeyManager::mEmptySlotBits max vector size reduced from ~200
to ~70 for batman_telltale.
Bug: b/384839847
Change-Id: I0d405c18b3f1c807da4c7a402392667630bd7f1f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6306687
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
e914b53d
|
2025-02-18T17:13:08
|
|
Add validation of null pointers for certain APIs
Bug: angleproject:397315932
Change-Id: I3b253a7ca0bbdf4fd55cf67943971426d825cd24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6275697
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
8f2fbbd1
|
2025-02-27T13:33:06
|
|
Reland "Add GL_BGRA_EXT as a sized renderable format"
This reverts commit 22dfe435daa7c680c07bb8d4f1d98ab765e60ad0.
Reason for revert: Fixed mapping back to BGRA_EXT for GL backend
Original change's description:
> Revert "Add GL_BGRA_EXT as a sized renderable format"
>
> This reverts commit 80093a7d8f850c3ab551ddb4972c2f1f27511433.
>
> Reason for revert: suspect for blocking rolling ANGLE into Chroimum
> https://chromium-review.googlesource.com/c/chromium/src/+/6283973
> https://ci.chromium.org/ui/p/chromium/builders/try/chromeos-amd64-generic-rel-gtest/372754/overview
>
> Original change's description:
> > Add GL_BGRA_EXT as a sized renderable format
> >
> > dEQP tests were updated to cover GL_BGRA_EXT as a sized renderable
> > format. It was apparently always supposed to be, based on the
> > wording of the spec.
> >
> > This CL adds that support and updates expectations, along with a few
> > extra tests.
> >
> > Includes contributions from Robic.Sun@arm.com.
> >
> > Test: angle_end2end_tests, angle_deqp_*_tests
> > Bug: b/42267264
> > Bug: angleproject:394384906
> > Change-Id: Ia10bcd61f66c5d99a3d27a2cfd6008c991ddcaa7
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6235444
> > Reviewed-by: Geoff Lang <geofflang@chromium.org>
> > Commit-Queue: Cody Northrop <cnorthrop@google.com>
> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
>
> Bug: b/42267264
> Bug: angleproject:394384906
> Change-Id: I64572361cfed33b4ea17eabf278f580471d045c2
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285628
> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: b/42267264
Bug: angleproject:394384906
Change-Id: I1bd9df904d93fd54286cbfce53fe89db89e842b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6310699
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
d39cabbd
|
2025-02-27T15:15:46
|
|
Translator: textureGather* always takes refZ with shadow sampler
Bug: angleproject:349994211
Change-Id: I8337b80bf1d9ecae6943c6f1432b710040081273
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6309579
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
fb03f3c5
|
2025-02-27T15:05:16
|
|
Vulkan: Enable the use of syncval extra properties
Adjusted a couple of cases that weren't working on bots due to a
difference in write barriers (which are probably safe to ignore
altogether in this case)
Bug: angleproject:391284743
Change-Id: I1da2d05aff8b2c9ac7497903d85754054f861495
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6309578
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e365aed5
|
2025-02-28T07:02:11
|
|
Roll Chromium from e21977455fee to d8add19f010a (559 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/e21977455fee..d8add19f010a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/ae89a57966..4aa3d0d3cc
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c161eb7db2..486f978d15
* third_party/android_build_tools/lint/cipd: 9zfe4Uaw-NwRZwOiAl-D_BvgC9wZWqTWAlRyLjUhM04C..Gj-bf0mbp-Xwrhdet_cfri4Ubb-8PgONVeBw6aXt10MC
* third_party/android_build_tools/manifest_merger/cipd: Zs3uzARJ77tL_Rkbn-4hU-qHip99y98mQPLSeYlAqZsC..kSLW7TCDnPXiA8K_534GKlsaIZOkGd_CSDf1sBwb-3cC
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/fab845bead..669df69264
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5b10d02d31..96e731bf12
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e5159abea6..c4e7c8717c
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/9d2408a41a..b1fcd9bd08
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/a5a92a7cb3..cd23b39adb
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e680144e71..6655febf26
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a2787d3da2..31e7c132a8
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I570b81cd091ee105a6b8398ce24b0a5ad9ea6f23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6312335
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
421109ac
|
2025-02-27T16:14:40
|
|
Unpin aosp builds from C++17
As Yuxin pointed out upstream libcxx was updated so we shouldn't need to
pin in Android any more. We still can't have C++20 code in ANGLE due to
Skia, so some of (Chromium CI) bots will continue building as C++17.
Bug: angleproject:330910097
Change-Id: I41a9a1f727ae47ccb450853b8a5ed0f0f5edd26d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6309328
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
73fc6666
|
2025-02-27T11:51:29
|
|
Revert "Add VVL Suppression to allow ANGLE rolls into Chromium"
This reverts commit 1ab3889c1263f31954c21396d18a19d0b4ac0f1c.
Reason for revert: latest VVL code rolls in chromium https://chromium-review.googlesource.com/c/chromium/src/+/6307665. We can remove the suppression that is dependent on the old VVL code.
Original change's description:
> Add VVL Suppression to allow ANGLE rolls into Chromium
>
> Bug: b/399191283
> Change-Id: I05092fe61141ef9265e3f067f9bdbb9f3ef86daf
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6306838
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bug: b/399191283
Change-Id: Id373b85b5afbff73d1ce9920c73644e9245cd4e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6309746
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
ca7e8882
|
2025-02-26T14:39:47
|
|
Account for relaxed precision conversion data loss
1. Add highp precision qualifier for "expect" uniforms
2. Change EXPECT_EQ -> EXPECT_*NEAR when using mediump
Bug: angleproject:391002353
Change-Id: I5a75ec81e622718f989f357fc263ae287c2c7dbc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6306684
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
932162e9
|
2025-02-27T10:01:23
|
|
Roll vulkan-deps from d0470d9cf4eb to c1c31f4d17a9 (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/d0470d9cf4eb..c1c31f4d17a9
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/27732e6ed99afa91b3493bc5e5412f4914482828..e1fcaef1e8f2e4f4ccbfb58ad8f20e807368de76
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/48c93ad7cc9e0da74ed21c8bf7d56324d995644d..4e7b0c905b1a0401e24333800937cc8792efa037
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: Ibc3d775f6099adb8cce965c9c810629d9d52f85d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6308266
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1ab3889c
|
2025-02-26T20:13:56
|
|
Add VVL Suppression to allow ANGLE rolls into Chromium
Bug: b/399191283
Change-Id: I05092fe61141ef9265e3f067f9bdbb9f3ef86daf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6306838
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
3c679c7b
|
2025-02-27T07:00:13
|
|
Roll Chromium from c9c1cefdf50c to e21977455fee (412 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/c9c1cefdf50c..e21977455fee
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/89e6c21960..ae89a57966
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/648cc69690..b248db940e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/1cf6b166f1..c161eb7db2
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b5f09a2b18..fab845bead
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/deb5575fbd..e5159abea6
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/be0bacb542..7f8b68f91c
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/486abb63f2..a5a92a7cb3
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/884d052478..7f2e443447
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/7d5d00ed00..e680144e71
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/338805b786..d040e7b4f7
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cd05a2d07d..a2787d3da2
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I7133a59aacb27c077653fcf807409f2ba7581b8f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6308261
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
96a1bda4
|
2025-02-26T18:13:01
|
|
Manual roll vulkan-deps from 1138e3898873 to d0470d9cf4eb (15 revisions)
Manual roll requested by yuxinhu@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/1138e3898873..d0470d9cf4eb
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/18f581a8a2c112074815e613776b928362ec324b..8b822ee8ac2c3e52926820f46ad858532a895951
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/1af97f05fe184de16139b2dc31842334007f95e7..27732e6ed99afa91b3493bc5e5412f4914482828
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/d5b6f2de791deb73357a797d5db7aa24ce45194c..f289d047f49fb60488301ec62bafab85573668cc
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/176fef0bccaba8bdf51de54ab4eed8d5d9aaac77..fb8f5a5d69f4590ff1f5ecacb5e3957b6d11daee
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/6be00ca9f51c714780cc1d6f537f8bc5650b6204..2d8f273ebd4b843c402d9ee881616895b854e42f
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e0158a966a288dbbaca9609a76f34f91facce4a8..48c93ad7cc9e0da74ed21c8bf7d56324d995644d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: b/399191283
Tbr: yuxinhu@google.com
Change-Id: Ib298161513c2d2ffded0a1b785f9c2322f553707
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6305262
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
c11e7baf
|
2025-02-26T17:00:57
|
|
Manual roll Chromium from 3ba664797d91 to c9c1cefdf50c (837 revisions)
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/chromium/src.git/+log/3ba664797d91..c9c1cefdf50c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,ynovikov@google.com,yuxinhu@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/1cff0029dc..89e6c21960
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/1b5a0e6c51..648cc69690
* buildtools/linux64: git_revision:ed1abc107815210dc66ec439542bee2f6cbabc00..git_revision:4a8016dc391553fa1644c0740cc04eaac844121e
* buildtools/mac: git_revision:ed1abc107815210dc66ec439542bee2f6cbabc00..git_revision:4a8016dc391553fa1644c0740cc04eaac844121e
* buildtools/win: git_revision:ed1abc107815210dc66ec439542bee2f6cbabc00..git_revision:4a8016dc391553fa1644c0740cc04eaac844121e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/359f882b6f..1cf6b166f1
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f85b2cdafd..b5f09a2b18
* third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/4727162453..98aee46efb
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/feeac124f2..deb5575fbd
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/cdc82e180c..be0bacb542
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/feff25d517..9d2408a41a
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/fcd44ae4be..884d052478
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/51e897712d..338805b786
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b5b26a8e87..a04da863f0
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/858e0d3059..cd05a2d07d
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com,ynovikov@google.com
Change-Id: Ic94db44fe939321e1ddc2e5b8adb5b004964d80a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6305260
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
ca8f072e
|
2025-02-13T16:46:30
|
|
Implement EGL_LARGEST_PBUFFER
When EGL_LARGEST_BUFFER is set to true during creating a
EGL pbuffer surface, it requires the largest available pixel buffer
surface when the allocation would otherwise fail. This means if
width/height is bigger than config's maxPbufferWidth/maxPbufferHeight,
it should be clamp to maxPbufferWidth/maxPbufferHeight. An end2end
test is also added.
Bug: angleproject:397315935
Change-Id: Ic160d9693478c87b59ece0a421d3acd5d6699ddc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6277912
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
8dbd2fe6
|
2025-02-19T14:07:21
|
|
Reland "Vulkan: Take stride into account for max buf size"
This is a reland of commit 91fe334eadd279746e06367142de6e8d9f8d00ed
In the original change, mMaxBufferMemorySizeLimit was cast to a
32-bit value for cap initialization. However, if the reported value
was larger than 4GB, it could result in incorrect cap values, leading
to shader compilation errors (e.g., exceeding maximum uniform location
size).
* Updated LimitToIntAnd() to always take a 64-bit value for the cap.
* The other arg (physicalDeviceValue) would be cast to the same
type for std::min().
* Removed the 32-bit casting from mMaxBufferMemorySizeLimit during
cap initialization.
Original change's description:
> Vulkan: Take stride into account for max buf size
>
> * Added LimitToIntAnd() to limit the input value to a certain
> threshold in addition to the int limit.
>
> * Cached the max buffer size limit in the renderer.
> * mMaxBufferMemorySizeLimit
>
> * In vk_caps_utils: Capped the following buffer size-related limits
> to the maximum memory allocation size:
>
> * maxStorageBufferRange
> * maxTexelBufferElements
> * maxUniformBufferRange
>
> Bug: angleproject:391002353
> Test: KHR-GLES31.core.texture_buffer.texture_buffer_max_size
> KHR-GLES32.core.texture_buffer.texture_buffer_max_size
> Change-Id: Iee9b13f5440a4f5e6f952e7d2beaf9485f864c2d
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6283625
> Reviewed-by: mohan maiya <m.maiya@samsung.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Bug: angleproject:391002353
Change-Id: Ieb06a1dcf3096b4d6f3643f96d0e05b2be6b2093
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6303408
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d9a9b75c
|
2025-02-25T22:21:03
|
|
Manual roll vulkan-deps from 02cb40cbb578 to 1138e3898873 (13 revisions)
Manual roll requested by yuxinhu@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/02cb40cbb578..1138e3898873
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/104bd85d990155f04f050972374a3502b4631830..18f581a8a2c112074815e613776b928362ec324b
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/c98e976b567735776a4dc692bc744231dae4b13a..1af97f05fe184de16139b2dc31842334007f95e7
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/aafd524577cc90fcdd13a6f0bcbfb929a30ee90f..d5b6f2de791deb73357a797d5db7aa24ce45194c
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/fc5788170fbe2e29162862bc817357c7fb9a04e4..e0158a966a288dbbaca9609a76f34f91facce4a8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: b/399191283
Tbr: yuxinhu@google.com
Change-Id: Ic2bdc48ba5d69b80186306eda6753a0ab54ef98f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6302919
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
4d66ff7a
|
2025-02-21T19:21:08
|
|
[gtest] Consume `AssertionResult`s in `Parse_test.cpp`
Wrap each `testing::AssertionResult` in an `EXPECT_TRUE(...)` [0] to
actually check if the assertion passed. The dropped assertion was
revealed [1] by Googletest recently marking `AssertionResult` as
`[[nodiscard]]` [2].
[0]:https://google.github.io/googletest/advanced.html#predicate-assertions-for-better-error-messages
[1]:https://ci.chromium.org/ui/p/chromium/builders/try/linux-chromeos-rel/2296143/overview
[2]:https://chromium.googlesource.com/external/github.com/google/googletest.git/+/3fbe4db9a39291ae8d7a9c5f1d75896bb4c5a18f%5E%21/
Bug: chromium:398298306
Change-Id: I438f817dc6636068664d2bd5bc41b041b867b4c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6293847
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Jonathan Lee <jonathanjlee@google.com>
|
|
|
0151051b
|
2025-02-25T11:20:15
|
|
Revert "Vulkan: Take stride into account for max buf size"
This reverts commit 91fe334eadd279746e06367142de6e8d9f8d00ed.
Reason for revert: breaks Android presubmit tests: https://android-review.git.corp.google.com/c/platform/external/angle/+/3506755
Original change's description:
> Vulkan: Take stride into account for max buf size
>
> * Added LimitToIntAnd() to limit the input value to a certain
> threshold in addition to the int limit.
>
> * Cached the max buffer size limit in the renderer.
> * mMaxBufferMemorySizeLimit
>
> * In vk_caps_utils: Capped the following buffer size-related limits
> to the maximum memory allocation size:
>
> * maxStorageBufferRange
> * maxTexelBufferElements
> * maxUniformBufferRange
>
> Bug: angleproject:391002353
> Test: KHR-GLES31.core.texture_buffer.texture_buffer_max_size
> KHR-GLES32.core.texture_buffer.texture_buffer_max_size
> Change-Id: Iee9b13f5440a4f5e6f952e7d2beaf9485f864c2d
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6283625
> Reviewed-by: mohan maiya <m.maiya@samsung.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Bug: angleproject:391002353
Change-Id: I20f68f98dcf43fd8cd42f7dce2465332fdb3ab51
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6302249
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
fb648546
|
2025-02-24T17:20:39
|
|
third_party/clspv: Update CLSPV(#1423)
The clspv is rebased to the below commit to fix
test_vectors vec_align_struct with
the spir64/phy_addressing option
- 60f822e8 fix LongVectorLoweringPass
when removing dead long-vector globals
that were lowered. (#1423)
As part of that clspv rebase, llvm is rebased
to the version used by clspv
- 1fd8d3fea53e (HEAD) [mlir] Fix wrong names
in LinalgOps and ScalableValueBoundsConstraintSet
(#117227)
The rebase of LLVM required updates
to the GN build files in clspv,
appropriate changes are made.
* .bc files are pre-builts and they are deviations
from upstream. Update of gn files for libclc will
be followed in separate patch.
Bug: angleproject:383647253
Change-Id: Ia75c1446d47b780000446d521503ebee9a7585fb
Signed-off-by: Hoonee Cho <hoonee.cho@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6299711
Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Reviewed-by: Austin Annestrand <a.annestrand@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9202e05a
|
2025-02-21T18:42:42
|
|
Vulkan: Invalidate the SharedCacheKey when cache gets evicted
When descriptorSet cache gets evicted, right now we have a bug that the
sharedCacheKey does not gets invalidated. This caused
SharedCacheKeyManager always think the sharedCacheKey is valid and the
mEmptySlotBits never gets cleared, which leads to mEmptySlotBits growth
over time, and increases CPU overhead when walking mEmptySlotBits
vector. This CL adds an assertion to ensure that all valid
sharedCacheKeys has a corresponding entry in the cache, which means
without this CL, some traces and dEQP tests are hitting the assertion.
This CL also fixes the bug.
Bug: b/384839847
Change-Id: If013443144aceb5d62f67f619074ef831e73653b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6292988
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
9592b970
|
2025-02-21T12:33:57
|
|
Move LogFeatureStatus() into overrideFeatures()
Both overrideFeatures() and LogFeatureStatus() a looping through the
overridden features the same way, with one applying the feature override
and the other logging the feature being overridden.
Rather than looping twice, build up the feature override log string
concurrently in overrideFeatures() and return the string, which can be
logged (or not).
Bug: b/372694741
Change-Id: I70b06792046fe80057f45cefaf18bdd3d05f1f21
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6288657
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
99032263
|
2024-12-30T16:05:22
|
|
Log EGL attribute feature overrides
Log the ANGLE feature overrides performed by the EGL attributes when
creating a display:
* EGL_FEATURE_OVERRIDES_ENABLED_ANGLE
* EGL_FEATURE_OVERRIDES_DISABLED_ANGLE
These log messages are useful on platforms that override features at
runtime using the EGL attributes. For example, when using a
configuration file to enable/disable ANGLE features.
This results in log messages like:
Feature: disableSeparateShaderObjects enabled
Bug: b/372694741
Change-Id: I35c374c8ec29e038008224049116cfc3265e70c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6133778
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f439541f
|
2025-02-25T02:01:36
|
|
Roll SwiftShader from 2407a54c9b29 to c12c13839d68 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/2407a54c9b29..c12c13839d68
2025-02-24 swiftshader.regress@gmail.com Regres: Update test lists @
2407a54c
2025-02-24 dneto@google.com test/kokoro: linux: use cpp-builder instead
of radial-build
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I901998c31cf5dfe90f2b3254ed557a0b1941ff65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6301962
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
67d508d3
|
2025-02-25T07:00:47
|
|
Roll Chromium from 17e7fcbd53ab to 3ba664797d91 (566 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/17e7fcbd53ab..3ba664797d91
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/5ae20d9aa6..1cff0029dc
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/eaa072a717..1b5a0e6c51
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/7f5cacb256..359f882b6f
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/04dc59d2c8..2705c6655c
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/39fcf9351a..f85b2cdafd
* third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/c00c3b606a..4727162453
* third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/b84ee3745c..62d56e0f00
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/09f963b5f4..5b10d02d31
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f945c74073..feeac124f2
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/94672e2af4..cdc82e180c
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/7f56829772..feff25d517
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/4d1b3107e3..fcd44ae4be
* third_party/siso/cipd: git_revision:4442c27a02f2b5de389f88be9639e4e638ff761a..git_revision:b146378738dc716f49267d22ed7b7953cdbccecb
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/73ffcd21c3..51e897712d
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1aabbb2e23..858e0d3059
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: Icbf31e34a6a162290b007deea7906f3f7e7eefd3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6299941
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e2dace71
|
2025-02-24T19:21:19
|
|
Revert "Suppress dEQP ASAN failures"
This reverts commit cab0acdf6208e483ac26448de926e3ca0df9dbd1.
Reason for revert: The following roll has landed: https://crrev.com/c/6298534
Original change's description:
> Suppress dEQP ASAN failures
>
> These block upgrading Clang to a new version that detects more problems.
>
> Bug: b/395920316
> Change-Id: Ie07d1fce240741f2572546c86e838f8b16c4950c
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6281031
> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bug: b/395920316
Change-Id: Ibbb5519a91b9ec95fb4dc74328d6fa28b6e79738
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6299712
Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
25a22dec
|
2025-02-24T14:32:42
|
|
Manual roll VK-GL-CTS from 69ec1790cb7c to ba86fb950043 (18 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/69ec1790cb7c..ba86fb950043
2025-02-21 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.6
into vk-gl-cts/main
2025-02-21 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12
into vk-gl-cts/main
2025-02-21 rgarcia@igalia.com Test "remaining array layers" and cube
images with HIC
2025-02-21 javed@igalia.com Add coverage for tess shader IO
2025-02-21 marcin.zajac@cognizant.com Complex acceleration structure
updates
2025-02-21 jbolz@nvidia.com Add tests for VK_NV_cooperative_vector
2025-02-21 syoussefi@google.com Remove last references to DE_NULL
2025-02-21 abdolrashidi@google.com Fix non-zero offset added to nullptr
2025-02-21 zzoon@igalia.com Vulkan Video Decode: Increase
MAX_BOUND_MEMORY
2025-02-21 lionel.g.landwerlin@intel.com Fix incorrect structure type
check
2025-02-21 gleese@broadcom.com Fix test data generation for copy tests
2025-02-21 javed@igalia.com Add tests for differing mutable format
2025-02-21 gleese@broadcom.com Stop querying device address from unbound
buffers
2025-02-21 scerveau@igalia.com video: rename clip description names
2025-02-21 kamil.goras@mobica.com Add test that redeclaring gl_FragDepth
is not permitted in ES
2025-02-21 kamil.goras@mobica.com Fix KHR-GLES31.core.nearest_edge.*
tests that fail with EXT_read_format_bgra formats. If BGRA format and
type 1_5_5_5 are preffered by device use BGRA_EXT and
UNSIGNED_SHORT_1_5_5_5_REV_EXT in ReadPixels and swizzle colors.
2025-02-21 mateusz.bahyrycz@mobica.com Add support for sparse mode for
ray tracing utils
2025-02-21 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1
into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: b/398956813
Tbr: yuxinhu@google.com
Change-Id: I8d2de8b6f8671b5cf66d6b4210877ca8f187528b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6298534
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
|
e3178f0e
|
2025-02-24T14:38:36
|
|
Add AHB clear tests using glClearTexImage
* Add tests to clear AHB images before readback, but using
glClearTexImage() instead of using a framebuffer and glClear()
* AHBClearAppliedViaClearTexImageBeforeReadBack
* AHBTwiceClearViaClearTexImageAppliedBeforeReadBack
Bug: b/223456677
Change-Id: Ic5ad2b5202aa24f38dc1783205900a0dab5125f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6299797
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
56b6b628
|
2025-02-07T16:08:39
|
|
renderer_utils: Clean up Clang-tidy warnings
Clean up various Clang-tidy warnings in renderer_utils.[cpp|h].
Most of these are around for loops:
* Using const references, rather than making copies.
* Using range-based for loops.
There are other changes related to cleaning up ineffective const
qualifiers, unused values, trivial ctors/dtors, etc.
Bug: b/372694741
Change-Id: I1c88124a67a3e60537e1d5747603077f1c9cc8d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6244613
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
91fe334e
|
2025-02-19T14:07:21
|
|
Vulkan: Take stride into account for max buf size
* Added LimitToIntAnd() to limit the input value to a certain
threshold in addition to the int limit.
* Cached the max buffer size limit in the renderer.
* mMaxBufferMemorySizeLimit
* In vk_caps_utils: Capped the following buffer size-related limits
to the maximum memory allocation size:
* maxStorageBufferRange
* maxTexelBufferElements
* maxUniformBufferRange
Bug: angleproject:391002353
Test: KHR-GLES31.core.texture_buffer.texture_buffer_max_size
KHR-GLES32.core.texture_buffer.texture_buffer_max_size
Change-Id: Iee9b13f5440a4f5e6f952e7d2beaf9485f864c2d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6283625
Reviewed-by: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
5775a974
|
2025-02-21T11:00:05
|
|
Vulkan: Fix transition to FORIEGN and back in same submission
Image layout transitions are typically automatically handled. In some
cases however, the image layout is specifically "finalized". For
foreign images, the relevant cases are all about the point in time when
the image is being released.
When a foreign image's layout is finalized, a barrier is generated to
transition it to the FOREIGN queue on submission. Previously, an
incorrect assumption was made that after such a point, the VkImage will
no longer be used by any commands.
This was incorrect because of EGL Images, which let the same VkImage
(and ImageHelper) be shared between multiple textures. The following
scenario broke that assumption:
- Texture is bound to the (foreign) EGL image
- Texture is used and deleted
* VkImage's transition back to foreign is cached, but not executed
- Another texture is bound to the same EGL image
- Texture is used
* At this point, the texture is re-acquired from foreign, but it
wasn't released in the first place!
In this change, a vkQueueSubmit is issued after the foreign image's
layout is finalized to make sure the transition back to FOREIGN is
applied.
Bug: angleproject:42263241
Bug: angleproject:42262454
Bug: angleproject:390443243
Bug: chromium:382527242
Change-Id: Ibe3e6d60f282f9fb0eed1deba3325456017c3617
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6292804
Reviewed-by: mohan maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
b47fffc8
|
2025-02-20T11:11:25
|
|
CL/VK: Add rewrite-packed-structs and int8 CLSPV option
To support structs with three- and four-component vectors,
--rewrite-packed-structs is needed as a CLSPV option.
The --int8 option is added to allow shaders to process
char buffers.
Tests-Passing: OCLCTS.test_vectors vec_align_packed_struct_arr
Bug: angleproject:397733768
Change-Id: I98ecc9e82bc599453c27f60737bde752c69decd4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6284137
Reviewed-by: Austin Annestrand <a.annestrand@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
5e056364
|
2025-02-20T11:38:23
|
|
Ignore other attributes when use EGL_CONFIG_ID to choose config
Per spec, when use EGL_CONFIG_ID in eglChooseConfig, other attributes
should be ignored, so additional attributes should not be inserted in
this case.
Bug: angleproject:396190956
Change-Id: I1170dc5312a9590c972d81f91e3d2140f2145805
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6262970
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
2430d519
|
2025-02-24T10:01:40
|
|
Roll vulkan-deps from f489bd52916f to 02cb40cbb578 (13 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/f489bd52916f..02cb40cbb578
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/a80d3b5c505e6541d98003b880ae583bc706bbc9..aafd524577cc90fcdd13a6f0bcbfb929a30ee90f
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/24e67179e2b0c7f9a2945927362c5ab0728e1fa8..809941a4ca137df69dc9c6e8eb456bd70309197c
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/dbe142e8f3a7f11478c2e4741c0d4c4b748fce4b..176fef0bccaba8bdf51de54ab4eed8d5d9aaac77
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/fe7a09b13899c5c77d956fa310286f7a7eb2c4ed..6be00ca9f51c714780cc1d6f537f8bc5650b6204
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a10e2725f99c333bbc468373159442fe41158039..fc5788170fbe2e29162862bc817357c7fb9a04e4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: Ic16686060887d140d2b1011c5bf40b2ca48b6887
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6296627
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
f4622589
|
2025-02-24T07:01:58
|
|
Roll Chromium from 365dbf46bc08 to 17e7fcbd53ab (816 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/365dbf46bc08..17e7fcbd53ab
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/530d40d7d3..5ae20d9aa6
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/99bd087289..eaa072a717
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/0d1f0f2d5d..7f5cacb256
* third_party/android_build_tools/error_prone/cipd: BLHCsmBI1vzyXlOtCyA-B4yW3gdbkW5iSjfvfnBjOvcC..nMr_RGT4rigGBhQsXW9PYfo20Zi0ABB1XBIdMvKrtkoC
* third_party/android_build_tools/lint/cipd: fgLlp9RaOxtJuuPeWET3B6EvLyGvsuX_b9n9AbFup9IC..9zfe4Uaw-NwRZwOiAl-D_BvgC9wZWqTWAlRyLjUhM04C
* third_party/android_build_tools/manifest_merger/cipd: Ff5T4JIhkmgt7xA50Kq8XHnzWaR6mKOwEtxCBXFE5rUC..Zs3uzARJ77tL_Rkbn-4hU-qHip99y98mQPLSeYlAqZsC
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/a818d47882..39fcf9351a
* third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/e96dafd97e..c00c3b606a
* third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/9ed8f7c020..b84ee3745c
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2259aa1766..f945c74073
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/1a88911caa..94672e2af4
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/e722dac269..7f56829772
* third_party/r8/cipd: 2ChXGrcBJ9WNhFhS069j3L6VMp0jw5xyyPqKhlOqj_sC..a5lzGHzibplY-YfBMiaHgYRnmll4wB1csMwXCzHMoH8C
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/55237f5cfb..73ffcd21c3
* tools/luci-go: git_revision:19861b3a5b37b383e7e9555e11aa43f34d71bd48..git_revision:0cddbdc27507a17134e1e038f938b62d0f509756
* tools/luci-go: git_revision:19861b3a5b37b383e7e9555e11aa43f34d71bd48..git_revision:0cddbdc27507a17134e1e038f938b62d0f509756
* tools/luci-go: git_revision:19861b3a5b37b383e7e9555e11aa43f34d71bd48..git_revision:0cddbdc27507a17134e1e038f938b62d0f509756
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8e880be2d6..b5b26a8e87
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ff6b5b7245..1aabbb2e23
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: Ib59abc755cb1eeeb817f43f1d3be56178bf748ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6296625
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
f09a19ce
|
2025-02-21T17:27:30
|
|
OpenCL: Pass bufferPtrOffsets by reference not value
enqueueNativeKernel() is passing `const std::vector<size_t>
bufferPtrOffsets` by value instead of reference. Changed to pass by
reference in this CL.
Bug: b/42266859
Change-Id: I337eb62451631297c8f389c9f850ff9ddd2421ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6293727
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
db8c86bd
|
2025-02-22T20:33:31
|
|
Vulkan: Disable imageless framebuffers on buggy ARM drivers
Bug: chromium:371512561
Change-Id: Ibf8c4ed84a29139afd6d234690d240785656cc06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6293786
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Solti Ho <solti@google.com>
Commit-Queue: Solti Ho <solti@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
34faa3db
|
2025-02-08T15:17:10
|
|
Fix issue that stride setting is incorrect when rotation is true
When rotateXY is true, stride should increase or decrease
on the Y axis.
Bug: angleproject:395131251
Change-Id: I0f5363c9952ccdf0a036499a9f918853eff7cd10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6242496
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Robic Sun <Robic.Sun@arm.com>
|
|
|
23df4f26
|
2025-02-21T10:30:04
|
|
Vulkan: Avoid storage grow related copy for mDefaultUniformBlocks
mDefaultUniformBlocks.uniformLayout is a std::vector, and my profile on
all app traces indicates quite some storage reallocation on this data.
This CL reserves enough storage upfront to avoids storage reallocation
in LinkTaskVk::initDefaultUniformLayoutMapping().
Bug: b/293297177
Change-Id: If249a373aa3bd1795757d974cbcfce38a153a813
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6288314
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
03de46ef
|
2025-02-20T00:00:00
|
|
Metal: Remove divMatrixScalar polyfills
MSL 2.3+ natively supports
matrix by scalar division.
Bug: angleproject:372169468
Change-Id: I2055ab8cfff01d8a52ddc0de4d5c3bc115271aed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6289047
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
c21e31a1
|
2025-02-20T17:32:17
|
|
Add handling null input to eglGetProcAddress
* Modified eglGetProcAddress() so it can handle a null input by
returning nullptr.
* Added a test for this case:
* EGLReadinessCheckTest.GetProcAddressNullInput
* Fixed some typos.
Bug: angleproject:397720948
Change-Id: If55223b12831649252e2e06e47abaf8d3546c86f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6289249
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
323c49a3
|
2025-02-20T15:44:08
|
|
Vulkan: Fix swap optimization after staged clear for MSAA
If the MSAA image only had a clear update and the update wasn't going
to be applied to the swapchain image, the clear update was accidentally
dropped because `flushStagedUpdates` wouldn't see the clear update which
is already extracted in `deferredClearValues`.
Test: angle_end2end_tests --gtest_filter=EGLSingleBufferTest.StagedClearResolveOnSwap/*
Bug: angleproject:382006939
Change-Id: I53ae26eeb8a7f38b7758f86bf97982a90b1990dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285627
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e5b87adc
|
2025-02-20T15:32:16
|
|
Vulkan: Fix WindowSurfaceVk::hasStagedUpdates w.r.t MSAA
The old `hasStagedUpdates()` checked swapchain image for staged updates.
However in case of MSAA, staged updates are added to the
`mColorImageMS`. Universal solution is to check staged updates on the
renderpass image from `mColorRenderTarget`, which will be
`mColorImageMS` in case of MSAA surface, and the currently acquired
swapchain image otherwise.
No automated test is possible, since `glReadPixels()` still works as
expected. Other reason is that `ANGLE_VK_TRACE_EVENT_AND_MARKER` before
acquire inserts commands into the outside renderpass command buffer
causing flush to happen. In other words, the debug marker interfering
with the normal ANGLE behavior, so even visual test is not possible.
Bug: angleproject:237449314
Change-Id: I237514a640a23a33d894109856711c1eb2dcbb29
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285626
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
|
|
|
eb22e1f8
|
2025-02-21T11:44:31
|
|
Roll vulkan-deps from 126c9b378eb7 to f489bd52916f (18 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/126c9b378eb7..f489bd52916f
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e66176c3f685b14dfa83882329e5d02f4e027c9b..104bd85d990155f04f050972374a3502b4631830
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/09913f088a1197aba4aefd300a876b2ebbaa3391..54a521dd130ae1b2f38fef79b09515702d135bdd
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9fa14b91414994e2bf4d9509b8efc8071f154991..a80d3b5c505e6541d98003b880ae583bc706bbc9
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/234c4b7370a8ea3239a214c9e871e4b17c89f4ab..952f776f6573aafbb62ea717d871cd1d6816c387
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/087c22a441e5fb8563516b6b515483898c843242..a10e2725f99c333bbc468373159442fe41158039
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ifb414ab9bbbd524973d4944854649deb0f1714c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6288472
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3972cfa1
|
2025-02-18T19:52:06
|
|
YUV should support on all the shader stages
* The spec requires all shader stages should support YUV. Therefore,
move YUV related functions out of the switch.
* Add a new end2end test that sampling YUV in the vertex shader.
Bug: angleproject:391919465
Change-Id: I7811d419d5f1461c2499c522a902c3b2149289a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6263325
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ba174a76
|
2025-02-19T16:35:15
|
|
Vulkan: Bugfix for nullColorAttachmentWithExternalFormatResolve
When nullColorAttachmentWithExternalFormatResolve is VK_TRUE,
* The imageView in VkRenderingAttachmentInfo for dynamic rendering
should be VK_NULL_HANDLE.
* Push YUV resolveImageView as if it is the color attachment to ensure
the coherency between ops, clearValues and attachmentViews for both
dynamic rendering and render pass objects. Then pack the YUV resolve
information first as well.
* Add end2end tests that render and clear YUV with a depth attachment.
Bug: angleproject:395212980
Change-Id: I8b6173b41723ed7dc12359e181791fb1ac22fc41
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6262510
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
03bdf1ca
|
2025-02-18T16:37:49
|
|
Vulkan: Use correct actual FormatID for MSAA swapchain image
Implementation of "overrideSurfaceFormatRGB8ToRGBA8" feature missed
updating actual FormatID for the MSAA swapchain image. This bug makes
possible to initialize RGBA8 swapchain image and RGB8 MSAA image.
However, on practice MSAA is still RGBA8 because RGB8 renderable is
generally emulated on Android.
VUID-vkCmdResolveImage-srcImage-01386: srcImage and dstImage must have
been created with the same image format.
This fix is cosmetic and is not expected to fix any real bugs
(because RGB8 is generally emulated with RGBA8).
Bug: angleproject:42265147
Change-Id: Ief4b74ac31e93a655f5088b7927e970585255f25
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6275968
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
|
|
|
f9566385
|
2025-02-06T00:00:00
|
|
Fix GetBooleani_v validation
That entrypoint must require OpenGL ES 3.1.
Fixed: angleproject:394610814
Change-Id: I9ee80d1497afadfdc0d714e49bb97b741ad57b63
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6243878
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
8d21acb3
|
2025-02-21T02:01:31
|
|
Roll SwiftShader from d7ed113c66ec to 2407a54c9b29 (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d7ed113c66ec..2407a54c9b29
2025-02-20 natsu@google.com Fix LLVM's AlignOf after previous change to
support c++23
2025-02-20 tikuta@google.com Add missing include headers
2025-02-20 dneto@google.com kokoro: Use streamlined image for
check_style
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I58ecd3186cc48e489c64cfdaf4d78cef8d1489ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6290599
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
8b4c42fe
|
2025-02-21T07:01:01
|
|
Roll Chromium from 8fcb1d1f64ae to 365dbf46bc08 (522 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/8fcb1d1f64ae..365dbf46bc08
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e42ba23e14..530d40d7d3
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d1ed719a33..99bd087289
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/75065cfcbb..0d1f0f2d5d
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/30345af7ee..09f963b5f4
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ab387d1ddc..2259aa1766
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e36be6784f..1a88911caa
* third_party/r8/cipd: QDwsH_fhjzc4w9ejy5IKJrAl9g6ct71e1UJiFwGoqYMC..2ChXGrcBJ9WNhFhS069j3L6VMp0jw5xyyPqKhlOqj_sC
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/ca9f905839..4d1b3107e3
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/1bc9dfc738..7d5d00ed00
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a6615a458d..55237f5cfb
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/810ed5860b..ff6b5b7245
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I58343fe5d873e4e99e54ddb74a5b1e5a4491345f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6288470
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
be98f841
|
2024-11-30T02:11:05
|
|
Implicitly end PLS for framebuffer reads and writes
In preparation for removing the PLS allow list, convert more problematic
methods to the new paradigm of implicitly ending PLS instead of
generating errors.
Also simplify the disable logic for framebuffer modifications, and just
blindly disable PLS for framebuffer updates, regardless of whether it's
GL_READ_FRAMEBUFFER or GL_DRAW_FRAMEBUFFER.
Bug: angleproject:40096838
Change-Id: Ie4390a219f5f05ef0a3d00f405d4914592726283
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6077335
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8f8b41e3
|
2025-02-14T17:54:51
|
|
Vulkan: Optimize for multiple TexSubImage calls in the same level
Based on app traces, some apps make glTexSubImage call for the same
level multiple times in a row. One extreme example is lumino_city, which
it creates a 2D texture with nullptr data, and then calls
glTexSubImage2D many times back to back for each row of the texture to
update the data. Because we uses std::vector to store the per level
update struct (SubresourceUpdate), it means we copy these data
structures every time it grows 2x, until it hit the max size 1081. The
other common case we get into is app update some area of the texture
(like google map and gacha_life) which also end up with a few
texSubImage calls back to back. The other more common case is we staged
a clear first and then glTexSubImage which end up with vector size of 2.
This CL changes to use std::deque instead of std::vector to store the
staged update for a given level, which allows it to grow without extra
penalty.
Bug: b/293297177
Change-Id: Iabbc143074ad9d6fcf47abbddee09ecf7f78d1a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6271964
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|