kc3-lang/angle

Log

Author Commit Date CI Message
Roman Lavrov c40f1a04 2023-12-01T09:17:04 aosp: remove gclient flag --delete_unversioned_trees Suggested by Gerrit folks: b/305091097#comment13 This flag has been set for a long time, but after migration to submodules it might be causing trouble. Bug: b/305091097 Change-Id: I9eba5bf4ebe192942ab72b7670628f957b03ecc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077411 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 7f1d9e05 2023-12-01T10:01:53 Roll vulkan-deps from 9bc701361bf9 to f4204cd3fb57 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9bc701361bf9..f4204cd3fb57 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/3f615ad93e..a1138bacff * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f4a73dd7a0..0d87845532 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ced1ecb526..f4ae60be27 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/923226cb92..64fb8917ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I0a46f4004b5933add9b27c68f6d8b53cd0bce3bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5079271 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 3fe678c9 2023-11-30T12:15:57 Avoid malloc in VertexArrayVk::mergeClientAttribsRange Replace temporary std::vector with angle::FixedVector Bug: b/300968773 Change-Id: I002233afc99c0eb03a5ad11ab7a5bfd85626b3a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5074625 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 3680a5dc 2023-11-17T13:51:07 Vulkan: Let program warmup continue passed link The warmup task does not actually affect the link results, so there is no reason to wait for it when the application queries the link status. This change allows the warm up task to continue in parallel until the program is used at draw time. This allows the warm up to be more efficient when the link itself is not parallelized. For applications that create programs in the middle of every frame, it's still likely best to disable warm up (as the following immediate draw will already effectively do the warm up). Note that currently the warm up code in the Vulkan backend is not completely thread-safe, and so the program still blocks on that task before the first draw can happen (or the program is modified in any way). Bug: angleproject:8417 Change-Id: I0877fef39a0585c3279e32699ce817d4643d7cd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5037538 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yiwei Zhang d842f3db 2023-11-29T06:53:58 Vulkan: add a disableSeparateShaderObjects feature Dota Underlords uses one PPO and keeps swapping the attached program. Though we get cache hit, the hundreds pipeline creation calls still amount to non-trivial CPU overhead via ANGLE. The use of SSO has been disabled by the app in certain cases, and this feature is added to support entirely disabling SSO in ANGLE on all Vulkan backend impls. Bug: b/309028728 Test: Dota Underlords easily hits target FPS on ANV and RADV Change-Id: I54532975237218563b8750f1878a83e386fe776d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5073414 Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 58a32acc 2023-11-30T10:01:00 Roll SwiftShader from 35b1a501141a to 4befa3ada54c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/35b1a501141a..4befa3ada54c 2023-11-29 syoussefi@google.com Remove Jonah from OWNERS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I129612b51ac64aeb03aacf03344f7dcc13983111 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5076105 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c10dea22 2023-11-30T10:01:23 Roll vulkan-deps from c41e80cec06c to 9bc701361bf9 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c41e80cec06c..9bc701361bf9 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/c59b876ca0..3f615ad93e * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/50e90dd74e..a3da0e87fa * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/afaf8fda2a..f4a73dd7a0 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/cf32131e12..ced1ecb526 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b994b0d458..923226cb92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I93a42e4cc56cdab212c3b924f8c7da15da91b3f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5076259 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9a5058be 2023-11-30T07:46:08 Roll Chromium from a2a7acf06e25 to 996514892366 (702 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a2a7acf06e25..996514892366 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f9cc71c99c..bb826aaf00 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c65da25aed..b17c7e870e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/342c05bb4d..9213eae588 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ec903ccd87..0764ad493e * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/3470538450..c4a82efb2f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2823d8f8be..ee967548fe * third_party/fuchsia-sdk/sdk: version:16.20231117.2.1..version:16.20231129.1.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6cd38f6d30..0ad014cff4 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c21fd3819a..4cb5c2cefe * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/85df028e4c..bbe2764382 * third_party/r8: o6MAAUwWCotub-YLAZV6fewtgr4AUJUrZpDwervcrtMC..1cleC9ETmNTNjX-TQoPj14Siz7FFAy6HR6x5pbSS00oC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/7b4829c7a3..67da756b88 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a1a98c84ca..5b7313d3e5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5e2447e2fb..913a358a00 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I5d38de547bb8a49bab8d9c2db3bf469558b68284 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5076359 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 6f4f5e39 2023-11-18T22:15:49 Fix checking result of link sub tasks Bug: angleproject:8297 Change-Id: I143a26be6e7340a4a2d2b917bbe4dd9dd474f7af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5042346 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao b746dc3b 2023-11-29T17:40:53 Vulkan: Fix assertion when texture's min/mag filter disagree Camera CTS test testCameraGpuEncoderPath[1] is hitting assertion due to minFilter is NEAREST but magFilter is LINEAR. This CL use sampler's filter if min/mag agrees. Otherwise it uses default YCbCr chroma filter. The min/mag filter will still apply separately if VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_SEPARATE_RECONSTRUCTION_FILTER_BIT is set. If this bit is not set, we will force all of three filter to be the same anyway. Bug: b/302196568 Bug: b/308208067 Change-Id: I19007a107cfcea0f839cb66c236a70c003c43653 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5074826 Reviewed-by: Chris Forbes <chrisforbes@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Geoff Lang 820e0d7a 2023-11-29T13:39:27 Compute the shader hash without copying objects. The shader hash was calculated by generating a large string and then sha1 hashing the string. sha1 can be generated with a fixed memory cost using the angle::base::SecureHashAlgorithm class. Bug: angleproject:8434 Change-Id: I816e2c3bbc7283cd5424621b4cc8f6dab0407aa4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5073293 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 2a6336ed 2023-11-29T13:35:57 Don't construct a compiler instance on shader cache hits. We can avoid constructing a shader compiler instance and then destroying it when we get shader cache hits. The resources and output type are available from the root gl::Compiler object. Bug: angleproject:8434 Change-Id: I2de43db34dc1b86265aa648b1275e32814487ff4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5073292 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sergey Kataev 058a2fd6 2023-11-28T17:38:28 Clear active queries before Begin Bug: angleproject:8415 Change-Id: I97dfd904d65933a66f25cd168c50fe150ef9c765 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5068525 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Sergey Kataev <sergeyka@chromium.org>
Charlie Lao f7eb7efb 2023-11-28T11:20:57 Vulkan: Fix camera panorama hang When EGL attributes does not speficy color space, right now we pick VK_COLOR_SPACE_SRGB_NONLINEAR_KHR. This overwrites the color space people set via ANativeWindow. This causes camera goes into CSC conversion and errors out and stops media codec pipeline and causes camera to hang. This CL enables mapUnspecifiedColorSpaceToPassThrough feature flag for all platform that supports VK_EXT_swapchain_colorspace so that it will pick VK_COLOR_SPACE_PASS_THROUGH_EXT and vulkan swapchain code will try to keep whatever color space surface already has. The feature flag is still kept here in case there is regression and we need to experiment this feature flag again. We can remove it once everything settles down. This CL also adds updateColorSpace() and getActualFormatID() to de-duplicate the logic of R8G8B8_UNORM overriding and use of VK_COLOR_SPACE_PASS_THROUGH_EXT. Bug: b/309480316 Bug: b/302196568 Change-Id: I0952fe78c2bfd59446391c553745b2b5cb152a9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066801 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Chris Forbes <chrisforbes@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 05e9ec11 2023-11-23T00:00:00 Metal: Saturate floating-point depth textures on upload Metal does not clamp uploaded floating-point depth texture values to the normalized range. Used a compute shader to enforce the expected OpenGL ES semantics. Fixed the following tests on Intel and Apple GPUs: dEQP-GLES3.functional.texture.specification .teximage2d_depth.depth_component32f .teximage2d_depth.depth32f_stencil8 .teximage2d_depth_pbo.depth_component32f .teximage2d_depth_pbo.depth32f_stencil8 .teximage3d_depth.depth_component32f_2d_array .teximage3d_depth.depth32f_stencil8_2d_array .teximage3d_depth_pbo.depth_component32f_2d_array .teximage3d_depth_pbo.depth32f_stencil8_2d_array .texsubimage2d_depth.depth_component32f .texsubimage2d_depth.depth32f_stencil8 .texsubimage3d_depth.depth_component32f_2d_array .texsubimage3d_depth.depth32f_stencil8_2d_array Fixed: angleproject:8422 Fixed: angleproject:8426 Change-Id: I843024f098fef2fbca15e7b6124052681d05b6ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5062710 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev d696b40f 2023-11-23T00:00:00 Metal: Use precise tanh for highp result types When fast math is enabled, default tanh does not pass dEQP precision tests. Explicitly request precise tanh when the result type has high precision. Bug: angleproject:8287 Change-Id: I07c8c2638b5f0a51feacbeadb78382152a95b03c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5057298 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll aaafecee 2023-11-29T10:01:37 Roll vulkan-deps from 47125179fa7d to c41e80cec06c (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/47125179fa7d..c41e80cec06c Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b820431a2c..c59b876ca0 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7d2a618bf9..afaf8fda2a * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b00cb455c4..cf32131e12 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e00625d685..b994b0d458 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ide971370f5b16ca4b6a43ba38ef0637e7b2c5a4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5068529 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 55814099 2023-11-29T07:00:39 Roll Chromium from b8706c636bf7 to a2a7acf06e25 (698 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b8706c636bf7..a2a7acf06e25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4a176626b8..f9cc71c99c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/aa432dc92d..c65da25aed * buildtools/linux64: git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03..git_revision:7367b0df0a0aa25440303998d54045bda73935a5 * buildtools/mac: git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03..git_revision:7367b0df0a0aa25440303998d54045bda73935a5 * buildtools/reclient: re_client_version:0.120.1.f75cfb7-gomaip..re_client_version:0.121.0.e622934-gomaip * buildtools/win: git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03..git_revision:7367b0df0a0aa25440303998d54045bda73935a5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c6b2bfd4cc..342c05bb4d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/334071bcb5..ec903ccd87 * third_party/android_build_tools/lint: A9hM5McVrqwLhfWjg3dptcOFMxIiBJaMsrmG-rb8aW0C..hPW0THuEdVxwGMSWqn9CZgyFBNXe9sXc2NJsh1hiliIC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/702ef3a599..2823d8f8be * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0acc468d8b..9e5fc28b6b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/763198b843..6cd38f6d30 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b90fa05c89..c21fd3819a * third_party/siso: git_revision:d3c91417789c3190676d18dc3cc26dff20819eea..git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e2d55f9bea..3ee0331f3c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/522ab0728a..990e9cdeeb * tools/luci-go: git_revision:bd7ce256f73f85cb75c630b40afa382cdf7fcc51..git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae * tools/luci-go: git_revision:bd7ce256f73f85cb75c630b40afa382cdf7fcc51..git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4874affc0c..a1a98c84ca * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/63050f1b91..5e2447e2fb No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I027e87639df6543348b9908fa1da8aa835d2a851 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5068528 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 989b1143 2023-11-28T14:06:06 Trace perf: logcat output captured line-buffered I've seen warmup detection getting stuck intermittently not seeing the log line despite the line being there. Hopefully this fixes. Bug: b/291604008 Change-Id: I10da772c485f7b1badd34efc00c20fc6d55139cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5067855 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop ee4b7a27 2023-11-03T09:06:50 Add --memory to restricted_trace_perf.py Detailed analysis of our power results showed that even checking memory can impact power. This CL makes memory measurement optional (like power) to enhance power measurements. Test: restricted_trace_perf.py --memory --power Bug: b/292249127 Change-Id: I69b34d378ca923de42af59fc1b532a1d766b4391 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066797 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Mark Lobodzinski 068a0ee8 2023-11-28T08:43:45 Tests: Add Retro Bowl trace Test: angle_trace_tests --gtest_filter=TraceTest.retro_bowl Bug: b/313610392 Change-Id: Iec30c95fd46a75c6995d968dfac5652a89209bc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066795 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 333e3a9c 2023-11-28T12:12:44 Re-add VUID-vkDestroySemaphore-semaphore-01137 temporarily To unbreak ANGLE-> Chromium swangle.. https://crrev.com/c/5066784 Bug: angleproject:7729 Change-Id: Ic7aaa10540cb9c6581872c9709b2d329eae4b8f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5067854 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 233b6675 2023-11-28T12:48:17 Roll vulkan-deps from e892a337898c to 47125179fa7d (24 revisions) VVL renamed VUID-vkDestroySemaphore-semaphore-01137 -> VUID-vkDestroySemaphore-semaphore-05149 https://chromium.googlesource.com/vulkan-deps.git/+log/e892a337898c..47125179fa7d Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/153064f2c7..b820431a2c * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/42299f92ef..50e90dd74e * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2a238ed24d..7d2a618bf9 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/7d92fe7b68..9d27c893cd * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0e7cf57a29..b00cb455c4 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/9ef6c05af3..98d168c168 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/228f7487dd..1fb77ad1d4 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4d7cdcc223..e00625d685 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7729 Tbr: romanl@google.com Change-Id: I8268b3532b78aa4362e632ae68f335b6808966e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066853 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll f2aee23f 2023-11-28T10:01:36 Roll SwiftShader from 50dbfc35468c to 35b1a501141a (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/50dbfc35468c..35b1a501141a 2023-11-27 syoussefi@google.com Make high precision filtering a build flag If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Icf9ff3ae4b7b8668c4e1b3bd37699db6a2ad6646 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066074 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1b8775f9 2023-11-28T07:47:29 Roll Chromium from 3c5e99605653 to b8706c636bf7 (594 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3c5e99605653..b8706c636bf7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cdf0c47b04..4a176626b8 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ed2855f2d6..aa432dc92d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e20739ec64..c6b2bfd4cc * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3747d5b3f1..334071bcb5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f0228fa92b..702ef3a599 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/25b4354fad..0acc468d8b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9e4e987c28..763198b843 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e6a7fd81ed..b90fa05c89 * third_party/r8: YJv5xgb5CjUj1a0k36y8EQ5Fg7faGfQi1bKh8-cAv6QC..o6MAAUwWCotub-YLAZV6fewtgr4AUJUrZpDwervcrtMC * third_party/turbine: rg7X3-H8Yd0enT9HWZY9KwEh1ciZBP0jkla5_rGW2pUC..e8ccyNXO5wVjI0vv5W8kfA101BaaLNjNiVH1JddpdWkC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/22124f50e9..7b4829c7a3 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/521ee9b0a7..e2d55f9bea * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8e1981d442..522ab0728a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a13c719040..4874affc0c * tools/skia_goldctl/linux: X1YWlW-vzJ8VB4_DZDx7vQjrh06xi6o_hnxnoQ9pRJgC..Zoe29KUyqS2oKisSjN23NSWAF2ABY3oXtvnMcmNgFf8C * tools/skia_goldctl/mac_amd64: tfXYA7PdwTB_MKkvGO3x0SiH7mnjOz_Qmaflm4quiVYC..JqbiGnBxG8TPvCgKA3OOreiQ59Tn_xZoQOrWCP7rzOUC * tools/skia_goldctl/mac_arm64: yXR-TKcp4Hk7mBJ1Yzar9h8PTy_CPyw9tGoYKjwooJoC..6U5_zURvPx2a03ZdJP9q_CPrUrIp3nU7x9u9a7ZWvFsC * tools/skia_goldctl/win: BYJuHIvTZ_3r-th5RnKUkcSmHEaKFPYrrkWebSiN4g0C..zEvgRWYnnTxGYfan6MIEqFyxyBfzgryl755RHBP98wYC Clang version changed llvmorg-18-init-11962-g73e96337:llvmorg-18-init-12422-g74cdb8e6 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/8e1981d4424915d69d4774d8f6835799c3c1d6a1..522ab0728a5204e48573ab73f5bd7ae34a7f5ef2/scripts/update.py Bug: None Tbr: romanl@google.com Change-Id: Ic631c3d147c91799b23d6e5149667f5ad928e2b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5065991 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 716c5d00 2023-11-13T10:23:10 Vulkan: Add RGB8-to-RGBA8 ubyte loading function Currently, to update RGB8 on desktop, ANGLE uses memcpy for each pixel, which is suboptimal. This CL adds a loading function to improve the copy time for RGB textures where RGBA is needed on the hardware. * Added a specialization to LoadToNative3To4() for unsigned bytes using 0xFF as the fourth component. * It is optimized for unsigned bytes when converting an RGB format to its corresponding RGBA format, e.g., RGB8 to RGBA8. * It uses uint32_t operations to speed up the process. * Added unit tests for the specialized LoadToNative3To4. * LoadToNative_unittest.cpp * Added perf test for RGB8 image allocation and loading. * RGBImageAllocationBenchmark in RGBImageAllocation.cpp. * RGBImageAllocationBenchmark shows some improvement in cpu_time and wall_time on a Linux and a Windows device. (Results below using aligned source pointer and texture size of 2048): * On Windows: +~85% cpu_time, +~71% wall_time * On Linux: +~26% cpu_time, +~27% wall_time Bug: b/308177124 Change-Id: I421d83f75fdc513b0111dffb0a5d5e74682dd6fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4995489 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Geoff Lang 1ff6a6f2 2023-11-27T13:08:29 Pass the attribute map to egl::Sync::initialize. The attribute map was typically passed to the impl objects in the constructors. Instead, pass it to the initialize function. This removes the need for many member variables in different backends and opens up the future optimization of re-using sync objects by calling initialize on them with new attributes. Bug: angleproject:8430 Change-Id: If69970462cfed39d9a205034adb5ddd937c5ea31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5063335 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Steven Noonan 99b077b7 2023-11-26T08:24:18 Vulkan: fix data clobbering with AllocateNonZeroMemory The offset of the suballocation was not being used when initializing memory, so it was possible to overwrite the start of an existing buffer with garbage. Bug: angleproject:8427 Change-Id: I8205068a173dc4342894c6c49ee5fa9c4a8a255a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5060776 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net>
Alexey Knyazev 3e617615 2023-11-23T00:00:00 Metal: Update depth texture dEQP expectations Bug: angleproject:5243 Bug: angleproject:8425 Bug: angleproject:8426 Change-Id: I62fe901e50cd76b483ba415ad01707129c4ff857 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5054336 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 1db20bf4 2023-11-27T15:33:23 Roll VK-GL-CTS from fdb23dfe8f79 to faf4fbbc8f8e (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fdb23dfe8f79..faf4fbbc8f8e 2023-11-27 rgarcia@igalia.com Remove many EDS stencil test combinations 2023-11-27 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I7df820b32c2f8aef34a76f17c645ab25b155d381 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5062274 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 3de9237e 2023-11-27T08:55:26 Disable recursive global lock with Chromium Bug: chromium:983167 Change-Id: I7eb1c993a2ffa4127ec207f160c12e4c94c6b2e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5061830 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev b7a31b7f 2023-11-27T00:00:00 dEQP: Treat signed integer overflow as two's complement Bug: b/307584642 Fixed: angleproject:8429 Change-Id: Ib3cdd1835d4c669a79a4553b24da676eb41e21b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5062708 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ea823893 2023-11-27T07:00:17 Roll Chromium from 89adc6a8e802 to 3c5e99605653 (503 revisions) https://chromium.googlesource.com/chromium/src.git/+log/89adc6a8e802..3c5e99605653 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8b922e8b99..cdf0c47b04 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/06a9897f24..ed2855f2d6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1ff91ec2c9..e20739ec64 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c03569abfc..9e4e987c28 * third_party/r8: Vjgh6DGZpPhxYqNjulYH9ogpNFhkWn31RDgrWeRQmPcC..YJv5xgb5CjUj1a0k36y8EQ5Fg7faGfQi1bKh8-cAv6QC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9fbc780088..8e1981d442 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/31368237c9..63050f1b91 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I83e87d480cc4ceb8c619aeec1f39431d6ed24277 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5060780 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9a70fc90 2023-11-25T15:53:13 Roll VK-GL-CTS from 005862913ee9 to fdb23dfe8f79 (10 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/005862913ee9..fdb23dfe8f79 2023-11-25 rgarcia@igalia.com Test static stencil write mask zero with discarded fragments 2023-11-25 ziga@lunarg.com Add transform feedback with conditional rendering tests 2023-11-25 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-11-24 gsweet@broadcom.com Add missing pipeline barriers in d/s buffer-to-image copies 2023-11-24 amber@igalia.com Add device lost detection support and a --deqp-terminate-on-device-lost option. 2023-11-24 ziga@lunarg.com Fix usage flags in external memory maintenance5 test 2023-11-24 rgarcia@igalia.com Remove ESO variants of extended dynamic state null pointer tests 2023-11-24 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-11-24 lorenzo@khronosgroup.org Fix for bug introduced in a8b1e1b (verbose option) 2023-11-20 javed@igalia.com Restore test descriptions as comments If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I9ea46e867c8b6747200ff55127576bee5344a1cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5060238 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lu Yahan 1bdb4038 2023-11-23T16:37:37 [riscv] Add riscv support Bug: angleproject:8423 Change-Id: Id1d9b06ff18985cb66a865477c30fdac8791e9de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5057086 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll baf4a9ca 2023-11-24T11:57:08 Roll vulkan-deps from fe7ac4762e47 to e892a337898c (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/fe7ac4762e47..e892a337898c Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/fd403737d2..153064f2c7 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/42aac916ab..42299f92ef * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a4ff6a54e4..0e7cf57a29 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7adefb0aeb..4d7cdcc223 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I1083ac6d49c55d274da32adcbd56620d641bcbc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5057095 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll bb7ac182 2023-11-24T07:42:59 Roll Chromium from d2936bfdb0ac to 89adc6a8e802 (325 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d2936bfdb0ac..89adc6a8e802 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/95d1d44174..8b922e8b99 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2a8d2c5eab..06a9897f24 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b403c6abb2..1ff91ec2c9 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e9f4ddc3e1..3470538450 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b80aa2639f..f0228fa92b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4b348d339b..c03569abfc * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/371593893a..e6a7fd81ed * third_party/r8: vFBpAdZar_sS8W_xKvQThRv5XpFyYZP4bMzjigyTTcwC..Vjgh6DGZpPhxYqNjulYH9ogpNFhkWn31RDgrWeRQmPcC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/5daffc716b..22124f50e9 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d262359249..521ee9b0a7 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ef629b98df..a13c719040 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/fb0d858a62..31368237c9 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Iad99d76360dccc90399acbf34eb5f165483b1fb2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5058171 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi aa3bebf9 2023-11-18T22:15:11 GL: Fix parallel link query of in-progress link Bug: angleproject:8297 Change-Id: Iab2f12467a2c567c945742435939057a40642951 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5042345 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev c8f707f8 2023-11-16T00:00:00 Metal: Simplify MSL sRGB conversions * Used metal::powr instead of metal::pow because the arguments are non-negative. * Reduced nesting. Bug: angleproject:8366 Change-Id: Ibc50880060c12217b4ee8452c662d346a1cb273a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5040993 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll a5e8f86a 2023-11-23T09:58:23 Roll Chromium from 36830a1d917b to d2936bfdb0ac (525 revisions) https://chromium.googlesource.com/chromium/src.git/+log/36830a1d917b..d2936bfdb0ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/968682938b..95d1d44174 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/92b79f4d75..2a8d2c5eab * testing: https://chromium.googlesource.com/chromium/src/testing/+log/60522bfa78..b403c6abb2 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1e8861f03f..3747d5b3f1 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/abf7a60fd7..e9f4ddc3e1 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/38b8de056e..25b4354fad * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4026ecfd49..4b348d339b * third_party/r8: vgwqt33JWwV0OVbbDCoTLt78eMlewV8Ut0CN1HyOdfYC..vFBpAdZar_sS8W_xKvQThRv5XpFyYZP4bMzjigyTTcwC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9db1a23b04..9fbc780088 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f068a70f17..ef629b98df * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6131f2e326..fb0d858a62 Clang version changed llvmorg-18-init-9505-g10664813:llvmorg-18-init-11962-g73e96337 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/9db1a23b048abc77c2649412775752e67e07e8f1..9fbc780088a01c4e5e5551c63f1af2a2ea0e2efc/scripts/update.py Bug: None Tbr: abdolrashidi@google.com Change-Id: If83477e9af19c15f8ce5c15618c06a0da62c4ad1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5054166 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang fba482b7 2023-11-22T12:01:31 Fix off-by-one bounds check on uniform location. Log an error when the user provides an invalid uniform location. Bug: chromium:1504162 Bug: chromium:1484878 Change-Id: Ieb7eb964d508954ac8dfa8e4d9bd941778185223 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5054238 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: James Godfrey-Kittle <jamesgk@google.com>
angle-autoroll 95f842d6 2023-11-22T10:01:17 Roll vulkan-deps from 856d90fb41aa to fe7ac4762e47 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/856d90fb41aa..fe7ac4762e47 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/4efde4c4c1..fd403737d2 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/42ee043c5c..a4ff6a54e4 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/de53ecbb06..7adefb0aeb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Iab25a85a45dc58324911e98846b42f69647f7516 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5051817 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b5e311a9 2023-11-22T07:01:47 Roll Chromium from 27466d6e992e to 36830a1d917b (565 revisions) https://chromium.googlesource.com/chromium/src.git/+log/27466d6e992e..36830a1d917b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/945d770c9a..968682938b * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4f46c73c17..92b79f4d75 * buildtools/linux64: git_revision:c7b223bfb225ce87a72a244d016ffdfcf227fa5e..git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03 * buildtools/mac: git_revision:c7b223bfb225ce87a72a244d016ffdfcf227fa5e..git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03 * buildtools/win: git_revision:c7b223bfb225ce87a72a244d016ffdfcf227fa5e..git_revision:92e63272dc04ee7cc1eaae2633c25da06e4f9c03 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/918cef4514..60522bfa78 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5c1525f035..b80aa2639f * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/434a8efe28..4026ecfd49 * third_party/r8: mIydEkNvLtzm1YbYV6Vch1Oj7Hwzdgw-XVLHEKLmjq4C..vgwqt33JWwV0OVbbDCoTLt78eMlewV8Ut0CN1HyOdfYC * third_party/siso: git_revision:2133382e6d258f4fa4de2cfb255d8287efc91039..git_revision:d3c91417789c3190676d18dc3cc26dff20819eea * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/32bdb9407b..6131f2e326 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ie4e2b6628360cef71db29c9c5ac8c41c4b9eade9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5050569 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 20eff9db 2023-11-21T10:01:52 Roll vulkan-deps from 63bb05a5e0ad to 856d90fb41aa (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/63bb05a5e0ad..856d90fb41aa Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/854db99ff1..4efde4c4c1 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/af4fb97d7b..7d92fe7b68 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/19e9e53255..42ee043c5c * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/e4ceafdd06..228f7487dd * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1cbb2c8ffa..de53ecbb06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Iecfd144a4b13a301aca3b10ceeb76b8961841b2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5046148 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c69e4825 2023-11-21T08:11:54 Roll Chromium from 0ddb38eda131 to 27466d6e992e (574 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0ddb38eda131..27466d6e992e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cd2687c456..945d770c9a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2895795509..4f46c73c17 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f6ba9d58d1..918cef4514 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d1c140e8b7..1e8861f03f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bd17576ac2..5c1525f035 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eb48a6ac0f..38b8de056e * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a96e76348a..434a8efe28 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f06a19ed57..9db1a23b04 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/407bbc768d..32bdb9407b No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I2caeffdff234a2cd22cc7f87bba0b7742c802d93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5046146 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 1169f6b4 2023-11-18T21:03:54 Add bad app behavior to parallel link perf test A large majority of apps hinder parallelism by immediately querying the link status after glLinkProgram. The parallel link perf test is now exercising this behavior as well. Additionally, since the Vulkan backend's default is to disable parallel link, the perf test is also enhanced to include this case. A follow up change will improve the performance of both these scenarios with the Vulkan backend. Bug: angleproject:8417 Change-Id: I39b9d5703a17d051d20d35fd4cede2b415e770a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5042344 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll cb28076f 2023-11-20T10:01:48 Roll vulkan-deps from b5f778a99583 to 63bb05a5e0ad (16 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b5f778a99583..63bb05a5e0ad Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/845e5d5a28..854db99ff1 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0df791f97a..2a238ed24d * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/38c5ce8b11..19e9e53255 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ae2a2dc99b..9ef6c05af3 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/177e2312fa..e4ceafdd06 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9534ebe901..1cbb2c8ffa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: If6eed060cb850e03db4d7c045ff934ec688b1e93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5043922 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c8a544dd 2023-11-20T09:49:36 Roll VK-GL-CTS from 55b64f6ad410 to 005862913ee9 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/55b64f6ad410..005862913ee9 2023-11-18 ziga@lunarg.com Remove descriptions from new eds tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I6d0a9f851d0eebe449441c56c304a2e0b6a73730 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5042854 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7c3233d7 2023-11-20T07:01:45 Roll Chromium from db5279ea46cd to 0ddb38eda131 (743 revisions) https://chromium.googlesource.com/chromium/src.git/+log/db5279ea46cd..0ddb38eda131 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/23f94fa6ef..cd2687c456 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/7d02c8ca33..2895795509 * buildtools/linux64: git_revision:bc5744174d9ea1c292f3f08cfb95fa97ea5c595e..git_revision:c7b223bfb225ce87a72a244d016ffdfcf227fa5e * buildtools/mac: git_revision:bc5744174d9ea1c292f3f08cfb95fa97ea5c595e..git_revision:c7b223bfb225ce87a72a244d016ffdfcf227fa5e * buildtools/win: git_revision:bc5744174d9ea1c292f3f08cfb95fa97ea5c595e..git_revision:c7b223bfb225ce87a72a244d016ffdfcf227fa5e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9740b867f3..f6ba9d58d1 * third_party/android_build_tools/manifest_merger: kyXImK5GOP19ROuy-2wf_I_zzcVr2RVsPvB0jhLyrCEC..SdNR04V227YL22FMmKoS4AdLYwv6MJe8HBAZKNhXoCsC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bb1266a081..bd17576ac2 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/06c4261af7..eb48a6ac0f * third_party/fuchsia-sdk/sdk: version:16.20231110.0.1..version:16.20231117.2.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4399383935..a96e76348a * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d529bb588f..371593893a * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/19b1234bfb..85df028e4c * third_party/r8: LSKbogNru-rwoTlrVtJniI4WT8_ZQbcI8QyWQJfwHXoC..mIydEkNvLtzm1YbYV6Vch1Oj7Hwzdgw-XVLHEKLmjq4C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1f8329e28f..f06a19ed57 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0638c560d2..f068a70f17 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cbdb0871cd..407bbc768d No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I3c962e06718cd60ab387c272d4f3126806c29380 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5043628 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Le Hoang Quyen 98d79260 2023-11-09T10:15:11 Metal: use release-consume order for queue's serials. Currently mtl::CommandQueue's mCommittedBufferSerial, mCompletedBufferSerial use relaxed memory order for load & store. They should use consume & release memory order respectively instead. Bug: angleproject:8406 Change-Id: I871259f1a6cca0e63d6c24b7592e7b80fd443dff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5015524 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll 88f7a65d 2023-11-18T10:32:07 Roll VK-GL-CTS from ff0a874a4e15 to 55b64f6ad410 (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ff0a874a4e15..55b64f6ad410 2023-11-18 javed@igalia.com Add tests for unused push constants. 2023-11-18 javed@igalia.com Fix test failures on VK_ERROR_FORMAT_NOT_SUPPORTED cases. 2023-11-18 lorenzo@khronosgroup.org Add verbose option for logging build information 2023-11-18 javed@igalia.com Add coverage for fully dynamic blend state with 0 attachment count. 2023-11-18 rgarcia@igalia.com Test pipeline libraries do not use the creation render pass 2023-11-18 rgarcia@igalia.com Test feedback loop attachment followed by draw with 0 attachments 2023-11-18 rgarcia@igalia.com Test mismatch in pipeline and render info att. count 2023-11-18 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iec7aa2ad19ad41debfa760885c3c0ada6d4b9d2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5039284 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chia-I Wu 170ba8c9 2023-11-16T19:45:35 Vulkan: Workaround depth bias constant factor on RADV Both ANV and RADV need the same workaround. Improve IsRADV to support Venus-over-RADV. Also "git cl format" to make presubmit happy. Bug: b/308835020 Test: dEQP-GLES3.functional.polygon_offset.fixed16_render_with_units Change-Id: Ibbad4d09f12df419e38aff1365d37d55ca326532 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5040097 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Chia-I Wu <olv@google.com>
angle-autoroll 6d50433c 2023-11-17T10:01:26 Roll vulkan-deps from 8fa1b1b67aa7 to b5f778a99583 (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8fa1b1b67aa7..b5f778a99583 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/4818f7e7ef..42aac916ab * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fb91e6f0eb..0df791f97a * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1ccfee8ee9..ae2a2dc99b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ac9cad108a..9534ebe901 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ifaeb2d984f691853eb815b1630eceecba5f41d58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5039281 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 33c77262 2023-11-17T07:24:53 Roll Chromium from 452960350735 to db5279ea46cd (590 revisions) https://chromium.googlesource.com/chromium/src.git/+log/452960350735..db5279ea46cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cacb5e680e..23f94fa6ef * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b20d1ecc58..7d02c8ca33 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1bc934d5a4..9740b867f3 * third_party/android_build_tools/lint: WRfTG1DnMqZHCdWAtNv2HfU9XUBWoAN58YlHtYB-vKEC..A9hM5McVrqwLhfWjg3dptcOFMxIiBJaMsrmG-rb8aW0C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b46041dad0..bb1266a081 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/58700cf7f8..06c4261af7 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/5b600baabc..4399383935 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/0226cb1cdf..d529bb588f * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/7b9fd7a061..19b1234bfb * third_party/siso: git_revision:c4b451b1bbfc63c12459aba4960686f8a82417df..git_revision:2133382e6d258f4fa4de2cfb255d8287efc91039 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/dfc48fc4de..5daffc716b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/624eabb790..0638c560d2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7afccc877e..cbdb0871cd No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I22e7bda87236b158edf106f4c69ad7927613c887 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5040343 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 8ae36a93 2023-11-14T10:11:51 Vulkan: Bugfix in isFastUnpackPossible Disallow fast unpack when there is a mismatch between the actual texture format and intended buffer (PBO or client buffer) format. Bug: angleproject:3777 Test: Texture2DTestES3.UnpackCompatibleFormatButDifferentType* Change-Id: I9ea9d9cdd5e1391acebb3d75d69437e27cfa90df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5029504 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Josip Sokcevic c208f9ea 2023-11-16T12:57:42 gitmodules: remove .git suffix Bug: b/303296048 Change-Id: Ic15a88624fd3ffa0ec14cd1682e4385729f7c19f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5038232 Auto-Submit: Josip Sokcevic <sokcevic@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 3944ffce 2023-11-13T18:32:13 Add missing validation code The validation code for below GLES 3.2 entry points is added: GL_TexParameterIiv GL_TexParameterIuiv GL_GetTexParameterIiv GL_GetTexParameterIuiv GL_SamplerParameterIiv GL_SamplerParameterIuiv GL_GetSamplerParameterIiv GL_GetSamplerParameterIuiv Also add extension check in validation functions of entry points that are exposed through these two extensions: GL_OES_texture_border_clamp GL_EXT_texture_border_clamp The validation functions of GL_OES_texture_border_clamp extension are moved to validationESEXT.cpp for readability. Bug: b/286572199 Bug: b/224537784 Change-Id: I77ed22e8dc961a30a5d86b0597c25555d15c517b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5028139 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d4281637 2023-11-15T13:17:36 Add names to worker threads Bug: angleproject:8417 Change-Id: I5841d194cb695387aa8fe48638cc025173152347 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5034797 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tomasz Wasilczyk 3698f3f3 2023-11-15T10:36:16 Angle: pin cpp_std to gnu++17 This project doesn't build with gnu++20 and prevents AOSP default to be upgraded to a newer standard. Once the build failure is fixed here, this change can be reverted. Bug: b/311052584 Test: scripts/roll_aosp.sh --genAndroidBp Test: m checkbuild (on AOSP) Change-Id: Ia820e7ea67e6fee812b85f0568c66e1ca4a88705 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5032449 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev e8923a62 2023-11-14T00:00:00 Clamp gl_PointSize to both bounds Ensure that point size values smaller than ALIASED_POINT_SIZE_RANGE[0] are clamped as the spec requires. Fixed: angleproject:8416 Change-Id: I3cfd2b1d3c1f34788d062ff4ca4b809ce3b5aaa9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5033198 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 01bddb8e 2023-11-16T10:01:22 Roll vulkan-deps from f4839bd25267 to 8fa1b1b67aa7 (16 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f4839bd25267..8fa1b1b67aa7 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/be3c81e3fd..cca08c63ce * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8ee3ae5244..fb91e6f0eb * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/90e25ec83a..1ccfee8ee9 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9e89de69f3..ac9cad108a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I18f137e689149e99056c58c4f366a5584819c21a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5035064 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 54189548 2023-11-16T07:37:48 Roll Chromium from 0378e885ab8c to 452960350735 (564 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0378e885ab8c..452960350735 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/33f6a1bed4..cacb5e680e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/bef6b92074..b20d1ecc58 * buildtools/linux64: git_revision:9a45b61238317b09b778c47555527c9926700e0c..git_revision:bc5744174d9ea1c292f3f08cfb95fa97ea5c595e * buildtools/mac: git_revision:9a45b61238317b09b778c47555527c9926700e0c..git_revision:bc5744174d9ea1c292f3f08cfb95fa97ea5c595e * buildtools/win: git_revision:9a45b61238317b09b778c47555527c9926700e0c..git_revision:bc5744174d9ea1c292f3f08cfb95fa97ea5c595e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5dc9940058..1bc934d5a4 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/84ccde02f2..d1c140e8b7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/23e70e69e5..b46041dad0 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/86c7f734f5..58700cf7f8 * third_party/kotlin_stdlib: UHG1TEvmBMX93y7dRSaoalB3LBMY2O5-OOvlFUByl5wC..QEHg036Jc2HWG4-ao7usl1QUexRidGFFSgqqWUpmK-YC * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/333c767f87..5b600baabc * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/69b8c64697..7b9fd7a061 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4ba5c18b33..624eabb790 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/857abd82b8..7afccc877e No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I0199515e19ddcae49acb1b2e11d799c213fdaba6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5035710 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi c5eb810b 2023-11-14T15:01:25 Remove angle::Result::Incomplete entirely Bug: angleproject:8414 Change-Id: I8d607614614360b65c530e3e7647d8a7ba38b18e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5031191 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi dd8432b5 2023-11-14T14:39:45 Remove angle::Result::Incomplete from shader/program paths angle::Result is not an error code, and having Incomplete made it very unclear what the purpose of this class is. A follow up will remove it entirely. Bug: angleproject:8414 Change-Id: Ica8271b9f7d8868671c7658161e50a53ef23c681 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5028091 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll eb6d1a82 2023-11-15T10:37:08 Roll vulkan-deps from 855191177ccd to f4839bd25267 (16 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/855191177ccd..f4839bd25267 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1dcb072cda..845e5d5a28 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/38f39dae5b..be3c81e3fd * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6b1e609ef1..8ee3ae5244 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0b31098e53..38c5ce8b11 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/312716a437..9e89de69f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ia8e174938bda11d87e76a28aad441f98163f6923 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5032436 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 359187dd 2023-11-15T08:24:27 Roll Chromium from a89a138fcfa3 to 0378e885ab8c (673 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a89a138fcfa3..0378e885ab8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/02912baf87..33f6a1bed4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b1425178e0..bef6b92074 * buildtools/linux64: git_revision:85bd0a62938bc84e1b8db0ef92be0e2bb634378d..git_revision:9a45b61238317b09b778c47555527c9926700e0c * buildtools/mac: git_revision:85bd0a62938bc84e1b8db0ef92be0e2bb634378d..git_revision:9a45b61238317b09b778c47555527c9926700e0c * buildtools/win: git_revision:85bd0a62938bc84e1b8db0ef92be0e2bb634378d..git_revision:9a45b61238317b09b778c47555527c9926700e0c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/def3564952..5dc9940058 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/01573850fd..23e70e69e5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7a9b709a6c..86c7f734f5 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2acf65d77d..333c767f87 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e51fad41df..4ba5c18b33 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/75bdec3aa3..857abd82b8 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I76f47d0da35fa42c0a203ecf1d010f2791959fd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5030987 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Eng a982e241 2023-11-01T10:11:09 renderergl_utils: check strings from glGetString for nullptr Return empty string instead. It is not valid to construct std::string or perform sscanf on a nullptr. Bug: chromium:1498447, chromium:1408916 Change-Id: Iae1f2fdb1c2dfc80597aa0a6008c50d7cda33527 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4411066 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Alexey Knyazev 95bacc28 2023-11-09T00:00:00 Metal: Override texture wrap modes for cube maps Always use clamp-to-edge texture wrapping for cube maps with OpenGL ES 3.0+ client contexts. Fixed the following tests on Apple silicon: dEQP-GLES3.functional.texture.filtering.cube.sizes.63x63_nearest dEQP-GLES3.functional.texture.filtering.cube.sizes.63x63_nearest_mipmap_nearest dEQP-GLES3.functional.texture.filtering.cube.sizes.63x63_nearest_mipmap_linear dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_nearest_repeat_repeat dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_nearest_repeat_mirror dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_nearest_mirror_repeat dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_linear_clamp_repeat dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_linear_repeat_clamp dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_linear_repeat_repeat dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_linear_repeat_mirror dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_mipmap_nearest_nearest_clamp_repeat dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_mipmap_nearest_nearest_mirror_repeat dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_mipmap_nearest_linear_clamp_repeat dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_mipmap_nearest_linear_repeat_clamp dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_mipmap_nearest_linear_mirror_repeat dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_mipmap_linear_linear_clamp_repeat dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_mipmap_linear_linear_repeat_clamp dEQP-GLES3.functional.texture.filtering.cube.combinations.nearest_mipmap_linear_linear_mirror_repeat Fixed: angleproject:7022 Change-Id: I52079b3e8de5ab052a20dd8aee7ead626ced9188 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5030451 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Caroline Liu 879598f3 2023-11-10T21:38:01 [fuchsia] Strip ScenicWindow utility of unsupported Fuchsia tools Bug: fuchsia:64206 Change-Id: I7e2ec1e1d2ebc16c2381f21c0c1ad2ad7149c4fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5020238 Reviewed-by: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
mark a. foltz a75659eb 2023-11-13T16:03:26 [Cast Convergence] Remove unused GN include. This file is being removed from Chromium. It is not needed in this file and can be removed, which will avoid breakage when that happens. Bug: angleproject:8413 Change-Id: Iccc4b45393bcbc268add434b16172e90d2b9d13b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5027723 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 49f8f8a0 2023-11-13T10:01:37 Manual roll vulkan-deps from 448a71c0790c to 855191177ccd (17 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/448a71c0790c..855191177ccd Manual edits: * Includes compile fixes for vulkan_command_buffer_utils Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a8d39f97cd..1dcb072cda * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fbf047cc8b..6b1e609ef1 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/8ccd414a46..af4fb97d7b * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/6342790c86..0b31098e53 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/322e7b3f08..90e25ec83a * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/5b3147a535..177e2312fa * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0eec8db60d..312716a437 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8412 Tbr: cnorthrop@google.com Change-Id: Iddbfda975afd44f100c02a399f9f80b3ba9c7d73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5023272 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 81e3ecff 2023-11-14T10:01:01 Roll SwiftShader from 4a62a93e27d9 to 50dbfc35468c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/4a62a93e27d9..50dbfc35468c 2023-11-13 shannonwoods@google.com Remove self from OWNERS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I251827514eaccd20101b74cd2333aec3edcd6e3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5027538 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f376964e 2023-11-14T07:01:41 Roll Chromium from df1a4a20b09f to a89a138fcfa3 (540 revisions) https://chromium.googlesource.com/chromium/src.git/+log/df1a4a20b09f..a89a138fcfa3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/481e01d61a..02912baf87 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3e28c7af3b..def3564952 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f25d23e77a..01573850fd * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7f22330c69..7a9b709a6c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3c83ca4110..e51fad41df No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ibc5762fb82412e974b1d27a25e67c8641efc1c3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5029495 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov b12d4867 2023-11-13T19:35:54 Revert "Temporarily remove trace bots from CQ" This reverts commit 0f7c39a2abbf516443d6e11ba90bc6a3d084e8ca. Reason for revert: trace bots switched to reclient Original change's description: > Temporarily remove trace bots from CQ > > Reclient doesn't work yet > Goma is slower than local today > > Bug: angleproject:8309 > Change-Id: I03c337dab5ee82adc8e03d4f5f52bf2b26aa7cad > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4818506 > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Roman Lavrov <romanl@google.com> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Roman Lavrov <romanl@google.com> Bug: angleproject:8309 Change-Id: Ia64d089b759f61570b467e44d566d56e0d0c1534 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5025974 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Takuto Ikuta 7b9b95f8 2023-11-13T11:42:26 drop goma support from capture_replay_tests.py https://ci.chromium.org/ui/p/angle/builders/try/win-trace/7316/overview failed, but it seems unrelated to this CL. Bug: angleproject:8309 Change-Id: Id4fd9cad341973c87570adbea63809b5aa84c4a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5019418 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Alexey Knyazev 4256d055 2023-11-09T00:00:00 Metal: Use a quad for blit with draw Adjusted blit emulation to use a two-triangle quad instead of an implicitly clipped triangle to avoid interpolation artifacts on Apple silicon. Reduced the BlitParams struct size from 48 to 32 bytes. Disabled perspective correction as it has no effect anyway. Fixed the following tests on Apple silicon: dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_mag dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_mag_reverse_src_x dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_mag_reverse_src_y dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_mag_reverse_dst_x dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_mag_reverse_dst_y dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_mag_reverse_src_dst_x dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_mag_reverse_src_dst_y dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_min_reverse_src_y dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_min_reverse_dst_y Fixed: angleproject:8408 Change-Id: Iba8dd1c206ff859aa3e635d72adab45608496e7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5018858 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi 64eb87af 2021-05-12T00:02:22 Add test for VectorizeVectorScalarArithmetic bug Bug: chromium:1201084 Change-Id: Icfb659ae5195f8dd80fecd0904cb90b77697fa70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2889601 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Takuto Ikuta a46cc37f 2023-08-17T16:35:14 infra/config: remove goma property Bug: angleproject:8309 Change-Id: Ia657986ebc3bc49423736af743983bec6467775a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4787413 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 35f4ff2f 2023-11-13T09:50:08 Test suppressions Bug: angleproject:8409 Bug: angleproject:8410 Change-Id: I9fb41292382563f7b9cc802167bf48432a46f55d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5023829 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 108bd958 2023-11-10T17:30:43 Tests: Add Slay the Spire trace Test: angle_trace_tests --gtest_filter="*slay_the_spire*" Bug: b/310281616 Change-Id: I6c94b0e3c72be1ad3cb2897981febd3f67722a20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5021241 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Alexey Knyazev 90278ecf 2023-11-09T00:00:00 GL: Support polygon mode extensions on OpenGL ES Expose NV_polygon_mode and ANGLE_polygon_mode when the native OpenGL ES driver supports the required functionality. Bug: angleproject:1791 Bug: angleproject:8132 Change-Id: I6a273640b5ef38e79e5d11f313cb90a9c79d0485 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5023849 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 53f1ed4b 2023-11-13T13:52:58 Manual roll Chromium from 3ce1fc718a19 to df1a4a20b09f (51 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/3ce1fc718a19..df1a4a20b09f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fec6559527..b1425178e0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2ecbe124ae..3e28c7af3b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea9bf7f343..7f22330c69 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2a2315e69a..2acf65d77d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/39112f33f9..3c83ca4110 No update to Clang. Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I174d04802ae352320fca042e8967579755e7d276 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5024794 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1819b449 2023-11-13T09:30:49 Roll Chromium from 7b99529aa494 to 3ce1fc718a19 (232 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7b99529aa494..3ce1fc718a19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/eb1aaf3896..481e01d61a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8c05271edf..fec6559527 * buildtools/linux64: git_revision:e4702d7409069c4f12d45ea7b7f0890717ca3f4b..git_revision:85bd0a62938bc84e1b8db0ef92be0e2bb634378d * buildtools/mac: git_revision:e4702d7409069c4f12d45ea7b7f0890717ca3f4b..git_revision:85bd0a62938bc84e1b8db0ef92be0e2bb634378d * buildtools/win: git_revision:e4702d7409069c4f12d45ea7b7f0890717ca3f4b..git_revision:85bd0a62938bc84e1b8db0ef92be0e2bb634378d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e69e220dc6..2ecbe124ae * third_party/siso: git_revision:9aef05a1a1bddf2cf8e60bc7d9312c7afbfbe9a2..git_revision:c4b451b1bbfc63c12459aba4960686f8a82417df No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ia82b1dae39e7454045621a644146eb44bea76563 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5023271 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2da62237 2023-11-11T09:23:24 Manual roll Chromium from 4c6eada2d6e1 to 7b99529aa494 (935 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/4c6eada2d6e1..7b99529aa494 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7f3a1ab7f2..eb1aaf3896 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/32d5d56504..8c05271edf * buildtools/reclient: re_client_version:0.118.1.ae3c3be-gomaip..re_client_version:0.120.1.f75cfb7-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9bab6e4bc3..e69e220dc6 * third_party/android_build_tools/lint: aCHp55GHeldC4gUHZhm4HHX0nRp0Hr4x13l8t-xO_EoC..WRfTG1DnMqZHCdWAtNv2HfU9XUBWoAN58YlHtYB-vKEC * third_party/android_build_tools/manifest_merger: doEA4zEMMRwIiYmB3veT2pt-7z3UasxhbTo279pDV40C..kyXImK5GOP19ROuy-2wf_I_zzcVr2RVsPvB0jhLyrCEC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5a57691454..f25d23e77a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5828285134..ea9bf7f343 * third_party/fuchsia-sdk/sdk: version:16.20231030.2.1..version:16.20231110.0.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/278060665f..2a2315e69a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bbcb7c6c14..1f8329e28f * tools/luci-go: git_revision:540222a3d0b11c1370539a1f698643113a0ee029..git_revision:bd7ce256f73f85cb75c630b40afa382cdf7fcc51 * tools/luci-go: git_revision:540222a3d0b11c1370539a1f698643113a0ee029..git_revision:bd7ce256f73f85cb75c630b40afa382cdf7fcc51 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f486685f8a..39112f33f9 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/bb03b82053..884774321e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/712486c62b..75bdec3aa3 * tools/skia_goldctl/linux: WTMxFNxXY-WvCR_1vkehlNUI0Ni4WkQKZ5KyBQUl2eAC..X1YWlW-vzJ8VB4_DZDx7vQjrh06xi6o_hnxnoQ9pRJgC * tools/skia_goldctl/mac_amd64: i_w2lfW3au1P5g--qUu5Si9hY60AtCRJ5zu3K0FBxscC..tfXYA7PdwTB_MKkvGO3x0SiH7mnjOz_Qmaflm4quiVYC * tools/skia_goldctl/mac_arm64: bG_OHoTvm9OroVOakbDvX6AtkRYM0ilBMSe-kvuLTjAC..yXR-TKcp4Hk7mBJ1Yzar9h8PTy_CPyw9tGoYKjwooJoC * tools/skia_goldctl/win: WgFDkUHOv_OnoBoSP1EHQvKOTaNpj8rGNNnlZcZ5Ce4C..BYJuHIvTZ_3r-th5RnKUkcSmHEaKFPYrrkWebSiN4g0C No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I571b02e0d5f1ec8afa5fe4140b41dbb0c0917713 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5022267 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi ade3dacd 2023-11-06T21:56:41 Do compile/link unlocked if not threaded (but thread-safe) If GL_KHR_parallel_shader_compile is not supported, or it is not used to do threaded compilation and link, this change lets the compile and link jobs be done after releasing the share group lock. With multithreaded/multi-context applications, this allows the other context (typically the main context) to make progress in the meantime. A typical scenario where this optimization matters is games seamlessly loading a new area of the game and performing compilation and link in a separate context. Before this change, the game would stutter as the compile/link jobs prevent the main thread from drawing anything. With this change, the hitching is removed. Bug: angleproject:8297 Change-Id: I702d84324a7442561b49677bf42c16d650304313 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5006640 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 93b97a59 2023-11-03T22:07:23 Make link job directly wait on compile job Previously, program link waited on the compile job on the calling thread before launching the link job. As a result, sequences of intermixed compile and link would get largely serialized as such: Main Thread Thread 1 Thread 2 Thread 3 Thread 4 Compile -------> Compile Compile -----------|----------> Compile Link | | Wait | | | | | |<--------------/--------------/ \------------------------------------------> Link Compile -------> Compile | Compile -----------|----------> Compile | Link | | | Wait | | | | | | | |<--------------/--------------/ | \---------------------------------------------|-----------> Link Compile -------> Compile | | Compile -----------|----------> Compile | | Link | | | | Wait | | | | | | | | | ... With this change, the main thread no longer waits for compilation to finish. It's the link job itself that does the waiting. This allows the main thread to go through Compile and Link commands without blocking, generating as many jobs as needed. The above scenario therefore becomes: Main T1 T2 T3 T4 T5 T6 T7 T8 T9 C ----> C C ------|----> C L ------|------|----> L C ------|------|-------W---> C C ------|------|-------|-----|----> C L ------|------|-------|-----|------|----> L C ------|------|-------|-----|------|-------W---> C C ------|------|-------|-----|------|-------|-----|----> C L ------|------|-------|-----|------|-------|-----|------|----> L . \-----\------>/ | | | | | W . | \-----\------>/ | | | . | | \-----\------>/ . | | | . | | | This greatly improves the amount of parallelism compile and link jobs get. The careful observer may note that the link job being blocked on the compile job is now wasting a thread from the thread pool. While this change is strictly an improvement, parallelism can be further improved if the link job is just not assigned to a thread until the corresponding compile jobs are finished. This is currently not possible, but may be if: - Instead of a thread pool, the operating system's FIFO scheduler is used. Then the operating system would automatically put blocking tasks to sleep and pick up another task. This has the downside of requiring threads to be created for each task. - The thread pool work scheduler is enhanced to be made aware of relationship between tasks and avoid scheduling jobs whose dependencies are not yet met. Alternatively, the number of threads in the pool can be increased by 30% and hope for the best. Bug: angleproject:8297 Change-Id: If4e6540ade47558a10cfab55e2286f073b904928 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5006874 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi aec4ffac 2023-11-06T14:13:06 Add a perf test for parallel compile and link Bug: angleproject:8297 Change-Id: I40ec3af49bd0f5effbafc82b557840c615fd4c64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5008040 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 3a6b385f 2023-11-09T15:48:48 Vulkan: Fix depth/stencil texture copy Bug: angleproject:7289 Change-Id: Icde8a26e855e95a6c0a1e506d2435e981adc6f28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5018798 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi d896fab8 2023-11-09T15:03:05 Vulkan: Fix texture self-copy A new layout is introduced to support self-copy. Bug: angleproject:7289 Change-Id: Ib914c433d55b9a79cfeb7a91f8a2b8680824d473 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5018797 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Geoff Lang e56cde03 2023-11-06T11:50:38 GL: Reset mLocalDirtyCurrentValues after syncronizing StateManagerGL::setAttributeCurrentData sets the bits in mLocalDirtyCurrentValues, leaving them set after syncState. All current values would be re-synchronized every time any the DIRTY_BIT_CURRENT_VALUES bit was set. Bug: chromium:1496378 Change-Id: I93b78c8f2d576f5583ac629660f189c268a154d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5008036 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ce40e12c 2023-11-10T14:40:32 Roll VK-GL-CTS from b127977ddad4 to ff0a874a4e15 (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b127977ddad4..ff0a874a4e15 2023-11-10 amber@igalia.com Add tests for alpha to coverage along with depth+stencil writes. 2023-11-10 ziga@lunarg.com Add host image copy tests for identical memory layout 2023-11-10 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I56f760169e6cd04a19cbe1e168c264387a8e87b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5020508 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e5119649 2023-11-10T12:27:59 Roll vulkan-deps from fd7e3d444d59 to 448a71c0790c (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/fd7e3d444d59..448a71c0790c Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/091b9fd979..a8d39f97cd * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9e7a1f2ddd..fbf047cc8b * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/aff5071d4e..8ccd414a46 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/daec145d41..0eec8db60d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I79eb39c562dcad467a1360c6119ff5502c73212b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5020228 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov f773a79f 2023-11-09T17:26:16 Roll chromium_revision a63a2e6890..4c6eada2d6 (1220134:1222362) Manually applies https://chromium-review.googlesource.com/c/chromium/src/+/5007775 Change log: https://chromium.googlesource.com/chromium/src/+log/a63a2e6890..4c6eada2d6 Full diff: https://chromium.googlesource.com/chromium/src/+/a63a2e6890..4c6eada2d6 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6f4d783d07..7f3a1ab7f2 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e1fa8831f1..32d5d56504 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/50cd78eb0e..9bab6e4bc3 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/03ab17bf55..84ccde02f2 * third_party/android_build_tools/bundletool: xOeKyLIaK_RRHU0Qv0EdxTrRlq_22HAwoOr1xn5yoOcC..XoK0RwIzanpFScg7dU_8th5zMvLgKvk7c_PmhZ5LSEQC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/2af29c6a26..abf7a60fd7 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/1fb4dd28f9..f7abe43b8a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f3e882d631..5a57691454 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b4e466e610..5828285134 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d781e6e1b8..278060665f * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/6969ef7fe9..41759e11ec * third_party/r8: XPk3PlUaYx3a8bIbKLnF6Dp23cbjBn6zSLmkL4SukQoC..LSKbogNru-rwoTlrVtJniI4WT8_ZQbcI8QyWQJfwHXoC * third_party/siso: git_revision:6af7e19f74a94ee61f1ddabc0d23b8e3c0d02e98..git_revision:9aef05a1a1bddf2cf8e60bc7d9312c7afbfbe9a2 * third_party/turbine: C6QGDoh6Gsr8uSRNcsphzaRJEoG9qKitOL771Mv9piIC..rg7X3-H8Yd0enT9HWZY9KwEh1ciZBP0jkla5_rGW2pUC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d1e293c5d2..bbcb7c6c14 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6815c10162..f486685f8a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9818a0f413..712486c62b DEPS diff: https://chromium.googlesource.com/chromium/src/+/a63a2e6890..4c6eada2d6/DEPS No update to Clang. BUG=None Change-Id: I6580d5bdc1ef73b15faeb587ac93885fea6732b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5017896 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 4c500944 2023-11-08T16:16:23 Translator: Mark most builtins as not having side effect This helps the translator eliminate stray uses of these builtins. Bug: angleproject:6061 Change-Id: Ic0e72bddad5730fb1f906a4c8e53191ab3318d29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5012988 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 6eeb11bd 2023-11-08T15:54:13 Translator: Unmark dFdx, dFdx and fwidth as having side effect These were marked as having a side effect in https://chromium-review.googlesource.com/c/angle/angle/+/924155, but it's unknown why. This change separately unmarks them as having a side effect, so if they are there to prevent a driver bug or such things, it can be isolated to this change. Bug: angleproject:6061 Change-Id: I8694ffdbb0142d330c8e2d73562f8004158023b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5012986 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill aea43399 2022-08-29T10:44:41 Mark texture2D() functions as not having side effects. This should allow the shader translator to remove unused variables and cut out sampling instructions in apps like T-Rex. Bug: angleproject:6061 Change-Id: If543c9c737cdbcfdea1433876cd425e7335e5297 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3862383 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 2155534b 2023-11-06T11:49:20 Don't set dirty bits for attribs that are out of range. PrivateState::setAllDirtyBits sets all bits in mDirtyCurrentValues. When the context has fewer max attibutes than MAX_VERTEX_ATTRIBS, this can cause out-of-bounds access to PrivateState::mVertexAttribCurrentValues if the dirty bits are iterated over without range validation. Bug: chromium:1496378 Change-Id: I65481c432263a6e353a9361bba741b97dc5e20b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5008034 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 4f4e8838 2023-11-09T10:01:57 Roll vulkan-deps from 969da898b476 to fd7e3d444d59 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/969da898b476..fd7e3d444d59 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/88bc5e321c..38f39dae5b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ca58d5500b..daec145d41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I69e7e68f974a620e729b1dc4d3c2c33fee0ce834 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5013261 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Takuto Ikuta 1bb2c5ec 2023-11-07T15:44:41 support reclient in capture_replay_tests This also uses autoninja to start and stop reclient automatically. This will be used with https://crrev.com/c/4797373. Bug: angleproject:8309 Change-Id: I2e17c87c8ff0e253f16201297ef979337bf30292 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4796170 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Shahbaz Youssefi cea3775c 2023-11-02T15:41:06 Vulkan: Suppress VU Undefined-Value-ShaderOutputNotConsumed Bug: angleproject:8401 Change-Id: I3b561ec98090cf1c0050f113db96ea0c6c79d785 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5002728 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
kmx.io     mail     discord kmxgit v0.4.0