|
f6b40bc8
|
2025-05-15T00:00:00
|
|
Add a missing compile macro
Bug: angleproject:406922380
Change-Id: If2d4cc1472b490b3507591f0a6ac940369df5ccb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6624377
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
8c48b502
|
2025-06-05T02:09:54
|
|
Vulkan: Fix deferred clear vs robust init vs invalidate
The DIRTY_OBJECT_DRAW_ATTACHMENTS bit, when handled, goes over
framebuffer attachments and requests that they be cleared. This is done
only with robust init.
The DIRTY_OBJECT_DRAW_FRAMEBUFFER bit, when handled, results in staged
updates to be applied to the attachments.
When syncDirtyObjects is called, the above bits are handled. If we end
up in a situation where DIRTY_OBJECT_DRAW_ATTACHMENTS is set, but not
DIRTY_OBJECT_DRAW_FRAMEBUFFER, the following happens with Vulkan:
- Handle DIRTY_OBJECT_DRAW_ATTACHMENTS
- TextureVk::initializeContents
- ImageHelper::stageResourceClearWithFormat
- Observer message to TextureVk->Texture->Framebuffer->Context
- Context sets DIRTY_OBJECT_DRAW_FRAMEBUFFER
- However syncDirtyObjects does not notice this bit, as it has cached
the dirty objects and is in the middle of looping over them
In the above scenario, the call that results in syncDirtyObjects does
not process the draw framebuffer (if not already dirty for some other
reason), meaning the clear is not applied _before_ the current operation
but after it (whenever framebuffer is synced next).
In this change, I attempted to ensure that if
DIRTY_OBJECT_DRAW_ATTACHMENTS is ever dirty,
DIRTY_OBJECT_DRAW_FRAMEBUFFER is also dirty. There were a few
operations that could theoretically lead to this which are fixed by this
change. The particular one that revealed the bug was
State::syncDirtyObject syncing only the FRAMEBUFFER bit and leaving the
ATTACHMENTS bit for the unsuspecting following operation.
The aforementioned assertion is not included in this change however, as
it revealed one unresolved issue with the d3d backend where
DIRTY_OBJECT_DRAW_ATTACHMENTS is not set, but processing
DIRTY_OBJECT_DRAW_ATTACHMENTS sets it while dirty bits are being
processed.
Bug: b/381284577
Change-Id: If3c35fbade069ae75f66dd6d4df5d73882a08a93
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6621059
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
92dec961
|
2025-05-15T00:00:00
|
|
Enforce validation consistency for lockless entry points
Bug: angleproject:406922380
Change-Id: If4e6051d0ac465f4ae8abca0a62cad14d1d739b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6624114
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
b6579180
|
2025-05-15T15:29:28
|
|
Add test case for CS writes without barriers
* Added the following test to ComputeShaderTest:
WriteToSeparateSSBOComponentsWithoutExplicitBarrier
* Based on KHR-GLES31 test:
.core.shader_storage_buffer_object.advanced-switchBuffers-cs
* It involves writing to different components of an SSBO without
explicit barriers in between.
Bug: b/417769912
Change-Id: I9f6170937c9ccf3487d8f9e7758196c950252ea3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552162
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
25fc5046
|
2025-06-05T03:01:42
|
|
Roll SwiftShader from a8133cbb3c89 to b62ac8aa106b (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/a8133cbb3c89..b62ac8aa106b
2025-06-04 swiftshader.regress@gmail.com Regres: Update test lists @
a8133cbb
2025-06-04 syoussefi@google.com Fix a number of asserts hit by latest
tests
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: Ibaa7fc30224a1cf9b48953d36af07310ae4003f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6623507
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
6400268a
|
2025-06-05T10:01:17
|
|
Roll vulkan-deps from d308a0e9d35f to 0dbc05833984 (7 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/d308a0e9d35f..0dbc05833984
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b888ebcee8ffaa59536b5f33277936536249d9be..fc060af4813d2d9b973f982c4987e1d53b1ec1c6
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/bb77842234bc567399f2621ec52e9649b80fdad0..7bcaa58729088d25eb6cbe6fce3dee9a9812f43e
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/7168a5ad041f6b6b9170f027c7417f98a2056ff0..fd96661925488574fe247a779babe5d380b63635
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/2e743e96b990f7390290630243b00ca0a75b8547..7dda3c01fb4c0f9941d3cb792947d57d896ac55f
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/338676d66f73bebfc1b64639b0a17149827ea7ac..596534df7e93137255f803653de4614e9d9e7ba2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: Ifdeea7e1e1099d3b595a83fac5b4f3dc43b72455
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622668
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
c2250cb4
|
2025-06-05T08:00:51
|
|
Roll Chromium from 0e7cd65001cf to ae0de49bcdc3 (680 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/0e7cd65001cf..ae0de49bcdc3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/fedeebe26a..e78b1cf9e6
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/52827af8a8..3c185fa96c
* buildtools/linux64: git_revision:b99a82ca8ee957da829d6313b818b99df8e7ccb8..git_revision:e5c4d1881b85b82789b7013233a944cf1a46370f
* buildtools/mac: git_revision:b99a82ca8ee957da829d6313b818b99df8e7ccb8..git_revision:e5c4d1881b85b82789b7013233a944cf1a46370f
* buildtools/win: git_revision:b99a82ca8ee957da829d6313b818b99df8e7ccb8..git_revision:e5c4d1881b85b82789b7013233a944cf1a46370f
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/838439e50c..4abe594e45
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f457992f2e..2b011cd0e9
* third_party/android_build_tools/error_prone/cipd: d635j0CoYfvepgbzkY8HflRSqwy4iELc08Rp569cJgkC..OFmDaNXqS5PTb5YKd4fCb0Y4cK4ImQXeZISzw9p1ILcC
* third_party/android_build_tools/lint/cipd: xY4TOq8o-UL3ddPKL_Md8HxqA-8zygxI2qe4TOy99UwC..B12WztL3EZsuJ7B1dMlfrnCHVd4n5qgxf_HYDQyzOkAC
* third_party/android_build_tools/manifest_merger/cipd: 08J0vF1HTJjf04BVy5fG5CWz9mJamI6-WLN9zSX7ZwEC..1QtZ_gZ5icFNOEvVrY34lJgcC2XoXxBfgPmz-eBrk7UC
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c35f24154b..8413456528
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d200280fa4..ea769d2a2a
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a55a42f55b..6d52c22ee3
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/275cada5de..0e242589e5
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/81a117beb4..644c27c66c
* third_party/r8/cipd: 92cfx3PA_Av-Zy3T2B_Whp1BtsuG_yeS_4HfsZra62IC..pxgwR4ardZ3LnNCARPEbdl_gTA9R1aaHowtsCNRpZaYC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9663e533dd..6268d2158a
* tools/luci-go: git_revision:963177240b1a36697c9762856f51ad36ab545ceb..git_revision:4ee25ef52cdb1d0ce5bba817578a4b40381bc39e
* tools/luci-go: git_revision:963177240b1a36697c9762856f51ad36ab545ceb..git_revision:4ee25ef52cdb1d0ce5bba817578a4b40381bc39e
* tools/luci-go: git_revision:963177240b1a36697c9762856f51ad36ab545ceb..git_revision:4ee25ef52cdb1d0ce5bba817578a4b40381bc39e
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5edb7a1ed8..04d0441efb
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c8cadb6f86..db7318cc95
* tools/skia_goldctl/linux: tuzeYVGxTKob1ipSmtH0hGunYFgqsvIk3fi6LKfo-JUC..bg1T2otEnMQQe-Lo1MLLZexZL1VsvAVAqfwuhhjSxQ4C
* tools/skia_goldctl/mac_amd64: 9WP08e9kVtdiE5A8xbucFZLJbVhEaWpy6lPHloEq28IC..v4HGLZ-ir5Y-4pZMGKYMAgJ7yAEv5Y5Kj-cdpYfzlgoC
* tools/skia_goldctl/mac_arm64: GmbmM4D9tFMSiRmMyhJC2m8Qn9ALIaSjqE23bxg300AC..LNWlZ0vnIDglaN4JlNc530ujLuhm_WIlIjLZEbgNfOcC
* tools/skia_goldctl/win: fqCHxyWS11f2OKiSL4CdTjHjEZx0Bm1PvJ3KDHjgf_0C..RKUSAHdNBItBShnfuk9DnsnmBS-7kTAt7k2N_GzFzmsC
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I76fa677c8d1b130b309d514e1b81f85eac8a61e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622933
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
ef31b3ed
|
2025-06-04T12:00:04
|
|
Vulkan: Selectively dirty DIRTY_BIT_SAMPLE_SHADING
When program executable changes dirty DIRTY_BIT_SAMPLE_SHADING bit
if either the current or previous program enabled per sample shading
Bug: angleproject:386749841
Change-Id: I82aa7df29473e455aa68dfba9fefdb1bc712a78d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6622156
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
93184102
|
2025-06-04T11:34:27
|
|
Manual roll vulkan-deps from 84aa8fdf32d0 to d308a0e9d35f (47 revisions)
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/vulkan-deps.git/+log/84aa8fdf32d0..d308a0e9d35f
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/be4ee7d0e3bfd151bfda7b3a8e03f8c49c55ed7b..b888ebcee8ffaa59536b5f33277936536249d9be
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/4841ea0a48c4ea07e9f24db3322f31541a25a101..bb77842234bc567399f2621ec52e9649b80fdad0
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/9a46274d2ef215d3c258ed4d1863bff4514fa316..7168a5ad041f6b6b9170f027c7417f98a2056ff0
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/a9d7fde99e73a619bbdda648473eff5895ead273..2e743e96b990f7390290630243b00ca0a75b8547
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/75ad707a587e1469fb53a901b9b68fe9f6fbc11f..b11eecd68fb4b770f30fe2c9da522ff966f95b1e
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/c913466fdc5004584890f89ff91121bdb2ffd4ba..bf4aec7ddb0f46d729ebd3255296d9fe8eed73ec
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/60b640cb931814fcc6dabe4fc61f4738c56579f6..e4fb76dc08f139df0436e9c3031f75be5e1f6264
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/49ac28931f28bffaa3cd73dc4ad997284d574962..03e1445cc7cce22baeeef8eff7bb934362d040eb
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e2d41fdd5ac2b0138112b61bd6eed0e0bb0ea693..338676d66f73bebfc1b64639b0a17149827ea7ac
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,ynovikov@google.com,yuxinhu@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com,ynovikov@google.com
Change-Id: I624c45182141a8611c6e9dab69a597c0749c99ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6618312
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
71910994
|
2025-06-04T07:00:09
|
|
Roll Chromium from 0b76caa6045f to 0e7cd65001cf (607 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/0b76caa6045f..0e7cd65001cf
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/9d1a4700d6..fedeebe26a
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/176c77f623..52827af8a8
* buildtools/linux64: git_revision:a84e399f9999003472192286abc03d752c9cb1f0..git_revision:b99a82ca8ee957da829d6313b818b99df8e7ccb8
* buildtools/mac: git_revision:a84e399f9999003472192286abc03d752c9cb1f0..git_revision:b99a82ca8ee957da829d6313b818b99df8e7ccb8
* buildtools/win: git_revision:a84e399f9999003472192286abc03d752c9cb1f0..git_revision:b99a82ca8ee957da829d6313b818b99df8e7ccb8
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3273e1952b..838439e50c
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7a3de773a3..d200280fa4
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/57dfc366b7..a55a42f55b
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/536618d78c..275cada5de
* third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/9f916e90e6..e2c93c3498
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/afcd61ed9a..5edb7a1ed8
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4da90bcf9c..c8cadb6f86
No update to Clang.
Bug: None
Tbr: yuxinhu@google.com
Change-Id: I47d8ec5981deeffca18c8388f812f6844a4e9bd4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6620578
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
23097376
|
2025-06-03T22:26:05
|
|
Update src/common/base's README
Bug: chromium:378273323
Change-Id: Iaa40abac52fdb2d5f8e3a65333d589097cb98834
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6617103
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
88ea74bf
|
2025-05-30T14:17:09
|
|
Add another condition to call copyBufferDataToImage directly
To directly copy from a buffer, it's necessary that the buffer does not
need conversion. Add this condition to the check function.
Add related end2end test.
Bug: angleproject:421288695
Change-Id: Id57df32f91a8f385bc07b2788149cc4478ccbab4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6605140
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Jiaqi Li <Jiaqi.Li@arm.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
87217c88
|
2025-06-03T08:01:03
|
|
Manual Roll VK-GL-CTS from 2231585b0204 to 832d82a93cb1 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2231585b0204..832d82a93cb1
2025-05-30 kamil.goras@mobica.com Add missing coverage for
ClearTex[Sub]Image for OpenGL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: b/421940612
Tbr: yuxinhu@google.com
Change-Id: I5b57cfc7b1d23b30fd8764db735eb5cf516ddc20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6616574
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
e877e655
|
2025-06-02T17:02:36
|
|
Reland "Suppress VUID-VkRenderPassBeginInfo-renderPass-00904"
This reverts commit 8c75960e034a09bad67ece528c99e202bed69b64.
Reason for revert: retry dry-run without revert
Bug: b/303441816
Original change's description:
> Revert "Suppress VUID-VkRenderPassBeginInfo-renderPass-00904"
>
> This reverts commit f8f9847771fa86589da29527c806d89e6f92c7a9.
> As the issue is no longer reproducible on a P25 device with
> latest ANGLE.
>
> Bug: b/303441816
> Change-Id: Iae86b3f4e30609cd5b1aedb4293192b06be71919
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6614157
> Commit-Queue: Xiang Wang <xwxw@google.com>
> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Bug: b/303441816
Change-Id: Ib447a5af33bd17f891a8db99766fc8f275162a6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6614164
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Xiang Wang <xwxw@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
d8c00a9d
|
2025-06-03T07:39:44
|
|
Revert "Increase linux-asan-test timeout"
This reverts commit b709754166bfb7dd9a8f936800b9fac10f327023.
Reason for revert: culprit reverted
Bug: angleproject:421425259
Original change's description:
> Increase linux-asan-test timeout
>
> Slow compile after crrev.com/c/6596941.
>
> Bug: angleproject:421425259
> Change-Id: I58d8cf0981c53ddb368860e0f94da1b158756947
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6611580
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Bug: angleproject:421425259
No-Try: true
Change-Id: I7086ea907c94b221fdc0556512024d3c0fb3e97b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6617900
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
0c8da5fc
|
2025-06-03T07:06:39
|
|
Roll Chromium from 055e258e91fc to 0b76caa6045f (4644 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/055e258e91fc..0b76caa6045f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/69dc3b19a1..9d1a4700d6
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cd169314af..176c77f623
* buildtools/linux64: git_revision:ebc8f16ca7b0d36a3e532ee90896f9eb48e5423b..git_revision:a84e399f9999003472192286abc03d752c9cb1f0
* buildtools/mac: git_revision:ebc8f16ca7b0d36a3e532ee90896f9eb48e5423b..git_revision:a84e399f9999003472192286abc03d752c9cb1f0
* buildtools/reclient: re_client_version:0.178.0.5ee9d3e8-gomaip..re_client_version:0.179.0.28341fc7-gomaip
* buildtools/win: git_revision:ebc8f16ca7b0d36a3e532ee90896f9eb48e5423b..git_revision:a84e399f9999003472192286abc03d752c9cb1f0
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/6a20ae4677..3273e1952b
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2401283880..f457992f2e
* third_party/android_build_tools/error_prone/cipd: 2jzgic7at7ZxQds7qXCsmkfC4bO7d3qnWU5Q7SFUiJwC..d635j0CoYfvepgbzkY8HflRSqwy4iELc08Rp569cJgkC
* third_party/android_build_tools/lint/cipd: PaYB6553MH9GJfamUZLduJESRbN13Clv2N2beHR6IQAC..xY4TOq8o-UL3ddPKL_Md8HxqA-8zygxI2qe4TOy99UwC
* third_party/android_build_tools/manifest_merger/cipd: 0L0N3_u2ypIxEEtf0k_l36g_2CykW2BNuZBXm-v5qAUC..08J0vF1HTJjf04BVy5fG5CWz9mJamI6-WLN9zSX7ZwEC
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/4333e5ba90..c35f24154b
* third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/20cf331dc7..67418b87fc
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/938fc9953b..7a3de773a3
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f73c587323..57dfc366b7
* third_party/fuchsia-sdk/sdk: version:28.20250515.3.1..version:28.20250528.4.1
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a01c02c9d4..536618d78c
* third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9810fb23f6..aca8664738
* third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/8575f4ae4f..e3eb847e51
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/9c3ae3120f..81a117beb4
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d30c1f18b8..345a48f432
* third_party/r8/cipd: QhYGRVpYYKZmt3f_Zb2HoJ9LIBEnWaeeLXRNei47Z30C..92cfx3PA_Av-Zy3T2B_Whp1BtsuG_yeS_4HfsZra62IC
* third_party/r8/d8/cipd: QhYGRVpYYKZmt3f_Zb2HoJ9LIBEnWaeeLXRNei47Z30C..i5l_yPIc-ZuKle_ibElGMSf50XN8buMgspBkoObkkRAC
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/b7156762f0..483563e40f
* third_party/siso/cipd: git_revision:d9393c2115244b6e4a797189055e4a2b6769a64d..git_revision:963177240b1a36697c9762856f51ad36ab545ceb
* third_party/turbine/cipd: VGtOG2ivl1SJR7Lai5FQddIu15mWCYDnp47QtozMQeoC..npJIrAZr4-2wb6qWV0r2oeWQd-Q1wiMGAAi8Up15SkQC
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e8ff3f3555..470d3a2ee4
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/61859fe79e..9663e533dd
* tools/luci-go: git_revision:45d1c0a0168f06a2bbde9eca9a03087ed1da523e..git_revision:963177240b1a36697c9762856f51ad36ab545ceb
* tools/luci-go: git_revision:45d1c0a0168f06a2bbde9eca9a03087ed1da523e..git_revision:963177240b1a36697c9762856f51ad36ab545ceb
* tools/luci-go: git_revision:45d1c0a0168f06a2bbde9eca9a03087ed1da523e..git_revision:963177240b1a36697c9762856f51ad36ab545ceb
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ddbe6fbaf9..4da90bcf9c
* tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/d88ef9e4de..11d67ba328
* tools/skia_goldctl/linux: bTGNxI6oWidGO0rn_gOIbBQco8hNmWt0yS6ARBqSjlsC..tuzeYVGxTKob1ipSmtH0hGunYFgqsvIk3fi6LKfo-JUC
* tools/skia_goldctl/mac_amd64: uq36HPTxtJXcSA6VRu488Anq19CjDz64IikQoKeegjIC..9WP08e9kVtdiE5A8xbucFZLJbVhEaWpy6lPHloEq28IC
* tools/skia_goldctl/mac_arm64: BpQkTzfhHyLozwZTFhy8nvc_t9VRDDXcaqdjQLA56bcC..GmbmM4D9tFMSiRmMyhJC2m8Qn9ALIaSjqE23bxg300AC
* tools/skia_goldctl/win: Qp03cZtVqA0CskUhi8g8_bciB5Nz1CHp4lpn0cprJWgC..fqCHxyWS11f2OKiSL4CdTjHjEZx0Bm1PvJ3KDHjgf_0C
No update to Clang.
Bug: angleproject:413078308,angleproject:420743402
Tbr: yuxinhu@google.com
Change-Id: I92737683d509d9ececba43ee826f6aa28c07a668
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6615259
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
af6313f5
|
2025-06-02T10:31:27
|
|
Check redundant statements for comma op in MSL translator.
Bug: angleproject:421891565
Change-Id: I0475476f360f103a3da4df263dae9c604a8bfef5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6610091
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
ac596fd8
|
2025-06-03T03:50:01
|
|
Revert "Tests: Add Aquarium trace"
This reverts commit 537d40dcac601e051e9954ed8b08cafd2cc55ff0.
Reason for revert: increases linux-asan-test compile time by 2 hours
Bug: b/420699380
Original change's description:
> Tests: Add Aquarium trace
>
> Test: angle_trace_tests --gtest_filter="*aquarium*"
> Bug: b/420699380
> Change-Id: I30e0b0cbf2520b98dc265a6686e81cc3280f5555
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594253
> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Bug: b/420699380, angleproject:421425259
Change-Id: I2931dec718e603c4e7903cfaa268ef1fb7aa3370
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6617080
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
8c75960e
|
2025-05-30T16:06:54
|
|
Revert "Suppress VUID-VkRenderPassBeginInfo-renderPass-00904"
This reverts commit f8f9847771fa86589da29527c806d89e6f92c7a9.
As the issue is no longer reproducible on a P25 device with
latest ANGLE.
Bug: b/303441816
Change-Id: Iae86b3f4e30609cd5b1aedb4293192b06be71919
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6614157
Commit-Queue: Xiang Wang <xwxw@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
7644c9db
|
2025-06-02T11:44:38
|
|
test: Remove EGLSingleBufferTest.VerifyMutableRenderBufferKHR
The test is enforcing that specifying/querying EGL_SINGLE_BUFFER
requires the extension EGL_KHR_mutable_render_buffer. However,
EGL_RENDER_BUFFER/EGL_SINGLE_BUFFER were introduced in EGL 1.4,
removing any extension requirements for devices that support EGL 1.4+.
3.5 Rendering Surfaces
3.5.1 Creating On-Screen Rendering Surfaces
...
EGL_RENDER_BUFFER specifies which buffer should be used by default for
client API rendering to the window, as described in section 2.2.2. If
its value is EGL_SINGLE_BUFFER, then client APIs should render
directly into the visible window. If its value is EGL_BACK_BUFFER,
then all client APIs should render into the back buffer. The default
value of EGL_RENDER_BUFFER is EGL_BACK_- BUFFER
The extension itself requires a minimum of EGL 1.2, meaning only
versions 1.2 and 1.3 require EGL_KHR_mutable_render_buffer to use
EGL_SINGLE_BUFFER.
Remove the test since it doesn't gives us any information anymore since
we always expose EGL 1.5 anyway.
Bug: b/417459061
Change-Id: I060e196600e6ece6179a164d9125a8b98c0d8498
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6613123
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b7097541
|
2025-06-02T17:52:30
|
|
Increase linux-asan-test timeout
Slow compile after crrev.com/c/6596941.
Bug: angleproject:421425259
Change-Id: I58d8cf0981c53ddb368860e0f94da1b158756947
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6611580
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
8644b18c
|
2025-06-02T08:01:40
|
|
Roll VK-GL-CTS from 7be6d4540af2 to 2231585b0204 (10 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7be6d4540af2..2231585b0204
2025-05-30 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12
into vk-gl-cts/main
2025-05-30 rgarcia@igalia.com Add tess test to reproduce RADV sync issue
2025-05-30 ziga@lunarg.com Test not setting depthWriteEnable
2025-05-30 rgarcia@igalia.com Test multiple vertices with constant
outputs per mesh shader instance
2025-05-30 ziga@lunarg.com Fix image layout in dynamic state tests
2025-05-30 piotr.byszewski@mobica.com Extend interface matching tests
2025-05-30 piotr.byszewski@mobica.com Fix
create_device_queue2_all_combinations test
2025-05-30 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2
into vk-gl-cts/vulkan-cts-1.4.3
2025-05-30 lorenzo@khronosgroup.org Add video fetching instructions to
the Vulkan README
2025-05-27 lorenzo@khronosgroup.org Allow conformance version Vulkan CTS
1.4.3.0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: yuxinhu@google.com
Change-Id: Ie30395de05164532d7c32f00e47ff20627825ee8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6609031
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
bb518ce1
|
2025-06-02T12:59:00
|
|
Stop ANGLE Mac NVIDIA testing.
MacBookPro11,3 machines support only up to macOS 11,
which is no longer supported by Chromium.
Bug: chromium:420724818
Change-Id: I55b9e26a7770027df6b5182af31b371666dd94bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6611578
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
b1359277
|
2025-05-14T22:53:36
|
|
Declare lavapipe device type
Fixes 'Unknown GPU architecture' warning when using
lavapipe driver with guest side ANGLE enabled on the
emulators. Also treats lavapipe similar to swiftshader
for test coverage purposes.
Bug: b/417791087
Test: run goldfish emulator with '-gpu lavapipe'
Change-Id: I40002ce191aa49f08d887c066321c4d0c27f2738
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6547537
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
f000acf8
|
2025-05-28T12:37:20
|
|
Vulkan: Remove suppressed VVL errors that no longer applies on bots
All the devices on bots support VK_ATTACHMENT_STORE_OP_NONE.
To pass the bot, we no longer need to suppress the VVL errors that
only occur on devices where VK_ATTACHMENT_STORE_OP_NONE is not
supported. Remove the error messages from the suppression list.
Bug: angleproject:42264496
Bug: angleproject:42265159
Change-Id: I47bfcb6cff77ae68b1755e8e0105411f31f713e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6598217
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
ef29d42e
|
2025-05-22T15:52:49
|
|
Support ASTC decode mode extensions in ANGLE
Added support for GL_EXT_texture_compression_astc_decode_mode and
GL_EXT_texture_compression_astc_decode_mode_rgb9e5 in ANGLE. Also added
corresponding end-to-end tests for ASTC decode mode queries, including
ASTC decode mode queries and rendering with ASTC texture formats with
different decode modes on GL_TEXTURE_2D works.
Bug: angleproject:419403188
Change-Id: I0f2dced8468c4e25597740d1de346b2f699bb81e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6575285
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
65b25882
|
2025-05-30T10:01:43
|
|
Roll vulkan-deps from 58febb14bdad to 84aa8fdf32d0 (9 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/58febb14bdad..84aa8fdf32d0
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/da48bb20bdfc8a214d5bffdacca2d1d2ae849009..a9d7fde99e73a619bbdda648473eff5895ead273
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/99e5ce205de87dc2485e1ffc7fbd5bc9604f7c89..e2d41fdd5ac2b0138112b61bd6eed0e0bb0ea693
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: Ie8598870c94819f32364c406675a1c82d6b3c6c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6606860
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
20b08f95
|
2025-05-29T10:14:33
|
|
Roll VK-GL-CTS from c9d2e24d1a6d to 7be6d4540af2 (27 revisions)
* Added gl4cTextureBufferTests files to deqp.gni.
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c9d2e24d1a6d..7be6d4540af2
2025-05-26 rgarcia@igalia.com Test vkGetPhysicalDeviceFormatProperties2
pNext chain
2025-05-26 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2
into vk-gl-cts/main
2025-05-26 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.12
into vk-gl-cts/main
2025-05-23 kamil.goras@mobica.com Add test texture buffer size clamping
2025-05-23 piotr.byszewski@mobica.com Tests null FS with cull distance
and sample mask
2025-05-23 piotr.byszewski@mobica.com Use bad
VkPipelineRenderingCreateInfo when it is not needed in GPL
2025-05-23 boris.zanin@amd.com Verify stride is non-constant value in
OpCooperativeMatrixStore/Load
2025-05-23 petermcneeley@google.com Amber tests for NClamp spir-v
extended instruction
2025-05-23 david.rosca@amd.com Fix film grain flag for
dEQP-VK.video.decode.av1.argon_filmgrain_10_test1019_*_dpb
2025-05-23 ziga@lunarg.com Fix enabling extensions in swapchain
maintenance1 tests
2025-05-23 lionel.g.landwerlin@intel.com Fix default SampleMask value in
VK_EXT_shader_object tests
2025-05-23 mateusz.bahyrycz@mobica.com Fix for missing synchronization
in BufferViewTestInstance
2025-05-23 piotr.byszewski@mobica.com Port selected tests to new
capabilities system
2025-05-23 michal.jakubek@mobica.com Reduce createCustomInstance()
calls.
2025-05-23 michal.jakubek@mobica.com Capabilities system for custom
device creation
2025-05-23 rgarcia@igalia.com Test multistream rasterization with XFB
2025-05-23 rgarcia@igalia.com Test image-to-image copies for 96-bit
formats with linear tiling
2025-05-23 rgarcia@igalia.com More DGC conditional rendering tests
related to preprocessing
2025-05-23 rgarcia@igalia.com Test sampling
VK_FORMAT_A1R5G5B5_UNORM_PACK16
2025-05-23 rgarcia@igalia.com Add tests with additional commands on
secondary command buffers
2025-05-23 rgarcia@igalia.com Fix verification thresholds in sampling
tests for small formats
2025-05-23 rgarcia@igalia.com Test copying immutable samplers
2025-05-23 rgarcia@igalia.com Add ldexp tests with non-32-bit exponents
2025-05-23 rgarcia@igalia.com Add XFB tests with primitive restart
2025-05-23 rgarcia@igalia.com Test arbitrary matching queue family
values in barriers
2025-05-23 rgarcia@igalia.com Test geometry shader side effects always
happen
2025-05-23 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2
into vk-gl-cts/main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:420728429
Tbr: abdolrashidi@google.com
Change-Id: Iee73fa63e10dd084a4c67bcae7ab1779f8efdbcf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6601054
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
b670d47b
|
2025-05-29T13:37:27
|
|
Disable unused private field for dEQP compilation
Incoming VK-GL-CTS rolls are failing due to the following error
for some dEQP targets:
"private field 'm_size' is not used [-Werror,-Wunused-private-field]"
This warning can be suppressed for this target temporarily, allowing
the autoroller to merge new changes. Once the issue has been addressed
on the CTS code, this change should be reverted.
* Added -Wno-unused-private-field to gles2 and gles31 targets.
* This is a temporary change. It should be removed once the issue
has been addressed.
Bug: angleproject:420728429
Change-Id: I0177ded84ad58a148884e8abfac3aea9a1ff7d43
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6604679
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
|
|
|
58f21f8f
|
2025-05-29T07:53:02
|
|
Vulkan: Optimize ProgramExecutableVk::bindDescriptor(...)
Cache valid descriptor set indices in a bitset, this helps eliminate
branches within loops and makes for more readable code
Bug: angleproject:386749841
Change-Id: I06fbf529ceb6c8ece9313b3b5e9edd6c6b63542b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6601733
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
433906d7
|
2025-05-29T16:22:18
|
|
WebGPU: Protect against null compilation info.
compilationInfo is an optional parameter of this callback.
Bug: chromium:413078308
Change-Id: I12770c566b3daad5eaf8d6c8b66e464a85da06f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6596988
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
7ddc219f
|
2025-05-28T22:25:37
|
|
WebGPU: Handle Dawn breaking change in QueueWorkDoneCallback
Needed in order to update Dawn to match the standard webgpu.h, here:
https://dawn-review.googlesource.com/c/dawn/+/243697
Bug: chromium:414868699
Change-Id: Ib52c0e32b685ef3f9f05fe1fe549ab16e8eec610
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6600550
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
|
|
|
8dbb0997
|
2025-05-15T00:00:00
|
|
Autogen support checks for ANGLE_base_vertex_base_instance
Bug: angleproject:409484297
Change-Id: Id730b55709e27910f2908294637e17cde9a791b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6597178
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
568d810a
|
2025-05-29T10:01:49
|
|
Roll vulkan-deps from 22a10043cac0 to 58febb14bdad (8 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/22a10043cac0..58febb14bdad
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/c9aad99f9276817f18f72a4696239237c83cb775..9a46274d2ef215d3c258ed4d1863bff4514fa316
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/01021466b5e71deaac9054f56082566c782bfd51..da48bb20bdfc8a214d5bffdacca2d1d2ae849009
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/8f0b8537e97369ccc6f32507ec9295e852abcb91..99e5ce205de87dc2485e1ffc7fbd5bc9604f7c89
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I5969919eb7ddecbd29770c19597f3572ae68c125
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6600962
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
7855312a
|
2025-05-15T00:00:00
|
|
Adjust multi draw validation
* Fixed validation of negative drawcount
for all MultiDraw*ANGLE entry points.
* Added missing extension checks to
MultiDraw*BaseInstanceANGLE entry points.
Fixed: angleproject:420956723
Change-Id: I3a058471446cd96a883970d4e38ba5af2fa07a8c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6597176
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
79cef542
|
2025-05-15T00:00:00
|
|
Autogen EGL image extension entry points
Bug: angleproject:409484297
Change-Id: I0e4a83c5e902f010a66fefa4fa6cc4169ab5529f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6596617
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e7118451
|
2025-04-15T09:55:48
|
|
restricted_trace_perf: Script fixes
Minor fixes.
Tests: restricted_trace_perf
Bug: b/404239853
Change-Id: I429f2c69c47bd9a8dc725ac3f499143827755de6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6455541
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
d5d76108
|
2025-05-15T00:00:00
|
|
Do not define GL_GLEXT_VERSION in gl2ext.h
Bug: angleproject:409484297
Change-Id: I2d71a4e923207f4d7ed410f8c4770aee9aff9d19
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6597675
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
4c964bc7
|
2025-05-15T00:00:00
|
|
Roll third_party/OpenGL-Registry/src/ 5bae8738b..200cea403 (74 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/OpenGL-Registry/+log/5bae8738b23d..200cea4030cb
Additional changes:
* Removed obsolete workarounds for mismatching
signatures between CreateShaderProgramvEXT
and CreateShaderProgramv.
* Aligned GL backend bindings for GL_OVR_multiview
entry points with the specs.
* Updated include/GLES2/gl2ext.h.
Bug: angleproject:409484297
Change-Id: Ifbb63dcc4bad312b22a368455a121e088b346fab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6596941
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
537d40dc
|
2025-05-27T12:43:55
|
|
Tests: Add Aquarium trace
Test: angle_trace_tests --gtest_filter="*aquarium*"
Bug: b/420699380
Change-Id: I30e0b0cbf2520b98dc265a6686e81cc3280f5555
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594253
Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
e67f4123
|
2025-05-28T10:01:19
|
|
Roll vulkan-deps from d18d20e2f8cd to 22a10043cac0 (8 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/d18d20e2f8cd..22a10043cac0
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/640f35dd85d25122371fa99b8788d944b71bc5e8..4841ea0a48c4ea07e9f24db3322f31541a25a101
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b75f27bc902ea48c1758d958222c742ecccf3aa2..8f0b8537e97369ccc6f32507ec9295e852abcb91
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: Icf05d2d4077cc0d1fb0fe626fd63b5ca61ed7f20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6593998
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
6462880b
|
2025-05-15T00:00:00
|
|
Autogen support checks for query extensions
Bug: angleproject:409484297
Change-Id: I91e6b7318c62868e65d48ceb380b7c2d53c447ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6596569
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
392dc591
|
2025-05-15T00:00:00
|
|
Remove GL_CHROMIUM_sync_query
Fixed: angleproject:420627279
Change-Id: I26dac7c55a7cf6b04121658144e1387be65d2569
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6593552
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
88f1a668
|
2025-05-20T10:35:36
|
|
Query sample count by getting image format props
ANGLE should query the image format properties to set
TextureCaps.sampleCounts based on internalformats.
Bug: angleproject:418815176
Change-Id: I7718121008acd9bb9bbb9964af5842646d7a689a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6564528
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Robic Sun <Robic.Sun@arm.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
2642ee46
|
2025-05-27T17:39:06
|
|
Add downstream to watch ANGLE feature changes
Bug: b/417527313
Change-Id: Idb36f7bac0c25391752a35cf5ed2ad99e6a6a636
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594071
Auto-Submit: Kaiyi Li <kaiyili@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
bc2c85a6
|
2025-05-27T11:40:33
|
|
Translator: Set correct qualifiers on user-declared gl_PerVertex
Bug: angleproject:409439499
Change-Id: Ia4bc1335d977f2b138af877e5d698914b182ff52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6592612
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
90668ecf
|
2025-05-25T10:51:52
|
|
Vulkan: Reset uniform buffer dirty bit on program change
When a program changes all of its non-texture shader resources are
invalidated, there is no need to re-invalidate uniform buffers.
Bug: angleproject:386749841
Change-Id: I7e941784c40046cef3a2ce297e6941a963b3a8dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6583476
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
eafcbbf9
|
2025-05-27T11:24:17
|
|
Vulkan: Reformat VVL error message
Remove the VVL skip messages that no longer apply.
Set the messageContents1 and messageContents2 to nullptr for ease of
clean up later.
Bug: angleproject:399191283
Change-Id: I6d4477a6c401e6b7d2915b1fc574413be31fdc9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594251
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
|
|
|
6542fea9
|
2025-05-07T17:28:45
|
|
Vulkan: Fix SpirV Error in Tessellation Control Shader
When feature varyingsRequireMatchingPrecisionInSpirv is enabled,
in the generated SpirV, if the shader output varying precision
needs to be adjusted, we create a new shader varying to replace the
original shader output varying, and save the original shader output
varying to the replacement shader output varying at the end of the
function. However, this does not work for tessellation control shader,
because the SpirV generated will perform following equivalent peudo
code:
layout (vertices=3) out;
in mediump float tc_in[];
out mediump float tc_out[];
highp float original_out[];
void main()
{
original_out[gl_InvocationID] = tc_in[gl_InvocationID];
// some other code in between
tc_out = original_out;
}
The last line will attempt to write to all indice of tc_out. However,
according to the spec, "each tessellation control shader invocation may
write only to those outputs corresponding to its output patch vertex.
Tessellation control shader must use the special variable
gl_InvocationID as the vertex number index when writing to per-vertex
output variables."
This change fixes the problem by keeping the precision of tessellation
control shader output as it is, and adjust the precision of
tessellation evaluation shader input instead.
Bug: b/42266751
Change-Id: I398545e2cbbf703c716d6738f1ba278baac4171f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6521225
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
27a1b2c9
|
2025-03-13T09:10:54
|
|
Metal: Fix crash with 3d tex, alpha, depth
Fix a crash when generating mipmaps for a 3d texture that has
mipmaps with w,h == 1, i.e. depth > max(2*w, 2*h).
Bug: angleproject:419755713
Change-Id: I7bf7f1f71c03b2bf6f8a30df30dc77ad06d433fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580167
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
dac0ef51
|
2025-05-27T18:36:56
|
|
WebGPU: Add a feature to avoid wgpuInstanceWaitAny
Synchronous waiting is not available in Chrome's renderer process yet.
Add a temporary feature to avoid some WaitAny calls and just log errors
instead.
Bug: angleproject:413078308
Change-Id: I67e54dfcfc093fd250da8cc616c05d44b78c8d64
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6593531
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
101cf210
|
2025-05-15T16:40:43
|
|
roll rapidjson src to Android
See b/279980674#comment52 for more details.
Test: presubmit, and tested the rolling to Android in https://googleplex-android-review.git.corp.google.com/c/platform/external/angle/+/33713920
Bug: b/279980674
Change-Id: I834317a4a81d169cb0bfa32f0e33f2b0929ce279
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6579712
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Solti Ho <solti@google.com>
|
|
|
2f6f0514
|
2025-05-22T15:59:19
|
|
Metal: Wraparound int arithmetic for add, sub
Implement wraparound int arithmetic for
int, ivec +, -, +=, -=, ++, --.
All of the added tests pass also without the changes.
Bug: angleproject:382215759
Change-Id: I7605582ab2931e63010c34fba474797f7edd19f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6578729
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
9cb64dc6
|
2025-05-27T10:01:58
|
|
Roll vulkan-deps from bf024288c340 to d18d20e2f8cd (7 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/bf024288c340..d18d20e2f8cd
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/93231001597dad1149a5d035af30eda50b9e6b6c..be4ee7d0e3bfd151bfda7b3a8e03f8c49c55ed7b
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/67b5d1d7f84660ca14951315afb4f9baa08ae138..640f35dd85d25122371fa99b8788d944b71bc5e8
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/ae56bd6e65d9faa731150e931cb35f0d895223bc..49ac28931f28bffaa3cd73dc4ad997284d574962
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/84b023ac42601ff51ea6094dc2c18ca62960b25d..b75f27bc902ea48c1758d958222c742ecccf3aa2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I7449245e3c956c836c733c8eb05c4036b4253b4b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6590199
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
2a18fdbf
|
2025-05-21T16:14:51
|
|
Fix sync issue between XFB output and UBO input
For the following scenario, where the first draw writes to the
transform feedback buffer and the second draw reads from the
same buffer as UBO, it is necessary to end the render pass
between the two draws and add a barrier.
// xfb write
glBindBufferBase(GL_TRANSFORM_FEEDBACK_BUFFER, 0, xfb);
glBeginTransformFeedback();
glDrawArrays();
glEndTransformFeedback();
// Draw with same buffer as UBO
glBindBuffer(GL_UNIFORM_BUFFER, xfb);
glDraw();
Bug: angleproject:418568423
Change-Id: Ia294d174111c6104b55762590ec26056ee759b53
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6572198
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
2802e9db
|
2025-05-26T03:01:28
|
|
Roll SwiftShader from f70c1194c173 to a8133cbb3c89 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f70c1194c173..a8133cbb3c89
2025-05-23 syoussefi@google.com Fix 3D blit's z-clamp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:419755713
Tbr: abdolrashidi@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: Id338db8529395ae750a49d18f9273c7658d2528e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6586403
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
a38ac25b
|
2025-05-26T10:01:53
|
|
Roll vulkan-deps from a4af0bcda127 to bf024288c340 (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/a4af0bcda127..bf024288c340
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/e1218d0e9ff42234a1841443176d8ed24405ee93..67b5d1d7f84660ca14951315afb4f9baa08ae138
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2cfeb90c13053a5003a8d5a2ee66fee4a0e0cdce..84b023ac42601ff51ea6094dc2c18ca62960b25d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I388ad3d49f4e103c58d168609ebed324cfeef3f8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6585112
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
7470cae4
|
2025-05-15T00:00:00
|
|
GL: Do not emulate EXT_base_instance
If a driver does not support the corresponding
commands, do not expose the extension at all,
regardless of the enabled features.
Bug: angleproject:355645824
Change-Id: Ideaae32e401c169690ca3aca6e437443a4b038f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580170
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
f0c46b2a
|
2025-05-25T10:44:23
|
|
WebGPU: Do not set autoresizingMask on the iOS Metal Layer
autoresizingMask is not a member on iOS builds. This mirrors the window
surface in the Metal backend.
Bug: angleproject:342213844
Change-Id: I8b5cfbb2b7f7af4f3284ddd7055e68e762c77883
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6584993
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
ec4d8f8e
|
2025-05-23T11:00:03
|
|
Changes to support sdk35
Set the sdkVersion to 35, which forces edge to edge mode.
Edge-to-edge mode without changes causes the ANGLE Preferences
settings page to render the title bar on top of the content.
The fix is to add an inset listener in the fragment, to adjust
the window's marginTop by the inset amount.
The preferences page that was being used had been deprecated as it used
the old ListView, so I updated it to the new way, using
PreferenceFragmentCompat which uses a RecyclerView.
This fragment change cascaded a few changes with the Activity itself,
and the theme, all of which are updated for this change
to use PreferenceFragmentCompat.
Tested: Built in the Android tree, flashed on a Pixel device.
Tested in portrait and landscape, light and dark modes.
Bug: b/403455598
Change-Id: I012b2ea2f9f0973f3e0a926a93d2c3b31daeccca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6581364
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Solti Ho <solti@google.com>
Auto-Submit: Brian Johnson <hibrian@google.com>
|
|
|
4b375fe5
|
2025-05-23T18:44:54
|
|
WebGPU: Fix NoOpErrorScope constructor.
We would always build with asserts enabled on our bots and missed that
this constructor did not match the ErrorScope constructor.
Bug: angleproject:342213844
Change-Id: Ieb73e6e1b0a0359b0ad336f14b7b9580c2ecc00b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580169
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
61e383dc
|
2025-05-23T18:41:57
|
|
WebGPU: Fix build on iOS and ChromeOS.
Make sure we return a NativeWindowSystem in all branches.
Build the Metal window surface on iOS.
Bug: chromium:419793882
Change-Id: Ic829c83b71c18df9907ef729320377d82958f6ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6580168
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
275745ff
|
2025-05-23T12:59:03
|
|
Vulkan: Fix warning about shared present mode support
An incorrect warning was issued about shared present mode being
requested without support for it, even if shared present mode was _not_
being requested.
Bug: b/412446258
Change-Id: I33f4ea9bcbd09695375010da93a68b375cfc8c8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6578819
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
525757d6
|
2025-05-22T16:32:32
|
|
Vulkan: Reformat VVL Error Message
Change the error message to use the extraProperties field.
Set the messageContents1 and messageContents2 to nullptr for ease
of clean up later.
Bug: angleproject:394598470
Change-Id: I0b7aec0b7e9a6e5206c89caae712e76db3338c4e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6581371
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
3e9a1375
|
2025-04-30T16:03:03
|
|
Fix unique object duplication warning
Clang has a `unique-object-duplication` warning that warns about objects
which are supposed to be unique (like static- or thread-local
variables), but may be accidentally duplicated across shared libraries
when they have hidden visibility.
This CL addresses instances of that warning by:
1. Ensuring that on non-windows systems, objects that need to be
exported are unconditionally given "default" visibility
2. Satisfy the compiler by marking everything as default visibility when
building a static library, since visibility only matters for shared
libraries
3. Mark functions with static or thread local variables as exported.
Bug: chromium:368047728
Change-Id: Ic60265353bf2b0af2cd1fef884bfa85038e0db02
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6502093
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
150f1242
|
2025-03-11T18:34:37
|
|
Metal: Provoking vertex conv. reads out of buffer
The provoking vertex helper would encode the addresses of index count
and primitive count variables, not their values. This would cause
the provoking vertex conversion shader to read overly many indices.
Not testable easily from the API, as the excessive read is hard to
test. Would cause context loss on the existing tests when run with
validation.
Bug: angleproject:419755715
Change-Id: Id81ecc66513c0eac1e95d11937f12d9bebb5e11e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6578202
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
157a99aa
|
2025-05-20T23:59:29
|
|
Update logic for redeclaring gl_FragDepth.
Update ParseContext logic to handle redeclaration of gl_FragDepth.
Bug: angleproject:419066563
Change-Id: I774d036922ec75ca151f1c871afc243ca09a3061
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6573532
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
571450df
|
2025-05-15T16:24:12
|
|
Depth value not clamped for clearBufferfi and clearBufferfv
Clamp depth values to [0,1] for calls to glClearBufferfi and
glClearBufferfv.
Bug: angleproject:418030862
Change-Id: I6f5393da863a17c5fd1d78f1b800df0e61d3dc60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552161
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
98a37b53
|
2025-05-23T10:01:05
|
|
Roll vulkan-deps from 39d1c1ac45e3 to a4af0bcda127 (9 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/39d1c1ac45e3..a4af0bcda127
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5cffd9a796210165631c995f9f58787ea0527eea..93231001597dad1149a5d035af30eda50b9e6b6c
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/ac9b0b4a1c587ce4a31f2380fba8dc76d5815b0d..e1218d0e9ff42234a1841443176d8ed24405ee93
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/736e415ebaa4290d21e42e370db5e933b9dff06d..01021466b5e71deaac9054f56082566c782bfd51
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/4f628210460c4df62029959cc7fb237ac75f7189..ae56bd6e65d9faa731150e931cb35f0d895223bc
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/da3df74a7982f54381b56126e7efc16b9e357df7..2cfeb90c13053a5003a8d5a2ee66fee4a0e0cdce
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: If28dda4c042d1c103a7083d597eb7baeeab7ef73
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6581469
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
c1e806de
|
2025-05-22T15:59:01
|
|
WebGPU: Allow providing an external WGPUDevice.
Update EGL_ANGLE_platform_angle_webgpu with a new parameter which allows
initializing DisplayWgpu with a pre-existing WGPUDevice. The adapter and
instance are queried from this device.
Bug: angleproject:42266898, angleproject:414827222
Change-Id: I3159ebe19750e75c5cf9aa395332f48385fdb4d9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6578196
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
|
|
|
3cf7a604
|
2025-05-17T19:39:08
|
|
WebGPU: Add extensions for importing external textures
Add EGL_ANGLE_device_webgpu which exposes the adapter and device used
by ANGLE internally.
Add EGL_ANGLE_webgpu_texture_client_buffer which allows importing
external WGPUTexture handles if they share the same device as ANGLE
(queried from EGL_ANGLE_device_webgpu).
Bug: angleproject:418022112
Change-Id: I0683d36b84a0f8e0e9b68a5ec0d3aa8b7a95152c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6553063
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
7c3cc750
|
2025-05-22T10:01:51
|
|
Roll vulkan-deps from 4f278f1c8646 to 39d1c1ac45e3 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/4f278f1c8646..39d1c1ac45e3
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d22cddc5c410f55093aa56f062a77ab963edaa63..da3df74a7982f54381b56126e7efc16b9e357df7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I6b6beb582c8b0ea891a01c958d9d7b65e60fc0e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6575758
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e76e534d
|
2025-05-22T07:05:05
|
|
Roll Chromium from 021bccde4594 to 055e258e91fc (1283 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/021bccde4594..055e258e91fc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/79fe614714..69dc3b19a1
* buildtools/linux64: git_revision:0c25d1bbde6ef17e1e6d3938011f56a00c02e457..git_revision:ebc8f16ca7b0d36a3e532ee90896f9eb48e5423b
* buildtools/mac: git_revision:0c25d1bbde6ef17e1e6d3938011f56a00c02e457..git_revision:ebc8f16ca7b0d36a3e532ee90896f9eb48e5423b
* buildtools/win: git_revision:0c25d1bbde6ef17e1e6d3938011f56a00c02e457..git_revision:ebc8f16ca7b0d36a3e532ee90896f9eb48e5423b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c25e306ec3..6a20ae4677
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ec041c7391..2401283880
* third_party/android_build_tools/error_prone/cipd: bd18Z8-1Y85m4C8xYA3z1J_VIhAaE2qRbkrBzn4_200C..2jzgic7at7ZxQds7qXCsmkfC4bO7d3qnWU5Q7SFUiJwC
* third_party/android_build_tools/lint/cipd: 7xZFl5M3w3LIJvhKsJYDQoTh5JZ3vr3I_-VWYXiGJC0C..PaYB6553MH9GJfamUZLduJESRbN13Clv2N2beHR6IQAC
* third_party/android_build_tools/manifest_merger/cipd: Ym1eWXywKFRvxsgK0yC4bFj9SwZViDqGEPb_w3mAKqMC..0L0N3_u2ypIxEEtf0k_l36g_2CykW2BNuZBXm-v5qAUC
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/56c2a30762..4333e5ba90
* third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/3ad26ca9f4..20cf331dc7
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/41104509db..938fc9953b
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/196d941610..f73c587323
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/cc4087cfb1..d30c1f18b8
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/0d8d1c842f..b7156762f0
* third_party/siso/cipd: git_revision:3753a55d0911b4ea3dd000263088f60edb8d947b..git_revision:d9393c2115244b6e4a797189055e4a2b6769a64d
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4821bf77c8..e8ff3f3555
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4e2e7b926a..61859fe79e
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/22750d081b..ddbe6fbaf9
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I69612901868e87539448e4a408a7cf1e5e64a2dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6577908
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
8d6d127a
|
2025-05-20T12:26:56
|
|
Vulkan: Avoid some loops in VertexArray::onBufferChanged
Before this CL, VertexArray::onBufferChanged() loops over
bufferBindingMask bits and calls onSubjectStateChange. In this CL,
VertexArray::onSubjectStateChange is embedded into
VertexArray::onBufferChanged(). DIRTY_BIT_ELEMENT_ARRAY_BUFFER and
DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA is re-arranged so that we can map
bufferBindingMask directly to VertexArray::mDirtyBits. This especially
useful when one buffer is bound to multiple indices in the VertexArray.
This CL also removes angle::ObserverInterface from VertexArray, since it
no longer observes anything.
ASSERT is added in gl::Buffer::mContentsObservers to ensure it only
contains BufferTexture, since vertexArray is no longer using the
subject/observer.
Bug: angleproject:400711938
Change-Id: Ie6e7159d7a89f0da5e1b7ca0a9dbe60a1e6c682f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6569638
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
26e790f7
|
2025-05-21T14:07:40
|
|
Update the gn arg to avoid warning message in gn desc json file
After this change
https://chromium-review.googlesource.com/c/chromium/src/+/6547915,
using android32_ndk_api_level and android64_ndk_api_level gn args
will results in a warning message generated at the top of the
gn desc json file:
WARNING Build argument has no effect.
android32_ndk_api_level = 26
^-
Did you mean "android_ndk_api_level"?
This causes the json.load() function in generate_android_bp.py failing
when parsing the json file
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
Update roll_aosp.sh to use the android_ndk_apk_level to remove the
warning message.
Also update the gn arg from android32_ndk_apk_level and
android64_ndk_api_level to android_ndk_apk_level in other files.
Bug: b/418837345
Change-Id: I12fa48dcb5638b37a9965d0adb339a2dee018297
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6576736
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
3f012a43
|
2025-05-14T17:11:06
|
|
Vulkan: Move VertexArray::ElementBuffer away from observer
Right now, VertexArray's element buffer is always observing buffer's
change. In previous CLs, we have moved vertex array away from
subject/observer usage. This CL moves element buffer away from
subject/observer as well. Since the gl::Buffer tracks buffer's binding
to each context's current vertex array's binding point,
kElementArrayBufferIndex is added to VertexArrayBufferBindingMask bits
so that the element buffer is tracked exactly the same as other vertex
array buffer bindings. The VerextArray code has been modified to handle
this special bit, since element buffer has its own binding point
VertexArrayState::mElementArrayBuffer as opposed to
VertexArrayState::mVertexBindings. After this CL, VertexArray object
should be completely off subject/observer usages.
Bug: angleproject:400711938
Change-Id: I662ddfabc95034bdc7734939c944ab033f41801c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552160
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
bdaf87cf
|
2025-05-15T00:00:00
|
|
Enforce validation consistency
Asserted that:
* Exactly one error is generated
if validation fails.
* No error is generated
if validation passes.
Supported only for entry points with
autogenerated context support checks.
Lockless entry points are excluded for now.
Bug: angleproject:406922380
Change-Id: I7549c8011768b1aa311d843b1658005ca3aba3b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6568559
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
1e45cbe3
|
2025-04-24T00:00:00
|
|
Update entry points autogen template
Used the same template for the always
supported entry points as for entry
points with conditional support.
No functional changes.
Bug: angleproject:409484297
Change-Id: I2077dec903a3bb52a69085acf5781c0df9ea935c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6574234
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3c0b2787
|
2025-05-17T19:36:42
|
|
WebGPU: Implement EGLImages
Implement EGLImages for WebGPU. Cube maps, and non-zero mip sources
are not supported yet.
Bug: angleproject:418022112
Change-Id: I59955aee907167a1829f870b7d0730a6269d814c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6557130
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
937cf23c
|
2025-05-13T16:11:47
|
|
Vulkan: Remove VertexArrayBufferContentsObservers
When vertex array needs to convert buffer's data, right now it uses
Subject/Observer to subscribe notifications from buffers about the data
change. Since we always dirty all binding point when we bind
VertexArray, or app has to rebind buffer to vertex array if its on the
other context, this notification really is only needed for the current
context's vertex array. In prior CLs we already moved notification from
buffer to the current context's vertex array away from Subject/Observer
usage pattern. This CL did similar things to
VertexArrayBufferContentsObservers::mContentsObservers.
VertexArrayBufferContentsObservers has been deleted in this CL. Each
VertexArrayImpl now tracks the need of content observer with a bit mask
of each bindingIndex (which is tracked by
mContentsObserverBindingsMask). When a buffer's content changes,
gl::Buffer will retrieve this bit mask from backend and pass it to the
current gl::Context, which sends to current VertexArray object, which
then set proper DATA dirty bits on VertexArray based on the binding bit
mask. If back end think it does not need any data conversion, then the
bit mask is zero and nothing will be done. This further removes
dependence on subject observer, which enables us to avoid taking shared
context lock for glEnableVertexAttribArray and
glDisableVertexAttribArray.
Bug: angleproject:400711938
Change-Id: Ieb0c09c042a560dd121242b63ec24478482399b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6549157
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
dc43c3ba
|
2025-05-17T19:28:20
|
|
WebGPU: Implement Renderbuffers
Implement the RenderbufferWgpu class. Add the concept of a non-owned
webgpu::ImageHelper for supporting EGLImage in the future.
Fix some missing texture formats that now get tested with dEQP.
Bug: angleproject:418022112
Change-Id: Ie1239ec581e62044e7c8723fc33cb7565d50575c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6557129
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
f537c6d9
|
2025-04-28T17:30:13
|
|
Allow passing a DawnProcTable to DisplayWgpu.
Bug: angleproject:42266898, angleproject:414827222
Change-Id: Ibf381461881244c9a874f2d24d3248995ea0760c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6496389
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
|
|
|
002897e9
|
2025-05-21T10:01:30
|
|
Roll vulkan-deps from 8f94220fd61f to 4f278f1c8646 (5 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/8f94220fd61f..4f278f1c8646
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/963588074b26326ff0426c8953c1235213309bdb..5cffd9a796210165631c995f9f58787ea0527eea
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/876fe5bdd694c5b1118450a35af8bc874016fce5..ac9b0b4a1c587ce4a31f2380fba8dc76d5815b0d
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/66fe610946a6d98169f8ebe9ca483f64c4009fa5..736e415ebaa4290d21e42e370db5e933b9dff06d
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/0f4bd6649d19b5df4e76381725ab6f5a2eeb9f30..c913466fdc5004584890f89ff91121bdb2ffd4ba
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I9e9f81f754bc71b2528cacda8889719c23801d6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6572900
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
70b90f22
|
2025-05-09T16:51:31
|
|
WebGPU: Use the C API only from the proc table
Define WGPU_SKIP_DECLARATIONS so that errors are generated when using
the global c or cpp functions.
The default proc table getter requires the cpp API is visible. Hide this
in a new wgpu_proc_utils so the rest of the WebGPU backend cannot see
those APIs.
Bug: angleproject:342213844
Change-Id: Ia1e9bfd25b0bb538cebeaa0efe7b9d2eeabc990d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6534317
Reviewed-by: Liza Burakova <liza@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
|
|
|
720f6bbe
|
2025-05-15T00:00:00
|
|
Fix attribute and uniform name validation
* Fixed null name error messages
to refer to correct parameters.
* BindUniformLocation
* Added name checks for null
and all reserved prefixes.
* Fixed error code for reserved prefixes.
* GetAttribLocation & GetUniformLocation
* Moved reserved prefixes check to the Context.
* Fixed and expanded tests.
Fixed: angleproject:418986804
Change-Id: I62760b3010fd38ee2e31e4ff88d9910647b329dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6568552
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
3158d638
|
2025-05-06T17:08:56
|
|
WebGPU: Store the WebGPU proc table in wrappers
Instead of relying on the global WebGPU functions, pass the proc table
to the object wrappers.
Bug: angleproject:342213844
Change-Id: I79a5e819ffac5b366fed0a159a6cef116b5e82b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6514676
Reviewed-by: Liza Burakova <liza@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
|
|
|
71b58cdc
|
2025-05-17T18:12:33
|
|
Fix feedback loop in ImageTest.SourceRenderbufferTargetTexture*
This test would make a renderbuffer as an EGLImage source and a texture
as the target. It would then try to verify the data in the texture by
sampling but the renderbuffer was currently bound to the framebuffer
creating a feedback loop.
Bug: angleproject:418022112
Change-Id: I456eb541c84d98d99e6b8d8be817ce67d7b1d519
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6556610
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
65180785
|
2025-05-20T07:59:46
|
|
Roll Chromium from a343631b79de to 021bccde4594 (658 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/a343631b79de..021bccde4594
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/4523ca62d9..79fe614714
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e9b36e9ffb..cd169314af
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/26a050e9cd..c25e306ec3
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f810dae272..196d941610
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/36e2b378de..cc4087cfb1
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/158e62527c..0d8d1c842f
* third_party/turbine/cipd: PbV7UFdzFIl6b_4lNwsj4VnlvnoULNAZRDwsndTGXTsC..VGtOG2ivl1SJR7Lai5FQddIu15mWCYDnp47QtozMQeoC
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/246a9e4b12..22750d081b
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ibf6dcdfac5c022ea3f81727ff431532f38cb4c3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6567407
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
dcbcee8a
|
2025-05-15T10:39:55
|
|
Tests: Use eglGetPlatformDisplay()
From the EGL 1.5 spec:
Appendix F
Version 1.5
EGL version 1.5 was voted out of the Khronos Technical Working Group
on January 31, 2014, and formally approved by the Khronos Board of
Promoters on March 14, 2014.
EGL 1.5 is the sixth release of EGL. It introduces the following new
features (the EGL extension(s) each feature is based on are also shown
parenthetically):
* Platform support:
– Providing a mechanism for support of multiple platforms (such as
window systems or offscreen rendering frameworks) in a single EGL
implementation at runtime (EGL_EXT_platform_base).
Many tests use eglGetPlatformDisplayEXT() which is provided by the EGL
extension EGL_EXT_platform_base. With the promotion of the
EGL_EXT_platform_base functions to core EGL in version 1.5 and ANGLE
supporting EGL 1.5 (as of at least 2019), update the calls to use
eglGetPlatformDisplay().
This is in preparation for running the ANGLE end2end tests in Android,
which only exposes the EGL 1.5 functions, and not the
EGL_EXT_platform_base functions.
Bug: b/391967165
Test: angle_end2end_tests
Change-Id: I58109c3afe270f46db952e124ee3f5c11200ca35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6552257
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
b4d39a07
|
2025-05-19T11:07:08
|
|
Reformat VVL Error Message
Tests failed in this manual roll
https://chromium-review.googlesource.com/c/angle/angle/+/5689521
no longer runs into the SYNC-HAZARD-WRITE-AFTER-WRITE VVL error.
Remove the VVL error from the skipped VVL error list.
Bug: angleproject:352094384
Change-Id: I8b0a4baebd7276fc6d42e0357a3b6f49adb0b4f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6564666
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
f91e3d46
|
2025-05-19T11:32:02
|
|
Revert "roll rapidjson src to Android"
This reverts commit 45b02ff020de99baea8c711f0cc391adda241038.
Reason for revert: Android roller is borken.
Bug: b/279980674
Original change's description:
> roll rapidjson src to Android
>
> Test: presubmit
> Bug: b/279980674
> Change-Id: Idb3ed14d337d1296cf50c66e796ae58ff9311514
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6553084
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Solti Ho <solti@google.com>
Bug: b/279980674
Change-Id: Iee11ddeaa87cfb3bad15eaed193e4d3d0c1dec3f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6565339
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Solti Ho <solti@google.com>
|
|
|
e7277deb
|
2025-05-19T11:16:56
|
|
Add test to validate eglGetPlatformDisplayEXT()
Add a test to validate eglGetPlatformDisplayEXT() returns a valid
display on devices that support the EGL extension EGL_EXT_platform_base.
Bug: b/279980674
Test: EGLDisplayTest.GetPlatformDisplayEXT/*
Change-Id: I8cbb9c3905deb960e567a07d64e6c9d590a4ae70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6565328
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
90697af1
|
2025-05-19T10:01:48
|
|
Roll vulkan-deps from 79e02d4e7a56 to 8f94220fd61f (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/79e02d4e7a56..8f94220fd61f
Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/97bb93fe4510ddbfb9e1a35c6a3052717a44713d..876fe5bdd694c5b1118450a35af8bc874016fce5
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9b1a7e7a6bc7d122b8474df155e3d498eb22d91f..66fe610946a6d98169f8ebe9ca483f64c4009fa5
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/42974927c2b34cfd29110e702fb493336e2fd711..d22cddc5c410f55093aa56f062a77ab963edaa63
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ie6160c05d462dae343f204b72323bbc2a6da9739
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6563645
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
9633d8f7
|
2025-05-19T03:01:32
|
|
Roll SwiftShader from 96085ee3c6cc to f70c1194c173 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/96085ee3c6cc..f70c1194c173
2025-05-16 swiftshader.regress@gmail.com Regres: Update test lists @
96085ee3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: Ie9b92ccf3517d08305c38e5f518cf693f7e66309
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6563644
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
94d5171e
|
2025-05-19T07:01:16
|
|
Roll Chromium from ceee7877afe5 to a343631b79de (737 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/ceee7877afe5..a343631b79de
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3cfaaa8c84..4523ca62d9
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/7ba47582ec..26a050e9cd
* third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/3ed7629c86..18bc289fc3
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b0fd19ed0e..56c2a30762
* third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/2b97b88495..3ad26ca9f4
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ffd1c50cbd..41104509db
* third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/069652e9cb..9810fb23f6
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/9aefa1cede..9c3ae3120f
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/abb422e192..158e62527c
* third_party/siso/cipd: git_revision:30ea210712239b874febcadf661f118fc2c0f6d7..git_revision:3753a55d0911b4ea3dd000263088f60edb8d947b
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/1af78910c3..60453178b6
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/2ce23e27cc..afcd61ed9a
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4abcec0a08..246a9e4b12
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I26ac2b102805fbcecd46340db1680e697c8a1cbd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6562701
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
5fd79e6a
|
2025-05-15T00:00:00
|
|
Remove unused parameter from ValidateGetVertexAttribBase
Bug: angleproject:409484297
Change-Id: I98fdfe8dbaeb6bc08a0c0a7a4a032850fcbdd37f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6558251
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
c601f0e7
|
2025-04-08T17:56:22
|
|
Add extra validation of null pointers for certain APIs
Bug: angleproject:409110245
Change-Id: I25dfdbdc52cdb0d7d2a91d773a0f3600e370f139
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6440146
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
30479104
|
2025-04-28T16:01:46
|
|
Add support for GL_EXT_texture_norm16 in glCopyImageSubDataEXT
Add the following compatible norm16 formats in EXT_copy_image:
RGBA16_EXT
RGBA16_SNORM_EXT
Bug: angleproject:412517249
Change-Id: I4939705915940dacaf3168acf1a7cc7abb0870ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6490613
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Mavis Deng <mavis.deng@arm.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
56becf05
|
2025-05-16T16:58:34
|
|
WGPU: texSubImage2D() should mark textures as dirty
TextureWgpu now observes its ImageHelper's edits to staged
subresources and notifies its observers (Texture) that it has
changed, ensuring TextureWgpu::syncState() is called before
draw if glTextSubImage2D() was called earlier.
Also ends the current render pass when flushing subresource
updates, otherwise if the texture is being used by the current
webgpu::CommandBuffer (staged render pass commands), the texture
may be updated before the staged commands are actually submitted
to the GPU.
Bug: angleproject:389145696
Change-Id: I07db566fca970e877a0d3faa3ceb02f8425c799a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6502676
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
|
|
|
e6231b0f
|
2025-05-16T10:29:46
|
|
Reformat VVL Error Message
catalyst_black trace no longer runs into the
SYNC-HAZARD-WRITE-AFTER-READ VVL error mentioned in
http://anglebug.com/42266390.
Remove the VVL error from the skipped error list.
Bug: angleproject:42266390
Change-Id: I7e3055e61632e1de42dc24233724f73beefef653
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6557942
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Auto-Submit: Yuxin Hu <yuxinhu@google.com>
|