|
3461be1a
|
2024-01-11T11:35:14
|
|
Version check usages of getPackageInfo() and of()
These were introduced in api level 33, and would crash on older devices.
Bug: b/268261262
Test: Presubmits
Change-Id: I4f0b4dbeab50508477adc1948fa1938ae576f369
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5190807
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Peiyong Lin <lpy@google.com>
|
|
250b2f68
|
2024-01-12T11:04:48
|
|
Add imports for use_resource_processor: true
Bug: b/319160342
Change-Id: If3429b2407d78747e6d6d96d11d8b895e962e13d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5192476
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
a06f5f89
|
2024-01-10T21:50:42
|
|
Android: Apply rules to global settings on boot
When we receive BOOT_COMPLETE or MY_PACKAGE_REPLACED broadcasts,
parse the rules and apply them to global settings.
Bug: b/293503000
Test: Manually built and installed on Android
Change-Id: If081f707f5acf0f22d10837177823bac59c3d4df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5191963
Reviewed-by: Peiyong Lin <lpy@google.com>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
99ca7f24
|
2024-01-11T20:49:00
|
|
Android: Add ANGLE to rules so it is non-empty
This allows tests to know when the rules parsing is
complete and global settings have been initalized.
Bug: b/293503000
Test: Manually built and installed on Android
Change-Id: Ifdb7537cf210ff36900c432394b21e183b4dac3e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5191962
Reviewed-by: Peiyong Lin <lpy@google.com>
Commit-Queue: Peiyong Lin <lpy@google.com>
Auto-Submit: Cody Northrop <cnorthrop@google.com>
|
|
fca3eb6b
|
2023-12-12T23:00:41
|
|
Refactor ANGLE settings UI.
This patch refactors the ANGLE settings UI to make sure it aligns better
with the settings global variables. This patch:
1) moves all ANGLE rule parsing logic to its own class, the parsing will
only parse the rule and store them, it currently does not set the
settings global variables;
2) removes the global enablement as it is now an option in Developer
options and that one has better guarding condition;
3) refactors the logic to query all packages in the system, instead of
constructing them with raw package name, use application name to
allow a more user-friendly UI, and also allow to toggle for system
applications.
4) adds two new entries to allow building ANGLE apk without any ANGLE
libraries;
5) adds a README.md file to document the design.
6) removes unused functions and variables and minor renames.
Bug: b/293503000
Test: manual
Change-Id: I7287935791c00040b0eacba7dce3e4df5eb4de3e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5118135
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Peiyong Lin <lpy@google.com>
|
|
|
ce7b9602
|
2023-06-13T22:44:23
|
|
Avoid clearing global settings when register receiver.
Global settings can be set by adb command and hence clearing the all
global settings values are not ideal. Previously ANGLE apk triggers a
clear when device boot is completed because we register the receiver and
immediately trigger the callback. However, that causes race condition as
our testing infra will set up the ANGLE per-application override to run
tests on top of ANGLE apk. This patch removes that trigger.
Bug: b/285594264
Test: Verify per-application override is no longer cleared
Change-Id: Ic10703b72593cee7f067570a523f668553047ae2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4611447
Reviewed-by: Solti Ho <solti@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Auto-Submit: Peiyong Lin <lpy@google.com>
|
|
|
f0848fc5
|
2023-04-11T10:17:48
|
|
Move targetSdkVersion to Android.bp and set to system_current
Also adds android:exported="true" which is required for newer SDKs.
Bug: b/275459680
Change-Id: I8ae5b67c1d3ccca867139fc1d9043308e03ffb6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4414227
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Roman Lavrov <romanl@google.com>
|
|
ec4629d6
|
2022-12-02T10:53:38
|
|
Android: set android:allowBackup="false" in manifset
This wasn't previously being set, and a partner pointed out that it
causes a security scan issue as explained in
https://stackoverflow.com/questions/12648373/what-is-androidallowbackup).
Bug: b/242671681
Change-Id: I17a0d9eec4ee7904ebb07bf934c7e2cdd8d61921
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4073982
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
89ac8a44
|
2021-05-19T10:48:40
|
|
Fix Loading ANGLE.apk in Android
The recent CL to remove the Settings GUI from the Android-built APK went
a little too far removing Java code and emptying the
AndroidManifest.xml. This resulted in ANGLE being unable to be loaded
from the APK, since ANGLE was not able to respond to the intent
android.app.action.ANGLE_FOR_ANDROID which indicates it contains ANGLE
libraries.
The AndroidManifest.xml requires various flags like
android:forceQueryable="true" so the APK can be accessed by the
framework.
The assets/ directory was removed, which contains 'a4a_rules.json' and
is required by GraphicsEnvironment. This is added back.
Bug: b/187342779
Change-Id: Ic7b758c92ed12750972c7e313729276a13f76032
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2906632
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
e815afbf
|
2020-09-07T22:09:22
|
|
First pass at increasing inclusivity
Link to the inclusivity rules
https://source.android.com/setup/contribute/respectful-code
Bug: b/162834212
Bug: chromium:1097198
Change-Id: Ied5a9e3879d72bff3f77ea6fcda9b82f30c32c2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2396737
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Trevor Black <vantablack@google.com>
|
|
|
2296e7af
|
2020-09-11T11:50:03
|
|
Android: Add forceQueryable="true" to AndroidManifest.xml
ANGLE needs to set the attribute forceQueryable="true" to the
AndroidManifest.xml to allow the Android framework to find the ANGLE
package.
Bug: angleproject:5035
Test: Manual verification
Change-Id: I5ac1c18a584b72d3384978592065853f0a9456de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2406131
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
555e11e3
|
2020-06-04T13:02:31
|
|
Add android:exported to AndroidManifest.xml
Any app that targets S+ will need to have an explicit android:exported
defined if intent filters are present for an activity/service/receiver.
Apps failing this requirement will fail to install.
While ANGLE doesn't explicitly target S, to prevent hitting this in the
future we should add android:exported to its AndroidManifest.xml since
we use several receiver intent-filters.
Bug: b/158221251
Test: CQ
Change-Id: I565c6ff5aaf25380d7e6ad2418612ab10f4c185f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2231249
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
03de11ac
|
2020-03-13T13:25:24
|
|
Add ANGLE_FOR_ANDROID_TOAST_MESSAGE to AndroidManifest.xml
The AndroidManifest.xml is missing the intent
android.app.action.ANGLE_FOR_ANDROID_TOAST_MESSAGE which causes a crash
when enabling the Toast message when an app uses ANGLE.
Bug: b:142320172
Change-Id: Iac69136fbf9ff753a3bad9e393ad62b0bf0918b5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103173
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
cf80f252
|
2020-03-12T11:33:10
|
|
Remove android:forceQueryable from the ANGLE.apk manifest
This property is not part of AOSP yet.
BUG=b:142320172
Change-Id: I73b0481872096053c6b4b709d15376d82a1a7b02
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2099421
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
27f310da
|
2020-03-11T16:07:18
|
|
Fix SearchProvider
The SearchProvider was attempting to launch ANGLE's MainActivity class
with the wrong fully qualified class name when Google's version
(com.google.android.angle) was installed on the device:
com.google.android.angle/.MainActivity
Instead, the AndroidManifest.xml and SearchProvider need to use the
fully qualified class name for com.android.angle.MainActivity since the
package name will differ between the AOSP (com.android.angle) and Google
(com.google.android.angle) versions.
Bug: b:142320172
Change-Id: Iab6883736be2a21dff64993bcaedbcc4c0cfecf8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2099443
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
14aaa1eb
|
2020-03-11T17:40:35
|
|
Refactor ANGLE target to allow GoogleANGLE to override it.
GoogleANGLE will be signed in a different part of Android so it needs to
be able to reference ANGLE's target and defaults to override certain
properties.
Update the manifests to request the needed permissions to use the
developer options.
Bug: b:142320172
Change-Id: Ia47815ab53f8de66332412efa2cc0fca3175e2cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096815
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
54bc3dab
|
2020-02-27T15:52:04
|
|
Add the ANGLE Android developer options to the ANGLE repository.
The ANGLE repository will house all the scripts needed to build
ANGLE.apk and the developer options are packaged in the APK.
BUG=angleproject:2344
Change-Id: I29090bd91a07546a1d2ccc03a6af19f45ffa3d90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079194
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|