kc3-lang/angle/scripts

scripts

Log

Author Commit Date CI Message
Cody Northrop 06aaa0c0 2023-03-05T17:40:38 Tests: Add Harry Potter: Hogwarts Mystery trace Test: angle_trace_tests --gtest_filter="*harry_potter_hogwarts_mystery*" Bug: b/271766619 Change-Id: I3efffb191b97b5fcc4d1d0626cba2127a309d157 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4311481 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 957bb8f5 2023-03-06T12:26:40 Roll VK-GL-CTS from 04e5d38379bd to 49ce61395065 (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/04e5d38379bd..49ce61395065 2023-03-06 gleese@broadcom.com Simplify descriptor_indexing test binding usage 2023-03-06 rgarcia@igalia.com Test alphaToCoverage with depth, stencil or sample mask exports 2023-03-06 rgarcia@igalia.com Test all dynamic color blend states simultaneously 2023-03-03 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2023-03-03 rgarcia@igalia.com Convert ray gen. robustness tests from NV to KHR 2023-03-03 marcin.zajac@mobica.com Acceleration structure updates 2023-03-03 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.5 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia96381d7a935a747c66bc8fcf79e7ae209491a04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4311748 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 3fed0866 2023-02-22T00:00:00 Implement EXT_texture_mirror_clamp_to_edge Support GL_MIRROR_CLAMP_TO_EDGE_EXT address mode when native support is available. Adjusted validation, sorted switch cases by target enums order. Added new TextureMirrorClampToEdge* end2end tests. Drive-by: fixed texture address computation for integer formats with GL_MIRRORED_REPEAT on D3D11. Fixed: angleproject:7968 Change-Id: Iaf29c8b4b32a7630c2a871f832d171f4bc4e2672 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4289137 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Amirali Abdolrashidi 8019f293 2023-03-01T14:43:53 Manual roll vulkan-deps from 385df753e370 to 5d7ca659e804 (62 revisions) Manual roll requested by abdolrashidi@google.com * Added "vulkan_sci.h" to the ignore list in export_targets.py to fix a presubmit error. https://chromium.googlesource.com/vulkan-deps.git/+log/385df753e370..5d7ca659e804 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/6d41bb9c55..9cdfc5a511 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/4e2fdb2567..7512345f61 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c9947cc8d5..9d71fb6764 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e8b8e06d09..a3dd2655a3 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/2015474294..3db19f3e3d * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/27c28d4b40..5bcfa1605e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a632681567..b8eae8a7c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8049 Tbr: abdolrashidi@google.com Change-Id: Ibda969b6a7db3ea8d41de8fc28c7caf5fb79ed45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4301769 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 18a1022e 2023-03-01T13:55:41 Manual roll VK-GL-CTS from c0a0038a1bed to 04e5d38379bd (12 revisions) Manual roll requested by abdolrashidi@google.com * Skipped the following test from KHR-GLES3* * shaders.negative.non_precision_qualifiers_in_struct_members https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c0a0038a1bed..04e5d38379bd 2023-02-24 anna.lesniewska@intel.com Add depth tests running on local heap with host visible memtype 2023-02-24 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main 2023-02-24 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2023-02-24 rgarcia@igalia.com Add GLES_ALLOW_DIRECT_LINK CMake option 2023-02-24 piotr.byszewski@mobica.com Test textureSize for oob lod 2023-02-24 syoussefi@google.com Tests for surface/swapchain maintenance1 2023-02-24 michal.jakubek@mobica.com Add coverage of vkGetImageMemoryRequirements2 for multiplanar formats 2023-02-24 Andrew.Fobel@amd.com Fix BufferView access tests for scaled types 2023-02-24 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.5 into vk-gl-cts/main 2023-02-22 piotr.byszewski@mobica.com Merge vk-gl-cts/dev/VK_EXT_pipeline_library_group_handles into vk-gl-cts/main 2023-02-14 ziga@lunarg.com Remove invalid new linked pipeline test with null layout 2023-02-13 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8045 Tbr: abdolrashidi@google.com Change-Id: Ie7e145113c58ede9ba718499b54b0cb32b36f268 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4301430 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov 6e58328d 2023-03-01T19:12:28 Add Mac AMD experimental bot Bug: chromium:1382149 Change-Id: I4652585abee747d4a9a738a679deefb7ae57f64f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300871 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov 024114b2 2022-12-16T11:32:30 Reland "Replace zlib from chrome by Android's zlib." Add zlib to delete_only_deps, otherwise gclient seems to choke on it https://crbug.com/skia/14155#c3 Also git add $root_add_dep instead of "$root_add_dep/*" as the latter wouldn't add deleted directories like third_party/zlib in this case. We also need zlib in unsupported_third_party_deps so that it gets deleted after gclient sync. When a file from a nested git repo was already added to the tree previously, git no longer relies on .git subdirectory detection and works as if .git wasn't there. This is a reland of commit 39f0eaf8095b303b09951ceb6ffda8254ed24c8d Original change's description: > Replace zlib from chrome by Android's zlib. > > Implements Elliott's https://r.android.com/2360448 in our codegen. The > only diffs are ordering and third_party_android_ndk_cpu_features. > We only seem to depend on cpufeatures for zlib. > > //third_party/zlib/google:compression_utils_portable is the root > dependency, so cutting it makes other zlib libs disappear from > Android.bp > > zlib_google_compression_utils_portable and libz_static > that this CL depends on were added in https://r.android.com/2359720 > > Tested by running roll_aosp.sh in Android tree and building. > third_party/zlib got deleted locally so presumably it should > get deleted by the roller > > Bug: b/262603863 > Change-Id: I2651cc21121d741526055fa2b0288d0dcfa5c62a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4111891 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Roman Lavrov <romanl@google.com> Bug: b/262603863 Change-Id: I87226e294a3e293ed5fcdeb2f0cf52f55917c1f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300169 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Alexey Knyazev a2efea13 2023-03-01T00:00:00 Add ANGLE_stencil_texturing This extension allows texturing of the stencil component of a packed depth stencil texture on OpenGL ES 3.0 contexts. Trivially exposed on backends that support OpenGL ES 3.1, which requires this feature. Adjusted the tests to check for the new extension string instead of the context version. Bug: angleproject:8051 Change-Id: I4d833acbc72e7374bde91d4c861598a0fdaf9b90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4295312 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Roman Lavrov a0736135 2023-03-01T15:17:07 Revert "Replace zlib from chrome by Android's zlib." This reverts commit 39f0eaf8095b303b09951ceb6ffda8254ed24c8d. Reason for revert: Broke roller https://crbug.com/skia/14155 Original change's description: > Replace zlib from chrome by Android's zlib. > > Implements Elliott's https://r.android.com/2360448 in our codegen. The > only diffs are ordering and third_party_android_ndk_cpu_features. > We only seem to depend on cpufeatures for zlib. > > //third_party/zlib/google:compression_utils_portable is the root > dependency, so cutting it makes other zlib libs disappear from > Android.bp > > zlib_google_compression_utils_portable and libz_static > that this CL depends on were added in https://r.android.com/2359720 > > Tested by running roll_aosp.sh in Android tree and building. > third_party/zlib got deleted locally so presumably it should > get deleted by the roller > > Bug: b/262603863 > Change-Id: I2651cc21121d741526055fa2b0288d0dcfa5c62a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4111891 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Roman Lavrov <romanl@google.com> Bug: b/262603863 Change-Id: Ie17cb5b63a2c86a7414230bf9b0e8ef16e8734bb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4298280 Commit-Queue: Roman Lavrov <romanl@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Alexey Knyazev 1ca860ac 2023-02-22T00:00:00 Add extension stubs * GL_EXT_conservative_depth * GL_EXT_depth_clamp * GL_EXT_render_snorm Bug: angleproject:8046 Bug: angleproject:8047 Bug: angleproject:8048 Change-Id: I7deb4f25f76008103c2754747db2d90be880b6ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296803 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mike Schuchardt 190a3214 2023-02-20T17:42:02 Tests: Add Arknights trace Test: angle_trace_tests --gtest_filter=TraceTest.arknights Bug: b/270523023 Change-Id: I147927e5ada7470a91d8aee540cf217fcb1e4ec1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4294655 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mike Schuchardt <mikes@lunarg.com>
Alexey Knyazev e2cf65ed 2023-02-22T00:00:00 Implement QCOM_render_shared_exponent Fixed: angleproject:8043 Change-Id: Ia76b8e4b60a640180bae77cba523142749051398 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4289140 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 39f0eaf8 2022-12-16T11:32:30 Replace zlib from chrome by Android's zlib. Implements Elliott's https://r.android.com/2360448 in our codegen. The only diffs are ordering and third_party_android_ndk_cpu_features. We only seem to depend on cpufeatures for zlib. //third_party/zlib/google:compression_utils_portable is the root dependency, so cutting it makes other zlib libs disappear from Android.bp zlib_google_compression_utils_portable and libz_static that this CL depends on were added in https://r.android.com/2359720 Tested by running roll_aosp.sh in Android tree and building. third_party/zlib got deleted locally so presumably it should get deleted by the roller Bug: b/262603863 Change-Id: I2651cc21121d741526055fa2b0288d0dcfa5c62a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4111891 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Charlie Lao 6d282d62 2023-02-08T16:51:07 Vulkan: Move retireFinishedCommands/garbageCleanup to worker thread This CL separate out the logic of mLastCompletedQueueSerial update and retireFinishedCommands and garbage clean up into different functions. At submission, previously we are always check fence and update mLastCompletedQueueSerials and calling reset on finished commands and do garbage clean up. With this CL, we only do the fence check and update mLastCompletedQueueSerials. Then it request worker thread to do the command buffer reset and garbage cleanup. We uses the CommandProcessor's thread for the reset and cleanup, since async submission path needs to handle this clean up anyway. This CL also added a new feature flag asyncCommandBufferReset and it is disabled right now. This will be enabled in the follow up CL. Bug: b/255411748 Change-Id: I6da558f8d4c962eb038e2378ccc76c464101cde2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4244823 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev a1f9b9aa 2023-02-20T00:00:00 Implement more texture border color adjustments D3D11: * Exposed EXT_texture_border_clamp extension string, to ensure that the relevant CTS tests are running. * Updated StateManager11::setSamplerState to adjust the border color based on the texture format. * Refactored ShaderConstants11::updateSamplerMetadata to correctly adjust the border color for integer formats. * Removed unused SamplerMetadata.internalFormatBits D3D9: * Updated Renderer9::setSamplerState to adjust the border color value based on the current texture format. * Added borderColorSrgb feature required for some drivers. GL: * Copy alpha value to green for A and LA legacy formats to workaround driver bugs when lumaWorkaround is not used. Tests: * Added ES 2.0 tests for texture formats that require border color adjustments. Fixed: angleproject:7969 Change-Id: I3d36cce43e76e6d5069a51865152c2250ecbb017 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4291000 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop ef6d1473 2023-02-24T08:27:33 Tests: Add Into the Dead 2 trace Test: angle_trace_tests --gtest_filter="*into_the_dead_2*" Bug: b/270605668 Change-Id: I80d1aa8058a8d970888725ca850ed934a100588b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4290021 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mike Schuchardt 13f246de 2023-02-20T17:43:57 Tests: Add Cookie Run Oven Break trace Test: angle_trace_tests --gtest_filter=TraceTest.cookie_run_oven_break Bug: b/270534812 Change-Id: I39109fc119cc82914e563b06cce912409a5c0434 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4289587 Commit-Queue: Mike Schuchardt <mikes@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Hailin Zhang 8fef41a8 2023-02-23T18:44:02 vulkan: improve EtcToBc transcoding precision. Bug: b/262352590 Change-Id: I6b127acdec28053423423f64ebc6e8561614f0ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4290347 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Hailin Zhang <hailinzhang@google.com>
Cody Northrop 9f4ebedf 2023-02-22T14:51:35 Tests: Add TMNT: Shredder's Revenge trace Test: angle_trace_tests --gtest_filter="*tmnt_shredders_revenge*" Bug: b/270426257 Change-Id: I36598eafdc37c77418e052f1539901cd6bb6aae8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4284638 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Brian Sheedy 9566011b 2023-02-23T15:01:59 Add support for permissive pixel comparison Adds support for running ANGLE pixel tests with a more permissive inexact matching algorithm. This is done by passing in --use-permissive-pixel-comparison=1 to the test runner. This is intended to reduce the amount of manual triage work required on CLs that are expected to have a larger amount of differences, such as SwiftShader rolls. On the bots, this will normally be disabled, but will be enabled if "Use-Permissive-Angle-Pixel-Comparison: True" is present as a CL footer. This footer is not yet included automatically anywhere, so there should be no functional change as a result of this CL yet. Bug: angleproject:7985 Change-Id: Ie815fac42edb2198dd4d115fc50650504df136c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4288612 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Mark Lobodzinski f8e56b0c 2023-02-23T16:29:52 Tests: Add SLAM DUNK from TV Animation trace Test: angle_trace_tests --gtest_filter=TraceTest.slam_dunk_from_tv_animation bug: b/270534814 Change-Id: I2062819c1f64c114ada23723188d8f090f57ab46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4288749 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi 3a7904e1 2023-01-25T23:56:56 Vulkan: Use VMA suballocation for images There is a maximum limit for device memory object allocation. On some platforms, there can be an error regarding too many object allocations when 4096 device memory handles have been allocated. Suballocation can help mitigate this issue. In this CL, some images will be allocated using VMA API calls, which use suballocation. * Added a new feature (useVmaForImageSuballocation). * Added VMA allocation for ImageHelper, which is used in initMemory(). * Suballocation is used for VMA image allocation. * If enabled, mVmaAllocation will be initialized in the ImageHelper object (instead of mDeviceMemory). * It is currently used for all platforms. * Minor change to the name of an arg in CreateBuffer() declaration. * Added test to make sure we can allocate at least 4096 images on supported platforms (8000 in the test). * Skipped the test "NonZeroBaseEmulatedClear" when run on Linux/Intel if this feature is enabled (due to output color mismatch). * Skipped several tests for capture/replay on Windows. Bug: b/218891184 Change-Id: Ibf80c9c8c485b301da7d23b5ba4bcbb1a8e3194f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4191202 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov 2678b830 2023-02-23T18:19:30 Reenable GLES 1.0 conformance tests on Win/Intel Hopefully blue screen and timeouts are fixed by the new driver. Bug: angleproject:7750 Change-Id: Ic84f3080aeac689fa04f4fc8fc2f7f9c582abc10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4286568 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov cba2a0d5 2023-02-16T19:48:30 Keep MemoryBarrier macro defined Macro was originally undefined in crrev.com/c/361291. Undefining it breaks UWP build with newer compilers. Keeping the macro defined doesn't affect libGLESv2 exported symbols, so it looks like there is no need to undefine it. Bug: chromium:1380553 Change-Id: I6476aa015949e5f2639160fac80db39da710bfb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4262071 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 7934094a 2023-02-22T18:07:21 Update extension data Windows Intel testing switched from HD630 to UHD630 GPU. Pixel 6 testing is no longer experimental. Bug: angleproject:6819, chromium:1349828 Change-Id: I3b156d83eba687e4834ec59f5ff41ae21664cc0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4283257 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Kimmo Kinnunen 177936ac 2023-02-18T14:51:29 Metal: disable 32-bit float filtering on iOS Update Metal format tables according to the Metal Format Tables. Disables OES_texture_float_linear on current iOS hardware, since R*32Float filtering is not available. Fixed: angleproject:8028 Change-Id: I29603d308f1992feb62ee997b0f69f8e6d0d385e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4266915 Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Alexey Knyazev dd1cf777 2023-02-16T00:00:00 Add EXT_texture_mirror_clamp_to_edge entry points Bug: angleproject:7968 Change-Id: I04b0c5d7b5148fbaca24d77a2c8688ea7a96cb64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4262073 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Auto-Submit: Alexey Knyazev <lexa.knyazev@gmail.com>
Jeff Vigil 278b5d02 2023-02-17T10:39:40 EGL: Enable wayland types with autogen Types with "wl_" indicate wayland types, use as is. Bug: angleproject:8027 Change-Id: If3c5d062272038c3a8773796a233af2305f3ed98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4265015 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski 6f092c31 2023-02-16T08:45:18 Tests: Add star trek fleet command trace Test: angle_trace_tests --gtest_filter=TraceTest.star_trek_fleet_command bug: b/269577054 Change-Id: I2e7ae40d47b89b854a3ecbb87aba7fe8fcfdf8ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4261952 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 27d412fb 2023-02-16T11:41:46 Presubmit: relax line length rules for quotes ... and : after Roll, Reland etc Bug: angleproject:4683 Change-Id: Ibe1098402a2fd67b929a71fa74c5a1747a90fc3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4261310 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll c2e25b70 2023-02-16T07:37:06 Roll Chromium from 3043a4c048b2 to 63251d7a0997 (544 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3043a4c048b2..63 251d7a0997 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/895ab7e260..606ec055d2 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9b577d15c1..1bb36c7a92 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7492f13b0b..3e929b8e59 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/35b945871c..b77ac02dd5 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/4e37a58163..a154c73c85 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4d5c7f83a2..f4ef1e4cea * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/60eac147fe..c1aaebb624 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d55076ba29 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e2f35370f5..6b98cdcbc1 * third_party/fuchsia-sdk/sdk: version:11.20230214.2.1..version:11.20230215.0.1 * third_party/kotlin_stdlib: yDx4bgi6fy03EzeCNgTQFs5WWyqNkJtPvSN7yqqN-48C..Mg7371mEUwDQH4_z29HdWqYWVlXN6t2dXX0kIutg_SwC * third_party/r8: gZGs-pJ_-u01VOdFNxu0W7ABR3ga7mqq9cmHOTr1Jn8C.._epIZkuhmcrUw9c591kUQWELdMlpKy_Uq0KVXhpeBl8C * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4bffa240bd..132569747b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/04ff20d2f6..f15b3214d5 * tools/skia_goldctl/linux: BDKegxfQ0gfqaGT-WbahabtRyj8gWJp6jfWN5oFGoJMC..0sWTRxVF-JnbihtHIuwUrWkXaZfHnlGbgbq_iuNBbbkC * tools/skia_goldctl/mac_amd64: 9Y06tOyAr_N_xhISU9yNR0Axvf_716FzCDhko8ENOa8C..UORVay0POLHppb8dNBQEBrEfYacH2edRleKTs5BF8QMC * tools/skia_goldctl/mac_arm64: Uw-uqwC-qLDh1r5y9BDfkLm1qdFC7VTJpB19hs2SZcoC..oCnjNSVWVT02JMCAWdBovX83D7IHEFNdxpkkYUKtmtQC * tools/skia_goldctl/win: NvPeEBjkQDR-QgnFonxeGfDRWWH3ckLNXKdUg86OrYEC..4uAK564j5zJPfrjm3Ebtql0dFZWxzdr7mGbqxakRvb0C No update to Clang. Bug: angleproject:6430,angleproject:7985 Tbr: ianelliott@google.com Change-Id: I3ed6b1efbf2e517ef104ee88972247e5c07aea3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4257257 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny a52c0a6c 2023-02-06T16:01:27 Capture/Replay: Add and handle new resource type for EGLSync So far calls involving EGLSync were not tracking the actual sync objects, and this may lead to race conditions in multi-threaded and multi-context scenarios. This CL adds the type EGLSyncID and some specialized code handling of egl::Sync to distinguish EGLSync from the already existing GLSync objects in order to track them separately. Bug: angleproject:7911 Change-Id: I91b188a41069bc0620f51c55ee516d23b55bdd38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4200095 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Constantine Shablya 31d576ca 2023-02-15T00:34:07 Tests: Add SuperTuxKart trace Test: angle_trace_tests --gtest_filter=TraceTest.supertuxkart Bug: angleproject:8023 Change-Id: I9d427700a5e3badde0e66e55b24d50725c338251 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4251637 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Geoff Lang 5a77200b 2023-02-08T17:10:28 Metal: Implement parallel shader linking. Update the Metal library cache to be thread safe. Change absl::flat_hash_map back to std::unordered_map because the value types now contain a mutex which must not move. Only generate async compilation tasks for shaders that were not already compiled and in the cache. Collapse some of the link methods in ProgramMtl that only had one call site. All linking is now done in ProgramMtl::link and ProgramMtl::load. Support disabling parallel linking using the new enableParallelMtlLibraryCompilation feature. Bug: chromium:1385510 Change-Id: I71ba71a34d994066729df7e4170911f88c89de4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4234153 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Mike Schuchardt 2e70fa15 2023-02-13T23:01:51 Tests: Add Top War: Battle Game trace Test: angle_trace_tests --gtest_filter=TraceTest.top_war Bug: b/269178202 Change-Id: I4537fb99227b6a357a2d16d83da6514ecfd2a39e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4246716 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mike Schuchardt <mikes@lunarg.com>
Maksim Sisov 25e9686c 2023-02-09T11:51:24 [ios]: fix missing caps for D16_UNORM Fixes "Assert failed in updateCaps (third_party/angle/src/libANGLE/ \ Context.cpp:4368): getClientVersion() < ES_3_0 || \ formatMaxSamples >= 4" as D16_UNORM caps were missing, which resulted in GenerateTextureCapsMap skipping that format. Bug: angleproject:6597, chromium:1413715 Change-Id: I031271e2db07d129e0c383107db2080794a11da1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4236537 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Kenneth Russell ee64836f 2023-02-11T17:56:06 Revert "Metal: Optimized BufferSubData per device" This reverts commit 968041b54770af8917001d8fe9b52a881cfed0b2. Includes the following patches: git revert -n 995db1f66bcf87fc9e47d908fb2a885e810d2567 \ 9a6c90c8f802b4d107a081bfccaf4be007e7af54 \ dbd47e378582ef86db52c7379cd220cf0b2c8193 \ 369b320f92f54774879e8b8faff834fc8db0793e \ 4abae6f97586448712e2dc1cced4a678b0901d7b \ 968041b54770af8917001d8fe9b52a881cfed0b2 Several conflicts with top-of-tree were resolved during this revert. The aim is to reland this with additional code which will reduce the amount of excess buffer memory allocated, and release the resources associated with temporary buffer allocations. Bug: angleproject:7544 Change-Id: Ib7a6bc2ab1c2f23cb43112cd980106e2898c3826 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4240556 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Gregg Tavares <gman@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 54951da2 2022-12-18T17:11:33 Vulkan: Refactor extension vs core version checks Extensions are now grouped based on promotion-to-core status, and initialization code is generally cleaned up. ANGLE currently doesn't attempt to use a core version above Vulkan 1.1, as extensions are always assumed to be exposed even if promoted to core in later versions. With this change, it would be simpler to use a newer core version if ever necessary. Bug: angleproject:7959 Change-Id: Ia5fd3e06c18f7289e9e5a63af0f039a6dc89c687 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4224582 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e60b0e4e 2023-02-13T07:02:07 Roll Chromium from 5221896b4233 to 155bf9f7bac6 (660 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5221896b4233..15 5bf9f7bac6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f8016dcd09..df19a5c740 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0e64446d34..dbaf3c47d5 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/035440c707..fb27d308b0 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/e95b94b74d..f0ea28495a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/439aacf3d9..244bbf5b99 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/93d7491b2e..d3f88fee5d * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f623f723b3..384e4741b8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7947234401 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/10369890bb..e636a25853 * third_party/fuchsia-sdk/sdk: version:11.20230209.3.1..version:11.20230212.3.1 * third_party/r8: UgTC8OKm5SiqQeTkdMMHkq0jL9h_6gbpI0YTBfHWrs8C..aPfF8BYhTWRf1GioUYZMwrC8hlAaLFllM_tfppFbRBIC * tools/luci-go: git_revision:f6b5518e872364f59bb17dd5a967270b38331b84..git_revision:a4b0cf91f9d6e0436705b94b979fe070d21912b1 * tools/luci-go: git_revision:f6b5518e872364f59bb17dd5a967270b38331b84..git_revision:a4b0cf91f9d6e0436705b94b979fe070d21912b1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/419aeec3e9..91d154887d * tools/skia_goldctl/linux: B3ETgoPk2gSY8aomIHMZNixKf63RvZDpuJhnZFelSl0C..LwN7ZJrQvM8sN80_aX10MUXINMSjQBvxibNfB23TK7AC * tools/skia_goldctl/mac_amd64: NOk7u3dYnhPnUxaMRoyyCQJuMKm8zRMFGnFQEABngAoC..Qnkn88mMsJO34PYkpRIvl-NLuVRex_EErC2mae0s8-wC * tools/skia_goldctl/mac_arm64: BUhEAfs1NoEiksslNZjWOXyg_zHe-s72fTUjjN1pCLkC..zwMY6HDvacAXQ7H2YoRaJaaZvTEjFqdaP-u8jsS1yksC * tools/skia_goldctl/win: 4l2ybbWBlKkcGXEi6Z6MOOanDzH2X3JuwuKW3hlLcq8C..ZEdHm2J5ysCEG6U97Ynh99pxkjw67x7lhhhZUMiXShkC No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: If05afcc12c85f8597f3ed09bd67eacc1c795ddca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4242772 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 90ddd7c7 2023-02-10T16:47:32 Tests: Add Mini Block Craft trace Test: angle_trace_tests --gtest_filter="*mini_block_craft*" Bug: b/267795849 Change-Id: Ia6087066476992367f432d5d032f6f5542eeb2d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4241403 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov a57e36dc 2023-02-10T12:21:36 Tests: Add Durak Online trace Test: angle_trace_tests --gtest_filter="*durak_online*" Bug: b/267794160 Change-Id: Id8047921bf5c48109fd7b59e8262849571701c5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4241398 Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 70dd4433 2023-02-09T09:56:56 Roll Chromium from 22b1fa2b9cc1 to 111e2c20b468 (1179 revisions) Manually adds third_party/kotlin_stdlib DEPS based on https://chromium-review.googlesource.com/c/chromium/src/+/4226232 https://chromium.googlesource.com/chromium/src.git/+log/22b1fa2b9cc1..11 1e2c20b468 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a88dbf7fdc..ec73ae49c0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8b4b823eed..70e9f44cbc * buildtools/linux64: git_revision:84c8431f3e03cc6226c59dd49637c15ea31169a1..git_revision:edf6ef4b06b42c58292faea78498aff76bdf68ed * buildtools/mac: git_revision:84c8431f3e03cc6226c59dd49637c15ea31169a1..git_revision:edf6ef4b06b42c58292faea78498aff76bdf68ed * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/31cf778cc2..035440c707 * buildtools/win: git_revision:84c8431f3e03cc6226c59dd49637c15ea31169a1..git_revision:edf6ef4b06b42c58292faea78498aff76bdf68ed * testing: https://chromium.googlesource.com/chromium/src/testing/+log/38eb24c9f2..0e9e5db2f3 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/cd843b25b4..e51c1873aa * third_party/android_build_tools/lint: sZdG1MNQ0xJujrekhrJYNg_olHerEdSIrcRjrsfZDC4C..5BDAxjWpDzT13mci6A0GjF4jCSjYOwUQD_-z9MnRhtUC * third_party/android_build_tools/manifest_merger: 5Zw4RYBL86koJro2O-jjcZYxOOdEW-hJDYykae8efQAC..gzy9U2HI42hR8r1zspR-mPI3BQ6I3zTmJ3GojAQrvgcC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/fd77243c4e..773cfa5e8b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..37e879a7d1 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c90793139..d8fb7c9667 * third_party/fuchsia-sdk/sdk: version:11.20230202.3.1..version:11.20230208.3.1 * third_party/r8: Ned_emxwurmNCGpvlG5BpLkBfs4sQkz1GvFudutb2TAC..shk1TNQCPsWWeZyuC5uzvDQmrY2wQfPzO0E_SKCaEu0C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6e5ae687b5..98dd69cae2 * tools/luci-go: git_revision:46eca1e3a280c340bf58f967aaded13c87ca3859..git_revision:f6b5518e872364f59bb17dd5a967270b38331b84 * tools/luci-go: git_revision:46eca1e3a280c340bf58f967aaded13c87ca3859..git_revision:f6b5518e872364f59bb17dd5a967270b38331b84 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/2c56755363..e534325cbe * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/be10dc8b8c..9c5059d900 * tools/skia_goldctl/linux: 96rbK3aat75vEXP7ECt3n7am23k8o4IW1Kj2NGUovQIC..B3ETgoPk2gSY8aomIHMZNixKf63RvZDpuJhnZFelSl0C * tools/skia_goldctl/mac_amd64: FntW8cjbXgVS_GvJvQvtt-7TJNG3fIimvtTYIZk0D1oC..NOk7u3dYnhPnUxaMRoyyCQJuMKm8zRMFGnFQEABngAoC * tools/skia_goldctl/mac_arm64: NZBp40siQ-lxQNC8b1WfCOirUrl613zS5Kvaux4g0cwC..xe7SkOafMEH4PikK8N-7c1Wt2rPEVLnTG10xrBCAExYC * tools/skia_goldctl/win: ENCJikCHD8vdfDSnlM_pfnzJG4G3uRkrN2s6giSlxWcC..4l2ybbWBlKkcGXEi6Z6MOOanDzH2X3JuwuKW3hlLcq8C No update to Clang. Bug: angleproject:7828, chromium:1412135 Change-Id: Iadf717df829df0d58b8dab3791b403bc882da082 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4236309 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 4c978523 2023-02-08T13:46:01 Tests: Add Add Words Crush: Word Puzzle Game trace Test: angle_trace_tests --gtest_filter="*words_crush*" Bug: b/267795212 Change-Id: I7c5c19b4306dd9b141f8880e1b4e7948629b6a73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4233090 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 93e311f7 2023-02-07T00:00:00 Add channel info to compressed formats in angle::Format Fixed: angleproject:8011 Change-Id: I2ea08f30523c08b7ca11ee327990a110a448ca42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4232118 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi b3846714 2022-11-28T11:05:05 Vulkan: Feature to make async queue slow for testing Bug: angleproject:6746 Change-Id: I2573cae2dcf42d177168c55bc2a6d8bb012dde18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4227986 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Yuly Novikov 36a4b33c 2023-02-07T17:41:01 Remove valid_param_values.h exception from export_targets Fixed upstream Bug: chromium:1412096 Change-Id: Iedb91040a835015301e1395310eea57f4744732f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4225034 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll a12dd26c 2023-02-07T07:00:02 Roll Chromium from 20c3dc51aba5 to 22b1fa2b9cc1 (546 revisions) https://chromium.googlesource.com/chromium/src.git/+log/20c3dc51aba5..22b1fa2b9cc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d0fad16496..a88dbf7fdc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5408fe0e01..8b4b823eed * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/549781a48c..31cf778cc2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0cb236a8e6..38eb24c9f2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6488cadd2f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ef2d011ad3..2c90793139 * third_party/r8: ChcFHxz1-A0Ts6xPtVwnVK2cqjRVmQTv4QRFYJ_et80C..Ned_emxwurmNCGpvlG5BpLkBfs4sQkz1GvFudutb2TAC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/44e5e39a90..6e5ae687b5 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/984e0a33ee..2c56755363 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5f50a38e7b..be10dc8b8c No update to Clang. Bug: angleproject:7998 Tbr: jonahr@google.com Change-Id: I632c6e493d2e9eade9308c78638ef0d05fc67582 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4227632 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 3159a4da 2023-02-03T17:58:15 Add temp gn_response_file to $(genDir) directory in Android build According to https://android-review.git.corp.google.com/c/platform/external/angle/+/2420140, the Android source tree will be made read-only eventually. Move the temporary file to the $(genDir) directory. Bug: None Change-Id: I1f39c2ee52f15dba54f88a700ac9d571c3860d37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4222356 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 6bdd90a7 2023-02-02T21:36:41 Manual roll vulkan-deps from c7184adab227 to 7ab598f59574 (12 revisions) Manual roll requested by ynovikov@google.com Suppressing VUIDs: "VUID-VkAttachmentDescription2-stencilStoreOp-parameter", "VUID-VkAttachmentDescription2-storeOp-parameter", https://chromium.googlesource.com/vulkan-deps.git/+log/c7184adab227..7ab598f59574 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/58d302cfa2..7341a21b34 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/199d0cb8a9..459fa67937 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8a0fe779e5..d8759a140b * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3bc9d7c0c5..ebb932a402 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/df9d118bb1..e1940bd368 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/99b147ad63..c5d638465e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1412096 Change-Id: Ie97d47f81bfd367e18602bfae885ba487bc732e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4219865 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll 30a5b24c 2023-02-03T20:02:51 Roll VK-GL-CTS from 435efeefbc72 to a13cbc855993 (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/435efeefbc72..a13cbc855993 2023-02-03 gleese@broadcom.com Simplify test setup for descriptor indexing 2023-02-03 gleese@broadcom.com Run descriptor_indexing tests in more places 2023-02-03 slawomir.cygan@intel.com Fix dispatching to custom device 2023-02-03 rgarcia@igalia.com Add more tests for off-screen viewports 2023-02-03 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.5 to vk-gl-cts/main 2023-02-03 quic_mnetsch@quicinc.com Notice of withdrawal of Vulkan CTS 1.3.1.x If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I19fdae34e856929505553a1f179a98326a5f3986 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4219010 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 173003af 2023-02-02T13:19:57 Tests: Add Lilys Garden trace Test: angle_trace_tests --gtest_filter=TraceTest.lilys_garden bug: b/267577743 Change-Id: I5dc64293767c30a0e4f79ca5779db092d34a9998 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4219853 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang 9b00af52 2023-02-01T11:10:32 Metal: Add an in-memory MTLLibrary cache. Add a small cache for (msl + compile parameters) -> MTLLibrary at the egl::Display level. In regular executions of Chrome, the same shaders (particularly vertex) are compiled multiple times in different programs. Tested for a regular Chrome startup + open wikipedia + motionmark 1.2: 112/282 (40%) cache hits. Several different caching methods were profiled (LinkProgram perf test) - struct key with std::map : 303309 - struct key with std::unordered_map : 308090 - binary blob key with std::map : 263595 - binary blob key with std::unordered_map : 286051 - struct key + is_transparent with std::unordered_map : 304877 - struct key + is_transparent with absl::flat_hash_map : 335686 Using is_transparent allows us to search the hash map without copying the shader source string to construct the key structure. Bug: chromium:1385510 Change-Id: Ieec4ba526fe286276a4af7114d89cde32a8f9e1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4214012 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll 36199fa9 2023-02-02T19:25:12 Roll VK-GL-CTS from bbf05746bf87 to 435efeefbc72 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/bbf05746bf87..435efeefbc72 2023-01-31 marcin.zajac@mobica.com Vulkan video only for windows and linux If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I1763ad11ec8184217c17484e8e27c789dd49eab2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4219852 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 17931e23 2023-01-27T00:00:00 Fix stencil and depth/stencil data uploads Multiple changes were made to depth and stencil load functions, removing redundant code and fixing issues. Failures were caused by incorrect assumptions about component locations in combined formats. * D32_FLOAT_S8X24_UINT has the same layout as GL_FLOAT_32_UNSIGNED_INT_24_8_REV * D24_UNORM_S8_UINT has stencil data in its MSBs, while GL_UNSIGNED_INT_24_8 puts it in LSBs. Bugfixes * Added LoadD24S8ToS8D24 that swaps D24 and S8 components * Added LoadS8ToS8X24 for stencil-only uploads on D3D * Replaced LoadD24S8ToD32F with LoadD32ToD32F * Fixed D and S extraction in LoadD24S8ToD32FS8X24 * Fixed stencil load and store in LoadD32FS8X24ToS8D24 and LoadD32FS8X24ToD32FS8X24 * Fixed S8_UINT subresource updates in Vulkan * Fixed D24_UNORM_S8_UINT subresource updates from GL_FLOAT_32_UNSIGNED_INT_24_8_REV data in Vulkan Cleanup * Renamed LoadUNorm16To32F to LoadD16ToD32F * Removed LoadUNorm32To32F, replaced it with LoadD32ToD32F * Renamed LoadR32ToR24G8 to LoadD32ToX8D24 * Renamed LoadD32FS8X24ToD24S8 to LoadD32FS8X24ToS8D24 * Removed unused LoadG8R24ToR24G8 * Removed Metal-specific LoadS8D24S8ToD32FX24S8, made use of the fixed LoadD24S8ToD32FS8X24 instead * Simplifed LoadD24S8ToD32F Added Texture2DTestES3.TexImageWithStencilData. Fixed: chromium:1408004 Fixed: angleproject:5317 Change-Id: I231345353aa4a7cebe46ded8458ac80de2c59e01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4203427 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Cody Northrop 9399c508 2023-01-31T20:37:39 Tests: Add Piano Kids - Music & Songs trace Test: angle_trace_tests --gtest_filter="*piano_kids*" Bug: b/267393674 Change-Id: I77637aa04e4a38b2915f3cd3bcb224468bb6323f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4211594 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 6486b25a 2023-01-31T19:59:41 Tests: Add 2 3 4 Player Mini Games trace Test: angle_trace_tests --gtest_filter="*2_3_4_player_mini_games*" Bug: b/267390255 Change-Id: Ia3a20af6126534fb6004a46470fe40316512486c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4211592 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Cody Northrop 754c923b 2023-01-31T16:32:31 Tests: Add Callbreak trace Test: angle_trace_tests --gtest_filter="*callbreak*" Bug: b/267369413 Change-Id: I00910bf3f683eeb35e3a9c2320fb5c62a82a81ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4209863 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski e4dfdde9 2023-01-31T11:35:02 Tests: Add Age of Origins Z trace Test: angle_trace_tests --gtest_filter=TraceTest.age_of_origins_z Bug: b/267289988 Change-Id: Ic7ca3270879b83a47101e58b86bad056a002dbf6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4209853 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Chia-I Wu 155a94d7 2023-01-27T15:23:56 Vulkan: prefer D24_UNORM_X8_UINT as D32_UNORM fallback D24_UNORM_S8_UINT might need a separate plane or might not be compressible depending on gpus. Prefer D24_UNORM_X8_UINT. Test: glmark2 Bug: b/259570128 Change-Id: I8e30f8dbe35853cc9647f2452a2bde8b2c6a1e26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4201091 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Chia-I Wu <olv@google.com>
angle-autoroll e8afed5b 2023-01-30T15:49:04 Roll Chromium from fb367de4643f to 97cd4b79248f (792 revisions) https://chromium.googlesource.com/chromium/src.git/+log/fb367de4643f..97cd4b79248f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b448ad8b3f..af34606076 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4ab9691e91..c09e1e5021 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/6d5f62996f..36806aa421 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..78833e4177 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/562481d6a9..9d77ca716f * third_party/fuchsia-sdk/sdk: version:11.20230126.1.1..version:11.20230129.3.1 * third_party/r8: lhnuNLpWpWBVM6efX0iIg5i9ztfW8VKpMvkyfWCxfr0C..kTwoRbYJ0cNEX_B1XARsNkSFKf4bOHgQCEiP4afsmBUC * third_party/turbine: t0TeGgk2CZr3B0HtEqBb60BSRwVPRJm9066izhJwzz0C..YQC-btuan_DTe9V9dv_e1LxgYSWeOoDfrd-VSqzIvHkC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/44d9b490c7..2d44c51ada * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1214b4d328..527cfbb299 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/134d306e72..9bc0b44c25 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/da557f2c89..568316d425 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3c9dc38f54..cd0d8fe0b1 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I354e85da9cc2f355cfb5ca4b65df82b11d3c023b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4203171 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 4716d85e 2023-01-10T20:31:37 Tests: Add LIMBO trace Test: angle_trace_tests --gtest_filter="*limbo*" Bug: angleproject:7945 Change-Id: Ic52af324ed554d62daafc8e27c373cebd52f9bdb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4152869 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Mark Lobodzinski 60ad92e4 2023-01-27T11:53:05 Tests: Add Goddess Of Victory: Nikke trace Test: angle_trace_tests --gtest_filter=TraceTest.goddess_of_victory_nikke Bug: angleproject:7982 Change-Id: Id4b49dce6be91bdca85c493d36dec2616be3392c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4199070 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
angle-autoroll 3d182016 2023-01-27T08:30:51 Roll Chromium from 5c03f547ddf9 to fb367de4643f (549 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5c03f547ddf9..fb367de4643f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1015724d82..b448ad8b3f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/949b2864b6..4ab9691e91 * third_party/android_build_tools/manifest_merger: Oe3FpLcNFdPYOQQYUNnC4ajNSBfgmsFHDUaAimk7m6MC..5Zw4RYBL86koJro2O-jjcZYxOOdEW-hJDYykae8efQAC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..35952dc547 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/44e9bee34f..562481d6a9 * third_party/fuchsia-sdk/sdk: version:11.20230125.2.1..version:11.20230126.1.1 * third_party/r8: SCuPfdKTpEJfVbWzckpmWx125Zf3pO-4RitqcfXX-RQC..lhnuNLpWpWBVM6efX0iIg5i9ztfW8VKpMvkyfWCxfr0C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/dca2b915e2..44d9b490c7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/566877f1ff..1214b4d328 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7fb7f11041..134d306e72 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/aec5433286..3c9dc38f54 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ic7934e445a6bd3fa7b2cd4664f7ede85ff704893 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4199067 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 83150e24 2023-01-27T05:45:26 Roll vulkan-deps from a2f348c2039f to 8a9f79f08d79 (22 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a2f348c2039f..8a9f79f08d79 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/eb9b273298..ff7a11dbcb * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7f9184a5b2..96c5dac559 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/a49166a89a..9f93cbe76a * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0a2c1bece6..3948415ebb * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/80e16af0fd..50d9f72d49 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8f898553b5..6226625105 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I4a50a7c1576aa2cdc8e6683b8ac3f08c5bbf5cfc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4199063 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 1d9b8d80 2023-01-24T16:50:32 Reland "Add support for glShaderBinary" This is a reland of commit 228973e73135924ddf6116e0b63eff5a1ccbf232 with the following fixes - 1. Apply patch from Yuly to fix chromium build errors 2. Fix ShaderBinaryTest instantiation call 3. Add ShaderBinaryTest to expectations file for IOS Original change's description: > Add support for glShaderBinary > > This patch adds the following - > 1. ANGLE_shader_binary extension and GL_SHADER_BINARY_ANGLE token. > 2. Compiler support to generate shader binaries. > 3. Update compiler to use SH_SPIRV_VULKAN_OUTPUT as output type for > Vulkan translator. > 4. Support to load GL_SHADER_BINARY_ANGLE binaries. > 5. end2end tests for glShaderBinary. > > Tests: ShaderBinaryTest* > Bug: angleproject:7833 > Change-Id: I191d5ba7c4d5304696f5e743c851dc945fa57858 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4137306 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: mohan maiya <m.maiya@samsung.com> > Reviewed-by: Charlie Lao <cclao@google.com> Bug: angleproject:7833 Change-Id: I21135c52e2bae955342a99aff5631ba0e687eff1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4195852 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mike Schuchardt 6938b883 2023-01-26T13:57:00 Tests: Add Dragon Ball Z Dokkan Battle trace Test: angle_trace_tests --gtest_filter=TraceTest.dragon_ball_z_dokkan_battle Bug: angleproject:7980 Change-Id: If7a69d81d7256a90420fad65739ff61e907f5d16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4198477 Commit-Queue: Mike Schuchardt <mikes@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop bed19c47 2023-01-26T10:41:23 Tests: Add Bubble Shooter and Friends trace Test: angle_trace_tests --gtest_filter="*bubble_shooter_and_friends*" Bug: b/266823872 Change-Id: I6dfec3b3349675791e3cb7c41bed52b146cb7bee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4195848 Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev ef0fe638 2023-01-16T00:00:00 Implement EXT_polygon_offset_clamp * Added polygonOffsetClamp to the RasterizerState * Adjusted State::setPolygonOffsetParams * Added PolygonOffsetClampTest end2end tests * Added StateChangeTestES3.PolygonOffsetClamp test * Suppressed the affected dEQP test as it has a bug Capture * Updated serialized rasterizer state * Updated CaptureMidExecutionSetup OpenGL * Rely on the EXT extension defined both for desktop and ES contexts * On desktops, might as well use the ARB extension or GL 4.6 once ANGLE supports them D3D11 * Requires FL10_0 or higher * Maps to D3D11_RASTERIZER_DESC.DepthBiasClamp * Drive-by cleanup of extensions init code Vulkan * Requires depthBiasClamp physical device feature * Maps to the depthBiasClamp parameter of the vkCmdSetDepthBias command Metal * Maps to the clamp parameter of the setDepthBias command Bug: angleproject:7957 Change-Id: If6b28df4084f0a81db29f75fb434e75d394c8730 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4169945 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Sean Risser 0133b6f1 2023-01-20T16:02:27 Add GL_ARM_shader_framebuffer_fetch builtins Bug: b/242419750 Bug: angleproject:7882 Change-Id: I85582ad21e58e448b740789ec88f783c8b95ee01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4189028 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Sean Risser <srisser@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 18657894 2023-01-25T13:05:56 Add features to dump and replace shader source. dump_shader_source writes shader source strings to files named with the hash of the source and shader type. enable_shader_substitution allows subsituting the shader source with the strings contained in a file. The same file naming scheme as dump_shader_source is used so shaders can be dumped in one run, modified and subsititued in the next run. Use the ANGLE_SHADER_DUMP_PATH and debug.angle.shader_dump_path environment variables to control where files are written. If they are unspecified, write to the temp directory. Based upon Cody's CLs: https://chromium-review.googlesource.com/c/angle/angle/+/2755841 https://chromium-review.googlesource.com/c/angle/angle/+/3961670 Bug: angleproject:7760, chromium:1385510 Change-Id: I43b9827b977079b88daa794e867637f7a126b080 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4192347 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 0c9cbf39 2023-01-26T12:07:51 Revert "Add support for glShaderBinary" This reverts commit 228973e73135924ddf6116e0b63eff5a1ccbf232. Reason for revert: breaks compile on ANGLE into Chromium roll https://cr-buildbucket.appspot.com/build/8790942326644064097 https://cr-buildbucket.appspot.com/build/8790942759045412865 https://cr-buildbucket.appspot.com/build/8790942417069789217 Leaks detected on ASAN https://cr-buildbucket.appspot.com/build/8790946657703508337 Original change's description: > Add support for glShaderBinary > > This patch adds the following - > 1. ANGLE_shader_binary extension and GL_SHADER_BINARY_ANGLE token. > 2. Compiler support to generate shader binaries. > 3. Update compiler to use SH_SPIRV_VULKAN_OUTPUT as output type for > Vulkan translator. > 4. Support to load GL_SHADER_BINARY_ANGLE binaries. > 5. end2end tests for glShaderBinary. > > Tests: ShaderBinaryTest* > Bug: angleproject:7833 > Change-Id: I191d5ba7c4d5304696f5e743c851dc945fa57858 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4137306 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: mohan maiya <m.maiya@samsung.com> > Reviewed-by: Charlie Lao <cclao@google.com> Bug: angleproject:7833 Change-Id: Ice19576acbc1351810ff0cd769ac17ad6c0abdf3 No-Try: true No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4197375 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 5e43562b 2023-01-26T07:01:05 Roll Chromium from 701fadbce737 to 5c03f547ddf9 (614 revisions) https://chromium.googlesource.com/chromium/src.git/+log/701fadbce737..5c03f547ddf9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/45d09f40b1..1015724d82 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0cc02fb849..3c7e3f1b8b * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/1dfd0022c4..1127c78cf9 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/bb5988e15c..e95b94b74d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/32401180de..949b2864b6 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a920882fe7..9b5f27f99a * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/7ce1c475b8..a102d977b6 * third_party/android_build_tools/lint: 0X1mSg1M9Q3Dv6pcOnX0mK0YR_LyTxyT3oRbYk5uxQ8C..EPj7vnLteKz9kMQ6x4ZPaM5E20Bt4I0wTdrxdBpruZMC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..140797ef1f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/00be3f079a..44e9bee34f * third_party/fuchsia-sdk/sdk: version:11.20230124.2.1..version:11.20230125.2.1 * third_party/jdk: egbcSHbmF1XZQbKxp_PQiGLFWlQK65krTGqQE-Bj4j8C..-FR8HTNcMfxy7J2HUaWVa0QmEE4f68iotzvFbqOj2LEC * third_party/r8: LH65AcDi3ysVLfebZhbSxN3YUGUV62qpqLIlrV6Znm8C..SCuPfdKTpEJfVbWzckpmWx125Zf3pO-4RitqcfXX-RQC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/41fd15ae6c..566877f1ff * tools/luci-go: git_revision:36cf4b54527c49aca7ed3023995a081e14f1852a..git_revision:221383f749a2c5b8587449d3d2e4982857daa9e7 * tools/luci-go: git_revision:36cf4b54527c49aca7ed3023995a081e14f1852a..git_revision:221383f749a2c5b8587449d3d2e4982857daa9e7 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f760c9e996..7fb7f11041 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/86a7bc48ce..aec5433286 * tools/skia_goldctl/linux: bOyplOZW_1JEVFUYAKgbKGWaIlUNmN1YWkzd5HXMjbMC..PZOpm-VdLUuaVE8seo910YRCnqv7Y2BkPcrmUs13RMAC * tools/skia_goldctl/mac_amd64: AUahse3CmKx-dL05gv51smOfDW3bSRbiOmWly3oDmyQC..aZ8KYJUPYrRq4f7-Td3nt0et_16S06A0vovOn2c85tIC * tools/skia_goldctl/mac_arm64: BUfxeGjbFbRJh3xW3sHUYhB0CNMviWBhCtud4vytIrEC..JtcfJFsvsUuaaIajqvwETn8j5hxOSC_YLDszV96Ukn8C * tools/skia_goldctl/win: eBpAa_OebMnB2kWt7jt2enLuznrQvGveRaHpV1a3y1AC..qp3u_bn43vFlG3HHG61Co9eOeo52m6SWIw099mHqt9EC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Iba34e4c2b8bfe540f11d364731ab5c29a11f6a68 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4195842 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 228973e7 2023-01-24T16:50:32 Add support for glShaderBinary This patch adds the following - 1. ANGLE_shader_binary extension and GL_SHADER_BINARY_ANGLE token. 2. Compiler support to generate shader binaries. 3. Update compiler to use SH_SPIRV_VULKAN_OUTPUT as output type for Vulkan translator. 4. Support to load GL_SHADER_BINARY_ANGLE binaries. 5. end2end tests for glShaderBinary. Tests: ShaderBinaryTest* Bug: angleproject:7833 Change-Id: I191d5ba7c4d5304696f5e743c851dc945fa57858 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4137306 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Alexey Knyazev 11608a8b 2023-01-23T00:00:00 Adjust STENCIL_INDEX8 caps * Fixed a typo in GetSizedFormatInternal * Required texturing for OES_texture_stencil8 * Marked all depth/stencil formats as not blendable * Fixed frontend and GL texture caps for GL_STENCIL_INDEX8 Bug: angleproject:3231 Change-Id: Ie91e4bb4e8ab56d39dc1270487380b0bfce25b08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4194169 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kenneth Russell 660e4a7c 2023-01-20T15:42:29 Don't override D16_UNORM to D32_FLOAT on Apple GPUs. Local testing of: dEQP-GLES3.functional.polygon_offset.fixed16_render_with_units on M1 indicates that depth bias works correctly with MTLPixelFormatDepth16Unorm on this GPU type, indicating that previous workarounds only need to be applied to non-Apple GPUs. Reimplement d24s8_fallbacks_mac as depth_fallbacks_mac, add this workaround there, and move the conditions to the JSON file per review feedback from Alexey Knyazev. Avoid emitting duplicate depth formats in gen_mtl_format_table.py. Leave the iOS Simulator alone - the workaround is likely still needed there, and difficult to test. Tested via: ./out/Release/angle_deqp_gles3_tests \ --gtest_filter=\ dEQP-GLES3.functional.polygon_offset.fixed16_render_with_units \ --use-angle=metal Bug: angleproject:6597 Change-Id: I52a99b3f710bb88e1f43ed17862f6e6f2e6471ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4184943 Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Gregg Tavares <gman@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
angle-autoroll e5671e16 2023-01-24T12:34:34 Roll VK-GL-CTS from c1ebeb5013f9 to 821e153ac85a (20 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c1ebeb5013f9..821e153ac85a 2023-01-24 cturner@igalia.com Add more coverage of image copies with BC formats and mips/layers 2023-01-24 gleese@broadcom.com Simplify failure message 2023-01-24 gleese@broadcom.com Extend helper_invocation tests to cover SPIR-V 1.6 2023-01-24 rgarcia@igalia.com Make dynamic primitive restart test more reliable 2023-01-24 amber@igalia.com Add tests for compute shaders dispatched in secondary command buffers 2023-01-24 ziga@lunarg.com Test vkGetDeviceProcAddr with device that has no extensions enabled 2023-01-24 amber@igalia.com Add tests for adjusted pipeline compatibility rules. 2023-01-23 piotr.byszewski@mobica.com Merge vk-gl-ct/opengl-cts-4.6.2 into vk-gl-ct/main 2023-01-23 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main 2023-01-23 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main 2023-01-16 slawomir.cygan@intel.com Remove not needed else statement and commented code from subgroups tests code 2023-01-16 ziga@lunarg.com Add robustness tests with dynamic index on vector 2023-01-16 rgarcia@igalia.com Make unused shader stage tests pass layout when linking 2023-01-16 cturner@igalia.com Add coverage of copies from compressed mipmap textures 2023-01-16 piotr.byszewski@mobica.com Test memory access write/read bit 2023-01-16 rgarcia@igalia.com Prioritize downloaded ffmpeg over system ffmpeg 2023-01-16 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main 2023-01-16 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main 2023-01-13 ziga@lunarg.com Create linked pipeline with null layout 2023-01-09 aitor@lunarg.com Fix atomic swapcomp return value tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I4a9a79ed59e4aa561ca787e9d651008c5bb64b73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4190689 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 057997e4 2023-01-20T16:47:00 Tests: Add CSR2 Drag Racing trace Test: angle_trace_tests --gtest_filter="*csr2_drag_racing*" Bug: b/266249089 Change-Id: I61e4d44fa9ed4bfc5cce1177189d93397cc8a8ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4184944 Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Yuxin Hu 3b27647c 2023-01-20T16:32:05 Remove the temp workaround in presubmit script The newly included header files in vulkan_core.h were added in the vulkan-headers/BUILD.gn: https://github.com/KhronosGroup/Vulkan-Headers/pull/348. Removing the temp workaround added in the export_targets.py which was needed to bypass the presubmit error before the above fix was ready. Bug: b/263310519 Change-Id: I37d2c6af9b1e705a1a285f8e6d4fb23f777d4bdc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4184948 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov 77e995c0 2023-01-20T15:03:45 Tests: Add Family Island trace Bug: b/266228507 Change-Id: I077236dad048662f093f65a7702a27b09205bdd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4185155 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop 134acaba 2023-01-20T11:34:55 Tests: Add Royal Match trace Test: angle_trace_tests --gtest_filter="*royal_match*" Bug: b/266220659 Change-Id: I7fcc81611dd2a566ba9b6f7cc97ea6efdc345339 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4184935 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll d4535966 2023-01-20T10:01:36 Roll vulkan-deps from 823d1a0d7c30 to f709feae795b (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/823d1a0d7c30..f709feae795b Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/615741f278..ca8d07d0bc * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bb1c885956..c51e2afe00 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/08bfe2e226..78448eda6e * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4b705abe08..125b4f665c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/57fe3f50cd..947366e2ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I261c9aac2e41336ec0b1651dc0f6baa1626267fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4182556 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bac6516b 2023-01-20T08:27:14 Roll Chromium from b7e315063b1a to 4303e3d5e898 (531 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b7e315063b1a..4303e3d5e898 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b999a0bc63..dac013f262 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b55d9cf082..8aa310ace3 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/4fd023ec65..da69f777a0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e4385f1ba0 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/faf64f1f63..aec39c38f8 * third_party/r8: sXl5FcBjtOx9iJFm1Sh2S_Q4meUE-UtMw23EOdeQRMkC..P1d7YJypbKC2Tv6UCo5QRdo1UwIyECszSGO583AzYigC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d55fe17f21..6d7ad776de * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/40f74f7860..c3af70bb40 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ifd7b9bf3d6bf464a617ee56e3766b0cf6103c3fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4182555 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi ffbb65bc 2022-11-28T13:31:48 Vulkan: Use VK_EXT_swapchain_maintenance1 for present fences Bug: angleproject:7878 Change-Id: Ic3a43c663789a6489cff261848d9ad4a408ca53a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4088905 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
Cody Northrop d2be1163 2023-01-18T23:10:26 Tests: Add Words of Wonders trace Test: angle_trace_tests --gtest_filter="*words_of_wonders*" Bug: angleproject:7965 Change-Id: I6fa9176a1ae90a85421aed6ed5a2101155bbe87b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4179705 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Jamie Madill e960355a 2023-01-05T14:56:48 Trace Interpreter: Support DOTA underlords. Supports zero pointer parameters, which are used to indicate unwritten parameters. Bug: angleproject:7887 Change-Id: Ibee1d558567020eeeeb2ed6ac98f38cf985d87a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4140259 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2c4de3a7 2023-01-03T16:07:35 Trace Interpreter: Support Genshin Impact. Includes a couple fixes: - parsing hexidecimal values instead of enums - support sharing strings and functions between modules - support 32-bit int pointers Bug: angleproject:7887 Change-Id: I6e20a64a862c45c17ccde78a58d6069d83b31867 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4135797 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 2c582dcb 2023-01-03T10:27:03 Trace Interpreter: Support Manhattan trace. Adds the following fixes and features: - support transform feedback varying strings - support infinity and NaN constants - support for sampler and query resources Bug: angleproject:7887 Change-Id: Ib01afe66e4fda9bc77d0cb5eed52fa83a694a7d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4126885 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill f7b5d5d1 2022-12-15T10:52:07 Capture/Replay: Remove inline variable declarations. This makes parsing easier for the "simplified C" interpreter. We introduce a resource ID buffer as a way to manage a list of resource IDs to replace the inline resource lists. Turns on the Among Us trace in the interpreter tests. Bug: angleproject:7775 Change-Id: I1bb9c0e9b087965a18691bc99b2e9947610b9eaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4128719 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Dan Glastonbury bf5a007a 2022-06-16T14:21:08 Metal: Ensure render pass has at least one valid render target. Extend MTLRenderPipelineDescriptor validation to ensure that there is at least one valid render target set for the the render pipeline. This is required for certain families of metal devices to avoid a validation failure inside the metal framework. Moving the failure here will cause the app using ANGLE to return a GL error instead of crashing the process. Bug: angleproject:7436 Change-Id: I594d92492a22a61a720dbe7021843c8460b389b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4109310 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Jamie Madill fdada9ee 2022-12-13T14:52:53 Re-land: "Make SyncIDs a packed type." This re-land fixes the sync map size tracking. This prepares syncs to use a simple resource map like other types, which will make life easier in the trace interpreter. Bug: angleproject:7775 Change-Id: If2114c51d5b68503890eacbf549182823667fedc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4178012 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 63a2848a 2023-01-18T15:46:30 Roll Chromium from ff04c317b95c to 9ddfe9a47c82 (661 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ff04c317b95c..9ddfe9a47c82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/31a56c9985..68a090ea4c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a1adda97a8..d843e69371 * buildtools/clang_format/script: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git/+log/8b525d2747..f97059df7f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe20815d47..8f22bbb7f7 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/fa68f99a85..22209d660e * third_party/android_build_tools/manifest_merger: 7ZPeHZjITxCcJzrEuxb5yznF7h65-RTQrbhzILJz4_gC..Oe3FpLcNFdPYOQQYUNnC4ajNSBfgmsFHDUaAimk7m6MC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7a311fe439 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/175767738f..86cfa62b07 * third_party/fuchsia-sdk/sdk: version:11.20230112.1.1..version:11.20230114.0.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/3fab077d8c..45851774ad * third_party/r8: bs2Q_5MC61CyUsEbpowkt4tABytyCHe7eSbylw4sC3QC..sXl5FcBjtOx9iJFm1Sh2S_Q4meUE-UtMw23EOdeQRMkC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bed826478a..ad4ed8f07b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/946d9d6a48..5878fbb39f * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/1b9851b39d..30392509cf No update to Clang. Bug: angleproject:7952 Tbr: geofflang@google.com Change-Id: Ibc08d14880f4e6400f90cd4f4b7dd4ba0466b1cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4177471 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 8971a592 2023-01-18T14:35:09 Revert "Make SyncIDs a packed type." This reverts commit 9de913077a5fcc3d2f2e327b56bbe30efe2fde96. Reason for revert: Fails win-trace, somewhat flakily. Original change's description: > Make SyncIDs a packed type. > > This prepares syncs to use a simple resource map like other > types, which will make life easier in the trace interpreter. > > Bug: angleproject:7775 > Change-Id: Ic2867f6133256f5ce2320eb2b322c1059266b201 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4103720 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: angleproject:7775 Change-Id: I29534b14c973fa34a4cb7457d534cd6156f33cd2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4178010 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Jamie Madill 9de91307 2022-12-13T14:52:53 Make SyncIDs a packed type. This prepares syncs to use a simple resource map like other types, which will make life easier in the trace interpreter. Bug: angleproject:7775 Change-Id: Ic2867f6133256f5ce2320eb2b322c1059266b201 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4103720 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 82826be0 2023-01-06T11:20:14 Reland "Make ANGLE program version only dependent on data that matters" This is a reland of commit 61728827d2e5ecce685578bc54bb2c744b65fc9a Changes made on top of previous commit 1. In src/program_serialize_data_version.py, fix the script error on Windows: anglebug.com/7918. 2. In BUILD.gn, replace the 'write_file' with 'response_file_content'. See https://gn.googlesource.com/gn/+/main/docs/reference.md#var_response_file_contents 3. In scripts/generate_android.bp.py, add code to handle the special GN build flag {{response_file_name}}. The code writes the list defined in srcs (identified by $(in) in Android blueprint) into a temp file named 'gn_response_file', and replaces the {{response_file_name}} with 'gn_response_file'. Original change's description > Changes made on top of original commit > 1. Enable execution permission on python script > program_serialize_data_version.py > 2. Remove unused list in libGLESv2.gni > 3. In angle/BUILD.gn, change file path from > "relative to angle_root", to "relative to root_build_dir", > so that inside the script program_serialize_data_version.py, > we don't have to find the absolute path of the code files for > hashing. > Original change's description > > This change introduces a new variable ANGLE_PROGRAM_VERSION > > to track the version of ANGLE source files that affect shader > > program serialization/deserialization. This change include more > > source files than necessary, to serve the purpose of a conservative > > jumping off point. We will narrow down the list of files for > > ANGLE_PROGRAM_VERSION hash generation in the future. > > Add a new script program_serialize_data_version.py that will > > be triggered during the build when the related source files changed. > > The script will generate a hash and the hash size from the related > > source files. In program serialization/deserialization and cache > > key generation, we will use this hash value instead of the entire > > ANGLE git hash. When the hash value changed, we know that the > > related source files changed, and we should invalidate the program > > cache and re-generate the blob cache / program binary. > > Bug: angleproject:4981 > > Change-Id: I2fb609416738d459d3289190c232c2d797ba58e3 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4072215 > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Cody Northrop <cnorthrop@google.com> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Yuxin Hu <yuxinhu@google.com> > Bug: angleproject:4981 > Change-Id: Iaa9eb0ab33439197bc30d03064fc245ea7ef1ea8 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4113445 > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:4981 Change-Id: Ib5bba199be6d08a1e19807026df0e7b747dbc8a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4144078 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 9bd37934 2023-01-12T00:00:00 Add EXT_polygon_offset_clamp entry points Bug: angleproject:7957 Change-Id: Ida28b852b1db3e6017b6e91a9424381eb8fe29f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4169943 Auto-Submit: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7909258e 2023-01-13T12:15:01 Roll vulkan-deps from dae0d442679f to a56166d59ebd (93 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/dae0d442679f..a56166d59ebd Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/d1fc064e79..1fb2f1d789 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/a89dea3c49..38cd214007 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/34d04647d3..d13b52222c * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d87f61605b..7e8813bb4c * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/fc90b60663..6ea9413be2 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/bf28c824b8..2b1fce945e * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/dda9ae0f91..6ef427d3b9 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ee3c27451e..6c021b786a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Iad6b57a56c7b8c4825fe4e5102d1f6d64ff00e9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4163755 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Qin Jiajia e58e77f5 2022-11-10T12:49:03 Support timestamp behind flag enableTimestampQueries All timestamp queries happen in the same disjoint query in one Context11. The whole design is that we start a disjoint query in D3D11 at the first timestamp request and keep it continuously running in current context. Only end it and read it back when the user queries if there is a disjoint. We cache the frequency and assume it doesn't change. For the first timestamp, we create a temporary D3D disjoint query and end it so we have a frequency to convert the ticks to nanoseconds. This task is taken over from https://chromium-review.googlesource.com/c/angle/angle/+/3694732 Bug: angleproject:7367 Change-Id: I747c9b00e10ac58362df66332efd01a24aa395f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4021139 Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 753d59e9 2023-01-10T18:49:54 Return success when shard(s) failed. A failed shard might cause the merge script to fail, which messes up the CI UI and makes it much more difficult to find failed shards: https://crbug.com/1346781#c112 Bug: angleproject:7299 Bug: chromium:1346781 Change-Id: Ic458002c38243ae605665bac6c3cef988a6e780f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4153133 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Roman Lavrov 1f89b777 2023-01-10T15:41:30 Use third_party/depot_tools/gsutil.py instead of gsutil This also worked on Windows in my tests. Bug: angleproject:7299 Change-Id: I0cfcaa3f034f86a4adcdd21e3f296e9fe2064a4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4153012 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 2774529b 2023-01-11T07:01:35 Roll Chromium from 4efd652d78ce to e97f96fc5ed0 (480 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4efd652d78ce..e97f96fc5ed0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5f0888fc07..1343648726 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f89baaae43..fd5fea71f1 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0b0cecd0de..bbcb6e24c0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e56ae5abfa..8d9a16885e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b8bcd0ece3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2b1aa8dcab..3e7206ff0a * third_party/fuchsia-sdk/sdk: version:11.20230109.2.2..version:11.20230109.3.1 * third_party/ninja: version:2@1.8.2.chromium.3..version:2@1.11.1.chromium.6 * third_party/r8: 3VqLjArDzdJ3Rgq8SH04G_33VEV5H7Wk5KquOg8OMkUC..D2PutVU8pDpx3doRzOeykwOIyWblTZFe0gS71FgSh7YC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/fa5dc47500..2d883199ff * tools/luci-go: git_revision:bac571b5399502fa16ac48a1d3820e1117505085..git_revision:81e5cdad29bb4c7aaad98c843637513db3155b0d * tools/luci-go: git_revision:bac571b5399502fa16ac48a1d3820e1117505085..git_revision:81e5cdad29bb4c7aaad98c843637513db3155b0d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0d00eb2837..e1a49ac6a9 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/574936f02f..39cff3218d * tools/skia_goldctl/linux: E46nXQa9dcFdViDiaWhmdecJ-XgdTDLkrfaGq45UlsUC..MXsAy_bc-PnYFk9_AbS1SvOtffQOs0lxsCcuFZoQyG8C * tools/skia_goldctl/mac_amd64: rfHNzii-7hBOdsmGW8WeOM_JU0csp7fQgf-6p8cPyZYC..zuvSWGwPdHdKF8rq_ICSj7qKIEJ1ZWvtnAR5RjaabgAC * tools/skia_goldctl/mac_arm64: WMPFVGxAsM-r610JEQHRGWzuoZ72se528q3xXCHUeDAC..V0uhiO8yEQmwDNMxsrzTtOm_9Cg9ZE41OCsqGPssrNwC * tools/skia_goldctl/win: NlbXdAFIb05vtC14fXZwj8gK67uZHdlqPVPBbNhpU1QC..pQVdWoY3lHFJsI2YCM2klbYkIpYilhK7HY3HbgO7hNAC No update to Clang. Bug: angleproject:6245 Tbr: jmadill@google.com Change-Id: I67f1261325be8d189f55889076086c0f56b9a357 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4154530 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0