kc3-lang/angle/src/libANGLE/renderer/ShaderImpl.h

• Show log

  Commit

• Hash : e7ce481f
  Author :
  Date : 2023-11-01T22:44:22
  

  Consolidate parallel compilation in front-end
  
  This cleans up the multiple compilation task implementations in the
  backends and consolidates them in the front-end.  The front-end is then
  able to do the compilation in an unlocked tail call instead if
  desired (in a future change).
  
  This change is in preparation for having the program link tasks directly
  wait on the shader compilation tasks.  As a result, the "shader resolve"
  should not be needed to access the shader compilation results; it should
  be enough to wait for the compilation job.  This change therefore moves
  post-processing of results to the compilation job itself as they did not
  need to actually be done after compilation is done (merely after
  translation is done).  As a side effect, shader substition and other
  debug features should now work for the GL backend as they are now done
  before back-end compilation.
  
  Bug: angleproject:8297
  Change-Id: Ib9274b1149fadca7545956a864d6635b6cba5c3a
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4994655
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Charlie Lao <cclao@google.com>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/libANGLE/renderer/ShaderImpl.h

• //
  // Copyright 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // ShaderImpl.h: Defines the abstract rx::ShaderImpl class.
  
  #ifndef LIBANGLE_RENDERER_SHADERIMPL_H_
  #define LIBANGLE_RENDERER_SHADERIMPL_H_
  
  #include <functional>
  
  #include "common/CompiledShaderState.h"
  #include "common/WorkerThread.h"
  #include "common/angleutils.h"
  #include "libANGLE/Shader.h"
  
  namespace gl
  {
  class ShCompilerInstance;
  }  // namespace gl
  
  namespace rx
  {
  // The compile task is generally just a call to the translator.  However, different backends behave
  // differently afterwards:
  //
  // - The Vulkan backend which generates binary (i.e. SPIR-V), does nothing more
  // - The backends that generate text (HLSL and MSL), do nothing at this stage, but modify the text
  //   at link time before invoking the native compiler.  These expensive calls are handled in link
  //   sub-tasks (see LinkSubTask in ProgramImpl.h).
  // - The GL backend needs to invoke the native driver, which is problematic when done in another
  //   thread (and is avoided).
  //
  // The call to the translator can thus be done in a separate thread or without holding the share
  // group lock on all backends except GL.  On the GL backend, the translator call is done on the main
  // thread followed by a call to the native driver.  If the driver supports
  // GL_KHR_parallel_shader_compile, ANGLE still delays post-processing of the results to when
  // compilation is done (just as if it was ANGLE itself that was doing the compilation in a thread).
  class ShaderTranslateTask
  {
    public:
      virtual ~ShaderTranslateTask() = default;
      virtual bool translate(ShHandle compiler,
                             const ShCompileOptions &options,
                             const std::string &source);
      virtual void postTranslate(ShHandle compiler, const gl::CompiledShaderState &compiledState) {}
  
      // Used by the GL backend to query whether the driver is compiling in parallel internally.
      virtual bool isCompilingInternally() { return false; }
      // Used by the GL backend to finish internal compilation and return results.
      virtual angle::Result getResult(std::string &infoLog) { return angle::Result::Continue; }
  };
  
  class ShaderImpl : angle::NonCopyable
  {
    public:
      ShaderImpl(const gl::ShaderState &state) : mState(state) {}
      virtual ~ShaderImpl() {}
  
      virtual void destroy() {}
  
      virtual std::shared_ptr<ShaderTranslateTask> compile(const gl::Context *context,
                                                           ShCompileOptions *options) = 0;
  
      virtual std::string getDebugInfo() const = 0;
  
      const gl::ShaderState &getState() const { return mState; }
  
      virtual angle::Result onLabelUpdate(const gl::Context *context);
  
    protected:
      const gl::ShaderState &mState;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_SHADERIMPL_H_
  

Download