kc3-lang/angle/src/compiler/translator/IntermNodePatternMatcher.cpp

• Show log

  Commit

• Hash : 9733ceef
  Author :
  Date : 2017-05-11T19:14:35
  

  Initialize uninitialized locals in GLSL output
  
  Guarantee that local variables are initialized before they are used
  in GLSL output. In HLSL output all variables were already being
  initialized.
  
  Locals are initialized using an AST transform. The local variable init
  can only be run after some simplification of the AST, so that it is
  able to handle complex cases like:
  
  for (int i[2], j = i[0]; i[0] < 3; ++i[0]) {
  }
  
  If we're dealing with ESSL 1.00 which lacks array constructors, in
  this kind of case the uninitialized array initialization code needs to
  be hoisted out of the loop init statement, and the code also needs to
  make sure that j's initializer is run after i is initialized.
  
  Another complex case involves nameless structs. This can be an issue
  also in ESSL 3.00 and above:
  
  for (struct { float f; } s; s.f < 1.0; ++s.f) {
  }
  
  Since the struct doesn't have a name, its constructor can not be used.
  We solve this by initializing the struct members individually,
  similarly to how arrays are initialized in ESSL 1.00.
  
  Initializing local variables is disabled on Mac and Android for now.
  On Mac, invalid behavior was exposed in the WebGL 2.0 tests when
  enabling it. On Android, the dEQP test runs failed for an unknown
  reason. Bugs have been opened to resolve these issues later.
  
  BUG=angleproject:1966
  TEST=angle_end2end_tests, WebGL conformance tests
  
  Change-Id: Ic06927f5b6cc9619bc82c647ee966605cd80bab2
  Reviewed-on: https://chromium-review.googlesource.com/504728
  Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/compiler/translator/IntermNodePatternMatcher.cpp

• //
  // Copyright (c) 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // IntermNodePatternMatcher is a helper class for matching node trees to given patterns.
  // It can be used whenever the same checks for certain node structures are common to multiple AST
  // traversers.
  //
  
  #include "compiler/translator/IntermNodePatternMatcher.h"
  
  #include "compiler/translator/IntermNode.h"
  
  namespace sh
  {
  
  IntermNodePatternMatcher::IntermNodePatternMatcher(const unsigned int mask) : mMask(mask)
  {
  }
  
  // static
  bool IntermNodePatternMatcher::IsDynamicIndexingOfVectorOrMatrix(TIntermBinary *node)
  {
      return node->getOp() == EOpIndexIndirect && !node->getLeft()->isArray() &&
             node->getLeft()->getBasicType() != EbtStruct;
  }
  
  bool IntermNodePatternMatcher::matchInternal(TIntermBinary *node, TIntermNode *parentNode)
  {
      if ((mMask & kExpressionReturningArray) != 0)
      {
          if (node->isArray() && node->getOp() == EOpAssign && parentNode != nullptr &&
              !parentNode->getAsBlock())
          {
              return true;
          }
      }
  
      if ((mMask & kUnfoldedShortCircuitExpression) != 0)
      {
          if (node->getRight()->hasSideEffects() &&
              (node->getOp() == EOpLogicalOr || node->getOp() == EOpLogicalAnd))
          {
              return true;
          }
      }
      return false;
  }
  
  bool IntermNodePatternMatcher::match(TIntermBinary *node, TIntermNode *parentNode)
  {
      // L-value tracking information is needed to check for dynamic indexing in L-value.
      // Traversers that don't track l-values can still use this class and match binary nodes with
      // this variation of this method if they don't need to check for dynamic indexing in l-values.
      ASSERT((mMask & kDynamicIndexingOfVectorOrMatrixInLValue) == 0);
      return matchInternal(node, parentNode);
  }
  
  bool IntermNodePatternMatcher::match(TIntermBinary *node,
                                       TIntermNode *parentNode,
                                       bool isLValueRequiredHere)
  {
      if (matchInternal(node, parentNode))
      {
          return true;
      }
      if ((mMask & kDynamicIndexingOfVectorOrMatrixInLValue) != 0)
      {
          if (isLValueRequiredHere && IsDynamicIndexingOfVectorOrMatrix(node))
          {
              return true;
          }
      }
      return false;
  }
  
  bool IntermNodePatternMatcher::match(TIntermAggregate *node, TIntermNode *parentNode)
  {
      if ((mMask & kExpressionReturningArray) != 0)
      {
          if (parentNode != nullptr)
          {
              TIntermBinary *parentBinary = parentNode->getAsBinaryNode();
              bool parentIsAssignment =
                  (parentBinary != nullptr &&
                   (parentBinary->getOp() == EOpAssign || parentBinary->getOp() == EOpInitialize));
  
              if (node->getType().isArray() && !parentIsAssignment &&
                  (node->isConstructor() || node->isFunctionCall()) && !parentNode->getAsBlock())
              {
                  return true;
              }
          }
      }
      return false;
  }
  
  bool IntermNodePatternMatcher::match(TIntermTernary *node)
  {
      if ((mMask & kUnfoldedShortCircuitExpression) != 0)
      {
          return true;
      }
      return false;
  }
  
  bool IntermNodePatternMatcher::match(TIntermDeclaration *node)
  {
      if ((mMask & kMultiDeclaration) != 0)
      {
          if (node->getSequence()->size() > 1)
          {
              return true;
          }
      }
      if ((mMask & kArrayDeclaration) != 0)
      {
          if (node->getSequence()->front()->getAsTyped()->getType().isStructureContainingArrays())
          {
              return true;
          }
          // Need to check from all declarators whether they are arrays since that may vary between
          // declarators.
          for (TIntermNode *declarator : *node->getSequence())
          {
              if (declarator->getAsTyped()->isArray())
              {
                  return true;
              }
          }
      }
      if ((mMask & kNamelessStructDeclaration) != 0)
      {
          TIntermTyped *declarator = node->getSequence()->front()->getAsTyped();
          if (declarator->getBasicType() == EbtStruct &&
              declarator->getType().getStruct()->name() == "")
          {
              return true;
          }
      }
      return false;
  }
  
  }  // namespace sh
  

Download