-
Show log
Commit
-
Hash : 36b884e6
Author :
Date : 2020-09-02T19:21:21
Fix undefined behavior in minifloat conversion This cl applies the same fix already applied in SwiftShader here: https://swiftshader-review.googlesource.com/c/SwiftShader/+/48069 Original description: Shifting a 32-bit value by 32 or more is undefined behavior in C++. This previously happened in this code when converting a 32-bit float value to an 11- or 10-bit minifloat which is too small to be represented as a denormal, and should produce 0 instead. Instead of going through this arithmetic for denormals, just test whether the input value is too small to produce a valid denormal, and return 0 instead. Bug: chromium:1117433 Change-Id: I227c0e4c53000df6d9260fee364351a300b113a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2391764 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
-
Files
- Color.h
- Color.inc
- FastVector.h
- FastVector_unittest.cpp
- FixedVector.h
- FixedVector_unittest.cpp
- Float16ToFloat32.cpp
- Float16ToFloat32.py
- MemoryBuffer.cpp
- MemoryBuffer.h
- Optional.h
- Optional_unittest.cpp
- PackedEGLEnums_autogen.cpp
- PackedEGLEnums_autogen.h
- PackedEnums.cpp
- PackedEnums.h
- PackedGLEnums_autogen.cpp
- PackedGLEnums_autogen.h
- PoolAlloc.cpp
- PoolAlloc.h
- PoolAlloc_unittest.cpp
- aligned_memory.cpp
- aligned_memory.h
- aligned_memory_unittest.cpp
- android_util.cpp
- android_util.h
- angleutils.cpp
- angleutils.h
- angleutils_unittest.cpp
- apple_platform_utils.h
- bitset_utils.h
- bitset_utils_unittest.cpp
- debug.cpp
- debug.h
- event_tracer.cpp
- event_tracer.h
- fuchsia_egl/
- gen_packed_gl_enums.py
- gen_uniform_type_table.py
- hash_utils.h
- hash_utils_unittest.cpp
- mathutil.cpp
- mathutil.h
- mathutil_unittest.cpp
- matrix_utils.cpp
- matrix_utils.h
- matrix_utils_unittest.cpp
- packed_egl_enums.json
- packed_gl_enums.json
- platform.h
- string_utils.cpp
- string_utils.h
- string_utils_unittest.cpp
- system_utils.cpp
- system_utils.h
- system_utils_linux.cpp
- system_utils_mac.cpp
- system_utils_posix.cpp
- system_utils_unittest.cpp
- system_utils_win.cpp
- system_utils_win32.cpp
- system_utils_winuwp.cpp
- third_party/
- tls.cpp
- tls.h
- uniform_type_info_autogen.cpp
- utilities.cpp
- utilities.h
- utilities_unittest.cpp
- vector_utils.h
- vector_utils_unittest.cpp
- version.h
- vulkan/
