Hash :
03068e0c
Author :
Date :
2025-08-20T17:36:22
[WebGPU] Implement direct copy for images. This CL implements CopyImage specifically in cases where the source is the same size and format as the destination. Bug: angleproject:438268609 Change-Id: Icf5f3685bb2f49874d996883c839515314f1c189 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6842317 Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295
//
// Copyright 2024 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#ifndef LIBANGLE_RENDERER_WGPU_WGPU_HELPERS_H_
#define LIBANGLE_RENDERER_WGPU_WGPU_HELPERS_H_
#include <stdint.h>
#include <webgpu/webgpu.h>
#include <algorithm>
#include "libANGLE/Error.h"
#include "libANGLE/ImageIndex.h"
#include "libANGLE/angletypes.h"
#include "libANGLE/renderer/wgpu/ContextWgpu.h"
#include "libANGLE/renderer/wgpu/wgpu_utils.h"
namespace rx
{
class ContextWgpu;
namespace webgpu
{
// WebGPU requires copy buffers bytesPerRow to be aligned to 256.
// https://www.w3.org/TR/webgpu/#abstract-opdef-validating-gputexelcopybufferinfo
static const GLuint kCopyBufferAlignment = 256;
enum class UpdateSource
{
Clear,
Texture,
};
struct ClearUpdate
{
ClearValues clearValues;
bool hasDepth;
bool hasStencil;
};
struct SubresourceUpdate
{
SubresourceUpdate() {}
~SubresourceUpdate() {}
SubresourceUpdate(UpdateSource targetUpdateSource,
gl::LevelIndex newTargetLevel,
BufferHandle targetBuffer,
const WGPUTexelCopyBufferLayout &targetBufferLayout)
{
updateSource = targetUpdateSource;
textureData = targetBuffer;
textureDataLayout = targetBufferLayout;
targetLevel = newTargetLevel;
}
SubresourceUpdate(UpdateSource targetUpdateSource,
gl::LevelIndex newTargetLevel,
uint32_t newLayerIndex,
uint32_t newLayerCount,
BufferHandle targetBuffer,
const WGPUTexelCopyBufferLayout &targetBufferLayout)
{
updateSource = targetUpdateSource;
textureData = targetBuffer;
textureDataLayout = targetBufferLayout;
targetLevel = newTargetLevel;
layerIndex = newLayerIndex;
layerCount = newLayerCount;
}
SubresourceUpdate(UpdateSource targetUpdateSource,
gl::LevelIndex newTargetLevel,
ClearValues clearValues,
bool hasDepth,
bool hasStencil)
{
updateSource = targetUpdateSource;
targetLevel = newTargetLevel;
clearData.clearValues = clearValues;
clearData.hasDepth = hasDepth;
clearData.hasStencil = hasStencil;
}
UpdateSource updateSource;
ClearUpdate clearData;
BufferHandle textureData;
WGPUTexelCopyBufferLayout textureDataLayout;
gl::LevelIndex targetLevel;
uint32_t layerIndex = 0;
uint32_t layerCount = 1;
};
WGPUTextureDimension ToWgpuTextureDimension(gl::TextureType glTextureType);
class ImageHelper : public angle::Subject
{
public:
ImageHelper();
~ImageHelper() override;
angle::Result initImage(const DawnProcTable *wgpu,
angle::FormatID intendedFormatID,
angle::FormatID actualFormatID,
DeviceHandle device,
gl::LevelIndex firstAllocatedLevel,
WGPUTextureDescriptor textureDescriptor);
angle::Result initExternal(const DawnProcTable *wgpu,
angle::FormatID intendedFormatID,
angle::FormatID actualFormatID,
webgpu::TextureHandle externalTexture);
angle::Result flushStagedUpdates(ContextWgpu *contextWgpu);
angle::Result flushSingleLevelUpdates(ContextWgpu *contextWgpu,
gl::LevelIndex levelGL,
ClearValuesArray *deferredClears,
uint32_t deferredClearIndex);
WGPUTextureDescriptor createTextureDescriptor(WGPUTextureUsage usage,
WGPUTextureDimension dimension,
WGPUExtent3D size,
WGPUTextureFormat format,
std::uint32_t mipLevelCount,
std::uint32_t sampleCount);
angle::Result stageTextureUpload(ContextWgpu *contextWgpu,
const webgpu::Format &webgpuFormat,
GLenum type,
const gl::Extents &glExtents,
GLuint inputRowPitch,
GLuint inputDepthPitch,
uint32_t outputRowPitch,
uint32_t outputDepthPitch,
uint32_t allocationSize,
const gl::ImageIndex &index,
const uint8_t *pixels);
void stageClear(gl::LevelIndex targetLevel,
ClearValues clearValues,
bool hasDepth,
bool hasStencil);
void removeStagedUpdates(gl::LevelIndex levelToRemove);
void removeSingleSubresourceStagedUpdates(gl::LevelIndex levelToRemove,
uint32_t layerIndex,
uint32_t layerCount);
void resetImage();
angle::Result CopyImage(ContextWgpu *contextWgpu,
ImageHelper *srcImage,
const gl::ImageIndex &dstIndex,
const gl::Offset &dstOffset,
gl::LevelIndex sourceLevelGL,
uint32_t sourceLayer,
const gl::Box &sourceBox);
static angle::Result getReadPixelsParams(rx::ContextWgpu *contextWgpu,
const gl::PixelPackState &packState,
gl::Buffer *packBuffer,
GLenum format,
GLenum type,
const gl::Rectangle &area,
const gl::Rectangle &clippedArea,
rx::PackPixelsParams *paramsOut,
GLuint *skipBytesOut);
angle::Result readPixels(rx::ContextWgpu *contextWgpu,
const gl::Rectangle &area,
const rx::PackPixelsParams &packPixelsParams,
webgpu::LevelIndex level,
uint32_t layer,
void *pixels);
angle::Result createTextureViewSingleLevel(gl::LevelIndex targetLevel,
uint32_t layerIndex,
TextureViewHandle &textureViewOut);
angle::Result createFullTextureView(TextureViewHandle &textureViewOut,
WGPUTextureViewDimension desiredViewDimension);
angle::Result createTextureView(gl::LevelIndex targetLevel,
uint32_t levelCount,
uint32_t layerIndex,
uint32_t arrayLayerCount,
TextureViewHandle &textureViewOut,
Optional<WGPUTextureViewDimension> desiredViewDimension);
LevelIndex toWgpuLevel(gl::LevelIndex levelIndexGl) const;
gl::LevelIndex toGlLevel(LevelIndex levelIndexWgpu) const;
bool isTextureLevelInAllocatedImage(gl::LevelIndex textureLevel) const;
TextureHandle &getTexture() { return mTexture; }
WGPUTextureFormat toWgpuTextureFormat() const { return mTextureDescriptor.format; }
angle::FormatID getIntendedFormatID() const { return mIntendedFormatID; }
angle::FormatID getActualFormatID() const { return mActualFormatID; }
const WGPUTextureDescriptor &getTextureDescriptor() const { return mTextureDescriptor; }
gl::LevelIndex getFirstAllocatedLevel() const { return mFirstAllocatedLevel; }
gl::LevelIndex getLastAllocatedLevel() const;
uint32_t getLevelCount() const { return mTextureDescriptor.mipLevelCount; }
WGPUExtent3D getSize() const { return mTextureDescriptor.size; }
WGPUExtent3D getLevelSize(LevelIndex wgpuLevel) const;
uint32_t getSamples() const { return mTextureDescriptor.sampleCount; }
WGPUTextureUsage getUsage() const { return mTextureDescriptor.usage; }
bool isInitialized() const { return mInitialized; }
private:
void appendSubresourceUpdate(gl::LevelIndex level, SubresourceUpdate &&update);
std::vector<SubresourceUpdate> *getLevelUpdates(gl::LevelIndex level);
const DawnProcTable *mProcTable = nullptr;
TextureHandle mTexture;
WGPUTextureDescriptor mTextureDescriptor = {};
bool mInitialized = false;
gl::LevelIndex mFirstAllocatedLevel = gl::LevelIndex(0);
angle::FormatID mIntendedFormatID;
angle::FormatID mActualFormatID;
std::vector<std::vector<SubresourceUpdate>> mSubresourceQueue;
};
struct BufferMapState
{
WGPUMapMode mode;
size_t offset;
size_t size;
};
enum class MapAtCreation
{
No,
Yes,
};
struct BufferReadback;
class BufferHelper : public angle::NonCopyable
{
public:
BufferHelper();
~BufferHelper();
bool valid() const { return mBuffer.operator bool(); }
void reset();
angle::Result initBuffer(const DawnProcTable *wgpu,
webgpu::DeviceHandle device,
size_t size,
WGPUBufferUsage usage,
MapAtCreation mappedAtCreation);
angle::Result mapImmediate(ContextWgpu *context, WGPUMapMode mode, size_t offset, size_t size);
angle::Result unmap();
uint8_t *getMapWritePointer(size_t offset, size_t size) const;
const uint8_t *getMapReadPointer(size_t offset, size_t size) const;
const std::optional<BufferMapState> &getMappedState() const;
bool canMapForRead() const;
bool canMapForWrite() const;
bool isMappedForRead() const;
bool isMappedForWrite() const;
webgpu::BufferHandle getBuffer() const;
uint64_t requestedSize() const;
uint64_t actualSize() const;
// Helper to copy data to a staging buffer and map it. Staging data is cleaned up by the
// BufferReadback RAII object.
angle::Result readDataImmediate(ContextWgpu *context,
size_t offset,
size_t size,
webgpu::RenderPassClosureReason reason,
BufferReadback *result);
private:
const DawnProcTable *mProcTable = nullptr;
webgpu::BufferHandle mBuffer;
size_t mRequestedSize = 0;
std::optional<BufferMapState> mMappedState;
};
struct BufferReadback
{
BufferHelper buffer;
const uint8_t *data = nullptr;
};
} // namespace webgpu
} // namespace rx
#endif // LIBANGLE_RENDERER_WGPU_WGPU_HELPERS_H_