-
Show log
Commit
-
Hash : 9d84ad7d
Author :
Date : 2023-02-14T10:47:54
Translator: Fix sampler-in-struct when struct is unused Standalone symbols as statements are also pruned. For example in the below: ``` x; g(); ``` The line that only contains `x;` is pruned. In particular, this was causing a bug with sampler-in-struct processing where the code ASSERTs that if an instance of the struct is visited during traversal, that it's already processed as part of an index chain (like s.member), but in the above situation that is not true. Bug: chromium:1416152 Change-Id: I49e9a5826fc4d8c1fef1fa6f1d38c65f33f8acfd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4247584 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
-
Files
- ASTMetadataHLSL.cpp
- ASTMetadataHLSL.h
- AtomicCounterFunctionHLSL.cpp
- AtomicCounterFunctionHLSL.h
- BaseTypes.cpp
- BaseTypes.h
- BuildSPIRV.cpp
- BuildSPIRV.h
- BuiltInFunctionEmulator.cpp
- BuiltInFunctionEmulator.h
- BuiltInFunctionEmulatorGLSL.cpp
- BuiltInFunctionEmulatorGLSL.h
- BuiltInFunctionEmulatorHLSL.cpp
- BuiltInFunctionEmulatorHLSL.h
- BuiltinsWorkaroundGLSL.cpp
- BuiltinsWorkaroundGLSL.h
- CallDAG.cpp
- CallDAG.h
- CodeGen.cpp
- CollectVariables.cpp
- CollectVariables.h
- Common.h
- Compiler.cpp
- Compiler.h
- ConstantUnion.cpp
- ConstantUnion.h
- Declarator.cpp
- Declarator.h
- Diagnostics.cpp
- Diagnostics.h
- DirectiveHandler.cpp
- DirectiveHandler.h
- DriverUniformMetal.cpp
- DriverUniformMetal.h
- ExtensionBehavior.cpp
- ExtensionBehavior.h
- ExtensionGLSL.cpp
- ExtensionGLSL.h
- FlagStd140Structs.cpp
- FlagStd140Structs.h
- FunctionLookup.cpp
- FunctionLookup.h
- HashNames.cpp
- HashNames.h
- ImageFunctionHLSL.cpp
- ImageFunctionHLSL.h
- ImmutableString.h
- ImmutableStringBuilder.cpp
- ImmutableStringBuilder.h
- ImmutableString_ESSL_autogen.cpp
- ImmutableString_autogen.cpp
- InfoSink.cpp
- InfoSink.h
- Initialize.cpp
- Initialize.h
- InitializeDll.cpp
- InitializeDll.h
- InitializeGlobals.h
- IntermNode.cpp
- IntermNode.h
- IsASTDepthBelowLimit.cpp
- IsASTDepthBelowLimit.h
- Operator.cpp
- Operator_autogen.h
- OutputESSL.cpp
- OutputESSL.h
- OutputGLSL.cpp
- OutputGLSL.h
- OutputGLSLBase.cpp
- OutputGLSLBase.h
- OutputHLSL.cpp
- OutputHLSL.h
- OutputSPIRV.cpp
- OutputSPIRV.h
- OutputTree.cpp
- OutputTree.h
- ParseContext.cpp
- ParseContext.h
- PoolAlloc.cpp
- PoolAlloc.h
- Pragma.h
- QualifierTypes.cpp
- QualifierTypes.h
- ResourcesHLSL.cpp
- ResourcesHLSL.h
- Severity.h
- ShaderLang.cpp
- ShaderStorageBlockFunctionHLSL.cpp
- ShaderStorageBlockFunctionHLSL.h
- ShaderStorageBlockOutputHLSL.cpp
- ShaderStorageBlockOutputHLSL.h
- ShaderVars.cpp
- StaticType.h
- StructureHLSL.cpp
- StructureHLSL.h
- Symbol.cpp
- Symbol.h
- SymbolTable.cpp
- SymbolTable.h
- SymbolTable_ESSL_autogen.cpp
- SymbolTable_autogen.cpp
- SymbolTable_autogen.h
- SymbolUniqueId.cpp
- SymbolUniqueId.h
- TextureFunctionHLSL.cpp
- TextureFunctionHLSL.h
- TranslatorESSL.cpp
- TranslatorESSL.h
- TranslatorGLSL.cpp
- TranslatorGLSL.h
- TranslatorHLSL.cpp
- TranslatorHLSL.h
- TranslatorMetalDirect.cpp
- TranslatorMetalDirect.h
- TranslatorMetalDirect/
- TranslatorVulkan.cpp
- TranslatorVulkan.h
- Types.cpp
- Types.h
- UtilsHLSL.cpp
- UtilsHLSL.h
- ValidateAST.cpp
- ValidateAST.h
- ValidateBarrierFunctionCall.cpp
- ValidateBarrierFunctionCall.h
- ValidateClipCullDistance.cpp
- ValidateClipCullDistance.h
- ValidateGlobalInitializer.cpp
- ValidateGlobalInitializer.h
- ValidateLimitations.cpp
- ValidateLimitations.h
- ValidateMaxParameters.cpp
- ValidateMaxParameters.h
- ValidateOutputs.cpp
- ValidateOutputs.h
- ValidateSwitch.cpp
- ValidateSwitch.h
- ValidateTypeSizeLimitations.cpp
- ValidateTypeSizeLimitations.h
- ValidateVaryingLocations.cpp
- ValidateVaryingLocations.h
- VariablePacker.cpp
- VariablePacker.h
- VersionGLSL.cpp
- VersionGLSL.h
- blocklayout.cpp
- blocklayout.h
- blocklayoutHLSL.cpp
- blocklayoutHLSL.h
- builtin_function_declarations.txt
- builtin_variables.json
- emulated_builtin_function_data_hlsl.json
- emulated_builtin_functions_hlsl_autogen.cpp
- gen_builtin_symbols.py
- gen_emulated_builtin_function_tables.py
- generate_parser.py
- glslang.h
- glslang.l
- glslang.y
- glslang_lex_autogen.cpp
- glslang_tab_autogen.cpp
- glslang_tab_autogen.h
- length_limits.h
- span_unittest.cpp
- tree_ops/
- tree_util/
- util.cpp
- util.h
