kc3-lang/angle/src/libANGLE/Error.h

• Show log

  Commit

• Hash : cfb430c8
  Author :
  Date : 2025-02-10T13:19:05
  

  Remove angle::ErrorStream helper
  
  Most uses of the helper either use just the code or a fixed string,
  which compiles to a few instructions. Using this helper adds 200+ bytes
  of assembly to each use, due to the unneeded instantiation of
  ostringstream which allocates a buffer etc. The combined effect of this
  CL on an Android perf build is ~12KB (0.2%) reduction in size.
  
  The cases where the message is actually formatted are converted to an
  explicit use of ostringstream. Removing the helper so that the new code
  is explicit about the intent to use ostringstream, or an alternative way
  to format the message.
  
  Discovered accidentally while looking into size reduction due to
  __builtin_unreachable()
  
  Semi-automated code change, risk of copy-paste mistakes should be
  minimal.
  
  Bug: angleproject:394129077
  Change-Id: I47c2642d750d31416b08a1cfa435d5463c294e35
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6250078
  Commit-Queue: Roman Lavrov <romanl@google.com>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Charlie Lao <cclao@google.com>
  

Download

• src/libANGLE/Error.h

• //
  // Copyright 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  
  // Error.h: Defines the egl::Error and gl::Error classes which encapsulate API errors
  // and optional error messages.
  
  #ifndef LIBANGLE_ERROR_H_
  #define LIBANGLE_ERROR_H_
  
  #include <EGL/egl.h>
  #include <EGL/eglext.h>
  #include "angle_gl.h"
  #include "common/angleutils.h"
  #include "common/debug.h"
  
  #include <memory>
  #include <ostream>
  #include <string>
  
  namespace egl
  {
  class Error;
  }  // namespace egl
  
  namespace egl
  {
  
  class [[nodiscard]] Error final
  {
    public:
      explicit inline Error(EGLint errorCode);
      Error(EGLint errorCode, std::string &&message);
      Error(EGLint errorCode, EGLint id, std::string &&message);
      inline Error(const Error &other);
      inline Error(Error &&other);
      inline ~Error() = default;
  
      inline Error &operator=(const Error &other);
      inline Error &operator=(Error &&other);
  
      inline EGLint getCode() const;
      inline EGLint getID() const;
      inline bool isError() const;
  
      inline void setCode(EGLint code);
  
      const std::string &getMessage() const;
  
      static inline Error NoError();
  
    private:
      void createMessageString() const;
  
      friend std::ostream &operator<<(std::ostream &os, const Error &err);
  
      EGLint mCode;
      EGLint mID;
      mutable std::unique_ptr<std::string> mMessage;
  };
  
  inline Error NoError()
  {
      return Error::NoError();
  }
  
  }  // namespace egl
  
  #define ANGLE_CONCAT1(x, y) x##y
  #define ANGLE_CONCAT2(x, y) ANGLE_CONCAT1(x, y)
  #define ANGLE_LOCAL_VAR ANGLE_CONCAT2(_localVar, __LINE__)
  
  #define ANGLE_TRY_TEMPLATE(EXPR, FUNC)                \
      do                                                \
      {                                                 \
          auto ANGLE_LOCAL_VAR = EXPR;                  \
          if (ANGLE_UNLIKELY(IsError(ANGLE_LOCAL_VAR))) \
          {                                             \
              FUNC(ANGLE_LOCAL_VAR);                    \
          }                                             \
      } while (0)
  
  #define ANGLE_RETURN(X) return X;
  #define ANGLE_TRY(EXPR) ANGLE_TRY_TEMPLATE(EXPR, ANGLE_RETURN)
  
  // TODO(jmadill): Remove after EGL error refactor. http://anglebug.com/42261727
  #define ANGLE_SWALLOW_ERR(EXPR)                                       \
      do                                                                \
      {                                                                 \
          auto ANGLE_LOCAL_VAR = EXPR;                                  \
          if (ANGLE_UNLIKELY(IsError(ANGLE_LOCAL_VAR)))                 \
          {                                                             \
              ERR() << "Unhandled internal error: " << ANGLE_LOCAL_VAR; \
          }                                                             \
      } while (0)
  
  #undef ANGLE_LOCAL_VAR
  #undef ANGLE_CONCAT2
  #undef ANGLE_CONCAT1
  
  #define ANGLE_CHECK(CONTEXT, EXPR, MESSAGE, ERROR)                                    \
      do                                                                                \
      {                                                                                 \
          if (ANGLE_UNLIKELY(!(EXPR)))                                                  \
          {                                                                             \
              CONTEXT->handleError(ERROR, MESSAGE, __FILE__, ANGLE_FUNCTION, __LINE__); \
              return angle::Result::Stop;                                               \
          }                                                                             \
      } while (0)
  
  namespace angle
  {
  // Result implements an explicit exception handling mechanism.  A value of Stop signifies an
  // exception akin to |throw|.
  // TODO: make incorrect usage of Stop consistent with the above expectation.
  // http://anglebug.com/42266839
  enum class [[nodiscard]] Result
  {
      Continue,
      Stop,
  };
  
  // TODO(jmadill): Remove this when refactor is complete. http://anglebug.com/42261727
  egl::Error ResultToEGL(Result result);
  }  // namespace angle
  
  // TODO(jmadill): Remove this when refactor is complete. http://anglebug.com/42261727
  inline bool IsError(angle::Result result)
  {
      return result == angle::Result::Stop;
  }
  
  // TODO(jmadill): Remove this when refactor is complete. http://anglebug.com/42261727
  inline bool IsError(const egl::Error &err)
  {
      return err.isError();
  }
  
  // TODO(jmadill): Remove this when refactor is complete. http://anglebug.com/42261727
  inline bool IsError(bool value)
  {
      return !value;
  }
  
  // Utility macro for handling implementation methods inside Validation.
  #define ANGLE_HANDLE_VALIDATION_ERR(X) \
      do                                 \
      {                                  \
          (void)(X);                     \
          return false;                  \
      } while (0)
  
  #define ANGLE_VALIDATION_TRY(EXPR) ANGLE_TRY_TEMPLATE(EXPR, ANGLE_HANDLE_VALIDATION_ERR)
  
  #include "Error.inc"
  
  #endif  // LIBANGLE_ERROR_H_
  

Download