kc3-lang/angle/src/libANGLE/renderer/TextureImpl.cpp

• Show log

  Commit

• Hash : 7ad48b84
  Author :
  Date : 2022-05-26T00:23:35
  

  Revert "Add Vulkan backend support for texture labels"
  
  This reverts commit 1afb80587e302e2ce9a901a69fd66e5ef98a73b6.
  
  Reason for revert: Null-dereference crash starting here:
  https://ci.chromium.org/ui/p/chromium/builders/ci/mac-swangle-chromium-x64/26323/blamelist
  (see angle blamelist)
  
  Crash reason:  EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
  Crash address: 0x0
  Process uptime: 24 seconds
  
  Thread 0 (crashed)
   0  0x0
      rax = 0x0000011c0113c000   rdx = 0x0000011c09094590
      rcx = 0x0000000000000006   rbx = 0x0000011c0e2a0000
      rsi = 0x00007ffedfc11500   rdi = 0x0000011c01378010
      rbp = 0x00007ffedfc11540   rsp = 0x00007ffedfc114f8
       r8 = 0x0000000000000006    r9 = 0x0000000123a6ccc4
      r10 = 0x0000011c011018d0   r11 = 0x00007ffdbc1a4834
      r12 = 0x0000000000000006   r13 = 0x0000011c090944b0
      r14 = 0x0000011c0e34c000   r15 = 0x00007ffedfc11550
      rip = 0x0000000000000000
      Found by: given as instruction pointer in context
   1  libGLESv2.dylib!gl::Context::objectLabel(unsigned int, unsigned int, int, char const*) + 0x156
      rbp = 0x00007ffedfc116a0   rsp = 0x00007ffedfc11550
      rip = 0x00000001357b38e6
      Found by: previous frame's frame pointer
   2  libGLESv2.dylib!_GL_ObjectLabelKHR + 0xa5
      rbp = 0x00007ffedfc116f0   rsp = 0x00007ffedfc116b0
      rip = 0x000000013578e7e5
      Found by: previous frame's frame pointer
   3  Chromium Framework!gpu::gles2::GLES2DecoderPassthroughImpl::DoBindTexture(unsigned int, unsigned int) + 0x1ea
      rbp = 0x00007ffedfc11780   rsp = 0x00007ffedfc11700
      rip = 0x000000011e7dcd4a
      Found by: previous frame's frame pointer
  
  Original change's description:
  > Add Vulkan backend support for texture labels
  >
  > Add onLableUpdate support for textures in the Vulkan backend.
  >
  > Bug: b/229105865
  > Change-Id: Id9e5b2b81352e97b7843a63f27709739005dc2f3
  > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645854
  > Reviewed-by: Ian Elliott <ianelliott@google.com>
  > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  > Reviewed-by: Jamie Madill <jmadill@chromium.org>
  > Commit-Queue: Ian Elliott <ianelliott@google.com>
  
  Bug: b/229105865
  Change-Id: I5a5e00084e1320a486c43fec9d41b9ae6cb2b1db
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3669657
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
  Commit-Queue: Kai Ninomiya <kainino@chromium.org>
  

Download

• src/libANGLE/renderer/TextureImpl.cpp

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // TextureImpl.cpp: Defines the abstract rx::TextureImpl classes.
  
  #include "libANGLE/renderer/TextureImpl.h"
  
  namespace rx
  {
  TextureImpl::TextureImpl(const gl::TextureState &state) : mState(state) {}
  
  TextureImpl::~TextureImpl() {}
  
  void TextureImpl::onDestroy(const gl::Context *context) {}
  
  angle::Result TextureImpl::copyTexture(const gl::Context *context,
                                         const gl::ImageIndex &index,
                                         GLenum internalFormat,
                                         GLenum type,
                                         GLint sourceLevel,
                                         bool unpackFlipY,
                                         bool unpackPremultiplyAlpha,
                                         bool unpackUnmultiplyAlpha,
                                         const gl::Texture *source)
  {
      UNREACHABLE();
      return angle::Result::Stop;
  }
  
  angle::Result TextureImpl::copySubTexture(const gl::Context *context,
                                            const gl::ImageIndex &index,
                                            const gl::Offset &destOffset,
                                            GLint sourceLevel,
                                            const gl::Box &sourceBox,
                                            bool unpackFlipY,
                                            bool unpackPremultiplyAlpha,
                                            bool unpackUnmultiplyAlpha,
                                            const gl::Texture *source)
  {
      UNREACHABLE();
      return angle::Result::Stop;
  }
  
  angle::Result TextureImpl::copyRenderbufferSubData(const gl::Context *context,
                                                     const gl::Renderbuffer *srcBuffer,
                                                     GLint srcLevel,
                                                     GLint srcX,
                                                     GLint srcY,
                                                     GLint srcZ,
                                                     GLint dstLevel,
                                                     GLint dstX,
                                                     GLint dstY,
                                                     GLint dstZ,
                                                     GLsizei srcWidth,
                                                     GLsizei srcHeight,
                                                     GLsizei srcDepth)
  {
      UNREACHABLE();
      return angle::Result::Stop;
  }
  
  angle::Result TextureImpl::copyTextureSubData(const gl::Context *context,
                                                const gl::Texture *srcTexture,
                                                GLint srcLevel,
                                                GLint srcX,
                                                GLint srcY,
                                                GLint srcZ,
                                                GLint dstLevel,
                                                GLint dstX,
                                                GLint dstY,
                                                GLint dstZ,
                                                GLsizei srcWidth,
                                                GLsizei srcHeight,
                                                GLsizei srcDepth)
  {
      UNREACHABLE();
      return angle::Result::Stop;
  }
  
  angle::Result TextureImpl::copyCompressedTexture(const gl::Context *context,
                                                   const gl::Texture *source)
  {
      UNREACHABLE();
      return angle::Result::Stop;
  }
  
  angle::Result TextureImpl::copy3DTexture(const gl::Context *context,
                                           gl::TextureTarget target,
                                           GLenum internalFormat,
                                           GLenum type,
                                           GLint sourceLevel,
                                           GLint destLevel,
                                           bool unpackFlipY,
                                           bool unpackPremultiplyAlpha,
                                           bool unpackUnmultiplyAlpha,
                                           const gl::Texture *source)
  {
      UNREACHABLE();
      return angle::Result::Stop;
  }
  
  angle::Result TextureImpl::copy3DSubTexture(const gl::Context *context,
                                              const gl::TextureTarget target,
                                              const gl::Offset &destOffset,
                                              GLint sourceLevel,
                                              GLint destLevel,
                                              const gl::Box &srcBox,
                                              bool unpackFlipY,
                                              bool unpackPremultiplyAlpha,
                                              bool unpackUnmultiplyAlpha,
                                              const gl::Texture *source)
  {
      UNREACHABLE();
      return angle::Result::Stop;
  }
  
  angle::Result TextureImpl::setImageExternal(const gl::Context *context,
                                              const gl::ImageIndex &index,
                                              GLenum internalFormat,
                                              const gl::Extents &size,
                                              GLenum format,
                                              GLenum type)
  {
      UNREACHABLE();
      return angle::Result::Stop;
  }
  
  angle::Result TextureImpl::setBuffer(const gl::Context *context, GLenum internalFormat)
  {
      UNREACHABLE();
      return angle::Result::Stop;
  }
  
  GLint TextureImpl::getMemorySize() const
  {
      return 0;
  }
  
  GLint TextureImpl::getLevelMemorySize(gl::TextureTarget target, GLint level)
  {
      return 0;
  }
  
  GLint TextureImpl::getNativeID() const
  {
      UNREACHABLE();
      return 0;
  }
  
  GLenum TextureImpl::getColorReadFormat(const gl::Context *context)
  {
      UNREACHABLE();
      return GL_NONE;
  }
  
  GLenum TextureImpl::getColorReadType(const gl::Context *context)
  {
      UNREACHABLE();
      return GL_NONE;
  }
  
  angle::Result TextureImpl::getTexImage(const gl::Context *context,
                                         const gl::PixelPackState &packState,
                                         gl::Buffer *packBuffer,
                                         gl::TextureTarget target,
                                         GLint level,
                                         GLenum format,
                                         GLenum type,
                                         void *pixels)
  {
      UNREACHABLE();
      return angle::Result::Stop;
  }
  
  angle::Result TextureImpl::getCompressedTexImage(const gl::Context *context,
                                                   const gl::PixelPackState &packState,
                                                   gl::Buffer *packBuffer,
                                                   gl::TextureTarget target,
                                                   GLint level,
                                                   void *pixels)
  {
      UNREACHABLE();
      return angle::Result::Stop;
  }
  
  GLint TextureImpl::getRequiredExternalTextureImageUnits(const gl::Context *context)
  {
      UNREACHABLE();
      return 0;
  }
  
  }  // namespace rx
  

Download