Hash :
801993bc
Author :
Date :
2025-01-18T21:48:41
handle Qualcomm's mixed vendor IDs
This is a weird situation. Up until Qualcomm had a native Vulkan driver
for Windows (with the Snapdragon X series chips), the only vendor ID
observable on Windows was 0x4D4F4351. This was reported through DXGI,
device manager, etc.
But with their native Vulkan driver, they now report 0x5143 as well:
VkPhysicalDeviceProperties:
---------------------------
apiVersion = 1.3.295 (4206887)
driverVersion = 0.807.0 (2150789120)
vendorID = 0x5143
deviceID = 0x36334330
deviceType = PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU
deviceName = Qualcomm(R) Adreno(TM) X1-85 GPU
pipelineCacheUUID = 0eba4509-4351-0000-0000-010c05430000
And yet, DXGI still reports 0x4D4F4351. Cool, huh?
Let's teach IsQualcomm to understand both vendor IDs to ensure the
device is correctly detected as a tile-based renderer in the Vulkan
backend.
Bug: angleproject:390866623
Change-Id: I9170c30262ace269498f066e922a279c7e981de6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6183621
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Steven Noonan <steven@uplinklabs.net>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235
//
// Copyright 2016 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// driver_utils.h : provides more information about current driver.
#ifndef LIBANGLE_RENDERER_DRIVER_UTILS_H_
#define LIBANGLE_RENDERER_DRIVER_UTILS_H_
#include "common/platform.h"
#include "common/platform_helpers.h"
#include "libANGLE/angletypes.h"
namespace rx
{
enum VendorID : uint32_t
{
VENDOR_ID_UNKNOWN = 0x0,
VENDOR_ID_AMD = 0x1002,
VENDOR_ID_APPLE = 0x106B,
VENDOR_ID_ARM = 0x13B5,
// Broadcom devices won't use PCI, but this is their Vulkan vendor id.
VENDOR_ID_BROADCOM = 0x14E4,
VENDOR_ID_GOOGLE = 0x1AE0,
VENDOR_ID_INTEL = 0x8086,
VENDOR_ID_MESA = 0x10005,
VENDOR_ID_MICROSOFT = 0x1414,
VENDOR_ID_NVIDIA = 0x10DE,
VENDOR_ID_POWERVR = 0x1010,
VENDOR_ID_QUALCOMM_DXGI = 0x4D4F4351,
VENDOR_ID_QUALCOMM = 0x5143,
VENDOR_ID_SAMSUNG = 0x144D,
VENDOR_ID_VIVANTE = 0x9999,
VENDOR_ID_VMWARE = 0x15AD,
VENDOR_ID_VIRTIO = 0x1AF4,
};
enum AndroidDeviceID : uint32_t
{
ANDROID_DEVICE_ID_UNKNOWN = 0x0,
ANDROID_DEVICE_ID_NEXUS5X = 0x4010800,
ANDROID_DEVICE_ID_PIXEL2 = 0x5040001,
ANDROID_DEVICE_ID_PIXEL1XL = 0x5030004,
ANDROID_DEVICE_ID_PIXEL4 = 0x6040001,
ANDROID_DEVICE_ID_GALAXYA23 = 0x6010901,
ANDROID_DEVICE_ID_GALAXYS23 = 0x43050A01,
ANDROID_DEVICE_ID_SWIFTSHADER = 0xC0DE,
};
inline bool IsAMD(uint32_t vendorId)
{
return vendorId == VENDOR_ID_AMD;
}
inline bool IsAppleGPU(uint32_t vendorId)
{
return vendorId == VENDOR_ID_APPLE;
}
inline bool IsARM(uint32_t vendorId)
{
return vendorId == VENDOR_ID_ARM;
}
inline bool IsBroadcom(uint32_t vendorId)
{
return vendorId == VENDOR_ID_BROADCOM;
}
inline bool IsIntel(uint32_t vendorId)
{
return vendorId == VENDOR_ID_INTEL;
}
inline bool IsGoogle(uint32_t vendorId)
{
return vendorId == VENDOR_ID_GOOGLE;
}
inline bool IsMicrosoft(uint32_t vendorId)
{
return vendorId == VENDOR_ID_MICROSOFT;
}
inline bool IsNvidia(uint32_t vendorId)
{
return vendorId == VENDOR_ID_NVIDIA;
}
inline bool IsPowerVR(uint32_t vendorId)
{
return vendorId == VENDOR_ID_POWERVR;
}
inline bool IsQualcomm(uint32_t vendorId)
{
// Qualcomm is an unusual one. It has two different vendor IDs depending on
// where you look. On Windows, DXGI will report the VENDOR_ID_QUALCOMM_DXGI
// value (due to it being an ACPI device rather than PCI device), but their
// native Vulkan driver will actually report their PCI vendor ID (the
// VENDOR_ID_QUALCOMM value). So we have to check both, to ensure we arrive
// at the right conclusion regardless of what source we are querying for
// vendor information.
return vendorId == VENDOR_ID_QUALCOMM || vendorId == VENDOR_ID_QUALCOMM_DXGI;
}
inline bool IsSamsung(uint32_t vendorId)
{
return vendorId == VENDOR_ID_SAMSUNG;
}
inline bool IsVivante(uint32_t vendorId)
{
return vendorId == VENDOR_ID_VIVANTE;
}
inline bool IsVMWare(uint32_t vendorId)
{
return vendorId == VENDOR_ID_VMWARE;
}
inline bool IsVirtIO(uint32_t vendorId)
{
return vendorId == VENDOR_ID_VIRTIO;
}
inline bool IsNexus5X(uint32_t vendorId, uint32_t deviceId)
{
return IsQualcomm(vendorId) && deviceId == ANDROID_DEVICE_ID_NEXUS5X;
}
inline bool IsPixel1XL(uint32_t vendorId, uint32_t deviceId)
{
return IsQualcomm(vendorId) && deviceId == ANDROID_DEVICE_ID_PIXEL1XL;
}
inline bool IsPixel2(uint32_t vendorId, uint32_t deviceId)
{
return IsQualcomm(vendorId) && deviceId == ANDROID_DEVICE_ID_PIXEL2;
}
inline bool IsPixel4(uint32_t vendorId, uint32_t deviceId)
{
return IsQualcomm(vendorId) && deviceId == ANDROID_DEVICE_ID_PIXEL4;
}
inline bool IsGalaxyA23(uint32_t vendorId, uint32_t deviceId)
{
return IsQualcomm(vendorId) && deviceId == ANDROID_DEVICE_ID_GALAXYA23;
}
inline bool IsGalaxyS23(uint32_t vendorId, uint32_t deviceId)
{
return IsQualcomm(vendorId) && deviceId == ANDROID_DEVICE_ID_GALAXYS23;
}
inline bool IsSwiftshader(uint32_t vendorId, uint32_t deviceId)
{
return IsGoogle(vendorId) && deviceId == ANDROID_DEVICE_ID_SWIFTSHADER;
}
std::string GetVendorString(uint32_t vendorId);
// For Linux, Intel graphics driver version is the Mesa version. The version number has three
// fields: major revision, minor revision and release number.
// For Windows, The version number includes 3rd and 4th fields. Please refer the details at
// http://www.intel.com/content/www/us/en/support/graphics-drivers/000005654.html.
// Current implementation only supports Windows.
class IntelDriverVersion
{
public:
IntelDriverVersion(uint32_t buildNumber);
IntelDriverVersion(uint32_t majorVersion, uint32_t minorVersion);
bool operator==(const IntelDriverVersion &) const;
bool operator!=(const IntelDriverVersion &) const;
bool operator<(const IntelDriverVersion &) const;
bool operator>=(const IntelDriverVersion &) const;
private:
uint32_t mBuildNumber;
};
IntelDriverVersion ParseIntelWindowsDriverVersion(uint32_t driverVersion);
bool IsSandyBridge(uint32_t DeviceId);
bool IsIvyBridge(uint32_t DeviceId);
bool IsHaswell(uint32_t DeviceId);
bool IsBroadwell(uint32_t DeviceId);
bool IsCherryView(uint32_t DeviceId);
bool IsSkylake(uint32_t DeviceId);
bool IsBroxton(uint32_t DeviceId);
bool IsKabyLake(uint32_t DeviceId);
bool IsGeminiLake(uint32_t DeviceId);
bool IsCoffeeLake(uint32_t DeviceId);
bool IsMeteorLake(uint32_t DeviceId);
bool Is9thGenIntel(uint32_t DeviceId);
bool Is11thGenIntel(uint32_t DeviceId);
bool Is12thGenIntel(uint32_t DeviceId);
using ARMDriverVersion = angle::VersionTriple;
ARMDriverVersion ParseARMVulkanDriverVersion(uint32_t driverVersion);
using QualcommDriverVersion = angle::VersionTriple;
QualcommDriverVersion ParseQualcommVulkanDriverVersion(uint32_t driverVersion);
// Platform helpers
using angle::IsAndroid;
using angle::IsApple;
using angle::IsChromeOS;
using angle::IsFuchsia;
using angle::IsIOS;
using angle::IsLinux;
using angle::IsMac;
using angle::IsWindows;
using angle::IsWindows10OrLater;
using angle::IsWindows8OrLater;
using angle::IsWindowsVistaOrLater;
bool IsWayland();
using OSVersion = angle::VersionTriple;
OSVersion GetMacOSVersion();
OSVersion GetiOSVersion();
OSVersion GetLinuxOSVersion();
int GetAndroidSDKVersion();
} // namespace rx
#endif // LIBANGLE_RENDERER_DRIVER_UTILS_H_