kc3-lang/angle/src

Diff

• Show log

  Commit

• Hash : 9ddaa686
  Author :
  Date : 2021-07-16T14:57:13
  

  Call getNearestSamples() in Framebuffer::setAttachment()
  
  The app jp.garud.ssimulator uses the same sample count of '2' for both
  glRenderbufferStorageMultisampleEXT() and
  glFramebufferTexture2DMultisampleEXT(). However, when
  glRenderbufferStorageMultisampleEXT() is called,
  Renderbuffer::setStorageMultisample() calls
  TextureCaps::getNearestSamples() which rounds up the sample count from
  '2' to '4'.   Later, when the app tries to draw with the framebuffer,
  an error is generated by ANGLE:
  
  Framebuffer is incomplete: Attachments have different sample counts.
  
  The fix is to also call TextureCaps::getNearestSamples() in
  Framebuffer::setAttachment() to make sure the sample count passed
  into glFramebufferTexture2DMultisampleEXT() is also rounded up to
  match the renderbuffer.
  
  Bug: angleproject:6183
  Test: MultisampledRenderToTextureTest.FramebufferCompletenessSmallSampleCount
  Change-Id: I58be9986077257f4767f2e528c2f87e496d9d774
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3036254
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Tim Van Patten <timvp@google.com>
  

• Files

• android_system_settings/
• commit_id.py
• common/
• compiler.gni
• compiler/
• copy_compiler_dll.bat
• feature_support_util/
• gpu_info_util/
• image_util/
• libANGLE/
• libEGL/
• libGL/
• libGLESv1_CM/
• libGLESv2.gni
• libGLESv2/
• libOpenCL/
• tests/
• third_party/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags