kc3-lang/angle/src/compiler/translator/Intermediate.h

• Show log

  Commit

• Hash : 5290174b
  Author :
  Date : 2015-04-15T13:42:45
  

  Refactor ternary operator parsing
  
  Refactor ternary operator parsing so that validation is done in
  ParseContext and Intermediate's role is simply to create the node added
  to the tree.
  
  Remove partially bugged checks for null nodes as a part of this - in
  error cases the parser doesn't typically add null nodes to the tree, but
  rather always has a fallback to add a dummy node if parsing fails as a
  method of recovery. When parsing ternary operators it should be
  guaranteed that none of the parameter nodes is null.
  
  Includes a better explanation of why ternary operators are not always
  folded when only the condition is constant, and a test to make sure this
  doesn't regress.
  
  BUG=angleproject:952
  TEST=WebGL conformance tests, angle_unittests
  
  Change-Id: Icbcb721b5ab36cf314a16e79f9814aef1f355fa0
  Reviewed-on: https://chromium-review.googlesource.com/265643
  Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
  Tested-by: Olli Etuaho <oetuaho@nvidia.com>
  

Download

• src/compiler/translator/Intermediate.h

• //
  // Copyright (c) 2002-2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #ifndef COMPILER_TRANSLATOR_INTERMEDIATE_H_
  #define COMPILER_TRANSLATOR_INTERMEDIATE_H_
  
  #include "compiler/translator/IntermNode.h"
  
  struct TVectorFields
  {
      int offsets[4];
      int num;
  };
  
  //
  // Set of helper functions to help parse and build the tree.
  //
  class TInfoSink;
  class TIntermediate
  {
    public:
      POOL_ALLOCATOR_NEW_DELETE();
      TIntermediate(TInfoSink &i)
          : mInfoSink(i) { }
  
      TIntermSymbol *addSymbol(
          int id, const TString &, const TType &, const TSourceLoc &);
      TIntermTyped *addBinaryMath(
          TOperator op, TIntermTyped *left, TIntermTyped *right, const TSourceLoc &);
      TIntermTyped *addAssign(
          TOperator op, TIntermTyped *left, TIntermTyped *right, const TSourceLoc &);
      TIntermTyped *addIndex(
          TOperator op, TIntermTyped *base, TIntermTyped *index, const TSourceLoc &);
      TIntermTyped *addUnaryMath(
          TOperator op, TIntermTyped *child, const TSourceLoc &line, const TType *funcReturnType);
      TIntermAggregate *growAggregate(
          TIntermNode *left, TIntermNode *right, const TSourceLoc &);
      TIntermAggregate *makeAggregate(TIntermNode *node, const TSourceLoc &);
      TIntermAggregate *setAggregateOperator(TIntermNode *, TOperator, const TSourceLoc &);
      TIntermNode *addSelection(TIntermTyped *cond, TIntermNodePair code, const TSourceLoc &);
      TIntermTyped *addSelection(TIntermTyped *cond, TIntermTyped *trueBlock, TIntermTyped *falseBlock,
                                 const TSourceLoc &line);
      TIntermSwitch *addSwitch(
          TIntermTyped *init, TIntermAggregate *statementList, const TSourceLoc &line);
      TIntermCase *addCase(
          TIntermTyped *condition, const TSourceLoc &line);
      TIntermTyped *addComma(
          TIntermTyped *left, TIntermTyped *right, const TSourceLoc &);
      TIntermConstantUnion *addConstantUnion(ConstantUnion *, const TType &, const TSourceLoc &);
      // TODO(zmo): Get rid of default value.
      bool parseConstTree(const TSourceLoc &, TIntermNode *, ConstantUnion *,
                          TOperator, TType, bool singleConstantParam = false);
      TIntermNode *addLoop(TLoopType, TIntermNode *, TIntermTyped *, TIntermTyped *,
                           TIntermNode *, const TSourceLoc &);
      TIntermBranch *addBranch(TOperator, const TSourceLoc &);
      TIntermBranch *addBranch(TOperator, TIntermTyped *, const TSourceLoc &);
      TIntermTyped *addSwizzle(TVectorFields &, const TSourceLoc &);
      bool postProcess(TIntermNode *);
  
      static void outputTree(TIntermNode *, TInfoSinkBase &);
  
    private:
      void operator=(TIntermediate &); // prevent assignments
  
      TInfoSink & mInfoSink;
  };
  
  #endif  // COMPILER_TRANSLATOR_INTERMEDIATE_H_
  

Download