Hash :
dadd1986
Author :
Date :
2020-04-21T01:50:00
Implement GL_APPLE_clip_distance - Built-in variable gl_ClipDistance has been added to compiler. - Desktop GL: gl_ClipDistance is supported since GL 3.0. Enable/Disable each gl_ClipDistances[i] works out of the box via glEnable(). - Vulkan/Metal: Use uniform variable to control writing to each gl_ClipDistance. One bit flag controls one element in the gl_ClipDistance array. The writing to the disabled element in vertex shader will be ignored, and turned into zero assignment instead. - Direct3D/Mobile GL: Not implemented yet. - Added ClipDistanceTest to gl_tests and compiler unittests. - GL_APPLE_clip_distance is a subset of GL_EXT_clip_cull_distance, so GL_EXT_clip_cull_distance could be implemented in future if needed. Bug: angleproject:4452 Change-Id: I571ac8b56826989808a680226a04bec4cf59988e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2084324 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120
//
// Copyright 2017 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#include "compiler/translator/HashNames.h"
#include "compiler/translator/ImmutableString.h"
#include "compiler/translator/ImmutableStringBuilder.h"
#include "compiler/translator/IntermNode.h"
#include "compiler/translator/Symbol.h"
namespace sh
{
namespace
{
constexpr const ImmutableString kHashedNamePrefix("webgl_");
ImmutableString HashName(const ImmutableString &name, ShHashFunction64 hashFunction)
{
ASSERT(!name.empty());
ASSERT(hashFunction);
khronos_uint64_t number = (*hashFunction)(name.data(), name.length());
// Build the hashed name in place.
static const unsigned int kHexStrMaxLength = sizeof(number) * 2;
static const size_t kHashedNameMaxLength = kHashedNamePrefix.length() + kHexStrMaxLength;
ImmutableStringBuilder hashedName(kHashedNameMaxLength);
hashedName << kHashedNamePrefix;
hashedName.appendHex(number);
return hashedName;
}
} // anonymous namespace
ImmutableString HashName(const ImmutableString &name,
ShHashFunction64 hashFunction,
NameMap *nameMap)
{
const ImmutableString kUnhashedNamePrefix(kUserDefinedNamePrefix);
if (hashFunction == nullptr)
{
if (name.length() + kUnhashedNamePrefix.length() > kESSLMaxIdentifierLength)
{
// If the identifier length is already close to the limit, we can't prefix it. This is
// not a problem since there are no builtins or ANGLE's internal variables that would
// have as long names and could conflict.
return name;
}
if (name == "gl_ClipDistance")
{
// NOTE(hqle): When gl_ClipDistance is re-declared, it will become an UserDefined
// symbol. Normally, UserDefined symbols will have "_u" prefix added to their names by
// ANGLE. However, gl_ClipDistance is an exception. If we add "_u" to its name, the
// backend won't be able to handle it properly. So for gl_ClipDistance, we won't add
// "_u" prefix, instead we return it original name.
//
// The other way is treating gl_ClipDistance as an AngleInternal symbol when a
// re-declaration occurs. AngleInternal symbols will have their name intact. However,
// the issue is that the current code put a lot of restrictions on AngleInternal
// symbols. For examples:
// - CollectVariables.cpp will not consider AngleInternal as varying output variales.
// - SymbolTable.cpp will throw an exception if AngleInternal symbols are declared by
// users. In this case, it would be gl_ClipDistance. This is because
// TSymbolTable::declare() only accepts an UserDefined symbol.
// - And potentially many other places that have some assumptions that haven't been
// discovered yet.
//
// If re-declared gl_ClipDistance was to be an AngleInternal symbol, a special "if (name
// == "gl_ClipDistance")" handling would have to be put into all the above mentioned
// cases. TParseContext::declareVariable() function would also have to be modified in
// order to assign AngleInternal symbol type to the re-declared gl_ClipDistance
// variable.
// Compare to only this place has to be handled if re-declared gl_ClipDistance is
// treated as an UserDefined symbol.
//
return name;
}
ImmutableStringBuilder prefixedName(kUnhashedNamePrefix.length() + name.length());
prefixedName << kUnhashedNamePrefix << name;
return prefixedName;
}
if (nameMap)
{
NameMap::const_iterator it = nameMap->find(name.data());
if (it != nameMap->end())
{
// TODO(oetuaho): Would be nice if we didn't need to allocate a string here.
return ImmutableString(it->second);
}
}
ImmutableString hashedName = HashName(name, hashFunction);
if (nameMap)
{
(*nameMap)[name.data()] = hashedName.data();
}
return hashedName;
}
ImmutableString HashName(const TSymbol *symbol, ShHashFunction64 hashFunction, NameMap *nameMap)
{
if (symbol->symbolType() == SymbolType::Empty)
{
return kEmptyImmutableString;
}
if (symbol->symbolType() == SymbolType::AngleInternal ||
symbol->symbolType() == SymbolType::BuiltIn)
{
return symbol->name();
}
return HashName(symbol->name(), hashFunction, nameMap);
}
} // namespace sh