kc3-lang/angle/src/compiler/translator/ValidateGlobalInitializer.cpp

• Show log

  Commit

• Hash : b0c645e2
  Author :
  Date : 2015-05-12T14:25:36
  

  Validate global initializer qualifiers
  
  Allow only constants, other globals, temporaries, and uniforms to be used
  in global variable initialization for now. The spec limits global
  variable initialization further to only constant expressions, but fully
  implementing this has a too large compatibility cost for ESSL 1.00, so
  implement it only partially. In the case of ESSL 3.00 we can use stricter
  validation, since there's no legacy to worry about.
  
  Resubmitting the change, since the previous version neglected to remove
  incorrect GLSL tests.
  
  TEST=angle_unittests, WebGL conformance tests, angle_end2end_tests
  BUG=angleproject:988
  
  Change-Id: I1bb3b8dc305689a90eadfe8cc7705e5ac3829e03
  Reviewed-on: https://chromium-review.googlesource.com/270651
  Tested-by: Olli Etuaho <oetuaho@nvidia.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/compiler/translator/ValidateGlobalInitializer.cpp

• //
  // Copyright (c) 2002-2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #include "compiler/translator/ValidateGlobalInitializer.h"
  
  #include "compiler/translator/ParseContext.h"
  
  namespace
  {
  
  class ValidateGlobalInitializerTraverser : public TIntermTraverser
  {
    public:
      ValidateGlobalInitializerTraverser(const TParseContext *context);
  
      void visitSymbol(TIntermSymbol *node) override;
  
      bool isValid() const { return mIsValid; }
      bool issueWarning() const { return mIssueWarning; }
  
    private:
      const TParseContext *mContext;
      bool mIsValid;
      bool mIssueWarning;
  };
  
  void ValidateGlobalInitializerTraverser::visitSymbol(TIntermSymbol *node)
  {
      const TSymbol *sym = mContext->symbolTable.find(node->getSymbol(), mContext->getShaderVersion());
      if (sym->isVariable())
      {
          // ESSL 1.00 section 4.3 (or ESSL 3.00 section 4.3):
          // Global initializers must be constant expressions.
          const TVariable *var = static_cast<const TVariable *>(sym);
          switch (var->getType().getQualifier())
          {
            case EvqConst:
              break;
            case EvqGlobal:
            case EvqTemporary:
            case EvqUniform:
              // We allow these cases to be compatible with legacy ESSL 1.00 content.
              // Implement stricter rules for ESSL 3.00 since there's no legacy content to deal with.
              if (mContext->getShaderVersion() >= 300)
              {
                  mIsValid = false;
              }
              else
              {
                  mIssueWarning = true;
              }
              break;
            default:
              mIsValid = false;
          }
      }
  }
  
  ValidateGlobalInitializerTraverser::ValidateGlobalInitializerTraverser(const TParseContext *context)
      : TIntermTraverser(true, false, false),
        mContext(context),
        mIsValid(true),
        mIssueWarning(false)
  {
  }
  
  } // namespace
  
  bool ValidateGlobalInitializer(TIntermTyped *initializer, const TParseContext *context, bool *warning)
  {
      ValidateGlobalInitializerTraverser validate(context);
      initializer->traverse(&validate);
      ASSERT(warning != nullptr);
      *warning = validate.issueWarning();
      return validate.isValid();
  }
  
  

Download