shaders

Diff

Show log
Commit

Hash : 57eded36
Author :
Date : 2024-04-03T23:02:39

Vulkan: Fix off-by-one error in compute-based stencil blit

The coordinates used for sampling were calculated based on pixel's
top-left (integer) coordinates and used with a NEAREST sampler.  This
resulted in two bugs:

- When X was flipped, the bounds check rejected the first column
- The sampling could pick the wrong pixel as the on-the-edge coordinates
  could map to either of 4 pixels that share that corner.

This change moves the sampling coordinates to the pixel's center.

Bug: angleproject:8652
Change-Id: I0b54fa0bad366f52f8e6c17bb0054fa373af8b5c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5420834
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Properties

Git HTTP	https://git.kmx.io/kc3-lang/angle.git
Git SSH	git@git.kmx.io:kc3-lang/angle.git
Public access ?	public
Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
Users
Tags

README.md
Shader Variations

To build multiple variations of a shader, add a file named X.json corresponding to shader file X. A variation is generated by building the shader with different definitions (a la glslang_validator’s -DName=1). These definitions come from flags and enumerations defined in the json file. Without a .json file, the shader is generated as is (1 variation).

There are multiple possible fields in the json file:
- “Description”: This contains the license and other comments, which will be ignored.
- “Flags”: this is a list of flags. Each flag FLAG defines a shader variation with or without the define FLAG=1.
- other: any other field is a similar list to flags, except that each entry in this enumeration is a variation. Similar to “flags”, every entry ENTRY results in an ENTRY=1 define.
Flags are shorthand for 2-entry enumerations. Given n flags, there are 2^n variations where every flag is either present or not. For enumerations, only one entry is active in any variation. Thus, an enumeration with n entries generates n variations.

Example

Here is an example json file:

{
```
"Description": [
    "Copyright 2018 The ANGLE Project Authors. All rights reserved.",
    "Use of this source code is governed by a BSD-style license that can be",
    "found in the LICENSE file.",
    "",
    "RayTrace.comp.json: Build parameters for RayTrace.comp."
],
"Flags": [
    "NanFilter",
    "WorkaroundIntelBug"
],
"RayTraceQuality": [
    "IsRTLowRes",
    "IsRTHighRes",
    "IsRTAwesome"
],
"ImageType": [
    "IsR",
    "IsRG",
    "IsRGB",
    "IsRGBA"
]
```
}

This will generate 2^2 3 4 shaders.

kc3-lang/angle/src/libANGLE/renderer/vulkan/shaders

Commit

Files

Properties

README.md

Shader Variations

Example