kc3-lang/angle/src/libANGLE/renderer/vulkan/DisplayVk.h

• Show log

  Commit

• Hash : 68a5baeb
  Author :
  Date : 2020-09-23T22:13:03
  

  Revert "Vulkan: Implement a SharedResourceUse pool"
  
  This reverts commit de335c16855f11d1f0a6f0b37bee30c8a09a6c1d.
  
  Reason for revert: Might actually regress CPU overhead perf.
  Unsure but it's possible the reported perf improvement was due
  to variance.
  
  Original change's description:
  > Vulkan: Implement a SharedResourceUse pool
  > 
  > When adding a Resource to the ResourceUseList of ContextVk
  > we constructed a new SharedResourceUse object for tracking
  > and update of the Resource's Serial. We would then delete
  > it after releasing the resource. This incurs repeated
  > memory operation costs.
  > 
  > Instead we now allocate a pool of SharedResourceUse objects
  > and acquire and release from this pool as needed.
  > 
  > VTune profile of the Manhattan 30 offscreen benchmark
  > shows the CPU occupancy of bufferRead decrease from an
  > average of 0.9% -> 0.6% and imageRead decreases from
  > an average of 0.4% -> 0.3%. The bottleneck for both
  > these methods is the retain() method that leverages
  > the new SharedResourceUse pool.
  > 
  > Bug: angleproject:4950
  > Change-Id: Ib4f67c6f101d4b2de118014546e6cc14ad108703
  > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2396597
  > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  > Reviewed-by: Jamie Madill <jmadill@chromium.org>
  > Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
  
  TBR=syoussefi@chromium.org,jmadill@chromium.org,m.maiya@samsung.com
  
  # Not skipping CQ checks because original CL landed > 1 day ago.
  
  Bug: angleproject:4950
  Change-Id: I40081551c3db67d6e55182fea40119946ed16ac3
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2426479
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  

Download

• src/libANGLE/renderer/vulkan/DisplayVk.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // DisplayVk.h:
  //    Defines the class interface for DisplayVk, implementing DisplayImpl.
  //
  
  #ifndef LIBANGLE_RENDERER_VULKAN_DISPLAYVK_H_
  #define LIBANGLE_RENDERER_VULKAN_DISPLAYVK_H_
  
  #include "common/MemoryBuffer.h"
  #include "libANGLE/renderer/DisplayImpl.h"
  #include "libANGLE/renderer/vulkan/vk_utils.h"
  
  namespace rx
  {
  class RendererVk;
  
  class ShareGroupVk : public ShareGroupImpl
  {
    public:
      ShareGroupVk() {}
  };
  
  class DisplayVk : public DisplayImpl, public vk::Context
  {
    public:
      DisplayVk(const egl::DisplayState &state);
      ~DisplayVk() override;
  
      egl::Error initialize(egl::Display *display) override;
      void terminate() override;
  
      egl::Error makeCurrent(egl::Surface *drawSurface,
                             egl::Surface *readSurface,
                             gl::Context *context) override;
  
      bool testDeviceLost() override;
      egl::Error restoreLostDevice(const egl::Display *display) override;
  
      std::string getVendorString() const override;
  
      DeviceImpl *createDevice() override;
  
      egl::Error waitClient(const gl::Context *context) override;
      egl::Error waitNative(const gl::Context *context, EGLint engine) override;
  
      SurfaceImpl *createWindowSurface(const egl::SurfaceState &state,
                                       EGLNativeWindowType window,
                                       const egl::AttributeMap &attribs) override;
      SurfaceImpl *createPbufferSurface(const egl::SurfaceState &state,
                                        const egl::AttributeMap &attribs) override;
      SurfaceImpl *createPbufferFromClientBuffer(const egl::SurfaceState &state,
                                                 EGLenum buftype,
                                                 EGLClientBuffer clientBuffer,
                                                 const egl::AttributeMap &attribs) override;
      SurfaceImpl *createPixmapSurface(const egl::SurfaceState &state,
                                       NativePixmapType nativePixmap,
                                       const egl::AttributeMap &attribs) override;
  
      ImageImpl *createImage(const egl::ImageState &state,
                             const gl::Context *context,
                             EGLenum target,
                             const egl::AttributeMap &attribs) override;
  
      ContextImpl *createContext(const gl::State &state,
                                 gl::ErrorSet *errorSet,
                                 const egl::Config *configuration,
                                 const gl::Context *shareContext,
                                 const egl::AttributeMap &attribs) override;
  
      StreamProducerImpl *createStreamProducerD3DTexture(egl::Stream::ConsumerType consumerType,
                                                         const egl::AttributeMap &attribs) override;
  
      EGLSyncImpl *createSync(const egl::AttributeMap &attribs) override;
  
      gl::Version getMaxSupportedESVersion() const override;
      gl::Version getMaxConformantESVersion() const override;
  
      virtual const char *getWSIExtension() const = 0;
      virtual const char *getWSILayer() const;
  
      // Determine if a config with given formats and sample counts is supported.  This callback may
      // modify the config to add or remove platform specific attributes such as nativeVisualID.  If
      // the config is not supported by the window system, it removes the EGL_WINDOW_BIT from
      // surfaceType, which would still allow the config to be used for pbuffers.
      virtual void checkConfigSupport(egl::Config *config) = 0;
  
      ANGLE_NO_DISCARD bool getScratchBuffer(size_t requestedSizeBytes,
                                             angle::MemoryBuffer **scratchBufferOut) const;
      angle::ScratchBuffer *getScratchBuffer() const { return &mScratchBuffer; }
  
      void handleError(VkResult result,
                       const char *file,
                       const char *function,
                       unsigned int line) override;
  
      // TODO(jmadill): Remove this once refactor is done. http://anglebug.com/3041
      egl::Error getEGLError(EGLint errorCode);
  
      void populateFeatureList(angle::FeatureList *features) override;
  
      bool isRobustResourceInitEnabled() const override;
  
      ShareGroupImpl *createShareGroup() override;
  
    protected:
      void generateExtensions(egl::DisplayExtensions *outExtensions) const override;
  
    private:
      virtual SurfaceImpl *createWindowSurfaceVk(const egl::SurfaceState &state,
                                                 EGLNativeWindowType window) = 0;
      void generateCaps(egl::Caps *outCaps) const override;
  
      virtual angle::Result waitNativeImpl();
  
      mutable angle::ScratchBuffer mScratchBuffer;
  
      std::string mStoredErrorString;
      bool mHasSurfaceWithRobustInit;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_VULKAN_DISPLAYVK_H_
  

Download