kc3-lang/angle/src/libANGLE/renderer/vulkan/RenderbufferVk.cpp

• Show log

  Commit

• Hash : a76b6836
  Author :
  Date : 2020-09-17T22:40:42
  

  Vulkan: Support MSRTT depth/stencil resolve
  
  VK_KHR_depth_stencil_resolve is used by this change to resolve
  depth/stencil multisampled-render-to-texture renderbuffers.
  
  This extension is not widely supported yet.  If it's not present, the
  depth/stencil resolve operation is silently ignored and the renderbuffer
  acts as a normal multisampled one.  This is not correct, but our primary
  user (Chrome), and most applications don't care for the resolved
  depth/stencil data.  In fact, it's recommended for the depth/stencil
  attachment to be invalidated after rendering.
  
  Exposing EXT_multisampled_render_to_texture even in the absence of
  depth/stencil resolve allows the majority of the applications to still
  take advantage of MSRTT color attachments.
  
  Bug: angleproject:4836
  Change-Id: I6ba4187344a0c9330d2c77bdc5e2c6fc5483c299
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2417645
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Tim Van Patten <timvp@google.com>
  

Download

• src/libANGLE/renderer/vulkan/RenderbufferVk.cpp

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // RenderbufferVk.cpp:
  //    Implements the class methods for RenderbufferVk.
  //
  
  #include "libANGLE/renderer/vulkan/RenderbufferVk.h"
  
  #include "libANGLE/Context.h"
  #include "libANGLE/Image.h"
  #include "libANGLE/renderer/vulkan/ContextVk.h"
  #include "libANGLE/renderer/vulkan/ImageVk.h"
  #include "libANGLE/renderer/vulkan/RendererVk.h"
  
  namespace rx
  {
  namespace
  {
  angle::SubjectIndex kRenderbufferImageSubjectIndex = 0;
  }  // namespace
  
  RenderbufferVk::RenderbufferVk(const gl::RenderbufferState &state)
      : RenderbufferImpl(state),
        mOwnsImage(false),
        mImage(nullptr),
        mImageObserverBinding(this, kRenderbufferImageSubjectIndex)
  {}
  
  RenderbufferVk::~RenderbufferVk() {}
  
  void RenderbufferVk::onDestroy(const gl::Context *context)
  {
      ContextVk *contextVk = vk::GetImpl(context);
      releaseAndDeleteImage(contextVk);
  }
  
  angle::Result RenderbufferVk::setStorageImpl(const gl::Context *context,
                                               GLsizei samples,
                                               GLenum internalformat,
                                               GLsizei width,
                                               GLsizei height,
                                               gl::MultisamplingMode mode)
  {
      ContextVk *contextVk       = vk::GetImpl(context);
      RendererVk *renderer       = contextVk->getRenderer();
      const vk::Format &vkFormat = renderer->getFormat(internalformat);
  
      if (!mOwnsImage)
      {
          releaseAndDeleteImage(contextVk);
      }
  
      if (mImage != nullptr && mImage->valid())
      {
          // Check against the state if we need to recreate the storage.
          if (internalformat != mState.getFormat().info->internalFormat ||
              width != mState.getWidth() || height != mState.getHeight() ||
              samples != mState.getSamples() || mode != mState.getMultisamplingMode())
          {
              releaseImage(contextVk);
          }
      }
  
      if ((mImage != nullptr && mImage->valid()) || width == 0 || height == 0)
      {
          return angle::Result::Continue;
      }
  
      if (mImage == nullptr)
      {
          mImage     = new vk::ImageHelper();
          mOwnsImage = true;
          mImageObserverBinding.bind(mImage);
          mImageViews.init(renderer);
      }
  
      const angle::Format &textureFormat = vkFormat.actualImageFormat();
      const bool isDepthStencilFormat    = textureFormat.hasDepthOrStencilBits();
      ASSERT(textureFormat.redBits > 0 || isDepthStencilFormat);
  
      // TODO(syoussefi): Currently not supported for depth/stencil images if
      // VK_KHR_depth_stencil_resolve is not supported.  Chromium only uses this for depth/stencil
      // buffers and doesn't attempt to read from it.  http://anglebug.com/5065
      const bool isRenderToTexture =
          mode == gl::MultisamplingMode::MultisampledRenderToTexture &&
          (!isDepthStencilFormat || renderer->getFeatures().supportsDepthStencilResolve.enabled);
  
      const VkImageUsageFlags usage =
          VK_IMAGE_USAGE_TRANSFER_DST_BIT | VK_IMAGE_USAGE_TRANSFER_SRC_BIT |
          VK_IMAGE_USAGE_SAMPLED_BIT |
          (isDepthStencilFormat ? VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT
                                : VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) |
          (isRenderToTexture ? VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT : 0);
  
      const uint32_t imageSamples = isRenderToTexture ? 1 : samples;
  
      VkExtent3D extents = {static_cast<uint32_t>(width), static_cast<uint32_t>(height), 1u};
      ANGLE_TRY(mImage->init(contextVk, gl::TextureType::_2D, extents, vkFormat, imageSamples, usage,
                             gl::LevelIndex(0), gl::LevelIndex(0), 1, 1));
  
      VkMemoryPropertyFlags flags = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT;
      ANGLE_TRY(mImage->initMemory(contextVk, renderer->getMemoryProperties(), flags));
  
      // If multisampled render to texture, an implicit multisampled image is created which is used as
      // the color or depth/stencil attachment.  At the end of the render pass, this image is
      // automatically resolved into |mImage| and its contents are discarded.
      if (isRenderToTexture)
      {
          mMultisampledImageViews.init(renderer);
  
          ANGLE_TRY(mMultisampledImage.initImplicitMultisampledRenderToTexture(
              contextVk, renderer->getMemoryProperties(), gl::TextureType::_2D, samples, *mImage));
  
          mRenderTarget.init(&mMultisampledImage, &mMultisampledImageViews, mImage, &mImageViews,
                             gl::LevelIndex(0), 0, RenderTargetTransience::MultisampledTransient);
      }
      else
      {
          mRenderTarget.init(mImage, &mImageViews, nullptr, nullptr, gl::LevelIndex(0), 0,
                             RenderTargetTransience::Default);
      }
  
      return angle::Result::Continue;
  }
  
  angle::Result RenderbufferVk::setStorage(const gl::Context *context,
                                           GLenum internalformat,
                                           GLsizei width,
                                           GLsizei height)
  {
      return setStorageImpl(context, 1, internalformat, width, height,
                            gl::MultisamplingMode::Regular);
  }
  
  angle::Result RenderbufferVk::setStorageMultisample(const gl::Context *context,
                                                      GLsizei samples,
                                                      GLenum internalformat,
                                                      GLsizei width,
                                                      GLsizei height,
                                                      gl::MultisamplingMode mode)
  {
      return setStorageImpl(context, samples, internalformat, width, height, mode);
  }
  
  angle::Result RenderbufferVk::setStorageEGLImageTarget(const gl::Context *context,
                                                         egl::Image *image)
  {
      ContextVk *contextVk = vk::GetImpl(context);
      RendererVk *renderer = contextVk->getRenderer();
  
      releaseAndDeleteImage(contextVk);
  
      ImageVk *imageVk = vk::GetImpl(image);
      mImage           = imageVk->getImage();
      mOwnsImage       = false;
      mImageObserverBinding.bind(mImage);
      mImageViews.init(renderer);
  
      const vk::Format &vkFormat = renderer->getFormat(image->getFormat().info->sizedInternalFormat);
      const angle::Format &textureFormat = vkFormat.actualImageFormat();
  
      VkImageAspectFlags aspect = vk::GetFormatAspectFlags(textureFormat);
  
      // Transfer the image to this queue if needed
      uint32_t rendererQueueFamilyIndex = contextVk->getRenderer()->getQueueFamilyIndex();
      if (mImage->isQueueChangeNeccesary(rendererQueueFamilyIndex))
      {
          vk::CommandBuffer &commandBuffer = contextVk->getOutsideRenderPassCommandBuffer();
          mImage->changeLayoutAndQueue(aspect, vk::ImageLayout::ColorAttachment,
                                       rendererQueueFamilyIndex, &commandBuffer);
      }
  
      gl::TextureType viewType = imageVk->getImageTextureType();
  
      if (imageVk->getImageTextureType() == gl::TextureType::CubeMap)
      {
          viewType = vk::Get2DTextureType(imageVk->getImage()->getLayerCount(),
                                          imageVk->getImage()->getSamples());
      }
  
      mRenderTarget.init(mImage, &mImageViews, nullptr, nullptr, imageVk->getImageLevel(),
                         imageVk->getImageLayer(), RenderTargetTransience::Default);
  
      return angle::Result::Continue;
  }
  
  angle::Result RenderbufferVk::getAttachmentRenderTarget(const gl::Context *context,
                                                          GLenum binding,
                                                          const gl::ImageIndex &imageIndex,
                                                          GLsizei samples,
                                                          FramebufferAttachmentRenderTarget **rtOut)
  {
      ASSERT(mImage && mImage->valid());
      *rtOut = &mRenderTarget;
      return angle::Result::Continue;
  }
  
  angle::Result RenderbufferVk::initializeContents(const gl::Context *context,
                                                   const gl::ImageIndex &imageIndex)
  {
      // Note: stageSubresourceRobustClear only uses the intended format to count channels.
      mImage->stageRobustResourceClear(imageIndex);
      return mImage->flushAllStagedUpdates(vk::GetImpl(context));
  }
  
  void RenderbufferVk::releaseOwnershipOfImage(const gl::Context *context)
  {
      ContextVk *contextVk = vk::GetImpl(context);
  
      mOwnsImage = false;
      releaseAndDeleteImage(contextVk);
  }
  
  void RenderbufferVk::releaseAndDeleteImage(ContextVk *contextVk)
  {
      releaseImage(contextVk);
      SafeDelete(mImage);
      mImageObserverBinding.bind(nullptr);
  }
  
  void RenderbufferVk::releaseImage(ContextVk *contextVk)
  {
      RendererVk *renderer = contextVk->getRenderer();
  
      if (mImage && mOwnsImage)
      {
          mImage->releaseImage(renderer);
          mImage->releaseStagingBuffer(renderer);
      }
      else
      {
          mImage = nullptr;
          mImageObserverBinding.bind(nullptr);
      }
  
      mImageViews.release(renderer);
  
      if (mMultisampledImage.valid())
      {
          mMultisampledImage.releaseImage(renderer);
      }
      mMultisampledImageViews.release(renderer);
  }
  
  const gl::InternalFormat &RenderbufferVk::getImplementationSizedFormat() const
  {
      GLenum internalFormat = mImage->getFormat().actualImageFormat().glInternalFormat;
      return gl::GetSizedInternalFormatInfo(internalFormat);
  }
  
  GLenum RenderbufferVk::getColorReadFormat(const gl::Context *context)
  {
      const gl::InternalFormat &sizedFormat = getImplementationSizedFormat();
      return sizedFormat.format;
  }
  
  GLenum RenderbufferVk::getColorReadType(const gl::Context *context)
  {
      const gl::InternalFormat &sizedFormat = getImplementationSizedFormat();
      return sizedFormat.type;
  }
  
  angle::Result RenderbufferVk::getRenderbufferImage(const gl::Context *context,
                                                     const gl::PixelPackState &packState,
                                                     gl::Buffer *packBuffer,
                                                     GLenum format,
                                                     GLenum type,
                                                     void *pixels)
  {
      // Storage not defined.
      if (!mImage || !mImage->valid())
      {
          return angle::Result::Continue;
      }
  
      ContextVk *contextVk = vk::GetImpl(context);
      ANGLE_TRY(mImage->flushAllStagedUpdates(contextVk));
  
      gl::MaybeOverrideLuminance(format, type, getColorReadFormat(context),
                                 getColorReadType(context));
  
      return mImage->readPixelsForGetImage(contextVk, packState, packBuffer, gl::LevelIndex(0), 0,
                                           format, type, pixels);
  }
  
  void RenderbufferVk::onSubjectStateChange(angle::SubjectIndex index, angle::SubjectMessage message)
  {
      ASSERT(index == kRenderbufferImageSubjectIndex &&
             message == angle::SubjectMessage::SubjectChanged);
  
      // Forward the notification to the parent class that the staging buffer changed.
      onStateChange(angle::SubjectMessage::SubjectChanged);
  }
  }  // namespace rx
  

Download