-
Show log
Commit
-
Hash : 1434697f
Author :
Date : 2022-11-23T14:47:38
Add a vk feature flag to only enable precision match fixer on IMG According to https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/5273, RelaxedPrecision does not need to match in the interface matching rules. However, removing the precision match is causing triangle clipping issues on IMG hardware. This change adds a feature flag to only run the code path that applies precision match in SpirV if the hardware is IMG. This is a follow-up change to https://crrev.com/c/4049421. Instead of adding back the code path that handles varying precision mismatch for every hardware, only enabling the code path if the vendor is IMG. Test: On Pixel6: $ adb shell setprop debug.angle.feature_overrides_enabled varyingsRequireMatchingPrecisionInSpirv $ out/AndroidDebug/angle_end2end_tests --gtest_filter="GLSLTest_ES3.MismatchPrecision*" --verbose Bug: angleproject:7488 Change-Id: Ia0155f14d523195df2f47b852ed6642918270e2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4054100 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
-
Files
- BUILD.gn
- EGLPlatformParameters.h
- EGLWindow.cpp
- EGLWindow.h
- Event.h
- Matrix.cpp
- Matrix.h
- OSPixmap.h
- OSWindow.cpp
- OSWindow.h
- Timer.cpp
- Timer.h
- android/
- angle_features_autogen.cpp
- angle_features_autogen.h
- capture/
- com_utils.h
- display/
- egl_loader_autogen.cpp
- egl_loader_autogen.h
- fuchsia/
- geometry_utils.cpp
- geometry_utils.h
- gles_loader_autogen.cpp
- gles_loader_autogen.h
- ios/
- keyboard.h
- linux/
- mouse.h
- osx/
- ozone/
- png_utils.cpp
- png_utils.h
- posix/
- random_utils.cpp
- random_utils.h
- shader_utils.cpp
- shader_utils.h
- test_utils.cpp
- test_utils.h
- test_utils_unittest.cpp
- test_utils_unittest_helper.cpp
- test_utils_unittest_helper.h
- util_export.h
- util_gl.h
- windows/
