-
Show log
Commit
-
Hash : 18fa02be
Author :
Date : 2024-03-12T10:23:55
Rewrite exprs using separated decl variables Rewrite expressions that use the rewritten struct declaration variables. Declaration that specfies a struct and defines multiple variables will get its variable declarations separated. The type of the variable changes when a struct specifier is removed for the second and rest of the variable declarations. The type of the variable changes also when a anonymous struct is named. The expressions that used the separated variables used the old struct as their types. Fix by using TIntermRebuild. Upon creating a new symbol node referencing the new type, the rebuilder will instantiate also all the needed intermediate nodes, which then get the correct struct type. For consistency, fix the case of anonymous struct -> named struct transform naming the variables similar to named struct separation. Consider base case: struct S { .. } a, b; -> struct S { .. } a; S b; Compare against case: struct { .. } a, b; Before, inconsistency: struct s1 { .. }; s1 a; s1 b; After, fixed: struct s1 { .. } a; s1 b; Bug: angleproject:8590 Change-Id: Iffb0ef4441d6021e076b04485b808b26a7fa4dcb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5365201 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- AddExplicitTypeCasts.cpp
- AddExplicitTypeCasts.h
- ConvertUnsupportedConstructorsToFunctionCalls.cpp
- ConvertUnsupportedConstructorsToFunctionCalls.h
- FixTypeConstructors.cpp
- FixTypeConstructors.h
- GuardFragDepthWrite.cpp
- GuardFragDepthWrite.h
- HoistConstants.cpp
- HoistConstants.h
- IntroduceVertexIndexID.cpp
- IntroduceVertexIndexID.h
- NameEmbeddedUniformStructsMetal.cpp
- NameEmbeddedUniformStructsMetal.h
- ReduceInterfaceBlocks.cpp
- ReduceInterfaceBlocks.h
- RewriteCaseDeclarations.cpp
- RewriteCaseDeclarations.h
- RewriteInterpolants.cpp
- RewriteInterpolants.h
- RewriteOutArgs.cpp
- RewriteOutArgs.h
- RewriteUnaddressableReferences.cpp
- RewriteUnaddressableReferences.h
- SeparateCompoundExpressions.cpp
- SeparateCompoundExpressions.h
- SeparateCompoundStructDeclarations.cpp
- SeparateCompoundStructDeclarations.h
- TransposeRowMajorMatrices.cpp
- TransposeRowMajorMatrices.h
- WrapMain.cpp
- WrapMain.h
