• Show log

    Commit

  • Hash : eb1cb31d
    Author : Igor Nazarov
    Date : 2023-02-21T14:09:49

    Vulkan: Remove code left after introduce of "vk::SharedGarbage"
    
    This logic calls "flushImpl()" each time some "ImageVk" is orphaned,
    regardless if it used in the RenderPass or not. Such undesired flushes
    negatively affect CPU and GPU performance.
    
    This flush was added in the very old commit:
        e755a5374f7eb24da579fdc9862b01e3c3c04721
        Vulkan: Add a new garbage type gated by fences.
    
    Flush was necessary to grab a proper Fence.
    
    However, after commit:
        f10bf6bf55a78669bff7bb5cdd3ae0954a87661e
        Vulkan: Implement multi-threaded GL.
    
    Fence was replaced by "vk::SharedGarbage" and "vk::SharedResourceUse".
    But "flushImpl()" was not removed along with misleading comment, that
    it is necessary "to make sure the fence has been submitted".
    
    This CL removes this leftover code. Any regressions should be fixed in
    a better way.
    
    Bug: angleproject:2464
    Change-Id: I640bb2b9519c15a47adf30e0de845a3125ceab42
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4272834
    Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
    Reviewed-by: Geoff Lang <geofflang@chromium.org>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags