kc3-lang/angle/src/libANGLE/renderer/metal/mtl_context_device.h

• Show log

  Commit

• Hash : aea88562
  Author :
  Date : 2023-05-19T16:52:43
  

  Reland "Metal: Optimized BufferSubData per device"
  
  This reverts commit ee64836f702332adaca58d9f452063a04b2da955 ,
  relanding the patch stack described there.
  
  Between patchsets 1 and 5:
  
  - The shadow buffer allocation has been replaced with a multimap of
    precisely-sized buffers, rather than rounding up buffer sizes.
  
  - Garbage collection of shadow buffers is triggered in three situations:
  
    - A certain number of context switches have occurred; this number
      was hand-tuned to avoid GC every frame.
  
    - A certain number of command buffer submissions has occurred; this
      number was hand-tuned to GC no more often than every few seconds
      on representative workloads.
  
    - The total size of the allocated shadow buffers is more than 1 MB,
      and either more than twice the size at the last garbage
      collection, or 64 MB more than at the last garbage collection. In
      this case, aggressive GC is performed in order to reclaim shadow
      buffers more quickly.
  
  Performance before and after these changes appears identical on
  microbenchmarks. On one Figma test case, comparing GPU memory
  allocated inside the BufferManager, peak consumption is decreased by
  over 75%, and steady-state consumption decreases by over 88%.
  
  Patchset 6 adds a needed workaround for a bug in the
  AMDMTLBronzeDriver affecting uploads of client-side data, and
  therefore some dEQP tests. It also streamlines the aggressive GC.
  
  Bug: angleproject:7544
  Change-Id: I81b061f0b33c27fa403527fa12d626f4e9c88ebe
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4497413
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Commit-Queue: Geoff Lang <geofflang@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/libANGLE/renderer/metal/mtl_context_device.h

• //
  // Copyright 2021 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // mtl_device.h:
  //    Defines the wrapper class for Metal's MTLDevice per context.
  //
  
  #ifndef LIBANGLE_RENDERER_METAL_CONTEXT_DEVICE_H_
  #define LIBANGLE_RENDERER_METAL_CONTEXT_DEVICE_H_
  
  #import <Metal/Metal.h>
  #import <mach/mach_types.h>
  
  #include "common/apple/apple_platform.h"
  #include "libANGLE/renderer/metal/mtl_common.h"
  
  namespace rx
  {
  namespace mtl
  {
  
  class ContextDevice final : public WrappedObject<id<MTLDevice>>, angle::NonCopyable
  {
    public:
      ContextDevice(GLint ownershipIdentity);
      ~ContextDevice();
      inline void set(id<MTLDevice> metalDevice) { ParentClass::set(metalDevice); }
  
      AutoObjCPtr<id<MTLSamplerState>> newSamplerStateWithDescriptor(
          MTLSamplerDescriptor *descriptor) const;
  
      AutoObjCPtr<id<MTLTexture>> newTextureWithDescriptor(MTLTextureDescriptor *descriptor) const;
      AutoObjCPtr<id<MTLTexture>> newTextureWithDescriptor(MTLTextureDescriptor *descriptor,
                                                           IOSurfaceRef iosurface,
                                                           NSUInteger plane) const;
  
      AutoObjCPtr<id<MTLBuffer>> newBufferWithLength(NSUInteger length,
                                                     MTLResourceOptions options) const;
      AutoObjCPtr<id<MTLBuffer>> newBufferWithBytes(const void *pointer,
                                                    NSUInteger length,
                                                    MTLResourceOptions options) const;
  
      AutoObjCPtr<id<MTLComputePipelineState>> newComputePipelineStateWithFunction(
          id<MTLFunction> computeFunction,
          __autoreleasing NSError **error) const;
      AutoObjCPtr<id<MTLRenderPipelineState>> newRenderPipelineStateWithDescriptor(
          MTLRenderPipelineDescriptor *descriptor,
          __autoreleasing NSError **error) const;
  
      AutoObjCPtr<id<MTLLibrary>> newLibraryWithSource(NSString *source,
                                                       MTLCompileOptions *options,
                                                       __autoreleasing NSError **error) const;
  
      AutoObjCPtr<id<MTLLibrary>> newLibraryWithData(dispatch_data_t data,
                                                     __autoreleasing NSError **error) const;
  
      AutoObjCPtr<id<MTLDepthStencilState>> newDepthStencilStateWithDescriptor(
          MTLDepthStencilDescriptor *descriptor) const;
  
      AutoObjCPtr<id<MTLSharedEvent>> newSharedEvent() const;
  
      void setOwnerWithIdentity(id<MTLResource> resource) const;
      bool hasUnifiedMemory() const;
  
    private:
      using ParentClass = WrappedObject<id<MTLDevice>>;
  
  #if ANGLE_USE_METAL_OWNERSHIP_IDENTITY
      task_id_token_t mOwnershipIdentity = TASK_ID_TOKEN_NULL;
  #endif
  };
  
  }  // namespace mtl
  }  // namespace rx
  
  #endif /* LIBANGLE_RENDERER_METAL_CONTEXT_DEVICE_H_ */
  

Download