Hash :
d8b037d6
Author :
Date :
2020-09-15T05:05:14
Change renderbuffer width/height/sample types to GLsizei This matches the types used by GL and stored in the state. setStorage and setStorageMultisampled calls were using size_t instead with a number of unnecessary casts in places which are now removed. Bug: angleproject:4836 Change-Id: Ibb570f0c088a6f29abe10f513de27c30ba4dd098 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411697 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98
//
// Copyright 2014 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// RenderbufferImpl.h: Defines the abstract class gl::RenderbufferImpl
#ifndef LIBANGLE_RENDERER_RENDERBUFFERIMPL_H_
#define LIBANGLE_RENDERER_RENDERBUFFERIMPL_H_
#include "angle_gl.h"
#include "common/angleutils.h"
#include "libANGLE/Error.h"
#include "libANGLE/angletypes.h"
#include "libANGLE/renderer/FramebufferAttachmentObjectImpl.h"
namespace gl
{
struct PixelPackState;
class RenderbufferState;
} // namespace gl
namespace egl
{
class Image;
} // namespace egl
namespace rx
{
class RenderbufferImpl : public FramebufferAttachmentObjectImpl
{
public:
RenderbufferImpl(const gl::RenderbufferState &state) : mState(state) {}
~RenderbufferImpl() override {}
virtual void onDestroy(const gl::Context *context) {}
virtual angle::Result setStorage(const gl::Context *context,
GLenum internalformat,
GLsizei width,
GLsizei height) = 0;
virtual angle::Result setStorageMultisample(const gl::Context *context,
GLsizei samples,
GLenum internalformat,
GLsizei width,
GLsizei height,
gl::MultisamplingMode mode) = 0;
virtual angle::Result setStorageEGLImageTarget(const gl::Context *context,
egl::Image *image) = 0;
virtual GLenum getColorReadFormat(const gl::Context *context);
virtual GLenum getColorReadType(const gl::Context *context);
virtual angle::Result getRenderbufferImage(const gl::Context *context,
const gl::PixelPackState &packState,
gl::Buffer *packBuffer,
GLenum format,
GLenum type,
void *pixels);
// Override if accurate native memory size information is available
virtual GLint getMemorySize() const;
protected:
const gl::RenderbufferState &mState;
};
inline GLint RenderbufferImpl::getMemorySize() const
{
return 0;
}
inline GLenum RenderbufferImpl::getColorReadFormat(const gl::Context *context)
{
UNREACHABLE();
return GL_NONE;
}
inline GLenum RenderbufferImpl::getColorReadType(const gl::Context *context)
{
UNREACHABLE();
return GL_NONE;
}
inline angle::Result RenderbufferImpl::getRenderbufferImage(const gl::Context *context,
const gl::PixelPackState &packState,
gl::Buffer *packBuffer,
GLenum format,
GLenum type,
void *pixels)
{
UNREACHABLE();
return angle::Result::Stop;
}
} // namespace rx
#endif // LIBANGLE_RENDERER_RENDERBUFFERIMPL_H_