Log

Author Commit Date CI Message
Michiharu Ariza c48f53d3 2018-12-03T16:59:41 more double changes
Michiharu Ariza 9424e805 2018-12-03T16:18:10 added minimized test cases
Michiharu Ariza 5fff6ab0 2018-12-03T16:06:58 additional precision made a difference in extents test
Michiharu Ariza 9e5180cd 2018-12-03T15:32:42 more double changes
Michiharu Ariza 9af33d7a 2018-12-03T14:48:46 Number to use double for all types
Behdad Esfahbod 84efe043 2018-12-02T12:38:53 [aat] Fix division sign fallout Happened after 11d2f49af8f53340134c844173f4d8655b00dea3 since now nClasses is unsigned int...
Behdad Esfahbod 2087f5a2 2018-12-01T20:04:45 Add casts to hb_array_t<>
Behdad Esfahbod 58d4d199 2018-12-01T19:34:18 Simplify build source list
Behdad Esfahbod 967a204e 2018-12-01T19:28:17 Minor
Behdad Esfahbod 11d2f49a 2018-12-01T13:12:21 New approach to change BigEndian casts to be int-sized Fixes spurious warnings like: Fixes https://github.com/harfbuzz/harfbuzz/issues/1436
Behdad Esfahbod 50e0273a 2018-12-01T13:03:52 Change hb_assert_unsigned_t<> to hb_is_signed<>
Behdad Esfahbod c3a8b047 2018-12-01T00:14:48 Revert "Change BigEndian casts to be int-sized" This reverts commit eb5ddd32bf4e458ca0af8d5784f8fd46485ad225. Broke tests, badly. To be investigated and reenabled.
Behdad Esfahbod be45677a 2018-12-01T00:04:29 Minor
Behdad Esfahbod eb5ddd32 2018-12-01T00:03:01 Change BigEndian casts to be int-sized Fixes spurious warnings like: Fixes https://github.com/harfbuzz/harfbuzz/issues/1436
Behdad Esfahbod e8860fdc 2018-11-30T23:38:24 Fix more warning
Behdad Esfahbod af349ee3 2018-11-30T23:20:50 Fix warning
Behdad Esfahbod 825df6db 2018-11-30T23:04:59 [CFF] Change spaces to tabs
Behdad Esfahbod 592f39b3 2018-11-30T22:54:57 [CFF] Whitespace
Behdad Esfahbod a2e8d1d4 2018-11-30T22:54:20 Minor
Behdad Esfahbod e3dc47c6 2018-11-30T22:43:22 Remove generated files that were accidentally added by CFF2 branch
Behdad Esfahbod 5e64e0f5 2018-11-30T22:40:54 Merge pull request #1113 from harfbuzz/cff-subset CFF/CFF2 subsetter
Bruce Mitchener 09096aa8 2018-12-01T10:22:49 Use nullptr instead of 0/NULL. (#1435) * Use nullptr instead of 0/NULL. * Update test-name-table.cc
Michiharu Ariza d8c69137 2018-11-30T18:58:14 undo 0u
Michiharu Ariza 2c859b38 2018-11-30T18:47:34 Merge branch 'master' into cff-subset
Behdad Esfahbod bb72de66 2018-11-30T21:36:35 Merge pull request #1433 from harfbuzz/overload-overload Fix ambiguous overload errors with old compilers
Behdad Esfahbod fb059082 2018-11-30T20:45:40 Revert ugly fixes Now that we have 6daf45e0, revert cryptic hacks... This reverts commit abd81ed4f5cbc5a94171747909bc6b77551cb929. This reverts commit 9c6921c08c905a0cf45ba0182134e6ff910fac51. This reverts commit d39760cabfe4007cefdfc45231e85e93fababac2. This reverts commit fedd8e6c176dea85194693399e50243eb1c117c4. Fixes https://github.com/harfbuzz/harfbuzz/issues/1374
Behdad Esfahbod dfad19ad 2018-11-30T19:57:12 Make operator [] take signed int The built-in operator takes signed int. So, match it, such that the built-in is never a better or equally-good match to our operator. Fixes "ambiguous overload" errors from gcc 4.2 and VS 2008. See https://github.com/harfbuzz/harfbuzz/issues/1374
Michiharu Ariza 9483da14 2018-11-30T16:59:41 redo fixes
Michiharu Ariza 291da448 2018-11-30T16:50:46 yet another
Michiharu Ariza b1821b9d 2018-11-30T16:31:01 some more
Michiharu Ariza 9784cff5 2018-11-30T16:07:08 fix another pesky gcc error
Michiharu Ariza 23a797b4 2018-11-30T15:15:31 silence picky gcc errors
Michiharu Ariza 9ae954f4 2018-11-30T15:00:52 Merge branch 'master' into cff-subset
Behdad Esfahbod fedd8e6c 2018-11-30T16:50:30 One more......... I wonder if there's something better to do about these :(. In file included from hb-ot-color.cc:31: hb-ot-color-cpal-table.hh: In member function 'unsigned int OT::CPAL::get_size() const': hb-ot-color-cpal-table.hh:118: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
Behdad Esfahbod bc5db9b0 2018-11-30T16:04:52 One more.... hb-ot-vorg-table.hh:96: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: hb-vector.hh:87: note: candidate 1: const Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) const [with Type = OT::VertOriginMetric, unsigned int PreallocedCount = 8u] hb-ot-vorg-table.hh:96: note: candidate 2: operator[](const T*, int) <built-in>
Behdad Esfahbod d39760ca 2018-11-30T15:55:30 One more... Sigh. hb-ot-kern-table.hh: In member function 'int OT::KernSubTableFormat3<KernSubTableHeader>::get_kerning(hb_codepoint_t, hb_codepoint_t) const': hb-ot-kern-table.hh:59: error: ambiguous overload for 'operator[]' in 'kernValue[kernIndex[i]]' hb-ot-kern-table.hh:59: note: candidates are: operator[](T*, int) <built-in> hb-dsalgs.hh:574: note: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::IntType<short int, 2u>]
Behdad Esfahbod 9c6921c0 2018-11-30T15:16:57 More... hb-ot-layout-gsubgpos.hh:1707: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: ...
Behdad Esfahbod f998bb20 2018-11-30T12:52:21 More weird fixes In file included from hb-ot-name.cc:29: hb-ot-name-table.hh: In member function 'unsigned int OT::name::get_size() const': hb-ot-name-table.hh:157: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: hb-open-type.hh:354: note: candidate 1: const Type& OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type = OT::NameRecord] hb-ot-name-table.hh:157: note: candidate 2: operator[](const T*, int) <built-in> hb-ot-name-table.hh: In member function 'void OT::name::accelerator_t::init(hb_face_t*)': hb-ot-name-table.hh:196: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: hb-dsalgs.hh:574: note: candidate 1: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::NameRecord] hb-ot-name-table.hh:196: note: candidate 2: operator[](T*, int) <built-in> hb-ot-name-table.hh:197: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: hb-dsalgs.hh:574: note: candidate 1: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::NameRecord] hb-ot-name-table.hh:197: note: candidate 2: operator[](T*, int) <built-in> hb-ot-name-table.hh:198: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: hb-dsalgs.hh:574: note: candidate 1: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::NameRecord] hb-ot-name-table.hh:198: note: candidate 2: operator[](T*, int) <built-in> make[4]: *** [libharfbuzz_la-hb-ot-name.lo] Error 1 make[3]: *** [all-recursive] Error 1
Behdad Esfahbod 67fd94da 2018-11-30T11:53:30 Merge commit 'ae79fdaa7774d3f886a8f03926577c3bd2010b03'
Behdad Esfahbod abd81ed4 2018-11-30T11:51:26 Umm. Cryptic, yes In file included from hb-face.cc:35: hb-ot-cmap-table.hh: In member function 'void OT::CmapSubtableFormat4::_compiles_assertion_on_line_388() const': hb-ot-cmap-table.hh:388: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: hb-open-type.hh:354: note: candidate 1: const Type& OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type = OT::IntType<short unsigned int, 2u>] hb-ot-cmap-table.hh:388: note: candidate 2: operator[](const T*, int) <built-in> hb-ot-cmap-table.hh: In member function 'void OT::CmapSubtableFormat4::_instance_assertion_on_line_388() const': hb-ot-cmap-table.hh:388: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: hb-open-type.hh:354: note: candidate 1: const Type& OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type = OT::IntType<short unsigned int, 2u>] hb-ot-cmap-table.hh:388: note: candidate 2: operator[](const T*, int) <built-in> hb-face.cc: In function 'hb_blob_t* _hb_face_builder_data_reference_blob(hb_face_builder_data_t*)': hb-face.cc:650: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u] hb-face.cc:650: note: candidate 2: operator[](T*, int) <built-in> hb-face.cc:650: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u] hb-face.cc:650: note: candidate 2: operator[](const T*, int) <built-in> hb-face.cc:651: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u] hb-face.cc:651: note: candidate 2: operator[](T*, int) <built-in> hb-face.cc:651: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u] hb-face.cc:651: note: candidate 2: operator[](const T*, int) <built-in>
Behdad Esfahbod ae79fdaa 2018-11-30T11:51:26 Umm. Cryptic, yes hb-face.cc:650: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u] hb-face.cc:650: note: candidate 2: operator[](T*, int) <built-in>
Behdad Esfahbod 0f32c95e 2018-11-30T11:31:39 Fix a few more sizeof(vector[0]) errors with weird compilers
Behdad Esfahbod 88630a45 2018-11-30T01:11:04 Fix build for realz
Behdad Esfahbod 346286d0 2018-11-30T00:44:40 Fix build
Behdad Esfahbod 31f39cb4 2018-11-30T00:38:08 [post] Rename v2 to v2X
Behdad Esfahbod e3dd47e6 2018-11-30T00:32:12 Move things
Behdad Esfahbod 27a6b0a2 2018-11-29T16:29:30 Fix build for realz
Behdad Esfahbod e2af4dd1 2018-11-29T16:03:15 [uniscribe] Fix build
Ebrahim Byagowi bf738ba3 2018-11-30T00:06:40 [test][aat] Remove extra --shaper ot As run-tests.py already adds it
Ebrahim Byagowi b65645bb 2018-11-29T23:57:50 [ci] Re-enable llvm-gcc-4.2 bots (#1429)
Ebrahim Byagowi e7bd29ea 2018-11-29T23:47:20 Limit __builtin_bswap16 to GCC >= 5 as it was implemented on 4.8
Behdad Esfahbod ac026471 2018-11-29T15:07:44 [coretext] Fix compile Fingers crossed.
Behdad Esfahbod 5c4fead7 2018-11-29T15:04:34 Convert "static const hb_tag_t" constants to enum
Behdad Esfahbod 9e4138c8 2018-11-29T15:01:10 Convert misc "static const" constants to enum
Behdad Esfahbod 44cbd2ea 2018-11-29T14:53:43 Convert "static const bool" constants to anonymous enum
Behdad Esfahbod 861bc753 2018-11-29T14:34:44 [vector] Make pointer cast explicit Too bad this doesn't help MSVC 2008 build, as explicit operators are C++11.
Behdad Esfahbod 72955e68 2018-11-29T14:28:44 Hand-hold older compilers
Behdad Esfahbod 1a182e97 2018-11-29T12:39:52 [test/text-rendering-tests] Update from upstream
Behdad Esfahbod 000d4b12 2018-11-29T12:32:47 Make shaper's override_features() override user features as well The override_features is used to override features that are normally discretionary features, but in a specific shaper are for various reasons desired to be bolted on or off, because they've been used for inherent shaping. As such, it makes sense that they also override user features. Ie. if user turned 'liga' on, we don't want Khmer shaping to become broken... Or turn 'clig' off... Fixes https://github.com/harfbuzz/harfbuzz/issues/1310
Behdad Esfahbod a95d9d8c 2018-11-29T12:30:14 [khmer] Move 'clig' to overrides Prerequisite for https://github.com/harfbuzz/harfbuzz/issues/1310
Behdad Esfahbod 282ce723 2018-11-29T12:18:14 Fix "typename outside template" issues Nothing an extra template class wouldn't fix... Fixes https://github.com/harfbuzz/harfbuzz/issues/1419
Behdad Esfahbod dc41ecef 2018-11-29T11:53:53 2.2.0
Behdad Esfahbod 7b85081b 2018-11-29T11:34:22 [icu] Minor
Behdad Esfahbod 0bcb1de1 2018-11-29T10:39:18 Merge pull request #1418 from gvictor/replace_icu_deprecated Replace @Deprecated ICU API - USCRIPT_CODE_LIMIT
Ebrahim Byagowi e0307de8 2018-11-29T11:36:05 [test][aat.kern] More (#1427)
Michiharu Ariza 471db3aa 2018-11-28T17:06:11 workaround for issue #1417
Michiharu Ariza 32d291ae 2018-11-28T16:27:45 Merge branch 'master' into cff-subset
Behdad Esfahbod 949655aa 2018-11-28T17:21:57 Merge pull request #1425 from mbutterick/patch-1 update simple shaping example (closes #298)
Matthew Butterick d3d0f15f 2018-11-28T13:46:12 update simple shaping example (closes #298) add call to `FT_Set_Char_Size`, otherwise default size remains at `0`, and glyph positions come back as `0` too
Ebrahim Byagowi 7b78d223 2018-11-29T00:55:05 [test][aat] Update expectency It is not visually noticeable but apparently affected by kern format2 correct implementation. I should've checked CoreText result which can't as CircleCI outage.
Ebrahim Byagowi 5155067e 2018-11-29T00:07:00 [test] Add test for format2 kern (#1423)
Behdad Esfahbod 42a2b496 2018-11-28T15:24:30 [kerx] Fix Format2 index calc again
Behdad Esfahbod 9e4f03b6 2018-11-28T15:08:01 Merge remote-tracking branch 'fdo/master'
Behdad Esfahbod a3267cf8 2018-11-28T15:06:01 [kern] Fix kern table Format2 offsetToIndex Fixes https://github.com/harfbuzz/harfbuzz/issues/1421
Behdad Esfahbod f9a9c0fd 2018-11-28T14:51:56 [kerx] Fix ClassTable implementation for 'kern' table Format 2
Behdad Esfahbod 5b4a789c 2018-11-28T14:46:26 [aat] Towards adding two ClassTable's
Ebrahim Byagowi 19863c80 2018-11-28T20:28:42 [test][aat] Add a test and make macOS runners faster (#1422)
Behdad Esfahbod 987f4187 2018-11-27T17:40:32 Merge pull request #1398 from Adenilson/bigInt01 Optimize harfbuzz big integer conversions
Behdad Esfahbod 4e2a03b6 2018-11-27T17:40:09 Comment
Adenilson Cavalcanti 4a719a7f 2018-11-20T14:41:19 Optimize harfbuzz big integer conversions Profiling showed that type conversions were adding considerable cycles in time spent doing text shaping. The idea is to optimize it using native processor instructions to help Blink layout performance. Doing further investigation revelead that compilers may not use the proper instruction on ARM 32bits builds (i.e. REV16). One way to insure that the generated ASM was ideal for both gcc/clang was using __builtin_bswap16. Added bonus is that we no longer need to test for CPU architecture.
Victor Chang a85886fc 2018-11-27T11:34:56 Replace @Deprecated ICU API - USCRIPT_CODE_LIMIT Use of the deprecated API USCRIPT_CODE_LIMIT prevents harfbuzz using the ICU4C as a shared library. The API has been replaced by u_getIntPropertyMaxValue(UCHAR_SCRIPT)
Ebrahim Byagowi 1042d9fb 2018-11-26T18:58:39 [ci] Add .codecov.yml Similar to https://github.com/GoogleChrome/lighthouse/blob/master/.codecov.yml No strong preference on commenting, feel free to enable it again
Ebrahim Byagowi 97eaedca 2018-11-26T16:58:58 [test][aat] Enable Tamil MN test (#1414)
Behdad Esfahbod 574d888c 2018-11-25T16:51:22 [aat] Ignore GSUB table of Muthu Foundry if they have morx table Fixes https://github.com/harfbuzz/harfbuzz/issues/1410
Behdad Esfahbod 4151c284 2018-11-25T16:38:36 [GDEF] Move more code
Behdad Esfahbod 4f21703f 2018-11-25T15:59:18 [GDEF] Move code around
Behdad Esfahbod 4ed9fb1a 2018-11-25T15:51:01 [GDEF] Minor
Ebrahim Byagowi 0e3a48e5 2018-11-25T13:37:23 [test][aat] fix 10.13.6 Helvetica expectation
Ebrahim Byagowi cbc541b4 2018-11-25T12:50:30 [aat] Add m grave test (#1412)
Ebrahim Byagowi fa26ad0f 2018-11-25T11:25:17 [aat] Fix macos expectation
Behdad Esfahbod 926f512f 2018-11-25T01:14:40 [aat.feat] Rework API and implementation Fixes https://github.com/harfbuzz/harfbuzz/pull/1346
Behdad Esfahbod 84dacbca 2018-11-24T12:08:36 [aat.feat] Add _MAX_VALUE to enums
Behdad Esfahbod 3922aae1 2018-11-24T11:02:04 [aat.feat] Minor
Behdad Esfahbod 0f8e98ec 2018-11-24T11:00:42 [aat.feat] Whitespace
Behdad Esfahbod c2256068 2018-11-24T10:54:40 [aat.feat] Port to SortedUnsizedArrayOf.bsearch()
Behdad Esfahbod 52ae9867 2018-11-24T10:46:56 [AAT.feat] Use lsearch for looking up SettingName's They are not sorted.
Behdad Esfahbod 44b9331f 2018-11-24T10:30:35 [aat] Fix include issues
Behdad Esfahbod b206133d 2018-11-23T14:05:11 [aat] Move contents of hb-aat.h to hb-aat-layout.h Since it was pages and pages...
Behdad Esfahbod 2cb235d0 2018-11-23T12:23:35 [aat.feat] Fix enum namespace
Behdad Esfahbod 712762ca 2018-11-23T12:21:02 Minor