kmx git

Commit	Date	Message
d6e88352	2024-04-10T17:45:03	Fix potential Null pointer dereference in regress_et.c
d45dca43	2024-04-10T17:39:36	Fix potential Null pointer dereference in regress_thread.c
2bdf1737	2024-04-10T16:18:27	Fix potential Null pointer dereference in regress_finalize.c
17796a2d	2024-04-10T15:32:54	Fix potential Null pointer dereference in regress_http.c
f9526e13	2024-04-10T15:16:21	Fix potential NULL pointer dereference in regress_bufferevent.c
fc48803d	2024-04-15T15:02:27	Fix potential Null pointer dereference in regress_zlib.c (#1597) Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
c6e8f175	2024-04-07T19:37:55	Edit logo path to match new website directory
39073df8	2024-03-30T21:44:50	evutil: don't call memset before memcpy In `evutil_parse_sockaddr_port`, it would `memset` the `out` to zero, however, the `memset` is unnecessary before `memcpy`, and may cause undefined behavior if the `outlen` is invalid. This should close #1573.
4fd07f0e	2024-03-12T21:56:35	Upgrade vmactions to use linux runners (#1570) Co-authored-by: neil <neilgit@neilpang.com>
539f73e3	2024-02-20T09:30:22	Fix leak in evbuffer_add_file() on empty files Found by oss-fuzz, after coverage had been improved in google/oss-fuzz#11257 v2: adjust test v3: fix for windows (_get_osfhandle() crashes when called on closed fd) v4: fix for EVENT__DISABLE_MM_REPLACEMENT
b9e1fe74	2024-03-11T21:00:18	ci: disable netbsd and freebsd due to lack of runners For example for openbsd-cmake-job (7.2, NONE) This request was automatically failed because there were no enabled runners online to process the request for more than 1 days. And maybe this will fix the macos builds.
0054b9aa	2024-03-11T17:12:14	Enable the full TCP KeepAlive mechanism on Windows (#1568) #1532 implemented the full support of TCP Keep-Alives on UNIX-like OS's while leaving a `TODO` for Windows. This PR intends to resolve that `TODO`. ## References - [SIO_KEEPALIVE_VALS Control Code](https://learn.microsoft.com/en-us/windows/win32/winsock/sio-keepalive-vals) - [IPPROTO_TCP socket options](https://learn.microsoft.com/en-us/windows/win32/winsock/ipproto-tcp-socket-options) - [TCP_KEEPINVTL and TCP_KEEPIDLE - Socket Keep Alives not working](https://cygwin.com/pipermail/cygwin/2020-June/245436.html) - [Cygwin: tcp: Support TCP_KEEPIDLE, TCP_KEEPCNT, TCP_KEEPINTVL](https://sourceware.org/pipermail/cygwin-cvs/2020q3/014473.html) - [Add cross-platform support for keep-alive socket options](https://github.com/dotnet/corefx/pull/29963/files)
9c8860ec	2024-03-11T15:50:43	chore: remove repetitive words Signed-off-by: tgolang <seekseat@aliyun.com>
e66df92c	2024-03-07T16:19:11	Accept SOCK_NONBLOCK/SOCK_CLOEXEC in type argument of socketpair (#1567) Setting `SOCK_NONBLOCK` and `SOCK_CLOEXEC` in the `type` argument of `socketpair()` is widely supported across UNIX-like OS: Linux, *BSD, Solaris, etc., as is the `socket()`. This will conserve several extra system calls, we should use it where available. ### References - [socketpair(2) on Linux](https://man7.org/linux/man-pages/man2/socketpair.2.html#HISTORY) - [socketpair(2) on FreeBSD](https://man.freebsd.org/cgi/man.cgi?query=socketpair&sektion=2#DESCRIPTION) - [socketpair(2) on DragonFly](https://man.dragonflybsd.org/?command=socketpair&section=2) - [socketpair(2) on NetBSD](https://man.netbsd.org/socketpair.2#DESCRIPTION) - [socketpair(2) on OpenBSD](https://man.openbsd.org/socketpair.2) - [socketpair(3C) on Solaris](https://docs.oracle.com/cd/E88353_01/html/E37843/socketpair-3c.html) Changelog: - Set SOCK_NONBLOCK and SOCK_CLOEXEC in the type argument of socketpair - Avoid EPROTOTYPE on macOS and OpenBSD - Eliminate the warnings about unused variables - Add some comments
f2b3ce6b	2024-03-03T23:10:48	Merge pull request #1558 from azat/ratelimit-fixes Fix few issues found by oss-fuzz in bufferevent ratelimits
e4b87327	2024-02-20T08:58:04	Fix integer-overflow in ev_token_bucket_cfg_new Found by oss-fuzz, after coverage had been improved in https://github.com/google/oss-fuzz/pull/11257 v2: better check (found by CI for windows)
15e643d0	2024-03-03T14:49:34	Fix pread detection for cmake builds Otherwise it will use lseek()+read() - suboptimal
92109747	2024-03-02T10:45:49	Simplify TCP_KEEPALIVE_ABORT_THRESHOLD settings on Solaris
c4fb0f76	2024-02-20T08:58:04	Fix divide-by-zero in ev_token_bucket_get_tick_ Found by oss-fuzz, after coverage had been improved in https://github.com/google/oss-fuzz/pull/11257
ec8d7a5a	2024-02-20T08:54:14	ci: fix ABI check (#1510)
7eddd526	2024-02-20T07:56:24	Patch abi-compliance-checker to avoid endless loop
798547ac	2024-02-20T07:51:37	Force abi-check to use DWARF 3
e4869625	2024-02-20T08:01:23	Fix abi_check.sh by excluding .abi-check from cp cp: cannot copy a directory, './.abi-check', into itself, '/le/src/.abi-check/work/abi-check/src/libevent/current/.abi-check'
5bdfab76	2024-02-18T21:36:30	Debug abi check
f37c667c	2024-02-18T20:28:49	Add ABI check without deploy for PRs
551df0b2	2023-09-03T08:15:07	ci: try to fix ABI check by using newer version of ubuntu Looks like after upgrading ubuntu from 18.04 (that has 1.9 version of lvc abi tools) to 20.04 (that has 1.11) the abi-check started to timeout (works longer then 6 hours, while usually few minutes, and sometimes even faster was enough). Unlikely upgrading ubuntu will help, since 22.04 and 20.04 has the same version, but still, let's try. Refs: #1463
0dbd3eb3	2024-02-18T16:06:28	tests: add test for EV_SIGNAL with timeout Refs: https://github.com/libevent/libevent-book/issues/12
5cec3417	2024-02-19T08:21:11	Make Infer static analyzer happy (#1554)
ed35b30f	2023-10-23T16:52:19	Fix two compiler errors for unused variable and undefined function In buffer.c a variable "flags" and a label "done" are defined but never used if "EVENT__HAVEMMAP" is not defined. The code does not work on platforms which do not provide the function `socketpair()`. Introduce EVENT__HAVE_SOCKETPAIR flag which determines if `socketpair()` or `evutil_ersatz_socketpair()` is used.
95ed33e3	2024-02-18T22:08:54	Follow up for HTTP chunk size check (#1552)
f9939490	2024-02-18T21:19:41	Fix leak in evconnlistener_new_async() Fixes: https://github.com/libevent/libevent/issues/414
317911a1	2024-02-18T20:39:12	Fix util/monotonic_prc_fallback under FreeBSD Looks like there was garbage, since evutil_configure_monotonic_time_() does not reset evutil_monotonic_timer structure, while in case of fallback it uses two fields from it: - last_time - adjust_monotonic_clock Fixes: https://github.com/libevent/libevent/issues/1495
3cf996f0	2024-02-18T19:53:58	evutil: add a comment why no NULL check in evutil_inet_pton_scope()
5412b2c3	2024-02-18T19:40:00	bufferevent_ssl: fix freeing ctx in case of error in bufferevent_ssl_new_impl
c9793baa	2024-02-18T19:39:50	bufferevent_ssl: proper NULL checks
6e4ea6c3	2024-02-18T19:31:12	evthread: fix NULL dereference in evthread_setup_global_lock_()
2f27523e	2024-02-18T18:22:21	bufferevent_ssl: do not return NULL from upcast /src/le/libevent/bufferevent_ssl.c:863: error: Null Dereference pointer `bev_ssl` last assigned on line 855 could be null and is dereferenced at line 863, column 6. 861. r2 = start_writing(bev_ssl); 862. 863. if (bev_ssl->underlying) { ^ 864. if (events & EV_READ) 865. BEV_RESET_GENERIC_READ_TIMEOUT(bev);
53034936	2024-02-18T18:16:38	bufferevent_filter: do not allow upcast() to return NULL (fixes infer warning) /src/le/libevent/bufferevent_filter.c:234: error: Null Dereference pointer `bevf` last assigned on line 231 could be null and is dereferenced at line 234, column 6. 232. EVUTIL_ASSERT(bevf); 233. 234. if (bevf->bev.options & BEV_OPT_CLOSE_ON_FREE) { ^ 235. /* Yes, there is also a decref in bufferevent_decref_. 236. * That decref corresponds to the incref when we set
d9b5fe31	2024-02-18T18:03:38	evrpc: proper NULL checks (API function return value added) Note, that in order to do this evrpc_hook_add_meta() should have return value, so this is a minor ABI change, which should not affect C ABI, but still worth to mention. Anyway this will be done in 2.2 release and unlikely RPC subsystem is popular.
05ed7c8c	2024-02-18T18:00:57	bufferevent_pair: fix infer warnings due to upcast() return NULL The only user that is care about this is bufferevent_pair_get_partner(), so let's move the check there.
8feed7f1	2024-02-18T19:26:47	http: forbid chunks size with 0X prefix Co-authored-by: Ben Kallus <49924171+kenballus@users.noreply.github.com>
87cdcc18	2024-02-18T15:24:58	http: change error for corrupted requests to 400 Bad Request Previously it was 413 Request Entity Too Large, which was odd.
f1632e59	2024-02-18T15:24:33	http: check first byte of the chunk for 0x as well
e60d039d	2024-02-18T15:02:59	tests: add a test for malformed chunks v2: fix test for win32 (and it more correct in general)
92ea8476	2024-02-18T08:56:46	Forbid 0x/+/-/whitespace prefixes on HTTP chunk sizes (#1542) Currently, libevent's HTTP parser accepts and ignores 0x, +, and whitespace prefixes on chunk sizes. It also ignores - prefixes on chunk sizes of 0. This patch fixes that. There is a potential danger in the current behavior, which is that there exist HTTP implementations that interpret chunk sizes as their longest valid prefix. For those implementations, 0xa (for example) is equivalent to 0, and this may present a request smuggling risk when those implementations are used in conjunction with libevent. However, as far I'm aware, there is no HTTP proxy that both interprets 0xa as 0 and forwards it verbatim, so I think this is a low-risk bug that is acceptable to report in public.
da3c7b50	2024-02-18T12:07:07	Update link to the github package registry usage from github actions Ugh, old link even don't have any redirect, what is a pitty. [skip ci]
7870e85e	2024-01-24T13:19:23	install DESTINATION use CMAKE_INSTALL_<dir>
b698e6c4	2024-01-23T04:29:04	Make MbedTLS and OpenSSL dependencies configurable (#1544) As acfac7a#r124469888 mentioned, LibeventConfig.cmake is looking for MBedTLS package, even if libevent is not configured to use MBedTLS. This PR makes MbedTLS and OpenSSL dependencies configurable. Fixes: #1543
665d79f1	2024-01-18T16:42:52	Fix integer overflow in HTTP version (#1541) Currently, when libevent parses requests with version `HTTP/4294967295.255`, you end up with `req->major == req->minor == (char)-1`. (At least on linux-gnu-x86_64, where `char` is signed.) This is sort of weird. This patch changes the version parser to match the grammar in RFCs 7230 and 9112. (i.e. `HTTP/[0-9].[0-9]`) EDIT: Technically, a little stronger than the RFC requires, since this patch continues to block major versions greater than 1, which was already what libevent was doing.
55899c2f	2024-01-14T21:24:37	Use read/write instead of readv/writev for single buffer The `readv`/`writev` functions are designed for scattered I/O optimally, their logic in the kernel is more sophisticated, compared to read/write, which includes extra on-stack `iovec` in the kernel space, importing `iovec` array from user space to kernel space, reading/writing with `iov_iter`, etc. As a result, using `readv`/`writev` on single-segment `iovec` will fall into the special branch in the kernel where it is imported as `ITER_UBUF` differed from `ITER_IOVEC` for multiple-segments `iovec`. Thus, it is just not worth calling `readv`/`writev` for single-segment `iovec`, we should use `read`/`write` instead, to save it from going through the sophisticated yet unnecessary kernel code path, circumvent a waste of kernel on-stack memory, copying `iovec` between user space and kernel space, etc.
3f508af6	2024-01-14T13:40:35	Ignore the project files from IDE or editors I sometimes browse and edit C/C++ code with VSCode, and it would generate some project files in .vscode which could easily be added and even pushed to a git repo by accident. It's sort of annoying for programmers who work with VS/VSCode, IntelliJ/Clion, or other widely-used IDE or editors to prevent themself from using git command like `git add .` in lib event project. Therefore, I propose leaving the project files generated by VS/VSCode and IntelliJ/Clion untracked for libevent project. Hopefully, this can be accepted.
23cdd610	2024-01-15T12:26:58	Use evutil_set_tcp_keepalive for sample/becat.c Since #1532 introduced the util function for consolidating TPC keep-alive settings, there is no need to write other handmade functions elsewhere.
cffb7c03	2024-01-13T15:54:49	ci: disable ABI check temporary (I hope that "temporary") Refs: https://github.com/libevent/libevent/issues/1463
9d4853b3	2024-01-13T20:51:49	Optimize preprocessor directives on Solaris for evutil_set_tcp_keepalive (#1536) Changes: - Optimize preprocessor directives on Solaris for evutil_set_tcp_keepalive - Reduce the amount of code being compiled and trim trailing whitespace in passing. - Move comments for Solaris under its macro - Refactor the control flow
76460fbe	2024-01-06T14:29:22	Fix windows CI (#1533) But note, that there is still issues with MbedTLS and ZLIB: CMake Error at C:/Program Files/CMake/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Error: Could NOT find MbedTLS (missing: MBEDTLS_INCLUDE_DIR MBEDTLS_LIBRARY MBEDTLS_CRYPTO_LIBRARY MBEDTLS_X509_LIBRARY MBEDTLS_LIBRARIES MBEDTLS_VERSION) Call Stack (most recent call first): C:/Program Files/CMake/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE) D:/a/libevent/libevent/cmake/FindMbedTLS.cmake:142 (find_package_handle_standard_args) D:/a/libevent/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package) C:/Program Files/CMake/share/cmake-3.27/Modules/CMakeFindDependencyMacro.cmake:76 (find_package) D:/a/libevent/libevent/build/LibeventConfig.cmake:43 (find_dependency) D:/a/libevent/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package) CMakeLists.txt:11 (find_package) But by some reason it is not a fatal error on some builds: -- OpenSSL lib: optimized;C:/Program Files/OpenSSL/lib/VC/libssl64MD.lib;debug;C:/Program Files/OpenSSL/lib/VC/libssl64MDd.lib;optimized;C:/Program Files/OpenSSL/lib/VC/libcrypto64MD.lib;debug;C:/Program Files/OpenSSL/lib/VC/libcrypto64MDd.lib -- Could NOT find MbedTLS (missing: MBEDTLS_INCLUDE_DIR MBEDTLS_LIBRARY MBEDTLS_CRYPTO_LIBRARY MBEDTLS_X509_LIBRARY MBEDTLS_LIBRARIES MBEDTLS_VERSION) -- Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.11") This will be fixed separatelly - #1534, partially worked CI better then fully broken anyway. * ci/windows: Update vcpkg to fix windows CI Switch to windows-latest (just in case)
3e01178b	2024-01-06T13:53:32	Update vcpkg to fix windows CI Previusly it got lots of 404 errors during downloading packages, this was due to too old repository had been used.
85c09bbf	2024-01-06T13:15:58	Switch to windows-latest (just in case)
7658b788	2024-01-06T00:52:43	Implement full support of TCP Keep-Alives across most Unix-like OS's (#1532) Default settings of TCP keep-alive are not always feasible, take Linux for example, the duration a connection needs to be idle before sending out the first keep-alive probe is two hours, which makes detecting dead connections extremely deferred. Thus, enabling TCP keep-alive will be to little avail. This sets TCP_KEEPIDLE, TCP_KEEPINTVL, and TCP_KEEPCNT when enabling TCP keep-alive mechanism to make it practicable.
0c54433c	2023-11-26T14:53:23	time-test: use event_new for compatibility with future libevent (#1525)
4c38de8c	2023-11-26T20:52:32	Fix -Walloc-size (#1526) Co-authored-by: Azat Khuzhin <azat@libevent.org>
4881b592	2023-11-25T19:13:35	Merge pull request #1519 from cculianu/ws_c_fixes
7f5b8f19	2023-11-18T15:55:14	Fix documentation inconsistency in evhttp callbacks This commit addresses a minor inconsistency identified in the documentation of multiple `evhttp` callback functions within the `event2/http.h` header file. It was observed that the word "additional" was presumably missing in the description of the `arg` parameter for several functions. This oversight led to an incorrect phrasing: "an context argument for the callback." The documentation for the following functions has been updated to rectify this issue: - `evhttp_set_gencb` - `evhttp_set_bevcb` - `evhttp_set_newreqcb` - `evhttp_set_errorcb` This commit solely improves the readability of the function descriptions without altering any functional aspects of the code.
cfb2b89a	2023-10-23T17:15:34	fix ERR macro geting redefined In evutil.c a macro ERR gets defined, this is a very generic name in case that in a included header file ERR is used too, the compiler will fail complaining about the redefinition of the macro ERR. To fix this make sure ERR is undefined, before defining it in evutil.c
a579b1d7	2023-10-20T15:36:07	Fix compile error in evbuffer_read() The variable chainp is only used if USE_IOVEC_IMPL is defined. This makes a strict compiler complain about unused variables, since chainp is declared outside of an USE_IOVEC_IMPL block.
15b9b6f0	2023-10-17T12:45:33	Apply suggestions from code review Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
b828c4ab	2023-10-16T15:25:12	Added 10MiB recv limit for WS frames, also a small nit - Added WS_MAX_RECV_FRAME_SZ, if a received frame exceeds this limit (10 MiB), error out. This is a DoS prevention measure. - Also redid the unmasking code in get_ws_frame(), to avoid assumptions about the size of an unsigned int and some casting, and avoid memcpy(), just use the mask bytes from the buffer that are already there to unmask.
7fbbe86f	2023-10-14T23:53:36	Fix unaligned access + missing frame length get_ws_frame: - had potentially unaligned access; fixed. - was not reading the full 8 bytes in the 64-bit case (was using the incorrect htons); fixed. make_ws_frame: - wasn't writing the length in the 8-byte case. Also switched both functions to use size_t rather than int where appropriate.
c9af0245	2023-10-12T10:22:04	wepoll api: fix definition of EPOLLONESHOT to match Linux
23685cfb	2023-09-28T11:18:10	Fix some typos (#1515)
d30ad0a7	2023-09-22T10:21:15	Merge branch 'becat-fixes-v2' * becat-fixes-v2: becat: change -R to -b (since it is more of a buffer size) becat: add ability to set TCP keepalive
9e4693ed	2023-09-22T10:21:06	becat: change -R to -b (since it is more of a buffer size)
617cf5ef	2023-09-22T10:21:06	becat: add ability to set TCP keepalive
c15ba75d	2023-09-22T09:35:42	Merge branch 'evbuffer_add_reference_with_offset' - #1513 * evbuffer_add_reference_with_offset: Add a comment for evbuffer_ref_cleanup_cb tests: simplify test_evbuffer_add_reference_with_offset Add function evbuffer_add_reference_with_offset()
c2a935b5	2023-09-22T09:34:59	Add a comment for evbuffer_ref_cleanup_cb
d9780cf9	2023-09-21T22:04:17	Fix -Wsingle-bit-bitfield-constant-conversion warning in clang 16 report: /src/le/libevent/sample/becat.c:304:29: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion] case 'k': o.extra.keep = 1; break;
cc3a9200	2023-09-21T22:02:48	tests: simplify test_evbuffer_add_reference_with_offset
648ec50e	2023-09-21T15:13:31	Add function evbuffer_add_reference_with_offset() This is the same as evbuffer_add_reference(), but allows to specify offset in the @data v2: rename evbuffer_add_reference_misalign() to evbuffer_add_reference_with_offset()
8728c983	2023-08-02T10:56:35	evthread: Fix typos in error messages - s/probaby/probably/
0797e207	2023-08-02T18:37:42	Fixed misaligned address access
f39ad1c4	2023-08-31T22:38:41	ws: replace evws_send with evws_send_text/evws_send_binary (ABI breakage) (#1500) Replace evws_send with evws_send_text, and introduce new API - evws_send_binary, that can be used to send binary frames. But note, that this commit breaks the ABI compatibility, but it should be OK, since there was only alpha release with evws_send, and nobody should rely on this, and I hope nobody does (we decided to go this way to avoid supporting deprecated API).
21d2f5a4	2023-08-18T07:51:02	Fixes #include of winsock.h before winsock2.h
c9ec6aaf	2023-08-01T14:02:34	Update cmake policy wrt. RPATH on OSX Previous settings caused install outside CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES to use install_name "lib/" in place of the expected (and useful) "@rpath/".
3c29a81b	2023-07-30T07:44:53	fixup RPATH computation Handle cases where ${CMAKE_INSTALL_LIBDIR} is not ${CMAKE_INSTALL_PREFIX}/lib . Also, preserve user provided ${CMAKE_INSTALL_RPATH} . fixup for 41a7393f3ecd1e9f58331df4653dac2e6739304e
66b3904b	2023-07-29T22:27:31	Merge pull request #1498 from mdavidsaver/cleanup-_WIN32_WINNT
f76bd641	2023-07-29T08:12:26	increment _WIN32_WINNT in evutil.c
126523f9	2023-07-25T11:01:32	fix prototype of evutil_check_working_afunix_() mingw w/ gcc 12 defaults to -Wstrict-prototype which complains about K&R style argument lists.
a14ff912	2023-07-25T10:52:10	move _WIN32_WINNT defintions before first #include _WIN32_WINNT and WIN32_LEAN_AND_MEAN need to be defined before the windows.h is included for the first time. Avoid the confusion of indirect #include by defining before any.
6db587de	2023-07-16T15:23:14	Merge branch 'scorecard-action' (#1494) * scorecard-action: docs(readme): add scorecard badge Enable Scorecard GitHub Action
e26e0647	2023-07-14T14:09:52	docs(readme): add scorecard badge
613581bb	2023-07-14T13:38:04	Enable Scorecard GitHub Action
7b302e7d	2023-07-13T21:21:58	Merge branch 'disable-signalfd' * disable-signalfd: Increase timeout for tests Disable signalfd by default
3d1d7548	2023-07-11T21:29:37	Increase timeout for tests Now, it 20min for sequential runs is not enough already, I've tested it on t3.medium manually and got the same: Total Test time (real) = 1275.03 sec And also if I run tests in parallel then I had few failures: bufferevent/bufferevent_connect_fail: FAIL /root/libevent/test/regress_bufferevent.c:865: didn't fail? what 128 FAIL /root/libevent/test/regress_bufferevent.c:906: assert(test_ok == 1): 0 vs 1 FAIL /root/libevent/test/regress_bufferevent.c:839: assert(n_events_invoked == 1): 2 vs 1bufferevent/bufferevent_connect_fail_eventcb_defer: FAIL /root/libevent/test/regress_bufferevent.c:839: assert(n_events_invoked == 1): 2 vs 1bufferevent/bufferevent_connect_fail_eventcb: 3/386 TESTS FAILED. (45 skipped) v2: Increase timeout more (for netbsd)
57d9eec6	2023-07-10T10:40:49	Disable signalfd by default signalfd may behave differently to sigaction/signal, so to avoid breaking libevent users (like [1], [2]) disable it by default. [1]: https://github.com/tmux/tmux/pull/3621 [2]: https://github.com/tmux/tmux/pull/3626 Also signalfd is not that perfect: - you need to SIG_BLOCK the signal before - blocked signals are not reset on exec - blocked signals are allowed to coalesce - so in case of multiple signals sent you may get the signal only once (ok for most of the signals, but may be a problem for SIGCHLD, though you may call waitpid() in a loop or use pidfd) - and also one implementation problem - sigprocmask is unspecified in a multithreaded process Refs: - https://lwn.net/Articles/415684/ - https://ldpreload.com/blog/signalfd-is-useless Refs: https://github.com/libevent/libevent/issues/1460 Refs: #1342 (cc @dmantipov)
227510d5	2023-07-13T22:20:33	Fix EVDNS_BASE_DISABLE_WHEN_INACTIVE (#1493) I faced with strange problem: event loop doesn't exit after dns resolving with `EVDNS_BASE_DISABLE_WHEN_INACTIVE`. Stand: - Ubuntu 22; - libevent release-2.1.12-stable - `resolve.conf` contains 2 nameservers; - I use `evdns_base_new` with `EVDNS_BASE_DISABLE_WHEN_INACTIVE \| EVDNS_BASE_INITIALIZE_NAMESERVERS` to avoid OS specific code. After small investigation, look like events related with dns sockets added to event_base before `evdns->disable_when_inactive` was initialized. `libevent` did epoll_ctl(DEL) after resolving completed on the first socket, but the second socket remained in the `epoll` interest list.
36ad1006	2023-06-26T11:13:58	#1479: GCC12 error for EVUTIL_FALLTHROUGH
5ab24bdd	2023-06-28T21:33:47	Merge branch 'becat-fixes' * becat-fixes: becat: fix handling positional arguments becat: handle -T correctly
2b729238	2023-06-28T21:33:41	becat: fix handling positional arguments
687124d0	2023-06-28T21:33:41	becat: handle -T correctly
be4eb97d	2023-06-21T22:26:51	Disable lazy gettimeofday/clock_gettime comparison (#1474)
2e312772	2023-06-20T22:18:41	Disable lazy gettimeofday/clock_gettime comparison The benefit of this optimization is questionable for the following reasons: - libevent uses CLOCK_MONOTONIC_COARSE which is fast enough (on my desktop CLOCK_MONOTONIC/CLOCK_MONOTONIC_RAW works 40/50 millions of ops per second, and CLOCK_MONOTONIC_COARSE is faster) - libevent has caching of time (EVENT_BASE_FLAG_NO_CACHE_TIME) So I don't see any reason for using one more caching - lazy comparsion (whatever you call it).

d6e88352

2024-04-10T17:45:03

Fix potential Null pointer dereference in regress_et.c

d45dca43

2024-04-10T17:39:36

Fix potential Null pointer dereference in regress_thread.c

2bdf1737

2024-04-10T16:18:27

Fix potential Null pointer dereference in regress_finalize.c

17796a2d

2024-04-10T15:32:54

Fix potential Null pointer dereference in regress_http.c

f9526e13

2024-04-10T15:16:21

Fix potential NULL pointer dereference in regress_bufferevent.c

fc48803d

2024-04-15T15:02:27

Fix potential Null pointer dereference in regress_zlib.c (#1597) Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>

c6e8f175

2024-04-07T19:37:55

Edit logo path to match new website directory

39073df8

2024-03-30T21:44:50

evutil: don't call memset before memcpy In `evutil_parse_sockaddr_port`, it would `memset` the `out` to zero, however, the `memset` is unnecessary before `memcpy`, and may cause undefined behavior if the `outlen` is invalid. This should close #1573.

4fd07f0e

2024-03-12T21:56:35

Upgrade vmactions to use linux runners (#1570) Co-authored-by: neil <neilgit@neilpang.com>

539f73e3

2024-02-20T09:30:22

Fix leak in evbuffer_add_file() on empty files Found by oss-fuzz, after coverage had been improved in google/oss-fuzz#11257 v2: adjust test v3: fix for windows (_get_osfhandle() crashes when called on closed fd) v4: fix for EVENT__DISABLE_MM_REPLACEMENT

b9e1fe74

2024-03-11T21:00:18

ci: disable netbsd and freebsd due to lack of runners For example for openbsd-cmake-job (7.2, NONE) This request was automatically failed because there were no enabled runners online to process the request for more than 1 days. And maybe this will fix the macos builds.

0054b9aa

2024-03-11T17:12:14

Enable the full TCP KeepAlive mechanism on Windows (#1568) #1532 implemented the full support of TCP Keep-Alives on UNIX-like OS's while leaving a `TODO` for Windows. This PR intends to resolve that `TODO`. ## References - [SIO_KEEPALIVE_VALS Control Code](https://learn.microsoft.com/en-us/windows/win32/winsock/sio-keepalive-vals) - [IPPROTO_TCP socket options](https://learn.microsoft.com/en-us/windows/win32/winsock/ipproto-tcp-socket-options) - [TCP_KEEPINVTL and TCP_KEEPIDLE - Socket Keep Alives not working](https://cygwin.com/pipermail/cygwin/2020-June/245436.html) - [Cygwin: tcp: Support TCP_KEEPIDLE, TCP_KEEPCNT, TCP_KEEPINTVL](https://sourceware.org/pipermail/cygwin-cvs/2020q3/014473.html) - [Add cross-platform support for keep-alive socket options](https://github.com/dotnet/corefx/pull/29963/files)

9c8860ec

2024-03-11T15:50:43

chore: remove repetitive words Signed-off-by: tgolang <seekseat@aliyun.com>

e66df92c

2024-03-07T16:19:11

Accept SOCK_NONBLOCK/SOCK_CLOEXEC in type argument of socketpair (#1567) Setting `SOCK_NONBLOCK` and `SOCK_CLOEXEC` in the `type` argument of `socketpair()` is widely supported across UNIX-like OS: Linux, *BSD, Solaris, etc., as is the `socket()`. This will conserve several extra system calls, we should use it where available. ### References - [socketpair(2) on Linux](https://man7.org/linux/man-pages/man2/socketpair.2.html#HISTORY) - [socketpair(2) on FreeBSD](https://man.freebsd.org/cgi/man.cgi?query=socketpair&sektion=2#DESCRIPTION) - [socketpair(2) on DragonFly](https://man.dragonflybsd.org/?command=socketpair&section=2) - [socketpair(2) on NetBSD](https://man.netbsd.org/socketpair.2#DESCRIPTION) - [socketpair(2) on OpenBSD](https://man.openbsd.org/socketpair.2) - [socketpair(3C) on Solaris](https://docs.oracle.com/cd/E88353_01/html/E37843/socketpair-3c.html) Changelog: - Set SOCK_NONBLOCK and SOCK_CLOEXEC in the type argument of socketpair - Avoid EPROTOTYPE on macOS and OpenBSD - Eliminate the warnings about unused variables - Add some comments

f2b3ce6b

2024-03-03T23:10:48

Merge pull request #1558 from azat/ratelimit-fixes Fix few issues found by oss-fuzz in bufferevent ratelimits

e4b87327

2024-02-20T08:58:04

Fix integer-overflow in ev_token_bucket_cfg_new Found by oss-fuzz, after coverage had been improved in https://github.com/google/oss-fuzz/pull/11257 v2: better check (found by CI for windows)

15e643d0

2024-03-03T14:49:34

Fix pread detection for cmake builds Otherwise it will use lseek()+read() - suboptimal

92109747

2024-03-02T10:45:49

Simplify TCP_KEEPALIVE_ABORT_THRESHOLD settings on Solaris

c4fb0f76

2024-02-20T08:58:04

Fix divide-by-zero in ev_token_bucket_get_tick_ Found by oss-fuzz, after coverage had been improved in https://github.com/google/oss-fuzz/pull/11257

ec8d7a5a

2024-02-20T08:54:14

ci: fix ABI check (#1510)

7eddd526

2024-02-20T07:56:24

Patch abi-compliance-checker to avoid endless loop

798547ac

2024-02-20T07:51:37

Force abi-check to use DWARF 3

e4869625

2024-02-20T08:01:23

Fix abi_check.sh by excluding .abi-check from cp cp: cannot copy a directory, './.abi-check', into itself, '/le/src/.abi-check/work/abi-check/src/libevent/current/.abi-check'

5bdfab76

2024-02-18T21:36:30

Debug abi check

f37c667c

2024-02-18T20:28:49

Add ABI check without deploy for PRs

551df0b2

2023-09-03T08:15:07

ci: try to fix ABI check by using newer version of ubuntu Looks like after upgrading ubuntu from 18.04 (that has 1.9 version of lvc abi tools) to 20.04 (that has 1.11) the abi-check started to timeout (works longer then 6 hours, while usually few minutes, and sometimes even faster was enough). Unlikely upgrading ubuntu will help, since 22.04 and 20.04 has the same version, but still, let's try. Refs: #1463

0dbd3eb3

2024-02-18T16:06:28

tests: add test for EV_SIGNAL with timeout Refs: https://github.com/libevent/libevent-book/issues/12

5cec3417

2024-02-19T08:21:11

Make Infer static analyzer happy (#1554)

ed35b30f

2023-10-23T16:52:19

Fix two compiler errors for unused variable and undefined function In buffer.c a variable "flags" and a label "done" are defined but never used if "EVENT__HAVEMMAP" is not defined. The code does not work on platforms which do not provide the function `socketpair()`. Introduce EVENT__HAVE_SOCKETPAIR flag which determines if `socketpair()` or `evutil_ersatz_socketpair()` is used.

95ed33e3

2024-02-18T22:08:54

Follow up for HTTP chunk size check (#1552)

f9939490

2024-02-18T21:19:41

Fix leak in evconnlistener_new_async() Fixes: https://github.com/libevent/libevent/issues/414

317911a1

2024-02-18T20:39:12

Fix util/monotonic_prc_fallback under FreeBSD Looks like there was garbage, since evutil_configure_monotonic_time_() does not reset evutil_monotonic_timer structure, while in case of fallback it uses two fields from it: - last_time - adjust_monotonic_clock Fixes: https://github.com/libevent/libevent/issues/1495

3cf996f0

2024-02-18T19:53:58

evutil: add a comment why no NULL check in evutil_inet_pton_scope()

5412b2c3

2024-02-18T19:40:00

bufferevent_ssl: fix freeing ctx in case of error in bufferevent_ssl_new_impl

c9793baa

2024-02-18T19:39:50

bufferevent_ssl: proper NULL checks

6e4ea6c3

2024-02-18T19:31:12

evthread: fix NULL dereference in evthread_setup_global_lock_()

2f27523e

2024-02-18T18:22:21

bufferevent_ssl: do not return NULL from upcast /src/le/libevent/bufferevent_ssl.c:863: error: Null Dereference pointer `bev_ssl` last assigned on line 855 could be null and is dereferenced at line 863, column 6. 861. r2 = start_writing(bev_ssl); 862. 863. if (bev_ssl->underlying) { ^ 864. if (events & EV_READ) 865. BEV_RESET_GENERIC_READ_TIMEOUT(bev);

53034936

2024-02-18T18:16:38

bufferevent_filter: do not allow upcast() to return NULL (fixes infer warning) /src/le/libevent/bufferevent_filter.c:234: error: Null Dereference pointer `bevf` last assigned on line 231 could be null and is dereferenced at line 234, column 6. 232. EVUTIL_ASSERT(bevf); 233. 234. if (bevf->bev.options & BEV_OPT_CLOSE_ON_FREE) { ^ 235. /* Yes, there is also a decref in bufferevent_decref_. 236. * That decref corresponds to the incref when we set

d9b5fe31

2024-02-18T18:03:38

evrpc: proper NULL checks (API function return value added) Note, that in order to do this evrpc_hook_add_meta() should have return value, so this is a minor ABI change, which should not affect C ABI, but still worth to mention. Anyway this will be done in 2.2 release and unlikely RPC subsystem is popular.

05ed7c8c

2024-02-18T18:00:57

bufferevent_pair: fix infer warnings due to upcast() return NULL The only user that is care about this is bufferevent_pair_get_partner(), so let's move the check there.

8feed7f1

2024-02-18T19:26:47

http: forbid chunks size with 0X prefix Co-authored-by: Ben Kallus <49924171+kenballus@users.noreply.github.com>

87cdcc18

2024-02-18T15:24:58

http: change error for corrupted requests to 400 Bad Request Previously it was 413 Request Entity Too Large, which was odd.

f1632e59

2024-02-18T15:24:33

http: check first byte of the chunk for 0x as well

e60d039d

2024-02-18T15:02:59

tests: add a test for malformed chunks v2: fix test for win32 (and it more correct in general)

92ea8476

2024-02-18T08:56:46

Forbid 0x/+/-/whitespace prefixes on HTTP chunk sizes (#1542) Currently, libevent's HTTP parser accepts and ignores 0x, +, and whitespace prefixes on chunk sizes. It also ignores - prefixes on chunk sizes of 0. This patch fixes that. There is a potential danger in the current behavior, which is that there exist HTTP implementations that interpret chunk sizes as their longest valid prefix. For those implementations, 0xa (for example) is equivalent to 0, and this may present a request smuggling risk when those implementations are used in conjunction with libevent. However, as far I'm aware, there is no HTTP proxy that both interprets 0xa as 0 and forwards it verbatim, so I think this is a low-risk bug that is acceptable to report in public.

da3c7b50

2024-02-18T12:07:07

Update link to the github package registry usage from github actions Ugh, old link even don't have any redirect, what is a pitty. [skip ci]

7870e85e

2024-01-24T13:19:23

install DESTINATION use CMAKE_INSTALL_<dir>

b698e6c4

2024-01-23T04:29:04

Make MbedTLS and OpenSSL dependencies configurable (#1544) As acfac7a#r124469888 mentioned, LibeventConfig.cmake is looking for MBedTLS package, even if libevent is not configured to use MBedTLS. This PR makes MbedTLS and OpenSSL dependencies configurable. Fixes: #1543

665d79f1

2024-01-18T16:42:52

Fix integer overflow in HTTP version (#1541) Currently, when libevent parses requests with version `HTTP/4294967295.255`, you end up with `req->major == req->minor == (char)-1`. (At least on linux-gnu-x86_64, where `char` is signed.) This is sort of weird. This patch changes the version parser to match the grammar in RFCs 7230 and 9112. (i.e. `HTTP/[0-9].[0-9]`) EDIT: Technically, a little stronger than the RFC requires, since this patch continues to block major versions greater than 1, which was already what libevent was doing.

55899c2f

2024-01-14T21:24:37

Use read/write instead of readv/writev for single buffer The `readv`/`writev` functions are designed for scattered I/O optimally, their logic in the kernel is more sophisticated, compared to read/write, which includes extra on-stack `iovec` in the kernel space, importing `iovec` array from user space to kernel space, reading/writing with `iov_iter`, etc. As a result, using `readv`/`writev` on single-segment `iovec` will fall into the special branch in the kernel where it is imported as `ITER_UBUF` differed from `ITER_IOVEC` for multiple-segments `iovec`. Thus, it is just not worth calling `readv`/`writev` for single-segment `iovec`, we should use `read`/`write` instead, to save it from going through the sophisticated yet unnecessary kernel code path, circumvent a waste of kernel on-stack memory, copying `iovec` between user space and kernel space, etc.

3f508af6

2024-01-14T13:40:35

Ignore the project files from IDE or editors I sometimes browse and edit C/C++ code with VSCode, and it would generate some project files in .vscode which could easily be added and even pushed to a git repo by accident. It's sort of annoying for programmers who work with VS/VSCode, IntelliJ/Clion, or other widely-used IDE or editors to prevent themself from using git command like `git add .` in lib event project. Therefore, I propose leaving the project files generated by VS/VSCode and IntelliJ/Clion untracked for libevent project. Hopefully, this can be accepted.

23cdd610

2024-01-15T12:26:58

Use evutil_set_tcp_keepalive for sample/becat.c Since #1532 introduced the util function for consolidating TPC keep-alive settings, there is no need to write other handmade functions elsewhere.

cffb7c03

2024-01-13T15:54:49

ci: disable ABI check temporary (I hope that "temporary") Refs: https://github.com/libevent/libevent/issues/1463

9d4853b3

2024-01-13T20:51:49

Optimize preprocessor directives on Solaris for evutil_set_tcp_keepalive (#1536) Changes: - Optimize preprocessor directives on Solaris for evutil_set_tcp_keepalive - Reduce the amount of code being compiled and trim trailing whitespace in passing. - Move comments for Solaris under its macro - Refactor the control flow

76460fbe

2024-01-06T14:29:22

Fix windows CI (#1533) But note, that there is still issues with MbedTLS and ZLIB: CMake Error at C:/Program Files/CMake/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Error: Could NOT find MbedTLS (missing: MBEDTLS_INCLUDE_DIR MBEDTLS_LIBRARY MBEDTLS_CRYPTO_LIBRARY MBEDTLS_X509_LIBRARY MBEDTLS_LIBRARIES MBEDTLS_VERSION) Call Stack (most recent call first): C:/Program Files/CMake/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE) D:/a/libevent/libevent/cmake/FindMbedTLS.cmake:142 (find_package_handle_standard_args) D:/a/libevent/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package) C:/Program Files/CMake/share/cmake-3.27/Modules/CMakeFindDependencyMacro.cmake:76 (find_package) D:/a/libevent/libevent/build/LibeventConfig.cmake:43 (find_dependency) D:/a/libevent/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package) CMakeLists.txt:11 (find_package) But by some reason it is not a fatal error on some builds: -- OpenSSL lib: optimized;C:/Program Files/OpenSSL/lib/VC/libssl64MD.lib;debug;C:/Program Files/OpenSSL/lib/VC/libssl64MDd.lib;optimized;C:/Program Files/OpenSSL/lib/VC/libcrypto64MD.lib;debug;C:/Program Files/OpenSSL/lib/VC/libcrypto64MDd.lib -- Could NOT find MbedTLS (missing: MBEDTLS_INCLUDE_DIR MBEDTLS_LIBRARY MBEDTLS_CRYPTO_LIBRARY MBEDTLS_X509_LIBRARY MBEDTLS_LIBRARIES MBEDTLS_VERSION) -- Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.11") This will be fixed separatelly - #1534, partially worked CI better then fully broken anyway. * ci/windows: Update vcpkg to fix windows CI Switch to windows-latest (just in case)

3e01178b

2024-01-06T13:53:32

Update vcpkg to fix windows CI Previusly it got lots of 404 errors during downloading packages, this was due to too old repository had been used.

85c09bbf

2024-01-06T13:15:58

Switch to windows-latest (just in case)

7658b788

2024-01-06T00:52:43

Implement full support of TCP Keep-Alives across most Unix-like OS's (#1532) Default settings of TCP keep-alive are not always feasible, take Linux for example, the duration a connection needs to be idle before sending out the first keep-alive probe is two hours, which makes detecting dead connections extremely deferred. Thus, enabling TCP keep-alive will be to little avail. This sets TCP_KEEPIDLE, TCP_KEEPINTVL, and TCP_KEEPCNT when enabling TCP keep-alive mechanism to make it practicable.

0c54433c

2023-11-26T14:53:23

time-test: use event_new for compatibility with future libevent (#1525)

4c38de8c

2023-11-26T20:52:32

Fix -Walloc-size (#1526) Co-authored-by: Azat Khuzhin <azat@libevent.org>

4881b592

2023-11-25T19:13:35

Merge pull request #1519 from cculianu/ws_c_fixes

7f5b8f19

2023-11-18T15:55:14

Fix documentation inconsistency in evhttp callbacks This commit addresses a minor inconsistency identified in the documentation of multiple `evhttp` callback functions within the `event2/http.h` header file. It was observed that the word "additional" was presumably missing in the description of the `arg` parameter for several functions. This oversight led to an incorrect phrasing: "an context argument for the callback." The documentation for the following functions has been updated to rectify this issue: - `evhttp_set_gencb` - `evhttp_set_bevcb` - `evhttp_set_newreqcb` - `evhttp_set_errorcb` This commit solely improves the readability of the function descriptions without altering any functional aspects of the code.

cfb2b89a

2023-10-23T17:15:34

fix ERR macro geting redefined In evutil.c a macro ERR gets defined, this is a very generic name in case that in a included header file ERR is used too, the compiler will fail complaining about the redefinition of the macro ERR. To fix this make sure ERR is undefined, before defining it in evutil.c

a579b1d7

2023-10-20T15:36:07

Fix compile error in evbuffer_read() The variable chainp is only used if USE_IOVEC_IMPL is defined. This makes a strict compiler complain about unused variables, since chainp is declared outside of an USE_IOVEC_IMPL block.

15b9b6f0

2023-10-17T12:45:33

Apply suggestions from code review Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>

b828c4ab

2023-10-16T15:25:12

Added 10MiB recv limit for WS frames, also a small nit - Added WS_MAX_RECV_FRAME_SZ, if a received frame exceeds this limit (10 MiB), error out. This is a DoS prevention measure. - Also redid the unmasking code in get_ws_frame(), to avoid assumptions about the size of an unsigned int and some casting, and avoid memcpy(), just use the mask bytes from the buffer that are already there to unmask.

7fbbe86f

2023-10-14T23:53:36

Fix unaligned access + missing frame length get_ws_frame: - had potentially unaligned access; fixed. - was not reading the full 8 bytes in the 64-bit case (was using the incorrect htons); fixed. make_ws_frame: - wasn't writing the length in the 8-byte case. Also switched both functions to use size_t rather than int where appropriate.

c9af0245

2023-10-12T10:22:04

wepoll api: fix definition of EPOLLONESHOT to match Linux

23685cfb

2023-09-28T11:18:10

Fix some typos (#1515)

d30ad0a7

2023-09-22T10:21:15

Merge branch 'becat-fixes-v2' * becat-fixes-v2: becat: change -R to -b (since it is more of a buffer size) becat: add ability to set TCP keepalive

9e4693ed

2023-09-22T10:21:06

becat: change -R to -b (since it is more of a buffer size)

617cf5ef

2023-09-22T10:21:06

becat: add ability to set TCP keepalive

c15ba75d

2023-09-22T09:35:42

Merge branch 'evbuffer_add_reference_with_offset' - #1513 * evbuffer_add_reference_with_offset: Add a comment for evbuffer_ref_cleanup_cb tests: simplify test_evbuffer_add_reference_with_offset Add function evbuffer_add_reference_with_offset()

c2a935b5

2023-09-22T09:34:59

Add a comment for evbuffer_ref_cleanup_cb

d9780cf9

2023-09-21T22:04:17

Fix -Wsingle-bit-bitfield-constant-conversion warning in clang 16 report: /src/le/libevent/sample/becat.c:304:29: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion] case 'k': o.extra.keep = 1; break;

cc3a9200

2023-09-21T22:02:48

tests: simplify test_evbuffer_add_reference_with_offset

648ec50e

2023-09-21T15:13:31

Add function evbuffer_add_reference_with_offset() This is the same as evbuffer_add_reference(), but allows to specify offset in the @data v2: rename evbuffer_add_reference_misalign() to evbuffer_add_reference_with_offset()

8728c983

2023-08-02T10:56:35

evthread: Fix typos in error messages - s/probaby/probably/

0797e207

2023-08-02T18:37:42

Fixed misaligned address access

f39ad1c4

2023-08-31T22:38:41

ws: replace evws_send with evws_send_text/evws_send_binary (ABI breakage) (#1500) Replace evws_send with evws_send_text, and introduce new API - evws_send_binary, that can be used to send binary frames. But note, that this commit breaks the ABI compatibility, but it should be OK, since there was only alpha release with evws_send, and nobody should rely on this, and I hope nobody does (we decided to go this way to avoid supporting deprecated API).

21d2f5a4

2023-08-18T07:51:02

Fixes #include of winsock.h before winsock2.h

c9ec6aaf

2023-08-01T14:02:34

Update cmake policy wrt. RPATH on OSX Previous settings caused install outside CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES to use install_name "lib/" in place of the expected (and useful) "@rpath/".

3c29a81b

2023-07-30T07:44:53

fixup RPATH computation Handle cases where ${CMAKE_INSTALL_LIBDIR} is not ${CMAKE_INSTALL_PREFIX}/lib . Also, preserve user provided ${CMAKE_INSTALL_RPATH} . fixup for 41a7393f3ecd1e9f58331df4653dac2e6739304e

66b3904b

2023-07-29T22:27:31

Merge pull request #1498 from mdavidsaver/cleanup-_WIN32_WINNT

f76bd641

2023-07-29T08:12:26

increment _WIN32_WINNT in evutil.c

126523f9

2023-07-25T11:01:32

fix prototype of evutil_check_working_afunix_() mingw w/ gcc 12 defaults to -Wstrict-prototype which complains about K&R style argument lists.

a14ff912

2023-07-25T10:52:10

move _WIN32_WINNT defintions before first #include _WIN32_WINNT and WIN32_LEAN_AND_MEAN need to be defined before the windows.h is included for the first time. Avoid the confusion of indirect #include by defining before any.

6db587de

2023-07-16T15:23:14

Merge branch 'scorecard-action' (#1494) * scorecard-action: docs(readme): add scorecard badge Enable Scorecard GitHub Action

e26e0647

2023-07-14T14:09:52

docs(readme): add scorecard badge

613581bb

2023-07-14T13:38:04

Enable Scorecard GitHub Action

7b302e7d

2023-07-13T21:21:58

Merge branch 'disable-signalfd' * disable-signalfd: Increase timeout for tests Disable signalfd by default

3d1d7548

2023-07-11T21:29:37

Increase timeout for tests Now, it 20min for sequential runs is not enough already, I've tested it on t3.medium manually and got the same: Total Test time (real) = 1275.03 sec And also if I run tests in parallel then I had few failures: bufferevent/bufferevent_connect_fail: FAIL /root/libevent/test/regress_bufferevent.c:865: didn't fail? what 128 FAIL /root/libevent/test/regress_bufferevent.c:906: assert(test_ok == 1): 0 vs 1 FAIL /root/libevent/test/regress_bufferevent.c:839: assert(n_events_invoked == 1): 2 vs 1bufferevent/bufferevent_connect_fail_eventcb_defer: FAIL /root/libevent/test/regress_bufferevent.c:839: assert(n_events_invoked == 1): 2 vs 1bufferevent/bufferevent_connect_fail_eventcb: 3/386 TESTS FAILED. (45 skipped) v2: Increase timeout more (for netbsd)

57d9eec6

2023-07-10T10:40:49

Disable signalfd by default signalfd may behave differently to sigaction/signal, so to avoid breaking libevent users (like [1], [2]) disable it by default. [1]: https://github.com/tmux/tmux/pull/3621 [2]: https://github.com/tmux/tmux/pull/3626 Also signalfd is not that perfect: - you need to SIG_BLOCK the signal before - blocked signals are not reset on exec - blocked signals are allowed to coalesce - so in case of multiple signals sent you may get the signal only once (ok for most of the signals, but may be a problem for SIGCHLD, though you may call waitpid() in a loop or use pidfd) - and also one implementation problem - sigprocmask is unspecified in a multithreaded process Refs: - https://lwn.net/Articles/415684/ - https://ldpreload.com/blog/signalfd-is-useless Refs: https://github.com/libevent/libevent/issues/1460 Refs: #1342 (cc @dmantipov)

227510d5

2023-07-13T22:20:33

Fix EVDNS_BASE_DISABLE_WHEN_INACTIVE (#1493) I faced with strange problem: event loop doesn't exit after dns resolving with `EVDNS_BASE_DISABLE_WHEN_INACTIVE`. Stand: - Ubuntu 22; - libevent release-2.1.12-stable - `resolve.conf` contains 2 nameservers; - I use `evdns_base_new` with `EVDNS_BASE_DISABLE_WHEN_INACTIVE | EVDNS_BASE_INITIALIZE_NAMESERVERS` to avoid OS specific code. After small investigation, look like events related with dns sockets added to event_base before `evdns->disable_when_inactive` was initialized. `libevent` did epoll_ctl(DEL) after resolving completed on the first socket, but the second socket remained in the `epoll` interest list.

36ad1006

2023-06-26T11:13:58

#1479: GCC12 error for EVUTIL_FALLTHROUGH

5ab24bdd

2023-06-28T21:33:47

Merge branch 'becat-fixes' * becat-fixes: becat: fix handling positional arguments becat: handle -T correctly

2b729238

2023-06-28T21:33:41

becat: fix handling positional arguments

687124d0

2023-06-28T21:33:41

becat: handle -T correctly

be4eb97d

2023-06-21T22:26:51

Disable lazy gettimeofday/clock_gettime comparison (#1474)

2e312772

2023-06-20T22:18:41

Disable lazy gettimeofday/clock_gettime comparison The benefit of this optimization is questionable for the following reasons: - libevent uses CLOCK_MONOTONIC_COARSE which is fast enough (on my desktop CLOCK_MONOTONIC/CLOCK_MONOTONIC_RAW works 40/50 millions of ops per second, and CLOCK_MONOTONIC_COARSE is faster) - libevent has caching of time (EVENT_BASE_FLAG_NO_CACHE_TIME) So I don't see any reason for using one more caching - lazy comparsion (whatever you call it).

kc3-lang/libevent

Log