Branch
Hash :
5e27ca23
Author :
Date :
2025-09-19T14:21:49
x86: Reformat NASM code to improve readability (and simplify the checkstyle script)
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370
;
; Grayscale colorspace conversion (32-bit MMX)
;
; Copyright 2009 Pierre Ossman <ossman@cendio.se> for Cendio AB
; Copyright (C) 2011, 2016, 2024-2025, D. R. Commander.
;
; Based on the x86 SIMD extension for IJG JPEG library
; Copyright (C) 1999-2006, MIYASAKA Masaru.
; For conditions of distribution and use, see copyright notice in jsimdext.inc
;
; This file should be assembled with NASM (Netwide Assembler) or Yasm.
%include "jcolsamp.inc"
; --------------------------------------------------------------------------
;
; Convert some rows of samples to the JPEG colorspace.
;
; GLOBAL(void)
; jsimd_rgb_gray_convert_mmx(JDIMENSION img_width, JSAMPARRAY input_buf,
; JSAMPIMAGE output_buf, JDIMENSION output_row,
; int num_rows)
%define img_width(b) (b) + 8 ; JDIMENSION img_width
%define input_buf(b) (b) + 12 ; JSAMPARRAY input_buf
%define output_buf(b) (b) + 16 ; JSAMPIMAGE output_buf
%define output_row(b) (b) + 20 ; JDIMENSION output_row
%define num_rows(b) (b) + 24 ; int num_rows
%define original_ebp ebp + 0
%define wk(i) ebp - (WK_NUM - (i)) * SIZEOF_MMWORD ; mmword wk[WK_NUM]
%define WK_NUM 2
%define gotptr wk(0) - SIZEOF_POINTER ; void *gotptr
align 32
GLOBAL_FUNCTION(jsimd_rgb_gray_convert_mmx)
EXTN(jsimd_rgb_gray_convert_mmx):
push ebp
mov eax, esp ; eax = original ebp
sub esp, byte 4
and esp, byte (-SIZEOF_MMWORD) ; align to 64 bits
mov [esp], eax
mov ebp, esp ; ebp = aligned ebp
lea esp, [wk(0)]
PUSHPIC eax ; make a room for GOT address
push ebx
; push ecx ; need not be preserved
; push edx ; need not be preserved
push esi
push edi
GET_GOT ebx ; get GOT address
MOVPIC POINTER [gotptr], ebx ; save GOT address
mov ecx, JDIMENSION [img_width(eax)] ; num_cols
test ecx, ecx
jz near .return
push ecx
mov esi, JSAMPIMAGE [output_buf(eax)]
mov ecx, JDIMENSION [output_row(eax)]
mov edi, JSAMPARRAY [esi + 0 * SIZEOF_JSAMPARRAY]
lea edi, [edi + ecx * SIZEOF_JSAMPROW]
pop ecx
mov esi, JSAMPARRAY [input_buf(eax)]
mov eax, INT [num_rows(eax)]
test eax, eax
jle near .return
ALIGNX 16, 7
.rowloop:
PUSHPIC eax
push edi
push esi
push ecx ; col
mov esi, JSAMPROW [esi] ; inptr
mov edi, JSAMPROW [edi] ; outptr0
MOVPIC eax, POINTER [gotptr] ; load GOT address (eax)
cmp ecx, byte SIZEOF_MMWORD
jae short .columnloop
ALIGNX 16, 7
%if RGB_PIXELSIZE == 3 ; ---------------
.column_ld1:
push eax
push edx
lea ecx, [ecx + ecx * 2] ; imul ecx, RGB_PIXELSIZE
test cl, SIZEOF_BYTE
jz short .column_ld2
sub ecx, byte SIZEOF_BYTE
xor eax, eax
mov al, byte [esi + ecx]
.column_ld2:
test cl, SIZEOF_WORD
jz short .column_ld4
sub ecx, byte SIZEOF_WORD
xor edx, edx
mov dx, word [esi + ecx]
shl eax, WORD_BIT
or eax, edx
.column_ld4:
movd mmA, eax
pop edx
pop eax
test cl, SIZEOF_DWORD
jz short .column_ld8
sub ecx, byte SIZEOF_DWORD
movd mmG, dword [esi + ecx]
psllq mmA, DWORD_BIT
por mmA, mmG
.column_ld8:
test cl, SIZEOF_MMWORD
jz short .column_ld16
movq mmG, mmA
movq mmA, MMWORD [esi + 0 * SIZEOF_MMWORD]
mov ecx, SIZEOF_MMWORD
jmp short .rgb_gray_cnv
.column_ld16:
test cl, 2 * SIZEOF_MMWORD
mov ecx, SIZEOF_MMWORD
jz short .rgb_gray_cnv
movq mmF, mmA
movq mmA, MMWORD [esi + 0 * SIZEOF_MMWORD]
movq mmG, MMWORD [esi + 1 * SIZEOF_MMWORD]
jmp short .rgb_gray_cnv
ALIGNX 16, 7
.columnloop:
movq mmA, MMWORD [esi + 0 * SIZEOF_MMWORD]
movq mmG, MMWORD [esi + 1 * SIZEOF_MMWORD]
movq mmF, MMWORD [esi + 2 * SIZEOF_MMWORD]
.rgb_gray_cnv:
; NOTE: The values of RGB_RED, RGB_GREEN, and RGB_BLUE determine the
; mapping of components A, B, and C to red, green, and blue.
;
; mmA = (A0 B0 C0 A1 B1 C1 A2 B2)
; mmG = (C2 A3 B3 C3 A4 B4 C4 A5)
; mmF = (B5 C5 A6 B6 C6 A7 B7 C7)
movq mmD, mmA
psllq mmA, 4 * BYTE_BIT ; mmA = (-- -- -- -- A0 B0 C0 A1)
psrlq mmD, 4 * BYTE_BIT ; mmD = (B1 C1 A2 B2 -- -- -- --)
punpckhbw mmA, mmG ; mmA = (A0 A4 B0 B4 C0 C4 A1 A5)
psllq mmG, 4 * BYTE_BIT ; mmG = (-- -- -- -- C2 A3 B3 C3)
punpcklbw mmD, mmF ; mmD = (B1 B5 C1 C5 A2 A6 B2 B6)
punpckhbw mmG, mmF ; mmG = (C2 C6 A3 A7 B3 B7 C3 C7)
movq mmE, mmA
psllq mmA, 4 * BYTE_BIT ; mmA = (-- -- -- -- A0 A4 B0 B4)
psrlq mmE, 4 * BYTE_BIT ; mmE = (C0 C4 A1 A5 -- -- -- --)
punpckhbw mmA, mmD ; mmA = (A0 A2 A4 A6 B0 B2 B4 B6)
psllq mmD, 4 * BYTE_BIT ; mmD = (-- -- -- -- B1 B5 C1 C5)
punpcklbw mmE, mmG ; mmE = (C0 C2 C4 C6 A1 A3 A5 A7)
punpckhbw mmD, mmG ; mmD = (B1 B3 B5 B7 C1 C3 C5 C7)
pxor mmH, mmH
movq mmC, mmA
punpcklbw mmA, mmH ; mmA = (A0 A2 A4 A6) = AE
punpckhbw mmC, mmH ; mmC = (B0 B2 B4 B6) = BE
movq mmB, mmE
punpcklbw mmE, mmH ; mmE = (C0 C2 C4 C6) = CE
punpckhbw mmB, mmH ; mmB = (A1 A3 A5 A7) = AO
movq mmF, mmD
punpcklbw mmD, mmH ; mmD = (B1 B3 B5 B7) = BO
punpckhbw mmF, mmH ; mmF = (C1 C3 C5 C7) = CO
%else ; RGB_PIXELSIZE == 4 ; -----------
.column_ld1:
test cl, SIZEOF_MMWORD / 8
jz short .column_ld2
sub ecx, byte SIZEOF_MMWORD / 8
movd mmA, dword [esi + ecx * RGB_PIXELSIZE]
.column_ld2:
test cl, SIZEOF_MMWORD / 4
jz short .column_ld4
sub ecx, byte SIZEOF_MMWORD / 4
movq mmF, mmA
movq mmA, MMWORD [esi + ecx * RGB_PIXELSIZE]
.column_ld4:
test cl, SIZEOF_MMWORD / 2
mov ecx, SIZEOF_MMWORD
jz short .rgb_gray_cnv
movq mmD, mmA
movq mmC, mmF
movq mmA, MMWORD [esi + 0 * SIZEOF_MMWORD]
movq mmF, MMWORD [esi + 1 * SIZEOF_MMWORD]
jmp short .rgb_gray_cnv
ALIGNX 16, 7
.columnloop:
movq mmA, MMWORD [esi + 0 * SIZEOF_MMWORD]
movq mmF, MMWORD [esi + 1 * SIZEOF_MMWORD]
movq mmD, MMWORD [esi + 2 * SIZEOF_MMWORD]
movq mmC, MMWORD [esi + 3 * SIZEOF_MMWORD]
.rgb_gray_cnv:
; NOTE: The values of RGB_RED, RGB_GREEN, and RGB_BLUE determine the
; mapping of components A, B, C, and D to red, green, and blue.
;
; mmA = (A0 B0 C0 D0 A1 B1 C1 D1)
; mmF = (A2 B2 C2 D2 A3 B3 C3 D3)
; mmD = (A4 B4 C4 D4 A5 B5 C5 D5)
; mmC = (A6 B6 C6 D6 A7 B7 C7 D7)
movq mmB, mmA
punpcklbw mmA, mmF ; mmA = (A0 A2 B0 B2 C0 C2 D0 D2)
punpckhbw mmB, mmF ; mmB = (A1 A3 B1 B3 C1 C3 D1 D3)
movq mmG, mmD
punpcklbw mmD, mmC ; mmD = (A4 A6 B4 B6 C4 C6 D4 D6)
punpckhbw mmG, mmC ; mmG = (A5 A7 B5 B7 C5 C7 D5 D7)
movq mmE, mmA
punpcklwd mmA, mmD ; mmA = (A0 A2 A4 A6 B0 B2 B4 B6)
punpckhwd mmE, mmD ; mmE = (C0 C2 C4 C6 D0 D2 D4 D6)
movq mmH, mmB
punpcklwd mmB, mmG ; mmB = (A1 A3 A5 A7 B1 B3 B5 B7)
punpckhwd mmH, mmG ; mmH = (C1 C3 C5 C7 D1 D3 D5 D7)
pxor mmF, mmF
movq mmC, mmA
punpcklbw mmA, mmF ; mmA = (A0 A2 A4 A6) = AE
punpckhbw mmC, mmF ; mmC = (B0 B2 B4 B6) = BE
movq mmD, mmB
punpcklbw mmB, mmF ; mmB = (A1 A3 A5 A7) = AO
punpckhbw mmD, mmF ; mmD = (B1 B3 B5 B7) = BO
movq mmG, mmE
punpcklbw mmE, mmF ; mmE = (C0 C2 C4 C6) = CE
punpckhbw mmG, mmF ; mmG = (D0 D2 D4 D6) = DE
punpcklbw mmF, mmH
punpckhbw mmH, mmH
psrlw mmF, BYTE_BIT ; mmF = (C1 C3 C5 C7) = CO
psrlw mmH, BYTE_BIT ; mmH = (D1 D3 D5 D7) = DO
%endif ; RGB_PIXELSIZE ; ---------------
; mm0 = (R0 R2 R4 R6) = RE
; mm2 = (G0 G2 G4 G6) = GE
; mm4 = (B0 B2 B4 B6) = BE
; mm1 = (R1 R3 R5 R7) = RO
; mm3 = (G1 G3 G5 G7) = GO
; mm5 = (B1 B3 B5 B7) = BO
;
; (Original)
; Y = 0.29900 * R + 0.58700 * G + 0.11400 * B
;
; (This implementation)
; Y = 0.29900 * R + 0.33700 * G + 0.11400 * B + 0.25000 * G
movq mm6, mm1
punpcklwd mm1, mm3
punpckhwd mm6, mm3
pmaddwd mm1, [GOTOFF(eax, PW_F0299_F0337)]
; mm1 = ROL * FIX(0.299) + GOL * FIX(0.337)
pmaddwd mm6, [GOTOFF(eax, PW_F0299_F0337)]
; mm6 = ROH * FIX(0.299) + GOH * FIX(0.337)
movq mm7, mm6
; mm7 = ROH * FIX(0.299) + GOH * FIX(0.337)
movq mm6, mm0
punpcklwd mm0, mm2
punpckhwd mm6, mm2
pmaddwd mm0, [GOTOFF(eax, PW_F0299_F0337)]
; mm0 = REL * FIX(0.299) + GEL * FIX(0.337)
pmaddwd mm6, [GOTOFF(eax, PW_F0299_F0337)]
; mm6 = REH * FIX(0.299) + GEH * FIX(0.337)
movq MMWORD [wk(0)], mm0
; wk(0) = REL * FIX(0.299) + GEL * FIX(0.337)
movq MMWORD [wk(1)], mm6
; wk(1) = REH * FIX(0.299) + GEH * FIX(0.337)
movq mm0, mm5 ; mm0 = BO
movq mm6, mm4 ; mm6 = BE
movq mm4, mm0
punpcklwd mm0, mm3
punpckhwd mm4, mm3
pmaddwd mm0, [GOTOFF(eax, PW_F0114_F0250)]
; mm0 = BOL * FIX(0.114) + GOL * FIX(0.250)
pmaddwd mm4, [GOTOFF(eax, PW_F0114_F0250)]
; mm4 = BOH * FIX(0.114) + GOH * FIX(0.250)
movq mm3, [GOTOFF(eax, PD_ONEHALF)] ; mm3 = [PD_ONEHALF]
paddd mm0, mm1
paddd mm4, mm7
paddd mm0, mm3
paddd mm4, mm3
psrld mm0, SCALEBITS ; mm0 = YOL
psrld mm4, SCALEBITS ; mm4 = YOH
packssdw mm0, mm4 ; mm0 = YO
movq mm4, mm6
punpcklwd mm6, mm2
punpckhwd mm4, mm2
pmaddwd mm6, [GOTOFF(eax, PW_F0114_F0250)]
; mm6 = BEL * FIX(0.114) + GEL * FIX(0.250)
pmaddwd mm4, [GOTOFF(eax, PW_F0114_F0250)]
; mm4 = BEH * FIX(0.114) + GEH * FIX(0.250)
movq mm2, [GOTOFF(eax, PD_ONEHALF)] ; mm2 = [PD_ONEHALF]
paddd mm6, MMWORD [wk(0)]
paddd mm4, MMWORD [wk(1)]
paddd mm6, mm2
paddd mm4, mm2
psrld mm6, SCALEBITS ; mm6 = YEL
psrld mm4, SCALEBITS ; mm4 = YEH
packssdw mm6, mm4 ; mm6 = YE
psllw mm0, BYTE_BIT
por mm6, mm0 ; mm6 = Y
movq MMWORD [edi], mm6 ; Save Y
sub ecx, byte SIZEOF_MMWORD
add esi, byte RGB_PIXELSIZE * SIZEOF_MMWORD ; inptr
add edi, byte SIZEOF_MMWORD ; outptr0
cmp ecx, byte SIZEOF_MMWORD
jae near .columnloop
test ecx, ecx
jnz near .column_ld1
pop ecx ; col
pop esi
pop edi
POPPIC eax
add esi, byte SIZEOF_JSAMPROW ; input_buf
add edi, byte SIZEOF_JSAMPROW
dec eax ; num_rows
jg near .rowloop
emms ; empty MMX state
.return:
pop edi
pop esi
; pop edx ; need not be preserved
; pop ecx ; need not be preserved
pop ebx
mov esp, ebp ; esp <- aligned ebp
pop esp ; esp <- original ebp
pop ebp
ret
; For some reason, the OS X linker does not honor the request to align the
; segment unless we do this.
align 32