thodg/libgit2/tests-clar/commit/commit.c

• Show log

  Commit

• Hash : 9094d30b
  Author :
  Date : 2012-11-23T11:41:56
  

  Reset all static variables to NULL in clar's __cleanup Without this change, any failed assertion in the second (or a later) test inside a test suite has a chance of double deleting memory, resulting in a heap corruption. See #1096 for details. This leaves alone the test cases where we "just" use cl_git_sandbox_init() and cl_git_sandbox_cleanup(). These methods already take good care to not double delete a repository. Fixes #1096

Download

• tests-clar/commit/commit.c

• #include "clar_libgit2.h"
  
  static git_repository *_repo;
  
  void test_commit_commit__initialize(void)
  {
  	cl_fixture_sandbox("testrepo.git");
  	cl_git_pass(git_repository_open(&_repo, "testrepo.git"));
  }
  
  void test_commit_commit__cleanup(void)
  {
  	git_repository_free(_repo);
  	_repo = NULL;
  
  	cl_fixture_cleanup("testrepo.git");
  }
  
  void test_commit_commit__create_unexisting_update_ref(void)
  {
  	git_oid oid;
  	git_tree *tree;
  	git_commit *commit;
  	git_signature *s;
  	git_reference *ref;
  
  	git_oid_fromstr(&oid, "a65fedf39aefe402d3bb6e24df4d4f5fe4547750");
  	cl_git_pass(git_commit_lookup(&commit, _repo, &oid));
  
  	git_oid_fromstr(&oid, "944c0f6e4dfa41595e6eb3ceecdb14f50fe18162");
  	cl_git_pass(git_tree_lookup(&tree, _repo, &oid));
  
  	cl_git_pass(git_signature_now(&s, "alice", "alice@example.com"));
  
  	cl_git_fail(git_reference_lookup(&ref, _repo, "refs/heads/foo/bar"));
  	cl_git_pass(git_commit_create(&oid, _repo, "refs/heads/foo/bar", s, s,
  				      NULL, "some msg", tree, 1, (const git_commit **) &commit));
  
  	cl_git_pass(git_reference_lookup(&ref, _repo, "refs/heads/foo/bar"));
  	cl_assert(!git_oid_cmp(&oid, git_reference_oid(ref)));
  
  	git_tree_free(tree);
  	git_commit_free(commit);
  	git_signature_free(s);
  	git_reference_free(ref);
  }
  

Download