thodg/libgit2/tests-clar/revwalk/signatureparsing.c

• Show log

  Commit

• Hash : 9094d30b
  Author :
  Date : 2012-11-23T11:41:56
  

  Reset all static variables to NULL in clar's __cleanup Without this change, any failed assertion in the second (or a later) test inside a test suite has a chance of double deleting memory, resulting in a heap corruption. See #1096 for details. This leaves alone the test cases where we "just" use cl_git_sandbox_init() and cl_git_sandbox_cleanup(). These methods already take good care to not double delete a repository. Fixes #1096

Download

• tests-clar/revwalk/signatureparsing.c

• #include "clar_libgit2.h"
  
  static git_repository *_repo;
  static git_revwalk *_walk;
  
  void test_revwalk_signatureparsing__initialize(void)
  {
  	cl_git_pass(git_repository_open(&_repo, cl_fixture("testrepo.git")));
  	cl_git_pass(git_revwalk_new(&_walk, _repo));
  }
  
  void test_revwalk_signatureparsing__cleanup(void)
  {
  	git_revwalk_free(_walk);
  	_walk = NULL;
  
  	git_repository_free(_repo);
  	_repo = NULL;
  }
  
  void test_revwalk_signatureparsing__do_not_choke_when_name_contains_angle_brackets(void)
  {
  	git_reference *ref;
  	git_oid commit_oid;
  	git_commit *commit;
  	const git_signature *signature;
  
  	/*
  	 * The branch below points at a commit with angle brackets in the committer/author name
  	 * committer <Yu V. Bin Haacked> <foo@example.com> 1323847743 +0100
  	 */
  	cl_git_pass(git_reference_lookup(&ref, _repo, "refs/heads/haacked"));
  
  	git_revwalk_push(_walk, git_reference_oid(ref));
  	cl_git_pass(git_revwalk_next(&commit_oid, _walk));
  
  	cl_git_pass(git_commit_lookup(&commit, _repo, git_reference_oid(ref)));
  
  	signature = git_commit_committer(commit);
  	cl_assert_equal_s("Yu V. Bin Haacked", signature->email);
  	cl_assert_equal_s("", signature->name);
  	cl_assert_equal_i(1323847743, (int)signature->when.time);
  	cl_assert_equal_i(60, signature->when.offset);
  
  	git_commit_free(commit);
  	git_reference_free(ref);
  }
  

Download