thodg/libgit2/tests-clar/notes/notesref.c

• Show log

  Commit

• Hash : 9094d30b
  Author :
  Date : 2012-11-23T11:41:56
  

  Reset all static variables to NULL in clar's __cleanup Without this change, any failed assertion in the second (or a later) test inside a test suite has a chance of double deleting memory, resulting in a heap corruption. See #1096 for details. This leaves alone the test cases where we "just" use cl_git_sandbox_init() and cl_git_sandbox_cleanup(). These methods already take good care to not double delete a repository. Fixes #1096

Download

• tests-clar/notes/notesref.c

• #include "clar_libgit2.h"
  
  #include "notes.h"
  
  static git_repository *_repo;
  static git_note *_note;
  static git_signature *_sig;
  static git_config *_cfg;
  
  void test_notes_notesref__initialize(void)
  {
  	cl_fixture_sandbox("testrepo.git");
  	cl_git_pass(git_repository_open(&_repo, "testrepo.git"));
  }
  
  void test_notes_notesref__cleanup(void)
  {
  	git_note_free(_note);
  	_note = NULL;
  
  	git_signature_free(_sig);
  	_sig = NULL;
  
  	git_config_free(_cfg);
  	_cfg = NULL;
  
  	git_repository_free(_repo);
  	_repo = NULL;
  
  	cl_fixture_cleanup("testrepo.git");
  }
  
  void test_notes_notesref__config_corenotesref(void)
  {
  	git_oid oid, note_oid;
  	const char *default_ref;
  
  	cl_git_pass(git_signature_now(&_sig, "alice", "alice@example.com"));
  	cl_git_pass(git_oid_fromstr(&oid, "8496071c1b46c854b31185ea97743be6a8774479"));
  
  	cl_git_pass(git_repository_config(&_cfg, _repo));
  
  	cl_git_pass(git_config_set_string(_cfg, "core.notesRef", "refs/notes/mydefaultnotesref"));
  
  	cl_git_pass(git_note_create(&note_oid, _repo, _sig, _sig, NULL, &oid, "test123test\n"));
  
  	cl_git_pass(git_note_read(&_note, _repo, NULL, &oid));
  	cl_assert(!strcmp(git_note_message(_note), "test123test\n"));
  	cl_assert(!git_oid_cmp(git_note_oid(_note), &note_oid));
  
  	git_note_free(_note);
  
  	cl_git_pass(git_note_read(&_note, _repo, "refs/notes/mydefaultnotesref", &oid));
  	cl_assert(!strcmp(git_note_message(_note), "test123test\n"));
  	cl_assert(!git_oid_cmp(git_note_oid(_note), &note_oid));
  
  	cl_git_pass(git_note_default_ref(&default_ref, _repo));
  	cl_assert(!strcmp(default_ref, "refs/notes/mydefaultnotesref"));
  
  	cl_git_pass(git_config_delete(_cfg, "core.notesRef"));
  
  	cl_git_pass(git_note_default_ref(&default_ref, _repo));
  	cl_assert(!strcmp(default_ref, GIT_NOTES_DEFAULT_REF));
  }
  

Download