thodg/libgit2/tests-clar/repo/setters.c

• Show log

  Commit

• Hash : c1aefb35
  Author :
  Date : 2012-04-14T14:13:17
  

  Fix git_repository_set_index() refcount issue
  
  git_repository_free() calls git_index_free() if the owned index is not null.
  
  According to the doc, when setting a new index through git_repository_set_index() the caller has still to take care of releasing the index by itself.
  
  In order to cope with this, this fix makes sure the index refcount is incremented when a new repository is being plugged a new index.
  

Download

• tests-clar/repo/setters.c

• #include "clar_libgit2.h"
  #include "buffer.h"
  #include "posix.h"
  #include "util.h"
  
  static git_repository *repo;
  
  void test_repo_setters__initialize(void)
  {
  	cl_fixture_sandbox("testrepo.git");
  	cl_git_pass(git_repository_open(&repo, "testrepo.git"));
  	cl_must_pass(p_mkdir("new_workdir", 0777));
  }
  
  void test_repo_setters__cleanup(void)
  {
  	git_repository_free(repo);
  	cl_fixture_cleanup("testrepo.git");
  	cl_must_pass(p_rmdir("new_workdir"));
  }
  
  void test_repo_setters__setting_a_workdir_turns_a_bare_repository_into_a_standard_one(void)
  {
  	cl_assert(git_repository_is_bare(repo) == 1);
  
  	cl_assert(git_repository_workdir(repo) == NULL);
  	cl_git_pass(git_repository_set_workdir(repo, "./new_workdir"));
  
  	cl_assert(git_repository_workdir(repo) != NULL);
  	cl_assert(git_repository_is_bare(repo) == 0);
  }
  
  void test_repo_setters__setting_a_workdir_prettifies_its_path(void)
  {
  	cl_git_pass(git_repository_set_workdir(repo, "./new_workdir"));
  
  	cl_assert(git__suffixcmp(git_repository_workdir(repo), "/") == 0);
  }
  
  void test_repo_setters__setting_a_new_index_on_a_repo_which_has_already_loaded_one_properly_honors_the_refcount(void)
  {
  	git_index *new_index;
  
  	cl_git_pass(git_index_open(&new_index, "./my-index"));
  	cl_assert(((git_refcount *)new_index)->refcount == 1);
  
  	git_repository_set_index(repo, new_index);
  	cl_assert(((git_refcount *)new_index)->refcount == 2);
  
  	git_repository_free(repo);
  	cl_assert(((git_refcount *)new_index)->refcount == 1);
  
  	git_index_free(new_index);
  
  	/* 
  	 * Ensure the cleanup method won't try to free the repo as it's already been taken care of
  	 */
  	repo = NULL;
  }
  

Download