IABSD.fr/src/usr.sbin/pkg_add

Branch :


Log

Author Commit Date CI Message
89643495 2020-06-22 13:21:29 add missing .Pp
17fabd8f 2020-06-09 20:16:12 Show a message while pkg_add updates the font cache. This occurs at the end of an install and can take quite a while if you have certain fonts installed. Before this change the cursor was left at an empty line. tweak/ok espie@
14093141 2020-05-17 14:34:47 in order for PKG_CACHE to work, skipped entries at the end should still be read. This happens for packages ending in symlinks for instance. this should fix some fringe cases where FETCH_PACKAGES doesn't work
48c01a1f 2020-04-23 21:28:08 ce examples of "Ar arg Ar arg" with "Ar arg arg" and stop the spread;
044f8b13 2020-03-26 19:31:39 Add support for "alpha" suffixes in package versions We already supported "beta" releases but not "alpha", probably to discourage people from pushing "alpha-quality" software in the ports tree. We have 30 ports with distfiles matching "alpha", and people just work around the lack of explicit support for "alpha" releases with mixes of crafted PKGNAME and REVISION/EPOCH. This looks needlessly complicated and a bit unfair when compared to GH_COMMIT support. Pointers from landry@ and sthen@, lgtm landry@, no objection from espie@
ba8d8ac8 2020-02-20 16:44:01 document no debug
3852ac0e 2020-02-20 16:40:49 forgot to actually put "nodebug" in state
c1cf5f13 2020-02-20 16:31:11 make shell "with debug info" by default and add a bit of code to mark stuff "no debug" eventually
14f1c896 2020-02-19 14:24:19 document new option combo
9944c58c 2020-02-19 14:23:26 refactor opt('Q') into its own code make sure we see -a along with opt('Q') tweak -aQ to use keep_all so that it shows every entry in every repository instead of stopping at the first one.
5781d503 2020-02-19 14:22:29 allow search objects to say "keep_all" and make PackageRepositoryLists aware of that for match_locations
3117a295 2020-02-19 10:53:53 Separate singular and plural
eb41c443 2020-02-18 11:29:16 have description of -Q match reality
449f4b76 2020-02-17 13:06:45 future replacement for PackageInfo.pm - the name was a bit confusing (pkg_info) - one of the first modules I wrote, and the old one isn't OO at all, and full of globals, which can be a problem for displaying error messages, and for tweaking PKG_DB locally... This will replace PackageInfo.pm once I've gone through all the callers. New synopsis would make this part of State in most cases, without any singleton.
3951cf8e 2020-02-11 16:20:05 add iwx to fw_update
a298a0f0 2020-01-28 16:00:24 banish implicit return
47df9083 2020-01-28 11:25:44 match opendir with closedir... not that important as the thing was most probably GC'd.
1f5a264f 2020-01-26 12:50:17 give pkg_create knowledge of WRKOBJDIR, so it can error out if a symlink points in there. okay aja@ sthen@
7cf1e51a 2020-01-24 21:10:46 Add FILES sections; OK espie@ solene@. Triggered because Claus Assmann observed on ports@ that the pkg_add(1) manual page didn't mention pkg-readmes.
867f1c35 2020-01-13 13:11:31 nit, use "fatal" with parameters as intended
3c025a5e 2020-01-11 13:46:39 debug-> pkg-debug defines It's only used for debugging pkgtools, it shouldn't interfere with possible flavors in pkg_create
8660d718 2020-01-09 11:01:25 have ask_tree be more specific in its error reporting. make sure the child has the same effective and real ids, as perl interprets it as "setuid, refuse to debug" go to the end of the pipe so the child doesn't exit prematurely (didn't use to happen but now it does) help from afresh1@ in diagnosing that one.
9be7aa91 2020-01-05 14:18:40 In his original writeup, espie@ had the terse parenthetical remark "(yes/no answer instead of full list)" regarding how to use wantarray(). Flesh this out with an example and a bit of explanation to reduce the risk of misunderstandings and misuse. Discussed with espie@.
a0dc2e2b 2020-01-04 17:13:35 mention $DB::inhibit_exit; my wording after espie@ explained what he had in mind; OK espie@
f5485e73 2020-01-04 15:13:54 be a bit more precise about what %a and %v do in paths; OK espie@
a8b7ad7c 2020-01-04 13:48:49 New manual page OpenBSD::style(3p). Based on a writeup that espie@ posted to misc@ with tweaks by me and additional feedback from espie@.
130b115f 2020-01-02 12:27:04 plain forgot about THAT optimization. Let .so/.a print again in pkg_info -L noticed by Mikolaj Kucharski
396f4403 2019-12-29 10:40:16 partial backout of 1.166: we still need to compute the pkgname without the repo for debug packages, but we need the full path for the handle (for now) fixes regression noticed by bluhm@
e9bfaee7 2019-12-08 11:42:32 close the gap for the "final" hint that did not install debug packages (coincidentally, that's the pattern used for install from ports) This just requires always passing pkgname thru parse to extract the right name. There's definitely a bit of code to clean up in pkg_add afterwards :/
2d3c02b3 2019-12-08 10:35:17 have DEBUG_PKG_CACHE also apply to already installed packages, to help bootstrap the process Clean the code: - move the decision logic into individual may_grab_debug_for - acknowledge the PkgAdd object doesn't matter in there, just use class - for already installed stuff, we skip packages that already exist
ddab9625 2019-12-04 11:01:37 explicitly say you're not allowed to insert most of these yourself
7d2e2b80 2019-12-04 10:53:27 document DEBUG_PKG_CACHE
d66cb51d 2019-12-04 10:47:38 add DEBUG_PKG_CACHE functionality. Doesn't interfere with normal operation. Basically, if you set DEBUG_PKG_CACHE to a directory, pkg_add will download debug packages "on the sly" any time it installs packages. It is mostly silent (apart from fetching error or directory non existent). It *won't* download packages that are already installed, but this allows keeping debug packages "just in case" in synch with your current snapshot, as some people (mpi@) have worried that by the time you get to debugging something, the snapshots will have moved too much.
18aa9aed 2019-12-04 10:45:19 allow error to be passed along, in case we need to save $? for later
92bd379c 2019-11-16 11:07:43 preliminary addition of -d option (semantics: add debug packages if they're present along the packages we want to add/update) probably not perfect yet, but 100% a no-op if it's not used, so won't break existing usage.
b48a274e 2019-11-15 18:28:13 nicer order of multi-choice packages (by version if everything else is equal, alphabetically otherwise) prompted by claudio@, okay claudio@ kmos@
1ccb9c39 2019-11-12 16:37:48 document the new annotations corresponding to DEBUG_PACKAGES
67182e2f 2019-11-10 16:43:11 tweaks to the file hierarchy to annotate anything with debuginfo, so existing @bin @lib and new @static-lib @so as discussed with p2k19 people
58a0869c 2019-11-10 14:22:53 typo
e84fb231 2019-11-08 14:50:58 added too much for -stable, if ftp says 404, we still need to save that
9b2338bf 2019-11-07 15:36:51 when asking the ports tree, we fork a child. instead of ditching stderr entirely, keep it in a temp file, and if the child exits with an error, we got something to display. (note that returning and undef'd plist is enough of an error, just we had no clue what went wrong previously) aja@ ran into this a few weeks ago.
5f348c0b 2019-11-07 15:35:23 style nit
037c3067 2019-11-05 14:11:04 Add ogx to fw_update.
78895fa0 2019-10-23 16:48:13 adapt to new ftp(1) retrieving error messages
1abccbc6 2019-10-20 09:05:58 I didn't check robert's fix closely enough. fix it so commands are run when several fontdirs are involved also streamline the alias code a little bit, and have it report actual issues in opening files
19395269 2019-10-13 16:22:58 name value to shorten code
9d478369 2019-10-13 16:22:30 even in the empty case, use wantarray to properly return 0/an empty array.
84f70789 2019-10-13 16:21:46 - have a method explicitly return undef instead of falling off the end - old signatures have been dead for 3 years, time to remove mention of them in error messages
af4e06d4 2019-09-04 12:27:38 let collisionreport work better with FETCH_PACKAGES
56f6d8b7 2019-08-26 06:52:51 also pass the signature style
fddcf565 2019-08-25 19:06:36 synch with other changes. bug noticed by naddy@
2ace43a4 2019-08-21 19:21:57 Remove cdrom mention ok espie@
ea4bc424 2019-08-20 11:11:53 fix error reporting, specifically having two repos on the same site may lead to one repo closing handles from the other to avoid DoS, as exemplified by stable-packages. okay sthen@
bec7ad74 2019-08-19 12:25:40 -Pcdrom is nonsensical now, so error out properly on it. Prompted and okay danj@
96acc640 2019-08-19 12:09:07 add a special flag -DDONTLOG so that regress test won't spam /var/log/messages
662d38bb 2019-08-08 13:41:40 Fix typos in OpenBSD::Intro.3p and OpenBSD::PackingElement.3p.
91273194 2019-07-24 18:05:26 GC old catchall add a better framework for signal handling (not used yet)
500f0e86 2019-07-24 09:03:12 explain some details
5a29d933 2019-07-22 06:59:41 separate the atend behavior, because dpb wants a pure signal intercept but not an END code. This fixes the stupid bug I had. Was looking in the wrong location, not surprisingly
38cae932 2019-07-21 15:31:39 tweak register a bit... END {} code is obviously the problem
36137a65 2019-07-21 14:18:55 gc old functions, that part is clean as well... so it's obviously the END code then...
5a69ed8c 2019-07-21 14:05:30 start re-adding the non-broken changes: - commonalize try{} catch {} for pkg_add/delete and pkg_create, so that debug works the same way in both. - switch printing command name to the catch handler, so that exceptions are simpler to handle
8d7b263f 2019-07-17 19:00:55 backout previous commits for now; some of this is shared with dpb and results in problems. hints from pvk@ about what introduced the breakage we were seeing, who confirms that this backout fixes things; comitting early to unbreak package builds. ==== a bunch of changes, all related to error-handling: - have Handle->register also create a proper END block, so that individual packages don't have to, and explain the issue - kill old Unlink/Copy code that migrated to State years ago - commonalize try{} catch {} for pkg_add/delete and pkg_create, so that debug works the same way in both. - switch printing command name to the catch handler, so that exceptions are simpler to handle and a few comments for the hairy parts... Members: OpenBSD/AddCreateDelete.pm:1.44->1.45 OpenBSD/AddDelete.pm:1.87->1.88 OpenBSD/Error.pm:1.33->1.34 OpenBSD/PackageRepository.pm:1.164->1.165 OpenBSD/PkgCreate.pm:1.160->1.161 OpenBSD/State.pm:1.58->1.59 OpenBSD/Temp.pm:1.34->1.35 ====
d1d416e1 2019-07-14 07:27:18 a bunch of changes, all related to error-handling: - have Handle->register also create a proper END block, so that individual packages don't have to, and explain the issue - kill old Unlink/Copy code that migrated to State years ago - commonalize try{} catch {} for pkg_add/delete and pkg_create, so that debug works the same way in both. - switch printing command name to the catch handler, so that exceptions are simpler to handle and a few comments for the hairy parts...
d718bad4 2019-07-11 07:14:23 move the display of cmd into fatal, and don't say it's a fatal error, it's already obvious
4c589827 2019-07-11 07:03:45 tweak the way we report bugs - the catch/catchall distinction is no longer relevant, strip some info by default now - use state->{cmd} to display the command name properly This makes sure final displays show the command name.
75a64d30 2019-07-10 11:56:01 yet another last_error
80bdda31 2019-07-10 11:15:15 yet another error
eafacb8e 2019-07-10 11:13:06 use last_error
e23d57e0 2019-07-10 09:34:38 make the END{} block transparent for exit
05cd2ff7 2019-07-10 09:34:09 deal with temp dir creation failures. make the END{} block transparent for exit
5f6a26f8 2019-07-10 09:18:09 make pkg_create fail properly (return 1 is useless there) OpenBSD::Temp error handling as well
8a054d5e 2019-07-09 11:24:09 knob for testing, do not even look in installurl by default
17ddcb71 2019-07-08 11:50:01 uniform error messages on temp file creation
59e3a3af 2019-07-08 11:03:47 actually use error, we can delay fatal problems
3b99bc6f 2019-07-08 10:59:30 check ::Temp creation
c07cf433 2019-07-08 10:55:39 error out if we can't create the temp file
c7833d9a 2019-07-07 12:42:54 use last_error fix again tmpfile so that it fails as it should
8ad6a08c 2019-07-05 06:21:14 revisit die messages: remove extra "\n", add $! if needed, don't use string concat as die takes a list like print.
37530f25 2019-07-05 06:02:29 add the strerror to the error message
4c6ebb50 2019-07-04 15:25:16 PKG_TMPDIR now defaults to /tmp instead of /var/tmp
0495aebe 2019-07-04 15:08:27 get vartmp to point to /tmp
990752d1 2019-07-04 14:53:27 unhardcode error message, suggested by otto@
2619906e 2019-07-04 14:50:01 unbreak, mkdtemp returns a scalar found out the hard way by otto@
0fc00915 2019-07-04 09:47:09 gc old code (unused since it couldn't work without a state) hack "print" to do the right thing because it wouldn't. this will probably need some cleanse at some point, like doing smart_join in a smarter way.
1dbdf974 2019-07-03 13:48:08 refine the error handling useful to keep the last error from OpenBSD::Temp around, with all particulars
91450a69 2019-07-03 12:51:02 make error message more explicit, so that ppl don't get confused by the privsep
35135148 2019-06-30 14:57:25 refactor a bit of code: retrieve_fullname/retrieve_size, so that special files are a bit less special. Leave ::Sample for now
75ad74c9 2019-06-30 14:56:21 tweak short_print to commonalize stems if they all have the same version number. Adjust the other shortener for that.
6b05aa91 2019-06-09 18:58:06 move solve_dependency up, so that pkg_create is happy again sorry
3b8fb9cd 2019-06-09 12:16:07 somehow, I thought I was recording destdir there, but I'm not.
5c974d94 2019-06-09 09:36:24 with tags, we do look in deletesets add an extra indirection so we don't look where we actually can't because the code doesn't exist. (as seen by various people on somewhat buggy installs)
674fe0a0 2019-06-03 19:21:05 be better at finding a nice directory to extract temporary files (this should interface with vstat to avoid vanishing directories, but it's already better than it was)
3ca10ce7 2019-05-28 23:24:44 oops, let cdrom normalize if it's there. Noticed by sthen@
581f303d 2019-05-28 19:31:42 make PERMIT_CDROM info optional as discussed with sthen@, code slightly adjusted
610cc7c7 2019-05-26 15:55:11 reflect current reality it's much simpler now that md5 is entirely gone
635922eb 2019-05-26 15:48:26 document somewhat oldish improvements
17a802f7 2019-05-26 15:47:49 adjust comment. ArcCheck hasn't dealt with long names ever since OpenBSD::Ustar gained support for xhdr.
fd2dce79 2019-05-26 15:34:25 perl makewhatis has been dead a few years
b21d7bd4 2019-05-23 22:33:29 look for tag in self first, solves a fringe case where we could find the dependency in another version of the the same package first, and error out (see special case found_in_self).