Commit c4fca5bb4fcf8509cb93db6e20314f22994c093b

cptpcrd 2021-02-07T14:22:21

closefrom: Handle lowfd < 0 properly More important if close_range() is going to be used, since casting negative values to 'unsigned int' might hide the errors. [guillem@hadrons.org: Minor coding style fix. ] Signed-off-by: Guillem Jover <guillem@hadrons.org>

1
2
3
4
5
6
7
8
9
10
11
12
13
14
diff --git a/src/closefrom.c b/src/closefrom.c
index be38813..e2e10a8 100644
--- a/src/closefrom.c
+++ b/src/closefrom.c
@@ -179,6 +179,9 @@ closefrom_procfs(int lowfd)
 void
 closefrom(int lowfd)
 {
+	if (lowfd < 0)
+		lowfd = 0;
+
 	/* Try the fast method first, if possible. */
 #if defined(HAVE_FCNTL_CLOSEM)
 	if (fcntl(lowfd, F_CLOSEM, 0) != -1)