src


Log

Author Commit Date CI Message
Anthony Green 369ef49f 2018-03-18T12:53:42 Add missing FFI_GNUW64 enum
Anthony Green 43980dd1 2018-03-18T12:32:10 Add FFI_GNUW64 ABI for GNU 80-bit long double support
Anthony Green 9bc40d87 2018-03-18T12:32:10 Add FFI_GWIN64 ABI for GNU 80-bit long double support
Ryan C. Underwood d4640608 2018-03-18T07:00:42 Fully allocate file backing writable maps (#389) When ftruncate() is used on a filesystem supporting sparse files, space in the file is not actually allocated. Then, when the file is mmap'd and libffi writes to the mapping, SIGBUS is thrown to the calling application. Instead, always fully allocate the file that will back writable maps.
Anthony Green 6a801d04 2018-03-16T17:53:33 Fix closure case where 8-byte value is partially passed in register. Fixes cls_many_mixed_float_double test case.
Anthony Green 01db31d9 2018-03-13T20:41:55 Update moxie sub opcode
Stef O'Rear 3840d49a 2018-03-11T05:55:15 New RISC-V port (#281) * Add RISC-V support This patch adds support for the RISC-V architecture (https://riscv.org). This patch has been tested using QEMU user-mode emulation and GCC 7.2.0 in the following configurations: * -march=rv32imac -mabi=ilp32 * -march=rv32g -mabi=ilp32d * -march=rv64imac -mabi=lp64 * -march=rv64g -mabi=lp64d The ABI currently can be found at https://github.com/riscv/riscv-elf-psabi-doc/blob/master/riscv-elf.md . * Add RISC-V to README * RISC-V: fix configure.host
Anthony Green dca52b55 2018-03-11T08:50:01 Merge pull request #406 from trofi/master ia64: fix variadic function closures with FP arguments
Anthony Green 83d9aba3 2018-03-11T08:48:42 Merge pull request #407 from trofi/ia64-small-struct ia64: fix small struct return
Andreas Schwab e66fd678 2018-02-20T10:47:09 Revert "Fix passing struct by value on aarch64" This reverts commit 482b37f00467325e3389bab322525099860dd9aa. That was actually a bug in python, see <https://bugs.python.org/issue30353>.
Sergei Trofimovich b58caef7 2018-02-17T19:00:40 ia64: fix small struct return This change fixes libffi.call/struct10.c failure on ia64: FAIL: libffi.call/struct10.c -W -Wall -Wno-psabi -O0 execution test .Lst_small_struct handles returns for structs less than 32 bytes (following ia64 return value ABI [1]). Subroutine does roughly the following: ``` mov [sp+0] = r8 mov [sp+8] = r9 mov [sp+16] = r10 mov [sp+24] = r11 memcpy(destination, source=sp, 12); ``` The problem: ia64 ABI guarantees that top 16 bytes of stack are scratch space for callee function. Thus it can clobber it. [1] says (7.1 Procedure Frames): """ * Scratch area. This 16-byte region is provided as scratch storage for procedures that are called by the current procedure. Leaf procedures do not need to allocate this region. A procedure may use the 16 bytes at the top of its own frame as scratch memory, but the contents of this area are not preserved by a procedure call. """ In our case 16 top bytes are clobbered by a PLT resolver when memcpy() is called for the first time. As a result memcpy implementation reads already clobbered data frop top of stack. The fix is simple: allocate 16 bytes of scrats space prior to memcpy() call. [1]: https://www.intel.com/content/dam/www/public/us/en/documents/guides/itanium-software-runtime-architecture-guide.pdf Bug: https://bugs.gentoo.org/634190 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Sergei Trofimovich 11de69dd 2018-02-11T11:29:39 ia64: fix variadic function closures with FP arguments libffi test framework already flagged failures as: ``` FAIL: libffi.call/cls_double_va.c -W -Wall -Wno-psabi -O0 output pattern test, is 7.0 res: 4 0.0 res: 4 ? should match 7.0 ?es: 4 ?.0 res: 4 ``` Failure happens here at ```c // testsuite/libffi.call/cls_double_va.c ... char* format = "%.1f\n"; double doubleArg = 7; ... CHECK(ffi_prep_closure_loc(pcl, &cif, cls_double_va_fn, NULL, code) == FFI_OK); res = ((int(*)(char*, ...))(code))(format, doubleArg); ``` libffi expects 'doubleArg' to be located in 'f9' (second FP argument) but gcc placed it to 'r33' (second GR). ia64 software [1] manual described argument passing ABI in "8.5.2 Register Parameters" as: """ If an actual parameter is known to correspond to a floating-point formal parameter, the following rules apply: a) The actual parameter is passed in the next available floating-point parameter register, if one is available. Floating-point parameter registers are allocated as needed from the range f8-f15, starting with f8. b) If all available floating-point parameter registers have been used, the actual parameter is passed in the appropriate general register(s). (This case can occur only as a result of homogeneous floating-point aggregates, described below.) If a floating-point actual parameter is known to correspond to a variable-argument specification in the formal parameter list, the following rule applies: c) The actual parameter is passed in the appropriate general register(s). If the compiler cannot determine, at the point of call, whether the corresponding formal parameter is a varargs parameter, it must generate code that satisfies both of the above conditions. (The compiler’s determination may be based on prototype declarations, language standard assumptions, analysis, or other user options or information.) """ We have [c] case here and gcc uses only GR for parameter passing. The change binds known variadic arguments ro GRs instead of FPs as those are always expected to be initialized for all variadic call types. This fixes all 10 failures on ia64-unknown-linux-gnu: ``` === libffi Summary === -# of expected passes 1945 -# of unexpected failures 10 + +# of expected passes 1955 ``` [1]: https://www.intel.com/content/dam/www/public/us/en/documents/guides/itanium-software-runtime-architecture-guide.pdf Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Anthony Green 9429968b 2018-02-10T23:23:33 Merge pull request #403 from frida/fix/x86-sysv-pic-closure-regression Fix x86 SysV closure in PIC mode
Andreas Schwab 482b37f0 2017-09-18T12:44:08 Fix passing struct by value on aarch64 This fixes the ctypes test in the python testsuite.
Ole André Vadla Ravnås 28d3b61b 2018-01-20T23:56:17 Fix x86 SysV closure in PIC mode The assembly single-line comments swallowed up the remaining assembly code of the macros due to lack of line-endings. This is a regression introduced in b7f6d7a.
Anthony Green bec6135d 2018-01-10T07:20:04 Merge pull request #393 from thejunkjon/master Linker error "recompile with -fPIC" for x86_64
YunQiang Su 746dbe3a 2018-01-03T10:07:41 mips/ffi.c: fix encoding for jr on r6 mips/ffi.c: instruction jr has a different encoding for r6
YunQiang Su 94c102aa 2017-12-10T14:25:01 Not set mips on mips r6 MIPS release changed encodes of some instructions, include ll/sc etc. if .set mips4 on mips r6, as will generate some wrong encode of some instructions.
jon d15581c6 2017-12-01T00:34:30 Updating calls to ffi_closure_unix64_inner and ffi_closure_win64_inner to use PLT. Without this fix, statically linking libffi causes the linker error i.e. 'requires dynamic R_X86_64_PC32 reloc against ffi_closure_unix64_inner which may overflow at runtime; recompile with -fPIC)'
Anthony Green 4fdbb057 2017-11-03T07:05:31 Merge pull request #320 from 0-wiz-0/master Support NetBSD with mprotect.
Anthony Green b302bc3d 2017-11-03T07:03:55 Merge pull request #322 from compnerd/aarch64-base aarch64: fix index base register for AArch64
Yen Chi Hsuan 9fc9dc53 2017-10-27T16:12:56 Fix linux detection (closes #303)
Saleem Abdulrasool 1fb788ac 2017-10-10T11:37:00 aarch64: fix index base register for AArch64 The base is passed in `x3`, not in `x2`. This fixes the indexing base so that the right value is used.
Anthony Green dc2ff5ba 2017-10-25T13:11:40 Merge pull request #323 from compnerd/x86-alloca-alignment x86: align alloca to 16-byte boundary
Anthony Green 927da716 2017-10-25T13:05:53 Merge pull request #379 from jlj/master Xcode build improvements
Anthony Green a0455c03 2017-10-25T13:04:23 Merge pull request #383 from hjl-tools/hjl/master Hjl/master
H.J. Lu 9d9d92b4 2017-10-25T04:59:31 Skip WIN64/EFI64 support for x32 Since x32 doesn't support WIN64/EFI64, skip it if __ILP32__ is defined.
Saleem Abdulrasool 3c372c38 2017-10-24T13:53:56 arm: fix a level of indirection issue Rather than relying on the stack being 0'ed out always, do it manually. The stack generally happened to be zero, and because the compiler realizes that the tests are dealing with chars truncates the read value. However, the top 3 nibbles of the value are undefined and may be non-zero. The indirection level caused a null-pointer dereference. Explicitly scribbling on the stack during the allocation causes test failures without the original zexting behaviour.
Jean-Luc Jumpertz 181fc4cc 2017-10-23T15:02:29 Merge branch 'master' based on ksjogo/libffi Added a tvOS target in Xcode project. Misc Xcode project cleanup. Fix macOS build target in Xcode project. # Conflicts: # src/aarch64/ffi.c # src/x86/ffi64.c
Saleem Abdulrasool 79d1509c 2017-10-10T11:39:45 x86: align alloca to 16-byte boundary Align the stack allocation to a 16-byte boundary. This ensures that the stack parameters are 16-byte aligned which is needed for some instructions.
Sergei Trofimovich ed7488c0 2017-10-17T13:00:51 src/ia64/unix.S: unbreak small struct handling commit 6e8a4460833594d5af1b4539178025da0077df19 added FFI_TYPE_COMPLEX value type (comes after FFI_TYPE_POINTER) ia64 ffi_closure_unix reiles on the ordering of FFI_ enums as ia64 has ia64-specific FFI types: small struct and FPU extesions. As a result all tests handling small structs broke. The change fixes dispatch table by adding (no-op) FFI_TYPE_COMPLEX entry This has positive effect of unbreaking most tests on ia64: === libffi Summary === -# of expected passes 1595 -# of unexpected failures 295 +# of expected passes 1930 +# of unexpected failures 10 # of unsupported tests 30 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Saleem Abdulrasool 7ad0ae7f 2017-10-10T11:44:05 arm: zext return value parameters The closure function (invoked as closure->fun in ffi_closure_XXX_inner) will only populate the actual number of bytes for the true return type, which may be a character. This leaves garbage on the stack when the assembly closure function (i.e. ffi_closure_XXX) reads the return value off of the stack into r0 as a 4-byte value. ffi_closure_XXX always leaves room for at least 4 bytes here, so we can safely set them to 0. Otherwise, if there is garbage in any of these bytes, these end up in r0 and in the returned value as well.
Joerg Sonnenberger 2bfcd299 2017-10-02T15:34:03 Support NetBSD with mprotect. Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Anthony Green 93d8e7dd 2017-09-27T21:51:34 Fix #265
Anthony Green 02a5145a 2017-09-27T21:43:03 Merge pull request #263 from ksjogo/master fix ios builds
Anthony Green 10099d6c 2017-09-27T20:54:09 Merge pull request #271 from frida/fix/qnx-cache-flushing arm: Fix cache flushing on QNX
Anthony Green db4dad97 2017-09-27T20:47:08 Merge pull request #312 from fjricci/fix_ub Fix misaligned memory access in ffi_call_int
Jean-Luc Jumpertz a78da739 2017-09-04T15:55:34 Fix macOS build target in Xcode project. - Add missing files for desktop platforms in generate-darwin-source-and-headers.py, and in the Xcode project. - Add a static library target for macOS. - Fix "implicit conversion loses integer precision" warnings for iOS mad macOS targets.
Francis Ricci 9c12209d 2017-08-03T10:46:28 Fix misaligned memory access in ffi_call_int
Tony Reix 0ff9419f 2017-05-17T14:57:53 This patch enables FFI Go Closure on AIX.
Gregory Pakosz bd72848c 2017-04-27T13:20:36 Prefix ALIGN macros with FFI_
Ole André Vadla Ravnås 57d8ff04 2017-03-15T01:43:11 Simplify iOS trampoline table allocation By using VM_FLAGS_OVERWRITE there is no need for speculatively allocating on a page we just deallocated. This approach eliminates the race-condition and gets rid of the retry logic.
Johannes Goslar 00406945 2016-07-12T16:08:42 Update Xcodeproj Include all currently relevent files. Call autogen is build script. Fix compiler settings. Fix mach include.
Anthony Green a94c999b 2017-03-19T07:36:07 Handle fastcall declaration differently for some Microsoft compilers
Anthony Green a0b14eea 2017-03-17T09:20:40 Merge pull request #291 from ramon-garcia/visual-studio-build Build with Visual C++ (64 bits)
Ole André Vadla Ravnås 5e4fcdcc 2017-03-15T01:43:11 Simplify iOS trampoline table allocation By using VM_FLAGS_OVERWRITE there is no need for speculatively allocating on a page we just deallocated. This approach eliminates the race-condition and gets rid of the retry logic.
Ole André Vadla Ravnås d42ce7b9 2017-03-15T01:23:40 Fix error path so mutex is unlocked before returning In the unusual case where ffi_trampoline_table_alloc() fails.
Ramón García Fernández 1e0d107b 2017-01-08T20:12:59 Modify configure.host to detect compilation with Microsoft Visual C++ and use assembly with Intel syntax in that case
Richard Henderson 256ce51c 2016-09-01T13:54:51 Merge pull request #273 from wbx-github/master m68k: support ISA-A Coldfire CPUs
Richard Henderson 2ded2a4f 2016-09-01T13:30:45 Merge pull request #272 from yousong/mips64-soft-float Mips64 soft float
Yuriy Kolerov b545ff81 2016-08-23T20:23:37 ARC: Remove unused variable Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
Waldemar Brodkorb 52a11f6d 2016-08-20T00:52:19 m68k: support ISA-A Coldfire CPUs Fix compilation for m68k/coldfire CPUs like mcf5208. Signed-off-by: Thorsten Glaser <tg@mirbsd.de> Signed-off-by: Waldemar Brodkorb <wbx@uclibc-ng.org>
Yousong Zhou 7a0d2c83 2016-08-15T15:00:13 mips: fix MIPS softfloat build issue The patch for o32.S is taken from OpenWrt packages repo 3a7a4bf "libffi: fix MIPS softfloat build issue with current binutils" Signed-off-by: Felix Fietkau <nbd@openwrt.org> Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
Tom Tromey 06d7c519 2016-08-10T15:06:16 Merge pull request #269 from frida/fix/aarch64-variadic-closures-on-ios aarch64: Fix handling of variadic closures on iOS
Tom Tromey aa7ed78c 2016-08-10T15:03:37 Merge pull request #268 from frida/fix/aarch64-large-aggregates aarch64: Fix handling of aggregates larger than 16 bytes
Ole André Vadla Ravnås 4da814b1 2016-08-10T22:48:09 aarch64: Fix handling of aggregates larger than 16 bytes Instead of allocating stack space for a pointer we would allocate stack space for the actual aggregate size.
s1341 ed848834 2016-08-10T14:57:22 arm: Fix cache flushing on QNX Use `msync()` directly as `__clear_cache()` is broken in the qnx650_gcc4.8.3 toolchain.
Ole André Vadla Ravnås 5e9ac7e2 2016-08-10T15:22:19 aarch64: Fix warning about unused function on iOS
Ole André Vadla Ravnås 4d1f11f6 2016-08-10T15:21:42 aarch64: Fix operand size warning reported by Clang
Ole André Vadla Ravnås 301166b1 2016-08-10T15:59:56 aarch64: Fix handling of variadic closures on iOS
Tom Tromey cf4b2a50 2016-06-17T10:09:44 Don't dereference "ecif" before NULL check Fixes #260
Richard Henderson 794a54d4 2016-06-05T14:57:00 Mark win64.S with GNU-stack note
Iain Sandoe 52fbd12d 2016-05-26T09:00:00 [Darwin-ppc, build] Fixes for clang build. clang is experimental on powerpc-darwin, but the changes are appropriate to cctools as as well. Use the 'official' simplified cmpwi insn, rather than the implied one accepted by cctools. Do not re-use a set value.
Iain Sandoe 92810b4b 2016-05-26T08:56:51 [Darwin-x86, build] Fix up label prefixes, remove .purgem Darwin uses a label prefix of _. cctools assembler will not accept .purgem as a directive.
Berker Peksag 74b3f520 2016-05-19T18:05:36 Remove unused FFI_CLOSURE_TEST It was here since the first commit c6dddbd (warning: huge diff) and it wasn't defined by the configure script. It was probably used manually during development.
Tom Tromey 0969a1c1 2016-05-18T10:09:28 Merge pull request #232 from berkerpeksag/signcompare Fix -Wsign-compare warnings in x86/ffi64.c
Berker Peksag 1e82e1cd 2016-03-07T18:38:10 Define _GNU_SOURCE on Linux for mremap() This was committed to CPython's libffi copy in https://bugs.python.org/issue10309 mremap() documentation says _GNU_SOURCE needs to be defined in order to use mremap(): see the synopsis section at http://linux.die.net/man/2/mremap Original commit: https://hg.python.org/cpython/rev/9986fff720a2 Original patch was written by Hallvard B Furuseth.
Berker Peksag 4a677a42 2016-03-05T09:58:38 Fix -Wsign-compare warnings in x86/ffi64.c This was originally reported on the Python tracker: httpa://bugs.python.org/issue23958 The original patch was written by Steve R. Hastings. I've updated it to current master of libffi.
Tom Tromey 9443eaed 2016-05-17T17:04:50 Merge pull request #242 from somasis/master Fix usage on musl libc
Richard Henderson 48bfae1f 2016-05-02T20:58:57 Merge pull request #236 from andreas-schwab/master Define FFI_SIZEOF_JAVA_RAW for aarch64 ILP32
Kylie McClain e169ba2b 2016-04-29T21:04:07 Fix usage on musl libc A gcc compiled on musl does not define __gnu_linux__, it defines __linux__. Only on glibc does __gnu_linux__ get defined, but both define __linux__, so we should check for that instead. With this patch, libffi works perfectly, and passes its testsuite entirely on musl libc systems.
Richard Henderson e5843a3a 2016-04-15T16:10:08 x86: Fix calling convention for ffi_closure_win64_inner Also enable testing for the cross-abi calls.
Richard Henderson d0675197 2016-03-07T12:14:22 x86: Copy fix for clang .org from unix64.S Clang doesn't understand .org with symbolic operands.
Andreas Schwab d76975db 2016-03-16T12:23:07 Define FFI_SIZEOF_JAVA_RAW for aarch64 ILP32 Like x32, aarch64 ILP32 needs to define FFI_SIZEOF_JAVA_RAW. This fixes the java interpreter.
Tom Tromey 38a4d72c 2015-11-17T21:18:20 add ffi_get_struct_offsets
Anthony Green 49b95eda 2016-02-20T06:49:40 Merge pull request #194 from amodra/master Correct powerpc sysv stack argument accounting
Anthony Green 415723b4 2016-02-20T06:49:19 Merge pull request #104 from joshtriplett/efi64 Support the Windows/EFI calling convention on all x86-64 targets
Anthony Green 69143d06 2016-02-20T06:44:28 Merge pull request #197 from foxsen/mips_go_closure Mips go closure support
Russell Keith-Magee bc4fc07a 2015-12-21T00:37:06 Fixed #181 -- Corrected problems with ARMv7 build under iOS. Based on a patch from @fealebenpae, with input from @SolaWing and @rth7680, and testing from @superdump.
Zhang Fuxin 505346e1 2015-08-26T09:57:10 fix type error in unwind code
foxsen 5953c66b 2015-08-20T20:28:13 add unwind infor for *go_closure; reorder the labels to make thing more clear
Zhang Fuxin f0ecd5d4 2015-08-11T12:47:36 fix O32 stack unwind code add missing 1: label
foxsen 6f0201c8 2015-08-04T18:25:34 various fixes for go closure support. Now all n64 tests passed.
foxsen 697dd4e8 2015-08-04T12:53:33 add support for go closure support on mips
Alan Modra 43fc5bca 2015-08-03T23:34:05 Correct powerpc sysv stack argument accounting ppc32 starts using the stack for integer arg passing when we run out of integer arg passing registers. Similarly, we start using the stack for floating point args when we run out of floating point registers. The decision on where an integer arg goes does not depend on number of floating point args, nor does the decision on where a floating point arg goes depend on number of integer args. Alignment of stack args also simply depends on number of stack args. This patch untangles the horrible mess we had, with intarg_count being wrongly used to count both integer args and stack words. * src/powerpc/ffi_sysv.c (ffi_prep_cif_sysv_core): Count fprs, gprs, and stack words separately. (ffi_prep_args_SYSV): Similarly.
Josh Triplett 1f6b5a91 2015-07-26T16:27:34 Support the WIN64/EFI64 calling convention on all X86_64 platforms Add a new calling convention FFI_EFI64, alias FFI_WIN64, on all X86_64 platforms. This allows libffi compiled on a 64-bit x86 platform to call EFI functions. Compile in ffiw64.c and win64.S on all X86_64 platforms. When compiled for a platform other than X86_WIN64, ffiw64.c suffixes its functions with _efi64, to avoid conflict with the platform's actual implementations of those functions.
Josh Triplett 6de51f3e 2015-07-26T16:23:55 src/x86/ffiw64.c: Don't assign a "char *" to an "unsigned char *" Declare a local variable to match the type of the struct field assigned to it, rather than adding unsigned to the type. Fixes a -Wpointer-sign warning.
Josh Triplett eaa59755 2015-07-26T17:17:16 src/x86/win64.S: Handle name mangling and PIC Move the macros from unix64.S into a shared header asmnames.h and use them in win64.S too.
Josh Triplett c8e82d9f 2015-07-26T16:18:57 src/x86/win64.S: Support compiling on non-WIN64 platforms Non-WIN64 versions of the GNU assembler don't support the .seh_* directives for structured exception handling, so wrap them in a macro that compiles to nothing. Handle the registers used for the non-Windows x86-64 calling convention when on a non-Windows platform. Distinguish between cases that should refer to the native argument registers (defined as arg0, arg1, arg2, and arg3) and cases that should always refer to the Windows argument registers.
Russell Keith-Magee e3d2812c 2015-04-25T19:03:03 Modified arm/sysv.S to remove directives not allowed by clang.
Andrew Pinski 95df3791 2015-02-11T08:31:48 aarch64: Handle ILP32 ABI
Richard Henderson 2104b2a4 2015-01-26T12:43:57 sparc: Re-introduce hand-written unwind info Fixes the build with the Solaris assembler.
Anthony Green 31a61853 2015-01-21T05:55:47 Merge pull request #170 from fealebenpae/aarch64-trampoline-table Support closures on ARM64 iOS
Richard Henderson 3ac1610a 2015-01-19T20:48:40 x86: Fix cygwin32 build The section syntax is just that little bit different.
Richard Henderson 1ad0b171 2015-01-16T13:30:05 sparc: Also mark the return address in unwind info
Richard Henderson d68c8aed 2015-01-16T11:40:33 sparc: Solaris fixes, part 2 /bin/as seems to only understand single-digit labels /bin/as knows nothing about .rept/.endr
Rainer Orth b740ab7c 2015-01-16T11:32:23 sparc: Solaris fixes * /bin/as requires .type fn,#function instead of @function. * /bin/as doesn't support .macro/.endm. I'm using preprocessor macros instead to implement E in src/sparc/v[89].S.
Rainer Orth f1560b7b 2015-01-16T11:31:37 x86: Solaris fixes * Solaris/x86 /bin/as doesn't support .org, so I've just disabled the uses in src/x86/{sysv, unix64}.S, as on Darwin. * Solaris/x86 needs to use EH_FRAME_FLAGS so manually and compiler generated .eh_frame sections match, otherwise libffi.so fails to link: * Solaris/x86 /bin/as has different COMDAT syntax; I've disabled it for the moment.
Yavor Georgiev 53636634 2015-01-16T15:19:38 aarch64: implement the trampoline table workaround for ffi closures on Apple systems This is a direct copy/paste port of the ARM code, with changes because of Aarch64 pc-relative addressing restrictions.
Yavor Georgiev 05e65b4e 2015-01-16T15:18:04 aarch64: rewrite range syntax into list to appease Clang Clang's assembler in Xcode 6 appears to choke when the operand of st4 is a range, but is happy with a list.