Commit 265651b2c7e7800c8e8d257057d4494d78bded95

Moritz Lenz 2012-01-08T20:49:01

Fix mp_mod(a, b, c) if b < 0 and a = n * b, n integer it used to return b, now it return 0.

diff --git a/bn_mp_mod.c b/bn_mp_mod.c
index 787f4d3..bf6b41d 100644
--- a/bn_mp_mod.c
+++ b/bn_mp_mod.c
@@ -15,7 +15,7 @@
  * Tom St Denis, tomstdenis@gmail.com, http://libtom.org
  */
 
-/* c = a mod b, 0 <= c < b */
+/* c = a mod b, 0 <= c < b if b > 0, b < c <= 0 if b < 0 */
 int
 mp_mod (mp_int * a, mp_int * b, mp_int * c)
 {
@@ -31,11 +31,11 @@ mp_mod (mp_int * a, mp_int * b, mp_int * c)
     return res;
   }
 
-  if (t.sign != b->sign) {
-    res = mp_add (b, &t, c);
-  } else {
+  if (mp_iszero(&t) || t.sign == b->sign) {
     res = MP_OKAY;
     mp_exch (&t, c);
+  } else {
+    res = mp_add (b, &t, c);
   }
 
   mp_clear (&t);