Fixed compiler warnings on QNX.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139
diff --git a/src/audio/qsa/SDL_qsa_audio.c b/src/audio/qsa/SDL_qsa_audio.c
index 9f202ba..9b20374 100644
--- a/src/audio/qsa/SDL_qsa_audio.c
+++ b/src/audio/qsa/SDL_qsa_audio.c
@@ -56,24 +56,6 @@
#define DEFAULT_CPARAMS_FRAGS_MIN 1
#define DEFAULT_CPARAMS_FRAGS_MAX 1
-#define QSA_NO_WORKAROUNDS 0x00000000
-#define QSA_MMAP_WORKAROUND 0x00000001
-
-struct BuggyCards
-{
- char *cardname;
- unsigned long bugtype;
-};
-
-#define QSA_WA_CARDS 3
-#define QSA_MAX_CARD_NAME_LENGTH 33
-
-struct BuggyCards buggycards[QSA_WA_CARDS] = {
- {"Sound Blaster Live!", QSA_MMAP_WORKAROUND},
- {"Vortex 8820", QSA_MMAP_WORKAROUND},
- {"Vortex 8830", QSA_MMAP_WORKAROUND},
-};
-
/* List of found devices */
#define QSA_MAX_DEVICES 32
#define QSA_MAX_NAME_LENGTH 81+16 /* Hardcoded in QSA, can't be changed */
@@ -97,40 +79,16 @@ QSA_SetError(const char *fn, int status)
return SDL_SetError("QSA: %s() failed: %s", fn, snd_strerror(status));
}
-/* card names check to apply the workarounds */
-static int
-QSA_CheckBuggyCards(_THIS, unsigned long checkfor)
-{
- char scardname[QSA_MAX_CARD_NAME_LENGTH];
- int it;
-
- if (snd_card_get_name
- (this->hidden->cardno, scardname, QSA_MAX_CARD_NAME_LENGTH - 1) < 0) {
- return 0;
- }
-
- for (it = 0; it < QSA_WA_CARDS; it++) {
- if (SDL_strcmp(buggycards[it].cardname, scardname) == 0) {
- if (buggycards[it].bugtype == checkfor) {
- return 1;
- }
- }
- }
-
- return 0;
-}
-
/* !!! FIXME: does this need to be here? Does the SDL version not work? */
static void
QSA_ThreadInit(_THIS)
{
- struct sched_param param;
- int status;
-
/* Increase default 10 priority to 25 to avoid jerky sound */
- status = SchedGet(0, 0, ¶m);
- param.sched_priority = param.sched_curpriority + 15;
- status = SchedSet(0, 0, SCHED_NOCHANGE, ¶m);
+ struct sched_param param;
+ if (SchedGet(0, 0, ¶m) != -1) {
+ param.sched_priority = param.sched_curpriority + 15;
+ SchedSet(0, 0, SCHED_NOCHANGE, ¶m);
+ }
}
/* PCM channel parameters initialize function */
@@ -385,18 +343,6 @@ QSA_OpenDevice(_THIS, void *handle, const char *devname, int iscapture)
return QSA_SetError("snd_pcm_open", status);
}
-#if 0
- if (!QSA_CheckBuggyCards(this, QSA_MMAP_WORKAROUND)) {
- /* Disable QSA MMAP plugin for buggy audio drivers */
- status =
- snd_pcm_plugin_set_disable(this->hidden->audio_handle,
- PLUGIN_DISABLE_MMAP);
- if (status < 0) {
- return QSA_SetError("snd_pcm_plugin_set_disable", status);
- }
- }
-#endif
-
/* Try for a closest match on audio format */
format = 0;
/* can't use format as SND_PCM_SFMT_U8 = 0 in qsa */
@@ -723,8 +669,6 @@ QSA_Deinitialize(void)
static int
QSA_Init(SDL_AudioDriverImpl * impl)
{
- snd_pcm_t *handle = NULL;
-
/* Clear devices array */
SDL_zero(qsa_playback_device);
SDL_zero(qsa_capture_device);
diff --git a/src/video/qnx/gl.c b/src/video/qnx/gl.c
index 28f05f2..19e1bd4 100644
--- a/src/video/qnx/gl.c
+++ b/src/video/qnx/gl.c
@@ -227,13 +227,15 @@ glSetSwapInterval(_THIS, int interval)
/**
* Swaps the EGL buffers associated with the given window
* @param _THIS
- * @paran window Window to swap buffers for
+ * @param window Window to swap buffers for
+ * @return 0 if successful, -1 on error
*/
-void
+int
glSwapWindow(_THIS, SDL_Window *window)
{
+ /* !!! FIXME: should we migrate this all over to use SDL_egl.c? */
window_impl_t *impl = (window_impl_t *)window->driverdata;
- eglSwapBuffers(egl_disp, impl->surface);
+ return eglSwapBuffers(egl_disp, impl->surface) == EGL_TRUE ? 0 : -1;
}
/**
diff --git a/src/video/qnx/sdl_qnx.h b/src/video/qnx/sdl_qnx.h
index 70a2e48..65e0798 100644
--- a/src/video/qnx/sdl_qnx.h
+++ b/src/video/qnx/sdl_qnx.h
@@ -40,7 +40,7 @@ extern int glLoadLibrary(_THIS, const char *name);
void *glGetProcAddress(_THIS, const char *proc);
extern SDL_GLContext glCreateContext(_THIS, SDL_Window *window);
extern int glSetSwapInterval(_THIS, int interval);
-extern void glSwapWindow(_THIS, SDL_Window *window);
+extern int glSwapWindow(_THIS, SDL_Window *window);
extern int glMakeCurrent(_THIS, SDL_Window * window, SDL_GLContext context);
extern void glDeleteContext(_THIS, SDL_GLContext context);
extern void glUnloadLibrary(_THIS);