kc3-lang/SDL

2022-12-17T06:58:02

Fixed compiler warning ``` ./src/thread/pthread/SDL_syssem.c:140:12: warning: variable 'retval' is used uninitialized whenever 'while' loop exits because its condition is false [-Wsometimes-uninitialized] while (sem_trywait(&sem->sem) != 0) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ./src/thread/pthread/SDL_syssem.c:149:12: note: uninitialized use occurs here return retval; ^~~~~~ ./src/thread/pthread/SDL_syssem.c:140:12: note: remove the condition if it is always true while (sem_trywait(&sem->sem) != 0) { ``` This was a legitimate bug, thank you clang! Fixes https://github.com/libsdl-org/SDL/issues/6830 (cherry picked from commit b678a9802435152324e0603055e4bb190d0ae526)

diff --git a/src/thread/pthread/SDL_syssem.c b/src/thread/pthread/SDL_syssem.c
index c933acb..3a5a5a2 100644
--- a/src/thread/pthread/SDL_syssem.c
+++ b/src/thread/pthread/SDL_syssem.c
@@ -100,7 +100,7 @@ int SDL_SemWait(SDL_sem *sem)
 
 int SDL_SemWaitTimeout(SDL_sem *sem, Uint32 timeout)
 {
-    int retval;
+    int retval = 0;
 #ifdef HAVE_SEM_TIMEDWAIT
 #ifndef HAVE_CLOCK_GETTIME
     struct timeval now;