Merged default into iOS-improvements
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679
diff --git a/.hgignore b/.hgignore
index c16de75..029dfaf 100644
--- a/.hgignore
+++ b/.hgignore
@@ -8,6 +8,9 @@ Makefile
sdl-config
SDL2.spec
build
+Build
+*xcuserdata*
+*xcworkspacedata*
# for Xcode
*.orig
diff --git a/Xcode-iOS/SDL/SDL.xcodeproj/project.pbxproj b/Xcode-iOS/SDL/SDL.xcodeproj/project.pbxproj
index 44055ca..747f150 100755
--- a/Xcode-iOS/SDL/SDL.xcodeproj/project.pbxproj
+++ b/Xcode-iOS/SDL/SDL.xcodeproj/project.pbxproj
@@ -1274,8 +1274,14 @@
FD6526640DE8FCCB002AD96B /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
+ CLANG_ENABLE_OBJC_ARC = YES;
+ CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
+ CLANG_WARN_OBJC_IMPLICIT_ATOMIC_PROPERTIES = YES;
COPY_PHASE_STRIP = NO;
IPHONEOS_DEPLOYMENT_TARGET = 5.1.1;
+ GCC_WARN_MULTIPLE_DEFINITION_TYPES_FOR_SELECTOR = YES;
+ GCC_WARN_STRICT_SELECTOR_MATCH = YES;
+ GCC_WARN_UNDECLARED_SELECTOR = YES;
PRODUCT_NAME = SDL2;
SKIP_INSTALL = YES;
};
@@ -1284,8 +1290,14 @@
FD6526650DE8FCCB002AD96B /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
+ CLANG_ENABLE_OBJC_ARC = YES;
+ CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
+ CLANG_WARN_OBJC_IMPLICIT_ATOMIC_PROPERTIES = YES;
COPY_PHASE_STRIP = YES;
IPHONEOS_DEPLOYMENT_TARGET = 5.1.1;
+ GCC_WARN_MULTIPLE_DEFINITION_TYPES_FOR_SELECTOR = YES;
+ GCC_WARN_STRICT_SELECTOR_MATCH = YES;
+ GCC_WARN_UNDECLARED_SELECTOR = YES;
PRODUCT_NAME = SDL2;
SKIP_INSTALL = YES;
};
diff --git a/include/SDL_hints.h b/include/SDL_hints.h
index e0fce66..92f31cd 100644
--- a/include/SDL_hints.h
+++ b/include/SDL_hints.h
@@ -261,8 +261,9 @@ extern "C" {
#define SDL_HINT_ORIENTATIONS "SDL_IOS_ORIENTATIONS"
/**
- * \brief A variable controlling whether an Android built-in accelerometer should be
- * listed as a joystick device, rather than listing actual joysticks only.
+ * \brief A variable controlling whether the Android / iOS built-in
+ * accelerometer should be listed as a joystick device, rather than listing
+ * actual joysticks only.
*
* This variable can be set to the following values:
* "0" - List only real joysticks and accept input from them
@@ -345,7 +346,7 @@ extern "C" {
/**
- * \brief If set to 1, then do not allow high-DPI windows. ("Retina" on Mac)
+ * \brief If set to 1, then do not allow high-DPI windows. ("Retina" on Mac and iOS)
*/
#define SDL_HINT_VIDEO_HIGHDPI_DISABLED "SDL_VIDEO_HIGHDPI_DISABLED"
diff --git a/include/SDL_syswm.h b/include/SDL_syswm.h
index c81cd48..5359b5d 100644
--- a/include/SDL_syswm.h
+++ b/include/SDL_syswm.h
@@ -209,9 +209,9 @@ struct SDL_SysWMinfo
struct
{
#if defined(__OBJC__) && __has_feature(objc_arc)
- NSWindow __unsafe_unretained *window; /* The Cocoa window */
+ NSWindow * __unsafe_unretained window; /* The Cocoa window */
#else
- NSWindow *window; /* The Cocoa window */
+ NSWindow *window; /* The Cocoa window */
#endif
} cocoa;
#endif
@@ -219,9 +219,9 @@ struct SDL_SysWMinfo
struct
{
#if defined(__OBJC__) && __has_feature(objc_arc)
- UIWindow __unsafe_unretained *window; /* The UIKit window */
+ UIWindow * __unsafe_unretained window; /* The UIKit window */
#else
- UIWindow *window; /* The UIKit window */
+ UIWindow *window; /* The UIKit window */
#endif
} uikit;
#endif
diff --git a/src/file/cocoa/SDL_rwopsbundlesupport.m b/src/file/cocoa/SDL_rwopsbundlesupport.m
index f6a65a9..648aaff 100644
--- a/src/file/cocoa/SDL_rwopsbundlesupport.m
+++ b/src/file/cocoa/SDL_rwopsbundlesupport.m
@@ -41,27 +41,23 @@ FILE* SDL_OpenFPFromBundleOrFallback(const char *file, const char *mode)
return fopen(file, mode);
}
- NSAutoreleasePool* autorelease_pool = [[NSAutoreleasePool alloc] init];
-
-
- NSFileManager* file_manager = [NSFileManager defaultManager];
- NSString* resource_path = [[NSBundle mainBundle] resourcePath];
-
- NSString* ns_string_file_component = [file_manager stringWithFileSystemRepresentation:file length:strlen(file)];
-
- NSString* full_path_with_file_to_try = [resource_path stringByAppendingPathComponent:ns_string_file_component];
- if([file_manager fileExistsAtPath:full_path_with_file_to_try]) {
- fp = fopen([full_path_with_file_to_try fileSystemRepresentation], mode);
- }
- else {
- fp = fopen(file, mode);
+ @autoreleasepool {
+ NSFileManager* file_manager = [NSFileManager defaultManager];
+ NSString* resource_path = [[NSBundle mainBundle] resourcePath];
+
+ NSString* ns_string_file_component = [file_manager stringWithFileSystemRepresentation:file length:strlen(file)];
+
+ NSString* full_path_with_file_to_try = [resource_path stringByAppendingPathComponent:ns_string_file_component];
+ if([file_manager fileExistsAtPath:full_path_with_file_to_try]) {
+ fp = fopen([full_path_with_file_to_try fileSystemRepresentation], mode);
+ } else {
+ fp = fopen(file, mode);
+ }
}
- [autorelease_pool drain];
-
return fp;
}
-#endif /* __MACOSX__ */
+#endif /* __APPLE__ */
/* vi: set ts=4 sw=4 expandtab: */
diff --git a/src/filesystem/cocoa/SDL_sysfilesystem.m b/src/filesystem/cocoa/SDL_sysfilesystem.m
index adcebd6..d11739e 100644
--- a/src/filesystem/cocoa/SDL_sysfilesystem.m
+++ b/src/filesystem/cocoa/SDL_sysfilesystem.m
@@ -36,67 +36,69 @@
char *
SDL_GetBasePath(void)
{
- NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
- NSBundle *bundle = [NSBundle mainBundle];
- const char* baseType = [[[bundle infoDictionary] objectForKey:@"SDL_FILESYSTEM_BASE_DIR_TYPE"] UTF8String];
- const char *base = NULL;
char *retval = NULL;
- if (baseType == NULL) {
- baseType = "resource";
- }
- if (SDL_strcasecmp(baseType, "bundle")==0) {
- base = [[bundle bundlePath] fileSystemRepresentation];
- } else if (SDL_strcasecmp(baseType, "parent")==0) {
- base = [[[bundle bundlePath] stringByDeletingLastPathComponent] fileSystemRepresentation];
- } else {
- /* this returns the exedir for non-bundled and the resourceDir for bundled apps */
- base = [[bundle resourcePath] fileSystemRepresentation];
- }
- if (base) {
- const size_t len = SDL_strlen(base) + 2;
- retval = (char *) SDL_malloc(len);
- if (retval == NULL) {
- SDL_OutOfMemory();
+
+ @autoreleasepool {
+ const char *base = NULL;
+ NSBundle *bundle = [NSBundle mainBundle];
+ const char* baseType = [[[bundle infoDictionary] objectForKey:@"SDL_FILESYSTEM_BASE_DIR_TYPE"] UTF8String];
+ if (baseType == NULL) {
+ baseType = "resource";
+ }
+ if (SDL_strcasecmp(baseType, "bundle")==0) {
+ base = [[bundle bundlePath] fileSystemRepresentation];
+ } else if (SDL_strcasecmp(baseType, "parent")==0) {
+ base = [[[bundle bundlePath] stringByDeletingLastPathComponent] fileSystemRepresentation];
} else {
- SDL_snprintf(retval, len, "%s/", base);
+ /* this returns the exedir for non-bundled and the resourceDir for bundled apps */
+ base = [[bundle resourcePath] fileSystemRepresentation];
+ }
+
+ if (base) {
+ const size_t len = SDL_strlen(base) + 2;
+ retval = (char *) SDL_malloc(len);
+ if (retval == NULL) {
+ SDL_OutOfMemory();
+ } else {
+ SDL_snprintf(retval, len, "%s/", base);
+ }
}
}
- [pool release];
return retval;
}
char *
SDL_GetPrefPath(const char *org, const char *app)
{
- NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
- NSArray *array = NSSearchPathForDirectoriesInDomains(NSApplicationSupportDirectory, NSUserDomainMask, YES);
char *retval = NULL;
- if ([array count] > 0) { /* we only want the first item in the list. */
- NSString *str = [array objectAtIndex:0];
- const char *base = [str fileSystemRepresentation];
- if (base) {
- const size_t len = SDL_strlen(base) + SDL_strlen(org) + SDL_strlen(app) + 4;
- retval = (char *) SDL_malloc(len);
- if (retval == NULL) {
- SDL_OutOfMemory();
- } else {
- char *ptr;
- SDL_snprintf(retval, len, "%s/%s/%s/", base, org, app);
- for (ptr = retval+1; *ptr; ptr++) {
- if (*ptr == '/') {
- *ptr = '\0';
- mkdir(retval, 0700);
- *ptr = '/';
+ @autoreleasepool {
+ NSArray *array = NSSearchPathForDirectoriesInDomains(NSApplicationSupportDirectory, NSUserDomainMask, YES);
+
+ if ([array count] > 0) { /* we only want the first item in the list. */
+ NSString *str = [array objectAtIndex:0];
+ const char *base = [str fileSystemRepresentation];
+ if (base) {
+ const size_t len = SDL_strlen(base) + SDL_strlen(org) + SDL_strlen(app) + 4;
+ retval = (char *) SDL_malloc(len);
+ if (retval == NULL) {
+ SDL_OutOfMemory();
+ } else {
+ char *ptr;
+ SDL_snprintf(retval, len, "%s/%s/%s/", base, org, app);
+ for (ptr = retval+1; *ptr; ptr++) {
+ if (*ptr == '/') {
+ *ptr = '\0';
+ mkdir(retval, 0700);
+ *ptr = '/';
+ }
}
+ mkdir(retval, 0700);
}
- mkdir(retval, 0700);
}
}
}
-
- [pool release];
return retval;
}
diff --git a/src/joystick/iphoneos/SDL_sysjoystick.m b/src/joystick/iphoneos/SDL_sysjoystick.m
index a402759..65e8ba7 100644
--- a/src/joystick/iphoneos/SDL_sysjoystick.m
+++ b/src/joystick/iphoneos/SDL_sysjoystick.m
@@ -23,6 +23,7 @@
/* This is the iOS implementation of the SDL joystick API */
#include "SDL_joystick.h"
+#include "SDL_hints.h"
#include "SDL_stdinc.h"
#include "../SDL_sysjoystick.h"
#include "../SDL_joystick_c.h"
@@ -32,9 +33,10 @@
/* needed for SDL_IPHONE_MAX_GFORCE macro */
#import "SDL_config_iphoneos.h"
-const char *accelerometerName = "iOS accelerometer";
+const char *accelerometerName = "iOS Accelerometer";
static CMMotionManager *motionManager = nil;
+static int numjoysticks = 0;
/* Function to scan the system for joysticks.
* This function should set SDL_numjoysticks to the number of available
@@ -44,12 +46,18 @@ static CMMotionManager *motionManager = nil;
int
SDL_SYS_JoystickInit(void)
{
- return (1);
+ const char *hint = SDL_GetHint(SDL_HINT_ACCELEROMETER_AS_JOYSTICK);
+ if (!hint || SDL_atoi(hint)) {
+ /* Default behavior, accelerometer as joystick */
+ numjoysticks = 1;
+ }
+
+ return numjoysticks;
}
int SDL_SYS_NumJoysticks()
{
- return 1;
+ return numjoysticks;
}
void SDL_SYS_JoystickDetect()
@@ -82,13 +90,15 @@ SDL_SYS_JoystickOpen(SDL_Joystick * joystick, int device_index)
joystick->nballs = 0;
joystick->nbuttons = 0;
- if (motionManager == nil) {
- motionManager = [[CMMotionManager alloc] init];
- }
+ @autoreleasepool {
+ if (motionManager == nil) {
+ motionManager = [[CMMotionManager alloc] init];
+ }
- /* Shorter times between updates can significantly increase CPU usage. */
- motionManager.accelerometerUpdateInterval = 0.1;
- [motionManager startAccelerometerUpdates];
+ /* Shorter times between updates can significantly increase CPU usage. */
+ motionManager.accelerometerUpdateInterval = 0.1;
+ [motionManager startAccelerometerUpdates];
+ }
return 0;
}
@@ -105,11 +115,13 @@ static void SDL_SYS_AccelerometerUpdate(SDL_Joystick * joystick)
const SInt16 maxsint16 = 0x7FFF;
CMAcceleration accel;
- if (!motionManager.accelerometerActive) {
- return;
- }
+ @autoreleasepool {
+ if (!motionManager.accelerometerActive) {
+ return;
+ }
- accel = [[motionManager accelerometerData] acceleration];
+ accel = motionManager.accelerometerData.acceleration;
+ }
/*
Convert accelerometer data from floating point to Sint16, which is what
@@ -153,7 +165,9 @@ SDL_SYS_JoystickUpdate(SDL_Joystick * joystick)
void
SDL_SYS_JoystickClose(SDL_Joystick * joystick)
{
- [motionManager stopAccelerometerUpdates];
+ @autoreleasepool {
+ [motionManager stopAccelerometerUpdates];
+ }
joystick->closed = 1;
}
@@ -161,10 +175,11 @@ SDL_SYS_JoystickClose(SDL_Joystick * joystick)
void
SDL_SYS_JoystickQuit(void)
{
- if (motionManager != nil) {
- [motionManager release];
+ @autoreleasepool {
motionManager = nil;
}
+
+ numjoysticks = 0;
}
SDL_JoystickGUID SDL_SYS_JoystickGetDeviceGUID( int device_index )
diff --git a/src/power/uikit/SDL_syspower.m b/src/power/uikit/SDL_syspower.m
index 60c4274..4984b78 100644
--- a/src/power/uikit/SDL_syspower.m
+++ b/src/power/uikit/SDL_syspower.m
@@ -50,24 +50,24 @@ SDL_UIKit_UpdateBatteryMonitoring(void)
SDL_bool
SDL_GetPowerInfo_UIKit(SDL_PowerState * state, int *seconds, int *percent)
{
- UIDevice *uidev = [UIDevice currentDevice];
+ @autoreleasepool {
+ UIDevice *uidev = [UIDevice currentDevice];
- if (!SDL_UIKitLastPowerInfoQuery) {
- SDL_assert([uidev isBatteryMonitoringEnabled] == NO);
- [uidev setBatteryMonitoringEnabled:YES];
- }
+ if (!SDL_UIKitLastPowerInfoQuery) {
+ SDL_assert(uidev.isBatteryMonitoringEnabled == NO);
+ uidev.batteryMonitoringEnabled = YES;
+ }
- /* UIKit_GL_SwapWindow() (etc) will check this and disable the battery
- * monitoring if the app hasn't queried it in the last X seconds.
- * Apparently monitoring the battery burns battery life. :)
- * Apple's docs say not to monitor the battery unless you need it.
- */
- SDL_UIKitLastPowerInfoQuery = SDL_GetTicks();
+ /* UIKit_GL_SwapWindow() (etc) will check this and disable the battery
+ * monitoring if the app hasn't queried it in the last X seconds.
+ * Apparently monitoring the battery burns battery life. :)
+ * Apple's docs say not to monitor the battery unless you need it.
+ */
+ SDL_UIKitLastPowerInfoQuery = SDL_GetTicks();
- *seconds = -1; /* no API to estimate this in UIKit. */
+ *seconds = -1; /* no API to estimate this in UIKit. */
- switch ([uidev batteryState])
- {
+ switch (uidev.batteryState) {
case UIDeviceBatteryStateCharging:
*state = SDL_POWERSTATE_CHARGING;
break;
@@ -84,11 +84,12 @@ SDL_GetPowerInfo_UIKit(SDL_PowerState * state, int *seconds, int *percent)
default:
*state = SDL_POWERSTATE_UNKNOWN;
break;
- }
+ }
- const float level = [uidev batteryLevel];
- *percent = ( (level < 0.0f) ? -1 : ((int) ((level * 100) + 0.5f)) );
- return SDL_TRUE; /* always the definitive answer on iOS. */
+ const float level = uidev.batteryLevel;
+ *percent = ( (level < 0.0f) ? -1 : ((int) ((level * 100) + 0.5f)) );
+ return SDL_TRUE; /* always the definitive answer on iOS. */
+ }
}
#endif /* SDL_POWER_UIKIT */
diff --git a/src/video/uikit/SDL_uikitappdelegate.m b/src/video/uikit/SDL_uikitappdelegate.m
index a9924fb..c4a1999 100644
--- a/src/video/uikit/SDL_uikitappdelegate.m
+++ b/src/video/uikit/SDL_uikitappdelegate.m
@@ -44,7 +44,6 @@ static UIWindow *launch_window;
int main(int argc, char **argv)
{
int i;
- NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
/* store arguments */
forward_argc = argc;
@@ -56,7 +55,9 @@ int main(int argc, char **argv)
forward_argv[i] = NULL;
/* Give over control to run loop, SDLUIKitDelegate will handle most things from here */
- UIApplicationMain(argc, argv, NULL, [SDLUIKitDelegate getAppDelegateClassName]);
+ @autoreleasepool {
+ UIApplicationMain(argc, argv, nil, [SDLUIKitDelegate getAppDelegateClassName]);
+ }
/* free the memory we used to hold copies of argc and argv */
for (i = 0; i < forward_argc; i++) {
@@ -64,7 +65,6 @@ int main(int argc, char **argv)
}
free(forward_argv);
- [pool release];
return exit_status;
}
@@ -75,16 +75,17 @@ SDL_IdleTimerDisabledChanged(void *userdata, const char *name, const char *oldVa
[UIApplication sharedApplication].idleTimerDisabled = disable;
}
-@interface SDL_splashviewcontroller : UIViewController {
- UIImageView *splash;
- UIImage *splashPortrait;
- UIImage *splashLandscape;
-}
+@interface SDL_splashviewcontroller : UIViewController
- (void)updateSplashImage:(UIInterfaceOrientation)interfaceOrientation;
+
@end
-@implementation SDL_splashviewcontroller
+@implementation SDL_splashviewcontroller {
+ UIImageView *splash;
+ UIImage *splashPortrait;
+ UIImage *splashLandscape;
+}
- (id)init
{
@@ -93,26 +94,20 @@ SDL_IdleTimerDisabledChanged(void *userdata, const char *name, const char *oldVa
return nil;
}
- self->splash = [[UIImageView alloc] init];
- [self setView:self->splash];
+ splash = [[UIImageView alloc] init];
+ self.view = splash;
CGSize size = [UIScreen mainScreen].bounds.size;
float height = SDL_max(size.width, size.height);
- self->splashPortrait = [UIImage imageNamed:[NSString stringWithFormat:@"Default-%dh.png", (int)height]];
- if (!self->splashPortrait) {
- self->splashPortrait = [UIImage imageNamed:@"Default.png"];
- }
- self->splashLandscape = [UIImage imageNamed:@"Default-Landscape.png"];
- if (!self->splashLandscape && self->splashPortrait) {
- self->splashLandscape = [[UIImage alloc] initWithCGImage: self->splashPortrait.CGImage
- scale: 1.0
- orientation: UIImageOrientationRight];
- }
- if (self->splashPortrait) {
- [self->splashPortrait retain];
+ splashPortrait = [UIImage imageNamed:[NSString stringWithFormat:@"Default-%dh.png", (int)height]];
+ if (!splashPortrait) {
+ splashPortrait = [UIImage imageNamed:@"Default.png"];
}
- if (self->splashLandscape) {
- [self->splashLandscape retain];
+ splashLandscape = [UIImage imageNamed:@"Default-Landscape.png"];
+ if (!splashLandscape && splashPortrait) {
+ splashLandscape = [[UIImage alloc] initWithCGImage: splashPortrait.CGImage
+ scale: 1.0
+ orientation: UIImageOrientationRight];
}
[self updateSplashImage:[[UIApplication sharedApplication] statusBarOrientation]];
@@ -147,12 +142,12 @@ SDL_IdleTimerDisabledChanged(void *userdata, const char *name, const char *oldVa
UIImage *image;
if (UIInterfaceOrientationIsLandscape(interfaceOrientation)) {
- image = self->splashLandscape;
+ image = splashLandscape;
} else {
- image = self->splashPortrait;
+ image = splashPortrait;
}
- if (image)
- {
+
+ if (image) {
splash.image = image;
}
}
@@ -165,7 +160,7 @@ SDL_IdleTimerDisabledChanged(void *userdata, const char *name, const char *oldVa
/* convenience method */
+ (id) sharedAppDelegate
{
- /* the delegate is set in UIApplicationMain(), which is garaunteed to be called before this method */
+ /* the delegate is set in UIApplicationMain(), which is guaranteed to be called before this method */
return [[UIApplication sharedApplication] delegate];
}
@@ -191,8 +186,7 @@ SDL_IdleTimerDisabledChanged(void *userdata, const char *name, const char *oldVa
/* If we showed a splash image, clean it up */
if (launch_window) {
- [launch_window release];
- launch_window = NULL;
+ launch_window = nil;
}
/* exit, passing the return status from the user's application */
@@ -205,12 +199,18 @@ SDL_IdleTimerDisabledChanged(void *userdata, const char *name, const char *oldVa
- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
/* Keep the launch image up until we set a video mode */
- launch_window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]];
+
+ /* This is disabled temporarily because the splash viewcontroller is
+ * interfering with rotation once a regular window is created: the view's
+ * orientations are incorrect and the status bar rotates without the view.
+ * Additionally, the splash viewcontroller doesn't load the correct launch
+ * images on iOS 7 and modern devices. */
+ /*launch_window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]];
UIViewController *splashViewController = [[SDL_splashviewcontroller alloc] init];
launch_window.rootViewController = splashViewController;
[launch_window addSubview:splashViewController.view];
- [launch_window makeKeyAndVisible];
+ [launch_window makeKeyAndVisible];*/
/* Set working directory to resource path */
[[NSFileManager defaultManager] changeCurrentDirectoryPath: [[NSBundle mainBundle] resourcePath]];
@@ -235,6 +235,35 @@ SDL_IdleTimerDisabledChanged(void *userdata, const char *name, const char *oldVa
SDL_SendAppEvent(SDL_APP_LOWMEMORY);
}
+- (void)application:(UIApplication *)application didChangeStatusBarOrientation:(UIInterfaceOrientation)oldStatusBarOrientation
+{
+ BOOL isLandscape = UIInterfaceOrientationIsLandscape(application.statusBarOrientation);
+ SDL_VideoDevice *_this = SDL_GetVideoDevice();
+
+ if (_this && _this->num_displays > 0) {
+ SDL_DisplayMode *desktopmode = &_this->displays[0].desktop_mode;
+ SDL_DisplayMode *currentmode = &_this->displays[0].current_mode;
+
+ /* The desktop display mode should be kept in sync with the screen
+ * orientation so that updating a window's fullscreen state to
+ * SDL_WINDOW_FULLSCREEN_DESKTOP keeps the window dimensions in the
+ * correct orientation.
+ */
+ if (isLandscape != (desktopmode->w > desktopmode->h)) {
+ int height = desktopmode->w;
+ desktopmode->w = desktopmode->h;
+ desktopmode->h = height;
+ }
+
+ /* Same deal with the current mode + SDL_GetCurrentDisplayMode. */
+ if (isLandscape != (currentmode->w > currentmode->h)) {
+ int height = currentmode->w;
+ currentmode->w = currentmode->h;
+ currentmode->h = height;
+ }
+ }
+}
+
- (void) applicationWillResignActive:(UIApplication*)application
{
SDL_VideoDevice *_this = SDL_GetVideoDevice();
diff --git a/src/video/uikit/SDL_uikitevents.m b/src/video/uikit/SDL_uikitevents.m
index 94fba87..48bb1bd 100644
--- a/src/video/uikit/SDL_uikitevents.m
+++ b/src/video/uikit/SDL_uikitevents.m
@@ -40,8 +40,9 @@ SDL_iPhoneSetEventPump(SDL_bool enabled)
void
UIKit_PumpEvents(_THIS)
{
- if (!UIKit_EventPumpEnabled)
+ if (!UIKit_EventPumpEnabled) {
return;
+ }
/* Let the run loop run for a short amount of time: long enough for
touch events to get processed (which is important to get certain
diff --git a/src/video/uikit/SDL_uikitmessagebox.m b/src/video/uikit/SDL_uikitmessagebox.m
index c24f3ff..9a99db1 100644
--- a/src/video/uikit/SDL_uikitmessagebox.m
+++ b/src/video/uikit/SDL_uikitmessagebox.m
@@ -30,17 +30,16 @@
static SDL_bool s_showingMessageBox = SDL_FALSE;
-@interface UIKit_UIAlertViewDelegate : NSObject <UIAlertViewDelegate> {
-@private
- int *clickedButtonIndex;
-}
+@interface UIKit_UIAlertViewDelegate : NSObject <UIAlertViewDelegate>
-- (id)initWithButtonIndex:(int *)_buttonIndex;
+- (id)initWithButtonIndex:(int *)buttonIndex;
- (void)alertView:(UIAlertView *)alertView didDismissWithButtonIndex:(NSInteger)buttonIndex;
@end
-@implementation UIKit_UIAlertViewDelegate
+@implementation UIKit_UIAlertViewDelegate {
+ int *clickedButtonIndex;
+}
- (id)initWithButtonIndex:(int *)buttonIndex
{
@@ -48,12 +47,13 @@ static SDL_bool s_showingMessageBox = SDL_FALSE;
if (self == nil) {
return nil;
}
- self->clickedButtonIndex = buttonIndex;
+
+ clickedButtonIndex = buttonIndex;
return self;
}
-- (void)alertView:(UIAlertView *)alertView didDismissWithButtonIndex:(NSInteger)buttonIndex;
+- (void)alertView:(UIAlertView *)alertView didDismissWithButtonIndex:(NSInteger)buttonIndex
{
*clickedButtonIndex = (int)buttonIndex;
}
@@ -71,40 +71,38 @@ int
UIKit_ShowMessageBox(const SDL_MessageBoxData *messageboxdata, int *buttonid)
{
int clicked;
+ int i;
+ const SDL_MessageBoxButtonData *buttons = messageboxdata->buttons;
- NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
-
- UIAlertView* alert = [[UIAlertView alloc] init];
-
- alert.title = [NSString stringWithUTF8String:messageboxdata->title];
- alert.message = [NSString stringWithUTF8String:messageboxdata->message];
- alert.delegate = [[UIKit_UIAlertViewDelegate alloc] initWithButtonIndex:&clicked];
+ @autoreleasepool {
+ UIAlertView* alert = [[UIAlertView alloc] init];
+ UIKit_UIAlertViewDelegate *delegate = [[UIKit_UIAlertViewDelegate alloc] initWithButtonIndex:&clicked];
- const SDL_MessageBoxButtonData *buttons = messageboxdata->buttons;
- int i;
- for (i = 0; i < messageboxdata->numbuttons; ++i) {
- [alert addButtonWithTitle:[[NSString alloc] initWithUTF8String:buttons[i].text]];
- }
+ alert.title = @(messageboxdata->title);
+ alert.message = @(messageboxdata->message);
+ alert.delegate = delegate;
- /* Set up for showing the alert */
- clicked = messageboxdata->numbuttons;
+ for (i = 0; i < messageboxdata->numbuttons; ++i) {
+ [alert addButtonWithTitle:@(buttons[i].text)];
+ }
- [alert show];
+ /* Set up for showing the alert */
+ clicked = messageboxdata->numbuttons;
- /* Run the main event loop until the alert has finished */
- /* Note that this needs to be done on the main thread */
- s_showingMessageBox = SDL_TRUE;
- while (clicked == messageboxdata->numbuttons) {
- [[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate distantFuture]];
- }
- s_showingMessageBox = SDL_FALSE;
+ [alert show];
- *buttonid = messageboxdata->buttons[clicked].buttonid;
+ /* Run the main event loop until the alert has finished */
+ /* Note that this needs to be done on the main thread */
+ s_showingMessageBox = SDL_TRUE;
+ while (clicked == messageboxdata->numbuttons) {
+ [[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate distantFuture]];
+ }
+ s_showingMessageBox = SDL_FALSE;
- [alert.delegate release];
- [alert release];
+ *buttonid = messageboxdata->buttons[clicked].buttonid;
- [pool release];
+ alert.delegate = nil;
+ }
return 0;
}
diff --git a/src/video/uikit/SDL_uikitmodes.h b/src/video/uikit/SDL_uikitmodes.h
index 9f2e9dd..65c185f 100644
--- a/src/video/uikit/SDL_uikitmodes.h
+++ b/src/video/uikit/SDL_uikitmodes.h
@@ -25,17 +25,17 @@
#include "SDL_uikitvideo.h"
-typedef struct
-{
- UIScreen *uiscreen;
- CGFloat scale;
-} SDL_DisplayData;
-
-typedef struct
-{
- UIScreenMode *uiscreenmode;
- CGFloat scale;
-} SDL_DisplayModeData;
+@interface SDL_DisplayData : NSObject
+
+@property (nonatomic, strong) UIScreen *uiscreen;
+
+@end
+
+@interface SDL_DisplayModeData : NSObject
+
+@property (nonatomic, strong) UIScreenMode *uiscreenmode;
+
+@end
extern SDL_bool UIKit_IsDisplayLandscape(UIScreen *uiscreen);
diff --git a/src/video/uikit/SDL_uikitmodes.m b/src/video/uikit/SDL_uikitmodes.m
index 05e33d9..37792f1 100644
--- a/src/video/uikit/SDL_uikitmodes.m
+++ b/src/video/uikit/SDL_uikitmodes.m
@@ -25,27 +25,36 @@
#include "SDL_assert.h"
#include "SDL_uikitmodes.h"
+@implementation SDL_DisplayData
+
+@synthesize uiscreen;
+
+@end
+
+@implementation SDL_DisplayModeData
+
+@synthesize uiscreenmode;
+
+@end
+
static int
UIKit_AllocateDisplayModeData(SDL_DisplayMode * mode,
- UIScreenMode * uiscreenmode, CGFloat scale)
+ UIScreenMode * uiscreenmode)
{
- SDL_DisplayModeData *data = NULL;
+ SDL_DisplayModeData *data = nil;
if (uiscreenmode != nil) {
/* Allocate the display mode data */
- data = (SDL_DisplayModeData *) SDL_malloc(sizeof(*data));
+ data = [[SDL_DisplayModeData alloc] init];
if (!data) {
return SDL_OutOfMemory();
}
- data->uiscreenmode = uiscreenmode;
- [data->uiscreenmode retain];
-
- data->scale = scale;
+ data.uiscreenmode = uiscreenmode;
}
- mode->driverdata = data;
+ mode->driverdata = (void *) CFBridgingRetain(data);
return 0;
}
@@ -54,23 +63,21 @@ static void
UIKit_FreeDisplayModeData(SDL_DisplayMode * mode)
{
if (mode->driverdata != NULL) {
- SDL_DisplayModeData *data = (SDL_DisplayModeData *)mode->driverdata;
- [data->uiscreenmode release];
- SDL_free(data);
+ CFRelease(mode->driverdata);
mode->driverdata = NULL;
}
}
static int
UIKit_AddSingleDisplayMode(SDL_VideoDisplay * display, int w, int h,
- UIScreenMode * uiscreenmode, CGFloat scale)
+ UIScreenMode * uiscreenmode)
{
SDL_DisplayMode mode;
SDL_zero(mode);
mode.format = SDL_PIXELFORMAT_ABGR8888;
mode.refresh_rate = 0;
- if (UIKit_AllocateDisplayModeData(&mode, uiscreenmode, scale) < 0) {
+ if (UIKit_AllocateDisplayModeData(&mode, uiscreenmode) < 0) {
return -1;
}
@@ -85,16 +92,16 @@ UIKit_AddSingleDisplayMode(SDL_VideoDisplay * display, int w, int h,
}
static int
-UIKit_AddDisplayMode(SDL_VideoDisplay * display, int w, int h, CGFloat scale,
+UIKit_AddDisplayMode(SDL_VideoDisplay * display, int w, int h,
UIScreenMode * uiscreenmode, SDL_bool addRotation)
{
- if (UIKit_AddSingleDisplayMode(display, w, h, uiscreenmode, scale) < 0) {
+ if (UIKit_AddSingleDisplayMode(display, w, h, uiscreenmode) < 0) {
return -1;
}
if (addRotation) {
/* Add the rotated version */
- if (UIKit_AddSingleDisplayMode(display, h, w, uiscreenmode, scale) < 0) {
+ if (UIKit_AddSingleDisplayMode(display, h, w, uiscreenmode) < 0) {
return -1;
}
}
@@ -114,24 +121,16 @@ UIKit_AddDisplay(UIScreen *uiscreen)
size.height = height;
}
- /* When dealing with UIKit all coordinates are specified in terms of
- * what Apple refers to as points. [UIScreen scale] indicates the
- * relationship between points and pixels. Since SDL has no notion
- * of points, we must compensate in all cases where dealing with such
- * units.
- */
- CGFloat scale = [uiscreen scale];
-
SDL_VideoDisplay display;
SDL_DisplayMode mode;
SDL_zero(mode);
mode.format = SDL_PIXELFORMAT_ABGR8888;
- mode.w = (int)(size.width * scale);
- mode.h = (int)(size.height * scale);
+ mode.w = (int) size.width;
+ mode.h = (int) size.height;
- UIScreenMode * uiscreenmode = [uiscreen currentMode];
+ UIScreenMode *uiscreenmode = [uiscreen currentMode];
- if (UIKit_AllocateDisplayModeData(&mode, uiscreenmode, scale) < 0) {
+ if (UIKit_AllocateDisplayModeData(&mode, uiscreenmode) < 0) {
return -1;
}
@@ -140,19 +139,18 @@ UIKit_AddDisplay(UIScreen *uiscreen)
display.current_mode = mode;
/* Allocate the display data */
- SDL_DisplayData *data = (SDL_DisplayData *) SDL_malloc(sizeof(*data));
+ SDL_DisplayData *data = [[SDL_DisplayData alloc] init];
if (!data) {
UIKit_FreeDisplayModeData(&display.desktop_mode);
return SDL_OutOfMemory();
}
- [uiscreen retain];
- data->uiscreen = uiscreen;
- data->scale = scale;
+ data.uiscreen = uiscreen;
- display.driverdata = data;
+ display.driverdata = (void *) CFBridgingRetain(data);
SDL_AddVideoDisplay(&display);
+
return 0;
}
@@ -170,9 +168,11 @@ UIKit_IsDisplayLandscape(UIScreen *uiscreen)
int
UIKit_InitModes(_THIS)
{
- for (UIScreen *uiscreen in [UIScreen screens]) {
- if (UIKit_AddDisplay(uiscreen) < 0) {
- return -1;
+ @autoreleasepool {
+ for (UIScreen *uiscreen in [UIScreen screens]) {
+ if (UIKit_AddDisplay(uiscreen) < 0) {
+ return -1;
+ }
}
}
@@ -182,34 +182,29 @@ UIKit_InitModes(_THIS)
void
UIKit_GetDisplayModes(_THIS, SDL_VideoDisplay * display)
{
- SDL_DisplayData *data = (SDL_DisplayData *) display->driverdata;
-
- SDL_bool isLandscape = UIKit_IsDisplayLandscape(data->uiscreen);
- SDL_bool addRotation = (data->uiscreen == [UIScreen mainScreen]);
-
- for (UIScreenMode *uimode in [data->uiscreen availableModes]) {
- CGSize size = [uimode size];
- int w = (int)size.width;
- int h = (int)size.height;
-
- /* Make sure the width/height are oriented correctly */
- if (isLandscape != (w > h)) {
- int tmp = w;
- w = h;
- h = tmp;
- }
+ @autoreleasepool {
+ SDL_DisplayData *data = (__bridge SDL_DisplayData *) display->driverdata;
+
+ SDL_bool isLandscape = UIKit_IsDisplayLandscape(data.uiscreen);
+ SDL_bool addRotation = (data.uiscreen == [UIScreen mainScreen]);
+ CGFloat scale = data.uiscreen.scale;
+
+ for (UIScreenMode *uimode in [data.uiscreen availableModes]) {
+ /* The size of a UIScreenMode is in pixels, but we deal exclusively in
+ * points (except in SDL_GL_GetDrawableSize.) */
+ CGSize size = [uimode size];
+ int w = (int)(size.width / scale);
+ int h = (int)(size.height / scale);
+
+ /* Make sure the width/height are oriented correctly */
+ if (isLandscape != (w > h)) {
+ int tmp = w;
+ w = h;
+ h = tmp;
+ }
- /* Add the native screen resolution. */
- UIKit_AddDisplayMode(display, w, h, data->scale, uimode, addRotation);
-
- if (data->scale != 1.0f) {
- /* Add the native screen resolution divided by its scale.
- * This is so devices capable of e.g. 640x960 also advertise 320x480.
- */
- UIKit_AddDisplayMode(display,
- (int)(size.width / data->scale),
- (int)(size.height / data->scale),
- 1.0f, uimode, addRotation);
+ /* Add the native screen resolution. */
+ UIKit_AddDisplayMode(display, w, h, uimode, addRotation);
}
}
}
@@ -217,19 +212,21 @@ UIKit_GetDisplayModes(_THIS, SDL_VideoDisplay * display)
int
UIKit_SetDisplayMode(_THIS, SDL_VideoDisplay * display, SDL_DisplayMode * mode)
{
- SDL_DisplayData *data = (SDL_DisplayData *) display->driverdata;
- SDL_DisplayModeData *modedata = (SDL_DisplayModeData *)mode->driverdata;
-
- [data->uiscreen setCurrentMode:modedata->uiscreenmode];
-
- if (data->uiscreen == [UIScreen mainScreen]) {
- if (mode->w > mode->h) {
- if (!UIKit_IsDisplayLandscape(data->uiscreen)) {
- [[UIApplication sharedApplication] setStatusBarOrientation:UIInterfaceOrientationLandscapeRight animated:NO];
- }
- } else if (mode->w < mode->h) {
- if (UIKit_IsDisplayLandscape(data->uiscreen)) {
- [[UIApplication sharedApplication] setStatusBarOrientation:UIInterfaceOrientationPortrait animated:NO];
+ @autoreleasepool {
+ SDL_DisplayData *data = (__bridge SDL_DisplayData *) display->driverdata;
+ SDL_DisplayModeData *modedata = (__bridge SDL_DisplayModeData *)mode->driverdata;
+
+ [data.uiscreen setCurrentMode:modedata.uiscreenmode];
+
+ if (data.uiscreen == [UIScreen mainScreen]) {
+ if (mode->w > mode->h) {
+ if (!UIKit_IsDisplayLandscape(data.uiscreen)) {
+ [[UIApplication sharedApplication] setStatusBarOrientation:UIInterfaceOrientationLandscapeRight animated:NO];
+ }
+ } else if (mode->w < mode->h) {
+ if (UIKit_IsDisplayLandscape(data.uiscreen)) {
+ [[UIApplication sharedApplication] setStatusBarOrientation:UIInterfaceOrientationPortrait animated:NO];
+ }
}
}
}
@@ -242,19 +239,21 @@ UIKit_QuitModes(_THIS)
{
/* Release Objective-C objects, so higher level doesn't free() them. */
int i, j;
- for (i = 0; i < _this->num_displays; i++) {
- SDL_VideoDisplay *display = &_this->displays[i];
+ @autoreleasepool {
+ for (i = 0; i < _this->num_displays; i++) {
+ SDL_VideoDisplay *display = &_this->displays[i];
+
+ UIKit_FreeDisplayModeData(&display->desktop_mode);
+ for (j = 0; j < display->num_display_modes; j++) {
+ SDL_DisplayMode *mode = &display->display_modes[j];
+ UIKit_FreeDisplayModeData(mode);
+ }
- UIKit_FreeDisplayModeData(&display->desktop_mode);
- for (j = 0; j < display->num_display_modes; j++) {
- SDL_DisplayMode *mode = &display->display_modes[j];
- UIKit_FreeDisplayModeData(mode);
+ if (display->driverdata != NULL) {
+ CFRelease(display->driverdata);
+ display->driverdata = NULL;
+ }
}
-
- SDL_DisplayData *data = (SDL_DisplayData *) display->driverdata;
- [data->uiscreen release];
- SDL_free(data);
- display->driverdata = NULL;
}
}
diff --git a/src/video/uikit/SDL_uikitopengles.h b/src/video/uikit/SDL_uikitopengles.h
index 947678c..f169189 100644
--- a/src/video/uikit/SDL_uikitopengles.h
+++ b/src/video/uikit/SDL_uikitopengles.h
@@ -25,6 +25,8 @@
extern int UIKit_GL_MakeCurrent(_THIS, SDL_Window * window,
SDL_GLContext context);
+extern void UIKit_GL_GetDrawableSize(_THIS, SDL_Window * window,
+ int * w, int * h);
extern void UIKit_GL_SwapWindow(_THIS, SDL_Window * window);
extern SDL_GLContext UIKit_GL_CreateContext(_THIS, SDL_Window * window);
extern void UIKit_GL_DeleteContext(_THIS, SDL_GLContext context);
diff --git a/src/video/uikit/SDL_uikitopengles.m b/src/video/uikit/SDL_uikitopengles.m
index 42303e3..50bb6a3 100644
--- a/src/video/uikit/SDL_uikitopengles.m
+++ b/src/video/uikit/SDL_uikitopengles.m
@@ -49,19 +49,37 @@ UIKit_GL_GetProcAddress(_THIS, const char *proc)
/*
note that SDL_GL_Delete context makes it current without passing the window
*/
-int UIKit_GL_MakeCurrent(_THIS, SDL_Window * window, SDL_GLContext context)
+int
+UIKit_GL_MakeCurrent(_THIS, SDL_Window * window, SDL_GLContext context)
{
- if (context) {
- SDL_WindowData *data = (SDL_WindowData *)window->driverdata;
- [data->view setCurrentContext];
- }
- else {
- [EAGLContext setCurrentContext: nil];
+ @autoreleasepool {
+ if (context) {
+ SDL_WindowData *data = (__bridge SDL_WindowData *)window->driverdata;
+ [data.view setCurrentContext];
+ }
+ else {
+ [EAGLContext setCurrentContext: nil];
+ }
}
return 0;
}
+void UIKit_GL_GetDrawableSize(_THIS, SDL_Window * window, int * w, int * h)
+{
+ @autoreleasepool {
+ SDL_WindowData *data = (__bridge SDL_WindowData *)window->driverdata;
+
+ if (w) {
+ *w = data.view.backingWidth;
+ }
+ if (h) {
+ *h = data.view.backingHeight;
+ }
+ }
+}
+
+
int
UIKit_GL_LoadLibrary(_THIS, const char *path)
{
@@ -78,102 +96,109 @@ UIKit_GL_LoadLibrary(_THIS, const char *path)
void UIKit_GL_SwapWindow(_THIS, SDL_Window * window)
{
+ @autoreleasepool {
+ SDL_WindowData *data = (__bridge SDL_WindowData *)window->driverdata;
+
#if SDL_POWER_UIKIT
- /* Check once a frame to see if we should turn off the battery monitor. */
- SDL_UIKit_UpdateBatteryMonitoring();
+ /* Check once a frame to see if we should turn off the battery monitor. */
+ SDL_UIKit_UpdateBatteryMonitoring();
#endif
- SDL_WindowData *data = (SDL_WindowData *)window->driverdata;
+ if (data.view == nil) {
+ return;
+ }
+ [data.view swapBuffers];
- if (nil == data->view) {
- return;
+ /* You need to pump events in order for the OS to make changes visible.
+ We don't pump events here because we don't want iOS application events
+ (low memory, terminate, etc.) to happen inside low level rendering.
+ */
}
- [data->view swapBuffers];
-
- /* You need to pump events in order for the OS to make changes visible.
- We don't pump events here because we don't want iOS application events
- (low memory, terminate, etc.) to happen inside low level rendering.
- */
}
-SDL_GLContext UIKit_GL_CreateContext(_THIS, SDL_Window * window)
+SDL_GLContext
+UIKit_GL_CreateContext(_THIS, SDL_Window * window)
{
- SDL_uikitopenglview *view;
- SDL_WindowData *data = (SDL_WindowData *) window->driverdata;
- SDL_VideoDisplay *display = SDL_GetDisplayForWindow(window);
- SDL_DisplayData *displaydata = display->driverdata;
- SDL_DisplayModeData *displaymodedata = display->current_mode.driverdata;
- UIWindow *uiwindow = data->uiwindow;
- EAGLSharegroup *share_group = nil;
-
- if (_this->gl_config.share_with_current_context) {
- SDL_uikitopenglview *view = (SDL_uikitopenglview *) SDL_GL_GetCurrentContext();
- share_group = [view.context sharegroup];
- }
+ @autoreleasepool {
+ SDL_uikitopenglview *view;
+ SDL_WindowData *data = (__bridge SDL_WindowData *) window->driverdata;
+ UIWindow *uiwindow = data.uiwindow;
+ CGRect frame = UIKit_ComputeViewFrame(window, uiwindow.screen);
+ EAGLSharegroup *share_group = nil;
+ CGFloat scale = 1.0;
+
+ if (window->flags & SDL_WINDOW_ALLOW_HIGHDPI) {
+ /* Set the scale to the natural scale factor of the screen - the backing
+ dimensions of the OpenGL view will match the pixel dimensions of the
+ screen rather than the dimensions in points.
+ */
+ scale = uiwindow.screen.scale;
+ }
- /* construct our view, passing in SDL's OpenGL configuration data */
- CGRect frame;
- if (window->flags & (SDL_WINDOW_FULLSCREEN|SDL_WINDOW_BORDERLESS)) {
- frame = [displaydata->uiscreen bounds];
- } else {
- frame = [displaydata->uiscreen applicationFrame];
- }
- view = [[SDL_uikitopenglview alloc] initWithFrame: frame
- scale: displaymodedata->scale
- retainBacking: _this->gl_config.retained_backing
- rBits: _this->gl_config.red_size
- gBits: _this->gl_config.green_size
- bBits: _this->gl_config.blue_size
- aBits: _this->gl_config.alpha_size
- depthBits: _this->gl_config.depth_size
- stencilBits: _this->gl_config.stencil_size
- majorVersion: _this->gl_config.major_version
- shareGroup: share_group];
- if (!view) {
- return NULL;
- }
+ if (_this->gl_config.share_with_current_context) {
+ SDL_uikitopenglview *view = (__bridge SDL_uikitopenglview *) SDL_GL_GetCurrentContext();
+ share_group = [view.context sharegroup];
+ }
- data->view = view;
- view->viewcontroller = data->viewcontroller;
- if (view->viewcontroller != nil) {
- [view->viewcontroller setView:view];
- [view->viewcontroller retain];
- }
- [uiwindow addSubview: view];
+ /* construct our view, passing in SDL's OpenGL configuration data */
+ view = [[SDL_uikitopenglview alloc] initWithFrame: frame
+ scale: scale
+ retainBacking: _this->gl_config.retained_backing
+ rBits: _this->gl_config.red_size
+ gBits: _this->gl_config.green_size
+ bBits: _this->gl_config.blue_size
+ aBits: _this->gl_config.alpha_size
+ depthBits: _this->gl_config.depth_size
+ stencilBits: _this->gl_config.stencil_size
+ sRGB: _this->gl_config.framebuffer_srgb_capable
+ majorVersion: _this->gl_config.major_version
+ shareGroup: share_group];
+ if (!view) {
+ return NULL;
+ }
- /* The view controller needs to be the root in order to control rotation on iOS 6.0 */
- if (uiwindow.rootViewController == nil) {
- uiwindow.rootViewController = view->viewcontroller;
- }
+ data.view = view;
+ view.viewcontroller = data.viewcontroller;
+ if (view.viewcontroller != nil) {
+ view.viewcontroller.view = view;
+ }
+ [uiwindow addSubview: view];
- if (UIKit_GL_MakeCurrent(_this, window, view) < 0) {
- UIKit_GL_DeleteContext(_this, view);
- return NULL;
- }
+ /* The view controller needs to be the root in order to control rotation on iOS 6.0 */
+ if (uiwindow.rootViewController == nil) {
+ uiwindow.rootViewController = view.viewcontroller;
+ }
- /* Make this window the current mouse focus for touch input */
- if (displaydata->uiscreen == [UIScreen mainScreen]) {
- SDL_SetMouseFocus(window);
- SDL_SetKeyboardFocus(window);
- }
+ if (UIKit_GL_MakeCurrent(_this, window, (__bridge SDL_GLContext)(view)) < 0) {
+ UIKit_GL_DeleteContext(_this, (SDL_GLContext) CFBridgingRetain(view));
+ return NULL;
+ }
- return view;
+ /* Make this window the current mouse focus for touch input */
+ if (uiwindow.screen == [UIScreen mainScreen]) {
+ SDL_SetMouseFocus(window);
+ SDL_SetKeyboardFocus(window);
+ }
+
+ return (SDL_GLContext) CFBridgingRetain(view);
+ }
}
-void UIKit_GL_DeleteContext(_THIS, SDL_GLContext context)
+void
+UIKit_GL_DeleteContext(_THIS, SDL_GLContext context)
{
- /* the delegate has retained the view, this will release him */
- SDL_uikitopenglview *view = (SDL_uikitopenglview *)context;
- if (view->viewcontroller) {
- UIWindow *uiwindow = (UIWindow *)view.superview;
- if (uiwindow.rootViewController == view->viewcontroller) {
- uiwindow.rootViewController = nil;
+ @autoreleasepool {
+ /* the delegate has retained the view, this will release him */
+ SDL_uikitopenglview *view = (SDL_uikitopenglview *)CFBridgingRelease(context);
+ if (view.viewcontroller) {
+ UIWindow *uiwindow = (UIWindow *)view.superview;
+ if (uiwindow.rootViewController == view.viewcontroller) {
+ uiwindow.rootViewController = nil;
+ }
+ view.viewcontroller.view = nil;
}
- [view->viewcontroller setView:nil];
- [view->viewcontroller release];
+ [view removeFromSuperview];
}
- [view removeFromSuperview];
- [view release];
}
#endif /* SDL_VIDEO_DRIVER_UIKIT */
diff --git a/src/video/uikit/SDL_uikitopenglview.h b/src/video/uikit/SDL_uikitopenglview.h
index eed2e5b..9bb8f0c 100644
--- a/src/video/uikit/SDL_uikitopenglview.h
+++ b/src/video/uikit/SDL_uikitopenglview.h
@@ -29,52 +29,35 @@
The view content is basically an EAGL surface you render your OpenGL scene into.
Note that setting the view non-opaque will only work if the EAGL surface has an alpha channel.
*/
-@interface SDL_uikitopenglview : SDL_uikitview {
+@interface SDL_uikitopenglview : SDL_uikitview
-@private
- /* The pixel dimensions of the backbuffer */
- GLint backingWidth;
- GLint backingHeight;
-
- EAGLContext *context;
-
- /* OpenGL names for the renderbuffer and framebuffers used to render to this view */
- GLuint viewRenderbuffer, viewFramebuffer;
-
- /* OpenGL name for the depth buffer that is attached to viewFramebuffer, if it exists (0 if it does not exist) */
- GLuint depthRenderbuffer;
-
- /* format of depthRenderbuffer */
- GLenum depthBufferFormat;
-
- id displayLink;
- int animationInterval;
- void (*animationCallback)(void*);
- void *animationCallbackParam;
-}
-
-@property (nonatomic, retain, readonly) EAGLContext *context;
+- (id)initWithFrame:(CGRect)frame
+ scale:(CGFloat)scale
+ retainBacking:(BOOL)retained
+ rBits:(int)rBits
+ gBits:(int)gBits
+ bBits:(int)bBits
+ aBits:(int)aBits
+ depthBits:(int)depthBits
+ stencilBits:(int)stencilBits
+ sRGB:(BOOL)sRGB
+ majorVersion:(int)majorVersion
+ shareGroup:(EAGLSharegroup*)shareGroup;
+
+@property (nonatomic, strong, readonly) EAGLContext *context;
+
+/* The width and height of the drawable in pixels (as opposed to points.) */
+@property (nonatomic, readonly) int backingWidth;
+@property (nonatomic, readonly) int backingHeight;
- (void)swapBuffers;
- (void)setCurrentContext;
-- (id)initWithFrame:(CGRect)frame
- scale:(CGFloat)scale
- retainBacking:(BOOL)retained
- rBits:(int)rBits
- gBits:(int)gBits
- bBits:(int)bBits
- aBits:(int)aBits
- depthBits:(int)depthBits
- stencilBits:(int)stencilBits
- majorVersion:(int)majorVersion
- shareGroup:(EAGLSharegroup*)shareGroup;
-
- (void)updateFrame;
- (void)setAnimationCallback:(int)interval
- callback:(void (*)(void*))callback
- callbackParam:(void*)callbackParam;
+ callback:(void (*)(void*))callback
+ callbackParam:(void*)callbackParam;
- (void)startAnimation;
- (void)stopAnimation;
diff --git a/src/video/uikit/SDL_uikitopenglview.m b/src/video/uikit/SDL_uikitopenglview.m
index 144100b..da724dc 100644
--- a/src/video/uikit/SDL_uikitopenglview.m
+++ b/src/video/uikit/SDL_uikitopenglview.m
@@ -26,42 +26,73 @@
#include <OpenGLES/EAGLDrawable.h>
#include "SDL_uikitopenglview.h"
#include "SDL_uikitmessagebox.h"
+#include "SDL_uikitvideo.h"
-@implementation SDL_uikitopenglview
+@implementation SDL_uikitopenglview {
+
+ /* OpenGL names for the renderbuffer and framebuffers used to render to this view */
+ GLuint viewRenderbuffer, viewFramebuffer;
+
+ /* OpenGL name for the depth buffer that is attached to viewFramebuffer, if it exists (0 if it does not exist) */
+ GLuint depthRenderbuffer;
+
+ /* format of depthRenderbuffer */
+ GLenum depthBufferFormat;
+
+ id displayLink;
+ int animationInterval;
+ void (*animationCallback)(void*);
+ void *animationCallbackParam;
+
+}
@synthesize context;
+@synthesize backingWidth;
+@synthesize backingHeight;
+
+ (Class)layerClass
{
return [CAEAGLLayer class];
}
- (id)initWithFrame:(CGRect)frame
- scale:(CGFloat)scale
+ scale:(CGFloat)scale
retainBacking:(BOOL)retained
- rBits:(int)rBits
- gBits:(int)gBits
- bBits:(int)bBits
- aBits:(int)aBits
- depthBits:(int)depthBits
- stencilBits:(int)stencilBits
- majorVersion:(int)majorVersion
- shareGroup:(EAGLSharegroup*)shareGroup
+ rBits:(int)rBits
+ gBits:(int)gBits
+ bBits:(int)bBits
+ aBits:(int)aBits
+ depthBits:(int)depthBits
+ stencilBits:(int)stencilBits
+ sRGB:(BOOL)sRGB
+ majorVersion:(int)majorVersion
+ shareGroup:(EAGLSharegroup*)shareGroup
{
- depthBufferFormat = 0;
-
if ((self = [super initWithFrame:frame])) {
const BOOL useStencilBuffer = (stencilBits != 0);
const BOOL useDepthBuffer = (depthBits != 0);
NSString *colorFormat = nil;
+ self.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
+ self.autoresizesSubviews = YES;
+
/* The EAGLRenderingAPI enum values currently map 1:1 to major GLES
versions, and this allows us to handle future OpenGL ES versions.
*/
EAGLRenderingAPI api = majorVersion;
- if (rBits == 8 && gBits == 8 && bBits == 8) {
+ context = [[EAGLContext alloc] initWithAPI:api sharegroup:shareGroup];
+ if (!context || ![EAGLContext setCurrentContext:context]) {
+ SDL_SetError("OpenGL ES %d not supported", majorVersion);
+ return nil;
+ }
+
+ if (sRGB && UIKit_IsSystemVersionAtLeast(@"7.0")) {
+ /* sRGB EAGL drawable support was added in iOS 7 */
+ colorFormat = kEAGLColorFormatSRGBA8;
+ } else if (rBits >= 8 && gBits >= 8 && bBits >= 8) {
/* if user specifically requests rbg888 or some color format higher than 16bpp */
colorFormat = kEAGLColorFormatRGBA8;
} else {
@@ -73,26 +104,28 @@
CAEAGLLayer *eaglLayer = (CAEAGLLayer *)self.layer;
eaglLayer.opaque = YES;
- eaglLayer.drawableProperties = [NSDictionary dictionaryWithObjectsAndKeys:
- [NSNumber numberWithBool: retained], kEAGLDrawablePropertyRetainedBacking, colorFormat, kEAGLDrawablePropertyColorFormat, nil];
-
- context = [[EAGLContext alloc] initWithAPI:api sharegroup:shareGroup];
- if (!context || ![EAGLContext setCurrentContext:context]) {
- [self release];
- SDL_SetError("OpenGL ES %d not supported", majorVersion);
- return nil;
- }
+ eaglLayer.drawableProperties = @{
+ kEAGLDrawablePropertyRetainedBacking: @(retained),
+ kEAGLDrawablePropertyColorFormat: colorFormat
+ };
/* Set the appropriate scale (for retina display support) */
self.contentScaleFactor = scale;
- /* create the buffers */
- glGenFramebuffersOES(1, &viewFramebuffer);
+ /* Create the color Renderbuffer Object */
glGenRenderbuffersOES(1, &viewRenderbuffer);
+ glBindRenderbufferOES(GL_RENDERBUFFER_OES, viewRenderbuffer);
+
+ if (![context renderbufferStorage:GL_RENDERBUFFER_OES fromDrawable:eaglLayer]) {
+ SDL_SetError("Failed creating OpenGL ES drawable");
+ return nil;
+ }
+ /* Create the Framebuffer Object */
+ glGenFramebuffersOES(1, &viewFramebuffer);
glBindFramebufferOES(GL_FRAMEBUFFER_OES, viewFramebuffer);
- glBindRenderbufferOES(GL_RENDERBUFFER_OES, viewRenderbuffer);
- [context renderbufferStorage:GL_RENDERBUFFER_OES fromDrawable:(CAEAGLLayer*)self.layer];
+
+ /* attach the color renderbuffer to the FBO */
glFramebufferRenderbufferOES(GL_FRAMEBUFFER_OES, GL_COLOR_ATTACHMENT0_OES, GL_RENDERBUFFER_OES, viewRenderbuffer);
glGetRenderbufferParameterivOES(GL_RENDERBUFFER_OES, GL_RENDERBUFFER_WIDTH_OES, &backingWidth);
@@ -119,15 +152,13 @@
}
if (glCheckFramebufferStatusOES(GL_FRAMEBUFFER_OES) != GL_FRAMEBUFFER_COMPLETE_OES) {
- return NO;
+ SDL_SetError("Failed creating OpenGL ES framebuffer");
+ return nil;
}
glBindRenderbufferOES(GL_RENDERBUFFER_OES, viewRenderbuffer);
- /* end create buffers */
-
- self.autoresizingMask = (UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight);
- self.autoresizesSubviews = YES;
}
+
return self;
}
@@ -164,8 +195,9 @@
animationCallback = callback;
animationCallbackParam = callbackParam;
- if (animationCallback)
+ if (animationCallback) {
[self startAnimation];
+ }
}
- (void)startAnimation
@@ -206,18 +238,25 @@
- (void)layoutSubviews
{
+ [super layoutSubviews];
+
[EAGLContext setCurrentContext:context];
[self updateFrame];
}
- (void)destroyFramebuffer
{
- glDeleteFramebuffersOES(1, &viewFramebuffer);
- viewFramebuffer = 0;
- glDeleteRenderbuffersOES(1, &viewRenderbuffer);
- viewRenderbuffer = 0;
+ if (viewFramebuffer != 0) {
+ glDeleteFramebuffersOES(1, &viewFramebuffer);
+ viewFramebuffer = 0;
+ }
- if (depthRenderbuffer) {
+ if (viewRenderbuffer != 0) {
+ glDeleteRenderbuffersOES(1, &viewRenderbuffer);
+ viewRenderbuffer = 0;
+ }
+
+ if (depthRenderbuffer != 0) {
glDeleteRenderbuffersOES(1, &depthRenderbuffer);
depthRenderbuffer = 0;
}
@@ -226,12 +265,10 @@
- (void)dealloc
{
- [self destroyFramebuffer];
if ([EAGLContext currentContext] == context) {
+ [self destroyFramebuffer];
[EAGLContext setCurrentContext:nil];
}
- [context release];
- [super dealloc];
}
@end
diff --git a/src/video/uikit/SDL_uikitvideo.h b/src/video/uikit/SDL_uikitvideo.h
index ef62982..dec49cd 100644
--- a/src/video/uikit/SDL_uikitvideo.h
+++ b/src/video/uikit/SDL_uikitvideo.h
@@ -25,20 +25,8 @@
#include "../SDL_sysvideo.h"
-#ifndef __IPHONE_6_0
-/* This enum isn't available in older SDKs, but we use it for our own purposes on iOS 5.1 and for the system on iOS 6.0 */
-enum UIInterfaceOrientationMask
-{
- UIInterfaceOrientationMaskPortrait = (1 << UIInterfaceOrientationPortrait),
- UIInterfaceOrientationMaskLandscapeLeft = (1 << UIInterfaceOrientationLandscapeLeft),
- UIInterfaceOrientationMaskLandscapeRight = (1 << UIInterfaceOrientationLandscapeRight),
- UIInterfaceOrientationMaskPortraitUpsideDown = (1 << UIInterfaceOrientationPortraitUpsideDown),
- UIInterfaceOrientationMaskLandscape = (UIInterfaceOrientationMaskLandscapeLeft | UIInterfaceOrientationMaskLandscapeRight),
- UIInterfaceOrientationMaskAll = (UIInterfaceOrientationMaskPortrait | UIInterfaceOrientationMaskLandscapeLeft | UIInterfaceOrientationMaskLandscapeRight | UIInterfaceOrientationMaskPortraitUpsideDown),
- UIInterfaceOrientationMaskAllButUpsideDown = (UIInterfaceOrientationMaskPortrait | UIInterfaceOrientationMaskLandscapeLeft | UIInterfaceOrientationMaskLandscapeRight),
-};
-#endif /* !__IPHONE_6_0 */
-
+BOOL UIKit_IsSystemVersionAtLeast(NSString *version);
+CGRect UIKit_ComputeViewFrame(SDL_Window *window, UIScreen *screen);
#endif /* _SDL_uikitvideo_h */
diff --git a/src/video/uikit/SDL_uikitvideo.m b/src/video/uikit/SDL_uikitvideo.m
index 4893bc1..5d4e812 100644
--- a/src/video/uikit/SDL_uikitvideo.m
+++ b/src/video/uikit/SDL_uikitvideo.m
@@ -78,12 +78,11 @@ UIKit_CreateDevice(int devindex)
device->ShowWindow = UIKit_ShowWindow;
device->HideWindow = UIKit_HideWindow;
device->RaiseWindow = UIKit_RaiseWindow;
+ device->SetWindowBordered = UIKit_SetWindowBordered;
device->SetWindowFullscreen = UIKit_SetWindowFullscreen;
device->DestroyWindow = UIKit_DestroyWindow;
device->GetWindowWMInfo = UIKit_GetWindowWMInfo;
- /* !!! FIXME: implement SetWindowBordered */
-
#if SDL_IPHONE_KEYBOARD
device->HasScreenKeyboardSupport = UIKit_HasScreenKeyboardSupport;
device->ShowScreenKeyboard = UIKit_ShowScreenKeyboard;
@@ -93,12 +92,13 @@ UIKit_CreateDevice(int devindex)
#endif
/* OpenGL (ES) functions */
- device->GL_MakeCurrent = UIKit_GL_MakeCurrent;
- device->GL_SwapWindow = UIKit_GL_SwapWindow;
+ device->GL_MakeCurrent = UIKit_GL_MakeCurrent;
+ device->GL_GetDrawableSize = UIKit_GL_GetDrawableSize;
+ device->GL_SwapWindow = UIKit_GL_SwapWindow;
device->GL_CreateContext = UIKit_GL_CreateContext;
device->GL_DeleteContext = UIKit_GL_DeleteContext;
device->GL_GetProcAddress = UIKit_GL_GetProcAddress;
- device->GL_LoadLibrary = UIKit_GL_LoadLibrary;
+ device->GL_LoadLibrary = UIKit_GL_LoadLibrary;
device->free = UIKit_DeleteDevice;
device->gl_config.accelerated = 1;
@@ -129,6 +129,26 @@ UIKit_VideoQuit(_THIS)
UIKit_QuitModes(_this);
}
+BOOL
+UIKit_IsSystemVersionAtLeast(NSString *version)
+{
+ NSString *sysversion = [UIDevice currentDevice].systemVersion;
+ return [sysversion compare:version options:NSNumericSearch] != NSOrderedAscending;
+}
+
+CGRect
+UIKit_ComputeViewFrame(SDL_Window *window, UIScreen *screen)
+{
+ BOOL hasiOS7 = UIKit_IsSystemVersionAtLeast(@"7.0");
+
+ if (hasiOS7 || (window->flags & (SDL_WINDOW_BORDERLESS|SDL_WINDOW_FULLSCREEN))) {
+ /* The view should always show behind the status bar in iOS 7+. */
+ return screen.bounds;
+ } else {
+ return screen.applicationFrame;
+ }
+}
+
/*
* iOS log support.
*
diff --git a/src/video/uikit/SDL_uikitview.h b/src/video/uikit/SDL_uikitview.h
index ce616c0..9824e78 100644
--- a/src/video/uikit/SDL_uikitview.h
+++ b/src/video/uikit/SDL_uikitview.h
@@ -31,27 +31,13 @@
#endif
#if SDL_IPHONE_KEYBOARD
-@interface SDL_uikitview : UIView<UITextFieldDelegate> {
+@interface SDL_uikitview : UIView <UITextFieldDelegate>
#else
-@interface SDL_uikitview : UIView {
+@interface SDL_uikitview : UIView
#endif
- SDL_TouchID touchId;
- UITouch *leftFingerDown;
-#ifndef IPHONE_TOUCH_EFFICIENT_DANGEROUS
- UITouch *finger[MAX_SIMULTANEOUS_TOUCHES];
-#endif
-
-#if SDL_IPHONE_KEYBOARD
- UITextField *textField;
- BOOL keyboardVisible;
- SDL_Rect textInputRect;
- int keyboardHeight;
-#endif
+@property (nonatomic, weak) SDL_uikitviewcontroller *viewcontroller;
-@public
- SDL_uikitviewcontroller *viewcontroller;
-}
- (CGPoint)touchLocation:(UITouch *)touch shouldNormalize:(BOOL)normalize;
- (void)touchesBegan:(NSSet *)touches withEvent:(UIEvent *)event;
- (void)touchesEnded:(NSSet *)touches withEvent:(UIEvent *)event;
@@ -61,9 +47,10 @@
- (void)showKeyboard;
- (void)hideKeyboard;
- (void)initializeKeyboard;
-@property (readonly) BOOL keyboardVisible;
-@property (nonatomic,assign) SDL_Rect textInputRect;
-@property (nonatomic,assign) int keyboardHeight;
+
+@property (nonatomic, assign, getter=isKeyboardVisible) BOOL keyboardVisible;
+@property (nonatomic, assign) SDL_Rect textInputRect;
+@property (nonatomic, assign) int keyboardHeight;
SDL_bool UIKit_HasScreenKeyboardSupport(_THIS);
void UIKit_ShowScreenKeyboard(_THIS, SDL_Window *window);
diff --git a/src/video/uikit/SDL_uikitview.m b/src/video/uikit/SDL_uikitview.m
index c51a3ba..c7a77de 100644
--- a/src/video/uikit/SDL_uikitview.m
+++ b/src/video/uikit/SDL_uikitview.m
@@ -35,27 +35,36 @@
#include "SDL_uikitmodes.h"
#include "SDL_uikitwindow.h"
-void _uikit_keyboard_init() ;
+void _uikit_keyboard_init();
-@implementation SDL_uikitview
+@implementation SDL_uikitview {
+
+ SDL_TouchID touchId;
+ UITouch *leftFingerDown;
+#ifndef IPHONE_TOUCH_EFFICIENT_DANGEROUS
+ UITouch *finger[MAX_SIMULTANEOUS_TOUCHES];
+#endif
+
+#if SDL_IPHONE_KEYBOARD
+ UITextField *textField;
+#endif
-- (void)dealloc
-{
- [super dealloc];
}
+@synthesize viewcontroller;
+
- (id)initWithFrame:(CGRect)frame
{
- self = [super initWithFrame: frame];
-
+ if (self = [super initWithFrame: frame]) {
#if SDL_IPHONE_KEYBOARD
- [self initializeKeyboard];
+ [self initializeKeyboard];
#endif
- self.multipleTouchEnabled = YES;
+ self.multipleTouchEnabled = YES;
- touchId = 1;
- SDL_AddTouch(touchId, "");
+ touchId = 1;
+ SDL_AddTouch(touchId, "");
+ }
return self;
@@ -65,36 +74,26 @@ void _uikit_keyboard_init() ;
{
CGPoint point = [touch locationInView: self];
- /* Get the display scale and apply that to the input coordinates */
- SDL_Window *window = self->viewcontroller.window;
- SDL_VideoDisplay *display = SDL_GetDisplayForWindow(window);
- SDL_DisplayModeData *displaymodedata = (SDL_DisplayModeData *) display->current_mode.driverdata;
-
if (normalize) {
- CGRect bounds = [self bounds];
+ CGRect bounds = self.bounds;
point.x /= bounds.size.width;
point.y /= bounds.size.height;
- } else {
- point.x *= displaymodedata->scale;
- point.y *= displaymodedata->scale;
}
+
return point;
}
- (void)touchesBegan:(NSSet *)touches withEvent:(UIEvent *)event
{
- NSEnumerator *enumerator = [touches objectEnumerator];
- UITouch *touch = (UITouch*)[enumerator nextObject];
-
- while (touch) {
+ for (UITouch *touch in touches) {
if (!leftFingerDown) {
CGPoint locationInView = [self touchLocation:touch shouldNormalize:NO];
/* send moved event */
- SDL_SendMouseMotion(self->viewcontroller.window, SDL_TOUCH_MOUSEID, 0, locationInView.x, locationInView.y);
+ SDL_SendMouseMotion(self.viewcontroller.window, SDL_TOUCH_MOUSEID, 0, locationInView.x, locationInView.y);
/* send mouse down event */
- SDL_SendMouseButton(self->viewcontroller.window, SDL_TOUCH_MOUSEID, SDL_PRESSED, SDL_BUTTON_LEFT);
+ SDL_SendMouseButton(self.viewcontroller.window, SDL_TOUCH_MOUSEID, SDL_PRESSED, SDL_BUTTON_LEFT);
leftFingerDown = touch;
}
@@ -118,25 +117,21 @@ void _uikit_keyboard_init() ;
}
}
#endif
- touch = (UITouch*)[enumerator nextObject];
}
}
- (void)touchesEnded:(NSSet *)touches withEvent:(UIEvent *)event
{
- NSEnumerator *enumerator = [touches objectEnumerator];
- UITouch *touch = (UITouch*)[enumerator nextObject];
-
- while(touch) {
+ for (UITouch *touch in touches) {
if (touch == leftFingerDown) {
/* send mouse up */
- SDL_SendMouseButton(self->viewcontroller.window, SDL_TOUCH_MOUSEID, SDL_RELEASED, SDL_BUTTON_LEFT);
+ SDL_SendMouseButton(self.viewcontroller.window, SDL_TOUCH_MOUSEID, SDL_RELEASED, SDL_BUTTON_LEFT);
leftFingerDown = nil;
}
CGPoint locationInView = [self touchLocation:touch shouldNormalize:YES];
#ifdef IPHONE_TOUCH_EFFICIENT_DANGEROUS
- SDL_SendTouch(touchId, (long)touch,
+ SDL_SendTouch(touchId, (SDL_FingerID)((size_t)touch),
SDL_FALSE, locationInView.x, locationInView.y, 1.0f);
#else
int i;
@@ -149,7 +144,6 @@ void _uikit_keyboard_init() ;
}
}
#endif
- touch = (UITouch*)[enumerator nextObject];
}
}
@@ -165,20 +159,17 @@ void _uikit_keyboard_init() ;
- (void)touchesMoved:(NSSet *)touches withEvent:(UIEvent *)event
{
- NSEnumerator *enumerator = [touches objectEnumerator];
- UITouch *touch = (UITouch*)[enumerator nextObject];
-
- while (touch) {
+ for (UITouch *touch in touches) {
if (touch == leftFingerDown) {
CGPoint locationInView = [self touchLocation:touch shouldNormalize:NO];
/* send moved event */
- SDL_SendMouseMotion(self->viewcontroller.window, SDL_TOUCH_MOUSEID, 0, locationInView.x, locationInView.y);
+ SDL_SendMouseMotion(self.viewcontroller.window, SDL_TOUCH_MOUSEID, 0, locationInView.x, locationInView.y);
}
CGPoint locationInView = [self touchLocation:touch shouldNormalize:YES];
#ifdef IPHONE_TOUCH_EFFICIENT_DANGEROUS
- SDL_SendTouchMotion(touchId, (long)touch,
+ SDL_SendTouchMotion(touchId, (SDL_FingerID)((size_t)touch),
locationInView.x, locationInView.y, 1.0f);
#else
int i;
@@ -190,7 +181,6 @@ void _uikit_keyboard_init() ;
}
}
#endif
- touch = (UITouch*)[enumerator nextObject];
}
}
@@ -199,14 +189,9 @@ void _uikit_keyboard_init() ;
*/
#if SDL_IPHONE_KEYBOARD
-@synthesize textInputRect = textInputRect;
-@synthesize keyboardHeight = keyboardHeight;
-
-/* Is the iPhone virtual keyboard visible onscreen? */
-- (BOOL)keyboardVisible
-{
- return keyboardVisible;
-}
+@synthesize textInputRect;
+@synthesize keyboardHeight;
+@synthesize keyboardVisible;
/* Set ourselves up as a UITextFieldDelegate */
- (void)initializeKeyboard
@@ -229,7 +214,6 @@ void _uikit_keyboard_init() ;
keyboardVisible = NO;
/* add the UITextField (hidden) to our view */
[self addSubview: textField];
- [textField release];
_uikit_keyboard_init();
}
@@ -318,8 +302,8 @@ static SDL_uikitview * getWindowView(SDL_Window * window)
return nil;
}
- SDL_WindowData *data = (SDL_WindowData *)window->driverdata;
- SDL_uikitview *view = data != NULL ? data->view : nil;
+ SDL_WindowData *data = (__bridge SDL_WindowData *)window->driverdata;
+ SDL_uikitview *view = data != nil ? data.view : nil;
if (view == nil) {
SDL_SetError("Window has no view");
@@ -335,44 +319,49 @@ SDL_bool UIKit_HasScreenKeyboardSupport(_THIS)
void UIKit_ShowScreenKeyboard(_THIS, SDL_Window *window)
{
- SDL_uikitview *view = getWindowView(window);
- if (view != nil) {
- [view showKeyboard];
+ @autoreleasepool {
+ SDL_uikitview *view = getWindowView(window);
+ if (view != nil) {
+ [view showKeyboard];
+ }
}
}
void UIKit_HideScreenKeyboard(_THIS, SDL_Window *window)
{
- SDL_uikitview *view = getWindowView(window);
- if (view != nil) {
- [view hideKeyboard];
+ @autoreleasepool {
+ SDL_uikitview *view = getWindowView(window);
+ if (view != nil) {
+ [view hideKeyboard];
+ }
}
}
SDL_bool UIKit_IsScreenKeyboardShown(_THIS, SDL_Window *window)
{
- SDL_uikitview *view = getWindowView(window);
- if (view == nil) {
- return 0;
- }
+ @autoreleasepool {
+ SDL_uikitview *view = getWindowView(window);
+ if (view == nil) {
+ return 0;
+ }
- return view.keyboardVisible;
+ return view.isKeyboardVisible;
+ }
}
void _uikit_keyboard_update() {
SDL_Window *window = SDL_GetFocusWindow();
if (!window) { return; }
- SDL_WindowData *data = (SDL_WindowData *)window->driverdata;
+ SDL_WindowData *data = (__bridge SDL_WindowData *)window->driverdata;
if (!data) { return; }
- SDL_uikitview *view = data->view;
+ SDL_uikitview *view = data.view;
if (!view) { return; }
-
+
SDL_Rect r = view.textInputRect;
int height = view.keyboardHeight;
int offsetx = 0;
int offsety = 0;
- float scale = [UIScreen mainScreen].scale;
if (height) {
int sw,sh;
SDL_GetWindowSize(window,&sw,&sh);
@@ -394,18 +383,16 @@ void _uikit_keyboard_update() {
offsety = -offsety;
}
- offsetx /= scale;
- offsety /= scale;
-
view.frame = CGRectMake(offsetx,offsety,view.frame.size.width,view.frame.size.height);
}
void _uikit_keyboard_set_height(int height) {
SDL_uikitview *view = getWindowView(SDL_GetFocusWindow());
if (view == nil) {
- return ;
+ return;
}
-
+
+ view.keyboardVisible = height > 0;
view.keyboardHeight = height;
_uikit_keyboard_update();
}
@@ -418,13 +405,12 @@ void _uikit_keyboard_init() {
queue:queue
usingBlock:^(NSNotification *notification) {
int height = 0;
- CGSize keyboardSize = [[[notification userInfo] objectForKey:UIKeyboardFrameBeginUserInfoKey] CGRectValue].size;
+ CGSize keyboardSize = [[notification userInfo][UIKeyboardFrameBeginUserInfoKey] CGRectValue].size;
height = keyboardSize.height;
UIInterfaceOrientation ui_orient = [[UIApplication sharedApplication] statusBarOrientation];
if (ui_orient == UIInterfaceOrientationLandscapeRight || ui_orient == UIInterfaceOrientationLandscapeLeft) {
height = keyboardSize.width;
}
- height *= [UIScreen mainScreen].scale;
_uikit_keyboard_set_height(height);
}
];
@@ -444,13 +430,15 @@ UIKit_SetTextInputRect(_THIS, SDL_Rect *rect)
SDL_InvalidParamError("rect");
return;
}
-
- SDL_uikitview *view = getWindowView(SDL_GetFocusWindow());
- if (view == nil) {
- return ;
- }
- view.textInputRect = *rect;
+ @autoreleasepool {
+ SDL_uikitview *view = getWindowView(SDL_GetFocusWindow());
+ if (view == nil) {
+ return;
+ }
+
+ view.textInputRect = *rect;
+ }
}
diff --git a/src/video/uikit/SDL_uikitviewcontroller.h b/src/video/uikit/SDL_uikitviewcontroller.h
index e8d595d..0ca98eb 100644
--- a/src/video/uikit/SDL_uikitviewcontroller.h
+++ b/src/video/uikit/SDL_uikitviewcontroller.h
@@ -23,12 +23,9 @@
#include "../SDL_sysvideo.h"
-@interface SDL_uikitviewcontroller : UIViewController {
-@private
- SDL_Window *window;
-}
+@interface SDL_uikitviewcontroller : UIViewController
-@property (readwrite) SDL_Window *window;
+@property (nonatomic, assign) SDL_Window *window;
- (id)initWithSDLWindow:(SDL_Window *)_window;
- (void)loadView;
@@ -36,5 +33,6 @@
- (NSUInteger)supportedInterfaceOrientations;
- (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)orient;
- (BOOL)prefersStatusBarHidden;
+- (UIStatusBarStyle)preferredStatusBarStyle;
@end
diff --git a/src/video/uikit/SDL_uikitviewcontroller.m b/src/video/uikit/SDL_uikitviewcontroller.m
index 447b80b..0a9fbab 100644
--- a/src/video/uikit/SDL_uikitviewcontroller.m
+++ b/src/video/uikit/SDL_uikitviewcontroller.m
@@ -40,12 +40,9 @@
- (id)initWithSDLWindow:(SDL_Window *)_window
{
- self = [self init];
- if (self == nil) {
- return nil;
+ if (self = [super initWithNibName:nil bundle:nil]) {
+ self.window = _window;
}
- self.window = _window;
-
return self;
}
@@ -56,31 +53,20 @@
- (void)viewDidLayoutSubviews
{
- if (self->window->flags & SDL_WINDOW_RESIZABLE) {
- SDL_WindowData *data = self->window->driverdata;
- SDL_VideoDisplay *display = SDL_GetDisplayForWindow(self->window);
- SDL_DisplayModeData *displaymodedata = (SDL_DisplayModeData *) display->current_mode.driverdata;
- const CGSize size = data->view.bounds.size;
- int w, h;
-
- w = (int)(size.width * displaymodedata->scale);
- h = (int)(size.height * displaymodedata->scale);
+ const CGSize size = self.view.bounds.size;
+ int w = (int) size.width;
+ int h = (int) size.height;
- SDL_SendWindowEvent(self->window, SDL_WINDOWEVENT_RESIZED, w, h);
- }
+ SDL_SendWindowEvent(window, SDL_WINDOWEVENT_RESIZED, w, h);
}
- (NSUInteger)supportedInterfaceOrientations
{
NSUInteger orientationMask = 0;
+ const char *hint = SDL_GetHint(SDL_HINT_ORIENTATIONS);
- const char *orientationsCString;
- if ((orientationsCString = SDL_GetHint(SDL_HINT_ORIENTATIONS)) != NULL) {
- BOOL rotate = NO;
- NSString *orientationsNSString = [NSString stringWithCString:orientationsCString
- encoding:NSUTF8StringEncoding];
- NSArray *orientations = [orientationsNSString componentsSeparatedByCharactersInSet:
- [NSCharacterSet characterSetWithCharactersInString:@" "]];
+ if (hint != NULL) {
+ NSArray *orientations = [@(hint) componentsSeparatedByString:@" "];
if ([orientations containsObject:@"LandscapeLeft"]) {
orientationMask |= UIInterfaceOrientationMaskLandscapeLeft;
@@ -94,14 +80,17 @@
if ([orientations containsObject:@"PortraitUpsideDown"]) {
orientationMask |= UIInterfaceOrientationMaskPortraitUpsideDown;
}
+ }
- } else if (self->window->flags & SDL_WINDOW_RESIZABLE) {
+ if (orientationMask == 0 && (window->flags & SDL_WINDOW_RESIZABLE)) {
orientationMask = UIInterfaceOrientationMaskAll; /* any orientation is okay. */
- } else {
- if (self->window->w >= self->window->h) {
+ }
+
+ if (orientationMask == 0) {
+ if (window->w >= window->h) {
orientationMask |= UIInterfaceOrientationMaskLandscape;
}
- if (self->window->h >= self->window->w) {
+ if (window->h >= window->w) {
orientationMask |= (UIInterfaceOrientationMaskPortrait | UIInterfaceOrientationMaskPortraitUpsideDown);
}
}
@@ -121,13 +110,19 @@
- (BOOL)prefersStatusBarHidden
{
- if (self->window->flags & (SDL_WINDOW_FULLSCREEN|SDL_WINDOW_BORDERLESS)) {
+ if (window->flags & (SDL_WINDOW_FULLSCREEN|SDL_WINDOW_BORDERLESS)) {
return YES;
} else {
return NO;
}
}
+- (UIStatusBarStyle)preferredStatusBarStyle
+{
+ /* We assume most games don't have a bright white background. */
+ return UIStatusBarStyleLightContent;
+}
+
@end
#endif /* SDL_VIDEO_DRIVER_UIKIT */
diff --git a/src/video/uikit/SDL_uikitwindow.h b/src/video/uikit/SDL_uikitwindow.h
index 494b028..17e9e1b 100644
--- a/src/video/uikit/SDL_uikitwindow.h
+++ b/src/video/uikit/SDL_uikitwindow.h
@@ -26,12 +26,11 @@
#import "SDL_uikitopenglview.h"
#import "SDL_uikitviewcontroller.h"
-typedef struct SDL_WindowData SDL_WindowData;
-
extern int UIKit_CreateWindow(_THIS, SDL_Window * window);
extern void UIKit_ShowWindow(_THIS, SDL_Window * window);
extern void UIKit_HideWindow(_THIS, SDL_Window * window);
extern void UIKit_RaiseWindow(_THIS, SDL_Window * window);
+extern void UIKit_SetWindowBordered(_THIS, SDL_Window * window, SDL_bool bordered);
extern void UIKit_SetWindowFullscreen(_THIS, SDL_Window * window, SDL_VideoDisplay * display, SDL_bool fullscreen);
extern void UIKit_DestroyWindow(_THIS, SDL_Window * window);
extern SDL_bool UIKit_GetWindowWMInfo(_THIS, SDL_Window * window,
@@ -39,12 +38,17 @@ extern SDL_bool UIKit_GetWindowWMInfo(_THIS, SDL_Window * window,
@class UIWindow;
-struct SDL_WindowData
-{
- UIWindow *uiwindow;
- SDL_uikitopenglview *view;
- SDL_uikitviewcontroller *viewcontroller;
-};
+@interface SDL_uikitwindow : UIWindow
+
+@end
+
+@interface SDL_WindowData : NSObject
+
+@property (nonatomic, strong) SDL_uikitwindow *uiwindow;
+@property (nonatomic, strong) SDL_uikitopenglview *view;
+@property (nonatomic, strong) SDL_uikitviewcontroller *viewcontroller;
+
+@end
#endif /* _SDL_uikitwindow_h */
diff --git a/src/video/uikit/SDL_uikitwindow.m b/src/video/uikit/SDL_uikitwindow.m
index 2b15677..a250ca5 100644
--- a/src/video/uikit/SDL_uikitwindow.m
+++ b/src/video/uikit/SDL_uikitwindow.m
@@ -41,43 +41,56 @@
#include <Foundation/Foundation.h>
+@implementation SDL_uikitwindow
+- (void)layoutSubviews
+{
+ [super layoutSubviews];
+
+ /* This seems to be needed on iOS 8, otherwise the window's frame is put in
+ * an unexpected position when the screen or device is rotated.
+ * FIXME: is there a better solution to that problem than this ugly hack?
+ */
+ self.frame = self.screen.bounds;
+}
+
+@end
+@implementation SDL_WindowData
-static int SetupWindowData(_THIS, SDL_Window *window, UIWindow *uiwindow, SDL_bool created)
+@synthesize uiwindow;
+@synthesize view;
+@synthesize viewcontroller;
+
+@end
+
+
+static int SetupWindowData(_THIS, SDL_Window *window, SDL_uikitwindow *uiwindow, SDL_bool created)
{
SDL_VideoDisplay *display = SDL_GetDisplayForWindow(window);
- SDL_DisplayModeData *displaymodedata = (SDL_DisplayModeData *) display->current_mode.driverdata;
- SDL_DisplayData *displaydata = (SDL_DisplayData *) display->driverdata;
- SDL_WindowData *data;
+ SDL_DisplayData *displaydata = (__bridge SDL_DisplayData *) display->driverdata;
/* Allocate the window data */
- data = (SDL_WindowData *)SDL_malloc(sizeof(*data));
+ SDL_WindowData *data = [[SDL_WindowData alloc] init];
if (!data) {
return SDL_OutOfMemory();
}
- data->uiwindow = uiwindow;
- data->viewcontroller = nil;
- data->view = nil;
+
+ data.uiwindow = uiwindow;
/* Fill in the SDL window with the window data */
{
window->x = 0;
window->y = 0;
- CGRect bounds;
- if (window->flags & (SDL_WINDOW_FULLSCREEN|SDL_WINDOW_BORDERLESS)) {
- bounds = [displaydata->uiscreen bounds];
- } else {
- bounds = [displaydata->uiscreen applicationFrame];
- }
+ CGRect frame = UIKit_ComputeViewFrame(window, displaydata.uiscreen);
- /* Get frame dimensions in pixels */
- int width = (int)(bounds.size.width * displaymodedata->scale);
- int height = (int)(bounds.size.height * displaymodedata->scale);
+ /* Get frame dimensions */
+ int width = (int) frame.size.width;
+ int height = (int) frame.size.height;
/* Make sure the width/height are oriented correctly */
- if (UIKit_IsDisplayLandscape(displaydata->uiscreen) != (width > height)) {
+ if (UIKit_IsDisplayLandscape(displaydata.uiscreen) != (width > height)) {
int temp = width;
width = height;
height = temp;
@@ -87,7 +100,7 @@ static int SetupWindowData(_THIS, SDL_Window *window, UIWindow *uiwindow, SDL_bo
window->h = height;
}
- window->driverdata = data;
+ window->driverdata = (void *) CFBridgingRetain(data);
/* only one window on iOS, always shown */
window->flags &= ~SDL_WINDOW_HIDDEN;
@@ -96,7 +109,7 @@ static int SetupWindowData(_THIS, SDL_Window *window, UIWindow *uiwindow, SDL_bo
* This is only set if the window is on the main screen. Other screens
* just force the window to have the borderless flag.
*/
- if (displaydata->uiscreen == [UIScreen mainScreen]) {
+ if (displaydata.uiscreen == [UIScreen mainScreen]) {
window->flags |= SDL_WINDOW_INPUT_FOCUS; /* always has input focus */
/* This was setup earlier for our window, and in iOS 7 is controlled by the view, not the application
@@ -116,10 +129,8 @@ static int SetupWindowData(_THIS, SDL_Window *window, UIWindow *uiwindow, SDL_bo
* device orientation changes. This will trigger resize events, if
* appropriate.
*/
- SDL_uikitviewcontroller *controller;
- controller = [SDL_uikitviewcontroller alloc];
- data->viewcontroller = [controller initWithSDLWindow:window];
- [data->viewcontroller setTitle:@"SDL App"]; /* !!! FIXME: hook up SDL_SetWindowTitle() */
+ data.viewcontroller = [[SDL_uikitviewcontroller alloc] initWithSDLWindow:window];
+ data.viewcontroller.title = @"SDL App"; /* !!! FIXME: hook up SDL_SetWindowTitle() */
return 0;
}
@@ -127,105 +138,109 @@ static int SetupWindowData(_THIS, SDL_Window *window, UIWindow *uiwindow, SDL_bo
int
UIKit_CreateWindow(_THIS, SDL_Window *window)
{
- SDL_VideoDisplay *display = SDL_GetDisplayForWindow(window);
- SDL_DisplayData *data = (SDL_DisplayData *) display->driverdata;
- const BOOL external = ([UIScreen mainScreen] != data->uiscreen);
- const CGSize origsize = [[data->uiscreen currentMode] size];
-
- /* SDL currently puts this window at the start of display's linked list. We rely on this. */
- SDL_assert(_this->windows == window);
-
- /* We currently only handle a single window per display on iOS */
- if (window->next != NULL) {
- return SDL_SetError("Only one window allowed per display.");
- }
-
- /* If monitor has a resolution of 0x0 (hasn't been explicitly set by the
- * user, so it's in standby), try to force the display to a resolution
- * that most closely matches the desired window size.
- */
- if ((origsize.width == 0.0f) && (origsize.height == 0.0f)) {
- if (display->num_display_modes == 0) {
- _this->GetDisplayModes(_this, display);
+ @autoreleasepool {
+ SDL_VideoDisplay *display = SDL_GetDisplayForWindow(window);
+ SDL_DisplayData *data = (__bridge SDL_DisplayData *) display->driverdata;
+ const BOOL external = ([UIScreen mainScreen] != data.uiscreen);
+ const CGSize origsize = [[data.uiscreen currentMode] size];
+
+ /* SDL currently puts this window at the start of display's linked list. We rely on this. */
+ SDL_assert(_this->windows == window);
+
+ /* We currently only handle a single window per display on iOS */
+ if (window->next != NULL) {
+ return SDL_SetError("Only one window allowed per display.");
}
- int i;
- const SDL_DisplayMode *bestmode = NULL;
- for (i = display->num_display_modes; i >= 0; i--) {
- const SDL_DisplayMode *mode = &display->display_modes[i];
- if ((mode->w >= window->w) && (mode->h >= window->h))
- bestmode = mode;
- }
+ /* If monitor has a resolution of 0x0 (hasn't been explicitly set by the
+ * user, so it's in standby), try to force the display to a resolution
+ * that most closely matches the desired window size.
+ */
+ if ((origsize.width == 0.0f) && (origsize.height == 0.0f)) {
+ if (display->num_display_modes == 0) {
+ _this->GetDisplayModes(_this, display);
+ }
- if (bestmode) {
- SDL_DisplayModeData *modedata = (SDL_DisplayModeData *)bestmode->driverdata;
- [data->uiscreen setCurrentMode:modedata->uiscreenmode];
+ int i;
+ const SDL_DisplayMode *bestmode = NULL;
+ for (i = display->num_display_modes; i >= 0; i--) {
+ const SDL_DisplayMode *mode = &display->display_modes[i];
+ if ((mode->w >= window->w) && (mode->h >= window->h))
+ bestmode = mode;
+ }
- /* desktop_mode doesn't change here (the higher level will
- * use it to set all the screens back to their defaults
- * upon window destruction, SDL_Quit(), etc.
- */
- display->current_mode = *bestmode;
- }
- }
+ if (bestmode) {
+ SDL_DisplayModeData *modedata = (__bridge SDL_DisplayModeData *)bestmode->driverdata;
+ [data.uiscreen setCurrentMode:modedata.uiscreenmode];
- if (data->uiscreen == [UIScreen mainScreen]) {
- if (window->flags & (SDL_WINDOW_FULLSCREEN|SDL_WINDOW_BORDERLESS)) {
- [UIApplication sharedApplication].statusBarHidden = YES;
- } else {
- [UIApplication sharedApplication].statusBarHidden = NO;
+ /* desktop_mode doesn't change here (the higher level will
+ * use it to set all the screens back to their defaults
+ * upon window destruction, SDL_Quit(), etc.
+ */
+ display->current_mode = *bestmode;
+ }
}
- }
- if (!(window->flags & SDL_WINDOW_RESIZABLE)) {
- if (window->w > window->h) {
- if (!UIKit_IsDisplayLandscape(data->uiscreen)) {
- [[UIApplication sharedApplication] setStatusBarOrientation:UIInterfaceOrientationLandscapeRight animated:NO];
+ if (data.uiscreen == [UIScreen mainScreen]) {
+ if (window->flags & (SDL_WINDOW_FULLSCREEN|SDL_WINDOW_BORDERLESS)) {
+ [UIApplication sharedApplication].statusBarHidden = YES;
+ } else {
+ [UIApplication sharedApplication].statusBarHidden = NO;
}
- } else if (window->w < window->h) {
- if (UIKit_IsDisplayLandscape(data->uiscreen)) {
- [[UIApplication sharedApplication] setStatusBarOrientation:UIInterfaceOrientationPortrait animated:NO];
+ }
+
+ if (!(window->flags & SDL_WINDOW_RESIZABLE)) {
+ if (window->w > window->h) {
+ if (!UIKit_IsDisplayLandscape(data.uiscreen)) {
+ [[UIApplication sharedApplication] setStatusBarOrientation:UIInterfaceOrientationLandscapeRight animated:NO];
+ }
+ } else if (window->w < window->h) {
+ if (UIKit_IsDisplayLandscape(data.uiscreen)) {
+ [[UIApplication sharedApplication] setStatusBarOrientation:UIInterfaceOrientationPortrait animated:NO];
+ }
}
}
- }
- /* ignore the size user requested, and make a fullscreen window */
- /* !!! FIXME: can we have a smaller view? */
- UIWindow *uiwindow = [UIWindow alloc];
- uiwindow = [uiwindow initWithFrame:[data->uiscreen bounds]];
+ /* ignore the size user requested, and make a fullscreen window */
+ /* !!! FIXME: can we have a smaller view? */
+ SDL_uikitwindow *uiwindow = [[SDL_uikitwindow alloc] initWithFrame:data.uiscreen.bounds];
+
+ /* put the window on an external display if appropriate. This implicitly
+ * does [uiwindow setframe:[uiscreen bounds]], so don't do it on the
+ * main display, where we land by default, as that would eat the
+ * status bar real estate.
+ */
+ if (external) {
+ [uiwindow setScreen:data.uiscreen];
+ }
- /* put the window on an external display if appropriate. This implicitly
- * does [uiwindow setframe:[uiscreen bounds]], so don't do it on the
- * main display, where we land by default, as that would eat the
- * status bar real estate.
- */
- if (external) {
- [uiwindow setScreen:data->uiscreen];
- }
+ if (SetupWindowData(_this, window, uiwindow, SDL_TRUE) < 0) {
+ return -1;
+ }
- if (SetupWindowData(_this, window, uiwindow, SDL_TRUE) < 0) {
- [uiwindow release];
- return -1;
}
return 1;
-
}
void
UIKit_ShowWindow(_THIS, SDL_Window * window)
{
- UIWindow *uiwindow = ((SDL_WindowData *) window->driverdata)->uiwindow;
+ @autoreleasepool {
+ UIWindow *uiwindow = ((__bridge SDL_WindowData *) window->driverdata).uiwindow;
- [uiwindow makeKeyAndVisible];
+ [uiwindow makeKeyAndVisible];
+ }
}
void
UIKit_HideWindow(_THIS, SDL_Window * window)
{
- UIWindow *uiwindow = ((SDL_WindowData *) window->driverdata)->uiwindow;
+ @autoreleasepool {
+ UIWindow *uiwindow = ((__bridge SDL_WindowData *) window->driverdata).uiwindow;
- uiwindow.hidden = YES;
+ uiwindow.hidden = YES;
+ }
}
void
@@ -239,91 +254,106 @@ UIKit_RaiseWindow(_THIS, SDL_Window * window)
_this->GL_MakeCurrent(_this, _this->current_glwin, _this->current_glctx);
}
-void
-UIKit_SetWindowFullscreen(_THIS, SDL_Window * window, SDL_VideoDisplay * display, SDL_bool fullscreen)
+static void
+UIKit_UpdateWindowBorder(_THIS, SDL_Window * window)
{
- SDL_DisplayData *displaydata = (SDL_DisplayData *) display->driverdata;
- SDL_DisplayModeData *displaymodedata = (SDL_DisplayModeData *) display->current_mode.driverdata;
- UIWindow *uiwindow = ((SDL_WindowData *) window->driverdata)->uiwindow;
+ SDL_WindowData *windowdata = (__bridge SDL_WindowData *) window->driverdata;
+ SDL_uikitviewcontroller *viewcontroller = windowdata.viewcontroller;
+ CGRect frame;
- if (fullscreen) {
- [UIApplication sharedApplication].statusBarHidden = YES;
- } else {
- [UIApplication sharedApplication].statusBarHidden = NO;
- }
+ if (windowdata.uiwindow.screen == [UIScreen mainScreen]) {
+ if (window->flags & (SDL_WINDOW_FULLSCREEN | SDL_WINDOW_BORDERLESS)) {
+ [UIApplication sharedApplication].statusBarHidden = YES;
+ } else {
+ [UIApplication sharedApplication].statusBarHidden = NO;
+ }
- CGRect bounds;
- if (fullscreen) {
- bounds = [displaydata->uiscreen bounds];
- } else {
- bounds = [displaydata->uiscreen applicationFrame];
+ /* iOS 7+ won't update the status bar until we tell it to. */
+ if ([viewcontroller respondsToSelector:@selector(setNeedsStatusBarAppearanceUpdate)]) {
+ [viewcontroller setNeedsStatusBarAppearanceUpdate];
+ }
}
- /* Get frame dimensions in pixels */
- int width = (int)(bounds.size.width * displaymodedata->scale);
- int height = (int)(bounds.size.height * displaymodedata->scale);
+ /* Update the view's frame to account for the status bar change. */
+ frame = UIKit_ComputeViewFrame(window, windowdata.uiwindow.screen);
+
+ windowdata.view.frame = frame;
+ [windowdata.view setNeedsLayout];
+ [windowdata.view layoutIfNeeded];
+
+ /* Get frame dimensions */
+ int width = (int) frame.size.width;
+ int height = (int) frame.size.height;
/* We can pick either width or height here and we'll rotate the
- screen to match, so we pick the closest to what we wanted.
+ screen to match, so we pick the closest to what we wanted.
*/
if (window->w >= window->h) {
- if (width > height) {
- window->w = width;
- window->h = height;
- } else {
- window->w = height;
- window->h = width;
- }
+ SDL_SendWindowEvent(window, SDL_WINDOWEVENT_RESIZED, SDL_max(width, height), SDL_min(width, height));
} else {
- if (width > height) {
- window->w = height;
- window->h = width;
- } else {
- window->w = width;
- window->h = height;
- }
+ SDL_SendWindowEvent(window, SDL_WINDOWEVENT_RESIZED, SDL_min(width, height), SDL_max(width, height));
}
}
void
-UIKit_DestroyWindow(_THIS, SDL_Window * window)
+UIKit_SetWindowBordered(_THIS, SDL_Window * window, SDL_bool bordered)
{
- SDL_WindowData *data = (SDL_WindowData *)window->driverdata;
+ @autoreleasepool {
+ UIKit_UpdateWindowBorder(_this, window);
+ }
+}
- if (data) {
- [data->viewcontroller release];
- [data->uiwindow release];
- SDL_free(data);
+void
+UIKit_SetWindowFullscreen(_THIS, SDL_Window * window, SDL_VideoDisplay * display, SDL_bool fullscreen)
+{
+ @autoreleasepool {
+ UIKit_UpdateWindowBorder(_this, window);
+ }
+}
+
+void
+UIKit_DestroyWindow(_THIS, SDL_Window * window)
+{
+ @autoreleasepool {
+ if (window->driverdata != NULL) {
+ CFRelease(window->driverdata);
+ }
}
+
window->driverdata = NULL;
}
SDL_bool
UIKit_GetWindowWMInfo(_THIS, SDL_Window * window, SDL_SysWMinfo * info)
{
- UIWindow *uiwindow = ((SDL_WindowData *) window->driverdata)->uiwindow;
+ @autoreleasepool {
+ UIWindow *uiwindow = ((__bridge SDL_WindowData *) window->driverdata).uiwindow;
- if (info->version.major <= SDL_MAJOR_VERSION) {
- info->subsystem = SDL_SYSWM_UIKIT;
- info->info.uikit.window = uiwindow;
- return SDL_TRUE;
- } else {
- SDL_SetError("Application not compiled with SDL %d.%d\n",
- SDL_MAJOR_VERSION, SDL_MINOR_VERSION);
- return SDL_FALSE;
+ if (info->version.major <= SDL_MAJOR_VERSION) {
+ info->subsystem = SDL_SYSWM_UIKIT;
+ info->info.uikit.window = uiwindow;
+ return SDL_TRUE;
+ } else {
+ SDL_SetError("Application not compiled with SDL %d.%d\n",
+ SDL_MAJOR_VERSION, SDL_MINOR_VERSION);
+ return SDL_FALSE;
+ }
}
}
int
SDL_iPhoneSetAnimationCallback(SDL_Window * window, int interval, void (*callback)(void*), void *callbackParam)
{
- SDL_WindowData *data = window ? (SDL_WindowData *)window->driverdata : NULL;
+ @autoreleasepool {
+ SDL_WindowData *data = window ? (__bridge SDL_WindowData *)window->driverdata : nil;
+
+ if (!data || !data.view) {
+ return SDL_SetError("Invalid window or view not set");
+ }
- if (!data || !data->view) {
- return SDL_SetError("Invalid window or view not set");
+ [data.view setAnimationCallback:interval callback:callback callbackParam:callbackParam];
}
- [data->view setAnimationCallback:interval callback:callback callbackParam:callbackParam];
return 0;
}