Commit 365fd9c6026e81572fbd021982323e4330fcbdfb

Sylvain Becker 2019-01-14T10:04:54

Android/openslES: some space and indentation to match SDL conventions

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
diff --git a/src/audio/openslES/SDL_openslES.c b/src/audio/openslES/SDL_openslES.c
index db9f85c..99b9550 100644
--- a/src/audio/openslES/SDL_openslES.c
+++ b/src/audio/openslES/SDL_openslES.c
@@ -50,453 +50,452 @@ static SLObjectItf outputMixObject = NULL;
 //static SLEnvironmentalReverbItf outputMixEnvironmentalReverb = NULL;
 
 // aux effect on the output mix, used by the buffer queue player
-static const SLEnvironmentalReverbSettings reverbSettings =
-    SL_I3DL2_ENVIRONMENT_PRESET_STONECORRIDOR;
+// static const SLEnvironmentalReverbSettings reverbSettings = SL_I3DL2_ENVIRONMENT_PRESET_STONECORRIDOR;
 
 // buffer queue player interfaces
-static SLObjectItf						bqPlayerObject = NULL;
-static SLPlayItf 						bqPlayerPlay;
-static SLAndroidSimpleBufferQueueItf	bqPlayerBufferQueue;
-//static SLEffectSendItf					bqPlayerEffectSend;
-static SLMuteSoloItf					bqPlayerMuteSolo;
-static SLVolumeItf						bqPlayerVolume;
+static SLObjectItf                   bqPlayerObject = NULL;
+static SLPlayItf                     bqPlayerPlay;
+static SLAndroidSimpleBufferQueueItf bqPlayerBufferQueue;
+//static SLEffectSendItf          bqPlayerEffectSend;
+static SLMuteSoloItf                 bqPlayerMuteSolo;
+static SLVolumeItf                   bqPlayerVolume;
 
+#if 0
 // recorder interfaces TODO
-static SLObjectItf						recorderObject = NULL;
-static SLRecordItf						recorderRecord;
-static SLAndroidSimpleBufferQueueItf	recorderBufferQueue;
+static SLObjectItf                   recorderObject = NULL;
+static SLRecordItf                   recorderRecord;
+static SLAndroidSimpleBufferQueueItf recorderBufferQueue;
+#endif
 
 // pointer and size of the next player buffer to enqueue, and number of remaining buffers
-static short 	*nextBuffer;
-static unsigned	nextSize;
-static int 		nextCount;
-
-static const char	*sldevaudiorecorderstr	= "SLES Audio Recorder";
-static const char	*sldevaudioplayerstr 	= "SLES Audio Player";
-
-#define	SLES_DEV_AUDIO_RECORDER	sldevaudiorecorderstr
-#define	SLES_DEV_AUDIO_PLAYER	sldevaudioplayerstr
+#if 0
+static short      *nextBuffer;
+static unsigned    nextSize;
+static int         nextCount;
+#endif
 
 #define NUM_BUFFERS 2           /* -- Don't lower this! */
 
-static	Uint8	*mixbuff = NULL;
-static	int		next_buffer = 0;
-static	Uint8	*pmixbuff[NUM_BUFFERS];
+static Uint8   *mixbuff               = NULL;
+static int      next_buffer           = 0;
+static Uint8   *pmixbuff[NUM_BUFFERS];
 
-static SDL_sem *playsem = NULL, *recsem = NULL;
+static SDL_sem *playsem               = NULL;
+#if 0
+static SDL_sem *recsem                = NULL;
+#endif
 
 //static SDL_AudioDevice* audioDevice = NULL;
 
 #if 0
+static const char *sldevaudiorecorderstr = "SLES Audio Recorder";
+static const char *sldevaudioplayerstr   = "SLES Audio Player";
+
+#define  SLES_DEV_AUDIO_RECORDER  sldevaudiorecorderstr
+#define  SLES_DEV_AUDIO_PLAYER  sldevaudioplayerstr
 static void openslES_DetectDevices( int iscapture )
 {
-	LOGI( "openSLES_DetectDevices()" );
+  LOGI( "openSLES_DetectDevices()" );
     if ( iscapture )
             addfn( SLES_DEV_AUDIO_RECORDER );
-	else
+  else
             addfn( SLES_DEV_AUDIO_PLAYER );
-	return;
+  return;
 }
 #endif
 
-static void openslES_DestroyEngine( void );
+static void openslES_DestroyEngine(void);
 
-static int	openslES_CreateEngine( void )
+static int
+openslES_CreateEngine(void)
 {
-	SLresult result;
+    SLresult result;
 
-	LOGI( "openSLES_CreateEngine()" );
+    LOGI("openSLES_CreateEngine()");
 
-	// create engine
-	result = slCreateEngine( &engineObject, 0, NULL, 0, NULL, NULL );
-	if ( SL_RESULT_SUCCESS != result ) {
-
-		LOGE( "slCreateEngine failed" );
-		goto error;
-	}
+    // create engine
+    result = slCreateEngine(&engineObject, 0, NULL, 0, NULL, NULL);
+    if (SL_RESULT_SUCCESS != result) {
+        LOGE("slCreateEngine failed");
+        goto error;
+    }
 
-	LOGI( "slCreateEngine OK" );
+    LOGI("slCreateEngine OK");
 
     // realize the engine
-    result = (*engineObject)->Realize( engineObject, SL_BOOLEAN_FALSE );
-	if ( SL_RESULT_SUCCESS != result ) {
-
-		LOGE( "RealizeEngine failed" );
-		goto error;
-	}
+    result = (*engineObject)->Realize(engineObject, SL_BOOLEAN_FALSE);
+    if (SL_RESULT_SUCCESS != result) {
+        LOGE("RealizeEngine failed");
+        goto error;
+    }
 
-	LOGI( "RealizeEngine OK" );
+    LOGI("RealizeEngine OK");
 
     // get the engine interface, which is needed in order to create other objects
-    result = (*engineObject)->GetInterface( engineObject, SL_IID_ENGINE, &engineEngine );
-	if ( SL_RESULT_SUCCESS != result ) {
-
-		LOGE( "EngineGetInterface failed" );
-		goto error;
-	}
+    result = (*engineObject)->GetInterface(engineObject, SL_IID_ENGINE, &engineEngine);
+    if (SL_RESULT_SUCCESS != result) {
+        LOGE("EngineGetInterface failed");
+        goto error;
+    }
 
-	LOGI( "EngineGetInterface OK" );
+    LOGI("EngineGetInterface OK");
 
     // create output mix, with environmental reverb specified as a non-required interface
-//  const SLInterfaceID ids[1] = { SL_IID_ENVIRONMENTALREVERB };
-//  const SLboolean req[1] = { SL_BOOLEAN_FALSE };
-
-  const SLInterfaceID ids[1] = { SL_IID_VOLUME };
-  const SLboolean req[1] = { SL_BOOLEAN_FALSE };
-  result = (*engineEngine)->CreateOutputMix( engineEngine, &outputMixObject, 1, ids, req );
-
-	if ( SL_RESULT_SUCCESS != result ) {
-
-		LOGE( "CreateOutputMix failed" );
-		goto error;
-	}
-	LOGI( "CreateOutputMix OK" );
+    // const SLInterfaceID ids[1] = { SL_IID_ENVIRONMENTALREVERB };
+    // const SLboolean req[1] = { SL_BOOLEAN_FALSE };
 
-  // realize the output mix
-  result = (*outputMixObject)->Realize( outputMixObject, SL_BOOLEAN_FALSE );
-	if ( SL_RESULT_SUCCESS != result ) {
+    const SLInterfaceID ids[1] = { SL_IID_VOLUME };
+    const SLboolean req[1] = { SL_BOOLEAN_FALSE };
+    result = (*engineEngine)->CreateOutputMix(engineEngine, &outputMixObject, 1, ids, req);
 
-		LOGE( "RealizeOutputMix failed" );
-		goto error;
-	}
+    if (SL_RESULT_SUCCESS != result) {
+        LOGE("CreateOutputMix failed");
+        goto error;
+    }
+    LOGI("CreateOutputMix OK");
 
-	return 1;
+    // realize the output mix
+    result = (*outputMixObject)->Realize(outputMixObject, SL_BOOLEAN_FALSE);
+    if (SL_RESULT_SUCCESS != result) {
+        LOGE("RealizeOutputMix failed");
+        goto error;
+    }
+    return 1;
 
-error:;
-	openslES_DestroyEngine( );
-	return 0;
+error:
+    openslES_DestroyEngine();
+    return 0;
 }
 
-static	void	openslES_DestroyPCMPlayer( void );
-static	void	openslES_DestroyPCMRecorder( void );
+static void openslES_DestroyPCMPlayer(void);
+static void openslES_DestroyPCMRecorder(void);
 
-static void openslES_DestroyEngine( void )
+static void openslES_DestroyEngine(void)
 {
-	LOGI( "openslES_DestroyEngine()" );
-
-	openslES_DestroyPCMPlayer( );
-	openslES_DestroyPCMRecorder( );
-
-	// destroy output mix object, and invalidate all associated interfaces
-	if ( outputMixObject != NULL ) {
-
-	    (*outputMixObject)->Destroy( outputMixObject );
-	    outputMixObject = NULL;
-//	    outputMixEnvironmentalReverb = NULL;
-	}
-
-	// destroy engine object, and invalidate all associated interfaces
-	if (engineObject != NULL) {
+    LOGI("openslES_DestroyEngine()");
+    openslES_DestroyPCMPlayer();
+    openslES_DestroyPCMRecorder();
+
+    // destroy output mix object, and invalidate all associated interfaces
+    if (outputMixObject != NULL) {
+        (*outputMixObject)->Destroy(outputMixObject);
+        outputMixObject = NULL;
+        // outputMixEnvironmentalReverb = NULL;
+    }
 
-	    (*engineObject)->Destroy( engineObject );
-	    engineObject = NULL;
-	    engineEngine = NULL;
-	}
+    // destroy engine object, and invalidate all associated interfaces
+    if (engineObject != NULL) {
+        (*engineObject)->Destroy(engineObject);
+        engineObject = NULL;
+        engineEngine = NULL;
+    }
 
-	return;
+    return;
 }
 
 // this callback handler is called every time a buffer finishes playing
-static void bqPlayerCallback( SLAndroidSimpleBufferQueueItf bq, void *context )
+static void
+bqPlayerCallback(SLAndroidSimpleBufferQueueItf bq, void *context)
 {
-	static int	t = 0;
-//    assert(bq == bqPlayerBufferQueue);
-//    assert(NULL == context);
+    static int t = 0;
+
+    // assert(bq == bqPlayerBufferQueue);
+    // assert(NULL == context);
 
     // for streaming playback, replace this test by logic to find and fill the next buffer
 #if 0
-	if (--nextCount > 0 && NULL != nextBuffer && 0 != nextSize) {
-		SLresult result;
-		// enqueue another buffer
-		result = (*bqPlayerBufferQueue)->Enqueue(bqPlayerBufferQueue, nextBuffer, nextSize);
-		// the most likely other result is SL_RESULT_BUFFER_INSUFFICIENT,
-		// which for this code example would indicate a programming error
-		assert(SL_RESULT_SUCCESS == result);
-		(void)result;
-	}
+    if (--nextCount > 0 && NULL != nextBuffer && 0 != nextSize)
+    {
+        SLresult result;
+
+        // enqueue another buffer
+        result = (*bqPlayerBufferQueue)->Enqueue(bqPlayerBufferQueue, nextBuffer, nextSize);
+        // the most likely other result is SL_RESULT_BUFFER_INSUFFICIENT,
+        // which for this code example would indicate a programming error
+        assert(SL_RESULT_SUCCESS == result);
+        (void) result;
+    }
 #endif
-
-	LOGI( "SLES: Playback Callmeback %u", t++ );
-
-	SDL_SemPost( playsem );
-
-	return;
+    LOGI("SLES: Playback Callmeback %u", t++);
+    SDL_SemPost(playsem);
+    return;
 }
 
-static int openslES_CreatePCMRecorder( _THIS )
+static int
+openslES_CreatePCMRecorder(_THIS)
 {
-	LOGE( "openslES_CreatePCMRecorder not implimented yet!" );
-	return SDL_SetError( "openslES_CreatePCMRecorder not implimented yet!" );
+    LOGE("openslES_CreatePCMRecorder not implimented yet!");
+    return SDL_SetError("openslES_CreatePCMRecorder not implimented yet!");
 }
 
-static void openslES_DestroyPCMRecorder( void )
+static void
+openslES_DestroyPCMRecorder(void)
 {
-	return;
+    return;
 }
 
-static int openslES_CreatePCMPlayer( _THIS )
+static int
+openslES_CreatePCMPlayer(
+      _THIS)
 {
-	SLDataFormat_PCM format_pcm;
-  SDL_AudioFormat	test_format;
-	SLresult result;
-	int	i;
+    SLDataFormat_PCM format_pcm;
 
-/*
-	test_format = SDL_FirstAudioFormat( this->spec.format );
+    SLresult result;
+    int i;
 
-	while ( test_format != 0 ) {
+    /*
+      SDL_AudioFormat test_format;
+      test_format = SDL_FirstAudioFormat( this->spec.format );
 
-		if ( SDL_AUDIO_ISSIGNED(test_format) && SDL_AUDIO_ISINT(test_format ) ) break;
-		test_format = SDL_NextAudioFormat( );
-	}
+      while (test_format != 0) {
 
-	if ( test_format == 0 ) {
+          if (SDL_AUDIO_ISSIGNED(test_format) && SDL_AUDIO_ISINT(test_format)) {
+              break;
+          }
+          test_format = SDL_NextAudioFormat();
+      }
 
-		// Didn't find a compatible format :( 
-		LOGI( "No compatible audio format!" );
-		return SDL_SetError("No compatible audio format!");
-	}
+      if ( test_format == 0 ) {
+          // Didn't find a compatible format :
+          LOGI( "No compatible audio format!" );
+          return SDL_SetError("No compatible audio format!");
+      }
 
-	this->spec.format = test_format;
-*/
+      this->spec.format = test_format;
+    */
 
- // Update the fragment size as size in bytes 
- SDL_CalculateAudioSpec( &this->spec );
+    // Update the fragment size as size in bytes
+    SDL_CalculateAudioSpec(&this->spec);
 
-	LOGI( "Try to open %u hz %u bit chan %u %s samples %u", 
-			this->spec.freq, SDL_AUDIO_BITSIZE( this->spec.format ), 
-			this->spec.channels, (test_format&0x1000) ? "BE" : "LE", this->spec.samples 
-		);
+    LOGI("Try to open %u hz %u bit chan %u %s samples %u",
+          this->spec.freq, SDL_AUDIO_BITSIZE(this->spec.format),
+          this->spec.channels, (test_format & 0x1000) ? "BE" : "LE", this->spec.samples);
 
-	// configure audio source
-	SLDataLocator_AndroidSimpleBufferQueue loc_bufq = { SL_DATALOCATOR_ANDROIDSIMPLEBUFFERQUEUE, 2 };
-//	SLDataLocator_AndroidSimpleBufferQueue loc_bufq = { SL_DATALOCATOR_ANDROIDSIMPLEBUFFERQUEUE, OPENSLES_BUFFERS };
+    // configure audio source
+    SLDataLocator_AndroidSimpleBufferQueue loc_bufq = { SL_DATALOCATOR_ANDROIDSIMPLEBUFFERQUEUE, 2 };
+    // SLDataLocator_AndroidSimpleBufferQueue loc_bufq = { SL_DATALOCATOR_ANDROIDSIMPLEBUFFERQUEUE, OPENSLES_BUFFERS };
 
-	format_pcm.formatType    = SL_DATAFORMAT_PCM;
-	format_pcm.numChannels   = this->spec.channels;
-	format_pcm.samplesPerSec = this->spec.freq * 1000;	/// kilo Hz to milli Hz
-	format_pcm.bitsPerSample = SDL_AUDIO_BITSIZE( this->spec.format );
-	format_pcm.containerSize = SDL_AUDIO_BITSIZE( this->spec.format );
+    format_pcm.formatType    = SL_DATAFORMAT_PCM;
+    format_pcm.numChannels   = this->spec.channels;
+    format_pcm.samplesPerSec = this->spec.freq * 1000;  // / kilo Hz to milli Hz
+    format_pcm.bitsPerSample = SDL_AUDIO_BITSIZE(this->spec.format);
+    format_pcm.containerSize = SDL_AUDIO_BITSIZE(this->spec.format);
 
-	if ( SDL_AUDIO_ISBIGENDIAN( this->spec.format ) )
-		format_pcm.endianness = SL_BYTEORDER_BIGENDIAN;
-	else
-		format_pcm.endianness = SL_BYTEORDER_LITTLEENDIAN;
+    if (SDL_AUDIO_ISBIGENDIAN(this->spec.format)) {
+        format_pcm.endianness = SL_BYTEORDER_BIGENDIAN;
+    } else {
+        format_pcm.endianness = SL_BYTEORDER_LITTLEENDIAN;
+    }
 
 /*
-#define SL_SPEAKER_FRONT_LEFT			((SLuint32) 0x00000001)
-#define SL_SPEAKER_FRONT_RIGHT			((SLuint32) 0x00000002)
-#define SL_SPEAKER_FRONT_CENTER			((SLuint32) 0x00000004)
-#define SL_SPEAKER_LOW_FREQUENCY			((SLuint32) 0x00000008)
-#define SL_SPEAKER_BACK_LEFT			((SLuint32) 0x00000010)
-#define SL_SPEAKER_BACK_RIGHT			((SLuint32) 0x00000020)
-#define SL_SPEAKER_FRONT_LEFT_OF_CENTER	((SLuint32) 0x00000040)
-#define SL_SPEAKER_FRONT_RIGHT_OF_CENTER	((SLuint32) 0x00000080)
-#define SL_SPEAKER_BACK_CENTER			((SLuint32) 0x00000100)
-#define SL_SPEAKER_SIDE_LEFT			((SLuint32) 0x00000200)
-#define SL_SPEAKER_SIDE_RIGHT			((SLuint32) 0x00000400)
-#define SL_SPEAKER_TOP_CENTER			((SLuint32) 0x00000800)
-#define SL_SPEAKER_TOP_FRONT_LEFT		((SLuint32) 0x00001000)
-#define SL_SPEAKER_TOP_FRONT_CENTER		((SLuint32) 0x00002000)
-#define SL_SPEAKER_TOP_FRONT_RIGHT		((SLuint32) 0x00004000)
-#define SL_SPEAKER_TOP_BACK_LEFT			((SLuint32) 0x00008000)
-#define SL_SPEAKER_TOP_BACK_CENTER		((SLuint32) 0x00010000)
-#define SL_SPEAKER_TOP_BACK_RIGHT		((SLuint32) 0x00020000)
+#define SL_SPEAKER_FRONT_LEFT            ((SLuint32) 0x00000001)
+#define SL_SPEAKER_FRONT_RIGHT           ((SLuint32) 0x00000002)
+#define SL_SPEAKER_FRONT_CENTER          ((SLuint32) 0x00000004)
+#define SL_SPEAKER_LOW_FREQUENCY         ((SLuint32) 0x00000008)
+#define SL_SPEAKER_BACK_LEFT             ((SLuint32) 0x00000010)
+#define SL_SPEAKER_BACK_RIGHT            ((SLuint32) 0x00000020)
+#define SL_SPEAKER_FRONT_LEFT_OF_CENTER  ((SLuint32) 0x00000040)
+#define SL_SPEAKER_FRONT_RIGHT_OF_CENTER ((SLuint32) 0x00000080)
+#define SL_SPEAKER_BACK_CENTER           ((SLuint32) 0x00000100)
+#define SL_SPEAKER_SIDE_LEFT             ((SLuint32) 0x00000200)
+#define SL_SPEAKER_SIDE_RIGHT            ((SLuint32) 0x00000400)
+#define SL_SPEAKER_TOP_CENTER            ((SLuint32) 0x00000800)
+#define SL_SPEAKER_TOP_FRONT_LEFT        ((SLuint32) 0x00001000)
+#define SL_SPEAKER_TOP_FRONT_CENTER      ((SLuint32) 0x00002000)
+#define SL_SPEAKER_TOP_FRONT_RIGHT       ((SLuint32) 0x00004000)
+#define SL_SPEAKER_TOP_BACK_LEFT         ((SLuint32) 0x00008000)
+#define SL_SPEAKER_TOP_BACK_CENTER       ((SLuint32) 0x00010000)
+#define SL_SPEAKER_TOP_BACK_RIGHT        ((SLuint32) 0x00020000)
 */
 
-	if ( this->spec.channels == 1 )
-		format_pcm.channelMask = SL_SPEAKER_FRONT_CENTER;
-	else if ( this->spec.channels == 2 )
-		format_pcm.channelMask = SL_SPEAKER_FRONT_LEFT | SL_SPEAKER_FRONT_RIGHT;
-	else if ( this->spec.channels == 3 )
-		format_pcm.channelMask = SL_SPEAKER_FRONT_LEFT | SL_SPEAKER_FRONT_RIGHT | SL_SPEAKER_FRONT_CENTER;
-	else if ( this->spec.channels == 4 )
-		format_pcm.channelMask = SL_SPEAKER_FRONT_LEFT | SL_SPEAKER_FRONT_RIGHT |
-								 SL_SPEAKER_BACK_LEFT  | SL_SPEAKER_BACK_RIGHT;
-	else
-		format_pcm.channelMask = SL_SPEAKER_FRONT_LEFT | SL_SPEAKER_FRONT_RIGHT |
-								 SL_SPEAKER_BACK_LEFT  | SL_SPEAKER_BACK_RIGHT |
-								 SL_SPEAKER_FRONT_CENTER;
-
-	SLDataSource audioSrc = { &loc_bufq, &format_pcm };
-
-	// configure audio sink
-	SLDataLocator_OutputMix loc_outmix = { SL_DATALOCATOR_OUTPUTMIX, outputMixObject };
-	SLDataSink audioSnk = { &loc_outmix, NULL };
-
-    // create audio player
-    const SLInterfaceID ids[2] = { 
-			SL_IID_ANDROIDSIMPLEBUFFERQUEUE,
-			SL_IID_VOLUME 
-			};
+    if (this->spec.channels == 1) {
+        format_pcm.channelMask = SL_SPEAKER_FRONT_CENTER;
+    } else if (this->spec.channels == 2) {
+        format_pcm.channelMask = SL_SPEAKER_FRONT_LEFT | SL_SPEAKER_FRONT_RIGHT;
+    } else if (this->spec.channels == 3) {
+        format_pcm.channelMask = SL_SPEAKER_FRONT_LEFT | SL_SPEAKER_FRONT_RIGHT | SL_SPEAKER_FRONT_CENTER;
+    } else if (this->spec.channels == 4) {
+        format_pcm.channelMask = SL_SPEAKER_FRONT_LEFT | SL_SPEAKER_FRONT_RIGHT |
+              SL_SPEAKER_BACK_LEFT | SL_SPEAKER_BACK_RIGHT;
+    } else {
+        format_pcm.channelMask = SL_SPEAKER_FRONT_LEFT | SL_SPEAKER_FRONT_RIGHT |
+              SL_SPEAKER_BACK_LEFT | SL_SPEAKER_BACK_RIGHT | SL_SPEAKER_FRONT_CENTER;
+    }
 
-    const SLboolean req[2] = { 
-			SL_BOOLEAN_TRUE, 
-			SL_BOOLEAN_FALSE,
-			};
+    SLDataSource audioSrc = { &loc_bufq, &format_pcm };
 
-	result = (*engineEngine)->CreateAudioPlayer( engineEngine, &bqPlayerObject, &audioSrc, &audioSnk,
-				2, ids, req );
-	if ( SL_RESULT_SUCCESS != result ) {
+    // configure audio sink
+    SLDataLocator_OutputMix loc_outmix = { SL_DATALOCATOR_OUTPUTMIX, outputMixObject };
+    SLDataSink audioSnk = { &loc_outmix, NULL };
 
-		LOGE( "CreateAudioPlayer failed" );
-		goto failed;
-	}
+    // create audio player
+    const SLInterfaceID ids[2] = {
+        SL_IID_ANDROIDSIMPLEBUFFERQUEUE,
+        SL_IID_VOLUME
+    };
+
+    const SLboolean req[2] = {
+        SL_BOOLEAN_TRUE,
+        SL_BOOLEAN_FALSE,
+    };
+
+    result = (*engineEngine)->CreateAudioPlayer(engineEngine, &bqPlayerObject, &audioSrc, &audioSnk, 2, ids, req);
+    if (SL_RESULT_SUCCESS != result) {
+        LOGE("CreateAudioPlayer failed");
+        goto failed;
+    }
 
     // realize the player
-	result = (*bqPlayerObject)->Realize( bqPlayerObject, SL_BOOLEAN_FALSE );
-	if ( SL_RESULT_SUCCESS != result ) {
-
-		LOGE( "RealizeAudioPlayer failed" );
-		goto failed;
-	}
-
-	// get the play interface
-	result = (*bqPlayerObject)->GetInterface( bqPlayerObject, SL_IID_PLAY, &bqPlayerPlay );
-	if ( SL_RESULT_SUCCESS != result ) {
+    result = (*bqPlayerObject)->Realize(bqPlayerObject, SL_BOOLEAN_FALSE);
+    if (SL_RESULT_SUCCESS != result) {
+        LOGE("RealizeAudioPlayer failed");
+        goto failed;
+    }
 
-		LOGE( "SL_IID_PLAY interface get failed" );
-		goto failed;
-	}
+    // get the play interface
+    result = (*bqPlayerObject)->GetInterface(bqPlayerObject, SL_IID_PLAY, &bqPlayerPlay);
+    if (SL_RESULT_SUCCESS != result) {
+        LOGE("SL_IID_PLAY interface get failed");
+        goto failed;
+    }
 
     // get the buffer queue interface
-	result = (*bqPlayerObject)->GetInterface( bqPlayerObject, SL_IID_ANDROIDSIMPLEBUFFERQUEUE, &bqPlayerBufferQueue );
-	if ( SL_RESULT_SUCCESS != result ) {
-
-		LOGE( "SL_IID_BUFFERQUEUE interface get failed" );
-		goto failed;
-	}
-
-	// register callback on the buffer queue
-	result = (*bqPlayerBufferQueue)->RegisterCallback( bqPlayerBufferQueue, bqPlayerCallback, NULL );
-	if ( SL_RESULT_SUCCESS != result ) {
+    result = (*bqPlayerObject)->GetInterface(bqPlayerObject, SL_IID_ANDROIDSIMPLEBUFFERQUEUE, &bqPlayerBufferQueue);
+    if (SL_RESULT_SUCCESS != result) {
+        LOGE("SL_IID_BUFFERQUEUE interface get failed");
+        goto failed;
+    }
 
-		LOGE( "RegisterCallback failed" );
-		goto failed;
-	}
+    // register callback on the buffer queue
+    result = (*bqPlayerBufferQueue)->RegisterCallback(bqPlayerBufferQueue, bqPlayerCallback, NULL);
+    if (SL_RESULT_SUCCESS != result) {
+        LOGE("RegisterCallback failed");
+        goto failed;
+    }
 
 #if 0
     // get the effect send interface
-	result = (*bqPlayerObject)->GetInterface( bqPlayerObject, SL_IID_EFFECTSEND, &bqPlayerEffectSend );
-	if ( SL_RESULT_SUCCESS != result ) {
+    result = (*bqPlayerObject)->GetInterface(bqPlayerObject, SL_IID_EFFECTSEND, &bqPlayerEffectSend);
+    if (SL_RESULT_SUCCESS != result)
+    {
 
-		LOGE( "SL_IID_EFFECTSEND interface get failed" );
-		goto failed;
-	}
+        LOGE("SL_IID_EFFECTSEND interface get failed");
+        goto failed;
+    }
 #endif
 
 #if 0   // mute/solo is not supported for sources that are known to be mono, as this is
     // get the mute/solo interface
     result = (*bqPlayerObject)->GetInterface(bqPlayerObject, SL_IID_MUTESOLO, &bqPlayerMuteSolo);
     assert(SL_RESULT_SUCCESS == result);
-    (void)result;
+    (void) result;
 #endif
 
     // get the volume interface
-	result = (*bqPlayerObject)->GetInterface( bqPlayerObject, SL_IID_VOLUME, &bqPlayerVolume );
-	if ( SL_RESULT_SUCCESS != result ) {
-
-		LOGE( "SL_IID_VOLUME interface get failed" );
-//		goto failed;
-	}
-
-	// set the player's state to playing
-	result = (*bqPlayerPlay)->SetPlayState( bqPlayerPlay, SL_PLAYSTATE_PLAYING );
-	if ( SL_RESULT_SUCCESS != result ) {
+    result = (*bqPlayerObject)->GetInterface(bqPlayerObject, SL_IID_VOLUME, &bqPlayerVolume);
+    if (SL_RESULT_SUCCESS != result) {
+        LOGE("SL_IID_VOLUME interface get failed");
+        // goto failed;
+    }
 
-		LOGE( "Play set state failed" );
-		goto failed;
-	}
+    // set the player's state to playing
+    result = (*bqPlayerPlay)->SetPlayState(bqPlayerPlay, SL_PLAYSTATE_PLAYING);
+    if (SL_RESULT_SUCCESS != result) {
+        LOGE("Play set state failed");
+        goto failed;
+    }
 
     /* Create the audio buffer semaphore */
-	playsem = SDL_CreateSemaphore( NUM_BUFFERS - 1 );
-	if ( !playsem ) {
-
-		LOGE( "cannot create Semaphore!" );
-		goto failed;
-	}
-
-	/* Create the sound buffers */
-	mixbuff = (Uint8 *) SDL_malloc( NUM_BUFFERS * this->spec.size );
-	if ( mixbuff == NULL) {
+    playsem = SDL_CreateSemaphore(NUM_BUFFERS - 1);
+    if (!playsem) {
+        LOGE("cannot create Semaphore!");
+        goto failed;
+    }
 
-		LOGE( "mixbuffer allocate - out of memory" );
-		goto failed;
-	}
+    /* Create the sound buffers */
+    mixbuff = (Uint8 *) SDL_malloc(NUM_BUFFERS * this->spec.size);
+    if (mixbuff == NULL) {
+        LOGE("mixbuffer allocate - out of memory");
+        goto failed;
+    }
 
-	for ( i = 0; i < NUM_BUFFERS; i ++ )
-		pmixbuff[i] = mixbuff + i * this->spec.size;
+    for (i = 0; i < NUM_BUFFERS; i++) {
+        pmixbuff[i] = mixbuff + i * this->spec.size;
+    }
 
     return 0;
 
-failed:;
+failed:
 
-	openslES_DestroyPCMPlayer( );
+    openslES_DestroyPCMPlayer();
 
-	return SDL_SetError( "Open device failed!" );
+    return SDL_SetError("Open device failed!");
 }
 
-static void openslES_DestroyPCMPlayer( void )
+static void
+openslES_DestroyPCMPlayer(void)
 {
-	// destroy buffer queue audio player object, and invalidate all associated interfaces
-	if ( bqPlayerObject != NULL ) {
+    // destroy buffer queue audio player object, and invalidate all associated interfaces
+    if (bqPlayerObject != NULL) {
 
-        (*bqPlayerObject)->Destroy( bqPlayerObject );
+        (*bqPlayerObject)->Destroy(bqPlayerObject);
 
-        bqPlayerObject		= NULL;
-        bqPlayerPlay		= NULL;
+        bqPlayerObject = NULL;
+        bqPlayerPlay = NULL;
         bqPlayerBufferQueue = NULL;
-//        bqPlayerEffectSend	= NULL;
-        bqPlayerMuteSolo	= NULL;
-        bqPlayerVolume		= NULL;
+        // bqPlayerEffectSend = NULL;
+        bqPlayerMuteSolo = NULL;
+        bqPlayerVolume = NULL;
     }
 
-	if ( playsem ) {
-
-		SDL_DestroySemaphore( playsem );
-		playsem = NULL;
-	}
+    if (playsem) {
+        SDL_DestroySemaphore(playsem);
+        playsem = NULL;
+    }
 
-	if ( mixbuff )
-		SDL_free( mixbuff );
+    if (mixbuff) {
+        SDL_free(mixbuff);
+    }
 
-	return;
+    return;
 }
 
-static int openslES_OpenDevice( _THIS, void *handle, const char *devname, int iscapture )
+static int
+openslES_OpenDevice(_THIS, void *handle, const char *devname, int iscapture)
 {
-	if ( iscapture ) {
-		LOGI( "openslES_OpenDevice( ) %s for capture", devname );
-		return openslES_CreatePCMRecorder( this );
-	}
-
-	LOGI( "openslES_OpenDevice( ) %s for playing", devname );
-
-	return openslES_CreatePCMPlayer( this );
+    if (iscapture) {
+        LOGI("openslES_OpenDevice( ) %s for capture", devname);
+        return openslES_CreatePCMRecorder(this);
+    } else {
+        LOGI("openslES_OpenDevice( ) %s for playing", devname);
+        return openslES_CreatePCMPlayer(this);
+    }
 }
 
-static void openslES_CloseDevice( _THIS )
+static void
+openslES_CloseDevice(_THIS)
 {
-	if ( this->iscapture ) {
-		LOGI( "openslES_CloseDevice( ) for capture" );
-		return openslES_DestroyPCMRecorder( );
-	}
-
-	LOGI( "openslES_CloseDevice( ) for playing" );
-	openslES_DestroyPCMPlayer( );
+    if (this->iscapture) {
+        LOGI("openslES_CloseDevice( ) for capture");
+        openslES_DestroyPCMRecorder();
+    } else {
+        LOGI("openslES_CloseDevice( ) for playing");
+        openslES_DestroyPCMPlayer();
+    }
 
-	return;
+    return;
 }
 
-static void openslES_WaitDevice( _THIS )
+static void
+openslES_WaitDevice(_THIS)
 {
-	LOGI( "openslES_WaitDevice( )" );
+    LOGI("openslES_WaitDevice( )");
 
     /* Wait for an audio chunk to finish */
-//    WaitForSingleObject(this->hidden->audio_sem, INFINITE);
-	SDL_SemWait( playsem );
+    // WaitForSingleObject(this->hidden->audio_sem, INFINITE);
+    SDL_SemWait(playsem);
 
-	return;
+    return;
 }
 
 ///           n   playn sem
@@ -507,65 +506,71 @@ static void openslES_WaitDevice( _THIS )
 // getbuf     1   0     0
 // fill buff  1   0     0
 // play       0   0     0
-// wait       
+// wait
 //
 // okay..
 
-
-static Uint8 *openslES_GetDeviceBuf( _THIS )
+static Uint8 *
+openslES_GetDeviceBuf(_THIS)
 {
-	LOGI( "openslES_GetDeviceBuf( )" );
-
+    LOGI("openslES_GetDeviceBuf( )");
     return pmixbuff[next_buffer];
 }
 
-static void openslES_PlayDevice( _THIS )
+static void
+openslES_PlayDevice(_THIS)
 {
-	SLresult result;
+    SLresult result;
 
-	LOGI( "======openslES_PlayDevice( )======" );
+    LOGI("======openslES_PlayDevice( )======");
     /* Queue it up */
 
-	result = (*bqPlayerBufferQueue)->Enqueue( bqPlayerBufferQueue, pmixbuff[next_buffer], this->spec.size );
-	if ( SL_RESULT_SUCCESS != result ) { 
-		// just puk here
-		// next !
-	}
+    result = (*bqPlayerBufferQueue)->Enqueue(bqPlayerBufferQueue, pmixbuff[next_buffer], this->spec.size);
+    if (SL_RESULT_SUCCESS != result) {
+        // just puk here
+        // next !
+    }
 
-	next_buffer ++;
-	if ( next_buffer >= NUM_BUFFERS ) next_buffer = 0;
+    next_buffer++;
+    if (next_buffer >= NUM_BUFFERS) {
+        next_buffer = 0;
+    }
 
-	return;
+    return;
 }
 
-static int openslES_Init( SDL_AudioDriverImpl * impl )
+static int
+openslES_Init(SDL_AudioDriverImpl * impl)
 {
-	LOGI( "openslES_Init() called" );
+    LOGI("openslES_Init() called");
 
-	if ( !openslES_CreateEngine() ) return 0;
+    if (!openslES_CreateEngine()) {
+        return 0;
+    }
 
-	LOGI( "openslES_Init() - set pointers" );
+    LOGI("openslES_Init() - set pointers");
 
-	/* Set the function pointers */
-//	impl->DetectDevices = openslES_DetectDevices;
-	impl->OpenDevice    = openslES_OpenDevice;
-   impl->PlayDevice	= openslES_PlayDevice;
-   impl->GetDeviceBuf	= openslES_GetDeviceBuf;
-	impl->Deinitialize  = openslES_DestroyEngine;
-   impl->WaitDevice	= openslES_WaitDevice;
+    /* Set the function pointers */
+    // impl->DetectDevices = openslES_DetectDevices;
+    impl->OpenDevice    = openslES_OpenDevice;
+    impl->PlayDevice    = openslES_PlayDevice;
+    impl->GetDeviceBuf  = openslES_GetDeviceBuf;
+    impl->Deinitialize  = openslES_DestroyEngine;
+    impl->WaitDevice    = openslES_WaitDevice;
 
-	/* and the capabilities */
-	impl->HasCaptureSupport = 0; /* TODO */
-	impl->OnlyHasDefaultOutputDevice = 1;
-//	impl->OnlyHasDefaultInputDevice  = 1;
+    /* and the capabilities */
+    impl->HasCaptureSupport             = 0;        /* TODO */
+    impl->OnlyHasDefaultOutputDevice    = 1;
+    // impl->OnlyHasDefaultInputDevice  = 1;
 
-	LOGI( "openslES_Init() - succes" );
+    LOGI("openslES_Init() - succes");
 
-	return 1;   /* this audio target is available. */
+    /* this audio target is available. */
+    return 1;
 }
 
 AudioBootStrap openslES_bootstrap = {
-	"openslES", "opensl ES audio driver", openslES_Init, 0
+    "openslES", "opensl ES audio driver", openslES_Init, 0
 };
 
 #endif /* SDL_AUDIO_DRIVER_OPENSLES */