Christoph Mallon: Remove pointless if (x) before SDL_FreeSurface(x)
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439
diff --git a/src/events/SDL_mouse.c b/src/events/SDL_mouse.c
index dd6049a..e322437 100644
--- a/src/events/SDL_mouse.c
+++ b/src/events/SDL_mouse.c
@@ -571,9 +571,7 @@ SDL_CreateColorCursor(SDL_Surface *surface, int hot_x, int hot_y)
mouse->cursors = cursor;
}
- if (temp) {
- SDL_FreeSurface(temp);
- }
+ SDL_FreeSurface(temp);
return cursor;
}
diff --git a/src/render/SDL_yuv_sw.c b/src/render/SDL_yuv_sw.c
index 9604783..2c7e724 100644
--- a/src/render/SDL_yuv_sw.c
+++ b/src/render/SDL_yuv_sw.c
@@ -1012,10 +1012,8 @@ SDL_SW_SetupYUVDisplay(SDL_SW_YUVTexture * swdata, Uint32 target_format)
break;
}
- if (swdata->display) {
- SDL_FreeSurface(swdata->display);
- swdata->display = NULL;
- }
+ SDL_FreeSurface(swdata->display);
+ swdata->display = NULL;
return 0;
}
@@ -1338,12 +1336,8 @@ SDL_SW_DestroyYUVTexture(SDL_SW_YUVTexture * swdata)
SDL_free(swdata->pixels);
SDL_free(swdata->colortab);
SDL_free(swdata->rgb_2_pix);
- if (swdata->stretch) {
- SDL_FreeSurface(swdata->stretch);
- }
- if (swdata->display) {
- SDL_FreeSurface(swdata->display);
- }
+ SDL_FreeSurface(swdata->stretch);
+ SDL_FreeSurface(swdata->display);
SDL_free(swdata);
}
}
diff --git a/src/video/SDL_bmp.c b/src/video/SDL_bmp.c
index 108f0b3..9244b28 100644
--- a/src/video/SDL_bmp.c
+++ b/src/video/SDL_bmp.c
@@ -398,9 +398,7 @@ SDL_LoadBMP_RW(SDL_RWops * src, int freesrc)
if (src) {
SDL_RWseek(src, fp_offset, RW_SEEK_SET);
}
- if (surface) {
- SDL_FreeSurface(surface);
- }
+ SDL_FreeSurface(surface);
surface = NULL;
}
if (freesrc && src) {
diff --git a/src/video/SDL_video.c b/src/video/SDL_video.c
index dcf0494..53de057 100644
--- a/src/video/SDL_video.c
+++ b/src/video/SDL_video.c
@@ -1432,9 +1432,7 @@ SDL_SetWindowIcon(SDL_Window * window, SDL_Surface * icon)
return;
}
- if (window->icon) {
- SDL_FreeSurface(window->icon);
- }
+ SDL_FreeSurface(window->icon);
/* Convert the icon into ARGB8888 */
window->icon = SDL_ConvertSurfaceFormat(icon, SDL_PIXELFORMAT_ARGB8888, 0);
@@ -2183,9 +2181,7 @@ SDL_DestroyWindow(SDL_Window * window)
/* Free memory associated with the window */
SDL_free(window->title);
- if (window->icon) {
- SDL_FreeSurface(window->icon);
- }
+ SDL_FreeSurface(window->icon);
SDL_free(window->gamma);
while (window->data) {
SDL_WindowUserData *data = window->data;
diff --git a/src/video/directfb/SDL_DirectFB_window.c b/src/video/directfb/SDL_DirectFB_window.c
index 74c958a..e373d4b 100644
--- a/src/video/directfb/SDL_DirectFB_window.c
+++ b/src/video/directfb/SDL_DirectFB_window.c
@@ -237,8 +237,7 @@ DirectFB_SetWindowIcon(_THIS, SDL_Window * window, SDL_Surface * icon)
}
return;
error:
- if (surface)
- SDL_FreeSurface(surface);
+ SDL_FreeSurface(surface);
SDL_DFB_RELEASE(windata->icon);
return;
}
diff --git a/src/video/dummy/SDL_nullframebuffer.c b/src/video/dummy/SDL_nullframebuffer.c
index f390491..f18ceea 100644
--- a/src/video/dummy/SDL_nullframebuffer.c
+++ b/src/video/dummy/SDL_nullframebuffer.c
@@ -38,9 +38,7 @@ int SDL_DUMMY_CreateWindowFramebuffer(_THIS, SDL_Window * window, Uint32 * forma
/* Free the old framebuffer surface */
surface = (SDL_Surface *) SDL_GetWindowData(window, DUMMY_SURFACE);
- if (surface) {
- SDL_FreeSurface(surface);
- }
+ SDL_FreeSurface(surface);
/* Create a new one */
SDL_PixelFormatEnumToMasks(surface_format, &bpp, &Rmask, &Gmask, &Bmask, &Amask);
@@ -83,9 +81,7 @@ void SDL_DUMMY_DestroyWindowFramebuffer(_THIS, SDL_Window * window)
SDL_Surface *surface;
surface = (SDL_Surface *) SDL_SetWindowData(window, DUMMY_SURFACE, NULL);
- if (surface) {
- SDL_FreeSurface(surface);
- }
+ SDL_FreeSurface(surface);
}
#endif /* SDL_VIDEO_DRIVER_DUMMY */
diff --git a/test/testautomation_render.c b/test/testautomation_render.c
index 858679d..e380181 100644
--- a/test/testautomation_render.c
+++ b/test/testautomation_render.c
@@ -190,10 +190,8 @@ int render_testPrimitives (void *arg)
_compare(referenceSurface, ALLOWABLE_ERROR_OPAQUE );
/* Clean up. */
- if (referenceSurface != NULL) {
- SDL_FreeSurface(referenceSurface);
- referenceSurface = NULL;
- }
+ SDL_FreeSurface(referenceSurface);
+ referenceSurface = NULL;
return TEST_COMPLETED;
}
@@ -333,10 +331,8 @@ int render_testPrimitivesBlend (void *arg)
_compare(referenceSurface, ALLOWABLE_ERROR_BLENDED );
/* Clean up. */
- if (referenceSurface != NULL) {
- SDL_FreeSurface(referenceSurface);
- referenceSurface = NULL;
- }
+ SDL_FreeSurface(referenceSurface);
+ referenceSurface = NULL;
return TEST_COMPLETED;
}
@@ -400,10 +396,8 @@ render_testBlit(void *arg)
/* Clean up. */
SDL_DestroyTexture( tface );
- if (referenceSurface != NULL) {
- SDL_FreeSurface(referenceSurface);
- referenceSurface = NULL;
- }
+ SDL_FreeSurface(referenceSurface);
+ referenceSurface = NULL;
return TEST_COMPLETED;
}
@@ -470,10 +464,8 @@ render_testBlitColor (void *arg)
/* Clean up. */
SDL_DestroyTexture( tface );
- if (referenceSurface != NULL) {
- SDL_FreeSurface(referenceSurface);
- referenceSurface = NULL;
- }
+ SDL_FreeSurface(referenceSurface);
+ referenceSurface = NULL;
return TEST_COMPLETED;
}
@@ -543,10 +535,8 @@ render_testBlitAlpha (void *arg)
/* Clean up. */
SDL_DestroyTexture( tface );
- if (referenceSurface != NULL) {
- SDL_FreeSurface(referenceSurface);
- referenceSurface = NULL;
- }
+ SDL_FreeSurface(referenceSurface);
+ referenceSurface = NULL;
return TEST_COMPLETED;
}
@@ -655,37 +645,29 @@ render_testBlitBlend (void *arg)
_testBlitBlendMode( tface, SDL_BLENDMODE_NONE );
referenceSurface = SDLTest_ImageBlitBlendNone();
_compare(referenceSurface, ALLOWABLE_ERROR_OPAQUE );
- if (referenceSurface != NULL) {
- SDL_FreeSurface(referenceSurface);
- referenceSurface = NULL;
- }
+ SDL_FreeSurface(referenceSurface);
+ referenceSurface = NULL;
/* Test Blend. */
_testBlitBlendMode( tface, SDL_BLENDMODE_BLEND );
referenceSurface = SDLTest_ImageBlitBlend();
_compare(referenceSurface, ALLOWABLE_ERROR_BLENDED );
- if (referenceSurface != NULL) {
- SDL_FreeSurface(referenceSurface);
- referenceSurface = NULL;
- }
+ SDL_FreeSurface(referenceSurface);
+ referenceSurface = NULL;
/* Test Add. */
_testBlitBlendMode( tface, SDL_BLENDMODE_ADD );
referenceSurface = SDLTest_ImageBlitBlendAdd();
_compare(referenceSurface, ALLOWABLE_ERROR_BLENDED );
- if (referenceSurface != NULL) {
- SDL_FreeSurface(referenceSurface);
- referenceSurface = NULL;
- }
+ SDL_FreeSurface(referenceSurface);
+ referenceSurface = NULL;
/* Test Mod. */
_testBlitBlendMode( tface, SDL_BLENDMODE_MOD);
referenceSurface = SDLTest_ImageBlitBlendMod();
_compare(referenceSurface, ALLOWABLE_ERROR_BLENDED );
- if (referenceSurface != NULL) {
- SDL_FreeSurface(referenceSurface);
- referenceSurface = NULL;
- }
+ SDL_FreeSurface(referenceSurface);
+ referenceSurface = NULL;
/* Clear surface. */
_clearScreen();
@@ -733,10 +715,8 @@ render_testBlitBlend (void *arg)
/* Check to see if final image matches. */
referenceSurface = SDLTest_ImageBlitBlendAll();
_compare(referenceSurface, ALLOWABLE_ERROR_BLENDED);
- if (referenceSurface != NULL) {
- SDL_FreeSurface(referenceSurface);
- referenceSurface = NULL;
- }
+ SDL_FreeSurface(referenceSurface);
+ referenceSurface = NULL;
return TEST_COMPLETED;
}
@@ -996,9 +976,7 @@ _compare(SDL_Surface *referenceSurface, int allowable_error)
/* Clean up. */
SDL_free(pixels);
- if (testSurface != NULL) {
- SDL_FreeSurface(testSurface);
- }
+ SDL_FreeSurface(testSurface);
}
/**
diff --git a/test/testautomation_surface.c b/test/testautomation_surface.c
index 97cc81d..d814918 100644
--- a/test/testautomation_surface.c
+++ b/test/testautomation_surface.c
@@ -63,14 +63,10 @@ _surfaceSetUp(void *arg)
void
_surfaceTearDown(void *arg)
{
- if (referenceSurface != NULL) {
- SDL_FreeSurface(referenceSurface);
- referenceSurface = NULL;
- }
- if (testSurface != NULL) {
- SDL_FreeSurface(testSurface);
- testSurface = NULL;
- }
+ SDL_FreeSurface(referenceSurface);
+ referenceSurface = NULL;
+ SDL_FreeSurface(testSurface);
+ testSurface = NULL;
}
/**
@@ -193,10 +189,8 @@ void _testBlitBlendMode(int mode)
SDLTest_AssertCheck(checkFailCount4 == 0, "Validate results from calls to SDL_SetSurfaceBlendMode, expected: 0, got: %i", checkFailCount4);
/* Clean up */
- if (face != NULL) {
- SDL_FreeSurface(face);
- face = NULL;
- }
+ SDL_FreeSurface(face);
+ face = NULL;
}
/* Helper to check that a file exists */
@@ -250,14 +244,10 @@ surface_testSaveLoadBitmap(void *arg)
unlink(sampleFilename);
/* Clean up */
- if (face != NULL) {
SDL_FreeSurface(face);
face = NULL;
- }
- if (rface != NULL) {
SDL_FreeSurface(rface);
rface = NULL;
- }
return TEST_COMPLETED;
}
@@ -294,14 +284,10 @@ surface_testSurfaceConversion(void *arg)
SDLTest_AssertCheck(ret == 0, "Validate result from SDLTest_CompareSurfaces, expected: 0, got: %i", ret);
/* Clean up. */
- if (face != NULL) {
- SDL_FreeSurface( face );
- face = NULL;
- }
- if (rface != NULL) {
- SDL_FreeSurface( rface );
- rface = NULL;
- }
+ SDL_FreeSurface(face);
+ face = NULL;
+ SDL_FreeSurface(rface);
+ rface = NULL;
return TEST_COMPLETED;
}
@@ -427,9 +413,7 @@ surface_testBlit(void *arg)
SDLTest_AssertCheck(ret == 0, "Validate result from SDLTest_CompareSurfaces, expected: 0, got: %i", ret);
/* Clean up. */
- if (compareSurface != NULL) {
- SDL_FreeSurface( compareSurface );
- }
+ SDL_FreeSurface(compareSurface);
return TEST_COMPLETED;
}
@@ -452,9 +436,7 @@ surface_testBlitColorMod(void *arg)
SDLTest_AssertCheck(ret == 0, "Validate result from SDLTest_CompareSurfaces, expected: 0, got: %i", ret);
/* Clean up. */
- if (compareSurface != NULL) {
- SDL_FreeSurface( compareSurface );
- }
+ SDL_FreeSurface(compareSurface);
return TEST_COMPLETED;
}
@@ -477,9 +459,7 @@ surface_testBlitAlphaMod(void *arg)
SDLTest_AssertCheck(ret == 0, "Validate result from SDLTest_CompareSurfaces, expected: 0, got: %i", ret);
/* Clean up. */
- if (compareSurface != NULL) {
- SDL_FreeSurface( compareSurface );
- }
+ SDL_FreeSurface(compareSurface);
return TEST_COMPLETED;
}
@@ -503,9 +483,7 @@ surface_testBlitBlendNone(void *arg)
SDLTest_AssertCheck(ret == 0, "Validate result from SDLTest_CompareSurfaces, expected: 0, got: %i", ret);
/* Clean up. */
- if (compareSurface != NULL) {
- SDL_FreeSurface( compareSurface );
- }
+ SDL_FreeSurface(compareSurface);
return TEST_COMPLETED;
}
@@ -528,9 +506,7 @@ surface_testBlitBlendBlend(void *arg)
SDLTest_AssertCheck(ret == 0, "Validate result from SDLTest_CompareSurfaces, expected: 0, got: %i", ret);
/* Clean up. */
- if (compareSurface != NULL) {
- SDL_FreeSurface( compareSurface );
- }
+ SDL_FreeSurface(compareSurface);
return TEST_COMPLETED;
}
@@ -553,9 +529,7 @@ surface_testBlitBlendAdd(void *arg)
SDLTest_AssertCheck(ret == 0, "Validate result from SDLTest_CompareSurfaces, expected: 0, got: %i", ret);
/* Clean up. */
- if (compareSurface != NULL) {
- SDL_FreeSurface( compareSurface );
- }
+ SDL_FreeSurface(compareSurface);
return TEST_COMPLETED;
}
@@ -578,9 +552,7 @@ surface_testBlitBlendMod(void *arg)
SDLTest_AssertCheck(ret == 0, "Validate result from SDLTest_CompareSurfaces, expected: 0, got: %i", ret);
/* Clean up. */
- if (compareSurface != NULL) {
- SDL_FreeSurface( compareSurface );
- }
+ SDL_FreeSurface(compareSurface);
return TEST_COMPLETED;
}
@@ -603,9 +575,7 @@ surface_testBlitBlendLoop(void *arg) {
SDLTest_AssertCheck(ret == 0, "Validate result from SDLTest_CompareSurfaces, expected: 0, got: %i", ret);
/* Clean up. */
- if (compareSurface != NULL) {
- SDL_FreeSurface(compareSurface);
- }
+ SDL_FreeSurface(compareSurface);
return TEST_COMPLETED;
diff --git a/test/testshape.c b/test/testshape.c
index 785ba1a..c202d8e 100644
--- a/test/testshape.c
+++ b/test/testshape.c
@@ -90,8 +90,7 @@ int main(int argc,char** argv)
if(pictures[i].surface == NULL) {
j = 0;
for(j=0;j<num_pictures;j++)
- if(pictures[j].surface != NULL)
- SDL_FreeSurface(pictures[j].surface);
+ SDL_FreeSurface(pictures[j].surface);
SDL_free(pictures);
SDL_VideoQuit();
SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, "Could not load surface from named bitmap file.");