Commit 413a2306bc6264eae4e8b1209f9a33037dfe69c8

meyraud705 2021-04-04T10:47:06

NULL passed to strcmp in Wayland_ShowMessageBox

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
diff --git a/src/video/wayland/SDL_waylandmessagebox.c b/src/video/wayland/SDL_waylandmessagebox.c
index 50869a5..56388b9 100644
--- a/src/video/wayland/SDL_waylandmessagebox.c
+++ b/src/video/wayland/SDL_waylandmessagebox.c
@@ -150,9 +150,11 @@ Wayland_ShowMessageBox(const SDL_MessageBoxData *messageboxdata, int *buttonid)
 
     /* Check which button got pressed */
     for (i = 0; i < messageboxdata->numbuttons; i += 1) {
-        if (SDL_strcmp(output, messageboxdata->buttons[i].text) == 0) {
-            *buttonid = i;
-            break;
+        if (messageboxdata->buttons[i].text != NULL) {
+            if (SDL_strcmp(output, messageboxdata->buttons[i].text) == 0) {
+                *buttonid = i;
+                break;
+            }
         }
     }