Commit 4d9bef604ab7967d18c873c550aa1bf1100eda21
2022-03-19T09:44:09
SDL_Rect: minor code cleanups.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294
diff --git a/src/video/SDL_rect.c b/src/video/SDL_rect.c
index dd2c7bc..29e1af8 100644
--- a/src/video/SDL_rect.c
+++ b/src/video/SDL_rect.c
@@ -31,16 +31,11 @@ SDL_HasIntersection(const SDL_Rect * A, const SDL_Rect * B)
if (!A) {
SDL_InvalidParamError("A");
return SDL_FALSE;
- }
-
- if (!B) {
+ } else if (!B) {
SDL_InvalidParamError("B");
return SDL_FALSE;
- }
-
- /* Special cases for empty rects */
- if (SDL_RectEmpty(A) || SDL_RectEmpty(B)) {
- return SDL_FALSE;
+ } else if (SDL_RectEmpty(A) || SDL_RectEmpty(B)) {
+ return SDL_FALSE; /* Special cases for empty rects */
}
/* Horizontal intersection */
@@ -48,25 +43,29 @@ SDL_HasIntersection(const SDL_Rect * A, const SDL_Rect * B)
Amax = Amin + A->w;
Bmin = B->x;
Bmax = Bmin + B->w;
- if (Bmin > Amin)
+ if (Bmin > Amin) {
Amin = Bmin;
- if (Bmax < Amax)
+ }
+ if (Bmax < Amax) {
Amax = Bmax;
- if (Amax <= Amin)
+ }
+ if (Amax <= Amin) {
return SDL_FALSE;
-
+ }
/* Vertical intersection */
Amin = A->y;
Amax = Amin + A->h;
Bmin = B->y;
Bmax = Bmin + B->h;
- if (Bmin > Amin)
+ if (Bmin > Amin) {
Amin = Bmin;
- if (Bmax < Amax)
+ }
+ if (Bmax < Amax) {
Amax = Bmax;
- if (Amax <= Amin)
+ }
+ if (Amax <= Amin) {
return SDL_FALSE;
-
+ }
return SDL_TRUE;
}
@@ -78,20 +77,13 @@ SDL_IntersectRect(const SDL_Rect * A, const SDL_Rect * B, SDL_Rect * result)
if (!A) {
SDL_InvalidParamError("A");
return SDL_FALSE;
- }
-
- if (!B) {
+ } else if (!B) {
SDL_InvalidParamError("B");
return SDL_FALSE;
- }
-
- if (!result) {
+ } else if (!result) {
SDL_InvalidParamError("result");
return SDL_FALSE;
- }
-
- /* Special cases for empty rects */
- if (SDL_RectEmpty(A) || SDL_RectEmpty(B)) {
+ } else if (SDL_RectEmpty(A) || SDL_RectEmpty(B)) { /* Special cases for empty rects */
result->w = 0;
result->h = 0;
return SDL_FALSE;
@@ -102,11 +94,13 @@ SDL_IntersectRect(const SDL_Rect * A, const SDL_Rect * B, SDL_Rect * result)
Amax = Amin + A->w;
Bmin = B->x;
Bmax = Bmin + B->w;
- if (Bmin > Amin)
+ if (Bmin > Amin) {
Amin = Bmin;
+ }
result->x = Amin;
- if (Bmax < Amax)
+ if (Bmax < Amax) {
Amax = Bmax;
+ }
result->w = Amax - Amin;
/* Vertical intersection */
@@ -114,11 +108,13 @@ SDL_IntersectRect(const SDL_Rect * A, const SDL_Rect * B, SDL_Rect * result)
Amax = Amin + A->h;
Bmin = B->y;
Bmax = Bmin + B->h;
- if (Bmin > Amin)
+ if (Bmin > Amin) {
Amin = Bmin;
+ }
result->y = Amin;
- if (Bmax < Amax)
+ if (Bmax < Amax) {
Amax = Bmax;
+ }
result->h = Amax - Amin;
return !SDL_RectEmpty(result);
@@ -132,35 +128,22 @@ SDL_UnionRect(const SDL_Rect * A, const SDL_Rect * B, SDL_Rect * result)
if (!A) {
SDL_InvalidParamError("A");
return;
- }
-
- if (!B) {
+ } else if (!B) {
SDL_InvalidParamError("B");
return;
- }
-
- if (!result) {
+ } else if (!result) {
SDL_InvalidParamError("result");
return;
- }
-
- /* Special cases for empty Rects */
- if (SDL_RectEmpty(A)) {
- if (SDL_RectEmpty(B)) {
- /* A and B empty */
- SDL_zerop(result);
- return;
- } else {
- /* A empty, B not empty */
- *result = *B;
- return;
- }
- } else {
- if (SDL_RectEmpty(B)) {
- /* A not empty, B empty */
+ } else if (SDL_RectEmpty(A)) { /* Special cases for empty Rects */
+ if (SDL_RectEmpty(B)) { /* A and B empty */
+ SDL_zerop(result);
+ } else { /* A empty, B not empty */
+ *result = *B;
+ }
+ return;
+ } else if (SDL_RectEmpty(B)) { /* A not empty, B empty */
*result = *A;
return;
- }
}
/* Horizontal union */
@@ -168,11 +151,13 @@ SDL_UnionRect(const SDL_Rect * A, const SDL_Rect * B, SDL_Rect * result)
Amax = Amin + A->w;
Bmin = B->x;
Bmax = Bmin + B->w;
- if (Bmin < Amin)
+ if (Bmin < Amin) {
Amin = Bmin;
+ }
result->x = Amin;
- if (Bmax > Amax)
+ if (Bmax > Amax) {
Amax = Bmax;
+ }
result->w = Amax - Amin;
/* Vertical union */
@@ -180,11 +165,13 @@ SDL_UnionRect(const SDL_Rect * A, const SDL_Rect * B, SDL_Rect * result)
Amax = Amin + A->h;
Bmin = B->y;
Bmax = Bmin + B->h;
- if (Bmin < Amin)
+ if (Bmin < Amin) {
Amin = Bmin;
+ }
result->y = Amin;
- if (Bmax > Amax)
+ if (Bmax > Amax) {
Amax = Bmax;
+ }
result->h = Amax - Amin;
}
@@ -201,9 +188,7 @@ SDL_EnclosePoints(const SDL_Point * points, int count, const SDL_Rect * clip,
if (!points) {
SDL_InvalidParamError("points");
return SDL_FALSE;
- }
-
- if (count < 1) {
+ } else if (count < 1) {
SDL_InvalidParamError("count");
return SDL_FALSE;
}
@@ -330,31 +315,20 @@ SDL_IntersectRectAndLine(const SDL_Rect * rect, int *X1, int *Y1, int *X2,
if (!rect) {
SDL_InvalidParamError("rect");
return SDL_FALSE;
- }
-
- if (!X1) {
+ } else if (!X1) {
SDL_InvalidParamError("X1");
return SDL_FALSE;
- }
-
- if (!Y1) {
+ } else if (!Y1) {
SDL_InvalidParamError("Y1");
return SDL_FALSE;
- }
-
- if (!X2) {
+ } else if (!X2) {
SDL_InvalidParamError("X2");
return SDL_FALSE;
- }
-
- if (!Y2) {
+ } else if (!Y2) {
SDL_InvalidParamError("Y2");
return SDL_FALSE;
- }
-
- /* Special case for empty rect */
- if (SDL_RectEmpty(rect)) {
- return SDL_FALSE;
+ } else if (SDL_RectEmpty(rect)) {
+ return SDL_FALSE; /* Special case for empty rect */
}
x1 = *X1;
@@ -378,8 +352,7 @@ SDL_IntersectRectAndLine(const SDL_Rect * rect, int *X1, int *Y1, int *X2,
return SDL_FALSE;
}
- if (y1 == y2) {
- /* Horizontal line, easy to clip */
+ if (y1 == y2) { /* Horizontal line, easy to clip */
if (x1 < rectx1) {
*X1 = rectx1;
} else if (x1 > rectx2) {
@@ -393,8 +366,7 @@ SDL_IntersectRectAndLine(const SDL_Rect * rect, int *X1, int *Y1, int *X2,
return SDL_TRUE;
}
- if (x1 == x2) {
- /* Vertical line, easy to clip */
+ if (x1 == x2) { /* Vertical line, easy to clip */
if (y1 < recty1) {
*Y1 = recty1;
} else if (y1 > recty2) {
@@ -476,24 +448,16 @@ SDL_GetSpanEnclosingRect(int width, int height,
if (width < 1) {
SDL_InvalidParamError("width");
return SDL_FALSE;
- }
-
- if (height < 1) {
+ } else if (height < 1) {
SDL_InvalidParamError("height");
return SDL_FALSE;
- }
-
- if (!rects) {
+ } else if (!rects) {
SDL_InvalidParamError("rects");
return SDL_FALSE;
- }
-
- if (!span) {
+ } else if (!span) {
SDL_InvalidParamError("span");
return SDL_FALSE;
- }
-
- if (numrects < 1) {
+ } else if (numrects < 1) {
SDL_InvalidParamError("numrects");
return SDL_FALSE;
}