Commit 557d0f827f346a3419ea278a8a479335857bad48

Hanseul Jun 2021-03-11T13:36:56

Commenting a false alarm in WIN_GLES_SetupWindow. When hint SDL_HINT_OPENGL_ES_DRIVER is set to "1" (e.g. for ANGLE support), assertion due to !_this->gl_config.driver_loaded can be causes while EGL is available.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
diff --git a/src/video/windows/SDL_windowsopengles.c b/src/video/windows/SDL_windowsopengles.c
index 93e2317..b066c44 100644
--- a/src/video/windows/SDL_windowsopengles.c
+++ b/src/video/windows/SDL_windowsopengles.c
@@ -108,7 +108,9 @@ WIN_GLES_SetupWindow(_THIS, SDL_Window * window)
     SDL_GLContext current_ctx = SDL_GL_GetCurrentContext();
 
     if (_this->egl_data == NULL) {
-        SDL_assert(!_this->gl_config.driver_loaded);
+        // When hint SDL_HINT_OPENGL_ES_DRIVER is set to "1" (e.g. for ANGLE support),
+        // _this->gl_config.driver_loaded can be 0, while the below lines function.
+        // SDL_assert(!_this->gl_config.driver_loaded);
         if (SDL_EGL_LoadLibrary(_this, NULL, EGL_DEFAULT_DISPLAY, 0) < 0) {
             SDL_EGL_UnloadLibrary(_this);
             return -1;