Commit 6872cb12e67fa6159924406b1b3977158ac30612

Sam Lantinga 2021-11-28T21:10:46

null-terminate the message buffer if FormatMessage() fails

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
diff --git a/src/core/windows/SDL_windows.c b/src/core/windows/SDL_windows.c
index a0c789a..434edd0 100644
--- a/src/core/windows/SDL_windows.c
+++ b/src/core/windows/SDL_windows.c
@@ -45,8 +45,9 @@ WIN_SetErrorFromHRESULT(const char *prefix, HRESULT hr)
     TCHAR buffer[1024];
     char *message;
     TCHAR *p = buffer;
-    FormatMessage(FORMAT_MESSAGE_FROM_SYSTEM, NULL, hr, 0,
+    DWORD c = FormatMessage(FORMAT_MESSAGE_FROM_SYSTEM, NULL, hr, 0,
                   buffer, SDL_arraysize(buffer), NULL);
+    buffer[c] = 0;
     /* kill CR/LF that FormatMessage() sticks at the end */
     while (*p) {
         if (*p == '\r') {