Commit 6bd3e0b189457bb3e0c62e301a0eef650178eeaf
2022-06-15T15:58:48
Test: Check sqrt and atan against the epsilon. On i686-linux, the `sqrt_regularCases` and `atan_limitCases` tests would fail as the result was not precise enough.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40
diff --git a/test/testautomation_math.c b/test/testautomation_math.c
index ad8d70f..8e3d9e5 100644
--- a/test/testautomation_math.c
+++ b/test/testautomation_math.c
@@ -2,8 +2,8 @@
* Math test suite
*/
-#include <math.h>
#include <float.h>
+#include <math.h>
#include "SDL.h"
#include "SDL_test.h"
@@ -1802,7 +1802,7 @@ sqrt_regularCases(void *args)
{ 2887.12782400000014604302123188972473144531250, 53.732 },
{ 65600.0156250, 256.125 }
};
- return helper_dtod("Sqrt", SDL_sqrt, regular_cases, SDL_arraysize(regular_cases));
+ return helper_dtod_inexact("Sqrt", SDL_sqrt, regular_cases, SDL_arraysize(regular_cases));
}
/* SDL_scalbn tests functions */
@@ -2432,12 +2432,14 @@ atan_limitCases(void *args)
double result;
result = SDL_atan(INFINITY);
- SDLTest_AssertCheck(M_PI / 2.0 == result,
+ SDLTest_AssertCheck((M_PI / 2.0) - EPSILON <= result &&
+ result <= (M_PI / 2.0) + EPSILON,
"Atan(%f), expected %f, got %f",
INFINITY, M_PI / 2.0, result);
result = SDL_atan(-INFINITY);
- SDLTest_AssertCheck(-M_PI / 2.0 == result,
+ SDLTest_AssertCheck((-M_PI / 2.0) - EPSILON <= result &&
+ result <= (-M_PI / 2.0) + EPSILON,
"Atan(%f), expected %f, got %f",
-INFINITY, -M_PI / 2.0, result);